D26797: KCM/Component Refactor UI to a single list of combobox

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooser.cpp:80 > + > +if (cfgType==QLatin1String("internal_email")) { > +loadedConfigWidget = new CfgEmailClient(this); I know it's older

D26799: Apply KDE coding style, minor optimizations

alex updated this revision to Diff 73988. alex added a comment. Add parentheses for parameter list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26799?vs=73987=73988 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26799 AFFECTED

D26799: Apply KDE coding style, minor optimizations

alex updated this revision to Diff 73987. alex added a comment. Adjust formatting of lambdas REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26799?vs=73980=73987 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26799 AFFECTED FILES

D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

mlaurent closed this revision. mlaurent added a comment. Done in 2 commits. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26790 To: mlaurent, apol Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart, hein

D26802: [Applet] Focus search field after showing it

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. ngraham requested review of this revision. REVISION SUMMARY ...Otherwise you need to manually click on it after showing it

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

gvgeo added a comment. D26256 removes these two settings. There is nothing for this patch to unify. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26234 To: gvgeo, #vdg, #plasma, drosca Cc: ndavis, meven,

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 73984. ngraham marked an inline comment as done. ngraham added a comment. Better, less disruptive version REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=73795=73984 BRANCH

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

ngraham added a comment. So this isn't needed if we do D26256 ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26234 To: gvgeo, #vdg, #plasma, drosca Cc: ndavis, meven, anthonyfieroni, ngraham, plasma-devel,

T12567: Reduce code/effort duplication around color scheme support

ndavis updated the task description. TASK DETAIL https://phabricator.kde.org/T12567 To: ndavis Cc: plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, ekasprzak, ragreen, domson, michaelh, ahmadsamir, dkardarakos,

D26799: Apply KDE coding style, minor optimizations

meven added a comment. Nice changes. INLINE COMMENTS > filteredfoldermodel.cpp:38 > +{ > +QStringList addTrailingSlashes(const QStringList ) > +{ space ? I am not sure. > kcm.cpp:44 > { > -QStringList defaultFolders() > -{ > -return { QDir::homePath() }; > -} > +inline

D14830: Add "Configure Displays" context menu entry on the desktop

nstefanov added a comment. In D14830#541878 , @GB_2 wrote: > Is there a reason this got abandoned? :/ I wonder too. This feature will be a great improvement. Many Windows users I migrate to Linux first ask where are the Display Settings.

D26799: Apply KDE coding style, minor optimizations

alex created this revision. alex added reviewers: ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The affected files have been reformatted following the KDE coding style (this makes up most of the

D26398: [KCM/Activities] Use KConfigXT in ui

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec73805eb2bf: [KCM/Activities] Use KConfigXT in ui (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73063=73977 REVISION DETAIL

D26797: KCM/Component Refactor UI to a single list of combobox

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wow, such a huge UI improvement. This is a pre-existing issue, but I see duplicate entries in the copy that's built from source in my pde prefix location, which looks pretty

D26797: KCM/Component Refactor UI to a single list of combobox

meven created this revision. meven added reviewers: Plasma, VDG, ngraham, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Refactor UI to a single list of Combobox: - Simplify code REPOSITORY R119

D26717: [App Style KCM] Use QtQuick NewStuff dialogs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6eaff2074093: [App Style KCM] Use QtQuick NewStuff dialogs (authored by gikari). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26717?vs=73755=73974#toc REPOSITORY R119 Plasma Desktop

D26796: [Notifications] When there is only a reply action, show reply field right away

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it more obvious that there is an inline reply rather than having a "Reply" button

D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

apol added a comment. Clearly 2 separate changes and too long line on the commit message. Please split when landing. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26790 To: mlaurent Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham,

D26788: do not needlessly run through Solid::Device::allDevices

This revision was automatically updated to reflect the committed changes. Closed by commit R102:d220002541b2: do not needlessly run through Solid::Device::allDevices (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26788?vs=73929=73967

D26789: find org.kde.kirigami as runtime dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R102:ced4536e510e: find org.kde.kirigami as runtime dependency (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26789?vs=73930=73968 REVISION

D26792: do not show "copy in english" when using C as locale

This revision was automatically updated to reflect the committed changes. Closed by commit R102:87d793d15f60: do not show copy in english when using C as locale (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26792?vs=73933=73969

D26783: Center only during drawing, not the hit rects

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R31 Breeze BRANCH phab/centering REVISION DETAIL https://phabricator.kde.org/D26783 To: mart, #vdg, hpereiradacosta, ndavis Cc: ngraham, plasma-devel, Orage,

D26714: KCM/Component Revamp FileManager UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2e54c4e748ba: KCM/Component Revamp FileManager UI (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73962=73963 REVISION DETAIL

D26731: KCM/Component Revamp Browser config

This revision was automatically updated to reflect the committed changes. Closed by commit R119:05569e53fd3e: KCM/Component Revamp Browser config (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26731?vs=73952=73964 REVISION DETAIL

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. How about this? F7894214: vokoscreen-2020-01-20_23-10-29.mp4 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf Cc: trmdi, filipf, ndavis, plasma-devel,

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73962. meven added a comment. Add copyright mention, add icon for added terminal emulator REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73951=73962 BRANCH filemanager-settings REVISION DETAIL

D26565: KCM/Component Revamp email config

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d1f62c16c878: KCM/Component Revamp email config (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73957=73959 REVISION DETAIL

D26705: KCM/Component Revamp Terminal Emulator UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4a0ba9e02697: KCM/Component Revamp Terminal Emulator UI (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26705?vs=73950=73960 REVISION

D26746: Add active, link, visited, negative, neutral and positive background colors

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:3aaf0ee1d096: Add active, link, visited, negative, neutral and positive background colors (authored by ndavis). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73957. meven added a comment. Avoid indentation level REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73948=73957 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED

D26745: Add active, link, visited, negative, neutral and positive background colors

This revision was automatically updated to reflect the committed changes. Closed by commit R858:ae9c5c088800: Add active, link, visited, negative, neutral and positive background colors (authored by ndavis). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D26743: Add active, link, visited, negative, neutral and positive background colors

This revision was automatically updated to reflect the committed changes. Closed by commit R169:ec44c3880b60: Add active, link, visited, negative, neutral and positive background colors (authored by ndavis). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D26770: [App Style KCM] Hide preview buttons, if previewers are not found

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R119 Plasma Desktop BRANCH hide-preview-buttons REVISION DETAIL https://phabricator.kde.org/D26770 To: gikari, ngraham Cc: ngraham, plasma-devel, Orage,

D26565: KCM/Component Revamp email config

ervin accepted this revision. ervin added inline comments. INLINE COMMENTS > componentchooseremail.cpp:109 > +} > +if (service) { > +// avoid duplicates entry when email clients are present in > mimeapps.list's Added Associations too I really meant if (!service) +

D26783: Center only during drawing, not the hit rects

ngraham added a comment. Works for me. Probably 5.18 material. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26783 To: mart, #vdg, hpereiradacosta, ndavis Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26747: Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a41f69f3512d: Fix typo (authored by alex, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26747?vs=73816=73953 REVISION DETAIL

D26731: KCM/Component Revamp Browser config

meven updated this revision to Diff 73952. meven added a comment. Inversion of variable to check REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26731?vs=73947=73952 BRANCH browser-settings REVISION DETAIL https://phabricator.kde.org/D26731

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73951. meven added a comment. Fix: Save the newly saved selected filemanager in m_currentIndex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73946=73951 BRANCH filemanager-settings REVISION DETAIL

D26705: KCM/Component Revamp Terminal Emulator UI

meven updated this revision to Diff 73950. meven added a comment. Fix: Save the newly saved selected terminal emulator in m_currentIndex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26705?vs=73949=73950 BRANCH terminal-config REVISION DETAIL

D26705: KCM/Component Revamp Terminal Emulator UI

meven updated this revision to Diff 73949. meven marked 3 inline comments as done. meven added a comment. Fix formatting, remove a bad Q_UNUSED REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26705?vs=73750=73949 BRANCH terminal-config REVISION

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73948. meven marked 2 inline comments as done. meven added a comment. Move static variable to a proper namespace block, refactor some code for clarity, fix selecting a newly selected email client REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26731: KCM/Component Revamp Browser config

meven updated this revision to Diff 73947. meven marked an inline comment as done. meven added a comment. Use falkon as default browser when it is installed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26731?vs=73782=73947 BRANCH

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73946. meven added a comment. Correct comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73746=73946 BRANCH filemanager-settings REVISION DETAIL https://phabricator.kde.org/D26714 AFFECTED

D26717: [App Style KCM] Use QtQuick NewStuff dialogs

ngraham added a comment. No objections so far. Sounds like you can land this on the 5.18 branch. REPOSITORY R119 Plasma Desktop BRANCH change-exec (branched from master) REVISION DETAIL https://phabricator.kde.org/D26717 To: gikari, broulik, ngraham Cc: jferrer, #localization,

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

davidedmundson added a comment. > So you oppose preloading of KRunner service, but accept it continuing to run forever awaiting its next use. I don't find this consistent. It's a common lazy-load pattern. Though that extension of closing down would also be a direction I would happily

D26765: Correctly save shortcuts of new Items

This revision was automatically updated to reflect the committed changes. Closed by commit R103:92bbc4735cbc: Correctly save shortcuts of new Items (authored by davidre). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26765?vs=73942=73943 REVISION

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. Could you clarify before/after screenshots? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26720: Cache single image wallpapers locally

trmdi added inline comments. INLINE COMMENTS > image.cpp:503 > +// check the cache > +} else if (QFile::exists(m_cachedWallpaperPath)) { > +m_wallpaperPath = m_cachedWallpaperPath; `QDir::mkpath` is better: https://doc.qt.io/qt-5/qdir.html#mkpath REPOSITORY R120

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

ervin added inline comments. INLINE COMMENTS > kcmkded.cpp:234 > const bool autoloadEnabled = > idx.data(ModulesModel::AutoloadEnabledRole).toBool(); > +m_model->setData(idx, > autoloadEnabled,ModulesModel::AutoloadEnabledSavedRole); > KConfigGroup cg(, >

D26765: Correctly save shortcuts of new Items

davidre updated this revision to Diff 73942. davidre added a comment. Now based on 5.18 branch REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26765?vs=73874=73942 BRANCH newitems (branched from master) REVISION DETAIL

D26731: KCM/Component Revamp Browser config

ervin added inline comments. INLINE COMMENTS > meven wrote in componentchooserbrowser.cpp:79 > Do we want to set falkon or konqueror as default ? If any it'd be falkon I think REPOSITORY R119 Plasma Desktop BRANCH browser-settings REVISION DETAIL https://phabricator.kde.org/D26731 To:

D26705: KCM/Component Revamp Terminal Emulator UI

ervin added inline comments. INLINE COMMENTS > componentchooserterminal.cpp:46 > > -void CfgTerminalEmulator::configChanged() > -{ > - emit changed(true); > +void CfgTerminalEmulator::selectTerminalEmulator(int index) { > +Q_UNUSED(index) Curly brace should be on its own line >

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

bport added inline comments. INLINE COMMENTS > meven wrote in modulesmodel.cpp:222 > Inserted twice, line 219 Yes I insert it twice first one is for autoenable value (that will change when we check or uncheck entry), and the second one is the base value to know if data are dirty or not.

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

bport updated this revision to Diff 73937. bport added a comment. Fix apply button state after saving a first time REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26784?vs=73924=73937 REVISION DETAIL https://phabricator.kde.org/D26784 AFFECTED

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:175 > // round necessary, otherwise shadow mask for players has gap! > -height: Math.round(0.5 * width) + (!winTitle.visible? > winTitle.height : 0) > +height: Math.round(0.5 * width) +

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 73935. trmdi added a comment. - hasPlayer-tooltips shouldn't disappear when the mouse is inside the bottom margin of the tooltip REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73876=73935 BRANCH

D26792: do not show "copy in english" when using C as locale

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY qlocale differentiates LANG=C from LANG=en_US for us it is though as the native untranslated strings are english, so when

D26565: KCM/Component Revamp email config

ervin added inline comments. INLINE COMMENTS > componentchooseremail.cpp:67 > } > +static const char s_AddedAssociations[] = "Added Associations"; > +static const auto s_mimetype = QStringLiteral("x-scheme-handler/mailto"); Not a huge fan of static consts appearing like this in the middle of

D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

mlaurent created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Make it compile without deprecated method (qt5.15) REPOSITORY R169 Kirigami BRANCH make_it_compile_qt5.15 (branched from

D26789: find org.kde.kirigami as runtime dependency

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY without it the energy and indexer modules won't work. BUG: 403011 FIXED-IN: 5.18.0 TEST

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

meven added inline comments. INLINE COMMENTS > modulesmodel.cpp:222 > +immutable, > +autoloadEnabled > }; Inserted twice, line 219 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26784 To: bport, ervin, crossi, meven, broulik

D26788: do not needlessly run through Solid::Device::allDevices

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY allDevice is bugging out and having duplicated entires https://bugs.kde.org/show_bug.cgi?id=416495 this results in garbage in our

D26785: cleanup devinfo header includes

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY these were so exhaustive they loop included each other. move everything that isn't required in a header to their respective cpp.

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

bport created this revision. bport added reviewers: ervin, crossi, meven, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY - Reset and apply button are not activated anymore if we change twice state of

Notes from 20/1/2020 monday meeting

Kai Uwe plasma-browser-integration: * Attempted again to upload it to Opera store but their review process is super annoying and not worth my time * Media Controller now supports a "proxy process", i.e. plasma-browser-integration is preferred over Chrome's built-in broken MPRIS, if available

D26655: show a thin separator between view and scrollbar

mart added a comment. In D26655#595380 , @hpereiradacosta wrote: > Yeah. I think one has to go this second way, to avoid the 1 pixel color flicker noted by Noah: scrollbar hover without handle hover. D26783

D26783: center only when to draw, not the hit rects

mart created this revision. mart added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY center only the drawing of the components but never modify the subcontrolrects (and hit targets) TEST PLAN

D26777: [App Style KCM] Port away from QDBusInterface

gikari added a comment. In D26777#597167 , @apol wrote: > Why don't you just export the interface you are using through qdbusxml2cpp and viceversa? This way you don't need to have the glue code. 1. This introduces build-time

D26773: Added option to blur background on active window

mart added a comment. I'm not sure about this. this looks like a nice playful addon i would expect from the KDE store, but not something in the default at all. As usual, this actually shows the need to have a nice framework for a "base" image wallpaper that then can be expanded in many

D26574: [Applet]Hide hamburger menu when empty

gvgeo updated this revision to Diff 73922. gvgeo added a comment. Rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26574?vs=73241=73922 BRANCH menu3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26574

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 73921. gvgeo added a comment. Rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=73240=73921 BRANCH mute2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418

D26256: [Applet] Make 'raise maximum volume' global

gvgeo updated this revision to Diff 73920. gvgeo added a comment. Raise maximum volume has the potential to aid in speaker blowout. Although this requires a system not properly configured (an amplifier too powerful with no limiter). I expect this to be the case only with DIY audio setups.

D26743: Add active, link, visited, negative, neutral and positive background colors

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. This is ok, but is missing a piece. this should be reflected also in qqc2-desktop-style/kirigami-plasmadesktop-integration/plasmadeksotptheme.cpp or it won't actually follow the

D26271: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 73919. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26271?vs=73238=73919 BRANCH layout2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26271

D9875: Extend parsing ssh prompt

This revision was automatically updated to reflect the committed changes. Closed by commit R105:e19146459b1e: Extend parsing ssh prompt (authored by pali, committed by fvogt). REPOSITORY R105 KDE SSH Password Dialog CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9875?vs=73912=73914

D9875: Extend parsing ssh prompt

fvogt updated this revision to Diff 73912. fvogt added a comment. Rebased CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9875?vs=32670=73912 REVISION DETAIL https://phabricator.kde.org/D9875 AFFECTED FILES src/main.cpp To: fvogt, pali, lbeltrame Cc: lbeltrame, ngraham, fvogt,

D9875: Extend parsing ssh prompt

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Just because the "accept" flag was cleared. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: fvogt, pali, lbeltrame Cc: lbeltrame,

D9875: Extend parsing ssh prompt

fvogt added a comment. I'll just land this now... REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: pali, fvogt Cc: ngraham, fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,