D28154: Add users KCM

cblack added inline comments. INLINE COMMENTS > broulik wrote in ChangePassword.qml:67 > How does that work? Holdover from an older version. You can look through the history of https://invent.kde.org/cblack/userkcm-ng/ to see when it actually worked. > broulik wrote in user.cpp:189 > Can you

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 04:56:20 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 125 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/125/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 04:56:19 + Build duration: 56 sec and counting CONSOLE OUTPUT [...truncated 233

D28154: Add users KCM

cblack updated this revision to Diff 78135. cblack marked 53 inline comments as done. cblack added a comment. Address some feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=78110=78135 BRANCH cblack/userkcm-ng (branched from

D28176: Implement Keyboard Keycode support as suggested in the spec

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Makes it possible to send keyboard events TEST PLAN Used it with my joyclick test app REPOSITORY R838 Flatpak Support: KDE Portal

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 00:12:02 + Build duration: 1 hr 7 min and counting CONSOLE OUTPUT

Please watch build statuses of dependent projects (was: Re: Manner in which kde-gtk-config development is conducted)

In data sabato 21 marzo 2020 01:31:40 CET, Ben Cooksley ha scritto: > Plasma community in general until I raised the matter by commenting on > the original review - several days after the fact. I take the opportunity to ask reviewers who review changes to watch for the impact of such changes on

Re: KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

On Fri, Mar 20, 2020 at 7:06 AM David Edmundson wrote: > > I investigated this (slightly) it seems these are false positives. Hi David, > > A new method was introduced in kcrash, that symbol is exported, then this > fails to link. > It implies this is just the CI system linking against an old

Manner in which kde-gtk-config development is conducted

Hi all, In recent days the repository `kde-gtk-config` has had a string of issues with the CI system which raises serious questions concerning the development practices of this project. The first violation was a compilation failure introduced following the commit of changes in

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 124 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/124/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 00:12:01 + Build duration: 59 sec and counting CONSOLE OUTPUT [...truncated 233

D28154: Add users KCM

The-Feren-OS-Dev added a comment. For the lack of text on Full Name, is there any chance some hint text could appear in the full name text box when the textbox value is empty saying something along the lines of "Full Name" or something? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28172: [applets/digital-clock] Fix date sizing in vertical panel

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch fixes several errors in the code: - The property is named

D28154: Add users KCM

davidedmundson added a comment. > Since the new KCM's name (kcm_user) does natch the name of the old one (user_manager) this will require a change in System Settings to actually make it appear. Also for some reason it does not show up to kcmshell list: The names need to match, otherwise

D28154: Add users KCM

davidedmundson added a comment. I can't see any saving to "~/.face.icon" this is needed for legacy compatibility with other systems that don't use accounts service. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham

D28154: Add users KCM

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +add_definitions(-DTRANSLATION_DOMAIN=\"plasmauser-kcm\") > + This must match the `KAboutData` name (which is `kcm_user`) and what `Messages.sh` is actually extracting into. > ChangePassword.qml:29 > + >

D28154: Add users KCM

nicolasfella added a comment. Couple of nitpicks, mostly coding style and most of that probably comes from me. Can't say much otherwise since I wrote quite a bit of it INLINE COMMENTS > main.qml:100 > +Component.onCompleted: () => { > +print("compl") >

D28154: Add users KCM

nicolasfella added a comment. > I seem to recall seeing that on a rough early version of @nicolasfella's version. That's the most urgently needed feature. I'm pretty sure I did no such thing and I also think it's not super important REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#631358 , @ngraham wrote: > If you're okay with me modifying the UI in a follow-up patch, I'll accept the UI in its current form. Is that acceptable? Thats the intention of all this - get it in a usable

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. TODO: T12840 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

Re: 2 kirigami fixes for a point release

On vendredi 20 mars 2020 12:16:09 CET David Edmundson wrote: > >> > Kirigami seems to be rather unstable, I wonder if anything can be done > >> > to > >> > improve upon that [*]. > >> > >> One important thing seems to have been getting sloppy in those repos; > >> mandatory code reviews. > >>

D27166: Refactor converter runner

alex updated this revision to Diff 78121. alex added a comment. Implement actions for copying results Also the icon for the matches has been changed: In the .desktop file it is accessories-calculator, but in for the matches edit-copy was used. And displaying the same icon three times in

D27166: Refactor converter runner

broulik added a comment. Sounds good! :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27166: Refactor converter runner

alex added a comment. If the match type gets set to InformationalMatch the run method will never be called (that is how it was before and for me it makes more sense this way). What about setting the type to InformationalMatch and adding a copy action? This way the old behavior is the

D28167: Let Discover take the frequency of automatic update checks from apt.

eliac created this revision. eliac added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. eliac requested review of this revision. REVISION SUMMARY BUG: 419055 Currently `PackageKitNotifier` attempts to check the frequency by

D27166: Refactor converter runner

broulik added a comment. I just noticed another minor issue: when I activate a result with the old one it would copy the value into the text field, i.e. I type "5 EUR", select the 4.55 GBP result and then it would copy 4.55 into the text field. This is done for `InformationalMatch` types,

D28154: Add users KCM

cblack added a comment. In D28154#631371 , @filipf wrote: > I'm strongly in favor of removing the autologin option from this KCM. The option only applies to SDDM so it should be in SDDM's settings.  In D28154#631355

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78117. apol added a comment. This revision is now accepted and ready to land. Fix it in a theoretically better but more convoluted way REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=77929=78117 BRANCH master

D28142: Display PID & signal numbers unlocalized

This revision was automatically updated to reflect the committed changes. Closed by commit R871:af4cd7a4cf5f: Display PID signal numbers unlocalized (authored by kossebau). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28142?vs=78022=78116 REVISION DETAIL

D28154: Add users KCM

filipf added a comment. I'm strongly in favor of removing the autologin option from this KCM. The option only applies to SDDM so it should be in SDDM's settings. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc:

D28166: Add support for power sensors from lm-sensors

raghuraman created this revision. raghuraman added a reviewer: mlaurent. raghuraman created this object with edit policy "Administrators". Herald added a project: Plasma. Herald added a subscriber: plasma-devel. raghuraman requested review of this revision. REVISION SUMMARY Some AMD GPUs do

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Yes, it's true that our UIs are frequently inconsistent; that's why the #consistency goal exists. A big part of this goal is to improve the usability of common components like the Kirigami SwipeListItem so that

D28154: Add users KCM

ngraham added subscribers: nicolasfella, ngraham. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Nice, this KCM was in desperate need of a rewrite. I've got some concerns though: Since the new KCM's name (`kcm_user`)

D26956: Remove export header from static install

jbbgameich added a comment. @apol is your question answered now / can I land this? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26956 To: masonm, #kirigami, mart, apol Cc: jbbgameich, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D28148: Fix broken paths in kirigami.qrc.in

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9949457f31ba: Fix broken paths in kirigami.qrc.in (authored by masonm, committed by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28154: Add users KCM

cblack updated this revision to Diff 78110. cblack added a comment. Drop executable bits REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=78062=78110 BRANCH cblack/userkcm-ng (branched from master) REVISION DETAIL

D27166: Refactor converter runner

alex marked 7 inline comments as done. alex added a comment. I don't have developer access, but I applied for it yesterday :-). REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage,

D27166: Refactor converter runner

broulik accepted this revision. broulik added a comment. Ship it! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28143: Add "veryLongDuration" animation duration

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8427e8eaa037: Add veryLongDuration animation duration (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28143?vs=78037=78101 REVISION DETAIL

D28143: Add "veryLongDuration" animation duration

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. sorry, didn't see the other one REPOSITORY R169 Kirigami BRANCH veryLongDuration (branched from master) REVISION DETAIL https://phabricator.kde.org/D28143 To: ngraham, #vdg, #kirigami,

D28143: Add "veryLongDuration" animation duration

davidre added a comment. Also needs adding in plasma In D28143#631225 , @mart wrote: > a problem tough.. this one won't follow system settngs, so globally disabling anoimations won't disable this one > it also needs implementing in

D28143: Add "veryLongDuration" animation duration

mart added a comment. a problem tough.. this one won't follow system settngs, so globally disabling anoimations won't disable this one it also needs implementing in plasma-framework/src/declarativeimports/kirigamiplasmadesktopstyle/ (where takes values from units.cpp in plasma units,

D27166: Refactor converter runner

alex updated this revision to Diff 78100. alex added a comment. Always display two decimals in currency conversion, set ENV variable in test REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=78098=78100 BRANCH converter_runner_refactoring

D27166: Refactor converter runner

broulik added a comment. Very nice! There's two minor nitpicks but then I think it should be good to go, thanks for your endurance :) INLINE COMMENTS > converterrunnertest.cpp:50 > +{ > +setlocale(LC_ALL, "C.utf8"); > +runner = new ConverterRunner(this, QVariantList()); This

D27166: Refactor converter runner

alex updated this revision to Diff 78098. alex added a comment. Rewrite query parsing, fix case sensitive units, add tests for these issues REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=78016=78098 BRANCH converter_runner_refactoring

D28158: [Cursor Theme KCM] Use standardized pointer and help cursor for preview

This revision was automatically updated to reflect the committed changes. Closed by commit R119:10c1a42b2cbf: [Cursor Theme KCM] Use standardized pointer and help cursor for preview (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28158: [Cursor Theme KCM] Use standardized pointer and help cursor for preview

ngraham accepted this revision. ngraham added a comment. stable branch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28158 To: broulik, #plasma, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28098: remove pointless and arbitrary 4 line frame limit

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R871:80efb36bc807: remove pointless and arbitrary 4 line frame limit (authored by sitter). REPOSITORY R871 DrKonqi

D27509: Introduce ProcessDataModel

davidedmundson updated this revision to Diff 78091. davidedmundson added a comment. cache kuser REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=78089=78091 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27509 AFFECTED

D28026: further constrict line parsing of .so files

ahmadsamir added inline comments. INLINE COMMENTS > backtraceparsergdb.cpp:75 > if (!regExp.cap(7).isEmpty()) { //we have file information (stuff > after from|at) > bool file = regExp.cap(8) == QLatin1String("at"); //'at' means > we have a source file (likely) >

D27509: Introduce ProcessDataModel

davidedmundson updated this revision to Diff 78089. davidedmundson added a comment. cache kuser REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=78025=78089 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27509 AFFECTED

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 18 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/18/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 20 Mar 2020 11:34:38 + Build duration: 4 min 16 sec and counting JUnit Tests Name:

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 11:34:38 + Build duration: 3 min 29 sec and counting JUnit Tests Name:

Re: 2 kirigami fixes for a point release

>> > Kirigami seems to be rather unstable, I wonder if anything can be done to >> > improve upon that [*]. > >> One important thing seems to have been getting sloppy in those repos; >> mandatory code reviews. >> That's an easy thing to enforce, and we know it makes a huge difference to >> code. >>

D27576: Kill Runner: Move config keys to new file

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Minor nitpick So the code basically extracts from KillRunnerConfigForm the Config constants. INLINE COMMENTS > killrunner.cpp:65 > > -m_sorting = (KillRunnerConfig::Sort)

KDE CI: Plasma » ksysguard » kf5-qt5 SUSEQt5.12 - Build # 121 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20SUSEQt5.12/121/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 10:31:32 + Build duration: 5 min 31 sec and counting JUnit Tests Name: (root)

D28134: Add ColorUtils

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. please no item grabbing in the singlethon. item grabbing is *not* stateless REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 78080. ahiemstra added a comment. - Properly install the export header REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=78020=78080 BRANCH sensors_lib REVISION DETAIL

D28137: make servicerunner only build once

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d03f98e782c3: make servicerunner only build once (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28137?vs=77999=78076 REVISION

D28156: [Dialog] Use `ShadowedRectangle`

This revision was automatically updated to reflect the committed changes. Closed by commit R858:eecb8f6402e8: [Dialog] Use `ShadowedRectangle` (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D28142: Display PID & signal numbers unlocalized

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I guess a localized number would be one with a thousand separator?  REPOSITORY R871 DrKonqi BRANCH fixpiddisplay REVISION DETAIL https://phabricator.kde.org/D28142 To: kossebau,

KDE CI: Plasma » ksysguard » kf5-qt5 SUSEQt5.12 - Build # 120 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20SUSEQt5.12/120/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 09:51:44 + Build duration: 39 sec and counting CONSOLE OUTPUT [...truncated 429

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 78074. meven marked 13 inline comments as done. meven added a comment. Address review, use Q_GLOBAL_STATIC_WITH_ARGS, move AutostartModel::sourceFromInt to cpp, code formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28158: [Cursor Theme KCM] Use standardized pointer and help cursor for preview

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY According to XDG cursor spec [1] the names are "pointer" and "help" for the pointing hand and

D28154: Add users KCM

zzag added a comment. Some files have the executable bit on, e.g. kcms/users/CMakeLists.txt. 755 -> 644. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27669: [kstyle] Tools area

niccolove added a comment. If possible, I think that supporting toparea transparency with those colorscheme would be a great feature for people who would like plasma to look like this (see below), as they would only need to change colorscheme. F8185993: image.png

D28156: [Dialog] Use `ShadowedRectangle`

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of expensive DropShadow layer. TEST PLAN I only just now found a place where it's

D27669: [kstyle] Tools area

davidre added a comment. Some colorschemes do have transparent titlebars, do you plan to support transparency or leave it as is? F8185862: Screenshot_20200320_090510.PNG To support apps that have another color schemes than the global one look at