Re: Plasma 6.0.1

Hi, Am Mittwoch, 6. März 2024, 00:38:54 CET schrieb Jonathan Riddell: > Plasma 6.0.1 is out now for packaging and distributing > https://kde.org/announcements/plasma/6.0.1/ URL is broken, it's https://kde.org/announcements/plasma/6/6.0.1/. Also, kpipewire fails to build because there's a syntax

Re: Plasma 5.26.3: Breeze is broken

Hi, Am Dienstag, 8. November 2022, 15:28:54 CET schrieb Jonathan Riddell: > Plasma 5.26.3 is now released https://kde.org/announcements/plasma/5/5.26.3 At least breeze has the wrong version in its CMakeLists.txt: set(PROJECT_VERSION "5.26.2") This means that plasma-workspace will silently ignor

Re: Plasma 5.24.2

Moin, Am Dienstag, 22. Februar 2022, 14:56:11 CET schrieb Jonathan Riddell: > Plasma 5.24.2 is now released https://kde.org/announcements/plasma/5/5.24.2 It appears like plasma-mobile-5.24.2.tar.xz is missing translations, like with 5.24.1 already. Cheers, Fabian

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 21:54:13 CET schrieb Fabian Vogt: > Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > > The first URL is used by kfontinst.knsrc from plasma-workspace: > &

[plasma/plasma-workspace/Plasma/5.24] kcms/kfontinst/kcmfontinst: Use the correct endpoint for this - hosted by a CDN and therefore capable of handling much greater volumes of traffic.

Git commit fb5656eaf2e021e6a9288edd00573c14afe6e115 by Fabian Vogt, on behalf of Ben Cooksley. Committed on 07/02/2022 at 11:09. Pushed by fvogt into branch 'Plasma/5.24'. Use the correct endpoint for this - hosted by a CDN and therefore capable of handling much greater volumes

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > The first URL is used by kfontinst.knsrc from plasma-workspace: > > ProvidersUrl=https://distribute.kde.org/khotnewstuff/fonts-providers.xml > >

Re: Critical Denial of Service bugs in Discover

Hi, Am Samstag, 5. Februar 2022, 22:16:28 CET schrieb Ben Cooksley: > Hi all, > > Over the past week or so Sysadmin has been dealing with an extremely high > volume of traffic directed towards both download.kde.org and > distribute.kde.org. > > This traffic volume is curious in so far that it is

Re: Fwd: Consistent CMake requirements in Plasma

Moin, Am Mittwoch, 24. Februar 2021, 14:40:08 CET schrieb Nicolas Fella: > Hi packagers, > > I recently proposed to formalize that Plasma depends on CMake 3.16. The > reasoning is to 1) make the requirements consistent across Plasma repos > and 2) enable the use of modern CMake features. If accpe

Re: Relicensing Plasma Browser Integration Host to GPLv3+

e following people (and myself) touched that folder: > > David Edmundson > Fabian Vogt > Laurent Montel > Friedrich W. H. Kossebau > Matthijs Tijink > > Are you fine with this, or have any other comments? I'm fine with GPL-3.0-or-later, yes. Cheers, Fabian > Cheers > Kai Uwe > > (Should probably do some REUSE porting as part of this, too ;)

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. I just tried that here and it works fine (Qt 5.15.1). Maybe there's something else in the environment which breaks it? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: memeplex, anthonyfieroni, luxus, snugghash, gla

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. In D12405#676733 , @memeplex wrote: > So I set QT_SCREEN_SCALE_FACTORS='eDP-1=2;DP-2=1.7;'. But consider: > > 1. QT_AUTO_SCREEN_SCALE_FACTOR=1 QT_SCREEN_SCALE_FACTORS='eDP-1=2;DP-2=1.7;' konsole > 2. QT_AUTO_SCREEN_SC

D9875: Extend parsing ssh prompt

fvogt closed this revision. fvogt added a comment. FTR: https://invent.kde.org/plasma/ksshaskpass/-/merge_requests/2 REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: fvogt, pali, lbeltrame Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel,

D9875: Extend parsing ssh prompt

fvogt added a comment. In D9875#675107 , @mkoller wrote: > They did not overwrite each other since the entry for the Username holds an URL _without_ user but the password entry did. That's pretty fragile, but would need to be kept for comp

D9875: Extend parsing ssh prompt

fvogt added a comment. In D9875#675101 , @mkoller wrote: > This patch breaks usage for git (and probably others): > git first asks for a "Username for 'https:" which leads to ksshaskpass open the input dialog but the typed-in user > is n

D29533: [Reminder] Also advert Chromie store for Vivaldi

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. "Chromie"? :D For some reason I can't get the reminder to trigger. `dbus-monitor` shows method call time=1588952594.025913 sender=:1.16 -> destination=org.kde.Activi

D28926: Signal player gone in "pagehide" not "beforeunload"

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Didn't test myself, but apparently you did, so LGTM. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28926 To: broulik, #plasma, fvogt, ognarb Cc:

D28936: Use a Proxy object to detect changes within the MediaMetadata

fvogt added a comment. In D28936#656422 , @broulik wrote: > > this doesn't catch something like this > > Yeah it doesn't. I thought I could "monitor" an Object but the caller actually has to //use// the Proxy for it to detect anything :/ >

D28936: Use a Proxy object to detect changes within the MediaMetadata

fvogt added a comment. AFAICT (take with a grain of salt, I'm a JS n00b) this doesn't catch something like this: let a = {}; navigator.mediaSession.metadata = a; a["foo"] = "bar"; And behaves weirdly if you do: let a = navigator.mediaSession.metadata; navigator.m

D28658: [krdb] Drop GTK2 colour exporting

fvogt added a comment. > FIXED-IN: 5.19.0 (or should we consider this a bugfix and land it on the stable branch?) At least in openSUSE we'll backport it to Plasma 5.18, but it might not be the kind of behaviour change desired in 5.18 at this point in time... REPOSITORY R119 Plasma Des

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. > Repository R120 Plasma Workspace How did that happen? > Should we include "ftp"? I'd say yes, together with `ftps`

D28853: krunner: Prevent regression

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a28e110cbb15: krunner: Prevent regression (authored by apol, committed by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28853?vs=80192&id=80371 R

D28853: krunner: Prevent regression

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Proper fix with refactoring will take too long, let's take this for now. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28853 To: apol, #p

D28893: Detect Vivaldi based on binary name

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested, works. I didn't even notice that it broke... Will probably have to be refactored later to look at `environmentDescriptions` or `environmentNames` though. > Should be good for

D28791: Manually merge stored and default settings

fvogt accepted this revision. fvogt added inline comments. INLINE COMMENTS > fvogt wrote in utils.js:39 > Why not if/else? I'd invert the condition REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28791 To: broulik, #plasma, fvogt Cc: plasma-devel, O

D28791: Manually merge stored and default settings

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Just have to make sure not to add anything to `DEFAULT_EXTENSION_SETTINGS.mpris.websiteSettings` now. Previously that would've been ignored. INLINE COMMENTS > utils.js:39 > +

D28709: Implement executeScript for Firefox

fvogt added a comment. In D28709#645296 , @broulik wrote: > I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the s

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Looks fragile, but I don't have a better idea either. https://bugreports.qt.io/browse/QTBUG-56761 sigh REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.

D28705: Don't consider player gone when it only got temporarily added by us

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. In D28705#645038 , @broulik wrote: > Yeah, wondering the same... maybe it didn't. Anyway this also fixes Spotify's previous/next buttons not wor

D28709: Implement executeScript for Firefox

fvogt abandoned this revision. fvogt added a comment. https://bugzilla.mozilla.org/show_bug.cgi?id=1591983 :-( I guess spotify had `unsave-eval`, but not `unsafe-inline`, so this method just breaks different pages... Apparently it's possible to add a `script` element with ´src="moz-

D28709: Implement executeScript for Firefox

fvogt added a comment. I just tried this with google translate on FF ESR 68(.1.0 IIRC) and it worked, but there was an error about the content security policy having blocked an eval. The error is gone if the extension is disabled. So this needs a test with spotify/nextcloud. Do you have any

D28709: Implement executeScript for Firefox

fvogt added a comment. I'm not sure about the `// Firefox enforces Content-Security-Policy also for scripts injected by the content-script` part, but I'm not sure how to test it. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #pl

D28706: Restore old Audio prototype after exportFunction

fvogt added a comment. D28709 conflicts/supersedes this now. `window.Audio.prototype != Audio` is a separate issue though, which might still need fixing. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28706

D28709: Implement executeScript for Firefox

fvogt added a comment. Note: Remains to be tested on non-firefox and old firefox ESR. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28709: Implement executeScript for Firefox

fvogt updated this revision to Diff 79729. fvogt added a comment. Use full URL in comment REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28709?vs=79728&id=79729 BRANCH ffeval REVISION DETAIL https://phabricator.kde.org/D28709 AFFEC

D28709: Implement executeScript for Firefox

fvogt created this revision. fvogt added reviewers: Plasma, broulik. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY window.eval is exactly what we need, so we can drop the Firefox specific replacements like calls to exportFunction. TEST PLAN Restar

D28706: Restore old Audio prototype after exportFunction

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. I can't find a better way to do this either... Some notes: - `window.eval` works as expected so if not entirely unlucky (old firefox?) this can be replaced by using `executeScript` c

D28705: Don't consider player gone when it only got temporarily added by us

fvogt added a comment. In D28705#644982 , @broulik wrote: > It worked on Chrome, and the properties can be accessed from the same context. > It's just that the mutation.removedNodes loop above which is in content script cannot access those JS

D28705: Don't consider player gone when it only got temporarily added by us

fvogt added a comment. So was the case handled by line 805 completely broken? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28705 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D26185: Also disable automatic scaling on Qt >= 5.14

fvogt added a comment. That sounds like a Qt bug, which fails to use the `QT_SCREEN_SCALE_FACTORS` value for pixmaps for some reason. Is it a multi-monitor setup? Can you open a new issue with details and a screenshot? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator

D28614: Add better player tab crash handling

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. For false positives the player would get added again by the `playing` event, which is not ideal, but as it doesn't require a reload it's IMO close enough. REPOSITORY R856 Plasma Browser Int

D28614: Add better player tab crash handling

fvogt added a comment. In D28614#642630 , @broulik wrote: > > If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? > > I believe whenever a player starts playing agai

D28614: Add better player tab crash handling

fvogt added a comment. If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack Cc: p

D28134: Add ColorUtils

fvogt added inline comments. INLINE COMMENTS > colorutils.cpp:90 > +}); > +} > + If item is neither of those three, it would never call `pending->setValue` at all > colorutils.cpp:103 > + > +if (pending->value().isValid()) { > + pending->setValue(luma(result->value().va

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

This revision was automatically updated to reflect the committed changes. fvogt marked an inline comment as done. Closed by commit R111:ba7f78716af6: Only link to Qt5WebChannel if Qt5WebEngineWidgets available (authored by fvogt). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE h

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt marked an inline comment as done. fvogt added inline comments. INLINE COMMENTS > lbeltrame wrote in CMakeLists.txt:86 > Should you add a message in case one of the two is not found? In that case `WEBENGINE_SCRIPTING_ENABLED` is `FALSE` and it'll print that `Scripting plugin support` is no

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt updated this revision to Diff 76750. fvogt added a comment. This revision is now accepted and ready to land. Treat scripting as a feature instead REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27347?vs=75550&id=76750 BRANCH Plasma/5.18 R

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt added a comment. Currently `processui/scripting.cpp` has this: #if HAVE_QTWEBENGINEWIDGETS #include ... #endif So `Qt5WebEngineWidgets` without `Qt5WebChannel` will fail to build and `Qt5WebChannel` without `Qt5WebEngineWidgets` leads to scripting support gettin

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt planned changes to this revision. fvogt added a comment. I need some input on how to express `HAVE_QTWEBENGINEWIDGETS` with this. Currently it would fail to build if `Qt5WebEngineWidgets` is installed but `Qt5WebChannel` isn't. REPOSITORY R111 KSysguard Library REVISION DETAIL htt

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#618310 , @jgrulich wrote: > In D27643#618132 , @fvogt wrote: > > > In D27643#618125 , @jgrulich wrote: > > > > > I have

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#618125 , @jgrulich wrote: > I have never used fuse. I see you can use kio-fuse over dbus to mount a file, but you still have to unmount it, which will be a problem, because from the portal I don't know whether th

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#617558 , @ngraham wrote: > Shouldn't KIO take care of this stuff automatically? I wouldn't want to lose streaming support for Flatpak apps. It should, but there's no API for that yet. At some point th

D27358: Sync ("Wayland") appending to match SDDM

fvogt added a comment. Note that this behaviour of sddm is not in any release yet - only in git. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27358 To: davidedmundson, #plasma, ngraham Cc: fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-

D27457: Move kcminit_startup and kded to plasma-session

fvogt added a comment. As there's no reason to clear the environment, wouldn't it be more useful if `StartServiceJob` would only allow adding/overwriting variables? `StartProcessJob` does not need an option to set the environment at all AFAICT. REPOSITORY R120 Plasma Workspace REVISION

D27457: Move kcminit_startup and kded to plasma-session

fvogt added inline comments. INLINE COMMENTS > davidedmundson wrote in startup.cpp:211 > StartProcessJob I think is fine. It's not set, so it'll inherit. > > It's the extra arg to StartServiceJob that has potential to wipe the env. > > It defaults to empty > > and we do p->setEnvironment(m

D27457: Move kcminit_startup and kded to plasma-session

fvogt reopened this revision. fvogt added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > startup.cpp:211 > +const QVector sequence = { > +new StartProcessJob(QStringLiteral("kcminit_startup"), {}), > +new StartServiceJob(QStringLiteral("kde

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY QWebChannel is only used if HAVE_QTWEBENGINEWIDGETS is set. WIP as I'm not show how to express HAVE

D26947: Drop kconf_update module, handled by kde-gtk-config now

This revision was automatically updated to reflect the committed changes. Closed by commit R98:5250ab3baa3a: Drop kconf_update module, handled by kde-gtk-config now (authored by fvogt). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26947?vs=7&id=750

D26842: Fix fonts KCM button state

fvogt closed this revision. fvogt added a comment. In D26842#605850 , @bport wrote: > In D26842#605839 , @fvogt wrote: > > > Does this mean the default fonts have a style name of "Regular" now? That

D26842: Fix fonts KCM button state

fvogt reopened this revision. fvogt added a comment. This revision is now accepted and ready to land. Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070. REPOSITORY R119 Plasma Desktop REVI

D26891: Upgrade theme to Breeze GTK on startup

fvogt accepted this revision. fvogt added a comment. In D26891#605464 , @ngraham wrote: > LGTM now. @meven and @fvogt, you good with this too? Not sure what the rename was about, but yes, still LGTM. REPOSITORY R99 KDE Gtk Configuration

D26891: Upgrade theme to Breeze GTK on startup

fvogt added a comment. The only remaining question from my side is why we have four different gtk configuration files and whether that causes issues. Besides that, only @meven's comment needs a resolution. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kd

D26947: Drop kconf_update module, handled by kde-gtk-config now

fvogt added a comment. In D26947#601517 , @ngraham wrote: > 5.18 I suppose? Yes, once D26891 landed. REPOSITORY R98 Breeze for Gtk BRANCH nokconf_update REVISION DETAIL https://phabricator.kde.

D26947: Drop kconf_update module, handled by kde-gtk-config now

fvogt created this revision. fvogt added reviewers: Plasma, gikari. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY D26891 introduces a kconf_update script which achieves the same. TEST PLAN Ran make, no kconf_upd

D26891: Upgrade theme to Breeze GTK on startup

fvogt added a comment. Tested, confirmed to work. I wonder what's up with the gtkrc files everywhere: ~/.config/gtkrc-2.0 ~/.config/gtkrc ~/.gtkrc-2.0 ./.config/gtk-3.0 It seems like the first two are created by krdb, does it read both still? REPOSITORY R99 KDE G

D26942: Fix kwin.upd not running if python 2 not installed

This revision was automatically updated to reflect the committed changes. Closed by commit R108:53af330d8f3e: Fix kwin.upd not running if python 2 not installed (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26942?vs=74432&id=74435 REVISION

D26942: Fix kwin.upd not running if python 2 not installed

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: KWin. Herald added a subscriber: kwin. fvogt requested review of this revision. REVISION SUMMARY If the listed interpreter does not exist, kconf_update skips the update. The update script uses python3, so decl

D26891: Upgrade theme to Breeze GTK on startup

fvogt added inline comments. INLINE COMMENTS > gtkconfig.cpp:207 > setEnableAnimations(); > +setDefaultGtk2Theme(); > +setDefaultGtk3Theme(); Now those two aren't needed anymore? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To:

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. In D26891#600837 , @gikari wrote: > @fvogt Do I understand correctly, that `kconf_update` script also run on Plasma update, if I add a new `Id` to one of .upd file (or add one with new `Id`)? For example from 5.17 to 5.18?

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. In D26891#600285 , @gikari wrote: > In D26891#600210 , @fvogt wrote: > > > It should only do the migration once, like the kconf_update script. > > > From where migration s

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. In D26891#600264 , @gikari wrote: > In D26891#600210 , @fvogt wrote: > > > If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa, it should be possible to drop the kconf_update script there. It might e

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added inline comments. INLINE COMMENTS > gtkconfig.h:76 > > +void setDefaultGtk2Theme() const; > +void setDefaultGtk3Theme() const; Where are those methods called from? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: gikari,

D26185: Also disable automatic scaling on Qt >= 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea66bff2af84: Also disable automatic scaling on Qt >= 5.14 (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26185?vs=72070&id=74004 REV

D9875: Extend parsing ssh prompt

This revision was automatically updated to reflect the committed changes. Closed by commit R105:e19146459b1e: Extend parsing ssh prompt (authored by pali, committed by fvogt). REPOSITORY R105 KDE SSH Password Dialog CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9875?vs=73912&id=7391

D9875: Extend parsing ssh prompt

fvogt updated this revision to Diff 73912. fvogt added a comment. Rebased CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9875?vs=32670&id=73912 REVISION DETAIL https://phabricator.kde.org/D9875 AFFECTED FILES src/main.cpp To: fvogt, pali, lbeltrame Cc: lbeltrame, ngraham, fvog

D9875: Extend parsing ssh prompt

fvogt added a comment. I'll just land this now... REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: pali, fvogt Cc: ngraham, fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexe

D26722: Load user information once on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R133:08178c059fd3: Load user information once on startup (authored by fvogt). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26722?vs=73749&id=73751 REVISION DETA

D26722: Load user information once on startup

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Apparently the seccomp filter can break KUser in certain setups, so load the info before the sandbox is active. TEST PLAN Provided a test pa

D26185: Fix font rendering when compiled against Qt >= 5.14

fvogt added a comment. The change itself is correct, but not in relation to the title and summary which are about https://bugreports.qt.io/browse/QTBUG-80967, which was a genuine bug in Qt, fixed in 5.14.1. What this change fixes is double scaling in applications which enable `Qt::AA_Enabl

D9875: Extend parsing ssh prompt

fvogt added a comment. Ping. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: pali, fvogt Cc: ngraham, fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D26640: [applets/weather] Port weather station picker to QQC2+ListView

fvogt added a comment. When I tested this, there was a very noticable delay (~10s) between starting the search and items appearing, so the busy indicator is IMO necessary. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26640 To: ngraham, #vdg, #plasma, brouli

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

fvogt added a comment. IMO it should still be considered if it's the only one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26330 To: broulik, #plasma Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, Zr

D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

fvogt added inline comments. INLINE COMMENTS > runnerresultsmodel.cpp:189 > + > +m_manager->reloadConfiguration(); > +} This reloads the configuration in `RunnerManager`, so why is this done in `RunnerResultsModel`? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26

D9875: Extend parsing ssh prompt

fvogt added a comment. In D9875#583106 , @pali wrote: > Is there anything else or something which blocks merging this change into upstream git repository? Do you have a contributor account? If not, I can push it. REPOSITORY R105 KDE SSH

D25569: Also overwrite document.createElement using exportFunction

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Ugly... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D25569 To: broulik, fvogt, davidedmundson, ognarb Cc: plasma-devel, LeGast00n, The-Feren-OS

D25466: Add Captive Portal auto-refresh handling

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. IMO this should be addressed outside of PBI instead: - If a captive portal is detected, call `CheckConnectivity` with a higher frequency (I've never had any issues with this, ac

D25403: Drop Position change signal and support Seeked signal

fvogt added a comment. This would work, but why not just emit `Seeked(m_position)` in `setPosition`? INLINE COMMENTS > mprisplugin.h:55 > Q_PROPERTY(qreal Volume READ volume WRITE setVolume) > Q_PROPERTY(qlonglong Position READ position) > Q_PROPERTY(double Rate READ playbackRa

D25363: Fix one more buffer overread in ksysguard network helper

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network. The `Packet` constructor has both `dataLength` and `packetSize`

D25320: Show startup error in popup as well

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. I wonder whether the `getStatus` handler could be cleaned up by removing the `UNKNOWN` value of `portStatus` and removing the `default:` case. REPOSITORY R856 Plasma Browser Integration RE

D25124: Make env in plasma-sourceenv.sh call portable

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0ebdf83a2f9e: Make env in plasma-sourceenv.sh call portable (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25124?vs=69212&id=69318 RE

D25140: kcm/fonts: set initial settings correctly

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. LGTM. This now ignores the return value of the `xft.get*` calls, but that seems to be useless anyway: bool KXftConfig::getSubPixelType(SubPixel::Type &type) { type = m_subPi

D25140: kcm/fonts: set initial settings correctly

fvogt added a comment. That seems like just the order of assignments is wrong and more logic isn't actually needed. What about something like this: KXftConfig::SubPixel::Type spType = KXftConfig::SubPixel::NotSet; // we get subpixel type from config xft.getSubPixelType(spType);

D24870: Apply autoplay prevention evasion also to document.createElement

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. IMO this looks uglier than multiline C macros, but ok... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24870 To: broulik, #plasma, fvogt Cc: pla

D24997: [Lock & Login Screens] Don't use a black shadow with black text

fvogt added a comment. In D24997#555258 , @ngraham wrote: > I think we have a greater conceptual problem here. If the lock and login screens are able to display arbitrary text colors from the user's color scheme, we will never be rid of these ki

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

fvogt added a comment. In D24947#554005 , @meven wrote: > In D24947#554001 , @fvogt wrote: > > > IMO it's a good thing to have KRunner as application in the menu anyway > > > It was not in the a

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. IMO it's a good think to have KRunner as application in the menu anyway REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24947 To: meven, fv

D24870: Apply autoplay prevention evasion also to document.createElement

fvogt added a comment. Is this not needed for `` as well? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24870 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, ale

D24750: Fix reading environment variables with newline

This revision was automatically updated to reflect the committed changes. Closed by commit R120:595ab88bc2ee: Fix reading environment variables with newline (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24750?vs=68217&id=68233 R

D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper

fvogt created this revision. fvogt added reviewers: lbeltrame, cgiboudeaux. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY This way the repository with debuginfo does not have to be enabled manually before clic

D24750: Fix reading environment variables with newline

fvogt added a comment. Note, the "-0" option is only available in GNU env, not in BSD /env... I can't think of a better way to fix this though other than implementing env ourselves in native code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24750 To: f

  1   2   3   4   5   6   7   >