Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124962/#review84650 --- Ship it! Ship It! - Martin Klapetek On Aug. 28, 2015, 9

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

> On Aug. 28, 2015, 7:33 p.m., Martin Klapetek wrote: > > CMakeLists.txt, line 38 > > <https://git.reviewboard.kde.org/r/124962/diff/1/?file=399442#file399442line38> > > > > Shouldn't this be ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} then?

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

g/r/124962/#comment58516> Shouldn't this be ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} then? Also, are pam modules actually supported outside of the default dir (I have no clue)? - Martin Klapetek On Aug. 28, 2015, 9:39 a.m., Pinak

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #2 from Martin Klapetek --- Max Screen Brightness for me says 100. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

https://bugs.kde.org/show_bug.cgi?id=350676 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #1 from Martin

Re: Review Request 124944: Fix a crash.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/#review84436 --- Ship it! Ship It! - Martin Klapetek On Aug. 27, 2015, 1

Re: Breeze-icons and Plasma Breeze-theme-icons

an icon that is not present in the Plasma icon theme, so we have to use the normal icon, even if just for the meantime. Where is the break between Plasma-breeze and Breeze-breeze? I'd like to think there shouldn't be one. Ideally the icons should be the same/s

Re: Plasma 5.4 beta out now

eers from Seoul, > Cheers from Toronto :D -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kubuntu-devel] Re: git moves

let4 is supported. Or move a copy together with kwallet4 (the code has quite some ifdefs so wouldn't be an exact copy). Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.4 branched

the two modules have been pushed to kdereview too > close > to the release. > Fwiw, kwallet-pam does not have any i18n and will never have, it's just a pam module, so it has no user facing strings. Cheers -- Martin Klapetek | KDE Developer __

[Breeze] [Bug 350500] Glassified Plasma theme has unreadable logout/reboot/poweroff dialog

https://bugs.kde.org/show_bug.cgi?id=350500 Martin Klapetek changed: What|Removed |Added Summary|I can't read white text on |Glassified Plasma them

[Breeze] [Bug 350500] I can't read white text on white background.

https://bugs.kde.org/show_bug.cgi?id=350500 --- Comment #13 from Martin Klapetek --- Unfortunately we do not control kde-look.org or its content, so there is nothing we can do about that. Sorry. (if you register/login to kde-look.org, you can open the author's profile and there's

Re: Review Request 124634: Filter applets by formFactor

> On Aug. 6, 2015, 1:51 p.m., Mark Gaiser wrote: > > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp, line 153 > > > > > > qCDebug perhaps? I would even throw it out altogether, it's useful whi

[Breeze] [Bug 350500] I can't read white text on white background.

https://bugs.kde.org/show_bug.cgi?id=350500 --- Comment #11 from Martin Klapetek --- Ah ok. This looks like a problem of the Glassified theme. I would suggest contacting the author and asking him to update the theme for Plasma 5 (if he hasn't already). Can you confirm that if you select B

Re: Review Request 123877: [digital-clock] Bring back font family option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review83457 --- Ship it! Ship It! - Martin Klapetek On Aug. 3, 2015, 8:12

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

marked as submitted. Review request for Plasma and Thomas Pfeiffer. Changes --- Submitted with commit 1fc66aabb2e597fb4b2432a80d4acaa41f305197 by Martin Klapetek to branch master. Bugs: 345378 https://bugs.kde.org/show_bug.cgi?id=345378 Repository: plasma-workspace Description

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

oke the "Show seconds" setting for those starting with "a", but no report was ever filed *shrug* - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124453/#rev

Re: Plasma 5.4 Changelog

On Tue, Aug 4, 2015 at 9:37 PM, Jonathan Riddell wrote: > Does anyone have nice screenshots they can provide for the > annoucement? I'll write it up on Thursday > I'll get you some tomorrow. Cheers -- Martin Klapetek | KDE Developer _

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

ital-clock/package/contents/config/main.xml 8b0872b Diff: https://git.reviewboard.kde.org/r/124453/diff/ Testing --- Switching the checkbox on and off works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde

Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels

marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit 33395e8e4200a5d61e834cdd44a4088ef1b28e4b by Martin Klapetek to branch master. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description

Re: Review Request 124451: [digital-clock] Add support for ISO date format

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 3d241158ff42fb484eac1d5162d71331e9527886 by Martin Klapetek to branch master. Repository: plasma-workspace Description --- Another frequently requested feature - allow date to be displayed in ISO

Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels

t; > > File Attachments > > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/0173583e-08ec-455b-9417-42d390aac81d__clock-rect-delimiter2.png > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124397: Add today button to calendar

> On July 28, 2015, 10:37 p.m., Martin Klapetek wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 147-149 > > <https://git.reviewboard.kde.org/r/124397/diff/3/?file=388457#file388457line147> > > > > Given this is only used here, would it

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

ad better to the users. Thinking a bit more about it (though for later patch), maybe it should also offer to log out or open Konsole? Because this way you're just left out with black screen, unable to do anything. - Ma

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

/#comment57533> "Deprecated, does nothing"? Deprecated usually still work, this won't anymore, so I'd add that note - Martin Klapetek On Aug. 1, 2015, 11:37 a.m., David Edmundson wrote: > > --- > This is an automa

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

https://projects.kde.org/projects/kde/workspace/kscreen/repository/show?rev=plasma-applet Please make sure these^ go through proper review. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

[Breeze] [Bug 350500] I can't read white text on white background.

https://bugs.kde.org/show_bug.cgi?id=350500 --- Comment #9 from Martin Klapetek --- Can I ask what Plasma theme are you using? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

days then please ship it) ksmserver/startup.cpp (line 486) <https://git.reviewboard.kde.org/r/124534/#comment57461> This should indeed be qCWarning(KSMSERVER) (as well as the others) - Martin Klapetek On July 31, 2015, 10:32 a.m., David Faure

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

> On July 30, 2015, 8:42 p.m., Mark Gaiser wrote: > > ksmserver/startup.cpp, lines 504-518 > > > > > > You're mixing coding styles here. This looks different (more use of > > spaces) then the above chunk. Perhap

[Powerdevil] [Bug 350771] New: Screen doesn't turn off when downloading a file

https://bugs.kde.org/show_bug.cgi?id=350771 Bug ID: 350771 Summary: Screen doesn't turn off when downloading a file Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Se

Re: Review Request 124397: Add today button to calendar

item does not seem to bring any advantages... - Martin Klapetek On July 28, 2015, 10:32 p.m., Bernhard Friedreich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 124509: Use small button for session combo

187 - 188) <https://git.reviewboard.kde.org/r/124509/#comment57383> I understand from the comment that it's a HACK, I don't understand from the comment how is the hack supposed to "fix" it. Might be worth adding like three words in the spirit of "becuase this

Re: Notes from Plasma BoF

acation during the release. > This all plus more is already at https://notes.kde.org/p/plasma-5.4-changes Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels

now with small panel things are layed horizontally, see video above. File Attachments (updated) Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/0173583e-08ec-455b-9417-42d390aac81d__clock-rect-delimiter2.png Thanks,

Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels

> On July 24, 2015, 3:42 p.m., Kai Uwe Broulik wrote: > > I'm fine with the pipe in general but just using a | might look really > > strange depending on the font. A separate Rectangle would be better imho > > Martin Klapetek wrote: > Good point, I'll see

Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels

> On July 24, 2015, 3:42 p.m., Kai Uwe Broulik wrote: > > I'm fine with the pipe in general but just using a | might look really > > strange depending on the font. A separate Rectangle would be better imho > > Martin Klapetek wrote: > Good point, I'll see

Re: Review Request 124255: keyboard: do not reset shortcut for changing layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124255/#review83046 --- Ship it! Looks good to me - Martin Klapetek On July 6

Re: Notes from Plasma BoF

On Mon, Jul 27, 2015 at 3:01 PM, Sebastian Kügler wrote: > Plasma BoF 27-7-2015 > > - Qt 5.5 > - we recommend Qt 5.4 > > - Changelog for Plasma 5.4 > - we recommend Qt 5.5, multiscreen is much better with it > These^ two seem contradictory? Cheers -- Martin

[Breeze] [Bug 347123] OSD is distracting and annoying

https://bugs.kde.org/show_bug.cgi?id=347123 --- Comment #13 from Martin Klapetek --- Plasma 5.4 will bring much improved OSD, besides it getting smaller, the disappearing algorithm was also changed to be less "annoying". -- You are receiving this mail because: You are the assignee f

[Breeze] [Bug 347123] OSD is distracting and annoying

https://bugs.kde.org/show_bug.cgi?id=347123 Martin Klapetek changed: What|Removed |Added Version Fixed In||5.4.0 Resolution

Re: Review Request 124451: [digital-clock] Add support for ISO date format

ead0ad5 applets/digital-clock/package/contents/ui/main.qml f42d7ad Diff: https://git.reviewboard.kde.org/r/124451/diff/ Testing --- ISO date appears as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

reviewboard.kde.org/r/124453/#review82967 ------- On July 25, 2015, 11:55 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

> On July 25, 2015, 10:24 p.m., Martin Klapetek wrote: > > +1, I've been running this patch since forever as well on my hidpi laptop, > > there are no issues without it as far as I can say. Err, meant just +1, not ship it but

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

er as well on my hidpi laptop, there are no issues without it as far as I can say. - Martin Klapetek On July 25, 2015, 6:46 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

On July 25, 2015, 9:38 p.m., David Edmundson wrote: > > Quote: > > -- It's also not a /huge/ deal as we do our own thing anyway, so the > > -- experience is better to just turn off this scaling. > > > > I find that excuse somewhat weak. Sure, Qt's way of scaling is biting now, > > but that's _b

Re: Review Request 124451: [digital-clock] Add support for ISO date format

t.reviewboard.kde.org/r/124451/#review82924 --- On July 24, 2015, 2:27 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

> > > checkbox on: 24 hours clock > > checkbox off: maybe 12, maybe 24 hour clock depending on your locale > > > > ? > > Martin Klapetek wrote: > No, it will in fact follow the setting regardless of locale (see line 382 > in the dif

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

default the same as the locale (currently it defaults to am/pm). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124453/#review82908 -----

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

iff: https://git.reviewboard.kde.org/r/124453/diff/ Testing --- Switching the checkbox on and off works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

iff: https://git.reviewboard.kde.org/r/124453/diff/ Testing --- Switching the checkbox on and off works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124453: [digital-clock] Provide a simple option for 24h clock

. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels

July 24, 2015, 12:27 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124449/ > --

Re: Review Request 124415: Don't crash when OSD QML file is invalid

tps://git.reviewboard.kde.org/r/124415/#comment57189> "...OSD QML file" might be more understoodtable but...up to you - Martin Klapetek On July 24, 2015, 3:34 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generate

Re: Review Request 124451: [digital-clock] Add support for ISO date format

/contents/ui/configAppearance.qml ead0ad5 applets/digital-clock/package/contents/ui/main.qml f42d7ad Diff: https://git.reviewboard.kde.org/r/124451/diff/ Testing --- ISO date appears as expected. Thanks, Martin Klapetek ___ Plasma-devel

Review Request 124451: [digital-clock] Add support for ISO date format

applets/digital-clock/package/contents/ui/main.qml f42d7adfcaecc75afa6045aaf5851da2c2d6eeb6 Diff: https://git.reviewboard.kde.org/r/124451/diff/ Testing --- ISO date appears as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma

Review Request 124449: [digital-clock] Introduce new layouting state for small panels

miters https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/e0aa0799-ca56-4bdb-b4e6-b8db6622ff10__clock-delimiters.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 350500] I can't read white text on white background.

https://bugs.kde.org/show_bug.cgi?id=350500 Martin Klapetek changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status

Re: Review Request 122488: Improved calendar navigation

> On July 22, 2015, 5:10 p.m., Martin Klapetek wrote: > > Ship It already! Actually hold with the shipping, I've just noticed that the calendar popup with digital clock has all wrong margins around the grid, this would need fixi

[Breeze] [Bug 350500] I can't read white text on white background.

https://bugs.kde.org/show_bug.cgi?id=350500 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #2 from Martin

Re: Review Request 122488: Improved calendar navigation

comment57129> This should be i18nc (cause, you know, RTL and stuff) - Martin Klapetek On July 18, 2015, 10:28 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 124415: Don't crash when OSD QML file is invalid

tps://git.reviewboard.kde.org/r/124415/#comment57101> I think it might be useful to have a qWarning here too? You may miss it in the plasma startup output but then when actually triggering the osd it would print again (and again) so you'd actually get some feedback while testing the osd.

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

> On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: > > What about just leaving the default an empty string and then do a fallback > > on the QML side? > > Bernhard Friedreich wrote: > that should be possible yes.. but shouldn't it also work like this? >

Re: Review Request 124409: Begin fading the OSD immediately

on X11 only with a huge amount of nasty > code. Also I don't think that this is a solution to the "annoying" - if I > watch a video and change the volume through kdeconnect I don't have a > keyboard. > > Anyway I would dismiss the "annoying"

Re: Review Request 124408: Make PlasmaCore.Dialog opacity work

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/#review82754 --- +1 - Martin Klapetek On July 20, 2015, 9:40 p.m., Kai Uwe

Re: Review Request 124409: Begin fading the OSD immediately

on X11 only with a huge amount of nasty > code. Also I don't think that this is a solution to the "annoying" - if I > watch a video and change the volume through kdeconnect I don't have a > keyboard. > > Anyway I would dismiss the "annoying"

Re: Review Request 124409: Begin fading the OSD immediately

x27;s gather feedback from beta and during akademy and if it's bad, we can revert for the release. - Martin Klapetek On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 124409: Begin fading the OSD immediately

> On July 21, 2015, 8:28 a.m., Martin Gräßlin wrote: > > This needs quite a bit of testing in real world: how does it behave with > > changing content underneath (e.g. a video, scrolling web browser), heavy > > load on the system, heavy load on the compositor, etc. Looks like the upcoming beta

Re: Review Request 124409: Begin fading the OSD immediately

> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

> On July 21, 2015, 1:36 a.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/osd/Osd.qml, line 48 > > > > > > This looks like a random wait time... Looking at the video, it seems > > like a slow animation. >

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

> On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: > > What about just leaving the default an empty string and then do a fallback > > on the QML side? > > Bernhard Friedreich wrote: > that should be possible yes.. but shouldn't it also work like this? >

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

> On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: > > What about just leaving the default an empty string and then do a fallback > > on the QML side? > > Bernhard Friedreich wrote: > that should be possible yes.. but shouldn't it also work like this? I think you are supposed to just ad

Re: Review Request 124368: Add KPeople.PersonsSortFilterProxyModel into the qml plugin

marked as submitted. Review request for Plasma and Telepathy. Changes --- Submitted with commit 4671b302ee3b71a079fd5fbfb79a5078359da19f by Martin Klapetek to branch master. Repository: kpeople Description --- So that it can be used from qml Diffs - src/declarative

Review Request 124368: Add KPeople.PersonsSortFilterProxyModel into the qml plugin

Description --- So that it can be used from qml Diffs - src/declarative/peopleqmlplugin.cpp fa84764 Diff: https://git.reviewboard.kde.org/r/124368/diff/ Testing --- Works fine from qml Thanks, Martin Klapetek ___ Plasma-devel mailing list

Re: Review Request 124355: Set notifications to show on all desktops

? - Martin Klapetek On July 15, 2015, 12:32 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 124342: Show plasmoid / application icon in systray entries config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124342/#review82476 --- +about1000 - Martin Klapetek On July 13, 2015, 10:01 p.m

Re: Review Request 124317: Wayland port of ksplashqml

tps://git.reviewboard.kde.org/r/124317/#comment56672> Given it's closed only when !test && !nofork, I guess the same condition could be reused here? Saves a bool. - Martin Klapetek On July 10, 2015, 10:12 a.m., M

Re: Review Request 124310: Improve quick chat widget

> On July 9, 2015, 8:37 p.m., Martin Klapetek wrote: > > Can you also have a look at https://bugs.kde.org/show_bug.cgi?id=298306 and > > perhaps include the fix for that as well? > > > > Basically the chat applet should collapse when it has nothing to show, just &g

Re: Review Request 124310: Improve quick chat widget

?id=298306 and perhaps include the fix for that as well? Basically the chat applet should collapse when it has nothing to show, just like eg. desktop pager or system tray. - Martin Klapetek On July 9, 2015, 8:03 p.m., Kai Uwe Broulik wrote

Re: on review process again.. phabricator?

eview board rather than gerrit, wasn't exactly a conscious decision (for any reason, be it UI or...) on my side. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 349750] New: Laptop does not suspend when lid closed in lock screen

https://bugs.kde.org/show_bug.cgi?id=349750 Bug ID: 349750 Summary: Laptop does not suspend when lid closed in lock screen Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED

Re: Review Request 124151: Add a default icon to notifications popup

marked as submitted. Review request for Plasma. Changes --- Submitted with commit eb5693810e6d0e907071e15dc1acf8b32dac534a by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description --- Currently there's none and if there's just a summary text ($ n

Re: Review Request 124149: Rework the notifications sizing code

/124149/#review81722 --- On June 22, 2015, 6:53 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 124151: Add a default icon to notifications popup

(and distinguisable) as it is a subconscious process anyway. > So having a default icon does not really take away from the recognition of > the other icons, but I deally I would ensure that very few default icons > remain anyway. The default icon could also better be round or square. > Anyway, these are just my thoughts. > Thanks for sharing your thoughts. I tend to agree with you but I'll leave the final word on this particular issue to our Visual Design Group. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124151: Add a default icon to notifications popup

-default-icon.png No icon notification https://git.reviewboard.kde.org/media/uploaded/files/2015/06/23/06c769be-b5fc-4360-9aac-6f3179601d92__notifications-layout1.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org htt

Re: Review Request 124151: Add a default icon to notifications popup

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81666 --- On June 22, 2015, 7:51 p.m., Martin Klapetek wrote: > > ---

Review Request 124151: Add a default icon to notifications popup

t-icon.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124149: Rework the notifications sizing code

marked as submitted. Review request for Plasma and Kai Uwe Broulik. Changes --- Submitted with commit 707a9b0bc74af62cdf1fe04cf11c6163a5006518 by Martin Klapetek to branch Plasma/5.3. Bugs: 339588 and 349142 https://bugs.kde.org/show_bug.cgi?id=339588 https://bugs.kde.org

Review Request 124149: Rework the notifications sizing code

27;ve been running it for couple hours, all notifications have correct sizes, see screenshot File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/f4f7689c-2a95-46aa-8e51-e90d25d99bb2__notifications-layout.png Thanks, Martin Kla

[Breeze] [Bug 349468] Colour of all 'Leave' options should correspond to selected theme

https://bugs.kde.org/show_bug.cgi?id=349468 Martin Klapetek changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

[Breeze] [Bug 349468] Colour of all 'Leave' options should correspond to selected theme

https://bugs.kde.org/show_bug.cgi?id=349468 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #3 from Martin

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

marked as submitted. Review request for Plasma. Changes --- Submitted with commit b533e7d13f7daac129d4f91b4cdd12d9362ff15b by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description --- We're getting lots of reports about notifications not being "cl

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/#review81489 ------- On June 15, 2015, 4:30 p.m., Martin Klapetek wrote: > > --- > This is an automatically gener

Re: Review Request 124072: Refactor the Calendar grid computation a bit

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 23add5d6e4c19d353b7d8bdaf9ea2f126e7f30b9 by Martin Klapetek to branch master. Repository: plasma-framework Description --- Makes the code a bit simpler & lighter and fixes the sometimes missing bo

Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

starts up, notify-osd is terminated, Plasma notifications appear. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: HTML in Plasma's tooltips

t's related to this: http://quickgit.kde.org/?p=plasma-desktop.git&a=commitdiff&h=c534f799cace5b0511e4adf802551df17b00c3d4 We either miss some default somewhere or just set this property in your tooltip. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124072: Refactor the Calendar grid computation a bit

ck applet. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124072: Refactor the Calendar grid computation a bit

r applet and Digital Clock applet. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124072: Refactor the Calendar grid computation a bit

Calendar applet and Digital Clock applet. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124072: Refactor the Calendar grid computation a bit

orderWidth addition? It looks odd. > > > > If not, then please add more parenthesis. > > Martin Klapetek wrote: > Fix how? What this does is "(cell width + border on one side of the cell) > * number of columns + one more outer border. > > In a grid where you

Re: Review Request 124072: Refactor the Calendar grid computation a bit

have N+1 borders (draw it on paper :P) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/#review81382 -------

<    1   2   3   4   5   6   7   8   9   10   >