D15011: [Kickoff] Make the search field always look like a search field

sharvey added a comment. In D15011#342503 , @urohan wrote: > Anyway, I am not yet a contributor so my words are weightless. Not true! We listen to everyone's input. Unfortunately, it seems you're a little late to this party and the change

D15011: [Kickoff] Make the search field always look like a search field

sharvey added a comment. Let's see what we can do... I'll make the `Activities` change a separate diff, since this one's the most epic I've personally encountered. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, ab

D15011: [Kickoff] Make the search field always look like a search field

sharvey added a comment. I can take a look at it. I didn't do anything regarding its visual appearance, just made it appear and disappear at will - by hiding or showing the row it was placed on. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngrah

D15885: Clean UI file for `details` portion of UI

sharvey created this revision. sharvey added reviewers: ngraham, bruns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Properly organized UI file (by @bruns) TEST PLAN Add to polkit-agent; recompile REPOSIT

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. @ngraham : Now that I understand what went wrong here, I really do think this particular diff be abandoned. It mistakenly contains unrelated material from a different diff (D12311 ) - which we probably shouldn't re-submit. I will g

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. This was copied from D12311: Align lock icon with bold message text; reduce overall size of dialog , which languished unapproved and un-landed for a long time. Indeed, I should have made this a separate patch, but I'd only been a c

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. I believe what you're perceiving in the XML file is in fact the result of a lot of changes made to the layout. Unneeded columns, rows, and spacers were deleted, causing "gaps" in the old XML file. In places, I added options like column spans and justifications. The X

D12498: Fully remove `Application Name` from Details panel

sharvey added inline comments. INLINE COMMENTS > bruns wrote in authdetails.ui:20 > Can you try to restore/use the same item order in the XML file as previously? > Should make the diff significantly smaller, and easier to review. The XML file is auto-generated by the form editor in QtCreator. I

D12498: Fully remove `Application Name` from Details panel

sharvey updated this revision to Diff 42375. sharvey added a comment. - Changed PolKit description to `Description not provided` Was: "Missing" REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12498?vs=33002&id=42375 BRANCH arcpat

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

sharvey updated this revision to Diff 42154. sharvey added a comment. Update "Mouse Click Emulation" to "Tap to Click" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15699?vs=42153&id=42154 BRANCH tap-to-click REVISION DETAIL https://phabricato

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

sharvey added inline comments. INLINE COMMENTS > tap.ui:31 > + > +Qt::AlignCenter > I only changed lines 28-31... I don't know what the other changes are. I pulled plasma-desktop fresh from git. The change took mere minutes. REPOSITORY R119 Plasma Desktop REVISION DE

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

sharvey created this revision. sharvey added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Text change/usability improvement. Replace technical terms with user-friendly language. TEST PL

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. Thanks for the investigation. I've been hoping someone else would lend a pair of eyes to this problem for ages. When you change the icon in `user-manager` repeatedly, are you prompted for a root password **every time**? On my system (Tumbleweed), there's a "grace

D12855: Move Widget search field to its own row so it doesn't get compressed

This revision was automatically updated to reflect the committed changes. Closed by commit R119:08983522bfb4: Move Widget search field to its own row so it doesn't get compressed (authored by sharvey). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1285

D12311: Align lock icon with bold message text; reduce overall size of dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R121:d4ee26a76a21: Align lock icon with bold message text; reduce overall size of dialog (authored by sharvey). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricato

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. As soon as D12311: Align lock icon with bold message text; reduce overall size of dialog is landed, I'll change this string. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To:

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. I'm still in favor of the brief but descriptive "Not Provided". This is an advanced developer field. I could add a tooltip with some additional information. My point is to convey the fact that "the vendor is supposed to provide this information, but did not." To

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. I believe it's done. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano, broulik,

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. In D13415#282884 , @hein wrote: > Can you have a look at the code in `kdeclarative`, specifically `src/qmlcontrols/kcoreaddons/kuserproxy.cpp` - that's where the KDirWatch monitoring the `face.icon` file is. I think you

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. In D13415#282860 , @hein wrote: > Can you elaborate what you tried and what you wanted to happen and what didn't happen? I'm a bit confused now @ `touch`. A few days ago, you suggested > You can run `touch $H

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. Trying to use `touch` made no difference. I called it manually between changes, and actually added it (temporarily) to the actual Kickoff code, so it "touched" every time Kickoff was opened. No change. Anybody have another guess? REPOSITORY R119 Plasma Desktop

D13699: Fix Ctrl+Alt+T shortcut to open Konsole

sharvey added a comment. +1 from me as well. I knew this shortcut from, ahem, //other// desktops. I thought it was something KDE simply didn't do. Nice fix. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D13699 To: ngraham, #plasma, kossebau Cc: sharvey, zzag, plas

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. Perhaps I can go into the UserManager KCM, let it change the avatar like always, then run a brief time (250ms?), and then ‘touch’ the face file so the KDirWatch runs a second time. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13415

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. @hein : Thanks for the time spent investigating. The User Manager KCM appears to write out proper (non-corrupt) files, at least in my testing. I know there's a KDirWatch in one of the included Frameworks (KCoreAddons, I think), but that seems to work properly. It doe

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. I'll get back to work on this. I've got a current open patch I need to finish up first, then I'll resume work on this. Should be a couple days at most. Thanks for all the debate and decision on the messaging. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISI

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. A couple of random ideas: - The Arch Wiki has a lengthy page on screen brightness. Maybe there's something there that can help. - Is there a valid use case for going all the way to zero? Minimum doesn't necessar

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. It seems I have some system rebuilding to do first. I'm not up for tackling it tonight. I'll work on it in the morning and try to get you some more data. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma, broulik

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. In D13095#277963 , @thsurrel wrote: > Hi Scott, thanks for the help! > If you can apply the patch, we could see if you have the same behavior than Nate with his hardware: when setting a very low value (for him, it's in

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. Hope you don't mind me jumping in - I'm another one of Nate's protegees... here's some data for you. These values are before your patch. Let me know if you'd like me to apply your patch and redo the testing. 0 (lowest) 75 (backlight on) 150 225

Re: Closing old Plasma 4 bugs

Did anyone check how much space has been freed up in the Bugzilla database? On Jun 8, 2018, 3:39 PM -0500, Nate Graham , wrote: > This work is done; all the bugs and feature requests in the plasma4 > product have been closed. Hope all of your inboxes survived the onslaught! > > Nate > > > > On 02/2

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. In D13415#275567 , @ngraham wrote: > I encounter the very same issue as in D13202 : Changing the Avatar in System Settings results in a blank circle in Kickoff. Here's a clue though: i

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added inline comments. INLINE COMMENTS > ngraham wrote in Header.qml:96 > I think I might prefer a lighter color than this. Perhaps the window > alternate background color? As soon as I get it working reliably and not showing blank circles...! REPOSITORY R119 Plasma Desktop REVISION

D13202: Circular user avatar for Kickoff

sharvey added a comment. I rewrote this patch using an `OpacityMask` and a second rounded `Rectangle` to draw the ring. It's a separate diff - D13415: Reshape Kickoff avatar to a circle with Opacity Mask . Please help me test and offer any suggestions.

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Attempt to avoid non-refreshing avatar by using `OpacityMask` instead of `ShaderEffect` TEST PLAN

D13202: Circular user avatar for Kickoff

sharvey added a comment. **#$%$@$!!!** I thought I had the blank circle problem fixed, but it appears I was wrong - must've done something incomplete in my testing. Will someone Plasma-related please have a look at this and see if you can offer any suggestions? I'm at a loss. All th

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#275279 , @davidedmundson wrote: > Worth noting that some values were tweaked here because of the smaller circle size. For the record, the values that I tweaked were: highp float blend = 0.03;

D13202: Circular user avatar for Kickoff

sharvey added a comment. @ngraham - This now appears to function properly with no blank circles. Will you please confirm? If Nate is happy, will someone from #plasma please approve so I can land it and get it filed under "finished"? Thanks

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35770. sharvey added a comment. - Remove explicit `visible: true`, as default == `true` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35648&id=35770 BRANCH round-kickoff-avatar (branched from master)

D13202: Circular user avatar for Kickoff

sharvey added a comment. @apol : My first pass at this used `OpacityMask`. It worked well. See below. In D13202#270387 , @sharvey wrote: > F5875550: Screenshot_20180529_113110.png Two things, th

D13202: Circular user avatar for Kickoff

sharvey added inline comments. INLINE COMMENTS > apol wrote in Header.qml:139 > No need to set it to true, just drop the line. Stupid defaults. :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, #plasma Cc: apol, davidedmundson

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35648. sharvey added a comment. - Reset QtQuick version to 2.4 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35647&id=35648 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL https

D13202: Circular user avatar for Kickoff

sharvey added a comment. Let's try this... INLINE COMMENTS > Header.qml:139 > +source: squareFace > +visible: true > width: units.gridUnit * 3 Was `faceIcon.status !== Image.Ready`, which I believe was an old timing test when machines were slower. Doesn't seem neces

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35647. sharvey added a comment. - Force icon to be visible, avoiding blank circle REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35151&id=35647 BRANCH round-kickoff-avatar (branched from master) REVI

D13202: Circular user avatar for Kickoff

sharvey added a comment. @davidedmundson - could use your input here, please. Your circle shader effect detects a user avatar change, partially - it goes blank. But it doesn't reload `squareFace` despite the fact that all three avatar locations (`~.face`,` ~.face.icon`, and `/var/lib/Accoun

D13202: Circular user avatar for Kickoff

sharvey marked 2 inline comments as done. sharvey added a comment. I don't know if I need to edit `user-manager` to emit a signal of some kind, or if some trigger needs to go over the D-Bus... I'm wading into deep water here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabri

D13202: Circular user avatar for Kickoff

sharvey added a comment. F5878497: Screenshot_20180530_121625.png It appears Kickoff had this problem prior to the circles. I changed my avatar, but un-patched Kickoff now shows the default avatar. I'm not clear why `user-manager` removes the prev

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#270585 , @ngraham wrote: > Looks great now! Quite pleasing to the eye. > > I've got a few blockers though: > > - When I change the icon in the user-manager KCM and re-open Kickoff, the new icon isn't dis

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35151. sharvey added a comment. - Whitespace once more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35150&id=35151 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL https://phabr

D13202: Circular user avatar for Kickoff

sharvey marked 2 inline comments as done. sharvey added a comment. F5876367: Screenshot_20180529_180924.png Best yet, I think. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, #plasma C

D13202: Circular user avatar for Kickoff

sharvey marked 4 inline comments as done. sharvey added inline comments. INLINE COMMENTS > davidedmundson wrote in Header.qml:76 > needed? Not anymore. I thought your ShaderEffect just drew circles. I didn't catch on that it rounded off an image and then added a border. This probably helped the

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35150. sharvey added a comment. - Remove redundant `OpacityMask`; tweaked antialiasing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35139&id=35150 BRANCH round-kickoff-avatar (branched from master)

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#270529 , @abetts wrote: > It doesn't look any different to me. They are both the same. Maybe the screenshot is too small? I can see the pixels from far on both images. Yeah, the same to me as well. The s

D13202: Circular user avatar for Kickoff

sharvey added a comment. AA option not set F5875999: Screenshot_20180529_131810.png AA option set F5876003: Screenshot_20180529_155151.png Does the second option look dramatically better or different?

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#270496 , @ngraham wrote: > Cool! But in your latest screenshot, the circle is aliased pretty badly I noticed. Dave's code specifically says it'll be drawn antialiased. There's also an antialiasing pr

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35139. sharvey added a comment. - Whitespace (again...) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35138&id=35139 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL https://phab

D13202: Circular user avatar for Kickoff

sharvey added a comment. I stuck with @davidedmundson 's use of `PlasmaCore.ColorScope.textColor` for the highlight ring. I tested it with a few different color themes and the whole thing comes out looking like a natural match. This shot is back to my personal choice of an openSUSE scheme.

D13202: Circular user avatar for Kickoff

sharvey added a comment. > If you copy and paste the ShaderEffect from UserDelegate.qml colorBorder is a property you can change {icon thumbs-up} Very nice bit of code. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham,

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35138. sharvey added a comment. - Add theme-colored ring around avatar REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35132&id=35138 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL

D13202: Circular user avatar for Kickoff

sharvey added a comment. > The one visual improvement I could think of is adding a thin light gray outline around the circle to help separate it from the background. This is done on the login and lock screens; might be able to mine those implementations for ideas, if it's not too hard. But e

D13202: Circular user avatar for Kickoff

sharvey added a comment. I intentionally didn't tag Bug 386656 , as it has some debate allowing the user to select between a round or square avatar. @ngraham voted for the circle, which is what I implemented. If we want it switchable, I'll add a

D13202: Circular user avatar for Kickoff

sharvey added a comment. F5875550: Screenshot_20180529_113110.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, plasma-devel Cc: ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35132. sharvey added a comment. - Remove whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35131&id=35132 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL https://phabrica

D13202: Circular user avatar for Kickoff

sharvey created this revision. sharvey added reviewers: ngraham, hein, plasma-devel. Restricted Application added a project: Plasma. sharvey requested review of this revision. REVISION SUMMARY Apply circular `OpacictyMask` to crop square user avatar into a circle TEST PLAN - Download & apply

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. Message received and understood. Sorry for jumping the gun. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. Oh. I see. The Phab emails say "now ready to land", so I did what the machine told me to. But I clearly see your point. Hopefully he will be okay with it. If not, I'm more than willing to roll it back and make any further changes. REPOSITORY R119 Plasma Deskto

D13122: Add second line of text for KickerDash item descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cd7252e9fa07: Add second line of text for KickerDash item descriptions (authored by sharvey). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13122?vs=34895&i

D13122: Add second line of text for KickerDash item descriptions

sharvey updated this revision to Diff 34895. sharvey added a comment. - - Remove trailing whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13122?vs=34885&id=34895 BRANCH two-row-dash (branched from master) REVISION DETAIL https://phabr

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. I forgot it was a bug. I thought it was an assignment. :-) REPOSITORY R119 Plasma Desktop BRANCH two-row-dash (branched from master) REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, plasma-devel Cc: ragreen, Pitel, ZrenBot, leslie

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. F5868921: Screenshot_20180525_164110.png Unfortunate line breaks in long file names. See line 98. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, plasma-devel

D13122: Add second line of text for KickerDash item descriptions

sharvey added inline comments. INLINE COMMENTS > ItemGridDelegate.qml:98 > elide: Text.ElideRight > -wrapMode: Text.NoWrap > +wrapMode: Text.Wrap > Note: will wrap at an arbitrary point if there's no natural break. Happens with long filenames under "Recent Documents"

D13122: Add second line of text for KickerDash item descriptions

sharvey created this revision. sharvey added reviewers: ngraham, hein, plasma-devel. Restricted Application added a project: Plasma. sharvey requested review of this revision. REVISION SUMMARY Adds a second line of text under icon/doc icons for more clarity. Will stop at two lines; if text con

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey added a comment. F5865966: Screenshot_20180523_223641.png Two quick injections of `units.smallSpacing` for margins and we have a nice sleek display with no overlap. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34767. sharvey added a comment. - Add `units.smallSpacing` as margins around search bar row REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34761&id=34767 BRANCH new-search-row (branched from master)

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey added a comment. Should ‘someAmazingValue’ be an explicit number (like (x) pixels), or something like ‘units.smallValue’ (or whatever the correct syntax is)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added a comment. F5865709: Screenshot_20180523_180214.png @davidedmundson (and/or others) - what's the most-correct and most-effective QML method to add a bit of padding around these elements? I know

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > davidedmundson wrote in WidgetExplorer.qml:275 > This is all a bit weird. > > This searchBarContainer is 0 px tall as it's not set to be the size of the > children. which is why you need to do that topM

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34761. sharvey marked an inline comment as done. sharvey added a comment. - Merge branch 'master' into new-search-row - Revise QML using relative sizing & spacing instead of fixed values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

sharvey added a comment. As a side note, usage of the terms "kicker" and/or "kickoff" aren't user-friendly at all. They're basically internal names and aren't mentioned in any user-facing text. I'm not trying to hijack the issue; this is just one of those barriers to entry we should try to k

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 13 inline comments as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:235 > I mean, could we do something like `newSearchRow.height = searchInput.height > + (units.smallSpacing * 2)` or something like that? Would that work? > > Now that

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:389 > Looks like it's still there? Not a huge deal, but it would be good to figure > out why your changes keep adding or removing whitespace. F5848538: Screenshot_20180

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 7 inline comments as done and 5 inline comments as done. sharvey added inline comments. INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > We from my (albeit limited) comprehension of `units`, they're all > derived programatically somehow, either from an icon size

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 3 inline comments as not done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:235 > `units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way > we can derive this height value programmatically? We from my (albeit l

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34160. sharvey marked an inline comment as done and an inline comment as not done. sharvey added a comment. - Remove unneeded commented-out code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34158&id=34

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 2 inline comments as done and 2 inline comments as done. sharvey added a comment. More revising in progress. Units. Bah humbug. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:203 > Can we use some multiple of `units.smallSpacing` or something here instead of > a hardcod

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34158. sharvey marked an inline comment as done and an inline comment as not done. sharvey added a comment. - Units changed to `gridUnits` instead of `smallSpacing`; whitespace cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://p

D12794: [weather applet] Improve name & comment metadata

sharvey added a comment. +1 for "Forecast & Current Conditions" - I think this is what they use on the American cable network "The Weather Channel" REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12794 To: kossebau, #plasma Cc: sharvey, jriddell, ngraham, plas

D12855: Move search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34129. sharvey added a comment. - Remove hardcoded pixel sizes; misc code cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34083&id=34129 BRANCH new-search-row (branched from master) REVISION D

D12855: Move search field to its own row so it doesn't get compressed

sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:157 > ? Not sure The extra comment adds anything. Instead we should just remove the > commented-out code in a new patch IMHO. I'm always unclear what to do when I find blocks of other people's comments. Some r

D12855: Move search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34083. sharvey added a comment. Submitted from wrong local branch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34078&id=34083 BRANCH new-search-row (branched from master) REVISION DETAIL https://

D12855: Move search field to its own row so it doesn't get compressed

sharvey added a comment. Before: {F5846708} -- After: F5846710: Screenshot_20180513_082104.png F5846712: Screenshot_20180513_082036.png REPOSITORY R119 Plasma Desktop REVISION DETAIL http

D12855: Move search field to its own row so it doesn't get compressed

sharvey created this revision. sharvey added reviewers: ngraham, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Move search to its own row to prevent it from bein

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

This revision was automatically updated to reflect the committed changes. Closed by commit R124:19712a1d22b2: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to… (authored by sharvey). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D12498: Fully remove `Application Name` from Details panel

sharvey added inline comments. INLINE COMMENTS > bruns wrote in AuthDialog.cpp:349 > According to > https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-rules > `description` is not optional, so the correct statement is "Missing" I was checking to see if this was still o

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. In D12252#254928 , @zzag wrote: > I've just noticed that it's calling `setMinimumSize`. Why? (especially, with such a big minimum size) > > What about icon based view mode, i.e. the old settings layout? The new setti

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 33667. sharvey marked an inline comment as done. sharvey added a comment. - Remove redundant size setting REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=33208&id=33667 BRANCH arcpatch-D12252 REVISIO

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in SettingsBase.cpp:108 > Do we actually need this? It wasn't referenced anywhere else in the project. Probably a leftover from times long ago. REPOSITORY R124 System Settings REVISION D

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 33208. sharvey added a comment. - Remove old, unused call to KConfig "MainWindow" REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32814&id=33208 BRANCH enlarge-default-size (branched from master) REV

D12498: Fully remove `Application Name` from Details panel

sharvey updated this revision to Diff 33002. sharvey marked an inline comment as done. sharvey added a comment. - Changed `Not Available` to `Missing` REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12498?vs=33000&id=33002 BRANCH remo

D12498: Fully remove `Application Name` from Details panel

sharvey updated this revision to Diff 33000. sharvey added a comment. - Correct for use of `isEmpty()`; changed `Action ID` to simply `ID` REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12498?vs=32993&id=33000 BRANCH remove-appname (

D12497: Fully remove "Application Name" from details panel

sharvey added a comment. In D12497#253114 , @ngraham wrote: > No need to abandon this revision; you could pull down master, re-branch, do your changes there, and then issue `arc diff --update D12497`, and it will replace the diff here with what

  1   2   >