[Differential] [Accepted] D2748: [effects] Repaint expandedGeometry in HighlightWindowsEffect

2016-09-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH highlightwindows-proper-repaint REVISION DETAIL https://phabricator.kde.org/D2748 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D2743: [server] When replacing the clipboard selection previous DataSource needs to be cancelled

2016-09-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH cancel-data-source REVISION DETAIL https://phabricator.kde.org/D2743 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D2724: Make WindowPixmap::isValid virtual and override in concrete implementation

2016-09-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH pixmap-valid-override REVISION DETAIL https://phabricator.kde.org/D2724 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Closed] D2760: style and high dpi fixes for screen identification OSD

2016-09-13 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN535bf03d03a5: style and high dpi fixes for screen identification OSD (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2760?vs=6696&id=6697

[Differential] [Updated, 69 lines] D2760: style and high dpi fixes for screen identification OSD

2016-09-13 Thread Sebastian Kügler
sebas updated this revision to Diff 6696. sebas added a comment. - address Kai's comments REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2760?vs=6690&id=6696 BRANCH sebas/screenid REVISION DETAIL https://phabricator.kde.org/D2760 AFFECTED FILES

[Differential] [Commented On] D2760: style and high dpi fixes for screen identification OSD

2016-09-13 Thread Sebastian Kügler
sebas added a comment. It would, and I played with it, but: This would need an ARGB window and also fallbacks to opaque components, at that point, we'd be duplicating much of the code in Plasma::Dialog (from plasmaquick). Since this code is hopefully going away for a yet-to-be-designed

[Differential] [Request, 72 lines] D2760: style and high dpi fixes for screen identification OSD

2016-09-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - screen identification osd now uses plasma styling, it's workspace thing - simplified the code - made it hig

[Differential] [Accepted] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

2016-09-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH settings-required-compositing REVISION DETAIL https://phabricator.kde.org/D2586 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Accepted] D2584: Introduce a config option whether applications are allowed to block compositing

2016-09-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > graesslin wrote in compositing.ui:9 > That is the minimum size ;-) So your change made the window's minimum width more than 300px wider? Th

[Differential] [Accepted] D2630: Support highlighting windows through EffectsHandlerImpl

2016-09-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH highlight-windows-through-effects REVISION DETAIL https://phabricator.kde.org/D2630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Changed Subscribers] D2630: Support highlighting windows through EffectsHandlerImpl

2016-09-12 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > effects.h:239 > > +void highlightWindows(const QVector &windows); > + EffectWindow* ? > highlightwindow.cpp:261 > > +void HighlightWindowEffect::highlightWindows(const > QVector &windows) > +{ whitespace > highlightwindow.h:58 > > +

[Differential] [Changed Subscribers] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

2016-09-12 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > dbusinterface.h:118 > Q_PROPERTY(QStringList supportedOpenGLPlatformInterfaces READ > supportedOpenGLPlatformInterfaces) > +Q_PROPERTY(bool platformRequiresCompositing READ > isPlatformRequiringCompositing) > public: same name for proper

[Differential] [Changed Subscribers] D2584: Introduce a config option whether applications are allowed to block compositing

2016-09-12 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > compositing.ui:9 > 0 > -481 > -349 > +815 > +510 resize the window before saving, that means it saves the minimum size, rather than a random one > compositing.ui:24 > > - > + > OpenGL compositin

Re: Review Request 128728: Update plasma handbook

2016-09-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128728/#review99129 --- Ship it! Ship It! - Sebastian Kügler On Aug. 25, 2016

Re: Plasma 5.7.4 is out

2016-09-12 Thread Sebastian Kügler
On Friday, September 9, 2016 11:58:25 PM UTC Andreas Müller wrote: > On Tue, Aug 23, 2016 at 6:46 PM, David Edmundson > > wrote: > > https://www.kde.org/announcements/plasma-5.7.4.php > > > > Regards > > > > David > > I did not find anything in announcement: What happened > to plasma-mediacen

Re: Plasma 5.8 Errata

2016-09-12 Thread Sebastian Kügler
On Monday, September 12, 2016 12:55:22 PM UTC Jonathan Riddell wrote: > Do we still have issues with Intel GPUs? I think we should recommend people having issues with Intel GPUs to try the modesetting driver. -- sebas http://www.kde.org | http://vizZzion.org

[Differential] [Accepted] D2528: Add support for Surface enter/leave events

2016-09-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > surface.cpp:50 > qint32 scale = 1; > +QVector outputs; > + Output* > surface.h:247 > + **/ > +QVector outputs() const; >

[Differential] [Accepted] D2526: [client] Track all created Outputs and add static get method

2016-09-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH client-output-track REVISION DETAIL https://phabricator.kde.org/D2526 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

Minutes Monday Plasma Meeting

2016-09-12 Thread Sebastian Kügler
lanned - plugin caching stuff ended up on my list - further on to testing plasma on wayland -- sebas Sebastian Kügler•http://vizZzion.org•http://www.kde.org

[Differential] [Closed] D2718: show an OSD on display button press

2016-09-09 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENad53dc4afaab: show an OSD on display button press (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2718?vs=6567&id=6592 REVISION DETAIL

[Differential] [Closed] D2711: add osd slot for screen layout changes

2016-09-09 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE64a3a1cd4167: add osd slot for screen layout changes (authored by sebas). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2711?vs=656

Re: Change settings for docking station

2016-09-09 Thread Sebastian Kügler
kscreen) saves the screen configuration based on the hardware connected, so if you set up your screens with a monitor connected through a docking station,the next time this hardware combo is detected, it will restore this configuration. In other words, it should work as you describe out of the box. Ch

[Differential] [Commented On] D2718: show an OSD on display button press

2016-09-09 Thread Sebastian Kügler
sebas added a comment. Display means one monitor, screen the combination of all. That is consistent with how we use it elsewhere as far as I can tell. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2718 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

[Differential] [Updated] D2711: add osd slot for screen layout changes

2016-09-08 Thread Sebastian Kügler
sebas added a dependent revision: D2718: show an OSD on display button press. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: broulik, plasm

[Differential] [Request, 20 lines] D2718: show an OSD on display button press

2016-09-08 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Show the plasma OSD with icon "preferences-desktop-display-randr" and text when the display button has been pre

[Differential] [Updated] D2718: show an OSD on display button press

2016-09-08 Thread Sebastian Kügler
sebas added a dependency: D2711: add osd slot for screen layout changes. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2718 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: plasma-devel, lesliezhai, ali-mohame

[Differential] [Commented On] D2711: add osd slot for screen layout changes

2016-09-08 Thread Sebastian Kügler
sebas added a comment. I had a look at showing the OSD on all screens, and it isn't looking very simple. The situation is as follows: In kscreen, we already have an OSDs, the one when you click on the "Identify" button in bottom right corner the display configuration module's layout view

[Differential] [Updated, 2 lines] D2711: add osd slot for screen layout changes

2016-09-08 Thread Sebastian Kügler
sebas updated this revision to Diff 6562. sebas added a comment. just export showText, instead of adding a redirection This makes the patch rather simpler and adds a generic method to the dbus object, rather than a specialized name of the call: so showText() vs. screenLayoutChanged().

[Differential] [Commented On] D2711: add osd slot for screen layout changes

2016-09-08 Thread Sebastian Kügler
sebas added a comment. yeah ... I don't think it does it right now, and it's perhaps not that critical for now. Anyway, I'll have a look later on, if you have comments on my patch as is, they're welcome to compress the review process a bit. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REV

[Differential] [Request, 6 lines] D2711: add osd slot for screen layout changes

2016-09-08 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds an OSD to the dbus object so we can hook up layout changes of the XF86Display button. The method

Re: Review Request 128707: Add support for captive portals

2016-09-06 Thread Sebastian Kügler
> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DD

[Differential] [Accepted] D2164: Allow struts on panels between screen edges if WM is KWin

2016-08-25 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH struts-shared-panels REVISION DETAIL https://phabricator.kde.org/D2164 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Accepted] D2529: Fix mistake between Lock and Leave action in lock_logout applet

2016-08-22 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2529 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: o

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-22 Thread Sebastian Kügler
On zondag 21 augustus 2016 16:50:16 CEST Kai Uwe Broulik wrote: > In my opinion the default usecase for the majority of users is "plug in TV > and get sound there". I don't want to fiddle around with settings just > because of that, especially because KScreen usually does the right thing in > this

Minutes Monday Plasma Hangout

2016-08-22 Thread Sebastian Kügler
** NO MEETING NEXT WEEK, IT'S REALLY CLOSE TO AKADEMY ** Minutes Plasma 'hangout', 22-8-2016, 12:00 CEST Present: bshah, Eike, jens, kbroulik, mgraesslin, notmart, roman, sebas bshah: - brightness stuff for plasma mobile - Last approch to notify KWin hwcomposer backend from powerdevil didn't fee

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2016-08-22 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=344612 Sebastian Kügler changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC

[Differential] [Accepted] D2344: Make linux/input.h compile time optional

2016-08-19 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH linux-input-optional REVISION DETAIL https://phabricator.kde.org/D2344 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Closed] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-19 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENf04d6d3c3c8a: [kded] correctly restore lidOpened configuration on startup (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=6024&id

[Differential] [Closed] D2496: normalize output positions in setoperation

2016-08-19 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN90d8ee283f88: normalize output positions in setoperation (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2496?vs=6054&id=60

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

2016-08-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/#review98496 --- Ship it! Honoured to oblige. :) - Sebastian Kügler On

[Differential] [Request, 76 lines] D2496: normalize output positions in setoperation

2016-08-18 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When setting a config, outputs may fall outside of the virtual screen layout. This can happen when, for example

Re: Review Request 128707: Add support for captive portals

2016-08-18 Thread Sebastian Kügler
tps://git.reviewboard.kde.org/r/128707/#comment66356> That shouldn't be necessary when using a scoped pointer. - Sebastian Kügler On Aug. 18, 2016, 11:42 a.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 128707: Add support for captive portals

2016-08-18 Thread Sebastian Kügler
) <https://git.reviewboard.kde.org/r/128707/#comment66350> Perhaps "Redirecting..." since that's what's supposedly happens. It's more telling than "captive portal" IMO. - Sebastian Kügler On Aug

[Differential] [Updated] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-18 Thread Sebastian Kügler
sebas marked 2 inline comments as done. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2465 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abe

[Differential] [Commented On] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-18 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in daemon.cpp:167-169 > So what is the code going to do here? Will it go into the code path here or > not? Ah, I see what you mean. Yes, it would go in there but do nothing since QFile::exists(..) will return false -- the file is n

[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-18 Thread Sebastian Kügler
sebas updated this revision to Diff 6024. sebas added a comment. - Also check isLaptop) REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=5988&id=6024 BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 AFFECTED FILES

Re: Review Request 128707: Add support for captive portals

2016-08-18 Thread Sebastian Kügler
org/r/128707/#comment66348> PortalMonitor is not known when webengine support is off at build time kded/service.cpp (line 86) <https://git.reviewboard.kde.org/r/128707/#comment66349> This would also need a an #if (or you can make webengine required dep, of course) - Seba

Re: Review Request 128707: Add support for captive portals

2016-08-18 Thread Sebastian Kügler
https://git.reviewboard.kde.org/r/128707/#comment66346> coding style, PortalMonitor *portalMonitor (should be at least consistent for new code) kded/service.cpp (line 60) <https://git.reviewboard.kde.org/r/128707/#comment66347> nullptr - Seb

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

2016-08-18 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362830 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org --- Comment #2 from Sebastian

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

2016-08-18 Thread Sebastian Kügler
board doesn't let me download the files. Could you put them up somewhere? (At least the highest resolution.) - Sebastian Kügler On Aug. 16, 2016, 7:26 p.m., Ken Vermette wrote: > > --- > This is an automatically generated e-ma

[Differential] [Commented On] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-17 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in daemon.cpp:167-169 > how does that behave if the device has no lid? It won't find a config file with _lidOpened appended, since that is only ever created when the lidClosedChanged signal is fired (which only happens when the dev

[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-16 Thread Sebastian Kügler
sebas updated this revision to Diff 5988. sebas added a comment. - constness REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=5987&id=5988 BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 AFFECTED FILES kded/daem

[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-16 Thread Sebastian Kügler
sebas updated this revision to Diff 5987. sebas added a comment. - --unused vars REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=5986&id=5987 BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 AFFECTED FILES kded/

[Differential] [Request, 109 lines] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-16 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When shutting down the machine (or kded5, really) with the lid closed will leave a config with the laptop panel

[Differential] [Accepted] D2402: [wayland] Unset focused keyboard surface when handling key event internally

2016-08-15 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH internal-window-unset-focus-keyboard REVISION DETAIL https://phabricator.kde.org/D2402 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

Re: Kirigami build instructions

2016-08-15 Thread Sebastian Kügler
On Monday, August 15, 2016 5:35:00 AM UTC Police Terror wrote: > Directory /platforms does not exist Looks like you haven't exported the ANDROID_NDK vars correctly, like Aleix suggested. -- sebas http://www.kde.org | http://vizZzion.org

Re: Now Dock - create a single widget panel?

2016-08-15 Thread Sebastian Kügler
On Saturday, August 13, 2016 1:47:18 PM UTC Michail Vourlakos wrote: > Having published the Now Dock plasmoid in kdelook, I would like in parallel > to start the effort to implement it as a panel... But I dont know from > where to start... I found in the plasmoids folder the org.kde.panel which I >

Re: stylesheed folders

2016-08-11 Thread Sebastian Kügler
On Thursday, August 11, 2016 12:17:49 PM UTC Sebastian Kügler wrote: > Did you test this with app-specific color schemes? > This I assume is only for the default folders, but what about the folder > icons that are already colored? If I'm using a green folder, and then > change th

Minutes Monday Plasma Hangout

2016-08-11 Thread Sebastian Kügler
Sorry for the delay... Minutes Plasma 'hangout', 8-8-2016, 12:00 CET Present: mgraesslin, bshah, Sho, sebas, notmart, Riddell, romangg, kbroulik bshah: * cleaned up patch to powerdevil: https://phabricator.kde.org/D2369 * Debugging the kaccounts and spacebar on phone Sho: - Minor changes to Qt

Re: stylesheed folders

2016-08-11 Thread Sebastian Kügler
On Thursday, August 11, 2016 12:58:25 AM UTC kainz.a wrote: > since a few days you can find in breeze-icons the posibility that folders > follow the color scheme colors. > > https://kdeonlinux.wordpress.com/2016/08/08/rainbow-folders/ > > As visual changes for folders are very importend for the

Re: Animate removal from Positioner?

2016-08-11 Thread Sebastian Kügler
On Wednesday, August 10, 2016 8:24:15 PM UTC Marco Martin wrote: > On Wednesday 10 August 2016 21:18:43 Michail Vourlakos wrote: > > I am creating an alternative plasmoid for tasks and I would like your > > wisdom around QML please.. > > > > > > At some point of my code I am using a Grid(Position

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Sebastian Kügler
> On Aug. 10, 2016, 1:23 p.m., David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? Did you read Martin's comments on the phab request? - Sebastian --- This is an automatically g

Re: Selecting a Plasma logo

2016-08-10 Thread Sebastian Kügler
On Wednesday, August 10, 2016 10:37:07 AM UTC kainz.a wrote: > as there is no new mail since 2 days how can we find a new logo? > > 1. poll of the existing logos > 2. irc/hangout meeting with plasma vdg and the icon designers > 3. git push I think consensus is that we're lacking an overview, hard

[Differential] [Closed] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREENf53805676dc0: [xrandr backend] fall back to preferred mode, fix crash (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
sebas updated this revision to Diff 5798. sebas added a comment. BUG:366575 REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5797&id=5798 BRANCH sebas/modefallback REVISION DETAIL https://phabricator.kde.org/D2330 AFFECTED FILES

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
sebas updated this revision to Diff 5797. sebas added a comment. - Improve conditional REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5796&id=5797 BRANCH sebas/modefallback REVISION DETAIL https://phabricator.kde.org/D2330 AFFE

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
sebas updated this revision to Diff 5796. sebas added a comment. - Merge branch 'master' into sebas/modefallback - Improve conditional REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5638&id=5796 BRANCH sebas/modefallback REVISIO

Re: Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

2016-08-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128641/#review98253 --- Ship it! Ship It! - Sebastian Kügler On Aug. 9, 2016

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98252 --- Ship it! Ship It! - Sebastian Kügler On Aug. 9, 2016

[Differential] [Commented On] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-09 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in xrandrconfig.cpp:556-558 > I think you want to remove the if clause now No, this part is a bit different from the above hunk, it uses the xOutput by default, and if that is empty, falls back to kscreen's currentModeId or the pre

[Differential] [Closed] D2374: [kded] fix monitoring for newly appearing outputs

2016-08-09 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN68423ccdf3f8: [kded] fix monitoring for newly appearing outputs (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2374?vs=5770&id=5771 REV

[Differential] [Updated, 10 lines] D2374: [kded] fix monitoring for newly appearing outputs

2016-08-09 Thread Sebastian Kügler
sebas updated this revision to Diff 5770. sebas added a comment. - Also connect disconnected outputs REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2374?vs=5747&id=5770 BRANCH sebas/newdockoutputs REVISION DETAIL https://phabricator.kde.org/D2374

[Differential] [Updated, 10 lines] D2374: [kded] fix monitoring for newly appearing outputs

2016-08-08 Thread Sebastian Kügler
sebas updated this revision to Diff 5747. sebas added a comment. - use unique connection REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2374?vs=5746&id=5747 BRANCH sebas/newdockoutputs REVISION DETAIL https://phabricator.kde.org/D2374 AFFECTED FI

[Differential] [Request, 10 lines] D2374: [kded] fix monitoring for newly appearing outputs

2016-08-08 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch makes the kded daemon monitor also newly connected outputs, and leads to correctly initialize output

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

2016-08-08 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366470 --- Comment #4 from Sebastian Kügler --- Ah. Why in progress though? Who is working on it? -- You are receiving this mail because: You are the assignee for the bug.

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

2016-08-08 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366470 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org Resolution

[Differential] [Accepted] D2371: [Wayland] Make it possible to have internal windows decorated

2016-08-08 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWIN KWin BRANCH internal-window-deco REVISION DETAIL https://phabricator.kde.org/D2371 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

Re: Plasma 5.8 and openSUSE 42.2

2016-08-05 Thread Sebastian Kügler
to revisit this. Maybe we should put more emphasis on the LTS release, do this regularly (perhaps once a year), and ship stable, but feature releases more often. We may or may not ship these with bugfix updates. Food for thought. Cheers, -- sebas Sebastian Kügler•http://vizZzion

Re: Selecting a Plasma logo

2016-08-05 Thread Sebastian Kügler
hat's also fine, but it explains where this confusion comes from. Personally, I find it unfortunate that you do not want any changes to the logo. I can undestand it, but given its basic design is quite popular, I think it's a shame to ask people not to change it. I respect your

[Differential] [Accepted] D2359: [libinput] Add support for gesture events

2016-08-05 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH libinput-gesture-support REVISION DETAIL https://phabricator.kde.org/D2359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D2234: [platforms/x11] Support output removal in nested setup

2016-08-05 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-x11-nested-support-output-removal REVISION DETAIL https://phabricator.kde.org/D2234 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Accepted] D2353: Change the default color in the color wallpaper plugin

2016-08-05 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH wallpaper-default-color REVISION DETAIL https://phabricator.kde.org/D2353 EMAIL PREFERENCES https://phabricator.kde.org/setti

Re: Review Request 128594: Add a kapptemplate for Plasma Wallpaper

2016-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128594/#review98138 --- Ship it! Ship It! - Sebastian Kügler On Aug. 3, 2016

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/#review98137 --- Ship it! Thanks for the perseverance! - Sebastian Kügler

[Differential] [Requested A Review Of] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-02 Thread Sebastian Kügler
sebas requested a review of this revision. REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D2330 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, dvratil, graesslin Cc: graesslin, plasma-devel, #plasma, ali-mohame

Re: Selecting a Plasma logo

2016-08-02 Thread Sebastian Kügler
On dinsdag 2 augustus 2016 14:11:25 CEST Thomas Pfeiffer wrote: > On 01.08.2016 15:11, Thomas Pfeiffer wrote: > > So, it looks like there are two variants which people are quite fond of, > > Ken's modifications of Andy's logo (his fourth), and of Alex's logo (his > > second). > > > > The second ha

[Differential] [Closed] D2336: update CRTCs before enabling an output

2016-08-02 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREENc2e1becccec9: update CRTCs before enabling an output (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2336?vs=5639&id=5640

[Differential] [Request, 3 lines] D2336: update CRTCs before enabling an output

2016-08-02 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: dvratil. sebas added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When connecting the docking station (Lenovo OneLink+), which has a VGA conne

[Differential] [Updated, 19 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-02 Thread Sebastian Kügler
sebas updated this revision to Diff 5638. sebas added a comment. - address comments from mgraesslin and dvratil REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5621&id=5638 BRANCH sebas/modefallback REVISION DETAIL https://phabri

[Differential] [Planned Changes To] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-02 Thread Sebastian Kügler
sebas planned changes to this revision. sebas added inline comments. INLINE COMMENTS > graesslin wrote in xrandrconfig.cpp:517-520 > it looks strange to me that you first access the currentModeId and afterwards > check whether there is a currentMode. > > What about a one liner? > > const int

[Differential] [Updated, 22 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-01 Thread Sebastian Kügler
sebas updated this revision to Diff 5621. sebas added a comment. - make mode id fallback faster REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5620&id=5621 BRANCH sebas/modefallback REVISION DETAIL https://phabricator.kde.org/D2

[Differential] [Commented On] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-01 Thread Sebastian Kügler
sebas added a comment. Here's the backtrace I get without this patch. The crash actually happens inside the debug message, but when it happens, it also means that the mode id we try to pass into xcb_randr_set_crtc_config is invalid (most likely 0) with disabled output: kscreen-docto

[Differential] [Request, 22 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-01 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: dvratil. sebas added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When enabling outputs, it's possible that a KScreen::Output's current mode i

Minutes Monday Plasma Hangout

2016-08-01 Thread Sebastian Kügler
Minutes Plasma 'hangout', 1-8-2016, 12:00 CET Present: mgraesslin, bshah, Sho, sebas, notmart, Riddell, andreas_k, romangg bshah: - mobile images - Mobile image update - Did new image with kactivitymanagerd preinstalled on mobile - Disabled qtvirtualkeyboard on that iamge due to various issues

[Differential] [Closed] D2295: improve logging for kscreen

2016-07-28 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. sebas marked an inline comment as done. Closed by commit rLIBKSCREEN08df8462efd9: unit test Log::context (authored by sebas). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2295?vs=5538&id=5548#toc REPOSITORY rLI

[Differential] [Updated] D1816: Switch to Hack as default monospace font

2016-07-28 Thread Sebastian Kügler
sebas added a reviewer: dhaumann. sebas added a comment. @dhaumann Does this font satisfy your concerns? REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, #plasma, #plasma:_design, dhaumann Cc: s

[Differential] [Closed] D2294: categorized logging for kscreen kcm

2016-07-28 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENca49b5309ca7: categorized logging for kscreen kcm (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2294?vs=5512&id=5539 REVISION DETAIL

[Differential] [Commented On] D2295: improve logging for kscreen

2016-07-28 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > davidedmundson wrote in log.cpp:136 > why call instance() from inside a member function? > it'll always return this. Log::log(...) is static. REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/log REVISION DETAIL https://phabricator.kde.or

[Differential] [Accepted] D2219: Add option to enable volume feedback

2016-07-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D2219#42920, @drosca wrote: > > Can we expect canberra to be available everywhere PA is? > > KF5 kmix has it as non-option

[Differential] [Commented On] D2219: Add option to enable volume feedback

2016-07-28 Thread Sebastian Kügler
sebas added a comment. In https://phabricator.kde.org/D2219#42870, @colomar wrote: > Is the feedback only played when there is no other source playing? > If not, it should be done like that. If you already have something playing, it's just annoying to play an additional sound, and does

<    1   2   3   4   5   6   7   8   9   10   >