This revision was automatically updated to reflect the committed changes.
Closed by commit R116:96203335b408: Before requesting a scan, check the time
threshold (authored by meven).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23578?
meven updated this revision to Diff 68120.
meven added a comment.
Rebasing
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23578?vs=67595&id=68120
BRANCH
arcpatch-D23578
REVISION DETAIL
https://phabricator.kde.org/D23578
AFFEC
jgrulich accepted this revision.
jgrulich added a comment.
Alright, I believe you are correct.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
arcpatch-D23578
REVISION DETAIL
https://phabricator.kde.org/D23578
To: meven, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren
meven added inline comments.
INLINE COMMENTS
> meven wrote in main.qml:77
> I removed this because
>
> 1:
> Request scan failure should never happen anymore because the handler makes
> sure never to call requestScan too often.
> The timer can just constantly ask for request scans it does not im
meven added inline comments.
INLINE COMMENTS
> jgrulich wrote in main.qml:77
> What about this?
I removed this because
1:
Request scan failure should never happen anymore because the handler makes sure
never to call requestScan too often.
The timer can just constantly ask for request scans it
meven updated this revision to Diff 67595.
meven marked 5 inline comments as done.
meven added a comment.
Rebase, clean wirelessScanTimerEnabled, better use delete
m_wirelessScanRetryTimer.take to clean m_wirelessScanRetryTimer hashmap, add
some comments
REPOSITORY
R116 Plasma Network Mana
jgrulich added inline comments.
INLINE COMMENTS
> jgrulich wrote in main.qml:77
> I wonder whether the timer in the applet itself should be running if we fail
> to scan, I think it should be stopped when we fail and resumed again when a
> successful scan was done. If I do get it correctly and w
meven added inline comments.
INLINE COMMENTS
> jgrulich wrote in handler.cpp:552
> This timer never gets deleted.
timer will be one of the value of hash m_wirelessScanRetryTimer, which are
cleaned line 516.
I could be missing a delete there though such as `delete
m_wirelessScanRetryTimer.remov
jgrulich added inline comments.
INLINE COMMENTS
> main.qml:77
> id: handler
> -onWirelessScanTimerEnabled: {
> -if (enabled) {
I wonder whether the timer in the applet itself should be running if we fail to
scan, I think it should be stopped when we fail and resumed
meven added a comment.
@jgrulich if you could have a second look, I improved this because my
previous code could have prevented requestScan to be fired.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
arcpatch-D23578
REVISION DETAIL
https://phabricator.kde.org/D23578
To: meve
meven updated this revision to Diff 66060.
meven added a comment.
Add a timer per interface allowing to scan devices as soon as technically
possible, rescheduling wifi scan for when it will be possible
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://pha
meven updated this revision to Diff 66015.
meven added a comment.
Improve code and make it cleaner
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23578?vs=65003&id=66015
BRANCH
arcpatch-D23578
REVISION DETAIL
https://phabricat
meven updated this revision to Diff 65003.
meven added a comment.
Account for method name change in networkmanager-qt
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23578?vs=64985&id=65003
BRANCH
master
REVISION DETAIL
https:/
meven updated this revision to Diff 64985.
meven added a comment.
remove a space
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23578?vs=64984&id=64985
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23578
AFFECTED
meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
meven requested review of this revision.
REVISION SUMMARY
Currently we don't follow the documented way to check requestScan res
15 matches
Mail list logo
