Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2366 --- Ship it! this can go in as a draft of what will be there for 4.4 fina

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-09-14 21:26:48.596052) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 366 > > > > > > this is only needed if m_showOnlyRemovable changes, correct? > >

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 366 > > > > > > this is only needed if m_showOnlyRemovable changes, correct? > >

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 366 > > > > > > this is only needed if m_showOnlyRemovable changes, correct? > >

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 366 > > > > > > this is only needed if m_showOnlyRemovable changes, correct? > >

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp, > > line 374 > > > > > > KMessageBox blocks all of plasma when used; use > > Plasma::Applet

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > is the latest version the most recent available version of the patch? > > because it doesn't apply cleanly to trunk. > > > > anyways ... i really don't like the "how long to show the popup" > > configuration item and the other 2 config items do

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > is the latest version the most recent available version of the patch? > > because it doesn't apply cleanly to trunk. > > > > anyways ... i really don't like the "how long to show the popup" > > configuration item and the other 2 config items do

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > is the latest version the most recent available version of the patch? > > because it doesn't apply cleanly to trunk. > > > > anyways ... i really don't like the "how long to show the popup" > > configuration item and the other 2 config items do

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > is the latest version the most recent available version of the patch? > > because it doesn't apply cleanly to trunk. > > > > anyways ... i really don't like the "how long to show the popup" > > configuration item and the other 2 config items do

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:44:22, Aaron Seigo wrote: > > is the latest version the most recent available version of the patch? > > because it doesn't apply cleanly to trunk. > > > > anyways ... i really don't like the "how long to show the popup" > > configuration item and the other 2 config items do

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:47:12, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp, > > line 87 > > > > > > when is this not the case? > > wrote: > i took that pi

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-09-11 21:32:17.946758) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

> On 2009-09-11 19:47:12, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp, > > line 87 > > > > > > when is this not the case? i took that piece of code from p

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2300 --- /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespac

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2298 --- is the latest version the most recent available version of the patch?

Re: Review Request: big revamp of Device Notifier

On 2009-09-10 18:18:27, Giulio Camuffo wrote: > > I still don't like the fact that you have to click twice to select the > > action if there is only one available action.. we should find a solution > > for this.. > > Giulio Camuffo wrote: > I agree. > Maybe we could show the actions on

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2289 --- /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurat

Re: Review Request: big revamp of Device Notifier

On 2009-09-10 18:18:27, Giulio Camuffo wrote: > > I still don't like the fact that you have to click twice to select the > > action if there is only one available action.. we should find a solution > > for this.. > > Giulio Camuffo wrote: > I agree. > Maybe we could show the actions on

Re: Review Request: big revamp of Device Notifier

> On 2009-09-10 18:18:27, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp, > > line 194 > > > > > > May I ask why do you need to go backward? > > wrote: > Sinc

Re: Review Request: big revamp of Device Notifier

On Friday 11 September 2009 05:56:52 Giulio Camuffo wrote: > > > On 2009-09-10 18:18:27, Jacopo De Simoi wrote: > > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui, > > > line 63 > > > > > > >

Re: Review Request: big revamp of Device Notifier

On 2009-09-10 18:18:27, Giulio Camuffo wrote: > > I still don't like the fact that you have to click twice to select the > > action if there is only one available action.. we should find a solution > > for this.. > > Giulio Camuffo wrote: > I agree. > Maybe we could show the actions on

Re: Review Request: big revamp of Device Notifier

> On 2009-09-10 18:18:27, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui, > > line 63 > > > > > > I am not a native speaker either.. but this "the" seems strange

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2266 --- Much better as for code and configuration, there are just a few remark

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-09-01 16:55:56.303861) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

> On 2009-08-29 21:00:29, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 204 > > > > > > We probably need to change this; > > Either show every time

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2213 --- I previously overlooked this; the mounting procedure should belong to

Re: Review Request: big revamp of Device Notifier

> On 2009-08-29 21:00:29, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 204 > > > > > > We probably need to change this; > > Either show every time

Re: Review Request: big revamp of Device Notifier

> On 2009-08-24 12:43:32, Aaron Seigo wrote: > > i'm not going to look at the code just yet. instead i'd like to focus on > > what's exposed in the configuration dialog first. then we can get to code :) > > > > automounting: that's already been discussed on the mailing list so we can > > skip

Re: Review Request: big revamp of Device Notifier

> On 2009-08-29 21:00:29, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 204 > > > > > > We probably need to change this; > > Either show every time

Re: Review Request: big revamp of Device Notifier

In data lunedì 24 agosto 2009 14:32:03, David Baron ha scritto: : > >Is this the one that has been on kde-look for a while? Sounds like it. > > > >This is a worthy revamp of the original device-notifier plasmoid and in > > 4.3 > > it > > >is actually readable. The "last mounted" tooltip is of quest

Re: Review Request: big revamp of Device Notifier

> On 2009-08-29 21:00:29, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 204 > > > > > > We probably need to change this; > > Either show every time

Re: Review Request: big revamp of Device Notifier

> On 2009-08-24 12:43:32, Aaron Seigo wrote: > > i'm not going to look at the code just yet. instead i'd like to focus on > > what's exposed in the configuration dialog first. then we can get to code :) > > > > automounting: that's already been discussed on the mailing list so we can > > skip

Re: Review Request: big revamp of Device Notifier

On Sunday 30 August 2009 08:43:52 David Baron wrote: > ...last but not least, the bug I reported about this thing sitting on > hald/dbus. This too me is a showstopper. The original device notifier > certainly does not do this. Uhm, afaiu the dependency has been removed as requested by Kevin...

Re: Review Request: big revamp of Device Notifier

...last but not least, the bug I reported about this thing sitting on hald/dbus. This too me is a showstopper. The original device notifier certainly does not do this. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/list

Re: Review Request: big revamp of Device Notifier

> The "last mounted" tooltip is of questionable usefulness. I would like very much to get rid of it, also the information it shows is (mostly) redundant and if the applet is not in a panel it looks plain awful. The last plugged in device is usually the one on top of all the others. There is an

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2180 --- - Jacopo On 2009-08-21 19:26:43, Giulio Camuffo wrote: > >

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2179 --- In general I like it quite a lot! Nice nice nice! I've a few comments:

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2172 --- Looks much better regarding the issues I raised. Thanks a lot for your

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2143 --- Hi there, thanks for working on this, I've been mostly disconnected fo

Re: Review Request: big revamp of Device Notifier

>Is this the one that has been on kde-look for a while? Sounds like it. >This is a worthy revamp of the original device-notifier plasmoid and in 4.3 it >is actually readable. The "last mounted" tooltip is of questionable >usefulness. This baby, at least the last kde-look.org version of it, is

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2133 --- i'm not going to look at the code just yet. instead i'd like to focus

Re: Review Request: big revamp of Device Notifier

2009/8/22 Kevin Ottens > On Saturday 22 August 2009 10:33:56 Alessandro Diaferia wrote: > > I've tested the patch and it works correctly. I'd clean indentation a > > little before committing. Just waiting until sunday before committing so, > > if someone is against the patch, speak now or shut up

Re: Review Request: big revamp of Device Notifier

On Saturday 22 August 2009 10:33:56 Alessandro Diaferia wrote: > I've tested the patch and it works correctly. I'd clean indentation a > little before committing. Just waiting until sunday before committing so, > if someone is against the patch, speak now or shut up forever =) Please wait for me t

Re: Review Request: big revamp of Device Notifier

2009/8/22 Giulio Camuffo > > 2009/8/21 Alessandro Diaferia > > > > > 2009/8/21 Giulio Camuffo > > > > > >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote: > > >> > > >> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifie > > >>r.h, line 106 > > >> > > >> > > < > > >>

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-08-21 19:26:43.299357) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

2009/8/21 Alessandro Diaferia > > > 2009/8/21 Giulio Camuffo > >> >> >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote: >> > > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h, >> line 106 >> > > < >> http://reviewboard.kde.org/r/1370/diff/3/?file=10433#file104

Re: Review Request: big revamp of Device Notifier

> On 2009-08-21 17:23:18, Alessandro Diaferia wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h, > > line 106 > > > > > > consider deleting white spaces > > eh, the problem with whit

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2112 --- The patch looks pretty good to me and really a great step forward in u

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-08-21 14:05:09.360260) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

> On 2009-08-20 18:39:43, Kevin Ottens wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 338 > > > > > > Urgh! Please no! > > > > You're hard depending on HAL now

Re: Review Request: big revamp of Device Notifier

> On 2009-08-21 13:15:51, Beat Wolf wrote: > > how much does this overlap with > > http://wm161.net/2009/08/12/device-automounter-in-kdereview-srpm-for-fedora-11/ > > ? well, as Kevin said in his comment, I should remove the automounter from my patch because in 4.4 there will be an automounter

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2106 --- how much does this overlap with http://wm161.net/2009/08/12/device-aut

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-08-21 12:47:32.535164) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

> On 2009-08-20 18:39:43, Kevin Ottens wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 369 > > > > > > And what will happen for computers faster/slower than your? You sh

Re: Review Request: big revamp of Device Notifier

2009/8/20 Björn Ruberg > On Donnerstag 20 August 2009, David Baron wrote: > > Is this the one that has been on kde-look for a while? Sounds like it. > > > > This is a worthy revamp of the original device-notifier plasmoid and in > 4.3 > > it is actually readable. The "last mounted" tooltip is of

Re: Review Request: big revamp of Device Notifier

On Donnerstag 20 August 2009, David Baron wrote: > Is this the one that has been on kde-look for a while? Sounds like it. > > This is a worthy revamp of the original device-notifier plasmoid and in 4.3 > it is actually readable. The "last mounted" tooltip is of questionable > usefulness. Yes, it i

Re: Review Request: big revamp of Device Notifier

Is this the one that has been on kde-look for a while? Sounds like it. This is a worthy revamp of the original device-notifier plasmoid and in 4.3 it is actually readable. The "last mounted" tooltip is of questionable usefulness. ___ Plasma-devel maili

Re: Review Request: big revamp of Device Notifier

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2100 --- First of all thanks for undertaking the difficult task to improve the

Re: Review Request: big revamp of Device Notifier

2009/8/20 Giulio Camuffo > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1370/ > --- > > Review request for Plasma. > > > Summary >