Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote: Good thinking, and in fact this is the idea that first came to my mind. But, as you would've noticed, the experience on clicking the button isn't very natural now because you aren't really pressing the button. Another (and better,

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 3, 2014, 3:03 p.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51799 --- mediaelements/mediacontroller/MediaController.qml

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 3, 2014, 3:13 p.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51801 --- Ship it! Ship It! - Shantanu Tushar On March 3, 2014,

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51802 --- This review has been submitted with commit

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
On March 3, 2014, 3:21 p.m., Commit Hook wrote: This review has been submitted with commit a76d23770ae075c55d0b3cc063cc1a073c639ad6 by Shantanu Tushar to branch master. It is pleasure to made some contribution to the KDE. Also i hope to Do more to the plasma-Media center. Thanks you

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51601 --- Good thinking, and in fact this is the idea that first came

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Rukshan Chathuranga
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote: Good thinking, and in fact this is the idea that first came to my mind. But, as you would've noticed, the experience on clicking the button isn't very natural now because you aren't really pressing the button. Another (and better,

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Shantanu Tushar
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote: Good thinking, and in fact this is the idea that first came to my mind. But, as you would've noticed, the experience on clicking the button isn't very natural now because you aren't really pressing the button. Another (and better,

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Rukshan Chathuranga
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote: Good thinking, and in fact this is the idea that first came to my mind. But, as you would've noticed, the experience on clicking the button isn't very natural now because you aren't really pressing the button. Another (and better,

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51408 --- mediaelements/mediacontroller/MediaController.qml

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 10:19 a.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51416 --- The whitespace is still there, if you see diff here on

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51423 --- mediaelements/mediacontroller/MediaController.qml

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 12:42 p.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51430 --- I've got good news and bad news. The good news is, the wheel

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 3:03 p.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
On March 1, 2014, 12:57 p.m., Shantanu Tushar wrote: I've got good news and bad news. The good news is, the wheel works perfect! The bad news is that the MouseEventListener eats up clicks and hence the volumeButton never gets clicked which then means that you won't be able to show

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
On March 1, 2014, 12:57 p.m., Shantanu Tushar wrote: I've got good news and bad news. The good news is, the wheel works perfect! The bad news is that the MouseEventListener eats up clicks and hence the volumeButton never gets clicked which then means that you won't be able to show

Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- Review request for Plasma. Repository: plasma-mediacenter Description

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 --- Your diff contains commented out changes to

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Shantanu Tushar
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 7:27 a.m.) Review request for Plasma. Changes