Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- (Updated Sept. 17, 2014, 5:48 nachm.) Status -- This change has been

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 p.m., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDial

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 nachm., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDi

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 6:36 p.m., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDial

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 nachm., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDi

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 nachm., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDi

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 p.m., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) Hmm I also don't really like how different from KConfigDialog this still is ... color

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66282 --- I'm sorry to reopen, but my clock config dialog now looks like

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- (Updated Sept. 11, 2014, 12:56 p.m.) Status -- This change has been

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > Should be good, tough is better to put screenshot in the review request if > > the patch is about visual changes > > Kai Uwe Broulik wrote: > I would have if the internet weren't that slow... right :) so yeah, ship it - Marco ---

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > Should be good, tough is better to put screenshot in the review request if > > the patch is about visual changes I would have if the internet weren't that slow... > On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > desktoppackage

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66228 --- Should be good, tough is better to put screenshot in the revie

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66226 --- Ship it! Woo, I like patches with lots of red :) Looks good

Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- Review request for Plasma. Repository: plasma-desktop Description -