Re: [pmapper-users] Plugins modifications

2013-08-19 Thread Armin Burger
OK, it was a trial. Trunk now set back to old compression function http://svn.pmapper.net/trac/changeset/1319 armin On 08/19/2013 03:19 PM, Chris forum wrote: > Same here, loading time back to 'normal' when compressJavaScriptFilePM is > used. > > > On Fri, Aug 16, 2013 at 7:18 PM, Armin Burger

Re: [pmapper-users] Plugins modifications

2013-08-19 Thread Chris forum
Same here, loading time back to 'normal' when compressJavaScriptFilePM is used. On Fri, Aug 16, 2013 at 7:18 PM, Armin Burger wrote: > I can at least confirm that the compression using JSMinPlus takes > noticeably longer to load the js_session.php (and somehow subsequently > js_config.php). Som

Re: [pmapper-users] Plugins modifications

2013-08-16 Thread Armin Burger
I can at least confirm that the compression using JSMinPlus takes noticeably longer to load the js_session.php (and somehow subsequently js_config.php). Something like 215 ms compared to 12 ms on my desktop PC. This for sure depends on the server etc. So I guess it's better switching back to th

Re: [pmapper-users] Plugins modifications

2013-08-16 Thread Armin Burger
Chris I could only guess that this is related to the new way how the JS files of the plugins are compressed, using "JSMinPlus". The check for custom JS files under the config directories was there also before, now they are just referenced in the phtml file at a different place. That huge diffe

Re: [pmapper-users] Plugins modifications

2013-08-16 Thread Chris forum
Hi Armin, I have just installed pmapper from trunk r1318 to test your modifications on my project. I didn't try to add any plugin custom JS file yet. I don't know if it is the process to look for custom JS files or the new JS compression tool, but with that pmapper release my project takes more t

Re: [pmapper-users] Plugins modifications

2013-08-10 Thread Armin Burger
The JS custom files loading should now be solved with separate loading of those files from the config directories. See changeset 1316 http://svn.pmapper.net/trac/changeset/1316 To use it you need to replace the files under incphp with the new versions and add a line echo $jsCustomReference;

Re: [pmapper-users] Plugins modifications

2013-07-29 Thread Chris forum
Thx a lot for the detailed info! I think I will keep it simple though and try what Armin has suggested with another custom.js dedicated for the plugins. On Mon, Jul 29, 2013 at 12:19 PM, Thomas RAFFIN wrote: > Indeed I've modified the core code to compress files in the same order > than if the

Re: [pmapper-users] Plugins modifications

2013-07-29 Thread Thomas RAFFIN
Indeed I've modified the core code to compress files in the same order than if they were included without compression (in my version js files are not included in js_session.php). It is complicated to compare with the "clean pmapper code", because 1) my version is using differently the configura

Re: [pmapper-users] Plugins modifications

2013-07-29 Thread Chris forum
Hi Thomas, Just checked, even with 5 the custom.js is still read before the plugins JS file What compression function are you using and where? On Mon, Jul 29, 2013 at 10:48 AM, Thomas RAFFIN wrote: > Hi, > > Try to inactivate the compression (debug level = 5 I think) and tell us > if the cust

Re: [pmapper-users] Plugins modifications

2013-07-29 Thread Thomas RAFFIN
Hi, Try to inactivate the compression (debug level = 5 I think) and tell us if the custom.js is before or after the plugins files please? AFAIK I don't use the same compression functions than in "standard" pmapper. So all js files are compressed in the same order than if they were included wit

Re: [pmapper-users] Plugins modifications

2013-07-29 Thread Chris forum
Ok I see. Thanx for the tips, I am going to try adding a custom_plugin.js file. I will also check if the plugins I modified are available as a class. On Fri, Jul 26, 2013 at 7:04 PM, Armin Burger wrote: > The problem is that the custom.js file from your config directory is > loaded before the pl

Re: [pmapper-users] Plugins modifications

2013-07-26 Thread Armin Burger
The problem is that the custom.js file from your config directory is loaded before the plugin JS files, so they will not have any effect The cleanest way would be to separate the custom JS files from the default JS files. Currently there is a a single check and all are referenced at the same ti

[pmapper-users] Plugins modifications

2013-07-26 Thread Chris forum
Hi all, Now that Thomas has updated several plugins, I realise I shouldn't have customized them in their own directories. I am now trying to put my changes back into custom.css and custom.js, in order to not loose them at the next general update. I am first trying to do that with the Coordinates