Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-11-08 Thread Vadim Zhukov
2013/11/8 Stuart Cassoff : > On 10/01/13 14:41, Stuart Cassoff wrote: >> On 10/01/13 12:07, Vadim Zhukov wrote: >>> 2013/10/1 Stuart Cassoff : On 07/11/13 18:39, Stuart Cassoff wrote: > On 07/11/13 17:21, Vadim Zhukov wrote: >> 2013/7/7 Stuart Cassoff : >>> Tested by me for all typ

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-11-08 Thread Stuart Cassoff
On 10/01/13 14:41, Stuart Cassoff wrote: > On 10/01/13 12:07, Vadim Zhukov wrote: >> 2013/10/1 Stuart Cassoff : >>> On 07/11/13 18:39, Stuart Cassoff wrote: On 07/11/13 17:21, Vadim Zhukov wrote: > 2013/7/7 Stuart Cassoff : >> Tested by me for all types of substitution. >> Also, I'

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-10-01 Thread Stuart Cassoff
On 10/01/13 12:07, Vadim Zhukov wrote: > 2013/10/1 Stuart Cassoff : >> On 07/11/13 18:39, Stuart Cassoff wrote: >>> On 07/11/13 17:21, Vadim Zhukov wrote: 2013/7/7 Stuart Cassoff : > Tested by me for all types of substitution. > Also, I've been running with it for a while with no adver

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-10-01 Thread Vadim Zhukov
2013/10/1 Stuart Cassoff : > On 07/11/13 18:39, Stuart Cassoff wrote: >> On 07/11/13 17:21, Vadim Zhukov wrote: >>> 2013/7/7 Stuart Cassoff : Tested by me for all types of substitution. Also, I've been running with it for a while with no adverse effects. I don't know which ports this

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-10-01 Thread Stuart Cassoff
On 07/11/13 18:39, Stuart Cassoff wrote: > On 07/11/13 17:21, Vadim Zhukov wrote: >> 2013/7/7 Stuart Cassoff : >>> Tested by me for all types of substitution. >>> Also, I've been running with it for a while with no adverse effects. >>> I don't know which ports this will affect. Can't be too many. >

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-07-11 Thread Stuart Cassoff
On 07/11/13 17:21, Vadim Zhukov wrote: > 2013/7/7 Stuart Cassoff : >> Tested by me for all types of substitution. >> Also, I've been running with it for a while with no adverse effects. >> I don't know which ports this will affect. Can't be too many. >> Does your previous patch cover them? > > Yes

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-07-11 Thread Vadim Zhukov
2013/7/7 Stuart Cassoff : > Tested by me for all types of substitution. > Also, I've been running with it for a while with no adverse effects. > I don't know which ports this will affect. Can't be too many. > Does your previous patch cover them? Yes, it is; it contains all necessary bumps there.

Re: Fixup path adjustment in Tcl/Tk ports

2013-07-09 Thread Stuart Cassoff
On 05/26/13 06:25, Vadim Zhukov wrote: > 2013/5/25 Stuart Cassoff > >> On 05/06/13 15:10, Vadim Zhukov wrote: >>> This patch cleans up path adjustments in Tcl/Tk ports. List of changes: >> >> Thanks for taking time to work on this. >> >> >>> * MODTCL_WISH_ADJ is renamed to MODTK_WISH_ADJ and mo

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-07-07 Thread Stuart Cassoff
Tested by me for all types of substitution. Also, I've been running with it for a while with no adverse effects. I don't know which ports this will affect. Can't be too many. Does your previous patch cover them? Stu On 07/07/13 14:48, Vadim Zhukov wrote: > 15.06.2013 9:03 пользователь "Stuart Ca

Re: Fixup path adjustment in Tcl/Tk ports, take 5

2013-07-07 Thread Vadim Zhukov
15.06.2013 9:03 пользователь "Stuart Cassoff" написал: > > After some discussion with Vadim Zhukov (takes 3 and 4) > and reviewing everything everyone else said. Sorry for the late answer, missed this letter in my backlog. Looks fine to me. If this version is tested, and with adding bumps to por

Fixup path adjustment in Tcl/Tk ports, take 5

2013-06-14 Thread Stuart Cassoff
After some discussion with Vadim Zhukov (takes 3 and 4) and reviewing everything everyone else said. Stu Index: tcl.port.mk === RCS file: /cvs/ports/lang/tcl/tcl.port.mk,v retrieving revision 1.14 diff -u -p -u -p -r1.14 tcl.port.mk

Re: Fixup path adjustment in Tcl/Tk ports, take 2

2013-05-28 Thread Stuart Cassoff
On 05/27/13 14:34, Vadim Zhukov wrote: > So here is a second try, after input from stu@. Differences from > previous version: > > * More compact and correct whitespace handling (with some ideas from > stu@'s diff); > > * Rewrite both tclsh and wish lines in both macros; > > * Use MODTC

Fixup path adjustment in Tcl/Tk ports, take 2

2013-05-27 Thread Vadim Zhukov
So here is a second try, after input from stu@. Differences from previous version: * More compact and correct whitespace handling (with some ideas from stu@'s diff); * Rewrite both tclsh and wish lines in both macros; * Use MODTCL_BIN also for rewritting "exec" lines in shell snippets;

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-26 Thread Vadim Zhukov
2013/5/25 Stuart Cassoff > On 05/06/13 15:10, Vadim Zhukov wrote: > > This patch cleans up path adjustments in Tcl/Tk ports. List of changes: > > Thanks for taking time to work on this. > > > > * MODTCL_WISH_ADJ is renamed to MODTK_WISH_ADJ and moved to a more > > appropriate place - tk.por

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Stuart Henderson
On 2013/05/25 16:53, Landry Breuil wrote: > On Sat, May 25, 2013 at 02:01:04PM +0200, Dmitrij Czarkoff wrote: > > On Sat, May 25, 2013 at 9:47 AM, Stuart Cassoff wrote: > > > On 05/06/13 15:10, Vadim Zhukov wrote: > > >> * MODTCL_TCLSH_ADJ and MODTCL_WISH_ADJ now use full path for > > >> replac

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Landry Breuil
On Sat, May 25, 2013 at 02:01:04PM +0200, Dmitrij Czarkoff wrote: > On Sat, May 25, 2013 at 9:47 AM, Stuart Cassoff wrote: > > On 05/06/13 15:10, Vadim Zhukov wrote: > >> * MODTCL_TCLSH_ADJ and MODTCL_WISH_ADJ now use full path for replacement > > > > Others have requested this as well. Ok. > >

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Stuart Henderson
On 2013/05/25 14:01, Dmitrij Czarkoff wrote: > On Sat, May 25, 2013 at 9:47 AM, Stuart Cassoff wrote: > > On 05/06/13 15:10, Vadim Zhukov wrote: > >> * MODTCL_TCLSH_ADJ and MODTCL_WISH_ADJ now use full path for replacement > > > > Others have requested this as well. Ok. > > > > > >> instead

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Dmitrij Czarkoff
On Sat, May 25, 2013 at 9:47 AM, Stuart Cassoff wrote: > On 05/06/13 15:10, Vadim Zhukov wrote: >> * MODTCL_TCLSH_ADJ and MODTCL_WISH_ADJ now use full path for replacement > > Others have requested this as well. Ok. > > >> instead of "#!/usr/bin/env ..." trick; > > It's not a trick, it's a p

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Stuart Cassoff
On 05/25/13 05:40, Stuart Cassoff wrote: > On 05/25/13 05:12, Stuart Henderson wrote: >> On 2013/05/25 03:47, Stuart Cassoff wrote: instead of "#!/usr/bin/env ..." trick; >>> >>> It's not a trick, it's a perfectly cromulent way to start a script >>> and some people write their scripts like

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Stuart Cassoff
On 05/25/13 05:12, Stuart Henderson wrote: > On 2013/05/25 03:47, Stuart Cassoff wrote: >>> instead of "#!/usr/bin/env ..." trick; >> >> It's not a trick, it's a perfectly cromulent way to start a script >> and some people write their scripts like that. > > Using the full path protects against

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Stuart Henderson
On 2013/05/25 03:47, Stuart Cassoff wrote: > > instead of "#!/usr/bin/env ..." trick; > > It's not a trick, it's a perfectly cromulent way to start a script > and some people write their scripts like that. Using the full path protects against certain cases of blundering numbskullery where PAT

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-25 Thread Stuart Cassoff
On 05/06/13 15:10, Vadim Zhukov wrote: > This patch cleans up path adjustments in Tcl/Tk ports. List of changes: Thanks for taking time to work on this. > * MODTCL_WISH_ADJ is renamed to MODTK_WISH_ADJ and moved to a more > appropriate place - tk.port.mk; This has come up before. I like t

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-15 Thread Stuart Cassoff
On 05/14/13 12:12, Stuart Cassoff wrote: > > Thanks for taking the time for this. > Looking at it today; estimated time for my reply is 6 hrs from now. > I'm not sure I agree with all the changes, but we'll see soon enough. > Apologies. I should never estimate. rsn, Stu

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-15 Thread Sebastian Reitenbach
On Tuesday, May 14, 2013 16:48 CEST, Vadim Zhukov wrote: > 2013/5/6 Vadim Zhukov > > > This patch cleans up path adjustments in Tcl/Tk ports. List of changes: > > > > * MODTCL_WISH_ADJ is renamed to MODTK_WISH_ADJ and moved to a more > > appropriate place - tk.port.mk; > > * MODTCL_

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-14 Thread Stuart Cassoff
On 05/14/13 10:48, Vadim Zhukov wrote: > 2013/5/6 Vadim Zhukov > >> This patch cleans up path adjustments in Tcl/Tk ports. List of changes: >> >> * MODTCL_WISH_ADJ is renamed to MODTK_WISH_ADJ and moved to a more >> appropriate place - tk.port.mk; >> * MODTCL_TCLSH_ADJ and MODTCL_WISH_ADJ

Re: Fixup path adjustment in Tcl/Tk ports

2013-05-14 Thread Vadim Zhukov
2013/5/6 Vadim Zhukov > This patch cleans up path adjustments in Tcl/Tk ports. List of changes: > > * MODTCL_WISH_ADJ is renamed to MODTK_WISH_ADJ and moved to a more > appropriate place - tk.port.mk; > * MODTCL_TCLSH_ADJ and MODTCL_WISH_ADJ now use full path for replacement > instead

Fixup path adjustment in Tcl/Tk ports

2013-05-06 Thread Vadim Zhukov
This patch cleans up path adjustments in Tcl/Tk ports. List of changes: * MODTCL_WISH_ADJ is renamed to MODTK_WISH_ADJ and moved to a more appropriate place - tk.port.mk; * MODTCL_TCLSH_ADJ and MODTCL_WISH_ADJ now use full path for replacement instead of "#!/usr/bin/env ..." trick; *