Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Alexandre Ratchov
On Fri, Nov 21, 2014 at 02:41:32AM +0100, Dmitrij D. Czarkoff wrote: Anthony J. Bentley said: There's at least one more obvious issue: when I pause music or video, I can't unpause... Apparently the workaround in audio_resume() function was causing this bug. (Not sure why, as the function

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread frantisek holop
Alexandre Ratchov, 22 Nov 2014 11:22: IMHO we should keep the message because upstream developpers have added it for a reason. We could add a second message right after the sio_stop() call to appreciate the time sio_stop() takes and if this is annoying find a solution. In other words, let's

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread frantisek holop
Dmitrij D. Czarkoff, 21 Nov 2014 02:41: Anthony J. Bentley said: There's at least one more obvious issue: when I pause music or video, I can't unpause... Apparently the workaround in audio_resume() function was causing this bug. (Not sure why, as the function exited just fine.)

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Stuart Henderson
This method of fetching waf doesn't work, | install: /usr/ports/distfiles/waf-1.7.16: No such file or directory and files used in the build need to be in DISTFILES not SUPDISTFILES. I have to say, I'm very un-keen on using this self-extracting waf distribution with no easy way to look at the

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread frantisek holop
Dmitrij D. Czarkoff, 21 Nov 2014 02:41: Anthony J. Bentley said: There's at least one more obvious issue: when I pause music or video, I can't unpause... Apparently the workaround in audio_resume() function was causing this bug. (Not sure why, as the function exited just fine.)

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Stuart Henderson
On 2014/11/22 15:41, frantisek holop wrote: Dmitrij D. Czarkoff, 21 Nov 2014 02:41: Anthony J. Bentley said: There's at least one more obvious issue: when I pause music or video, I can't unpause... Apparently the workaround in audio_resume() function was causing this bug. (Not

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Stuart Henderson
On 2014/11/22 15:55, frantisek holop wrote: some ports guru might have a trick for this yeah, use the autoconf build in old-configure instead :-)

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread frantisek holop
Stuart Henderson, 22 Nov 2014 14:53: I have to say, I'm very un-keen on using this self-extracting waf distribution with no easy way to look at the contents, it isn't something we should be encouraging in ports. all the waf versions have checksums on their official site and the mpv 'bootstrap'

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread frantisek holop
Stuart Henderson, 22 Nov 2014 15:01: On 2014/11/22 15:55, frantisek holop wrote: some ports guru might have a trick for this yeah, use the autoconf build in old-configure instead :-) could we focus on the port please? :) waf is a very minor distraction, and if the stupid file was included

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread frantisek holop
Dmitrij D. Czarkoff, 21 Nov 2014 02:41: Anthony J. Bentley said: There's at least one more obvious issue: when I pause music or video, I can't unpause... Apparently the workaround in audio_resume() function was causing this bug. (Not sure why, as the function exited just fine.)

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Stuart Henderson
On 2014/11/22 16:07, frantisek holop wrote: Stuart Henderson, 22 Nov 2014 15:01: On 2014/11/22 15:55, frantisek holop wrote: some ports guru might have a trick for this yeah, use the autoconf build in old-configure instead :-) could we focus on the port please? :) er, the port could

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread frantisek holop
frantisek holop, 22 Nov 2014 16:03: incidentally, mpv has moved on to a newer waf version: https://github.com/mpv-player/mpv/blob/master/bootstrap.py -WAF =waf-1.7.16 +WAF =waf-1.8.1 ok, this is only for post-0.6.2, please ignore. -f -- in

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Brad Smith
On 11/22/14 10:22, Stuart Henderson wrote: y'all autoconf junkies have a heavy version of the stockholm syndrome :p all autoconfiguration systems that I've seen suck, but at least we know how to work with autoconf (and to a lesser extent cmake) without going insane ;) Exactly, it's what

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Dmitrij D. Czarkoff
Alexandre Ratchov said: For testing, you could temprorarily set par.appbufsz to a huge value (eg. 48000) to make synchronization problems (if any) more obvious. Tested with par.appbufsz=48000. While impact on pausing is significant, after resume playback appears to be perfectly synchronized.

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Alexandre Ratchov
On Sat, Nov 22, 2014 at 03:01:58PM +, Stuart Henderson wrote: On 2014/11/22 15:55, frantisek holop wrote: some ports guru might have a trick for this yeah, use the autoconf build in old-configure instead :-) iirc, the configure shell script is human readable, probably not generated by

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Dmitrij D. Czarkoff
Alexandre Ratchov said: iirc, the configure shell script is human readable, probably not generated by autotools. Indeed. Another version of this port, now based on old* infrastructure is attached. FWIW it lost quite a few WANTLIB entries, although mostly those related to particular codecs; as

Re: NEW: x11/mpv [0.6.2]

2014-11-22 Thread Dmitrij D. Czarkoff
Dmitrij D. Czarkoff said: Alexandre Ratchov said: iirc, the configure shell script is human readable, probably not generated by autotools. Indeed. Another version of this port, now based on old* infrastructure is attached. FWIW it lost quite a few WANTLIB entries, although mostly those

Re: NEW: x11/mpv [0.6.2]

2014-11-20 Thread Alexandre Ratchov
On Thu, Nov 20, 2014 at 02:43:05AM +0100, Dmitrij D. Czarkoff wrote: Henrik Friedrichsen said: I understand. I have attached another version that fetches all the files in the fetch phase. Could you give it another try? I made some changes to the port. (See attached tarball for

Re: NEW: x11/mpv [0.6.2]

2014-11-20 Thread Alexandre Ratchov
On Wed, Nov 19, 2014 at 08:45:50PM -0700, Anthony J. Bentley wrote: Dmitrij D. Czarkoff writes: FWIW on my ThinkPad E325 the performance of mpv is really bad. (MPlayer does no good here either, although ffplay copes with everything just fine.) I also noticed that it has problems with

Re: NEW: x11/mpv [0.6.2]

2014-11-20 Thread Alexandre Ratchov
On Thu, Nov 20, 2014 at 08:45:45AM +0100, Dmitrij D. Czarkoff wrote: Anthony J. Bentley said: Not sure if this is related, but sound is very choppy for me, and: AV: 00:05:23 / 01:40:58 (5%) A-V: 0.020 [ao/sndio] Blocking until remaining audio is played... (sndio design bug). was

Re: NEW: x11/mpv [0.6.2]

2014-11-20 Thread Dmitrij D. Czarkoff
Alexandre Ratchov said: sorry, don't have the time to test debug this right now, but a quick look at the ao_sndio.c suggest that blocking mode is used, while the device is opened in non-blocking mode: p-hdl = sio_open(p-dev, SIO_PLAY, 1); ^^ could you

Re: NEW: x11/mpv [0.6.2]

2014-11-20 Thread Anthony J. Bentley
Hi Alexandre, Alexandre Ratchov writes: sorry, don't have the time to test debug this right now, but a quick look at the ao_sndio.c suggest that blocking mode is used, while the device is opened in non-blocking mode: p-hdl = sio_open(p-dev, SIO_PLAY, 1);

Re: NEW: x11/mpv [0.6.2]

2014-11-20 Thread Dmitrij D. Czarkoff
Anthony J. Bentley said: There's at least one more obvious issue: when I pause music or video, I can't unpause... Apparently the workaround in audio_resume() function was causing this bug. (Not sure why, as the function exited just fine.) Attached revision of the port fixes that by replacing

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Henrik Friedrichsen
Hey, because I'd really like to see this port included and since the OP has not responded so far, I took the liberty to work on the port. On Thu, Nov 13, 2014 at 03:35:41AM +0100, Henrik Friedrichsen wrote: Some notes: - multimedia/libdvdnav is required - You probably shouldn't hardcode

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread frantisek holop
Henrik Friedrichsen, 19 Nov 2014 19:55: On Thu, Nov 13, 2014 at 03:35:41AM +0100, Henrik Friedrichsen wrote: Some notes: - multimedia/libdvdnav is required - You probably shouldn't hardcode /usr/local, but instead use ${LOCALBASE} - During the initial check it says: Bluray support:

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Landry Breuil
On Wed, Nov 19, 2014 at 09:18:54PM +0100, frantisek holop wrote: Henrik Friedrichsen, 19 Nov 2014 19:55: On Thu, Nov 13, 2014 at 03:35:41AM +0100, Henrik Friedrichsen wrote: Some notes: - multimedia/libdvdnav is required - You probably shouldn't hardcode /usr/local, but instead

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Dmitrij D. Czarkoff
Henrik Friedrichsen said: - Bootstrap and download the recommended waf with the script provided This sounds very wrong. Also, systrace blocks this step. Consequently, port does not build. -- Dmitrij D. Czarkoff

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread frantisek holop
Landry Breuil, 19 Nov 2014 21:30: On Wed, Nov 19, 2014 at 09:18:54PM +0100, frantisek holop wrote: Henrik Friedrichsen, 19 Nov 2014 19:55: On Thu, Nov 13, 2014 at 03:35:41AM +0100, Henrik Friedrichsen wrote: Some notes: - multimedia/libdvdnav is required - You probably

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Dmitrij D. Czarkoff
Landry Breuil said: waf ? no fucking way. We got rid of that utter piece of crap for a reason Could you please elaborate on this? You suggest custom Makefile in ports? Or you suggest avoiding mpv because of its waf-based build system? Or something else? -- Dmitrij D. Czarkoff

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Henrik Friedrichsen
Hey, On Wed, Nov 19, 2014 at 09:43:06PM +0100, Dmitrij D. Czarkoff wrote: This sounds very wrong. Also, systrace blocks this step. Consequently, port does not build. I understand. I have attached another version that fetches all the files in the fetch phase. Could you give it another try?

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Dmitrij D. Czarkoff
Henrik Friedrichsen said: I understand. I have attached another version that fetches all the files in the fetch phase. Could you give it another try? I made some changes to the port. (See attached tarball for details.) FWIW on my ThinkPad E325 the performance of mpv is really bad.

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Henrik Friedrichsen
Thanks a lot for your changes. They all seem reasonable and help me understanding how things are done in OpenBSD ports. Looking at existing ports is not always ideal, as they often seem to do things differently from how they should be done now. On Thu, Nov 20, 2014 at 02:43:05AM +0100, Dmitrij D.

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Dmitrij D. Czarkoff
Henrik Friedrichsen said: You have disabled libdvdnav and moved it to BUILD_DEPENDS. Was this intentional? No, I disabled libdvdnav by mistake and moved it to BUILD_DEPENDS when ``make package'' said it wasn't needed in LIB_DEPENDS, as I was mistakenly assuming that it was linked in statically.

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Anthony J. Bentley
Dmitrij D. Czarkoff writes: FWIW on my ThinkPad E325 the performance of mpv is really bad. (MPlayer does no good here either, although ffplay copes with everything just fine.) I also noticed that it has problems with unmuting if master output was muted before mpv started. To really unmute I

Re: NEW: x11/mpv [0.6.2]

2014-11-19 Thread Dmitrij D. Czarkoff
Anthony J. Bentley said: Not sure if this is related, but sound is very choppy for me, and: AV: 00:05:23 / 01:40:58 (5%) A-V: 0.020 [ao/sndio] Blocking until remaining audio is played... (sndio design bug). was added in this commit:

Re: NEW: x11/mpv [0.6.2]

2014-11-12 Thread Henrik Friedrichsen
Hey, Some notes: - multimedia/libdvdnav is required - You probably shouldn't hardcode /usr/local, but instead use ${LOCALBASE} - During the initial check it says: Bluray support: no If BluRay does not work with the current libbluray version, you should probably remove the dependency or

NEW: x11/mpv [0.6.2]

2014-11-10 Thread Jakub Skrzypnik
Dear ports@, I've attached a Makefile and DESCR for mpv. It'a new mplayer2 fork with more improvements over origin and cleaned code. It's my first port, but I want to contribute to OpenBSD project with pushing more ports in the future ;) -- Jakub Skrzypnik jot.skr...@gmail.com Makefile