Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-15 Thread Julius Volz
Yeah! While it's not as high priority because fewer people implement and use it, it would still be great to have :) On Thu, Apr 15, 2021, 16:16 Mat Arye wrote: > Thanks to Tom and Julius for the work! > > Would there be interest in a remote_read compliance test as well? If so, > my team would

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-15 Thread Mat Arye
Thanks to Tom and Julius for the work! Would there be interest in a remote_read compliance test as well? If so, my team would be happy to write it and contribute, but only if people think it's useful (and it's not already being worked on by others). On Thu, Apr 15, 2021 at 4:58 AM Julius Volz

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-14 Thread Bartłomiej Płotka
Sounds good, thanks Tom for this work! Kind Regards, Bartek Płotka (@bwplotka) On Wed, Apr 14, 2021 at 1:33 PM Tom Wilkie wrote: > SGTM, I've moved it to https://github.com/prometheus/compliance (and > moved all the remote_write code to a subdirectory). > > Cheers > > Tom > > On Wed, Apr 14,

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-14 Thread Tom Wilkie
SGTM, I've moved it to https://github.com/prometheus/compliance (and moved all the remote_write code to a subdirectory). Cheers Tom On Wed, Apr 14, 2021 at 4:34 AM Callum Styan wrote: > Repo in prometheus org makes the most sense to me as well. > > On Tue, Apr 13, 2021 at 3:04 PM Julien

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Julien Pivotto
I am in favour of a repo in the prometheus org. On 13 Apr 22:08, Julius Volz wrote: > Nope, they are run as a binary that takes flags, a config, and outputs JSON > / TEXT / TSV / CSV for consumption by humans / website code / etc. > >

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Julius Volz
Nope, they are run as a binary that takes flags, a config, and outputs JSON / TEXT / TSV / CSV for consumption by humans / website code / etc. https://github.com/promlabs/promql-compliance-tester/blob/master/cmd/promql-compliance-tester/main.go On Tue, Apr 13, 2021 at 9:50 PM Tom Wilkie wrote:

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Tom Wilkie
Yeah I’m fine with either - but would probably prefer a single big repo. Are your PromQl tests golang unit tests by any chance? On Tue, 13 Apr 2021 at 20:36, Julius Volz wrote: > I'm fine with the main org too. Then there's just the question of whether > we have one big compatibility repo for

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Julius Volz
I'm fine with the main org too. Then there's just the question of whether we have one big compatibility repo for remote_write / PromQL / etc., or one for each tested interface. There's definitely pros + cons for each approach, but I'd ultimately be fine with either I think. On Tue, Apr 13, 2021

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Tom Wilkie
I only suggested the -community org so its not in my personal org, to encourage contributions from the wider community. I would be happy to move it to the main prometheus org. As a monorepo guy, I'm less keen on a proliferation of many orgs so less keen on a dedicated prometheus-compatibility

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Richard Hartmann
On Tue, Apr 13, 2021 at 2:16 PM Julius Volz wrote: > Great! I think as we start taking compatibility more seriously, we could even > create a home for remote_write / PromQL / ... compatibility tests in either > the main Prometheus org, or in a dedicated "Prometheus Compatibility Project" >

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Julius Volz
Great! I think as we start taking compatibility more seriously, we could even create a home for remote_write / PromQL / ... compatibility tests in either the main Prometheus org, or in a dedicated "Prometheus Compatibility Project" org? On Tue, Apr 13, 2021 at 2:12 PM Tom Wilkie wrote: > Hello

[prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Tom Wilkie
Hello Prometheans! In preparation for my PromCon talk, I build a little test suite the checks various Prometheus Remote Write compatible "agents": https://github.com/tomwilkie/remote-write-compliance There are ~13 pretty simple tests, and each one exports some metrics, forks off the "agent"