[Puppet-dev] [PATCH/puppet 2/2] (#4258) Use pkgutil -a to reliably determine package common names/aliases

2011-03-18 Thread Dominic Cleal
Populate instances with both the real package name ("CSWsvn") and the alias name ("subversion") from separate "pkgutil -a" call. Fixed cases where pkgutil noise was parsed as aliased package names and also breaking "not in catalog" detection. Updated pkgutil_spec test to show various edge cases.

[Puppet-dev] [PATCH/puppet 1/2] (#4258) Update pkgutil spec for recent impl changes

2011-03-18 Thread Dominic Cleal
Fix test output of pkgutil for commands using --single Fix expected upgrade command to match impl Signed-off-by: Dominic Cleal --- spec/unit/provider/package/pkgutil_spec.rb | 22 +- 1 files changed, 9 insertions(+), 13 deletions(-) diff --git a/spec/unit/provider/package/

Re: [Puppet-dev] Re: [PATCH/puppet 19/19] (#4258) pkgutil provider: better handling of short package names

2011-03-18 Thread Dominic Cleal
On 15/03/11 13:24, Dominic Cleal wrote: > On 10/03/11 08:03, Juerg Walz wrote: >> Thanks for the feedback, Dominic. >> I've never actually ran it with debugging turned on (again, I'm fairly >> new to Puppet, and Ruby). I need to read up on the prefetching and >> what's expected in the alias. My mod

[Puppet-dev] [PATCH/puppet 1/1] (#6658) Propagate ENC connection errors to the agent

2011-03-18 Thread Matt Robinson
When the master failed to run the External Node Classifier script it would log an error on the master, but the agent didn't get back the full error or the stack trace for it's logs. By raising when there's an ENC script problem on the master, this causes the error messages to propagate to the agen

Re: [Puppet-dev] Managing network devices in core

2011-03-18 Thread James Turnbull
Luke Kanies wrote: > > What I mean is, I looked through the code for that before, and I > concluded it could easily be turned into a module. I just wasn't > specifically looking for whether any changes needed to be made to core. I think at least 2-3 of Brice's patches added methods to Puppet::U

Re: [Puppet-dev] Managing network devices in core

2011-03-18 Thread Luke Kanies
On Mar 18, 2011, at 2:10 PM, Markus Roberts wrote: > >> This is mostly to Brice, but I figure others are interested. >> >> We've been looking at what it will take to get the network device support >> prototype as implemented by Brice into core, along with the fact that we'll >> be producing th

Re: [Puppet-dev] Managing network devices in core

2011-03-18 Thread Markus Roberts
> This is mostly to Brice, but I figure others are interested. >> >> We've been looking at what it will take to get the network device support >> prototype as implemented by Brice into core, along with the fact that we'll >> be producing the RC1 for statler on April 13, and I don't think it will ma

Re: [Puppet-dev] Managing network devices in core

2011-03-18 Thread Luke Kanies
On Mar 18, 2011, at 11:47 AM, Markus Roberts wrote: > > > This is mostly to Brice, but I figure others are interested. > > We've been looking at what it will take to get the network device support > prototype as implemented by Brice into core, along with the fact that we'll > be producing the

[Puppet-dev] Re: [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-18 Thread Michael Knox
It's been bugging me for a while that when I run Puppet from the command line, I don't see the changes that Augeas does/will make as we do with the file type. There seem to be 2 requests for this: https://projects.puppetlabs.com/issues/2728 http://projects.puppetlabs.com/issues/5400 I haven't

Re: [Puppet-dev] Splitting exec type into type & provider

2011-03-18 Thread Markus Roberts
> On Fri, Mar 18, 2011 at 11:36 AM, Markus Roberts > wrote: > > One thought, looking through the code (I haven't given it a thorough read > > yet) is that it may make sense to split the MS Windows provider off from > the > > posixs provider (though that's out of scope here, I think). > It definit

Re: [Puppet-dev] Debugging Puppet on Windows

2011-03-18 Thread Markus Roberts
On Fri, Mar 18, 2011 at 12:07 PM, Jay Flowers wrote: > I finally got some more time to work on this. I ended up getting RubyMine > setup and configured for me to develop and debug with. > > I logged a bug on this: > https://projects.puppetlabs.com/issues/6773 > > If someone can give me a clue I

Re: [Puppet-dev] Debugging Puppet on Windows

2011-03-18 Thread Jay Flowers
I finally got some more time to work on this. I ended up getting RubyMine setup and configured for me to develop and debug with. I logged a bug on this: https://projects.puppetlabs.com/issues/6773 If someone can give me a clue I can fix this and supply a patch. Thanks On Sun, Mar 13, 2011 at 6

Re: [Puppet-dev] Splitting exec type into type & provider

2011-03-18 Thread Matt Robinson
It definitely makes sense now that exec actually has providers. As you say though, this was out of scope for the work we were currently doing which was just to split as much as possible to allow the shell provider and test things as much as possible. The exec type and provider are by no means bea

Re: [Puppet-dev] Managing network devices in core

2011-03-18 Thread Markus Roberts
This is mostly to Brice, but I figure others are interested. > > We've been looking at what it will take to get the network device support > prototype as implemented by Brice into core, along with the fact that we'll > be producing the RC1 for statler on April 13, and I don't think it will make > t

Re: [Puppet-dev] Splitting exec type into type & provider

2011-03-18 Thread Markus Roberts
One thought, looking through the code (I haven't given it a thorough read yet) is that it may make sense to split the MS Windows provider off from the posixs provider (though that's out of scope here, I think). -- M --- When in trouble or in

[Puppet-dev] [PATCH/puppet 1/1] (#4884) Remove typo from spec test

2011-03-18 Thread Max Martin
One of the stubs was accidentally stubbing for /bin/foo instead of /bin/true. Reviewed-by:Nick Lewis Signed-off-by: Max Martin --- spec/unit/type/exec_spec.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spec/unit/type/exec_spec.rb b/spec/unit/type/exec_spec.rb inde

Re: [Puppet-dev] Splitting exec type into type & provider

2011-03-18 Thread Max Martin
Kudos are also due to Daniel for a lot of the work in this series. On Thu, Mar 17, 2011 at 11:01 PM, Daniel Pittman wrote: > On Thu, Mar 17, 2011 at 20:12, Nigel Kersten wrote: > > On Thu, Mar 17, 2011 at 1:42 PM, Max Martin wrote: > > > >> This series of patches breaks some of the existing fun

[Puppet-dev] [PATCH/puppet 1/1] (#4884) Modify tests to pass on non-OS X systems

2011-03-18 Thread Max Martin
Fixed problems with the spec tests for the new exec type and providers that were causing failures on non-OS X systems. This involved rearranging some of the tests and their describe blocks, which makes the diff look more dramatic than it really is. Paired-with:Matt Robinson, Jacob Helwig Signed-o

[Puppet-dev] Managing network devices in core

2011-03-18 Thread Luke Kanies
Hi all, This is mostly to Brice, but I figure others are interested. We've been looking at what it will take to get the network device support prototype as implemented by Brice into core, along with the fact that we'll be producing the RC1 for statler on April 13, and I don't think it will make

Re: [Puppet-dev] Re: [Puppet Users] Re: ANNOUNCE: Facter 1.5.9rc2

2011-03-18 Thread James Turnbull
Stig Sandbeck Mathisen wrote: And also, what is the arp fact supposed to _do_? For now, it returns the MAC address of a random neighbour on my network interfaces. The fact was created to supplement the EC2 facts - it helps us constraint those to only run when they are on EC2. Regards Jame

[Puppet-dev] [PATCH/facter] (#6763) Use Facter::Util::Resolution.exec for arp

2011-03-18 Thread Todd Zullinger
The arp command is in /sbin on Fedora/RHEL, not /usr/sbin. Using Facter::Util::Resolution.exec is preferable to hard-coding the path. --- lib/facter/arp.rb |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/facter/arp.rb b/lib/facter/arp.rb index 65cf4c3..5035ad0

[Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-18 Thread Michael Knox
From: Michael Knox Utilising Augeas's SAVE_NEWFILE mode (similar to augtool -n) to determine the changes that will be made be made by Augeas. Output a unified diff to info Signed-off-by: Mike Knox --- lib/puppet/provider/augeas/augeas.rb | 12 ++-- 1 files changed, 10 insertions(+),

[Puppet-dev] Re: [Puppet Users] Re: ANNOUNCE: Facter 1.5.9rc2

2011-03-18 Thread Stig Sandbeck Mathisen
Thomas Bendler writes: > don't know if it's a bug or related to the packages but facter search > arp at /usr/sbin/arp but on CentOS 5 it is at /sbin/arp. And also, what is the arp fact supposed to _do_? For now, it returns the MAC address of a random neighbour on my network interfaces. -- Stig

[Puppet-dev] Re: [Puppet Users] ANNOUNCE: Facter 1.5.9rc2

2011-03-18 Thread Stig Sandbeck Mathisen
Jacob Helwig writes: > Facter 1.5.9rc2 is a maintenance release containing fixes and updates. Hello, and thanks for a new release candidate. I've uploaded a packaged version to Debian experimental, it should be visible on http://packages.qa.debian.org/f/facter.html shortly. -- Stig Sandbeck M