[Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-09 Thread Ashley Penney
Hi, Over the last few days I've spent some time refactoring the puppetlabs-ntp module to be a little bit more modern in style and not to be one giant class. As a result I've released a release candidate and I wanted to give users of the module a headsup to take a look at the differences and possib

Re: [Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-10 Thread Matthias Saou
On Tue, 9 Jul 2013 18:21:52 -0400 Ashley Penney wrote: > http://forge.puppetlabs.com/puppetlabs/ntp/1.0.0-rc1 or github is > where you can grab the latest if you're willing to test it. > > If you have any feedback regarding the general design of the module > this is an excellent place to hash it

Re: [Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-10 Thread Francis Pereira
How do you get the service to restart if the config file changes ? ~Francis http://7terminals.com On Wed, Jul 10, 2013 at 2:44 PM, Matthias Saou wrote: > On Tue, 9 Jul 2013 18:21:52 -0400 > Ashley Penney wrote: > > > http://forge.puppetlabs.com/puppetlabs/ntp/1.0.0-rc1 or github is > > where

Re: [Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-10 Thread Matthias Saou
On Wed, 10 Jul 2013 17:09:25 +0530 Francis Pereira wrote: > How do you get the service to restart if the config file changes ? Look at the ~> (and not ->) at the bottom of init.pp, where the config class notifies the service class : Anchor['ntp::begin'] -> Class['::ntp::install'] -> Class['

Re: [Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-10 Thread Francis Pereira
Thanks Matthias ~Francis http://7terminals.com On Wed, Jul 10, 2013 at 5:31 PM, Matthias Saou wrote: > On Wed, 10 Jul 2013 17:09:25 +0530 > Francis Pereira wrote: > > > How do you get the service to restart if the config file changes ? > > Look at the ~> (and not ->) at the bottom of init.pp

Re: [Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-10 Thread Trevor Vaughan
Just out of curiosity, has anyone done a performance analysis on moving to the Anchor -> Class dependency structure? Since these classes are small, it shouldn't be *too* bad but I can see issues with using this pattern blindly in terms of memory usage and catalog size/transmission size. Alternati

Re: [Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-10 Thread jcbollinger
On Wednesday, July 10, 2013 9:03:02 AM UTC-5, Trevor Vaughan wrote: > > Just out of curiosity, has anyone done a performance analysis on moving to > the Anchor -> Class dependency structure? > > Since these classes are small, it shouldn't be *too* bad but I can see > issues with using this patt

Re: [Puppet Users] puppetlabs-ntp 1.0.0-rc1

2013-07-10 Thread Ashley Penney
On Wed, Jul 10, 2013 at 5:14 AM, Matthias Saou wrote: > > It looks really nice and clean! I would personally only have a few very > minor nitpicks : > > * Shouldn't the placeholder files/README.markdown be removed? > * Space between class name and parenthesis inconsistency : >"class foo(...