[issue17920] Documentation: "complete ordering" should be "total ordering"

2013-05-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: It can be closed now. Thanks for the reminder. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue17930] Search not needed in combinations_with_replacement

2013-05-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks Tim :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue17908] Unittest runner needs an option to call gc.collect() after each test

2013-05-10 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue11406] There is no os.listdir() equivalent returning generator instead of list

2013-05-10 Thread Ben Hoyt
Ben Hoyt added the comment: > Please bring this up on python-dev. Good idea. Thread started: http://mail.python.org/pipermail/python-dev/2013-May/126119.html -- ___ Python tracker

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: > 2. Mike Bayer (SQL Alchemy author) has requested the ability to derive a > custom metaclass that turns off the Enums-with-members-are-final > subclassing restriction (relaxing the rule that members of an enum are > instances of that enum to "members of an enum a

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: On Fri, May 10, 2013 at 8:09 PM, Nick Coghlan wrote: > > Nick Coghlan added the comment: > > Two requests: > > 1. Lose the frame hack. With the explicit "module=__name__" API available, > the implicit fragile magic isn't necessary and leads to Enum instances that

[issue12535] Chained tracebacks are confusing because the first traceback is minimal

2013-05-10 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Nick Coghlan
Nick Coghlan added the comment: Two requests: 1. Lose the frame hack. With the explicit "module=__name__" API available, the implicit fragile magic isn't necessary and leads to Enum instances that may or may not support pickling depending on the implementation. Better to say "if you use the f

[issue1551113] random.choice(setinstance) fails

2013-05-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: Sorry, this is still rejected for the reasons that Tim mentioned. -- ___ Python tracker ___ ___

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: By the way, if anyone is willing to take on the documentation, that could be of great help. It shouldn't be very hard since PEP 435 is extremely detailed. The stdlib .rst doc would be the descriptions from PEP 435 plus a reference of the exposed classes which i

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-10 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue16694] Add pure Python operator module

2013-05-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4b3238923b01 by Raymond Hettinger in branch 'default': Issue #16694: Add source code link for operator.py http://hg.python.org/cpython/rev/4b3238923b01 -- ___ Python tracker

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Stefan Mihaila added the comment: On 5/10/2013 11:46 PM, Stefan Mihaila wrote: > Changes by Stefan Mihaila : > > > -- > nosy: +mstefanro > > ___ > Python tracker > > ___ > Hello. I

[issue17951] TypeError during gdb backtracing

2013-05-10 Thread Catalin Patulea
New submission from Catalin Patulea: With libpython.py loaded in gdb, when backtracing and trying to pretty-print frame objects along the way, this error is sometimes raised: Python Exception object of type 'FakeRepr' has no len() See attached patch against tip. -- components: Demos

[issue14191] argparse doesn't allow optionals within positionals

2013-05-10 Thread paul j3
paul j3 added the comment: I should note one caveat: As a consequence of setting nargs to 0 for the first 'parse_know_args' step, all positional entries in the namespace get an empty list value ([]). This is produced by 'ArgumentParser._get_values'. With the builtin action classes this does

[issue17950] Dynamic classes contain non-breakable reference cycles

2013-05-10 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Hello Antoine. 1) Yes, I am not completely happy with the approach myself, but I'd like to get the ball rolling. One particular nuance is that there appears to be a way to provide a custom MRO, one which does not enforce the rule that the self type co

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Changes by Stefan Mihaila : Removed file: http://bugs.python.org/file30211/780722877a3e.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Changes by Stefan Mihaila : Added file: http://bugs.python.org/file30211/780722877a3e.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread mirabilos
mirabilos added the comment: + dest is always aligned on common platforms + (if sizeof(PyASCIIObject) is divisible by SIZEOF_LONG). Actually, that’s the part that is not

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread mirabilos
mirabilos added the comment: I’m currently thinking this patch. (Will need another day or so for compiles to finish, though.) -- Added file: http://bugs.python.org/file30210/python3.3_3.3.1-1+m68k.1.debdiff ___ Python tracker

[issue17944] Refactor test_zipfile

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, the first patch includes only this change (plus some needed regrouping and renaming). The second patch in additional wraps long lines, uses asserts with better error reporting, has better resource management ("with" operator and addCleanup), and contain

[issue17950] Dynamic classes contain non-breakable reference cycles

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: > 1) the mro tuple in the type object is "nerfed" to contain a > Py_None reference in its first place I like the idea, but I find the implementation (the new macros) quite convoluted. I think special-casing the first tuple element where necessary would be clea

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Ethan Furman
Ethan Furman added the comment: Round 4. I wonder if I should have used two digits to number the patches. ;) -- Added file: http://bugs.python.org/file30209/pep-0435_4.patch ___ Python tracker ___

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread mirabilos
mirabilos added the comment: Currently 22; it will increase to 24 if a few more bits are added. That’s why I said it’s “fragile” magic. -- ___ Python tracker ___ ___

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Changes by Stefan Mihaila : -- nosy: +mstefanro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is sizeof(PyASCIIObject) on m68k? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I think we can be bold and put #if !defined(__m68k__) and #endif > around the entire block and, should there ever be another architecture > with similar issues, whitelist them there. Agreed. -- ___ Python tracker

[issue1545463] New-style classes fail to cleanup attributes

2013-05-10 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: belopolsky -> status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread mirabilos
mirabilos added the comment: file30203/ascii_decode_nonaligned.patch is potentially a nop (the struct being a multiple of, in the m68k case 4, bytes is not an indicator of whether to skip it). I think we can be bold and put #if !defined(__m68k__) and #endif around the entire block and, should

[issue17950] Dynamic classes contain non-breakable reference cycles

2013-05-10 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Adding file demonstraing the problem. -- Added file: http://bugs.python.org/file30208/classleak.py ___ Python tracker ___ __

[issue17950] Dynamic classes contain non-breakable reference cycles

2013-05-10 Thread Kristján Valur Jónsson
New submission from Kristján Valur Jónsson: Classes contain two kinds of cycles back to themselves: 1) in their __mro_ list, the class itself is typically the first member. 2) in the descriptors for various fields such as __dict__. The problem here is that there is no way to break the cycle. A

[issue17944] Refactor test_zipfile

2013-05-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: As I understand this, the main refactoring is to put the tests duplicated for zlib, bz2, and lzma into a master class that is then subclasses=d for each of the compressors. This looks like a great idea. -- nosy: +terry.reedy __

[issue17898] gettext bug while parsing plural-forms metadata

2013-05-10 Thread Steve Strassmann
Steve Strassmann added the comment: Sorry, I haven't installed python 3.*, I just have default Mac OS python 2.7. Here's a minimal test case. Tar expands to file structure: ./test.py

[issue17945] tkinter/Python 3.3.0: peer_create doesn't instantiate Text

2013-05-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: (This issue only applies to 3.3+ because the method is new in 3.3.) Gregory: 'works for me' means that the issue can be closed without a patch because Python actually 'works' for the example presented. I presume you mean that the tkinter works *after* you appl

[issue14191] argparse doesn't allow optionals within positionals

2013-05-10 Thread Glenn Linderman
Glenn Linderman added the comment: paul j3: Regarding earlier versions of these files - I do not see a way of deleting them. Click on edit, then there is an option to unlink. I don't know if they ever actually get deleted, but it clears out the clutter when looking for the latest version. W

[issue17939] Misleading information about slice assignment in docs

2013-05-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since range objects have a known length, that example is not enough to show 'any iterable'. However, generators do not even have a __length_hint__ and they work too. a = [1,2,3] a[0:1] = (i for i in range(4)) print(a) >>> [0, 1, 2, 3, 2, 3] -- nosy:

[issue14191] argparse doesn't allow optionals within positionals

2013-05-10 Thread paul j3
paul j3 added the comment: 'parse_fallback_args()' function is only in the 'test_intermixed.py' file, not the patch. It should be in the 'if __name__' section of that file, along with the modified 'exit()' method, since it is part of these testing suit, not meant to be imported. 'test_interm

[issue17930] Search not needed in combinations_with_replacement

2013-05-10 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue17906] JSON should accept lone surrogates

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I forgot about issue11489. After reclassification this issue is it's duplicate. -- resolution: -> duplicate superseder: -> json.dumps not parsable by json.loads (on Linux only) ___ Python tracker

[issue11489] json.dumps not parsable by json.loads (on Linux only)

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I forgot about this issue and open a new issue17906. There is a patch for it. Simplejson has accepted it in https://github.com/simplejson/simplejson/issues/62. RFC 4627 does not make exceptions for the range 0xD800-0xDFFF (unescaped = %x20-21 / %x23-5B / %x

[issue17905] Add check for locale.h

2013-05-10 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue17898] gettext bug while parsing plural-forms metadata

2013-05-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since the other two listed inner-loop issues apply to 3.x, I would guess that this does also. Steve, can you test with 3.3? And provide a *minimal* test case? -- nosy: +terry.reedy stage: -> test needed ___ Python

[issue12425] gettext breaks on empty plural-forms value

2013-05-10 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1475523] gettext breaks on plural-forms header

2013-05-10 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue17895] TemporaryFile name returns an integer in python3

2013-05-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Given that the changed behavior is documented and pretty obviously intentional, it is not a bug. The proposal would have to be that we 'enhance' 3.4 *or later* by reverting back to the 2.x -- and possibly break 3.0 to 3.3 code. We are not going to do that with

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Well, it will be safer to skip this block on such platforms. -- keywords: +patch Added file: http://bugs.python.org/file30203/ascii_decode_nonaligned.patch ___ Python tracker ___

[issue17948] HTTPS and sending a big file size hangs.

2013-05-10 Thread Jesús Vidal Panalés
Jesús Vidal Panalés added the comment: Thank you. I will modify IIS security to disable SSL older verions. -- ___ Python tracker ___ _

[issue17948] HTTPS and sending a big file size hangs.

2013-05-10 Thread James O'Cull
James O'Cull added the comment: I appreciate the response all the same. Thanks for taking the time to look at it, Antoine. -- ___ Python tracker ___

[issue17948] HTTPS and sending a big file size hangs.

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: Closing as won't fix. I hope you'll find a reasonable to deal with this, sorry :-/ -- resolution: -> wont fix status: open -> closed ___ Python tracker __

[issue17948] HTTPS and sending a big file size hangs.

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you for pointing this out. I am frankly shocked that IIS would defaut to SSLv2 (an obsolete and insecure version of the protocol), while Python's (and certainly Mercurial's) default settings allow for higher protocol versions. > If you are interested in

[issue17940] extra code in argparse.py

2013-05-10 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue17927] Argument copied into cell still referenced by frame

2013-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: Martin Morrison, can you check if my fix (cellfree4.diff) applies cleanly to 3.3? Or if nearly so, could you upload a fixed version here? (Or create a new issue and assign it to me if you can't upload to this issue.) -- ___

[issue17948] HTTPS and sending a big file size hangs.

2013-05-10 Thread James O'Cull
James O'Cull added the comment: We have more information on this bug here. It's SSL v2 related when pushing to IIS. http://stackoverflow.com/a/16486104/97964 Here's a paste from the StackOverflow answer: I found a few ways of dealing with this issue: To fix this server-side i

[issue17906] JSON should accept lone surrogates

2013-05-10 Thread Bob Ippolito
Bob Ippolito added the comment: The patch that I wrote for simplejson is here (it differs a bit from serhiy's patch): https://github.com/simplejson/simplejson/commit/35816bfe2d0ddeb5ddcc68239683cbb35b7e3ff2 I discovered another bug along the way in the pure-Python scanstring, int(s, 16) will

[issue17940] extra code in argparse.py

2013-05-10 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +bethard stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Ethan Furman
Ethan Furman added the comment: More adjustments due to review. -- Added file: http://bugs.python.org/file30202/pep-0435_3.patch ___ Python tracker ___ __

[issue17923] test glob with trailing slash fail

2013-05-10 Thread Ezio Melotti
Changes by Ezio Melotti : -- components: +Library (Lib) nosy: +ezio.melotti stage: -> patch review ___ Python tracker ___ ___ Python-

[issue17920] Documentation: "complete ordering" should be "total ordering"

2013-05-10 Thread Ezio Melotti
Ezio Melotti added the comment: Raymond, since this has been merged to default too in e163c13b941c, can the issue be closed or is there something else left to do? -- nosy: +ezio.melotti ___ Python tracker

[issue17907] Deprecate imp.new_module() in favour of types.ModuleType

2013-05-10 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue17468] Generator memory leak

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: The issue17807 patch has now been committed and should solve this issue. I would like to encourage anyone to test this change, as it is quite a significant departure from the previous semantics: http://mail.python.org/pipermail/python-dev/2013-May/126102.html

[issue17927] Argument copied into cell still referenced by frame

2013-05-10 Thread Martin Morrison
Martin Morrison added the comment: Our usage of Python would certainly benefit from the backport. We are embedding Python 3.3 in a system with requirements that lead us to disable the gc in most cases, so cycles are an obvious problem for us. Cycles created inadvertently, such as this, are the

[issue17904] bytes should be listed as built-in function for 2.7

2013-05-10 Thread Ezio Melotti
Ezio Melotti added the comment: Here's a patch. Do you think it should be added under the string signature too? It will make linking easier, but it might be more confusing for users. -- keywords: +patch nosy: +chris.jerdonek, ezio.melotti stage: needs patch -> patch review type: behav

[issue995907] memory leak with threads and enhancement of the timer class

2013-05-10 Thread Charles-François Natali
Charles-François Natali added the comment: I'm attaching a proof of concept code for a ScheduledExecutor interface, and a ScheduledThreadPoolExecutor implementation (unfortunately I can't upload it as a mercurial diff for now). Here's what the API looks like: """ from concurrent.futures import

[issue17949] operator documentation mixup

2013-05-10 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the report and the patch! -- assignee: docs@python -> ezio.melotti nosy: +ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> enhancement ___ Python tracke

[issue17949] operator documentation mixup

2013-05-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9c93a631e95a by Ezio Melotti in branch '2.7': #17949: fix merge glitch in itemgetter signature. Patch by Martijn Pieters. http://hg.python.org/cpython/rev/9c93a631e95a -- nosy: +python-dev ___ Python tra

[issue16523] attrgetter and itemgetter signatures in docs need cleanup

2013-05-10 Thread Martijn Pieters
Martijn Pieters added the comment: The 2.7 patch shifted the `itemgetter()` signature to above the `attrgetter()` change and new notes. New patch to fix that in issue #17949: http://bugs.python.org/issue17949 -- nosy: +mjpieters ___ Python tracker

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread mirabilos
mirabilos added the comment: Antoine: precisely. Serhiy: sure. The times are now in msec per loop. I did three subsequent runs, so the second and third tuple are cache-warm. Without assert: (89,88), (87,87), (89,86) Without block : (79,78), (78,78), (79,78) And in a second run: Without assert

[issue17949] operator documentation mixup

2013-05-10 Thread Martijn Pieters
New submission from Martijn Pieters: Rev 83684 (http://hg.python.org/cpython/rev/5885c02120f0) managed to move the `attrgetter()` `versionadded` and `versionchanged` notes down to the `itemgetter()` documentation instead, by moving the `itemgetter()` signature *up* above these lines. Now the

[issue17944] Refactor test_zipfile

2013-05-10 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file30197/test_zipfile_2.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue17883] Fix buildbot testing of Tkinter

2013-05-10 Thread Zachary Ware
Zachary Ware added the comment: Thanks for your response, Martin. Martin v. Löwis wrote: > Zach: Temporarily committing changes to test specific buildbot issues > is fine I suppose it would also be beneficial to get some output from the other bots which are *not* failing, to have something to

[issue17927] Argument copied into cell still referenced by frame

2013-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: Ok, the deed is done. Thanks for your review, Benjamin! I've reassigned it to you so you can fix up the test if you want to. What would you think of a backport to 3.3? -- assignee: gvanrossum -> benjamin.peterson resolution: -> fixed

[issue17927] Argument copied into cell still referenced by frame

2013-05-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset d331e14cae42 by Guido van Rossum in branch 'default': #17927: Keep frame from referencing cell-ified arguments. http://hg.python.org/cpython/rev/d331e14cae42 -- nosy: +python-dev ___ Python tracker

[issue1045893] warning '"_POSIX_C_SOURCE" redefined' when include Python.h

2013-05-10 Thread Jonathan Wakely
Jonathan Wakely added the comment: Insisting on including Python.h first is just broken. GNU libc's /usr/include/features.h will override it anyway when _GNU_SOURCE is defined: # undef _POSIX_C_SOURCE # define _POSIX_C_SOURCE200809L # undef _XOPEN_SOURCE # define _XOPEN_SOURCE 700 So i

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Zachary Ware
Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Ethan Furman
Changes by Ethan Furman : -- hgrepos: -189 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Ethan Furman
Ethan Furman added the comment: Incorporated comments. -- Added file: http://bugs.python.org/file30195/pep-0435_2.patch ___ Python tracker ___ ___

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Alex Gaynor
Changes by Alex Gaynor : -- nosy: +alex ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue14596] struct.unpack memory leak

2013-05-10 Thread Meador Inge
Meador Inge added the comment: > > Serhiy Storchaka added the comment: > > So what about more compact Struct object? I already implemented the count optimization as a part of my patch for implementing PEP 3188 in issue3132. I need to rebaseline the patch. It has gotten stale. Hopefully there

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: Regarding module vs. module_name for the extra param in the functional API, Guido rightly points out in issue 17941 that __module__ is the class attribute, so "module" is a consistent choice. -- ___ Python tracker <

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: On Fri, May 10, 2013 at 7:02 AM, Guido van Rossum wrote: > > Guido van Rossum added the comment: > > Module, please. The class attribute is also called __module__ after all. > Makes sense. Thanks. -- ___ Python track

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: OK, I sent another batch of reviews through the code review system - Ethan you should've gotten an email about it. -- ___ Python tracker ___ ___

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: Module, please. The class attribute is also called __module__ after all. On Friday, May 10, 2013, Eli Bendersky wrote: > > Eli Bendersky added the comment: > > A question that came up while reviewing the new enum code: "module" or > "module_name" for this ext

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: A question that came up while reviewing the new enum code: "module" or "module_name" for this extra argument? The former is shorter, but the latter is more correct in a way. -- ___ Python tracker

[issue5901] missing meta-info in documentation pdf

2013-05-10 Thread A.M. Kuchling
A.M. Kuchling added the comment: This seems to be fixed now. I downloaded python-3.3.1-docs-pdf-letter.tar.bz2 and ran pdfinfo on using.pdf: Title: Python Setup and Usage Subject: Keywords: Author: Guido van Rossum, Fred L. Drake, Jr., editor Creator:LaT

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: I don't see docs in the patch, but perhaps that should be a separate patch to keep reviewing easier. Also, Ethan, number the patch files in some way (like pep-435.1.patch, pep-435.N.patch) as they go through rounds of reviews. -- assignee: docs@python

[issue11016] stat module in C

2013-05-10 Thread Christian Heimes
Christian Heimes added the comment: AP has started to review my patch. I'm not yet sure how we should handle constants and functions when the platform doesn't provide them. For example Windows doesn't have any S_IS*() function like macros and doesn't provide a S_IFBLK constant. We have three

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-10 Thread Eli Bendersky
Changes by Eli Bendersky : Removed file: http://bugs.python.org/file30191/ref435.py ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14596] struct.unpack memory leak

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: So what about more compact Struct object? This is not only memory issue (a Struct object can require several times larger memory than size of processed data), but performance issue (time of creating such object is proportional to it's size). Here is a patch

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could you please repeat the tests with a larger data (1MB or more)? -- ___ Python tracker ___ ___

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Which supports your suspicion that the optimised case may not be needed > at all. So we can just skip the assert when __m68k__ is defined? -- ___ Python tracker ___

[issue5773] Crash on shutdown after os.fdopen(2) in debug builds

2013-05-10 Thread Anselm Kruis
Anselm Kruis added the comment: Hi, I was faced with a very similar problem also caused by an invalid file descriptor. My solution is to set an invalid parameter handler, that does nothing. This effectively disables Dr. Watson. Perhaps this is a suitable solution for other users too. And it

[issue17936] O(n**2) behaviour when adding/removing classes

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Right, I misread the code. > Since the remove_subclass() function is called when a subclass dies, > I don't think it is necessary to clear out weak references in > add_subclass(). They are there merely to break the reference cycle. Agreed. -- __

[issue9687] dbmmodule.c:dbm_contains fails on 64bit big-endian (test_dbm.py fails) when built against gdbm (int vs Py_ssize_t)

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: Should be fixed in issue17926. AFAICT the issue doesn't exist on 3.x. -- resolution: -> duplicate stage: patch review -> committed/rejected status: open -> closed superseder: -> PowerLinux dbm failure in 2.7 versions: -Python 3.1, Python 3.2

[issue17936] O(n**2) behaviour when adding/removing classes

2013-05-10 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Right, I misread the code. Since the remove_subclass() function is called when a subclass dies, I don't think it is necessary to clear out weak references in add_subclass(). They are there merely to break the reference cycle. Btw, the 'patch diff' stu

[issue17926] PowerLinux dbm failure in 2.7

2013-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue9687. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing

[issue9687] dbmmodule.c:dbm_contains fails on 64bit big-endian (test_dbm.py fails) when built against gdbm (int vs Py_ssize_t)

2013-05-10 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17936] O(n**2) behaviour when adding/removing classes

2013-05-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: Py_None is what PyWeakref_GET_OBJECT() returns when the object is dead. (same as calling () on a weakref, really) The patch looks straightforward to me. 2.7 doesn't receive performance fixes, though, except for large regressions. Also, we've had enough regressi

[issue17237] m68k aligns on 16bit boundaries.

2013-05-10 Thread mirabilos
mirabilos added the comment: Hi again, sorry for being a bit late in following up to this. Here are the results for the two runs you requested; these were done on the same machine, intermixed (the first one cache-clean, the second and third run subsequently (so that the third run is cache-fil

[issue16133] asyncore.dispatcher.recv doesn't handle EAGAIN / EWOULDBLOCK

2013-05-10 Thread Xavier de Gaye
Xavier de Gaye added the comment: > Deciding what's best to do at this point without breaking existent > code is not easy, that is why I think that on python <= 3.3 we > should fix *asynchat* in order to take EAGAIN/EWOULDBLOCK into > account and leave asyncore's recv() alone. IMHO for all pytho

[issue17936] O(n**2) behaviour when adding/removing classes

2013-05-10 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: So, any objections? It is pretty straighforward. Btw, the searching for Py_NONE seems to be a rudiment of some older version, there is no place where a Py_NONE is put in there. Also, what is the policy for 2.7? Are performance bugs proper bugs? ---

  1   2   >