Re: [python-committers] Please edit the commit message when merge a PR

2017-08-03 Thread Serhiy Storchaka
11.07.17 19:39, Brett Cannon пише: There's isn't a way to block a merge at that stage. But one thing I've been thinking about is adding a check to Bedevere post-merge that sees if the commit message was left unchanged (not quite sure if I can come up with a reliable heuristic, though). In

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-11 Thread Brett Cannon
On Mon, 10 Jul 2017 at 07:57 Berker Peksağ wrote: > On Mon, Jul 10, 2017 at 4:14 PM, Serhiy Storchaka > wrote: > > When a PR is consistent on several commits, the final commit message > > composed by GitHub contains messages of all these commits:

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-11 Thread Victor Stinner
2017-07-10 17:35 GMT+02:00 Guido van Rossum : > Often the committer has more context to write a proper commit message, and > asking the contributor to do the squash is just wasting time (plus in > general we *don't* want contributors to squash, since that loses the context > for

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-10 Thread Terry Reedy
On 7/10/2017 10:49 AM, Berker Peksağ wrote: On Mon, Jul 10, 2017 at 4:14 PM, Serhiy Storchaka wrote: When a PR is consistent on several commits, the final commit message composed by GitHub contains messages of all these commits: "fix typo", "address yyy comments", "revert

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-10 Thread Guido van Rossum
Often the committer has more context to write a proper commit message, and asking the contributor to do the squash is just wasting time (plus in general we *don't* want contributors to squash, since that loses the context for the review). So I'm with Sergey. This is how we do it in the

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-10 Thread Barry Warsaw
On Jul 10, 2017, at 04:57 PM, Victor Stinner wrote: >I would prefer to ask the author to squash and/or rebase his/her >commits rather than having to edit the commit message myself. I prefer >that the commit message is part of the review, and not only done by >the one who clicks on the Merge

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-10 Thread Victor Stinner
I would prefer to ask the author to squash and/or rebase his/her commits rather than having to edit the commit message myself. I prefer that the commit message is part of the review, and not only done by the one who clicks on the Merge button. It would prefer mistakes in the commit message.

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-10 Thread Berker Peksağ
On Mon, Jul 10, 2017 at 4:14 PM, Serhiy Storchaka wrote: > When a PR is consistent on several commits, the final commit message > composed by GitHub contains messages of all these commits: "fix typo", > "address yyy comments", "revert zzz". If the initial commit message >

[python-committers] Please edit the commit message when merge a PR

2017-07-10 Thread Serhiy Storchaka
When a PR is consistent on several commits, the final commit message composed by GitHub contains messages of all these commits: "fix typo", "address yyy comments", "revert zzz". If the initial commit message contained errors (e.g. absent issue number), it is easy to edit the title and text of