Re: [Python-Dev] cpython (3.2): Stop ignoring Mercurial merge conflits files (#12255).

2011-07-30 Thread Antoine Pitrou
On Fri, 29 Jul 2011 22:22:05 -0400 R. David Murray rdmur...@bitdance.com wrote: On Fri, 29 Jul 2011 23:36:03 +0200, Antoine Pitrou solip...@pitrou.net wrote: On Fri, 29 Jul 2011 12:19:45 -0400 R. David Murray rdmur...@bitdance.com wrote: Besides, hg status is meant to show

Re: [Python-Dev] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Antoine Pitrou
Hi Senthil, +if source_address: self.source_address = source_address Could you try to follow PEP 8? (I know PEP 8 is not always followed in old code, but there's no reason not to follow it in code that we add to the stdlib) +SMTP.__init__(self, host, port, local_hostname =

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Georg Brandl
Am 29.07.2011 11:26, schrieb Barry Warsaw: So I'm curious, why is this move better than adding noindexes, or just trusting users to understand the difference between test.support.unlink() and os.unlink()? If I currently search for 'unlink', os.unlink comes up first, which is good, and that

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Georg Brandl
Am 27.07.2011 19:44, schrieb Terry Reedy: On 7/27/2011 9:24 AM, Antoine Pitrou wrote: Docstrings are sufficient for own our purposes. import test.support as t help(t.rmtree) Help on function rmtree in module test.support: rmtree(path) Well, what are you waiting for... just add the

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Georg Brandl
Am 27.07.2011 19:47, schrieb Terry Reedy: On 7/27/2011 1:27 PM, Brett Cannon wrote: Perhaps what we could do is move the documentation for test.support to the devguide, and then vet the test suite so that unlink and friends are always called as 'support.unlink', etc. I like

Re: [Python-Dev] Draft PEP: Simplified Package Layout and Partitioning

2011-07-30 Thread Sandro Tosi
Hi, sorry for nitpicking, but... On Wed, Jul 20, 2011 at 05:58, P.J. Eby p...@telecommunity.com wrote: ... For those implementing PEP \302 importer objects: the '\' should be removed, right? Cheers, -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/

Re: [Python-Dev] Draft PEP: Simplified Package Layout and Partitioning

2011-07-30 Thread Éric Araujo
Hi Sandro, On Wed, Jul 20, 2011 at 05:58, P.J. Eby p...@telecommunity.com wrote: For those implementing PEP \302 importer objects: the '\' should be removed, right? No. Philip used backslashes to prevent the HTML conversion to transform each and every instance of “PEP \d+” to a link, which

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Terry Reedy
On 7/29/2011 6:54 PM, Antoine Pitrou wrote: On Fri, 29 Jul 2011 18:47:07 -0400 Terry Reedytjre...@udel.edu wrote: And test.support *is* for internal use. No, the stuff in there is *not* for internal use within the module but for external use is possiby every test module. I meant internal

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Terry Reedy
On 7/29/2011 7:27 PM, Antoine Pitrou wrote: On Fri, 29 Jul 2011 19:02:32 -0400 Terry Reedytjre...@udel.edu wrote: On 7/29/2011 5:32 PM, Antoine Pitrou wrote: On Fri, 29 Jul 2011 11:51:18 -0400 Barry Warsawba...@python.org wrote: The solution then is to rename test.support to

Re: [Python-Dev] the history of tests being inside Lib/ in Python

2011-07-30 Thread R. David Murray
On Sat, 30 Jul 2011 06:30:40 +0300, Eli Bendersky eli...@gmail.com wrote: This mail can appear as if advocating the transfer of Lib/test into Tests/, but this is not my intention here. Honest :-) I'm just trying to understand the history and rationale behind this structure in the CPython

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Antoine Pitrou
On Sat, 30 Jul 2011 09:25:27 -0400 Terry Reedy tjre...@udel.edu wrote: I'm sorry, can you be more precise. The effect of what? Your proposal to remove the current formatted documentation of test.support instead of completing it and force all developers to only have reference to the

Re: [Python-Dev] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Senthil Kumaran
Hello Antoine, On Sat, Jul 30, 2011 at 08:46:00AM +0200, Antoine Pitrou wrote: (I know PEP 8 is not always followed in old code, but there's no reason not to follow it in code that we add to the stdlib) Thanks for pointing out. I somehow overlooked it. I shall refactor that lib. Unless

Re: [Python-Dev] cpython: make the types of None and Ellipsis callable

2011-07-30 Thread Benjamin Peterson
2011/7/29 Georg Brandl g.bra...@gmx.net: Am 30.07.2011 01:20, schrieb benjamin.peterson: http://hg.python.org/cpython/rev/84c3be27b4c7 changeset:   71614:84c3be27b4c7 parent:      71611:a6afd26caa8a user:        Benjamin Peterson benja...@python.org date:        Fri Jul 29 18:19:43 2011

Re: [Python-Dev] Draft PEP: Simplified Package Layout and Partitioning

2011-07-30 Thread Sandro Tosi
On Sat, Jul 30, 2011 at 14:57, Éric Araujo mer...@netwok.org wrote: On Wed, Jul 20, 2011 at 05:58, P.J. Eby p...@telecommunity.com wrote: For those implementing PEP \302 importer objects: the '\' should be removed, right? No.  Philip used backslashes to prevent the HTML conversion to

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Nick Coghlan
On Sat, Jul 30, 2011 at 1:49 AM, Barry Warsaw ba...@python.org wrote: On Jul 30, 2011, at 01:02 AM, Nick Coghlan wrote: If test.support is truly and only an internal implementation detail, then it should adhere to Pythonic convention for such things, and be renamed test._support.  Then you

Re: [Python-Dev] cpython: make the types of None and Ellipsis callable

2011-07-30 Thread Nick Coghlan
On Sun, Jul 31, 2011 at 12:12 AM, Benjamin Peterson benja...@python.org wrote: 2011/7/29 Georg Brandl g.bra...@gmx.net: Shouldn't there be a matching Doc change somewhere? Somewhere is the question! While None/NotImplemented/Ellipsis are all documented as singletons, the behaviour of calling

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Barry Warsaw
On Jul 31, 2011, at 01:23 AM, Nick Coghlan wrote: It sounds to me like you're really objecting to the devguide living in a separate clone. This doesn't bode well for the prospects of ever splitting the stdlib out from the CPython interpreter core... Actually, no. I'm objecting to moving

Re: [Python-Dev] Convention on functions that shadow existing stdlib functions

2011-07-30 Thread Nick Coghlan
On Sun, Jul 31, 2011 at 1:38 AM, Barry Warsaw ba...@python.org wrote: On Jul 31, 2011, at 01:23 AM, Nick Coghlan wrote: It sounds to me like you're really objecting to the devguide living in a separate clone. This doesn't bode well for the prospects of ever splitting the stdlib out from the

Re: [Python-Dev] [Python-checkins] cpython: Issue 12647: Add __bool__() method to the None object.

2011-07-30 Thread Nick Coghlan
On Sat, Jul 30, 2011 at 6:08 AM, Brett Cannon br...@python.org wrote: Wasn't this change only in 3.3 where __nonzero__ doesn't exist? So when PyPy eventually supports Python 3 they will have to update to support __bool__ on None but this test won't exercise that for them. IOW I think the guard

Re: [Python-Dev] cpython: make the types of None and Ellipsis callable

2011-07-30 Thread Nick Coghlan
On Sun, Jul 31, 2011 at 1:30 AM, Nick Coghlan ncogh...@gmail.com wrote: And on that note... was there any particular reason for leaving NotImplemented out for this change? Never mind, just noticed the subsequest checkin. Cheers, Nick. -- Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane,

Re: [Python-Dev] cpython (2.7): note Ellipsis syntax

2011-07-30 Thread Georg Brandl
On 07/30/11 17:00, benjamin.peterson wrote: http://hg.python.org/cpython/rev/402f94edf11b changeset: 71637:402f94edf11b branch: 2.7 user:Benjamin Peterson benja...@python.org date:Sat Jul 30 09:59:12 2011 -0500 summary: note Ellipsis syntax files:

Re: [Python-Dev] cpython: we can call singleton types now

2011-07-30 Thread Georg Brandl
On 07/30/11 17:03, benjamin.peterson wrote: http://hg.python.org/cpython/rev/4a07b772f0e0 changeset: 71639:4a07b772f0e0 user:Benjamin Peterson benja...@python.org date:Sat Jul 30 10:03:09 2011 -0500 summary: we can call singleton types now files:

Re: [Python-Dev] cpython (2.7): note Ellipsis syntax

2011-07-30 Thread Benjamin Peterson
2011/7/30 Georg Brandl g.bra...@gmx.net: On 07/30/11 17:00, benjamin.peterson wrote: http://hg.python.org/cpython/rev/402f94edf11b changeset:   71637:402f94edf11b branch:      2.7 user:        Benjamin Peterson benja...@python.org date:        Sat Jul 30 09:59:12 2011 -0500 summary:   note

Re: [Python-Dev] [Python-checkins] cpython: Modernize modulefinder module and tests a bit.

2011-07-30 Thread Ezio Melotti
Hi, On 29/07/2011 15.35, eric.araujo wrote: http://hg.python.org/cpython/rev/1521d9837d16 changeset: 71569:1521d9837d16 user:Éric Araujomer...@netwok.org date:Thu Jul 28 23:35:29 2011 +0200 summary: Modernize modulefinder module and tests a bit. The tests don’t use an

Re: [Python-Dev] [Python-checkins] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Ezio Melotti
Hi, On 30/07/2011 5.58, senthil.kumaran wrote: http://hg.python.org/cpython/rev/26839edf3cc1 changeset: 71617:26839edf3cc1 parent: 71613:018e14a46454 user:Senthil Kumaransent...@uthcode.com date:Sat Jul 30 10:56:50 2011 +0800 summary: Fix closes Issue11281 -

Re: [Python-Dev] cpython (2.7): note Ellipsis syntax

2011-07-30 Thread Greg Ewing
Benjamin Peterson wrote: why would you use Ellipsis outside of slices? I could imagine someone wanting to use it as part of a function API. For example, print(a, b, c, ...) would have been a nice way to tell print() not to put a newline on the end. -- Greg

Re: [Python-Dev] [Python-checkins] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Senthil Kumaran
On Sat, Jul 30, 2011 at 11:11:08PM +0300, Ezio Melotti wrote: -.. class:: SMTP(host='', port=0, local_hostname=None[, timeout]) +.. class:: SMTP(host='', port=0, local_hostname=None[, timeout], source_address=None) The [, timeout] now looks weird there, and it would be better to convert it