Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, 25 Jan 2018 at 17:33 Eric V. Smith wrote: > On 1/25/2018 8:13 PM, Terry Reedy wrote: > > On 1/25/2018 7:47 PM, Mariatta Wijaya wrote: > >> I think we're starting to deviate from the original topic here which > >> is: please replace # with GH- when you click Squash & Merge button. > > > >

Re: [Python-Dev] inconsistency in annotated assigned targets

Thank you for the clarification! I should have looked through the PEPs first. On Thu, Jan 25, 2018 at 10:14 PM, Guido van Rossum wrote: > PEP 526 has this in the "Rejected/Postponed Proposals" section: > > - **Allow annotations in** ``with`` **and** ``for`` **statement:** > This was rejected b

Re: [Python-Dev] inconsistency in annotated assigned targets

PEP 526 has this in the "Rejected/Postponed Proposals" section: - **Allow annotations in** ``with`` **and** ``for`` **statement:** This was rejected because in ``for`` it would make it hard to spot the actual iterable, and in ``with`` it would confuse the CPython's LL(1) parser. On Thu, Jan

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On 1/25/2018 8:13 PM, Terry Reedy wrote: On 1/25/2018 7:47 PM, Mariatta Wijaya wrote: I think we're starting to deviate from the original topic here which is: please replace # with GH- when you click Squash & Merge button. I will try to remember to do this, although it seems pointless if most

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On 1/25/2018 7:47 PM, Mariatta Wijaya wrote: I think we're starting to deviate from the original topic here which is: please replace # with GH- when you click Squash & Merge button. I will try to remember to do this, although it seems pointless if most people do not. The idea of the mergebot

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On 1/25/2018 4:34 PM, Berker Peksağ wrote: On Fri, Jan 26, 2018 at 12:09 AM, Terry Reedy wrote: On 1/25/2018 1:53 PM, Brett Cannon wrote: I would assume it would just go into miss-islington, but before we get ahead of ourselves and design this we need to get consensus that people like the ove

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

I think we're starting to deviate from the original topic here which is: please replace # with GH- when you click Squash & Merge button. The idea of the mergebot (by issuing a command) was brought up for a different purpose: to automate the merging of a PR after all CI passes (which can take time)

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On 1/25/2018 4:22 PM, Berker Peksağ wrote: On Thu, Jan 25, 2018 at 11:50 PM, Terry Reedy wrote: On 1/25/2018 1:03 PM, Mariatta Wijaya wrote: One idea is maybe have a bot to do the squash commit, for example by commenting on GitHub: @merge-bot merge So core devs can do the above instead o

Re: [Python-Dev] inconsistency in annotated assigned targets

2018-01-25 15:00 GMT-08:00 Joe Jevnik via Python-Dev : > Currently there are many ways to introduce variables in Python; however, > only a few allow annotations. I was working on a toy language and chose to > base my syntax on Python's when I noticed that I could not annotate a loop > iteration v

[Python-Dev] inconsistency in annotated assigned targets

Currently there are many ways to introduce variables in Python; however, only a few allow annotations. I was working on a toy language and chose to base my syntax on Python's when I noticed that I could not annotate a loop iteration variable. For example: for x: int in range(5): ... This led

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 1:46 PM, Barry Warsaw wrote: > On Jan 25, 2018, at 13:38, Mariatta Wijaya wrote: >> >> +1 for the mergebot! :) > > Yes, +1 from me too. As you know, GitLab has the option to “merge when CI > completes successfully” and it’s a great workflow. Once I’ve reviewed and > ap

Re: [Python-Dev] Merging the implementation of PEP 563

I looked at the PR and I think the code is fine. Yury On Thu, Jan 25, 2018 at 4:39 PM, Victor Stinner wrote: > Hi, > > If nobody is available to review your PR, I suggest to push it anyway, > to get it merged before the feature freeze. The code can be reviewed > later. Merging it sooner gives mo

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

2018-01-25 22:55 GMT+01:00 Mariatta Wijaya : > My problem has been that I almost always still need to rewrite the commit > message. > Especially when someone wrote "fix a typo" or "fix several typos". That's the main drawback of GitHub compared to Gerrit. On Gerrit, the commit message is at the sa

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

2018-01-25 22:46 GMT+01:00 Barry Warsaw : > Why not just auto merge if the PR is approved, CI is all green, and no > additional commits have been pushed? Merging a PR and approving it should be two different actions. Sometimes, you prefer to wait for 2 approvals before merging. Sometimes, you wan

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Jan 25, 2018, at 16:55, Mariatta Wijaya wrote: > My problem has been that I almost always still need to rewrite the commit > message. > Especially when someone wrote "fix a typo" or "fix several typos". > > If it automatically merges, then there's no opportunity to adjust the commit > mess

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

> > Why not just auto merge if the PR is approved, CI is all green, and no > additional commits have been pushed? My problem has been that I almost always still need to rewrite the commit message. Especially when someone wrote "fix a typo" or "fix several typos". If it automatically merges, then

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Jan 25, 2018, at 13:38, Mariatta Wijaya wrote: > > +1 for the mergebot! :) Yes, +1 from me too. As you know, GitLab has the option to “merge when CI completes successfully” and it’s a great workflow. Once I’ve reviewed and approved the branch, I can hit this button and… we’re done! Assum

Re: [Python-Dev] Merging the implementation of PEP 563

Hi, If nobody is available to review your PR, I suggest to push it anyway, to get it merged before the feature freeze. The code can be reviewed later. Merging it sooner gives more time to test it and spot bugs. It also gives more time to fix bugs ;-) Well, at the end, it's up to you. Victor 2018

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Fri, Jan 26, 2018 at 12:09 AM, Terry Reedy wrote: > On 1/25/2018 1:53 PM, Brett Cannon wrote: > >> I would assume it would just go into miss-islington, but before we get >> ahead of ourselves and design this we need to get consensus that people like >> the overall idea of using a bot to do a ma

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On 01/25/2018 10:53 AM, Brett Cannon wrote: [...] before we get ahead of ourselves and design this we need to get consensus that people like the overall idea of using a bot to do a main > commits as well. -1 on using comments for the main commit. -- ~Ethan~ ___

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 11:50 PM, Terry Reedy wrote: > On 1/25/2018 1:03 PM, Mariatta Wijaya wrote: > >> One idea is maybe have a bot to do the squash commit, for example by >> commenting on GitHub: >> @merge-bot merge > > >> So core devs can do the above instead of pressing the commit button. A

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On 1/25/2018 1:53 PM, Brett Cannon wrote: I would assume it would just go into miss-islington, but before we get ahead of ourselves and design this we need to get consensus that people like the overall idea of using a bot to do a main commits as well. I strongly dislike any idea of making me

[Python-Dev] Merging the implementation of PEP 563

Hi all, Serhiy looks busy these days. I'd appreciate somebody looking at and hopefully merging https://github.com/python/cpython/pull/4390 . Everything there was reviewed by Serhiy except for the latest commit. This should be ready to merge and maybe

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On 1/25/2018 1:03 PM, Mariatta Wijaya wrote: One idea is maybe have a bot to do the squash commit, for example by commenting on GitHub: @merge-bot merge So core devs can do the above instead of pressing the commit button. Any thoughts on this? I can hardly believe that you are seriously

Re: [Python-Dev] CLion IDE

On 01/24, Steve Holden wrote: I've just start using CLion from JetBrains, and I wondered if anyone on the list is using this product in CPython development. Links to any guidance would be useful. regards Steve Holden Hi Steve, I tried to use it for CPython, but it uses CMake and not the autot

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

-1 on using magic words in comments rather than the normal UI. Perhaps one of the bots could post a reminder at a time when it makes sense? All checks passed, maybe? Top-posted from my Windows phone From: Brett Cannon Sent: Friday, January 26, 2018 6:01 To: Berker Peksağ Cc: Python Dev Subject:

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, 25 Jan 2018 at 10:51 Berker Peksağ wrote: > On Thu, Jan 25, 2018 at 9:38 PM, Mariatta Wijaya > wrote: > >> That would be best solution (I think it would solve > >> https://github.com/python/miss-islington/issues/16 too) but it's more > >> complicated than the extension idea :) I have som

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 9:38 PM, Mariatta Wijaya wrote: >> That would be best solution (I think it would solve >> https://github.com/python/miss-islington/issues/16 too) but it's more >> complicated than the extension idea :) I have some time work on it if >> you'd like to implement the mergebot i

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, 25 Jan 2018 at 10:14 Zachary Ware wrote: > On Thu, Jan 25, 2018 at 12:03 PM, Mariatta Wijaya > wrote: > >> Of course, we would still need to convince people to install it :) > > > > > > Right, that's the challenge :) > > I personally use Chrome (!) and I've been using your Chrome extensi

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

> > That would be best solution (I think it would solve > https://github.com/python/miss-islington/issues/16 too) but it's more > complicated than the extension idea :) I have some time work on it if > you'd like to implement the mergebot idea. +1 for the mergebot! :) New bot or miss-islington's

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 9:03 PM, Mariatta Wijaya wrote: >> Of course, we would still need to convince people to install it :) > > > Right, that's the challenge :) > I personally use Chrome (!) and I've been using your Chrome extension, so > thank you! > However, I don't feel comfortable making thi

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 12:03 PM, Mariatta Wijaya wrote: >> Of course, we would still need to convince people to install it :) > > > Right, that's the challenge :) > I personally use Chrome (!) and I've been using your Chrome extension, so > thank you! > However, I don't feel comfortable making th

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

> > Of course, we would still need to convince people to install it :) Right, that's the challenge :) I personally use Chrome (!) and I've been using your Chrome extension, so thank you! However, I don't feel comfortable making this available only for a specific browser user, feels exclusionary t

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 4:58 PM, Mariatta Wijaya wrote: > It has to be manually edited right before you commit/merge on GitHub. > I don't think it can be automatically changed? Unless we have some kind of > post commit hook to amend the commit message. Perhaps it's possible to edit both title and

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

It has to be manually edited right before you commit/merge on GitHub. I don't think it can be automatically changed? Unless we have some kind of post commit hook to amend the commit message. I've been changing it to GH- , so does miss-islington when she backports. If you see the mixed GH- and # i

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 1:42 PM, INADA Naoki wrote: > Hi. > > Devguide says: > > """ > Replace the reference to GitHub pull request # with GH-. If > the title is too long, the pull request number can be added to the > message body. > """ > > https://devguide.python.org/gitbootcamp/#accepti

Re: [Python-Dev] GH-NNNN vs #NNNN in merge commit

GH prefix avoids confusion between bugs.python.org and GitHub, but GitHub generates #xxx in the generated commit message on Merge... Each commit message has to be manually edited. It would be better to get GH automatically. Victor Le 25 janv. 2018 11:44, "INADA Naoki" a écrit : > Hi. > > Devgui

[Python-Dev] GH-NNNN vs #NNNN in merge commit

Hi. Devguide says: """ Replace the reference to GitHub pull request # with GH-. If the title is too long, the pull request number can be added to the message body. """ https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pull-request But there are more # than GH- in