Re: [Qemu-devel] [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl

2012-02-20 Thread Gerd Hoffmann
Hi, I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the spice-protocol patch? Yes. -if (qxl-vram_size 4096) { -qxl-vram_size = 4096; +if (qxl-vram_size qxl-vram32_size) { +qxl-vram_size = qxl-vram32_size; Am I reading correctly that you want the

Re: [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change

2012-02-20 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: It's not needed. Besides we can then assume that bdrv_eject() is only called when there's a tray state change, which is useful to the DEVICE_TRAY_MOVED event (going to be added in a future commit). We can assume that only after the next patch

Re: [Qemu-devel] [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 09:00:14AM +0100, Gerd Hoffmann wrote: Hi, I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the spice-protocol patch? Yes. -if (qxl-vram_size 4096) { -qxl-vram_size = 4096; +if (qxl-vram_size qxl-vram32_size) { +

Re: [Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load()

2012-02-20 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This is used to sync the physical tray state after migration when using CD-ROM passthrough. However, migrating when using passthrough is broken anyway and shouldn't be supported... So, drop this function as it causes a problem with the

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-20 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: It's emitted whenever the tray is moved by the guest or by HMP/QMP commands. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt | 18 ++ block.c| 24

Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-20 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: The event name changed, which caused the subject to change too, hope this won't cause confusion. v3 o Rename the event to DEVICE_TRAY_MOVED o Rename the 'ejected' event data to 'tray-open' o Only call bdrv_eject() if the tray state changed o

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-20 Thread Michael S. Tsirkin
On Wed, Dec 14, 2011 at 08:43:17AM -0500, Stefan Berger wrote: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: Remove unneeded include statements

2012-02-20 Thread Stefan Hajnoczi
On Sat, Feb 11, 2012 at 10:07:55AM +0100, Stefan Weil wrote: The standard include files are already included in qemu-common.h. malloc.h and alloca.h were needed for alloca() which was removed from TCG code some years ago when switching from dyngen to TCG (see commit

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-20 Thread Paolo Bonzini
On 02/19/2012 01:36 PM, Alexander Barabash wrote: The proposed object_property_get_child() may return either the direct child with the specified name in the composition tree, or the value of the link with the specified name, as object_property_get_link() indeed does. Have you actually

Re: [Qemu-devel] [PATCH] qom: Fix object_initialize_with_type() assertion

2012-02-20 Thread Paolo Bonzini
On 02/20/2012 12:49 AM, Andreas Färber wrote: Assert the object is at least sizeof(Object), not sizeof(ObjectClass). Signed-off-by: Andreas Färber afaer...@suse.de --- qom/object.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qom/object.c b/qom/object.c

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Gerd Hoffmann
On 02/20/12 00:44, Anthony Liguori wrote: We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do this. /me wonders why you touch vc's at all for this. Doesn't it make alot more sense to just have a -chardev vte (which then opens a

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has multiple disks with enabling I/O throttling function separately, when draining activities are done, some requests maybe are in the throttled queue; So we need to restart them at

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Zhi Yong Wu
On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has multiple disks with enabling I/O throttling function separately, when draining activities are done, some requests

Re: [Qemu-devel] [PATCH][v12] megasas: LSI Megaraid SAS HBA emulation

2012-02-20 Thread Hannes Reinecke
On 02/18/2012 01:38 PM, Gerhard Wiesinger wrote: Hello Hannes, Patch applies well to qemu tree and with a one line modification to qemu-kvm. My testcase was to install Fedora 16 x64 on qemu-kvm. Unfortunatly it was NOT successful. 1.) Strange thing is that udevd got into timeouts and

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Zhi Yong Wu
For example, one disk of one guest is hot plugout, its other disks should not be affected if those disks also enable I/O throttling. But if one whole VM need to be stored, all throttled requests for all disks need to be drained. On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf kw...@redhat.com wrote:

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 10:29, schrieb Zhi Yong Wu: On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has multiple disks with enabling I/O throttling function separately, when

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Zhi Yong Wu
On Mon, Feb 20, 2012 at 5:39 PM, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 10:29, schrieb Zhi Yong Wu: On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has

Re: [Qemu-devel] [PATCH] block: fix block I/O throtting with IDE

2012-02-20 Thread Chris Webb
Zhi Yong Wu zwu.ker...@gmail.com writes: On Mon, Feb 20, 2012 at 5:18 AM, Chris Webb ch...@arachsys.com wrote: I would indeed quite like to backport this to qemu 1.0! Am I right in thinking the sanest way to do this is to apply 922453bca6a9 to bring all the relevant qemu_aio_flush() calls

[Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-20 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Cheers, Juan.

Re: [Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2012-02-20 Thread Peter Lieven
On 21.10.2011 11:22, Gerd Hoffmann wrote: Hi, Original: * Mouse #1: QEMU HID Tablet (absolute) Mouse #0: QEMU PS/2 Mouse Start from the snapshot: * Mouse #0: QEMU PS/2 Mouse Mouse #1: QEMU HID Tablet (absolute) The active mouse device is not be saved into the snapshot. That

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-20 Thread Alexander Graf
On 20.02.2012, at 04:01, David Gibson wrote: Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to determine the direction of DMA it is emulating. We already have a DMADirection enum designed specifically to encode DMA directions. This patch uses it for dma_bdrv_io() as well.

Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie

2012-02-20 Thread Gerd Hoffmann
+if (cookie == NULL) { +cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO, +QXL_IO_UPDATE_AREA_ASYNC, +0); +} Automagic cookie creation is still there. I think when cookie is NULL you should just

Re: [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough

2012-02-20 Thread Tobias Geiger
Hi! i wanted to test these patches against http://xenbits.xensource.com/xen-unstable.hg but it seems to check out an outdated version of upstream-qemu, even with QEMU=upstream. Where can i check out the qemu-upstream version to which these patches apply? Thanks and Greetings Tobias Am

Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async

2012-02-20 Thread Gerd Hoffmann
Hi, +void qxl_render_update_area_done(PCIQXLDevice *qxl, QXLCookie *cookie) +{ This is called from spice server thread context, correct? -for (i = 0; i ARRAY_SIZE(dirty); i++) { +for (i = 0; i ARRAY_SIZE(data-dirty); i++) { if (qemu_spice_rect_is_empty(dirty+i)) {

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-20 Thread Alexander Barabash
On 02/20/2012 11:11 AM, Paolo Bonzini wrote: On 02/19/2012 01:36 PM, Alexander Barabash wrote: The proposed object_property_get_child() may return either the direct child with the specified name in the composition tree, or the value of the link with the specified name, as

Re: [Qemu-devel] [PATCH v2] Revised: Add object_property_get_child().

2012-02-20 Thread Alexander Barabash
On 02/19/2012 06:04 PM, Alexander Barabash wrote: Add object_property_get_child(). Please disregard this patch. object_property_get_link() works for this purpose.

Re: [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough

2012-02-20 Thread Anthony PERARD
On Mon, Feb 20, 2012 at 10:51, Tobias Geiger tobias.gei...@vido.info wrote: i wanted to test these patches against http://xenbits.xensource.com/xen-unstable.hg but it seems to check out an outdated version of upstream-qemu, even with QEMU=upstream. Where can i check out the qemu-upstream

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Gerd Hoffmann
On 02/19/12 22:28, Alon Levy wrote: This changes the behavior of the monitor command. After the previous patch, there is no longer an option of deadlock with virt-manager, but ppm_save is called too early, before the update has completed. With this patch it is called at the correct moment, but

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-20 Thread Paolo Bonzini
On 02/20/2012 12:13 PM, Alexander Barabash wrote: I would only suggest that the documentation of object_property_add_child() be amended to reflect the fact that the child object may be retrieved using object_property_get_link(). Sure, feel free to post a patch for that or to add a synonym with

[Qemu-devel] [Bug 924943] Re: usb-host devices given by command line are routed incomplete to the guest

2012-02-20 Thread Erik Rull
Still present with the latest patch queue and update from the GIT master. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/924943 Title: usb-host devices given by command line are routed incomplete

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-20 Thread Gerd Hoffmann
On 02/19/12 22:28, Alon Levy wrote: Add an implementation of the DisplayAllocator callbacks for qxl. Uses the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32 bits per pixel line convertion. Since free/resize/create are defined in qxl.c, it is easy to ensure consistent

Re: [Qemu-devel] [PATCH] build: add needed missing libraries libm and librt

2012-02-20 Thread Roger Pau Monné
2012/2/18 Andreas Färber afaer...@suse.de: Am 18.02.2012 09:24, schrieb Blue Swirl: On Wed, Feb 8, 2012 at 17:06, Roger Pau Monne roger@entel.upc.edu wrote: libm is used in cutils.c, but the library was not specified when linking some binaries, throwing the following error: cutils.o:

[Qemu-devel] [PATCH 1/2] build: check if libm is needed in configure

2012-02-20 Thread Roger Pau Monne
Remove the hardcoded use of libm and instead rely on configure to check for it. It is needed at least for qemu-ga and qemu-system. Signed-off-by: Roger Pau Monne roger@entel.upc.edu --- Makefile.target |4 configure | 14 ++ 2 files changed, 14 insertions(+), 4

[Qemu-devel] [PATCH 2/2] build: replace librt check function

2012-02-20 Thread Roger Pau Monne
Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the clock_getttime function can be used without linking against librt (although the manual page states the opposite). Signed-off-by: Roger Pau Monne roger@entel.upc.edu --- configure |3 ++- 1 files changed, 2

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
Hi, On 17 February 2012 19:21, Peter Maydell peter.mayd...@linaro.org wrote: I'm looking at cleaning up some more omap3 patches, and have been working on the omap_i2c related ones. At the moment in omap_i2c.c there are the following #defines for the I2C module revision (as exposed via the

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 00:44, schrieb Anthony Liguori: Hi, I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of discoverability but it's worse than I think

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
On 20 February 2012 13:12, andrzej zaborowski balr...@gmail.com wrote: I have neither of the TRMs at hand but I downloaded the TRM for omap35x which features i2c module 3.1 and it looks like the current Sorry, the revision is not given in the TRM, 3.1 is an example. Cheers

Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 11:56:58AM +0100, Gerd Hoffmann wrote: +if (cookie == NULL) { +cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO, +QXL_IO_UPDATE_AREA_ASYNC, +0); +} Automagic cookie

Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 12:10:38PM +0100, Gerd Hoffmann wrote: Hi, +void qxl_render_update_area_done(PCIQXLDevice *qxl, QXLCookie *cookie) +{ This is called from spice server thread context, correct? -for (i = 0; i ARRAY_SIZE(dirty); i++) { +for (i = 0; i

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread Peter Maydell
On 20 February 2012 12:12, andrzej zaborowski balr...@gmail.com wrote: On 17 February 2012 19:21, Peter Maydell peter.mayd...@linaro.org wrote: Does anybody know what the distinction between these two constants is supposed to be? They were introduced by commit 29885477 back in 2008... (Also,

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 12:32:44PM +0100, Gerd Hoffmann wrote: On 02/19/12 22:28, Alon Levy wrote: This changes the behavior of the monitor command. After the previous patch, there is no longer an option of deadlock with virt-manager, but ppm_save is called too early, before the update has

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 12:41:09PM +0100, Gerd Hoffmann wrote: On 02/19/12 22:28, Alon Levy wrote: Add an implementation of the DisplayAllocator callbacks for qxl. Uses the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32 bits per pixel line convertion. Since

Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie

2012-02-20 Thread Gerd Hoffmann
Hi, Which spice server version added async support? IIRC this is 0.8.2? I'm tempted to raise the minimal supported version to 0.8.latest and zap a bunch of #ifdefs from the code. What do you think? How does that work? raise the minimal supported version in configure? Yes. Then zap

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 13:17, schrieb Kevin Wolf: Am 20.02.2012 00:44, schrieb Anthony Liguori: Hi, I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of

Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async

2012-02-20 Thread Gerd Hoffmann
Hi, @@ -151,6 +171,7 @@ void qxl_render_update(PCIQXLDevice *qxl) dpy_update() call here. Calling that one isn't safe without grabbing the qemu lock. About dpy_update, discovered it the hard way. You mean I need the lock for dpy_update or also before? Any qemu code should be

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Gerd Hoffmann
Hi, (2) Async monitor command. Keeps interface and works nicely. A bunch of QAPI bits tickled into master meanwhile, so we could look at this again. Luiz? What is the status here? I was going to look for QAPI bits after this series (i.e. (2)). Doing (3) is also possible.

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-20 Thread Gerd Hoffmann
Hi, I'll send a series that works with vnc+spice and sdl+spice (didn't test sdl+vnc+spice), and screendumps at the same time. Setting the QEMU_ALLOCATED_FLAG flag sounds hackish too. QEMU_ALLOCATED_FLAG is just a flag which is used by the defaultallocator_free_displaysurface function to

[Qemu-devel] [PATCH v3] Add tab-completion for device_add.

2012-02-20 Thread Andrzej Zaborowski
From: Andrzej Zaborowski balr...@gmail.com Signed-off-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- v2: pass only char *prop_name as qdev_driver_prop_foreach_func parameter, Anthony noted Property was soon going away. v3: use QOM. --- monitor.c | 58

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Anthony Liguori
On 02/20/2012 03:17 AM, Gerd Hoffmann wrote: On 02/20/12 00:44, Anthony Liguori wrote: We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do this. /me wonders why you touch vc's at all for this. Doesn't it make alot more sense to

Re: [Qemu-devel] [PATCH 5/6] gtk: add support for screen scaling and full screen

2012-02-20 Thread Anthony Liguori
On 02/20/2012 01:41 AM, Paolo Bonzini wrote: On 02/20/2012 12:45 AM, Anthony Liguori wrote: +static void gd_menu_zoom_in(GtkMenuItem *item, void *opaque) +{ +GtkDisplayState *s = opaque; + +s-scale_x *= 1.25; +s-scale_y *= 1.25; + +gd_resize(s-ds); +} + +static void

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Gerd Hoffmann
On 02/20/12 14:45, Anthony Liguori wrote: On 02/20/2012 03:17 AM, Gerd Hoffmann wrote: On 02/20/12 00:44, Anthony Liguori wrote: We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do this. /me wonders why you touch vc's at all

Re: [Qemu-devel] [PATCH 6/6] gtk: make default UI

2012-02-20 Thread Stefano Stabellini
On Mon, 20 Feb 2012, Anthony Liguori wrote: On 02/19/2012 08:52 PM, Brad Smith wrote: On 19/02/12 9:44 PM, Anthony Liguori wrote: On 02/19/2012 08:24 PM, Brad Smith wrote: On 19/02/12 8:10 PM, Anthony Liguori wrote: If not, it will be nice to keep SDL because GTK huge and not that

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Anthony Liguori
On 02/20/2012 06:17 AM, Kevin Wolf wrote: Am 20.02.2012 00:44, schrieb Anthony Liguori: I'm not attempting to make a pretty desktop virtualization UI. Maybe we'll go there eventually but that's not what this series is about. This is just attempting to use a richer toolkit such that we can

Re: [Qemu-devel] [PATCH 6/6] gtk: make default UI

2012-02-20 Thread Anthony Liguori
On 02/20/2012 08:06 AM, Stefano Stabellini wrote: On Mon, 20 Feb 2012, Anthony Liguori wrote: On 02/19/2012 08:52 PM, Brad Smith wrote: On 19/02/12 9:44 PM, Anthony Liguori wrote: On 02/19/2012 08:24 PM, Brad Smith wrote: On 19/02/12 8:10 PM, Anthony Liguori wrote: If not, it will be nice

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Anthony Liguori
On 02/20/2012 06:47 AM, Kevin Wolf wrote: Am 20.02.2012 13:17, schrieb Kevin Wolf: Am 20.02.2012 00:44, schrieb Anthony Liguori: Hi, I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with

Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation

2012-02-20 Thread Meador Inge
On 02/18/2012 10:33 AM, Andreas Färber wrote: Am 17.02.2012 18:06, schrieb Andreas Färber: Am 17.02.2012 18:03, schrieb Meador Inge: Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f where 'watch_mem_write' was modified to fall-through to 'abort' on every input.

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Anthony Liguori
On 02/20/2012 07:59 AM, Gerd Hoffmann wrote: On 02/20/12 14:45, Anthony Liguori wrote: On 02/20/2012 03:17 AM, Gerd Hoffmann wrote: On 02/20/12 00:44, Anthony Liguori wrote: We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do

Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write

2012-02-20 Thread Meador Inge
On 02/18/2012 11:11 AM, Max Filippov wrote: Signed-off-by: Max Filippov jcmvb...@gmail.com Reviewed-by: Meador Inge mead...@codesourcery.com --- exec.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index b81677a..f105b43 100644 ---

[Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Virtbie
Dear qemuers, thanks for your exellent software. I would like to use cache=writeback, but I still can't understand if this is safe or not in case of power loss. In particular with virtio-blk on bare LVM device. Qemu manpage still says cache=writeback isn't safe, but I seem to find some

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Gerd Hoffmann
Hi, This would require touching a fair bit of code that handles things like defaults. I'm not sure that having the distinction makes anything easier to implement. /me suggests to simply have no default terminals with qemu -gtk. One thing I was contemplating but ultimately didn't do was

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 15:04, schrieb Anthony Liguori: * Half of the menu entries appears to be translated by the libraries used. Give me something that is all German or something that is all English. Mixed languages looks unprofessional. This is because of the use of stock items. I can

Re: [Qemu-devel] [RFC] Replication agent design (was [RFC PATCH] replication agent module)

2012-02-20 Thread Paolo Bonzini
On 02/19/2012 02:40 PM, Ori Mamluk wrote: I think it might be better to go back to my original less generic design. We can regard it as a 'plugin' for a specific application - in this case, replication. I can add a plugin interface in the generic block layer that allows building a proper

Re: [Qemu-devel] [PATCH 6/6] gtk: make default UI

2012-02-20 Thread Stefano Stabellini
On Mon, 20 Feb 2012, Anthony Liguori wrote: On 02/20/2012 08:06 AM, Stefano Stabellini wrote: On Mon, 20 Feb 2012, Anthony Liguori wrote: On 02/19/2012 08:52 PM, Brad Smith wrote: On 19/02/12 9:44 PM, Anthony Liguori wrote: On 02/19/2012 08:24 PM, Brad Smith wrote: On 19/02/12 8:10 PM,

Re: [Qemu-devel] [PATCH 6/6] gtk: make default UI

2012-02-20 Thread Roy Tam
2012/2/20 Stefano Stabellini stefano.stabell...@eu.citrix.com: On Mon, 20 Feb 2012, Anthony Liguori wrote: On 02/20/2012 08:06 AM, Stefano Stabellini wrote: On Mon, 20 Feb 2012, Anthony Liguori wrote: On 02/19/2012 08:52 PM, Brad Smith wrote: On 19/02/12 9:44 PM, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH v2] Revised: Add object_property_get_child().

2012-02-20 Thread Alexander Barabash
On 02/19/2012 07:14 PM, Andreas Färber wrote: Am 19.02.2012 17:04, schrieb Alexander Barabash: ... Signed-off-by: Alexander Barabashalexander_barab...@mentor.com Please use git-send-email to submit your patches: The commit message is unnecessarily indented and the first line is

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Anthony Liguori
On 02/20/2012 08:18 AM, Virtbie wrote: Dear qemuers, thanks for your exellent software. I would like to use cache=writeback, but I still can't understand if this is safe or not in case of power loss. Safe is too simplistic of a view. The documentation in qemu-options.hx probably needs to be

Re: [Qemu-devel] [PATCH][v13] megasas: LSI Megaraid SAS HBA emulation

2012-02-20 Thread Alexander Graf
On 20.02.2012, at 16:11, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. I've tested it to work with Linux, Windows Vista, and Windows7. Changes since v12: - Fixup flag setting via properties - Disable MSI-X per default - Fixup MSI-X handling If

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 15:18, schrieb Virtbie: Dear qemuers, thanks for your exellent software. I would like to use cache=writeback, but I still can't understand if this is safe or not in case of power loss. In particular with virtio-blk on bare LVM device. Qemu manpage still says

Re: [Qemu-devel] [PATCH][v13] megasas: LSI Megaraid SAS HBA emulation

2012-02-20 Thread Alexander Graf
On 20.02.2012, at 16:16, Hannes Reinecke wrote: On 02/20/2012 04:13 PM, Alexander Graf wrote: On 20.02.2012, at 16:11, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. I've tested it to work with Linux, Windows Vista, and Windows7. Changes

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Peter Maydell
On 20 February 2012 15:20, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 15:18, schrieb Virtbie: Qemu manpage still says cache=writeback isn't safe, but I seem to find some discordant information reading around. Is the WCE+volatile flag exposed to the guest already? I am logging into a

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Virtbie
On 02/20/12 16:06, Anthony Liguori wrote: On 02/20/2012 08:18 AM, Virtbie wrote: Dear qemuers, thanks for your exellent software. I would like to use cache=writeback, but I still can't understand if this is safe or not in case of power loss. Safe is too simplistic of a view. The

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-20 Thread Stefan Berger
On 02/20/2012 03:51 AM, Michael S. Tsirkin wrote: On Wed, Dec 14, 2011 at 08:43:17AM -0500, Stefan Berger wrote: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 16:29, schrieb Peter Maydell: On 20 February 2012 15:20, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 15:18, schrieb Virtbie: Qemu manpage still says cache=writeback isn't safe, but I seem to find some discordant information reading around. Is the WCE+volatile flag exposed

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2012-02-20 Thread Clint Byrum
Thanks Jeff! Barring any regressions being reported, this should arrive in lucid-updates around the 24th. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Peter Maydell
On 20 February 2012 15:56, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 16:29, schrieb Peter Maydell: The thing that confuses me when this subject comes up is that cache=writeback is a property of the block layer, but the WCE flag is a SCSI parameter, right? How does this work on

Re: [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough

2012-02-20 Thread Tobias Geiger
Hi Anthony thanks for that hint. I checked out a fresh xen-unstable via hg, compiled it using QEMU=upstream , checked out qemu.git from where you mentioned and used the resulting qemu- system-x86_64 binary as device_model_override . so far so good. My Domu (Win7_64) boots fine, but 2 of my 6

Re: [Qemu-devel] [PATCH v2 1/1] gdbserver: Don't send a GDB syscall until the system CPU is stopped

2012-02-20 Thread Peter Maydell
On 17 February 2012 16:21, Meador Inge mead...@codesourcery.com wrote: Fix an issue where the GDB server implementation was sending GDB syscall requests while the system CPU was still running.  Syscall requests must be sent while the CPU is stopped otherwise replies from the GDB client might

Re: [Qemu-devel] Merging qemu-iotests into qemu.git?

2012-02-20 Thread Kevin Wolf
Am 16.02.2012 21:53, schrieb Christoph Hellwig: On Thu, Feb 16, 2012 at 04:01:58PM +0100, Kevin Wolf wrote: Hi Christoph, I just talked to Stefan about our testing, both regarding the block layer and qemu in general, and we came to the conclusion that it would probably make sense to merge

[Qemu-devel] [Bug 883136] Re: qemu on ARM hosts aborts on startup because makecontext() always fails

2012-02-20 Thread Peter Maydell
David Gilbert's post to upstream eglibc, and a reply from Joseph Myers with some review comments: http://comments.gmane.org/gmane.comp.lib.glibc.ports/1187 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH] block: remove unused fields in BlockDriverState

2012-02-20 Thread Paolo Bonzini
sync_aiocb is unused since commit ce1a14d (Dynamically allocate AIO Completion Blocks., 2006-08-07). private is unused since commit 56a1493 (drive cleanup fixes., 2009-09-25). Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block_int.h |5 - 1 files changed, 0 insertions(+), 5

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Paolo Bonzini
On 02/20/2012 05:08 PM, Peter Maydell wrote: On 20 February 2012 15:56, Kevin Wolf kw...@redhat.com wrote: Am 20.02.2012 16:29, schrieb Peter Maydell: The thing that confuses me when this subject comes up is that cache=writeback is a property of the block layer, but the WCE flag is a SCSI

Re: [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough

2012-02-20 Thread Anthony PERARD
On Mon, Feb 20, 2012 at 16:11, Tobias Geiger tobias.gei...@vido.info wrote: My Domu (Win7_64) boots fine, but 2 of my 6 passed-through pcidevices dont get passed through at all: libxl: error: libxl_pci.c:756:libxl__device_pci_reset: write to /sys/bus/pci/devices/:03:00.0/reset returned

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Peter Maydell
On 20 February 2012 17:03, Paolo Bonzini pbonz...@redhat.com wrote: the default is cache=writethrough and it already does a flush after each write. This runs so slowly that SD is basically unusable for anything beyond trivial stuff. -- PMM

Re: [Qemu-devel] [PATCH 1/2] arm: clean up GIC constants.

2012-02-20 Thread Peter Maydell
On 19 February 2012 23:06, Rusty Russell ru...@rustcorp.com.au wrote: Interrupts numbers 0-31 are private to the processor interface, 32-1019 are general interrups.  Add GIC_INTERNAL and substitute everywhere. interrupts. @@ -74,7 +76,7 @@ typedef struct gic_irq_state  #define

[Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-20 Thread Jeff Cody
The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not support receiving a qlist as opposed to a qdict for input. This patch allows for array input parameters, although no argument validation

[Qemu-devel] [PATCH 0/3] Group Live Snapshots

2012-02-20 Thread Jeff Cody
This series of patches adds the ability to take group live snapshots, as opposed to indvidual device snapshots. In addition, it adds the ability to pass an array input parameter to a QMP command, although without argument validation. Currently, when taking live snapshots of devices, if a

[Qemu-devel] [PATCH 3/3] qapi: Introduce blockdev-query-group-snapshot-failure

2012-02-20 Thread Jeff Cody
In the case of a failure in a group snapshot, it is possible for multiple file image failures to occur - for instance, failure of an original snapshot, and then failure of one or more of the attempted reopens of the original. Knowing all of the file images which failed could be useful or critical

[Qemu-devel] [PATCH 2/3] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-20 Thread Jeff Cody
This is a QAPI/QMP only command to take a snapshot of a group of devices. This is simlar to the blockdev-snapshot-sync command, except blockdev-group-snapshot-sync accepts a list devices, filenames, and formats. It is attempted to keep the snapshot of the group atomic; if any snapshot of a device

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 02:18:19PM +0100, Gerd Hoffmann wrote: Hi, I'll send a series that works with vnc+spice and sdl+spice (didn't test sdl+vnc+spice), and screendumps at the same time. Setting the QEMU_ALLOCATED_FLAG flag sounds hackish too. QEMU_ALLOCATED_FLAG is just a

Re: [Qemu-devel] [PATCH 3/3] qapi: Introduce blockdev-query-group-snapshot-failure

2012-02-20 Thread Eric Blake
On 02/20/2012 10:31 AM, Jeff Cody wrote: In the case of a failure in a group snapshot, it is possible for multiple file image failures to occur - for instance, failure of an original snapshot, and then failure of one or more of the attempted reopens of the original. Knowing all of the file

Re: [Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Virtbie
On 02/20/12 16:43, Virtbie wrote: Great explanation Anthony, may I still ask: 1) Is WCE + volatile flag exposed to the guest, by all three virtual devices: - virtio - scsi - ide ? (if not, I still don't understand how this works) 2) Is there a minimum guest kernel and a minimum viostor

Re: [Qemu-devel] [PATCH 2/3] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-20 Thread Eric Blake
On 02/20/2012 10:31 AM, Jeff Cody wrote: This is a QAPI/QMP only command to take a snapshot of a group of devices. This is simlar to the blockdev-snapshot-sync command, except s/simlar/similar/ blockdev-group-snapshot-sync accepts a list devices, filenames, and formats. It is attempted to

[Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-20 Thread Peter Lieven
Hi, I came a across an issue with a Windows 7 (32-bit) as well as with a Windows 2008 R2 (64-bit) guest. If I transfer a file from the VM via CIFS or FTP to a remote machine, i get very poor read performance (around 13MB/s). The VM peaks at 100% cpu and I see a lot of insn_emulations and all

[Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes

2012-02-20 Thread Meador Inge
Commit e22b7015353be824620b1f0f5e32a8575b898a8c added the translation from target to host RLIMIT_* codes, but some of the added codes are only available on newer version of Linux (as documented in 'getrlimit(2)'). Signed-off-by: Meador Inge mead...@codesourcery.com --- linux-user/syscall.c |

Re: [Qemu-devel] [PATCH][v12] megasas: LSI Megaraid SAS HBA emulation

2012-02-20 Thread Gerhard Wiesinger
On Mon, 20 Feb 2012, Hannes Reinecke wrote: On 02/18/2012 01:38 PM, Gerhard Wiesinger wrote: Hello Hannes, Patch applies well to qemu tree and with a one line modification to qemu-kvm. My testcase was to install Fedora 16 x64 on qemu-kvm. Unfortunatly it was NOT successful. 1.) Strange

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-20 Thread Gleb Natapov
On Mon, Feb 20, 2012 at 07:17:55PM +0100, Peter Lieven wrote: Hi, I came a across an issue with a Windows 7 (32-bit) as well as with a Windows 2008 R2 (64-bit) guest. If I transfer a file from the VM via CIFS or FTP to a remote machine, i get very poor read performance (around 13MB/s).

Re: [Qemu-devel] [PATCH v6 1/4] cadence_uart: initial version of device model

2012-02-20 Thread Peter Maydell
On 20 February 2012 01:45, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: Implemented cadence UART serial controller Is there any publicly available documentation for this? Google only found a minimum-info datasheet... Signed-off-by: Peter A. G. Crosthwaite

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-20 Thread Gleb Natapov
On Mon, Feb 20, 2012 at 08:40:08PM +0200, Gleb Natapov wrote: On Mon, Feb 20, 2012 at 07:17:55PM +0100, Peter Lieven wrote: Hi, I came a across an issue with a Windows 7 (32-bit) as well as with a Windows 2008 R2 (64-bit) guest. If I transfer a file from the VM via CIFS or FTP to a

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-20 Thread Peter Lieven
On 20.02.2012 19:40, Gleb Natapov wrote: On Mon, Feb 20, 2012 at 07:17:55PM +0100, Peter Lieven wrote: Hi, I came a across an issue with a Windows 7 (32-bit) as well as with a Windows 2008 R2 (64-bit) guest. If I transfer a file from the VM via CIFS or FTP to a remote machine, i get very poor

Re: [Qemu-devel] win7 bad i/o performance, high insn_emulation and exists

2012-02-20 Thread Peter Lieven
On 20.02.2012 20:04, Gleb Natapov wrote: On Mon, Feb 20, 2012 at 08:40:08PM +0200, Gleb Natapov wrote: On Mon, Feb 20, 2012 at 07:17:55PM +0100, Peter Lieven wrote: Hi, I came a across an issue with a Windows 7 (32-bit) as well as with a Windows 2008 R2 (64-bit) guest. If I transfer a file

  1   2   >