[Qemu-devel] [RFC 7/9] hw/virtio-net.c: Add virtio-net device.

2012-04-25 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com --- hw/virtio-net.c | 46 ++ hw/virtio-net.h | 11 +++ 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index bc5e3a8..febf384 100644 ---

[Qemu-devel] [RFC 6/9] hw/virtio-balloon.c: Add virtio-balloon device.

2012-04-25 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com --- hw/virtio-balloon.c | 34 ++ hw/virtio-balloon.h |7 +++ 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index ce9d2c9..5640e58 100644 ---

Re: [Qemu-devel] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-04-25 Thread Alexey Korolev
On 25/04/12 13:48, Kevin O'Connor wrote: On Tue, Apr 24, 2012 at 06:25:39PM +1200, Alexey Korolev wrote: Migrate 64bit entries to 64bit pci regions if they do not fit in 32bit range. [...] +static void pci_region_migrate_64bit_entries(struct pci_region *from, +

[Qemu-devel] [RFC 2/9] virtio: Support transports which can specify the vring alignment

2012-04-25 Thread Evgeny Voevodin
From: Peter Maydell peter.mayd...@linaro.org Support virtio transports which can specify the vring alignment (ie where the guest communicates this to the host) by providing a new virtio_queue_set_align() function. (The default alignment remains as before.) FIXME save/load support for this new

[Qemu-devel] [RFC 0/9] Virtio-mmio refactoring.

2012-04-25 Thread Evgeny Voevodin
This patchset is derived from patchset provided by Peter Maydell peter.mayd...@linaro.org: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01870.html Also this patchset includes some fixes for bugs spotted by Ying-Shiuan Pan ys...@itri.org.tw. Still isue pointed by Peter presents here I

[Qemu-devel] [RFC 5/9] hw/virtio-serial-bus.c: Add virtio-serial device.

2012-04-25 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com --- hw/virtio-serial-bus.c | 42 ++ hw/virtio-serial.h |9 + 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index

[Qemu-devel] [RFC 3/9] Virtio: Add transport bindings.

2012-04-25 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com --- Makefile.objs |1 + hw/virtio-transport.c | 46 ++ hw/virtio-transport.h | 39 +++ 3 files changed, 86 insertions(+), 0 deletions(-) create

Re: [Qemu-devel] [PATCH v10 2/4] sockets: change inet_connect() to support nonblock socket

2012-04-25 Thread Orit Wasserman
On 04/25/2012 08:21 AM, Amos Kong wrote: Add a bool argument to inet_connect() to assign if set socket to block/nonblock, and delete original argument 'socktype' that is unused. Add a new argument to inet_connect()/inet_connect_opts(), to pass back connect error by error class. Retry to

Re: [Qemu-devel] [PULL] QOM CPUState for cris and microblaze

2012-04-25 Thread Edgar E. Iglesias
On Mon, Apr 23, 2012 at 04:43:37PM +0200, Andreas Färber wrote: Hello Edgar, Ask and thou shall receive: Please pull the cris and microblaze QOM CPU conversions. Thanks, I've applied the series Cheers Changes from v2: * Rebased onto master (all preceding targets got merged in the

[Qemu-devel] [Bug 988125] Re: Generated smb.conf needs to declare state directory

2012-04-25 Thread Jan Kiszka
That may fix old complaints about the smb feature not working. Since which smb version is this switch available? Maybe we need to make a version check before injecting it. In any case, please post such a change as proper patch (subject, description, signed-off) to qemu-devel. Thanks! -- You

[Qemu-devel] [Bug 988128] Re: smbd crashes when called with smb ports = 0

2012-04-25 Thread Jan Kiszka
It communicates via standard input (just like inetd). Obviously newer versions do not need this anymore, and smbd will detect in which mode it is supposed to run. That switch was once introduce in 15ef3e to add Samba 3 support. Maybe you can check with the samba guys if that switch was

Re: [Qemu-devel] [PATCH 1/7] e1000: introduce bits of PHY control register

2012-04-25 Thread Michael S. Tsirkin
On Thu, Mar 22, 2012 at 06:01:42PM +0800, Jason Wang wrote: This would be used be following patches. Signed-off-by: Jason Wang jasow...@redhat.com Applied, thanks. --- hw/e1000_hw.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/e1000_hw.h

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-25 Thread David Gibson
On Tue, Apr 24, 2012 at 03:46:25PM +0200, Paolo Bonzini wrote: Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: [snip] #elif defined(_ARCH_PPC) /* - * We use an eieio() for a wmb() on powerpc. This assumes we don't + * We use an eieio() for wmb() and mb() on powerpc. This

Re: [Qemu-devel] [PATCH v2] configure: Fix creation of symbolic links for MinGW toolchain

2012-04-25 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 01:20:47PM +0100, Stefan Weil wrote: The MinGW toolchain on w32/w64 hosts does not create symbolic links, but implements 'ln -s' similar to 'cp -r'. In incremental out of tree builds, this resulted in files which were not updated when their counterparts in the QEMU

Re: [Qemu-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Christoph Hellwig
-case BLKIF_OP_WRITE_BARRIER: +case BLKIF_OP_FLUSH_DISKCACHE: if (!ioreq-req.nr_segments) { ioreq-presync = 1; return 0; } -ioreq-presync = ioreq-postsync = 1; +ioreq-postsync = 1; /* fall through */ It might be

Re: [Qemu-devel] How can I see the data for IDE DMA?

2012-04-25 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 10:25 AM, Sungchan Kim sungchan@chonbuk.ac.kr wrote: I'm trying to integrate our custom SSD simulator by modifying the ide part of qemu. [...] I need to monitor (and get) the actual IDE DMA data that is read from/written when using the raw disk image, /dev/sdb. Can

Re: [Qemu-devel] [PULL] xen patches

2012-04-25 Thread Christoph Hellwig
On Tue, Apr 24, 2012 at 12:28:35PM +0100, Stefano Stabellini wrote: xen_disk: use bdrv_aio_flush instead of bdrv_flush This one seems completely broken, as it just queues up the flushes and writes without any ordering between them. Linux filesystems absolutely rely on a REQ_FUA request

Re: [Qemu-devel] [PATCH] pci: Remove partial overrun checking from pci_host_config_{read, write} common

2012-04-25 Thread Michael S. Tsirkin
On Mon, Apr 16, 2012 at 02:16:24PM +1000, David Gibson wrote: Currently the pci_host_config_{read,write}_common() functions clamp the given access size to prevent it from overruning the size of config space. This does not protect against total overruns (that is where the start address is

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Ian Campbell
On Wed, 2012-04-25 at 09:45 +0100, Christoph Hellwig wrote: -case BLKIF_OP_WRITE_BARRIER: +case BLKIF_OP_FLUSH_DISKCACHE: if (!ioreq-req.nr_segments) { ioreq-presync = 1; return 0; } -ioreq-presync = ioreq-postsync = 1; +

[Qemu-devel] [PATCH 1/9] hw/qxl.c: qxl_phys2virt: replace panics with guest_bug

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index c3540c3..9e8cdf3 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1097,15 +1097,28 @@ void *qxl_phys2virt(PCIQXLDevice *qxl,

[Qemu-devel] [PATCH 3/9] qxl: replace panic with guest bug in qxl_track_command

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index b6a738e..8b66cbb 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -394,7 +394,11 @@ static int qxl_track_command(PCIQXLDevice *qxl, struct

[Qemu-devel] [PATCH 2/9] qxl: check for NULL return from qxl_phys2virt

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl-logger.c | 51 ++- hw/qxl-render.c | 14 +++--- hw/qxl.c| 13 - hw/qxl.h|6 +++--- 4 files changed, 64 insertions(+), 20 deletions(-) diff --git

[Qemu-devel] [PATCH 8/9] qxl: qxl_add_memslot: remove guest trigerrable panics

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 44ee495..44a167a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1038,8 +1038,8 @@ static const MemoryRegionPortio

[Qemu-devel] [PATCH 9/9] qxl: ioport_write: remove guest trigerrable abort

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 44a167a..c614c91 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1464,8 +1464,7 @@ async_common: qxl_spice_destroy_surfaces(d, async);

[Qemu-devel] [PULL] QOM CPUState properties for x86

2012-04-25 Thread Andreas Färber
Hello Anthony, Please pull the x86 QOM CPU properties. Cc: Anthony Liguori anth...@codemonkey.ws The following changes since commit cf36b31db209a261ee3bc2737e788e1ced0a1bec: Limit ptimer rate to something achievable (2012-04-24 09:50:31 -0500) are available in the git repository at:

[Qemu-devel] [PATCH v3 02/15] target-i386: Pass X86CPU to cpu_x86_register()

2012-04-25 Thread Andreas Färber
Avoids an x86_env_get_cpu() call there, to work with QOM properties. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c|3 ++- target-i386/cpu.h|2 +-

[Qemu-devel] [PATCH v3 05/15] target-i386: Add model property to X86CPU

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH 6/9] qxl: cleanup s/__FUNCTION__/__func__/

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 44a4c9b..6e7232c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1503,7 +1503,7 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t events)

Re: [Qemu-devel] [RFC PATCH 1/1] virtio-serial-bus: Unset guest_connected at reset and driver reset

2012-04-25 Thread Alon Levy
On Tue, Apr 24, 2012 at 07:39:27PM +0530, Amit Shah wrote: When a guest driver resets the virtio status to not ready, or when qemu is reset, reset the guest_connected bit and let ports know if they have the guest_close() callback registered. Reviewed-by: Alon Levy al...@redhat.com Looks

[Qemu-devel] [PULL] e1000, eepro100, virtio

2012-04-25 Thread Michael S. Tsirkin
The following changes since commit cf36b31db209a261ee3bc2737e788e1ced0a1bec: Limit ptimer rate to something achievable (2012-04-24 09:50:31 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git refs/tags/for_anthony for you to fetch changes up to

[Qemu-devel] [PATCH v3 09/15] target-i386: Add property getter for CPU model

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c

[Qemu-devel] [PATCH v3 10/15] target-i386: Add property getter for CPU stepping

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index

[Qemu-devel] [PATCH] tracetool: use Python 2.5-compatible exception handling syntax

2012-04-25 Thread Stefan Hajnoczi
The newer except exception-type as exception: syntax is not supported by Python 2.5, we need to use except exception-type, exception:. Tested all trace backends with Python 2.5.6. Reported-by: Andreas Färber afaer...@suse.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PULL 0/9] Tracing patches

2012-04-25 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 7:00 PM, Andreas Färber afaer...@suse.de wrote: Am 18.04.2012 16:07, schrieb Stefan Hajnoczi: The last tracing pull for 1.1 before we merge only fixes. The following changes since commit 6e7a7f3d9bc2031b4c93c05400b18775ba1b1f55:   Allow controlling volume with

[Qemu-devel] [PATCH v2] qxl: don't assert on guest create_guest_primary

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index c614c91..6c11e70 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1191,7 +1191,10 @@ static void qxl_create_guest_primary(PCIQXLDevice *qxl, int

[Qemu-devel] [PATCH v3 12/15] target-i386: Introduce level property for X86CPU

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH v3 03/15] target-i386: Add range check for -cpu , family=x

2012-04-25 Thread Andreas Färber
A family field value of 0xf and extended family field value of 0xff is the maximum representable unsigned family number. All other CPUID property values are bounds-checked, so add a check here for symmetry before we adopt it in a property setter. Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PATCH v3 14/15] target-i386: Prepare vendor property for X86CPU

2012-04-25 Thread Andreas Färber
Using it now would incur converting the three x86_def_t vendor words into a string for object_property_set_str(), then back to three words in the vendor setter. The built-in CPU definitions use numeric preprocessor defines to initialize the three words in a charset-safe way, so do not change the

[Qemu-devel] [PATCH v3 15/15] target-i386: Introduce tsc-frequency property for X86CPU

2012-04-25 Thread Andreas Färber
Use Hz as unit. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH v3 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-25 Thread Andreas Färber
Don't assume zeroed cpuid_model[] fields. This didn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Reviewed-by: Eduardo Habhost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com [AF: Use

[Qemu-devel] [PATCH v3 08/15] target-i386: Add property getter for CPU family

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index

[Qemu-devel] [PATCH v3 06/15] target-i386: Add stepping property to X86CPU

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Christoph Hellwig
On Wed, Apr 25, 2012 at 10:02:45AM +0100, Ian Campbell wrote: The blkif spec was recently much improved, you can find it at http://xenbits.xen.org/docs/unstable/hypercall/include,public,io,blkif.h.html TBH I'm not sure it actually answers your questions wrt BLKIF_OP_FLUSH_DISKCACHE, if not

[Qemu-devel] [PATCH v3 07/15] target-i386: Add model-id property to X86CPU

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index

[Qemu-devel] [PATCH 4/9] qxl: fix 80 chars line

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 8b66cbb..b22f86e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -777,8 +777,8 @@ static void interface_async_complete_io(PCIQXLDevice *qxl,

[Qemu-devel] [PATCH 5/9] qxl: don't abort on guest trigerrable ring indices mismatch

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 51 +++ 1 file changed, 39 insertions(+), 12 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b22f86e..44a4c9b 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -27,28 +27,42 @@ #include qxl.h

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2012 at 04:38:50PM +1000, David Gibson wrote: On Tue, Apr 24, 2012 at 03:46:25PM +0200, Paolo Bonzini wrote: Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: [snip] #elif defined(_ARCH_PPC) /* - * We use an eieio() for a wmb() on powerpc. This assumes we

[Qemu-devel] [PATCH 7/9] qxl: interface_notify_update: remove guest trigerrable abort

2012-04-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6e7232c..44ee495 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -768,8 +768,13 @@ static int interface_req_cursor_notification(QXLInstance

[Qemu-devel] [PATCH v3 13/15] target-i386: Introduce xlevel property for X86CPU

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH v3 04/15] target-i386: Add family property to X86CPU

2012-04-25 Thread Andreas Färber
Add the property early in the initfn so that it can be used in helpers such as mce_init(). Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com [AF: Add an error_free(), spotted by Michael Roth] Reviewed-by: Igor Mammedov imamm...@redhat.com ---

[Qemu-devel] [PATCH v3 11/15] target-i386: Add property getter for CPU model-id

2012-04-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c

Re: [Qemu-devel] [PATCH v2 1/6] block: use Error mechanism instead of -errno for block_job_create()

2012-04-25 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 7:35 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 24 Apr 2012 14:53:55 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The block job API uses -errno return values internally and we convert these to Error in the QMP functions.  This is ugly because

Re: [Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream

2012-04-25 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 8:14 PM, Luiz Capitulino lcapitul...@redhat.com wrote:  # Returns: Nothing on success  #          If streaming is already active on this device, DeviceInUse  #          If @device does not exist, DeviceNotFound  #          If image streaming is not supported by this

Re: [Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-25 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 8:31 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Mon, 23 Apr 2012 16:39:48 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Allow streaming operations to be started with an initial speed limit. This eliminates the window of time between starting

Re: [Qemu-devel] [PATCH v2 0/6] block: add optional 'speed' parameter to block-stream

2012-04-25 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 8:31 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 24 Apr 2012 14:53:54 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Eric Blake raised concerns about the inability to start block jobs with a speed limit.  Current the user needs to follow up

[Qemu-devel] [HACK] hda: expose microphone instead of line-in

2012-04-25 Thread Jan Kiszka
Hi Gerd, I had problems with Windows LiveMeeting expecting a microphone as input. But the HDA model only exposes a line-in port. The following hack works for me, but I bet there is a cleaner solution. Any suggestions? BTW, sound output quality of a Win7 guest on my Linux hosts sucks while it's

Re: [Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream

2012-04-25 Thread Kevin Wolf
Am 24.04.2012 15:53, schrieb Stefan Hajnoczi: diff --git a/qapi-schema.json b/qapi-schema.json index d56fcb6..b1e349f 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1571,15 +1571,19 @@ # # @base: #optional the common backing file name # +# @speed: #optional the maximum

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Stefano Stabellini
On Wed, 25 Apr 2012, Christoph Hellwig wrote: On Wed, Apr 25, 2012 at 10:02:45AM +0100, Ian Campbell wrote: The blkif spec was recently much improved, you can find it at http://xenbits.xen.org/docs/unstable/hypercall/include,public,io,blkif.h.html TBH I'm not sure it actually answers

Re: [Qemu-devel] [PATCH v2 0/6] block: add optional 'speed' parameter to block-stream

2012-04-25 Thread Kevin Wolf
Am 25.04.2012 12:57, schrieb Stefan Hajnoczi: On Tue, Apr 24, 2012 at 8:31 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 24 Apr 2012 14:53:54 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Eric Blake raised concerns about the inability to start block jobs with a

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Ian Campbell
On Wed, 2012-04-25 at 12:21 +0100, Stefano Stabellini wrote: On Wed, 25 Apr 2012, Christoph Hellwig wrote: On Wed, Apr 25, 2012 at 10:02:45AM +0100, Ian Campbell wrote: The blkif spec was recently much improved, you can find it at

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Christoph Hellwig
On Wed, Apr 25, 2012 at 12:21:53PM +0100, Stefano Stabellini wrote: That is true, in fact I couldn't figure out what I had to implement just reading the comment. So I went through the blkback code and tried to understand what I had to do, but I got it wrong. Reading the code again it seems

Re: [Qemu-devel] [PULL] xen patches

2012-04-25 Thread Stefano Stabellini
Anthony, please ignore this pull request, I'll rework and resubmit later. On Wed, 25 Apr 2012, Christoph Hellwig wrote: On Tue, Apr 24, 2012 at 12:28:35PM +0100, Stefano Stabellini wrote: xen_disk: use bdrv_aio_flush instead of bdrv_flush This one seems completely broken, as it just

Re: [Qemu-devel] [HACK] hda: expose microphone instead of line-in

2012-04-25 Thread Gerd Hoffmann
On 04/25/12 13:03, Jan Kiszka wrote: Hi Gerd, I had problems with Windows LiveMeeting expecting a microphone as input. But the HDA model only exposes a line-in port. The following hack works for me, but I bet there is a cleaner solution. Any suggestions? Good to know this works. /me has

Re: [Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-25 Thread Luiz Capitulino
On Wed, 25 Apr 2012 11:56:51 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Apr 24, 2012 at 8:31 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Mon, 23 Apr 2012 16:39:48 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Allow streaming operations to be started

Re: [Qemu-devel] [PATCH] tracetool: use Python 2.5-compatible exception handling syntax

2012-04-25 Thread Andreas Färber
Am 25.04.2012 11:42, schrieb Stefan Hajnoczi: The newer except exception-type as exception: syntax is not supported by Python 2.5, we need to use except exception-type, exception:. Tested all trace backends with Python 2.5.6. Reported-by: Andreas Färber afaer...@suse.de Signed-off-by:

[Qemu-devel] [PATCH] qemu-iotests: fix missing 'result' variable assignment in 030

2012-04-25 Thread Stefan Hajnoczi
We test this value after block-job-cancel but forget to actually assign it. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Acked-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/030 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/030

[Qemu-devel] [PATCH] Declare state directory in smb.conf

2012-04-25 Thread Nikolaus Rath
The smb.conf generated by the userspace networking does not include a state directory directive. Samba therefore falls back to the default value. Since the user generally does not have write access to this path, smbd immediately crashes. The state directory option was added in Samba 3.4.0

Re: [Qemu-devel] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-04-25 Thread Kevin O'Connor
On Wed, Apr 25, 2012 at 06:25:07PM +1200, Alexey Korolev wrote: On 25/04/12 13:48, Kevin O'Connor wrote: On Tue, Apr 24, 2012 at 06:25:39PM +1200, Alexey Korolev wrote: +pci_region_map_entries(busses, r64_mem); +pci_region_map_entries(busses, r64_pref); +} //

[Qemu-devel] Fwd: buildbot failure in qemu on ubuntu-default

2012-04-25 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on ubuntu-default Date: Tue, 24 Apr 2012 21:28:11 +0200 From: build...@spunk.home.kraxel.org To: kra...@gmail.com The Buildbot has detected a failed build on builder ubuntu-default while building qemu. Full details are

Re: [Qemu-devel] [PATCH v2 0/2] [trivial] More concise handling of tracetool-generated files

2012-04-25 Thread Stefan Hajnoczi
On Wed, Apr 18, 2012 at 08:15:34PM +0200, Lluís Vilanova wrote: Some trivial changes to handle tracetool-generated files more concisely. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- NOTE: Applies on top of the tracetool rewrite. Changes in v2: * Only remove tracetool-generated

Re: [Qemu-devel] [PATCH v3 5/5] qemu-iotests: add block-stream speed value test case

2012-04-25 Thread Eric Blake
On 04/25/2012 07:17 AM, Stefan Hajnoczi wrote: Add tests to exercise the InvalidParameter 'speed' error code path, as well as the regular success case for setting the speed. The block-stream 'speed' parameter allows the speed limit of the job to be applied immediately when the job starts

[Qemu-devel] [PULL] QOM CPUState for sh4, m68k and mips

2012-04-25 Thread Andreas Färber
Hello Anthony, Blue, Please pull the remainder of the QOM CPU conversions: sh4, m68k and mips. There was no reaction from the listed maintainers to my patches for weeks nor to the MAINTAINERS RFC for one week, so please apply to let us proceed. Cc: Anthony Liguori anth...@codemonkey.ws Cc: Blue

[Qemu-devel] [PATCH 03/12] target-sh4: QOM'ify CPU

2012-04-25 Thread Andreas Färber
Embed CPUSH4State as first member of SuperHCPU. Let CPUClass::reset() call cpu_state_reset() for now. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- Makefile.target|1 + target-sh4/cpu-qom.h | 70

[Qemu-devel] [PATCH 1/3] exynos4210: drop All rights reserved line from files license

2012-04-25 Thread Igor Mitsyanko
It has been noted that All rights reserved statement conflicts with GPL, remove it. Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com --- hw/exynos4210.c |2 +- hw/exynos4210.h |2 +- hw/exynos4210_combiner.c |3 +-- hw/exynos4210_fimd.c |3 +--

[Qemu-devel] [PATCH 09/12] target-m68k: Add QOM CPU subclasses

2012-04-25 Thread Andreas Färber
Move code from cpu_m68k_set_model() into model-specific initfns and inline the remaining parts into cpu_m68k_init(). Let m68k_cpu_list() print CPU classes alphabetically except for any. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Laurent Vivier laur...@vivier.eu Tested-by:

[Qemu-devel] [PATCH v3 0/5] block: add optional 'speed' parameter to block-stream

2012-04-25 Thread Stefan Hajnoczi
Eric Blake raised concerns about the inability to start block jobs with a speed limit. Current the user needs to follow up the block-stream command with block-job-set-speed. There is a window of time while the new block job is running but block-job-set-speed has not been processed yet. This

[Qemu-devel] [PATCH v3 2/5] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-25 Thread Stefan Hajnoczi
There are at least two different errors that can occur in block_job_set_speed(): the job might not support setting speeds or the value might be invalid. Use the Error mechanism to report the error where it occurs. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Acked-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] tracetool: use Python 2.5-compatible exception handling syntax

2012-04-25 Thread Lluís Vilanova
Stefan Hajnoczi writes: The newer except exception-type as exception: syntax is not supported by Python 2.5, we need to use except exception-type, exception:. Tested all trace backends with Python 2.5.6. Reported-by: Andreas Färber afaer...@suse.de Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] Fwd: buildbot failure in qemu on ubuntu-default

2012-04-25 Thread Anthony Liguori
On 04/25/2012 08:56 AM, Gerd Hoffmann wrote: Original Message Subject: buildbot failure in qemu on ubuntu-default Date: Tue, 24 Apr 2012 21:28:11 +0200 From: build...@spunk.home.kraxel.org To: kra...@gmail.com The Buildbot has detected a failed build on builder

Re: [Qemu-devel] [PATCH] pci: Remove partial overrun checking from pci_host_config_{read, write} common

2012-04-25 Thread David Gibson
On Wed, Apr 25, 2012 at 11:08:12AM +0300, Michael S. Tsirkin wrote: On Mon, Apr 16, 2012 at 02:16:24PM +1000, David Gibson wrote: Currently the pci_host_config_{read,write}_common() functions clamp the given access size to prevent it from overruning the size of config space. This does not

Re: [Qemu-devel] [PATCH v6 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-25 Thread Paul Brook
On 23 April 2012 23:21, Peter Chubb peter.ch...@nicta.com.au wrote: Peter Are these two devices really on the same IRQ? Yes. A single interrupt line comes from the FPGA into the AVIC. Inside the FPGA the interrupts for the UARTs, SD card and NAND flash are connected to that single

[Qemu-devel] [PATCH v3 3/5] block: change block-job-set-speed argument from 'value' to 'speed'

2012-04-25 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Acked-by: Kevin Wolf kw...@redhat.com --- block.c |6 +++--- block/stream.c |8 block_int.h |4 ++-- blockdev.c |4 ++-- hmp-commands.hx |4 ++-- qapi-schema.json |4 ++--

[Qemu-devel] [PATCH 0/3] Exynos4210: license and RAM vmstate fixes

2012-04-25 Thread Igor Mitsyanko
PATCH1 drops All rights reserved from all exynos-related file's licenses. PATCH2 registers RO MemoryRegions for live migration. This is needed because ram_save_live saves all MemoryRegions no matter if they were registered or not. This is probably a bug in QEMU because It's not written anywhere

[Qemu-devel] [PATCH 10/12] target-mips: QOM'ify CPU

2012-04-25 Thread Andreas Färber
Embed CPUMIPSState as first member of QOM MIPSCPU. Let CPUClass::reset() call cpu_state_reset() for now. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Richard Henderson r...@twiddle.net --- Makefile.target |3 ++ target-mips/cpu-qom.h | 74

[Qemu-devel] [PATCH 2/6] MAINTAINERS: Fix virtio-9p file pattern

2012-04-25 Thread Andreas Färber
Only one pattern is allowed per F: line, split in two. Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- MAINTAINERS |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PATCH 3/6] MAINTAINERS: Fix TCI file pattern

2012-04-25 Thread Andreas Färber
tcg/tci is a directory, so for recursive semantics add a trailing slash. Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Stefan Weil s...@weilnetz.de --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PATCH 6/6] MAINTAINERS: Document all stable trees

2012-04-25 Thread Andreas Färber
We currently host stable trees for 0.10, 0.14, 0.15 and 1.0. Sort in descending order. It is expected that further non-stable sections will be added above these so this order avoids scrolling through an ever-growing list of stable trees. Signed-off-by: Andreas Färber afaer...@suse.de ---

[Qemu-devel] [PATCH 5/6] MAINTAINERS: Fix SCM tree for virtio-9p

2012-04-25 Thread Andreas Färber
Instead of a Web link, T: is supposed to indicate type of SCM and pullable URL, so switch to the git:// URL. Also harmonize the spacing between sections while at it. Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- MAINTAINERS |3

[Qemu-devel] [PULL] MAINTAINERS tidying and stable trees

2012-04-25 Thread Andreas Färber
Hello Anthony, Please pull the uncontroversial parts of MAINTAINERS updates. I'm leaving out the Maintained upgrades and would ask you to apply the 0.15 patch once we've figured that out. For darwin-user I'll send a separate PULL. Cc: Anthony Liguori anth...@codemonkey.ws The following changes

Re: [Qemu-devel] [PATCH] tracetool: use Python 2.5-compatible exception handling syntax

2012-04-25 Thread Stefan Hajnoczi
On Wed, Apr 25, 2012 at 2:35 PM, Andreas Färber andreas.faer...@web.de wrote: Am 25.04.2012 11:42, schrieb Stefan Hajnoczi: The newer except exception-type as exception: syntax is not supported by Python 2.5, we need to use except exception-type, exception:. Tested all trace backends with

Re: [Qemu-devel] [SeaBIOS] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-04-25 Thread Gerd Hoffmann
On 04/25/12 14:51, Kevin O'Connor wrote: On Wed, Apr 25, 2012 at 06:25:07PM +1200, Alexey Korolev wrote: On 25/04/12 13:48, Kevin O'Connor wrote: On Tue, Apr 24, 2012 at 06:25:39PM +1200, Alexey Korolev wrote: +pci_region_map_entries(busses, r64_mem); +

[Qemu-devel] [PATCH 1/6] MAINTAINERS: Fix PC file pattern

2012-04-25 Thread Andreas Färber
Only one pattern is allowed per F: line, split it in two. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Anthony Liguori aligu...@us.ibm.com --- MAINTAINERS |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index cce37e7..83d3568 100644 ---

[Qemu-devel] [PATCH 02/12] MAINTAINERS: Downgrade target-mips and target-sh4 to Odd Fixes

2012-04-25 Thread Andreas Färber
Patches are not being handled, so let's downgrade to Odd Fixes. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Aurélien Jarno aurel...@aurel32.net --- MAINTAINERS |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8ae9158..32d8dc7

[Qemu-devel] [PATCH 4/6] MAINTAINERS: Indicate type of SCM

2012-04-25 Thread Andreas Färber
T: lines are supposed to indicate whether it's git. Signed-off-by: Andreas Färber afaer...@suse.de --- MAINTAINERS |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7781023..305dbf9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -437,7

[Qemu-devel] [PATCH 06/12] target-m68k: QOM'ify CPU

2012-04-25 Thread Andreas Färber
Embed CPUM68KState as first member of QOM M68kCPU. Drop cpu_m68k_close() in favor of object_delete(). Let CPUClass::reset() call cpu_state_reset() for now. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Laurent Vivier laur...@vivier.eu Tested-by: Laurent Vivier laur...@vivier.eu ---

Re: [Qemu-devel] [PATCH v3 5/5] qemu-iotests: add block-stream speed value test case

2012-04-25 Thread Stefan Hajnoczi
On Wed, Apr 25, 2012 at 3:21 PM, Eric Blake ebl...@redhat.com wrote: On 04/25/2012 07:17 AM, Stefan Hajnoczi wrote: Add tests to exercise the InvalidParameter 'speed' error code path, as well as the regular success case for setting the speed.  The block-stream 'speed' parameter allows the

[Qemu-devel] [PATCH v4 0/5] block: add optional 'speed' parameter to block-stream

2012-04-25 Thread Stefan Hajnoczi
Eric Blake raised concerns about the inability to start block jobs with a speed limit. Current the user needs to follow up the block-stream command with block-job-set-speed. There is a window of time while the new block job is running but block-job-set-speed has not been processed yet. This

[Qemu-devel] [PATCH v4 1/5] block: use Error mechanism instead of -errno for block_job_create()

2012-04-25 Thread Stefan Hajnoczi
The block job API uses -errno return values internally and we convert these to Error in the QMP functions. This is ugly because the Error should be created at the point where we still have all the relevant information. More importantly, it is hard to add new error cases to this case since we

[Qemu-devel] [PATCH v4 2/5] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-25 Thread Stefan Hajnoczi
There are at least two different errors that can occur in block_job_set_speed(): the job might not support setting speeds or the value might be invalid. Use the Error mechanism to report the error where it occurs. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Acked-by: Kevin Wolf

[Qemu-devel] [PATCH v4 3/5] block: change block-job-set-speed argument from 'value' to 'speed'

2012-04-25 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Acked-by: Kevin Wolf kw...@redhat.com --- block.c |6 +++--- block/stream.c |8 block_int.h |4 ++-- blockdev.c |4 ++-- hmp-commands.hx |4 ++-- qapi-schema.json |4 ++--

  1   2   >