Re: [Qemu-devel] [PATCH 2/2] hw/armv7m_nvic: Add global variable for SysTick external reference clock

2012-10-12 Thread Andre Beckus
On Wed, 2012-10-10 at 13:03 +0100, Peter Maydell wrote: On 9 October 2012 23:29, Andre Beckus mikemail98-q...@yahoo.com wrote: Adds a new external reference clock scale variable to complement the existing system_clock_scale variable. Previously, the value was hardcoded to 1000 when

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-12 Thread Avik Sil
On 10/12/2012 04:29 AM, David Gibson wrote: On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: This patch adds nvram specified boot device into qemu default boot_devices list. This helps firmware to boot from nvram specified boot device if no -boot option is specified. I really don't

Re: [Qemu-devel] slower live-migration with XBZRLE

2012-10-12 Thread Alexandre DERUMIER
Hi, I have observed same behaviour with vm with lot of memory transfert, or playing video in the guest. https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg00138.html You can try to tunned to xbzrle cache size, maybe it'll improve speed. - Mail original - De: Vasilis Liaskovitis

[Qemu-devel] Build the qemu with spice support return error

2012-10-12 Thread Bing Bu Cao
Hi, I want to build qemu(not qemu-kvm) with spice support enabled. 1.build spice cd $SRC_ROOT/spice ./autogen.sh make install 2.build qemu cd $SRC_ROOT/qemu ./configure --target-list=x86_64-softmmu --enable-spice make return error: /qemu/hw/i386/../qxl.c: In function

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-10-12 Thread Mike Lovell
On 10/12/2012 12:49 AM, Mike Lovell wrote: This makes a few changes to allow ifname to be specified when using qemu-bridge-helper with both the bridge and tap network interfaces. It adds the --ifname option to qemu-bridge-helper, removes the restriction that ifname cannot be specified with

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Gerd Hoffmann
Hi, Yes. Reason I ask is because q35 is adding bridges by default now. Would it be possible to only add them if requested on command line by user instead? I realize some guests expect devices at specific slots but this does not apply to bridges I think? I just tried out getting rid of

[Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-10-12 Thread Mike Lovell
This makes a few changes to allow ifname to be specified when using qemu-bridge-helper with both the bridge and tap network interfaces. It adds the --ifname option to qemu-bridge-helper, removes the restriction that ifname cannot be specified with helper for the tap interface, and adds logic to

Re: [Qemu-devel] Build the qemu with spice support return error

2012-10-12 Thread Gerd Hoffmann
Hi, I have pull the latest source code and it still can not work,so I think the qxl.h need updated in the master ref? right? spice-protocol is too old and needs to be updated. Pending spice pull has patches to make sure spice-protocol and spice-server are recent enougth. cheers, Gerd

[Qemu-devel] [PATCH v2] chardev: Use timer instead of bottom-half to postpone open event

2012-10-12 Thread Jan Kiszka
As the block layer may decide to flush bottom-halfs while the machine is still initializing (e.g. to read geometry data from the disk), our postponed open event may be processed before the last frontend registered with a muxed chardev. Until the semantics of BHs have been clarified, use an

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-12 Thread Stefan Hajnoczi
On Thu, Oct 11, 2012 at 03:33:23PM +0200, Tiziano Müller wrote: One test case was: * xfs_repair /dev/vda2 - corruptions found and fixed * xfs_repair /dev/vda2 - no corruptions found From here... * mount /dev/vda2 /mnt/something * find /mnt/something /dev/null * umount /mnt/something

Re: [Qemu-devel] [RFC 3/7] block: bdrv_img_create(): move param printing to qemu-img

2012-10-12 Thread Paolo Bonzini
Il 11/10/2012 23:27, Luiz Capitulino ha scritto: bdrv_img_create() is being used by the transaction QMP command and therefore shouldn't print directly to the user. Move the param printing to qemu-img instead. Has the side effect of only printing it when the bdrv_img_create() call succeeds,

Re: [Qemu-devel] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

2012-10-12 Thread Kevin Wolf
Am 11.10.2012 17:04, schrieb Corey Bryant: On 10/11/2012 07:25 AM, Kevin Wolf wrote: Am 10.10.2012 16:20, schrieb Corey Bryant: qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was

Re: [Qemu-devel] [PATCH 1/2] hw/armv7m_nvic: Implement byte read/write for NVIC SCB_SHPRx registers

2012-10-12 Thread Peter Maydell
On 12 October 2012 06:43, Andre Beckus mikemail98-q...@yahoo.com wrote: Yes, I was being lazy. Now that I think about it, we could handle all sizes with one block of code directly in the nvic_sysreg_read and nvic_sysreg_write functions - the write would look like this: for(i = 0; i

Re: [Qemu-devel] [RFC 0/7] block: bdrv_img_create(): propagate errors

2012-10-12 Thread Paolo Bonzini
Il 11/10/2012 23:26, Luiz Capitulino ha scritto: I'm calling this an RFC because I did it on hurry and it's almost untested, but I wanted to drop it for early review while I'm out for a public holiday :) This should improve qmp_transaction() error messages on bdrv_img_create() failure quite

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-10-12 Thread Michael Tokarev
On 12.10.2012 10:49, Mike Lovell wrote: /* request a tap device, disable PI, and add vnet header support if - * requested and it's available. */ -prep_ifreq(ifr, tap%d); + * requested and it's available. use ifname if provided for tap name. */ +prep_ifreq(ifr, ifname !=

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-12 Thread Stefan Hajnoczi
On Thu, Oct 11, 2012 at 03:33:23PM +0200, Tiziano Müller wrote: Checking the image using `qemu-img check` then gives something like this: ERROR OFLAG_COPIED: offset=3bc3 refcount=1 ERROR offset=c7e331: Cluster is not properly aligned; L2 entry corrupted. Is any other program accessing

Re: [Qemu-devel] [PATCH 2/2] hw/armv7m_nvic: Add global variable for SysTick external reference clock

2012-10-12 Thread Peter Maydell
On 12 October 2012 07:53, Andre Beckus mikemail98-q...@yahoo.com wrote: As a case study, the STM32 does have a reference clock. It is simply the system clock divided by 8 (maybe not ARM's intention for it to be tied so closely to the system clock). The documentation says the TENMS field is

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-12 Thread Tiziano Müller
Am Freitag, den 12.10.2012, 10:33 +0200 schrieb Stefan Hajnoczi: On Thu, Oct 11, 2012 at 03:33:23PM +0200, Tiziano Müller wrote: Checking the image using `qemu-img check` then gives something like this: ERROR OFLAG_COPIED: offset=3bc3 refcount=1 ERROR offset=c7e331: Cluster is not

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-12 Thread Tiziano Müller
Am Freitag, den 12.10.2012, 10:28 +0200 schrieb Stefan Hajnoczi: On Thu, Oct 11, 2012 at 03:33:23PM +0200, Tiziano Müller wrote: One test case was: * xfs_repair /dev/vda2 - corruptions found and fixed * xfs_repair /dev/vda2 - no corruptions found From here... * mount /dev/vda2

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vnc: fix info vnc with -vnc ..., reverse=on

2012-10-12 Thread Stefan Hajnoczi
On Wed, Oct 10, 2012 at 02:30:58PM +0200, Paolo Bonzini wrote: When reverse connection is in use, there is no active VNC server socket. Because of this, getsockopt(-1, ...) is attempted and the following error is emitted: $ socat TCP-LISTEN:5900,reuseaddr TCP-LISTEN:5901,reuseaddr

[Qemu-devel] [PULL 0/3] Trivial patches for 6 to 12 October 2012

2012-10-12 Thread Stefan Hajnoczi
The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade: ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

[Qemu-devel] [PATCH 1/3] configure: Tidy up remnants of non-64-bit physaddrs

2012-10-12 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Tidy up some remnants of code to support non-64-bit physaddrs which were accidentally omitted from commit 4be403c8. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- configure | 2 -- 1 file

[Qemu-devel] [PATCH 3/3] vnc: fix info vnc with -vnc ..., reverse=on

2012-10-12 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com When reverse connection is in use, there is no active VNC server socket. Because of this, getsockopt(-1, ...) is attempted and the following error is emitted: $ socat TCP-LISTEN:5900,reuseaddr TCP-LISTEN:5901,reuseaddr $

[Qemu-devel] [PATCH 2/3] sheepdog: use bool for boolean variables

2012-10-12 Thread Stefan Hajnoczi
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This improves readability. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/sheepdog.c | 70 1 file changed, 35

[Qemu-devel] [PATCH 5/7] usb-serial: don't magically zap chardev on umplug

2012-10-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-serial.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 69b6e48..43214cd 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -421,7 +421,7 @@ static

[Qemu-devel] [PATCH 2/7] serial: add pci variant

2012-10-12 Thread Gerd Hoffmann
So we get a hot-pluggable 16550 uart. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- default-configs/pci.mak |2 + hw/Makefile.objs|1 + hw/pci_ids.h|1 + hw/serial-pci.c | 115 +++ hw/serial.c |

Re: [Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-10-12 Thread Jan Kiszka
On 2012-10-08 20:52, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-11 17:53, Jan Kiszka wrote: Our one and only BIOS depends on a writable shadowed BIOS in the ISA range. As we have no interface to control the write property, make that region writable by

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-12 Thread Michael S. Tsirkin
On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote: For writes, the standard seems to be a commit latch. We could abuse the generation count for this: the driver writes to it to commit config changes. I think this will work. There are a couple of things that bother me:

[Qemu-devel] [PATCH 1/7] serial: split serial.c

2012-10-12 Thread Gerd Hoffmann
Split serial.c into serial.c, serial.h and serial-isa.c. While being at creating a serial.h header file move the serial prototypes from pc.h to the new serial.h. The latter leads to s/pc.h/serial.h/ in tons of boards which just want the serial bits from pc.h Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Michael S. Tsirkin
On Fri, Oct 12, 2012 at 09:27:02AM +0200, Gerd Hoffmann wrote: Hi, Yes. Reason I ask is because q35 is adding bridges by default now. Would it be possible to only add them if requested on command line by user instead? I realize some guests expect devices at specific slots but this

[Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are tons of arguments for the different backends. The hmp version limited to the most common use

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 11:26, Gerd Hoffmann ha scritto: This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are tons of arguments for the different

Re: [Qemu-devel] [PULL 0/7] serial device hotplug patch series.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 11:25, Gerd Hoffmann ha scritto: Final patch adds chardev hotplug to the mix, which makes the other patches alot more useful. It is the missing bit needed to really hotplug serial devices: (qemu) chardev_add pciserial file /root/hotchardev.log (qemu) device_add

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-12 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote: For writes, the standard seems to be a commit latch. We could abuse the generation count for this: the driver writes to it to commit config changes. I think this will work. There

[Qemu-devel] [PULL 0/7] serial device hotplug patch series.

2012-10-12 Thread Gerd Hoffmann
Hi, This patch series tackles serial device hotplug. The first four patches have been on the list before, they implement pci-serial devices featuring a hot-pluggable 16550 uart and got some minor tweaks only. The next two patches update the usb-serial device. It will only show up in the

[Qemu-devel] [PATCH 4/7] serial: add 2x + 4x pci variant

2012-10-12 Thread Gerd Hoffmann
Add multiport serial card implementation, with two variants, one featuring two and one featuring four ports. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/qemupciserial.inf |2 + hw/serial-pci.c| 157 2 files changed, 159

[Qemu-devel] [PATCH 6/7] usb-serial: only expose device in guest when the chardev is open

2012-10-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-serial.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 43214cd..a466f99 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -427,6

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-12 Thread Michael S. Tsirkin
On Fri, Oct 12, 2012 at 08:21:50PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote: For writes, the standard seems to be a commit latch. We could abuse the generation count for this: the driver writes to

[Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs

2012-10-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/qemupciserial.inf | 107 1 files changed, 107 insertions(+), 0 deletions(-) create mode 100644 docs/qemupciserial.inf diff --git a/docs/qemupciserial.inf b/docs/qemupciserial.inf new file

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Gerd Hoffmann
Hi, I just tried out getting rid of the bridges by default. That clearly raises the question which devices should be created automatically by -M q35. I think the devices which are part of the ich9 chipset should be there by default. /me looks at my laptop which happens to have a ich9

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
On 10/12/12 11:40, Paolo Bonzini wrote: Il 12/10/2012 11:26, Gerd Hoffmann ha scritto: This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Michael S. Tsirkin
On Fri, Oct 12, 2012 at 12:06:44PM +0200, Gerd Hoffmann wrote: Hi, I just tried out getting rid of the bridges by default. That clearly raises the question which devices should be created automatically by -M q35. I think the devices which are part of the ich9 chipset should be

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 12:23, Gerd Hoffmann ha scritto: I suggest that you implement the commands in a similar way as netdev_add. Why? Isn't the whole point of using josn is that you'll get the stuff from the josn parser marshaller in a usable form instead of having it to feed into yet another

Re: [Qemu-devel] [PATCH 4/6] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr

2012-10-12 Thread Riku Voipio
Hi, On Thu, Oct 11, 2012 at 12:52:27PM -0700, Richard Henderson wrote: On 10/11/2012 12:22 PM, Richard Henderson wrote: The previous formuation with multiple assignments to __typeof(*hptr) falls down when hptr is qualified const. E.g. with const struct S *p, p-f is also qualified const.

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
On 10/12/12 12:50, Paolo Bonzini wrote: Il 12/10/2012 12:23, Gerd Hoffmann ha scritto: I suggest that you implement the commands in a similar way as netdev_add. Why? Isn't the whole point of using josn is that you'll get the stuff from the josn parser marshaller in a usable form instead of

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 13:15, Gerd Hoffmann ha scritto: In principle you're right, but I think it's ugly that adding another chardev argument needs changes in 3 places instead of just one. Hmm, I don't have to use the generated marshaller, right? With direct access to the QDict I could just

[Qemu-devel] [PULL 0/9] arm-devs queue

2012-10-12 Thread Peter Maydell
Hi; this is a pullreq for the arm-devs queue. Contains my fix for the various DS1338 bugs plus some other minor patches from various people; please pull. thanks -- PMM The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade: ssi: Add slave autoconnect helper (2012-10-10

[Qemu-devel] [PATCH 7/9] versatilepb: add gpio pl061 support

2012-10-12 Thread Peter Maydell
From: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/versatilepb.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/versatilepb.c

[Qemu-devel] [PATCH 1/9] cadence_ttc: Fix 'clear on read' behavior

2012-10-12 Thread Peter Maydell
From: Soren Brinkmann soren.brinkm...@xilinx.com A missing call to qemu_set_irq() when reading the IRQ register required SW to write to the IRQ register to acknowledge an interrupt. With this patch the behavior is fixed: - Reading the interrupt register clears it and updates the timers

Re: [Qemu-devel] [PATCH 2/2] linux-user: register align p{read, write}64

2012-10-12 Thread Peter Maydell
On 30 September 2012 02:32, Alexander Graf ag...@suse.de wrote: pread64 and pwrite64 pass 64bit parameters which for some architectures need to be aligned to special argument pairs, creating a gap argument. Handle this special case the same way we handle it in other places of the code.

[Qemu-devel] [PATCH 8/9] zynq_slcr: Fixed ResetValues enum

2012-10-12 Thread Peter Maydell
From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com There is a gap in the reset region of the address space at offset 0x208. This throws out all these enum values by one when translating them to address offsets. Fixed by putting the corresponding gap in the enum as well.

[Qemu-devel] [PATCH 5/9] hw/ds1338: Remove 'now' field from state struct

2012-10-12 Thread Peter Maydell
The 'struct tm now' field in the state structure is in fact only ever used as a temporary (the actual RTC state is held in 'offset'). Remove it from the state structure in favour of using local variables to avoid confusion about whether it needs to be saved on migration. Signed-off-by: Peter

[Qemu-devel] [PATCH 3/9] hw/ds1338: Fix mishandling of register pointer

2012-10-12 Thread Peter Maydell
Correct several deficiencies in the handling of the register pointer: * it should wrap around after 0x3f, not 0xff * guard against the caller handing us an out of range pointer (on h/w this can never happen, because only a 7 bit value is transferred over the I2C bus) * there was confusion

[Qemu-devel] [PATCH 9/9] arm_gic: Rename gic_state to GICState

2012-10-12 Thread Peter Maydell
Rename the gic_state struct to match QEMU's coding style conventions for structure names, since the impending KVM-for-ARM patches will create another subclass of it. This patch was created using: sed -i 's/gic_state/GICState/g' hw/arm_gic.c hw/arm_gic_common.c \ hw/arm_gic_internal.h

[Qemu-devel] [PATCH 6/9] hw/ds1338: Implement state save/restore

2012-10-12 Thread Peter Maydell
Implement state save/restore for the DS1338. This requires the usual minor adjustment of types in the state struct to get fixed-width ones with vmstate macros. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/ds1338.c | 27 ++- 1 file changed, 22

[Qemu-devel] [PATCH 2/9] hw/arm_gic.c: Fix improper DPRINTF output.

2012-10-12 Thread Peter Maydell
From: Evgeny Voevodin e.voevo...@samsung.com s-cpu_enabled is an array, so s-cpu_enabled ? En : Dis returns En always. We should use s-cpu_enabled[cpu] here. Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm_gic.c |2 +- 1

[Qemu-devel] [PATCH 4/9] hw/ds1338: Recapture current time when register pointer wraps around

2012-10-12 Thread Peter Maydell
The DS1338 datasheet documents that the current time is captured into the secondary registers when the register pointer wraps round to zero as well as at a START condition. Implement this. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/ds1338.c | 59

[Qemu-devel] [PATCH 0/2] qemu-img: Fix division by zero for zero size images

2012-10-12 Thread Kevin Wolf
Kevin Wolf (2): qemu-img: Fix division by zero for zero size images qemu-iotests: Test qemu-img operation on zero size image qemu-img.c | 23 tests/qemu-iotests/041 | 78 tests/qemu-iotests/041.out | 15

[Qemu-devel] [PATCH 1/2] qemu-img: Fix division by zero for zero size images

2012-10-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index f17f187..849eb41 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -674,7 +674,7 @@ static int img_convert(int argc,

[Qemu-devel] [PATCH 2/2] qemu-iotests: Test qemu-img operation on zero size image

2012-10-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/041 | 78 tests/qemu-iotests/041.out | 15 tests/qemu-iotests/group |1 + 3 files changed, 94 insertions(+), 0 deletions(-) create mode 100755

[Qemu-devel] [PATCH 03/11] linux-user: Perform more checks on iovec lists

2012-10-12 Thread riku . voipio
From: Richard Henderson r...@twiddle.net Validate count between 0 and IOV_MAX. Limit total length of operation in the same way the kernel does. Signed-off-by: Richard Henderson r...@twiddle.net Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/syscall.c | 162

[Qemu-devel] [PATCH 10/11] linux-user: ppc: mark as long long aligned

2012-10-12 Thread riku . voipio
From: Alexander Graf ag...@suse.de The SysV PPC32 ABI dictates that long long (64bit) parameters are pass in odd/even register pairs. Because unlike ARM and MIPS we start at an odd register number, we can reuse the same aligning code that ARM and MIPS use. Clarified inline comment that it is

[Qemu-devel] [PATCH 01/11] linux-user: fix statfs

2012-10-12 Thread riku . voipio
From: Alexander Graf ag...@suse.de The statfs syscall should always memset(0) its full struct extent before writing to it. Newer versions of the syscall use one of the reserved fields for flags, which would otherwise get stale values from uncleaned memory. This fixes libarchive for me, which got

[Qemu-devel] [PATCH 06/11] linux-user: Fix siginfo handling

2012-10-12 Thread riku . voipio
From: Richard Henderson r...@twiddle.net Compare signal numbers in the proper domain. Convert all of the fields for SIGIO and SIGCHLD. Signed-off-by: Richard Henderson r...@twiddle.net Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/qemu.h|3 +++ linux-user/signal.c |

[Qemu-devel] [PATCH 02/11] linux-user: fix multi-threaded /proc/self/maps

2012-10-12 Thread riku . voipio
From: Alexander Graf ag...@suse.de When reading our faked /proc/self/maps from a secondary thread, we get an invalid stack entry. This is because ts-stack_base is not initialized in non-primary threads. However, ts-info is, and the stack layout information we're looking for is there too. So

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
On 10/12/12 13:17, Paolo Bonzini wrote: Il 12/10/2012 13:15, Gerd Hoffmann ha scritto: In principle you're right, but I think it's ugly that adding another chardev argument needs changes in 3 places instead of just one. Hmm, I don't have to use the generated marshaller, right? With direct

[Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are tons of arguments for the different backends. The hmp version limited to the most common use

[Qemu-devel] [PATCH 09/11] tcg: Remove TCG_TARGET_HAS_GUEST_BASE define

2012-10-12 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org GUEST_BASE support is now supported by all TCG backends, and is now mandatory. Drop the now-pointless TCG_TARGET_HAS_GUEST_BASE define (set by every backend) and the error if it is unset. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
On 10/12/12 14:39, Gerd Hoffmann wrote: This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are tons of arguments for the Oops. Ignore the

[Qemu-devel] [PATCH 04/11] linux-user: Implement gethostname

2012-10-12 Thread riku . voipio
From: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/syscall.c | 13 + 1 file changed, 13 insertions(+) diff --git

[Qemu-devel] [PATCH 11/11] linux-user: register align p{read, write}64

2012-10-12 Thread riku . voipio
From: Alexander Graf ag...@suse.de pread64 and pwrite64 pass 64bit parameters which for some architectures need to be aligned to special argument pairs, creating a gap argument. Handle this special case the same way we handle it in other places of the code. Reported-by: Alex Barcelo

[Qemu-devel] [PATCH 05/11] alpha-linux-user: Fix sigaltstack structure definition

2012-10-12 Thread riku . voipio
From: Richard Henderson r...@twiddle.net Signed-off-by: Richard Henderson r...@twiddle.net Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/alpha/target_signal.h |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/linux-user/alpha/target_signal.h

[Qemu-devel] [PATCH 08/11] configure: Remove unnecessary host_guest_base code

2012-10-12 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org All TCG hosts now support guest-base functionality, so we can remove the setting of host_guest_base to 'yes' in every arm of the case $cpu statement, and simply set guest_base to default to 'yes'. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH 07/11] linux-user: If loading fails, print error as string, not number

2012-10-12 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org If the attempt to load the guest executable fails, print the error message as a string, not a number. This requires us to fix a couple of places in loader_exec() where we were returning -1 instead of a valid negative errno. The change allows us to

[Qemu-devel] [PATCH 00/11] Pending Linux-user patches

2012-10-12 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade: ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000) are available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git

Re: [Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-10-12 Thread Anthony Liguori
Jan Kiszka jan.kis...@siemens.com writes: On 2012-10-08 20:52, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-11 17:53, Jan Kiszka wrote: Our one and only BIOS depends on a writable shadowed BIOS in the ISA range. As we have no interface to control the write

[Qemu-devel] [PATCH] linux-user: Merge pread/pwrite into pread64/pwrite64

2012-10-12 Thread Peter Maydell
The Linux syscalls underlying pread() and pwrite() take a 64 bit offset on all architectures, even if some of them name the syscall pread/pwrite rather than pread64/pwrite64 for historical reasons. So move the four QEMU target architectures (arm, i386, sparc, unicore32) which were defining

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: $ qemu-img info --backing-chain snap2.qcow2 image: snap2.qcow2 file format: qcow2

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: +do { +bs = bdrv_new_open(filename, fmt, BDRV_O_FLAGS | BDRV_O_NO_BACKING, +

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Kevin Wolf
Am 12.10.2012 16:24, schrieb Eric Blake: On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: +do { +bs = bdrv_new_open(filename,

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:27 AM, Kevin Wolf wrote: Am 12.10.2012 16:24, schrieb Eric Blake: On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: +do

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Kevin Wolf
Am 12.10.2012 16:32, schrieb Eric Blake: On 10/12/2012 08:27 AM, Kevin Wolf wrote: Am 12.10.2012 16:24, schrieb Eric Blake: On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 -

Re: [Qemu-devel] [PATCH 4/6] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr

2012-10-12 Thread Richard Henderson
On 10/12/2012 04:10 AM, Riku Voipio wrote: Since changing __get_user/__put_user impacts more than just sigaction, do you mind if we put this patch (and thus sigaction change as well) to a later pull request? Certainly. r~

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:38 AM, Kevin Wolf wrote: Hmm. For 'qemu-img info', I can see two behaviors, both useful, when presented with a corrupt image. One is to error out right away (because qemu would be unable to use the image). But the other is for debugging WHY the image is corrupt, at which

[Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Stefan Hajnoczi
The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: $ qemu-img info --backing-chain snap2.qcow2 image: snap2.qcow2 file format: qcow2 virtual size: 100M (104857600 bytes) disk size: 196K

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Jason Baron
On Thu, Oct 11, 2012 at 10:40:04PM +0200, Michael S. Tsirkin wrote: Windows and Linux guests seem fine with either layout. Slots 1-2 are specific to my setup. So this is a pretty minimal set. I guess we can remove the PCI bridge too? maybe. Perhaps, we can have a very basic set of

Re: [Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset

2012-10-12 Thread Andreas Färber
Am 12.06.2012 15:44, schrieb Kevin Wolf: Am 12.06.2012 15:33, schrieb Andreas Färber: Am 14.05.2012 14:20, schrieb Kevin Wolf: Am 13.05.2012 10:03, schrieb Zhouyi Zhou: hi all sometimes, qemu/kvm-0.1x will hang in endless loop in qcow2_alloc_cluster_offset. after some

Re: [Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-10-12 Thread Jan Kiszka
On 2012-10-12 15:41, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-10-08 20:52, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-11 17:53, Jan Kiszka wrote: Our one and only BIOS depends on a writable shadowed BIOS in the ISA range. As

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-12 Thread Jason Baron
On Fri, Oct 12, 2012 at 12:06:44PM +0200, Gerd Hoffmann wrote: Hi, I just tried out getting rid of the bridges by default. That clearly raises the question which devices should be created automatically by -M q35. I think the devices which are part of the ich9 chipset should be

Re: [Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-10-12 Thread Anthony Liguori
Jan Kiszka jan.kis...@siemens.com writes: On 2012-10-12 15:41, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-10-08 20:52, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-11 17:53, Jan Kiszka wrote: Our one and only BIOS depends on a

Re: [Qemu-devel] [PULL 0/3] usb patch queue

2012-10-12 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, Pretty small this time with just a few bugfixes. please pull, Gerd Pulled. Thanks. Regards, Anthony Liguori The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade: ssi: Add slave autoconnect helper (2012-10-10

Re: [Qemu-devel] [PULL] vfio-pci tree 20121008

2012-10-12 Thread Anthony Liguori
Alex Williamson alex.william...@redhat.com writes: Anthony, The following changes since commit 4bb26682f70a5f626cad3e0ac82bf4b6252ea7a4: Merge branch 'master' of git.qemu.org:/pub/git/qemu (2012-10-07 18:42:18 +) are available in the git repository at:

Re: [Qemu-devel] [PULL 0/4] Net patches

2012-10-12 Thread Anthony Liguori
Stefan Hajnoczi stefa...@redhat.com writes: The following changes since commit 4bb26682f70a5f626cad3e0ac82bf4b6252ea7a4: Merge branch 'master' of git.qemu.org:/pub/git/qemu (2012-10-07 18:42:18 +) are available in the git repository at: git://github.com/stefanha/qemu.git net

Re: [Qemu-devel] [PULL 0/8] spice patch queue

2012-10-12 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, Here comes the spice patch queue. It raises the minimal required spice-server version to 0.12 and the qxl device revision to 4. It also brings a collection of bugfixes. please pull, Gerd Pulled. Thanks. Regards, Anthony Liguori The

[Qemu-devel] [PATCH] qemu-timer: Check for usable fields for SIGEV_THREAD_ID

2012-10-12 Thread Richard Henderson
Older glibc (RHEL 5.x, Debian 5.x) does not have the _sigev_un._tid member in its structure definition, while the accompanying kernel headers do define SIGEV_THREAD_ID. We need configure to check for both before using it. Cc: Paolo Bonzini pbonz...@redhat.com Cc: Anthony Liguori

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 14:39, Gerd Hoffmann ha scritto: +chr = qemu_chr_new_from_opts(opts, NULL); +if (chr == NULL) { +qemu_opts_del(opts); +error_setg(err, Creating chardev failed\n); +goto exit_err; +} +return 0; + Since you have to do a v3, please make

Re: [Qemu-devel] [PATCH] qemu-timer: Check for usable fields for SIGEV_THREAD_ID

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 18:26, Richard Henderson ha scritto: Older glibc (RHEL 5.x, Debian 5.x) does not have the _sigev_un._tid member in its structure definition, while the accompanying kernel headers do define SIGEV_THREAD_ID. We need configure to check for both before using it. Cc: Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Fix division by zero for zero size images

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 14:31, Kevin Wolf ha scritto: Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index f17f187..849eb41 100644 --- a/qemu-img.c +++ b/qemu-img.c

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test qemu-img operation on zero size image

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 14:31, Kevin Wolf ha scritto: Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/041 | 78 tests/qemu-iotests/041.out | 15 tests/qemu-iotests/group |1 + 3 files changed, 94 insertions(+), 0

Re: [Qemu-devel] [PATCH 0/2] tcg/arm: Implement movcond_i32

2012-10-12 Thread Peter Maydell
On 26 September 2012 19:48, Peter Maydell peter.mayd...@linaro.org wrote: These patches implement movcond_i32 for the ARM TCG backend; we emit mov dst, v2; cmp c1, c2; movcc dst, v1. We could have done this with a pair of conditional movs, but (a) this is not actually any shorter (b) it means

  1   2   >