Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-14 Thread Kashyap Chamarthy
On Sun, Oct 14, 2012 at 3:06 AM, Eric Blake ebl...@redhat.com wrote: On 10/13/2012 09:50 AM, Kashyap Chamarthy wrote: [PS: I haven't used 'git-send-email' for this trivial patch. Should I have used that, instead of attaching it? I was wondering if attachments like these are frowned upon. ]

[Qemu-devel] [PATCH]Re: qemu-img: document 'info --backing-chain

2012-10-14 Thread Kashyap Chamarthy
Sorry, forgot to add [PATCH] in the subject. /kashyap On Sun, Oct 14, 2012 at 11:00 AM, Kashyap Chamarthy kashyap...@gmail.com wrote: From a6233277e17338f571dda27cd9192d764f824b18 Mon Sep 17 00:00:00 2001 From: Kashyap Chamarthy kashyap...@gmail.com Date: Sun, 14 Oct 2012 09:51:18 +0530

Re: [Qemu-devel] defferences between /usr/libexec/qemu-kvm and /usr/bin/qemu-system-x86_64

2012-10-14 Thread Michael Tokarev
On 14.10.2012 09:01, yue-kvm wrote: what is the defferences between /usr/libexec/qemu-kvm and /usr/bin/qemu-system-x86_64? my OS is centos6.2, qemu-kvm is from a rpm package, while qemu-system-x86_64 is builded manually from source code. 1. if i can recognize they are the same thing?

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-14 Thread Andriy Gapon
on 11/10/2012 00:09 malc said the following: On Thu, 11 Oct 2012, Andriy Gapon wrote: on 08/10/2012 12:02 Andriy Gapon said the following: on 08/10/2012 10:52 malc said the following: On Mon, 8 Oct 2012, Andriy Gapon wrote: I am running Qemu (plain, no kvm, etc) on an AMD 10h machine that

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-14 Thread malc
On Sun, 14 Oct 2012, Andriy Gapon wrote: [..snip..] Hmm... Since you are the author of the patch, wouldn't be more appropriate for you to submit it? Besides, I can only mostly repeat the bug report as I do not quite understand the code and can not properly describe what the patch does.

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-14 Thread Andriy Gapon
on 14/10/2012 13:56 malc said the following: On Sun, 14 Oct 2012, Andriy Gapon wrote: [..snip..] Hmm... Since you are the author of the patch, wouldn't be more appropriate for you to submit it? Besides, I can only mostly repeat the bug report as I do not quite understand the code and

[Qemu-devel] [PATCH V3 07/10] add def_value and use it in qemu_opts_print.

2012-10-14 Thread Dong Xu Wang
qemu_opts_print has no user now, so I re-write it and use it in qemu-img.c. qemu_opts_print will be used while using qemu-img create, it will produce the same output as previous code. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 41

[Qemu-devel] [PATCH V3 06/10] create new function: qemu_opt_set_number

2012-10-14 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 24 qemu-option.h |1 + 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index d7d5ea9..eeb2c9c 100644 --- a/qemu-option.c +++ b/qemu-option.c @@

[Qemu-devel] [PATCH V3 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-10-14 Thread Dong Xu Wang
It will set opt-str in qemu_opt_set_bool, without opt-str, there will be some potential bugs. These are uses of opt-str, and what happens when it isn't set: * qemu_opt_get(): returns NULL, which means not set. Bug can bite when value isn't the default value. * qemu_opt_parse(): passes NULL

[Qemu-devel] [PATCH V3 10/10] remove QEMUOptionParameter related functions and struct

2012-10-14 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 285 - qemu-option.h | 32 --- 2 files changed, 0 insertions(+), 317 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index c391f7d..cc34a68 100644 ---

[Qemu-devel] [PATCH V3 00/10] replace QEMUOptionParameter with QemuOpts parser

2012-10-14 Thread Dong Xu Wang
Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Patch 2 and 3 are changed according Paolo's comments. Patch 4-5: because qemu_opts_create can not fail while id is null, so create function

[Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-14 Thread Tim Hardeck
When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list QEMU segfaults. Check for this case specifically on item removal. Signed-off-by: Tim Hardeck thard...@suse.de --- qemu-queue.h |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-queue.h

[Qemu-devel] [PATCH 0/2] fix segfaults triggered by failed vnc handshakes

2012-10-14 Thread Tim Hardeck
While trying to adapt Anthony Liguori's websockets patches to the current standard I ran into some segfaults. They were triggered during disconnects due to failed VNC handshakes. I have added checks to prevent them. Tim Hardeck (2): vnc: fix segfault due to failed handshake qemu queue: fix

[Qemu-devel] [PATCH 1/2] vnc: fix segfault due to failed handshake

2012-10-14 Thread Tim Hardeck
When the VNC server disconnects due to a failed handshake we don't have vs-bh allocated yet. Check for this case and don't delete it. Signed-off-by: Tim Hardeck thard...@suse.de --- ui/vnc.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index

[Qemu-devel] [PATCH 5/7] hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR

2012-10-14 Thread Peter Maydell
Use the new LOG_UNIMP and LOG_GUEST_ERROR logging types rather than hw_error(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pl011.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pl011.c b/hw/pl011.c index 3245702..743eea6 100644 ---

[Qemu-devel] [PATCH 6/7] hw/pl022: Use LOG_UNIMP and LOG_GUEST_ERROR

2012-10-14 Thread Peter Maydell
Use LOG_UNIMP and LOG_GUEST_ERROR where appropriate rather than hw_error(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pl022.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/pl022.c b/hw/pl022.c index 60e35da..91e5df0 100644 --- a/hw/pl022.c +++

[Qemu-devel] [PATCH 4/7] hw/pl190: Use LOG_GUEST_ERROR

2012-10-14 Thread Peter Maydell
If the guest attempts an offset to a nonexistent register, just log this via LOG_GUEST_ERROR rather than killing QEMU with a hw_error. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pl190.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pl190.c

[Qemu-devel] [PATCH 2/7] hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR

2012-10-14 Thread Peter Maydell
Rather than a mix of direct printing to stderr and aborting via hw_error(), use LOG_UNIMP and LOG_GUEST_ERROR. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pl181.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/pl181.c b/hw/pl181.c

[Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs

2012-10-14 Thread Peter Maydell
This patch series introduces a new logging category to qemu_log_mask(), for reporting situations which the device model can cope with but which indicate bugs in the guest. The most common cause of these is guest tried to access a register which doesn't exist. At the moment device models use an

[Qemu-devel] [PATCH 3/7] hw/pl041: Use LOG_UNIMP

2012-10-14 Thread Peter Maydell
Use the new LOG_UNIMP tracing to report unimplemented features. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pl041.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/pl041.c b/hw/pl041.c index b6723be..260c560 100644 --- a/hw/pl041.c +++ b/hw/pl041.c

[Qemu-devel] [PATCH 7/7] hw/pl031: Use LOG_GUEST_ERROR

2012-10-14 Thread Peter Maydell
Use LOG_GUEST_ERROR rather than hw_error or direct fprintf. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pl031.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/pl031.c b/hw/pl031.c index 9602664..a718d2e 100644 --- a/hw/pl031.c +++

[Qemu-devel] [PATCH V3 08/10] Create four opts list related functions

2012-10-14 Thread Dong Xu Wang
This patch will create 4 functions, count_opts_list, append_opts_list, free_opts_list and print_opts_list, they will used in following commits. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 87 + qemu-option.h

[Qemu-devel] [PATCH V3 02/10] qemu-option: qemu_opts_validate(): fix duplicated code

2012-10-14 Thread Dong Xu Wang
Use opts_accepts_any() and find_desc_by_name(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 14 +++--- 1 files changed, 3 insertions(+), 11 deletions(-) diff --git a/qemu-option.c b/qemu-option.c

[Qemu-devel] [PATCH V3 04/10] introduce qemu_opts_create_nofail function

2012-10-14 Thread Dong Xu Wang
While id is NULL, qemu_opts_create can not fail, so ignore errors is fine. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c |5 + qemu-option.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index

[Qemu-devel] [PATCH V3 05/10] use qemu_opts_create_nofail

2012-10-14 Thread Dong Xu Wang
We will use qemu_opts_create_nofail function, it can make code more readable. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- blockdev.c |2 +- qemu-config.c |4 ++-- qemu-img.c |2 +- qemu-sockets.c | 10 +- vl.c | 12 +--- 5 files

[Qemu-devel] [PATCH V3 01/10] qemu-option: opt_set(): split it up into more functions

2012-10-14 Thread Dong Xu Wang
The new functions are opts_accepts_any() and find_desc_by_name(), which are also going to be used by qemu_opts_validate() (see next commit). This also makes opt_set() slightly more readable. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Dong Xu Wang

[Qemu-devel] [PATCH 1/7] qemu-log: Add new log category for guest bugs

2012-10-14 Thread Peter Maydell
Add a new category for device models to log guest behaviour which is likely to be a guest bug of some kind (accessing nonexistent registers, reading 32 bit wide registers with a byte access, etc). Making this its own log category allows those who care (mostly guest OS authors) to see the

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-14 Thread Michal Suchanek
So this is a compiler or system header error? Anybody examined the differences in code generated with native compiler and crosscompiler? Is there some code difference or are wrong kernel headers pulled from i386 resulting in invalid syscalls? -- You received this bug notification because you

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-14 Thread Peter Maydell
Michal Suchanek wrote: So this is a compiler or system header error? Anybody examined the differences in code generated with native compiler and crosscompiler? ...this comment doesn't make much sense to me -- did you add it to the wrong bug report by mistake? i386 user mode's issues are not

Re: [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 1:11 PM, Peter Maydell peter.mayd...@linaro.org wrote: This patch series introduces a new logging category to qemu_log_mask(), for reporting situations which the device model can cope with but which indicate bugs in the guest. The most common cause of these is guest

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-14 Thread Michal Suchanek
It might be just coincidence but if you read the above comments you will notice that people who compiled qemu natively on arm report that they can run various binaries without issue but people who crosscompiled report that they can't run the simplest i386 shell utilities. How come that the

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-14 Thread Justin Shafer
I do now know... I compile on my phone and tablet. In fact I loaded Ubuntu on my Touchpad last night, native. http://code.google.com/p/hp-touchpad-ubuntu/wiki/Installation No more chroot to deal with. -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-14 Thread Peter Maydell
How come that the functionality that is missing magically appears for some people? Coincidence. Nobody on this bug report has reported that they've been able to run x86 binary X with a native compiled qemu but not with a cross compiled version of the same qemu sources. I think it is vastly more

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-14 Thread Justin Shafer
I am now able to run winecfg... you have to have wine-pthread run winecfg qemu-i386 /usr/bin/qemu-i386 wine-pthread winecfg All the tabs load except audio.. For that it hangs.. Trying to fix that.. I want to run an app that hangs and it uses audio. -- You received this bug notification because

Re: [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs

2012-10-14 Thread Peter Maydell
On 14 October 2012 15:02, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 1:11 PM, Peter Maydell peter.mayd...@linaro.org wrote: One question that comes to mind -- should we include qemu-log.h in qemu-common.h (or some other common header?) rather than having to include

Re: [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 3:41 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 14 October 2012 15:02, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 1:11 PM, Peter Maydell peter.mayd...@linaro.org wrote: One question that comes to mind -- should we include qemu-log.h in

[Qemu-devel] [PATCH v2] hw/armv7m_nvic: Implement byte/halfword access for NVIC SCB_SHPRx registers

2012-10-14 Thread Andre Beckus
Implement byte/halfword read and write for the NVIC SCB_SHPRx (System Handler Priority Registers). Do this by removing SHPR word access from nvic_readl/writel and adding common code to hande all access sizes in nvic_sysreg_read/write. Because the nvic_state *s variable now needs to be declared

[Qemu-devel] [PATCH] arm-semi.c: Handle get/put_user() failure accessing arguments

2012-10-14 Thread Peter Maydell
Rework the handling of arguments to ARM semihosting calls so that we handle a possible failure return from get_user_ual() or put_user_ual(). (This incidentally silences a lot of warnings from clang about expression result unused). Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 00/11] static patches

2012-10-14 Thread Blue Swirl
I made a small tool to detect unused functions and variables. Here's some fixes. Blue Swirl (11): target-sparc: make do_unaligned_access static vl.c: add missing static vnc: add missing static and remove unused functions tap-win32: avoid a warning m48t59: remove unused m48t59_set_addr

[Qemu-devel] [PATCH 01/11] target-sparc: make do_unaligned_access static

2012-10-14 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-sparc/cpu.h |3 --- target-sparc/ldst_helper.c |8 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 214d01d..b4eda18 100644 --- a/target-sparc/cpu.h +++

[Qemu-devel] [PATCH 02/11] vl.c: add missing static

2012-10-14 Thread Blue Swirl
Add missing 'static' qualifiers and remove unused pcmcia_socket_unregister(). Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/pcmcia.h |1 - sysemu.h|5 - vl.c| 33 - 3 files changed, 12 insertions(+), 27 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 00/11] static patches

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 7:58 PM, Blue Swirl blauwir...@gmail.com wrote: I made a small tool to detect unused functions and variables. Here's some fixes. Just run the attached tool in an object directory and after some time, it will produce a list of suspect symbols: AES_decrypt ( ./aes.o)

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Peter Maydell
On 14 October 2012 20:58, Blue Swirl blauwir...@gmail.com wrote: index 2fc4137..2c02a83 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -871,24 +871,3 @@ void omap_gpmc_attach(struct omap_gpmc_s *s, int cs, MemoryRegion *iomem) f-iomem = iomem; omap_gpmc_cs_map(s, cs); } -

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: Disable clang's initializer-overrides warnings, as QEMU makes significant use of the pattern of initializing an array with a range-based default entry like [0 ... 0x1ff] = { GPIO_NONE, 0 } followed by specific

[Qemu-devel] [PATCH 03/11] vnc: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
Add missing 'static' qualifiers. Remove unused functions vnc_stop_worker_thread(), vnc_has_job() and vnc_jobs_clear(). Signed-off-by: Blue Swirl blauwir...@gmail.com --- console.h |2 -- ui/vnc-jobs.c | 46 +- ui/vnc-jobs.h |4

[Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-14 Thread Peter Maydell
Disable clang's initializer-overrides warnings, as QEMU makes significant use of the pattern of initializing an array with a range-based default entry like [0 ... 0x1ff] = { GPIO_NONE, 0 } followed by specific entries which override that default, and clang would otherwise warn initializer

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-14 Thread Peter Maydell
On 14 October 2012 21:15, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: Blue Swirl previously submitted a patch which enabled this flag (among others): http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04203.html

[Qemu-devel] [PATCH 09/11] target-ppc: make some functions static

2012-10-14 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-ppc/cpu.h|6 -- target-ppc/mmu_helper.c | 11 ++- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index d3ada54..ab88b33 100644 --- a/target-ppc/cpu.h +++

[Qemu-devel] [PATCH 11/11] exec: make some functions static

2012-10-14 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- cpu-common.h|5 - exec-all.h |2 -- exec-obsolete.h |4 exec.c | 19 +++ 4 files changed, 11 insertions(+), 19 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index c0d27af..f51ba67

[Qemu-devel] [PATCH 08/11] ppc: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
Add missing 'static' qualifiers and remove unused functions. This removes 405cr model entirely but it was not accessible before. Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/adb.c |8 +- hw/adb.h |4 - hw/mac_nvram.c | 24 hw/nvram.h | 11 --

[Qemu-devel] [PATCH 04/11] tap-win32: avoid a warning

2012-10-14 Thread Blue Swirl
Avoid a warning about missing declaration. Signed-off-by: Blue Swirl blauwir...@gmail.com --- net/tap-win32.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index f1801e2..7964b45 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@

[Qemu-devel] [PATCH 06/11] sun4c: remove unused functions

2012-10-14 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/sun4c_intctl.c | 23 --- hw/sun4m.h|4 2 files changed, 0 insertions(+), 27 deletions(-) diff --git a/hw/sun4c_intctl.c b/hw/sun4c_intctl.c index 8dfa5ec..09ef937 100644 --- a/hw/sun4c_intctl.c +++

Re: [Qemu-devel] [PATCH 00/11] static patches

2012-10-14 Thread malc
On Sun, 14 Oct 2012, Blue Swirl wrote: On Sun, Oct 14, 2012 at 7:58 PM, Blue Swirl blauwir...@gmail.com wrote: I made a small tool to detect unused functions and variables. Here's some fixes. Just run the attached tool in an object directory and after some time, it will produce a list of

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 14 October 2012 20:58, Blue Swirl blauwir...@gmail.com wrote: index 2fc4137..2c02a83 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -871,24 +871,3 @@ void omap_gpmc_attach(struct omap_gpmc_s *s, int cs,

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Peter Maydell
On 14 October 2012 21:33, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell peter.mayd...@linaro.org wrote: Please don't delete this function, it is the public facing interface for allowing board models to attach NAND devices to the GPMC. This might not be

[Qemu-devel] [PATCH 07/11] slirp: remove unused function u_sleep

2012-10-14 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- slirp/misc.c | 14 -- slirp/misc.h |1 - 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index 0bee864..664532a 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -253,20 +253,6 @@ void

[Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
Add missing 'static' qualifiers and remove unused functions. Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/devices.h |3 -- hw/i2c.h |3 -- hw/omap.h |1 - hw/omap_gpmc.c| 21

[Qemu-devel] [PATCH 05/11] m48t59: remove unused m48t59_set_addr

2012-10-14 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/m48t59.c |7 --- hw/nvram.h |1 - 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/hw/m48t59.c b/hw/m48t59.c index dd6cb37..867bbda 100644 --- a/hw/m48t59.c +++ b/hw/m48t59.c @@ -466,13 +466,6 @@ uint32_t m48t59_read

Re: [Qemu-devel] [PATCH 00/11] static patches

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:32 PM, malc av1...@comtv.ru wrote: On Sun, 14 Oct 2012, Blue Swirl wrote: On Sun, Oct 14, 2012 at 7:58 PM, Blue Swirl blauwir...@gmail.com wrote: I made a small tool to detect unused functions and variables. Here's some fixes. Just run the attached tool in an

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 14 October 2012 21:33, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell peter.mayd...@linaro.org wrote: Please don't delete this function, it is the public facing interface

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Peter Maydell
On 14 October 2012 21:49, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 14 October 2012 21:33, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell peter.mayd...@linaro.org wrote: In

[Qemu-devel] Any alternative to kqemu ?

2012-10-14 Thread Timothy Madden
Hello Is kqemu deprecated ? Is there an alternative to it ? I mean other than kvm, which my CPU (Pentium Celeron D, 2.53 GHz) does not support. Can I compile qemu with -O3 -march=pentium if I want to get better performance ? Has anyone tried it ? `qemu-system-i386 -net nic ...` keeps

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Andreas Färber
Am 14.10.2012 22:33, schrieb Blue Swirl: On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell peter.mayd...@linaro.org wrote: Please don't delete this function, it is the public facing interface for allowing board models to attach NAND devices to the GPMC. This might not be used by anything

Re: [Qemu-devel] [PATCH 05/11] m48t59: remove unused m48t59_set_addr

2012-10-14 Thread Andreas Färber
Am 14.10.2012 21:58, schrieb Blue Swirl: Signed-off-by: Blue Swirl blauwir...@gmail.com Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

[Qemu-devel] [PATCH 02/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-10-14 Thread David Gibson
Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models to represent a TLB entry contains a target_phys_addr_t. That works reasonably for now, but is troublesome for saving the state, which we'll want to do in future. target_phys_addr_t is a large enough type to contain a

[Qemu-devel] [PATCH 08/15] savevm: Implement VMS_DIVIDE flag

2012-10-14 Thread David Gibson
The vmstate infrastructure includes a VMS_MULTIPY flag, and associated VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to save a variably sized buffer where the size in bytes of the buffer isn't directly accessible as a structure field, but an element count from which the size can be

[Qemu-devel] [PATCH 01/15] pseries: Split xics irq configuration from state information

2012-10-14 Thread David Gibson
Currently the XICS irq controller code has a per-irq state structure which amongst other things includes whether the interrupt is level or message triggered - this is configured by the platform code, and is not directly visible to the guest. This leads to a slightly awkward construct at reset

[Qemu-devel] [PATCH 15/15] pseries: savevm support for pseries machine

2012-10-14 Thread David Gibson
This adds the necessary pieces to implement savevm / migration for the pseries machine. The most complex part here is migrating the hash table - for the paravirtualized pseries machine the guest's hash page table is not stored within guest memory, but externally and the guest accesses it via

[Qemu-devel] [PATCH 09/15] target-ppc: Convert ppc cpu savevm to VMStateDescription

2012-10-14 Thread David Gibson
The savevm code for the powerpc cpu emulation is currently based around the old register_savevm() rather than register_vmstate() method. It's also rather broken, missing some important state on some CPU models. This patch completely rewrites the savevm for target-ppc, using the new

[Qemu-devel] [PATCH 07/15] savevm: Fix bugs in the VMSTATE_VBUFFER_MULTIPLY definition

2012-10-14 Thread David Gibson
The VMSTATE_BUFFER_MULTIPLY macro is misnamed - it actually specifies a variably sized buffer with VMS_VBUFFER, so should be named VMSTATE_VBUFFER_MULTIPLY. This patch fixes this (the macro had no current users under either name). In addition, unlike the other VMSTATE_VBUFFER variants, this

[Qemu-devel] [PATCH 14/15] pseries: savevm support for PAPR virtual SCSI

2012-10-14 Thread David Gibson
This patch adds the necessary support for saving the state of the PAPR VIO virtual SCSI device. This turns out to be trivial, because the generiC SCSI code already quiesces the attached virtual SCSI bus. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/spapr_vscsi.c | 28

[Qemu-devel] [PATCH 04/15] savevm: Add VMSTATE_UINTTL_EQUAL helper

2012-10-14 Thread David Gibson
This adds an _EQUAL VMSTATE helper for target_ulongs, defined in terms of VMSTATE_UINT32_EQUAL or VMSTATE_UINT64_EQUAL as appropriate. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/hw.h |6 ++ vmstate.h |7 +-- 2 files changed, 11 insertions(+), 2 deletions(-)

[Qemu-devel] RFC: savevm/migration support for pseries

2012-10-14 Thread David Gibson
Hi Alex, Juan, This large patch series contains the full set of patches to add working migration support for the pseries machine. This includes converting target-ppc to new-style VMStateDescription, at the same time reworking it thoroughly to correct many bugs. As far as I know, no target-ppc

[Qemu-devel] [PATCH 13/15] pseries: savevm support for PAPR TCE tables

2012-10-14 Thread David Gibson
This patch adds the necessary VMStateDescription information to save the state of PAPR TCE tables (that is, the PAPR specified IOMMU). Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/spapr_iommu.c | 24 1 file changed, 24 insertions(+) diff --git

[Qemu-devel] [PATCH 10/15] pseries: savevm support for XICS interrupt controller

2012-10-14 Thread David Gibson
This patch adds the necessary VMStateDescription information to allow savevm/loadvm for the XICS interrupt controller. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/xics.c | 57 + 1 file changed, 53 insertions(+), 4

[Qemu-devel] [PATCH 05/15] savevm: Add VMSTATE_FLOAT64 helpers

2012-10-14 Thread David Gibson
The current savevm code includes VMSTATE helpers for a number of commonly used data types, but not for the float64 type used by the internal floating point emulation code. This patch fixes the deficiency. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- savevm.c | 23

[Qemu-devel] [PATCH 06/15] savevm: Add VMSTATE_STRUCT_VARRAY_POINTER_UINT32

2012-10-14 Thread David Gibson
Currently the savevm code contains a VMSTATE_STRUCT_VARRAY_POINTER_INT32 helper (a variably sized array with the number of elements in an int32_t), but not VMSTATE_STRUCT_VARRAY_POINTER_UINT32 (... with the number of elements in a uint32_t). This patch (trivially) fixes the deficiency.

[Qemu-devel] [PATCH 12/15] pseries: savevm support for PAPR VIO logical lan

2012-10-14 Thread David Gibson
This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_llan (PAPR logical lan) device. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/spapr_llan.c | 24 ++-- hw/spapr_vty.c | 16 2 files

[Qemu-devel] [PATCH 03/15] savevm: Add VMSTATE_UINT64_EQUAL helpers

2012-10-14 Thread David Gibson
The savevm code already includes a number of *_EQUAL helpers which act as sanity checks verifying that the configuration of the saved state matches that of the machine we're loading into to work. Variants already exist for 8 bit 16 bit and 32 bit integers, but not 64 bit integers. This patch

[Qemu-devel] [PATCH 11/15] pseries: savevm support for VIO devices

2012-10-14 Thread David Gibson
This patch adds helpers to allow PAPR VIO devices to save state common to all VIO devices during savevm. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/spapr_vio.c | 20 hw/spapr_vio.h |5 + 2 files changed, 25 insertions(+) diff --git

Re: [Qemu-devel] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-14 Thread Laine Stump
On 10/13/2012 04:47 PM, Laine Stump wrote: I am attempting to enhance libvirt's virDomainUpdateDeviceFlags() API to support changing just about anything about the host side of a PCI network device without actually detaching the PCI device from the guest. Here is a patch I sent to the libvirt

Re: [Qemu-devel] [PATCH V7 0/4] libqblock qemu block layer library

2012-10-14 Thread wenchao xia
于 2012-10-13 18:49, Blue Swirl 写道: On Sat, Oct 13, 2012 at 5:10 AM, Wenchao Xia xiaxia34...@163.com wrote: From: Wenchao Xia xiaw...@linux.vnet.ibm.com These patches introduce libqblock API, make libqblock.la and make check-libqblock could build this library. Functionalities: 1 create

[Qemu-devel] [PATCH V8 0/4] libqblock qemu block layer library

2012-10-14 Thread Wenchao Xia
These patches introduce libqblock API, make libqblock.la and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported

[Qemu-devel] [PATCH V8 1/4] libqblock build system

2012-10-14 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock.

[Qemu-devel] [PATCH V8 4/4] libqblock test example

2012-10-14 Thread Wenchao Xia
In this example, first it will create some qcow2 images, then try get information including backing file relationship, then it will do sync IO on the image. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/libqblock/libqblock-qcow2.c | 390 -

[Qemu-devel] [PATCH V8 2/4] libqblock type defines

2012-10-14 Thread Wenchao Xia
This patch contains type and macro defines used in APIs, one file for public usage, one for libqblock internal usage. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-internal.h | 75 libqblock/libqblock-types.h| 252

[Qemu-devel] [PATCH V8 3/4] libqblock API

2012-10-14 Thread Wenchao Xia
This patch contains the major APIs in the library. For ABI some reserved members were used. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockState. It stands for an block image object. 3 QBlockStaticInfo. It contains

[Qemu-devel] [PATCH] configure: Remove unused parameters from main function

2012-10-14 Thread Stefan Weil
This modification is required if compiler option -Wunused-parameter is activated. Signed-off-by: Stefan Weil s...@weilnetz.de --- configure |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 353d788..499ad81 100755 --- a/configure +++