Re: [Qemu-devel] vmdk: improve streamOptimized vmdk support

2015-04-21 Thread Fam Zheng
On Fri, 04/17 18:25, devsk wrote: Fam: Any updates on this? Hi, I'm still working on the patchset. Will send to the list once it's done. Fam Thanks On Tuesday, March 3, 2015 12:54 AM, Fam Zheng f...@redhat.com wrote: On Tue, 03/03 09:36, Milos Vyletel wrote: On Sun, Mar

Re: [Qemu-devel] [PATCH 06/18] virtio: Return error from virtqueue_pop

2015-04-21 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:21PM +0800, Fam Zheng wrote: When getting invalid data from vring, virtqueue_pop used to print an error and exit. Add an errp parameter so it can return the error to callers. Signed-off-by: Fam Zheng f...@redhat.com --- hw/9pfs/virtio-9p.c | 2 +-

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Paolo Bonzini
On 20/04/2015 22:34, Michael S. Tsirkin wrote: On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: On 20/04/2015 19:36, Michael S. Tsirkin wrote: At the implementation level, there's one big issue you seem to have missed: DMA to invalid memory addresses causes a crash in memory

Re: [Qemu-devel] [PATCH 04/18] virtio: Return error from virtqueue_next_desc

2015-04-21 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:19PM +0800, Fam Zheng wrote: Two callers pass error_abort now, which can be changed to check return value and pass the error on. Signed-off-by: Fam Zheng f...@redhat.com --- hw/virtio/virtio.c | 27 ++- 1 file changed, 18

Re: [Qemu-devel] [PATCH 06/18] virtio: Return error from virtqueue_pop

2015-04-21 Thread Fam Zheng
On Tue, 04/21 08:49, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:21PM +0800, Fam Zheng wrote: When getting invalid data from vring, virtqueue_pop used to print an error and exit. Add an errp parameter so it can return the error to callers. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-21 Thread Thomas Huth
Am Tue, 21 Apr 2015 10:24:48 +1000 schrieb David Gibson da...@gibson.dropbear.id.au: On Mon, Apr 20, 2015 at 05:34:56PM +0200, Thomas Huth wrote: The check liobn 0xULL in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter.

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 01:50:33PM +0800, Fam Zheng wrote: On Tue, 04/21 07:22, Michael S. Tsirkin wrote: On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: On Mon, 04/20 19:36, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: Currently,

Re: [Qemu-devel] [PATCH 03/18] virtio: Return error from virtqueue_get_head

2015-04-21 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:18PM +0800, Fam Zheng wrote: Return type is changed to int. When data is invalid, return -EINVAL with an error. Signed-off-by: Fam Zheng f...@redhat.com Problem is, callers can't really handle -EINVAL here, so it's adding dead code if we just apply patches

[Qemu-devel] [Bug 1440843] Re: Guest WinXP crashes when trying to use a USB spectrometer

2015-04-21 Thread Erik Rull
Which version is used? Try the latest QEMU or at least QEMU 2.0. The behavior sounds like a pretty old QEMU version. Additionally, enable the EHCI controller (see example in the docs subdirectory). It it working on a native Windows XP? -- You received this bug notification because you are a

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config arg sub-argument

2015-04-21 Thread Liviu Ionescu
On 21 Apr 2015, at 16:34, Leon Alrae leon.al...@imgtec.com wrote: I'll resend the patch with dropped RFC as I would really like to go forward and finally close this issue. perhaps you should first take a closer look at the patch I submitted, since it covers not only parsing the arguments,

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config arg sub-argument

2015-04-21 Thread Eric Blake
On 04/21/2015 10:54 AM, Peter Maydell wrote: On 21 April 2015 at 17:48, Eric Blake ebl...@redhat.com wrote: On 04/21/2015 09:55 AM, Peter Maydell wrote: If you want pure POSIX shell then it is slightly uglier as we have to invoke sed: argstr= for arg in $@; do o=$(printf '%s.\n' $arg

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config arg sub-argument

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 17:51, Liviu Ionescu i...@livius.net wrote: could you also suggest a solution for a .BAT script when running on windows? I don't do windows, so you're on your own there, I'm afraid, though a little googling suggests windows bat syntax does have sufficient power (eg

Re: [Qemu-devel] [PATCH 3/6] s390/kvm: diag288 instruction interception and handling

2015-04-21 Thread Alexander Graf
On 04/17/2015 09:52 AM, Cornelia Huck wrote: From: Xu Wang gesa...@linux.vnet.ibm.com Intercept the diag288 requests from kvm guests, and hand the requested command to the diag288 watchdog device for further handling. Signed-off-by: Xu Wang gesa...@linux.vnet.ibm.com Reviewed-by: David

Re: [Qemu-devel] [PATCH 09/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-04-21 Thread Christian Borntraeger
Am 21.04.2015 um 21:12 schrieb Alexander Graf: On 04/20/2015 04:55 PM, Christian Borntraeger wrote: Am 09.04.2015 um 10:51 schrieb Cornelia Huck: From: Thomas Huth th...@linux.vnet.ibm.com Add code to make use of the new ioctl for reading from / writing to virtual guest memory. By using the

Re: [Qemu-devel] [PATCH] hda-codec: use smaller dynamic range for input amplifier

2015-04-21 Thread Marc-André Lureau
Hi - Original Message - This patch addresses the following problem: Moving the input volume slider 0% to 1% in a Win7 guest causes the the gain values in the emulated HDA codec HW to jump from 0 to 40. This makes it impossible to control sound volume in the low-gain range using the

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Laszlo Ersek
On 04/21/15 17:04, Gerd Hoffmann wrote: +static const MemoryRegionOps tseg_blackhole_ops = { +.read = tseg_blackhole_read, +.write = tseg_blackhole_write, +.endianness = DEVICE_NATIVE_ENDIAN, +.valid.min_access_size = 1, +.valid.max_access_size = 4, +

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config arg sub-argument

2015-04-21 Thread Liviu Ionescu
On 21 Apr 2015, at 19:54, Peter Maydell peter.mayd...@linaro.org wrote: Incidentally if you have a better idea for achieving the desired goal than this messing around with comma-escaping I would really like to know. I don't like either of the current two proposals very much :-( please

Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable has_dynamic_sysbus

2015-04-21 Thread Alexander Graf
On 04/17/2015 09:52 AM, Cornelia Huck wrote: From: Xu Wang gesa...@linux.vnet.ibm.com We have to enable this flag to support dynamically adding devices to the sysbus. This change is needed for the the upcoming diag288 watchdog. s390 doesn't have a sysbus per se. Please create a new bus type.

Re: [Qemu-devel] [PATCH 2/2] pci: GPEX: Add support to route legacy interrupts

2015-04-21 Thread Alexander Graf
On 04/17/2015 10:55 AM, Pranavkumar Sawargaonkar wrote: This patch adds routine to route legacy interrupts to VM. Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org Signed-off-by: Tushar Jagad tushar.ja...@linaro.org I don't think the device model should have awareness of any

Re: [Qemu-devel] [PATCH 09/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-04-21 Thread Christian Borntraeger
Am 21.04.2015 um 21:36 schrieb Alexander Graf: On 04/21/2015 09:34 PM, Christian Borntraeger wrote: Am 21.04.2015 um 21:12 schrieb Alexander Graf: On 04/20/2015 04:55 PM, Christian Borntraeger wrote: Am 09.04.2015 um 10:51 schrieb Cornelia Huck: From: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH 09/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-04-21 Thread Alexander Graf
On 04/21/2015 09:34 PM, Christian Borntraeger wrote: Am 21.04.2015 um 21:12 schrieb Alexander Graf: On 04/20/2015 04:55 PM, Christian Borntraeger wrote: Am 09.04.2015 um 10:51 schrieb Cornelia Huck: From: Thomas Huth th...@linux.vnet.ibm.com Add code to make use of the new ioctl for reading

[Qemu-devel] [Bug 1440843] Re: Guest WinXP crashes when trying to use a USB spectrometer

2015-04-21 Thread Erik Rull
Please check that the devices get added to the EHCI bus and not to the UHCI. As far as I know the -usb* commands are deprecated. The functions behind the -device usb* and -usb* should behave the same. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH 09/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-04-21 Thread Alexander Graf
On 04/20/2015 04:55 PM, Christian Borntraeger wrote: Am 09.04.2015 um 10:51 schrieb Cornelia Huck: From: Thomas Huth th...@linux.vnet.ibm.com Add code to make use of the new ioctl for reading from / writing to virtual guest memory. By using the ioctl, the memory accesses are now protected with

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Fam Zheng
On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng f...@redhat.com wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such as losing unsaved data (e.g. when guest user is writing a

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Fam Zheng
On Tue, 04/21 11:08, Cornelia Huck wrote: On Tue, 21 Apr 2015 16:38:31 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-21 Thread Shannon Zhao
On 2015/4/21 15:30, Cornelia Huck wrote: On Tue, 21 Apr 2015 09:43:36 +0800 Shannon Zhao shannon.z...@linaro.org wrote: On 2015/4/20 19:32, Cornelia Huck wrote: On Mon, 20 Apr 2015 16:20:00 +0800 shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Move

[Qemu-devel] [PATCH v3 0/2] virtio: Move host features to backends

2015-04-21 Thread shannon . zhao
From: Shannon Zhao shannon.z...@linaro.org The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390, and virtio-*-ccw already have the ability to forward property accesses to the

[Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi

2015-04-21 Thread shannon . zhao
From: Shannon Zhao shannon.z...@linaro.org Move DEFINE_VIRTIO_SCSI_FEATURES to the backend virtio-scsi. The transports just sync the host features from backend. Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org ---

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 08:52:36AM +0200, Paolo Bonzini wrote: On 20/04/2015 22:34, Michael S. Tsirkin wrote: On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: On 20/04/2015 19:36, Michael S. Tsirkin wrote: At the implementation level, there's one big issue you seem to

Re: [Qemu-devel] [PATCH v2 09/14] Switch non-CPU callers from ld/st*_phys to address_space_ld/st*

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Switch all the uses of ld/st*_phys to address_space_ld/st*, except for those cases where the address space is the CPU's (ie cs-as). This was done with the following script which generates a Coccinelle patch. A few over-80-columns lines in the

Re: [Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single step

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: On 31 March 2015 at 16:40, Alex Bennée alex.ben...@linaro.org wrote: This adds support for single-step. There isn't much to do on the QEMU side as after we set-up the request for single step via the debug ioctl it is all handled within the

Re: [Qemu-devel] [RFC/PATCH] Bad volume scaling with Win7 guest, spice audio, and Qemu Intel HDA codec

2015-04-21 Thread Marc-André Lureau
Hi - Original Message - I see a problem with input volume control on a Windows7 guest using the qemu Intel HDA codec. In short, moving the volume slider for the input volume from 0% to 1% under Windows results in the gain values in the emulated HW to jump from 0 to 40 (out of 74)

Re: [Qemu-devel] [PATCH] virtio_blk: comment fix

2015-04-21 Thread Stefan Hajnoczi
On Sun, Apr 12, 2015 at 05:55:17PM +0200, Michael S. Tsirkin wrote: update virtio blk header from latest linux, include comment fixups. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/standard-headers/linux/virtio_blk.h | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [Qemu-devel] [PATCH] m25p80: add missing blk_attach_dev_nofail

2015-04-21 Thread Stefan Hajnoczi
On Tue, Apr 14, 2015 at 05:29:47PM +0200, Paolo Bonzini wrote: Of the block devices that poked into -drive options via drive_get_next, m25p80 was the only one who also did not attach itself to the BlockBackend. Since sd does it, and all other devices go through a drive property, with this

Re: [Qemu-devel] [PATCH for-2.4] m25p80: fix s-blk usage before assignment

2015-04-21 Thread Stefan Hajnoczi
On Wed, Apr 15, 2015 at 10:43:44AM +0100, Stefan Hajnoczi wrote: Delay the call to blk_blockalign() until s-blk has been assigned. This never caused a crash because blk_blockalign(NULL, size) defaults to 4096 alignment but it's technically incorrect. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-04-21 Thread Stefano Stabellini
On Tue, 21 Apr 2015, Fabio Fantoni wrote: Il 21/04/2015 12:49, Stefano Stabellini ha scritto: On Mon, 20 Apr 2015, Fabio Fantoni wrote: I updated xen and qemu from xen 4.5.0 with its upstream qemu included to xen 4.5.1-pre with qemu upstream from stable-4.5 (changed Config.mk to use

Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 12:33:36PM +0100, Peter Maydell wrote: On 21 April 2015 at 11:09, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: A predefined scope in the ACPI specs is precede with a backslash. Signed-off-by: Gal Hammer

Re: [Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single step

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 13:56, Alex Bennée alex.ben...@linaro.org wrote: Peter Maydell peter.mayd...@linaro.org writes: switch (hsr_ec) { +case HSR_EC_SOFT_STEP: +if (cs-singlestep_enabled) { +return true; +} else { +error_report(Came out of

Re: [Qemu-devel] [PATCH v2 4/4] target-arm: kvm - add support for HW assisted debug

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: On 31 March 2015 at 16:40, Alex Bennée alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com This adds basic support for HW assisted debug. The ioctl interface to KVM allows us to pass an implementation defined number of break and

Re: [Qemu-devel] [PATCH] block: document block-stream in qmp-commands.hx

2015-04-21 Thread Stefan Hajnoczi
On Wed, Apr 15, 2015 at 11:43:42AM +0100, Stefan Hajnoczi wrote: The 'block-stream' QMP command is documented in block-core.json but not qmp-commands.hx. Add a summary of the command to qmp-commands.hx (similar to the documentation for 'block-commit'). Reported-by: Kashyap Chamarthy

Re: [Qemu-devel] [PATCH v2 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 08:39, Alex Bennée alex.ben...@linaro.org wrote: Peter Maydell peter.mayd...@linaro.org writes: Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by:

Re: [Qemu-devel] [PATCH v2 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Edgar E. Iglesias

[Qemu-devel] [Bug 1440843] Re: Guest WinXP crashes when trying to use a USB spectrometer

2015-04-21 Thread Ruslan
I was using QEMU from git, v2.3.0-rc2, when reporting this bug. And this is the same since much earlier (about a year older) version. And of course I do enable EHCI controller via `-device usb-ehci`. And checked it with native Windows XP, where the device works with no problem. Actually, as I said

Re: [Qemu-devel] [PATCH 04/18] virtio: Return error from virtqueue_next_desc

2015-04-21 Thread Fam Zheng
On Tue, 04/21 08:37, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:19PM +0800, Fam Zheng wrote: Two callers pass error_abort now, which can be changed to check return value and pass the error on. Signed-off-by: Fam Zheng f...@redhat.com --- hw/virtio/virtio.c | 27

Re: [Qemu-devel] [PATCH v2 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Add new address_space_ld*/st* functions which allow transaction attributes and error reporting for basic load and stores. These are named to be in line with the address_space_read/write/rw buffer operations. The existing ld/st*_phys functions

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Fam Zheng
On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng f...@redhat.com wrote: Currently, virtio code chooses to kill QEMU if the guest

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 16:38:31 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng

Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Check watchpoints against CPU security state

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Fix a TODO in bp_wp_matches() now that we have a function for testing whether the CPU is currently in Secure mode or not. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Edgar E. Iglesias edgar.igles...@xilinx.com

Re: [Qemu-devel] [PATCH v2 12/14] target-arm: Add user-mode transaction attribute

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Add a transaction attribute indicating that a memory access is being done from user-mode (unprivileged). This corresponds to an equivalent signal in ARM AMBA buses. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH v2 13/14] target-arm: Use attribute info to handle user-only watchpoints

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Now that we have memory access attribute information in the watchpoint checking code, we can correctly implement handling of watchpoints which should match only on userspace accesses, where LDRT/STRT/LDT/STT from EL1 are treated as userspace

Re: [Qemu-devel] [PATCH 06/18] virtio: Return error from virtqueue_pop

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 03:24:25PM +0800, Fam Zheng wrote: On Tue, 04/21 08:49, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:21PM +0800, Fam Zheng wrote: When getting invalid data from vring, virtqueue_pop used to print an error and exit. Add an errp parameter so it can

[Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Gal Hammer
A predefined scope in the ACPI specs is precede with a backslash. Signed-off-by: Gal Hammer gham...@redhat.com --- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c

[Qemu-devel] [question] Clean way to retrieve the gsi of a sysbus device qemu_irq?

2015-04-21 Thread Eric Auger
Hi, I am trying to figure out a clean solution to retrieve the gsi associated to a sysbus device qemu_irq. Among other things this is needed to start VFIO platform signaling. With PCI, it seems the PCI host stores the mapping (*_route_intx_pin_to_irq). Without PCI, if my understanding is correct

Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Igor Mammedov
On Tue, 21 Apr 2015 11:26:12 +0300 Gal Hammer gham...@redhat.com wrote: A predefined scope in the ACPI specs is precede with a backslash. Signed-off-by: Gal Hammer gham...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- hw/i386/acpi-build.c| 2 +-

Re: [Qemu-devel] virtio-blk and virtio-scsi performance comparison

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 11:53, Konstantin Krotov wrote: Can you detail the problem more? That could be a kernel bug. I connect to the host system, two storage systems as block devices. Both block devices combine md-raid1. md-device use as disk for virtual machine. If i use io=native, read perform

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng f...@redhat.com wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has

Re: [Qemu-devel] [PATCH v2 08/14] exec.c: Capture the memory attributes for a watchpoint hit

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Capture the memory attributes for the transaction which triggered a watchpoint; this allows CPU specific code to implement features like ARM's user-mode only WPs also hit for LDRT/STRT accesses made from privileged code. This change also

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Use correct memory attributes for page table walks

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Factor out the page table walk memory accesses into their own function, so that we can specify the correct S/NS memory attributes for them. This will also provide a place to use the correct endianness and handle the need for a stage-2

Re: [Qemu-devel] [PATCH 04/18] virtio: Return error from virtqueue_next_desc

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 03:30:23PM +0800, Fam Zheng wrote: On Tue, 04/21 08:37, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:19PM +0800, Fam Zheng wrote: Two callers pass error_abort now, which can be changed to check return value and pass the error on.

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 09:43:36 +0800 Shannon Zhao shannon.z...@linaro.org wrote: On 2015/4/20 19:32, Cornelia Huck wrote: On Mon, 20 Apr 2015 16:20:00 +0800 shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Move DEFINE_VIRTIO_NET_FEATURES to the backend

Re: [Qemu-devel] [PATCH v2 10/14] target-arm: Honour NS bits in page tables

2015-04-21 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Honour the NS bit in ARM page tables: * when adding entries to the TLB, include the Secure/NonSecure transaction attribute * set the NS bit in the PAR when doing ATS operations Note that we don't yet correctly use the NSTable bit to

Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: A predefined scope in the ACPI specs is precede with a backslash. Signed-off-by: Gal Hammer gham...@redhat.com s/precede/preceded/ This is correct, but do we need this in 2.3? I'm split on this. Thoughts? If yes, commit log needs

Re: [Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-21 Thread Laszlo Ersek
Hi Amos, On 04/21/15 01:31, Amos Kong wrote: Hi Kevin, When I use old seabios in some stable linux release, some bootable devices (2 ide disks) would be lost when I try to restart guest by Ctrl+Alt+Delete during boot stage. Releated Red Hat BZ:

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 05:16:53PM +0800, Fam Zheng wrote: On Tue, 04/21 11:08, Cornelia Huck wrote: On Tue, 21 Apr 2015 16:38:31 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote:

Re: [Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 02:29, Kevin O'Connor wrote: On a typical x86 machine, the BIOS image is located in read-only memory at 0x. The chipsets typically also support shadowing that image to ram (or as a read-only copy) at 0xf. However, neither qemu nor kvm fully support all the

Re: [Qemu-devel] virtio-blk and virtio-scsi performance comparison

2015-04-21 Thread Konstantin Krotov
16.04.2015 14:57, Paolo Bonzini пишет: On 16/04/2015 13:17, Konstantin Krotov wrote: In my production system i'm interested to use io=thread, becouse i export MD raid1 devices to guest's and i need to read from the MD device performs balanced between raid1 legs (it's true only if io=thread).

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 17:16:53 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 11:08, Cornelia Huck wrote: My concern is mainly about legacy setups that aren't used interactively. How about pausing guest and generating an QMP event? That sounds good as well.

Re: [Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt board

2015-04-21 Thread Peter Maydell
On 8 April 2015 at 22:21, Christoffer Dall christoffer.d...@linaro.org wrote: Adding the GICv2m to the virt board should allow us to enable MSIs on the generic PCI host controller, in theory. So is this commit message just saying I haven't tested this patchset :-), or are we still missing

Re: [Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-21 Thread Kevin O'Connor
On Tue, Apr 21, 2015 at 10:37:49AM +0200, Laszlo Ersek wrote: As to how you can fix https://bugzilla.redhat.com/show_bug.cgi?id=1129549 (which is the motivation for this entire discussion): - You need to identify *what variable exactly* stores the list of bootable devices. Is that a

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
On Di, 2015-04-21 at 17:08 +0200, Paolo Bonzini wrote: On 21/04/2015 17:04, Gerd Hoffmann wrote: Hmm. I think if we merge all the smm / smram / tseg patches in one go this should work. Without patches reading the ESMRAMC register returns zero. With the patches the three cache-disable

[Qemu-devel] [PATCH] qcow2: do lazy allocation of the L2 cache

2015-04-21 Thread Alberto Garcia
Large disk images need large L2 caches in order to maximize their I/O performance. However setting a correct size for the cache is not necessarily easy since apart from the image size, it also depends on other factors like its usage patterns or whether it's part of a backing chain. In order to be

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 17:05, Laszlo Ersek wrote: Yet another question -- as far as I understand, I should have enough info (with my pending questions of course) for EFI_SMM_ACCESS2_PROTOCOL. I've now reviewed EFI_SMM_CONTROL2_PROTOCOL too, and AFAICS the only thing I need to know for it is how to

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 16:35, Luiz Capitulino wrote: gladly, I am definitely looking for Review, first I wanted to check if the idea itself was acceptable. I honestly don't have an opinion on this, which means I'm willing to apply if there are no objections. On the other hand, isn't it

Re: [Qemu-devel] [PATCH v2.5 00/10] block: incremental backup transactions

2015-04-21 Thread Kashyap Chamarthy
On Tue, Apr 21, 2015 at 03:53:11PM +0200, Kashyap Chamarthy wrote: [. . .] And, invoking `drive-backup` *without* pre-creating the target image (i.e. 'incremental.o.img'): { 'execute': 'drive-backup', 'arguments': { 'device': 'ide0-0-0', Small typo (in this email, not

[Qemu-devel] [PATCH v2 2/2] target-mips: add Config5.FRE support allowing Status.FR=0 emulation

2015-04-21 Thread Leon Alrae
This relatively small architectural feature adds the following: FIR.FREP: Read-only. If FREP=1, then Config5.FRE and Config5.UFE are available. Config5.FRE: When enabled all single-precision FP arithmetic instructions, LWC1/LWXC1/MTC1, SWC1/SWXC1/MFC1 cause a Reserved

[Qemu-devel] [PATCH v2 0/2] target-mips: add Config5.FRE support

2015-04-21 Thread Leon Alrae
MIPS architectural feature allowing emulation of Status.FR=0 on a CPU with Status.FR hardwired to 1. v2: * move functions and drop prototypes (James) * fix declaration after code (James) Leon Alrae (2): target-mips: move group of functions above gen_load_fpr32() target-mips: add Config5.FRE

[Qemu-devel] [PATCH v2 1/2] target-mips: move group of functions above gen_load_fpr32()

2015-04-21 Thread Leon Alrae
Move the Tests group of functions so that gen_load_fpr32() and gen_store_fpr32() can use generate_exception(). Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/translate.c | 118 1 file changed, 58 insertions(+), 60 deletions(-)

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
+static const MemoryRegionOps tseg_blackhole_ops = { +.read = tseg_blackhole_read, +.write = tseg_blackhole_write, +.endianness = DEVICE_NATIVE_ENDIAN, +.valid.min_access_size = 1, +.valid.max_access_size = 4, +.impl.min_access_size = 4, +

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Claudio Fontana
On 21.04.2015 16:28, Paolo Bonzini wrote: On 21/04/2015 16:25, Claudio Fontana wrote: I seem not to get this warning with the compiler version I am currently using, and after checking the code I could not find out why with some compilers would emit such a warning. It is difficult for

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
Hi, I'm thinking, the last 1 / 2 / 8 megabytes should behave as RAM in all of the following cases: - no SMRAM programmed (tseg size = 0) - SMRAM programmed (tseg size 0), and it is open - SMRAM programmed (tseg size 0) and closed, but CPU in SMM Correct. Almost. I think the

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config arg sub-argument

2015-04-21 Thread Liviu Ionescu
On 21 Apr 2015, at 16:34, Leon Alrae leon.al...@imgtec.com wrote: (PS: --semihosting-cmdline $@ is probably the most convenient from GUI / wrapper point of view, but I don't have an opinion whether this is enough to justify adding a top level QEMU command line option with such a unique

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
tseg_blackhole is added on top of address_space_memory to hide TSEG; tseg_window is included in /machine/smram and TCG adds it to the private per-CPU address space when it enters system management mode. Hm, I must have missed this (or not seen it at all) -- should I have noticed it in

Re: [Qemu-devel] kvm vs host (arm64)

2015-04-21 Thread Christopher Covington
Hi Mohan, On 04/21/2015 02:23 AM, Mohan G wrote: comments inline - Original Message - From: Marc Zyngier marc.zyng...@arm.com To: Mohan G mohan...@yahoo.com; linux-arm-ker...@lists.infradead.org linux-arm-ker...@lists.infradead.org Cc: Sent: Monday, April 20, 2015 4:32 PM

Re: [Qemu-devel] [PATCH v2 00/14] Add memory attributes and use them in ARM

2015-04-21 Thread Peter Maydell
On 13 April 2015 at 14:21, Peter Maydell peter.mayd...@linaro.org wrote: I've included both the changes to the core memory system code and the target-arm changes as a usage example, but the ARM stuff is all at the end of the series, so if we want to split it and take it via separate subtrees

Re: [Qemu-devel] [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-21 Thread Kevin Wolf
Am 21.04.2015 um 15:28 hat Stefan Hajnoczi geschrieben: On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: The image field in BlockDeviceInfo is supposed to contain an ImageInfo object. However that is being filled in by bdrv_query_info(), not by bdrv_block_device_info(), which

[Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-21 Thread Alexander Graf
The AMD Opteron family has different xlevel levels depending on the generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the levels according to real silicon. The reason this came up is that there is a sanity check in KVM making sure that SVM is only used when xlevel is high enough.

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Luiz Capitulino
On Fri, 27 Mar 2015 17:19:30 +0100 Claudio Fontana claudio.font...@huawei.com wrote: Just a respectful ping on this one.. Luiz do you think you can integrate this into the monitor? Would be nice to get a Reviewed-by from someone and, I'm getting a build error:

Re: [Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-21 Thread Alexander Graf
On 04/21/2015 04:16 PM, Eduardo Habkost wrote: On Tue, Apr 21, 2015 at 04:04:21PM +0200, Alexander Graf wrote: The AMD Opteron family has different xlevel levels depending on the generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the levels according to real silicon. The reason

Re: [Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-21 Thread Eduardo Habkost
On Tue, Apr 21, 2015 at 04:04:21PM +0200, Alexander Graf wrote: The AMD Opteron family has different xlevel levels depending on the generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the levels according to real silicon. The reason this came up is that there is a sanity check

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Claudio Fontana
Hello Luiz, On 21.04.2015 00:01, Luiz Capitulino wrote: On Fri, 27 Mar 2015 17:19:30 +0100 Claudio Fontana claudio.font...@huawei.com wrote: Just a respectful ping on this one.. Luiz do you think you can integrate this into the monitor? Would be nice to get a Reviewed-by from someone

[Qemu-devel] [PATCH RFC 0/2] virtio-ccw realization/plugged handling

2015-04-21 Thread Cornelia Huck
Turns out that reworking the realization/plugging sequence for virtio-ccw to make it more similar to virtio-pci (as discussed in https://marc.info/?l=qemu-develm=142954827813046w=2) was easier than expected. At least I have something that seems to look sane, produces working virtio-ccw devices and

Re: [Qemu-devel] [PATCH 2/3] arm_gicv2m: Add GICv2m widget to support MSIs

2015-04-21 Thread Peter Maydell
On 8 April 2015 at 22:20, Christoffer Dall christoffer.d...@linaro.org wrote: The ARM GICv2m widget is a little device that handle MSI interrupt handles writes to a trigger register and ties them to a range of interrupt lines wires to the GIC. It has a few status/id registers and the

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Laszlo Ersek
On 04/21/15 16:38, Paolo Bonzini wrote: On 21/04/2015 16:30, Laszlo Ersek wrote: -MemoryRegion tseg_blackhole; +MemoryRegion tseg_blackhole, tseg_window; PcPciInfo pci_info; ram_addr_t below_4g_mem_size; ram_addr_t above_4g_mem_size; Why is this necessary? If you

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 17:04, Gerd Hoffmann wrote: Hmm. I think if we merge all the smm / smram / tseg patches in one go this should work. Without patches reading the ESMRAMC register returns zero. With the patches the three cache-disable bits are hardcoded to '1'. This should work for detecting

[Qemu-devel] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-21 Thread Thomas Huth
The check liobn 0xULL in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter. Fix this by using target_ulong instead (this is what most of the callers of this function are using, too). Signed-off-by: Thomas Huth th...@redhat.com

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 03:25, Wen Congyang wrote: Please do not introduce name+colo block drivers. This approach is invasive and makes block replication specific to only a few block drivers, e.g. NBD or qcow2. NBD is used to connect to secondary qemu, so it must be used. But the primary qemu

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config arg sub-argument

2015-04-21 Thread Leon Alrae
On 16/04/2015 15:22, Peter Maydell wrote: On 15 April 2015 at 10:09, Liviu Ionescu i...@livius.net wrote: we currently have two solutions: - multiple: --semihosting-config arg=... - a single option, placed at the end, and followed by any number of arguments: --semihosting-cmdline $@ \n

Re: [Qemu-devel] [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-21 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: The image field in BlockDeviceInfo is supposed to contain an ImageInfo object. However that is being filled in by bdrv_query_info(), not by bdrv_block_device_info(), which is where BlockDeviceInfo is actually created. Anyone

Re: [Qemu-devel] [PATCH v2 10/14] target-arm: Honour NS bits in page tables

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 10:24, Alex Bennée alex.ben...@linaro.org wrote: Peter Maydell peter.mayd...@linaro.org writes: Honour the NS bit in ARM page tables: * when adding entries to the TLB, include the Secure/NonSecure transaction attribute * set the NS bit in the PAR when doing ATS

Re: [Qemu-devel] [PATCH v2.5 00/10] block: incremental backup transactions

2015-04-21 Thread Kashyap Chamarthy
On Fri, Apr 17, 2015 at 09:01:10PM -0400, John Snow wrote: I am not prepared to send a v3 on this, primarily because I am still waffling on whether or not to do the code motion patch that is present in patch #8 of v2 of this series. However, for the purposes of testing, reviewers may find it

  1   2   >