Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > >> > > > >> > I use your new code: > > >> > - > > >> >unsigned long *p = ... > > >> >if (p[0] || p[1] || p[2] || p[3] > > >> >|| memcmp(p+4, p, size - 4 * sizeof(unsigned

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json Missing a vNN in the subject line. I think we're up to v14? But it doesn't affect what 'git am' will do. > > Signed-off-by: Prasanna Kumar Kalever > --- >

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2015 at 10:48:12AM +0100, Paolo Bonzini wrote: > > > On 11/11/2015 20:09, Eduardo Habkost wrote: > > All DisplayType values are just UI options that don't affect any > > hardware emulation code, except for DT_NOGRAPHIC. Replace > > DT_NOGRAPHIC with DT_NONE plus a new

[Qemu-devel] [PATCH 3/3] qtest/ahci: use raw format when qemu-img is absent

2015-11-12 Thread John Snow
If we don't have the qemu-img tool, use the raw format for tests and skip the high-sector LBA48 tests. Signed-off-by: John Snow --- tests/ahci-test.c | 41 - 1 file changed, 32 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 0/3] qtest/ahci: skip qcow2 tests

2015-11-12 Thread John Snow
Skip tests that need qcow2 to function when qemu-img isn't set or otherwise present. When running under raw mode, we no longer properly test LBA48 reads/writes beyond 137Gb. ahci-test will skip past any //io//lba48//high test. While we're at it, try to make failures due to missing qemu-img

Re: [Qemu-devel] [PATCH 1/4] block/gluster: rename [server, volname, image] -> [host, volume, path]

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch is very much be meaningful after next patch which adds multiple > gluster servers support. After that, > > an example is, in 'servers' tuple values we use 'server' variable for key Awkward line break mid-sentence. The commit

Re: [Qemu-devel] [PATCH] tests/.gitignore: ignore test-blockjob-txn

2015-11-12 Thread John Snow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11/12/2015 03:31 PM, Eric Blake wrote: > On 11/12/2015 01:21 PM, John Snow wrote: >> Reported-by: Eric Blake Signed-off-by: John >> Snow --- tests/.gitignore | 1 + 1 file >> changed, 1 insertion(+) > > My

Re: [Qemu-devel] [PATCH v2 0/7] vl: graphics stubs + #ifdef cleanup

2015-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2015 at 02:17:53PM -0700, Eric Blake wrote: > On 11/12/2015 12:02 PM, Eduardo Habkost wrote: > > Clean up the graphics initialization code to reduce the number of > > > > Lame of git for eating lines that start with #ifdef. But at least it > doesn't matter on the cover letter :)

[Qemu-devel] [PATCH] scsi: remove scsi_req_free prototype

2015-11-12 Thread Hervé Poussineau
Function has been deleted in ad2d30f79d3b0812f02c741be2189796b788d6d7. Signed-off-by: Hervé Poussineau --- include/hw/scsi/scsi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h index cdaf0f8..1915a73 100644 ---

[Qemu-devel] [PATCH 1/3] qtest/ahci: always specify image format

2015-11-12 Thread John Snow
Signed-off-by: John Snow --- tests/ahci-test.c | 51 +-- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 59d387c..6d9ac84 100644 --- a/tests/ahci-test.c +++

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Jeff Cody
On Thu, Nov 12, 2015 at 03:52:07PM +0530, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- >

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Jeff Cody
On Thu, Nov 12, 2015 at 03:52:08PM +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currently VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH for-2.5 v5 1/1] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-12 Thread Peter Maydell
On 12 November 2015 at 17:54, Peter Crosthwaite wrote: > From: Guenter Roeck > > Add support for the Xilinx XADC core used in Zynq 7000. > > References: > - Zynq-7000 All Programmable SoC Technical Reference Manual > - 7 Series FPGAs and Zynq-7000

[Qemu-devel] [PATCH] tests/.gitignore: ignore test-blockjob-txn

2015-11-12 Thread John Snow
Reported-by: Eric Blake Signed-off-by: John Snow --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index e96f569..de5e793 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -9,6 +9,7 @@

Re: [Qemu-devel] [PATCH] tests/.gitignore: ignore test-blockjob-txn

2015-11-12 Thread Eric Blake
On 11/12/2015 01:21 PM, John Snow wrote: > Reported-by: Eric Blake > Signed-off-by: John Snow > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) My version of this same patch at least called out the commit that introduced the problem :)

Re: [Qemu-devel] [PATCH v2 0/7] vl: graphics stubs + #ifdef cleanup

2015-11-12 Thread Eric Blake
On 11/12/2015 12:02 PM, Eduardo Habkost wrote: > Clean up the graphics initialization code to reduce the number of > Lame of git for eating lines that start with #ifdef. But at least it doesn't matter on the cover letter :) > Changes v1 -> v2: > * Patches 2-6: Move stub files to stubs/ui/ > *

[Qemu-devel] which machinetypes have an integrated/implied IDE controller?

2015-11-12 Thread Laine Stump
For a long time, libvirt assumed by default that all types of virtual machines had an integrated IDE controller named "ide" that wasn't specified on the qemu commandline. Since that caused problems specifically for the Q35 machine type (which has an *ahci* controller that it perplexingly calls

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Eric Blake
On 11/12/2015 12:56 PM, Dr. David Alan Gilbert wrote: >> One thing I still can't understand, why the unit test in host environment >> shows >> 'memcmp()' have better performance? Have you tried running under a profiler, to see if there are hotspots or at least get an idea of where the time is

[Qemu-devel] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-12 Thread Hervé Poussineau
dbdma_from_ch() uses channel field to return the right DBDMA object. Previous code was working if guest OS was only using registered DMA channels. However, it lead to QEMU crashes if guest OS was using unregistered DMA channels. Signed-off-by: Hervé Poussineau ---

[Qemu-devel] [PATCH 2/3] libqos: add qemu-img presence check

2015-11-12 Thread John Snow
To allow tests to optionally exercise additional tests that require the qemu-img tool that may not be present in all builds. Signed-off-by: John Snow --- tests/libqos/libqos.c | 28 +++- tests/libqos/libqos.h | 1 + 2 files changed, 24 insertions(+), 5

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- > qapi/block-core.json |

Re: [Qemu-devel] [PATCH for-2.5 1/2] input: Avoid CamelCase in InputEvent enums

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > Our documentation states that we prefer 'lower-case', rather than > 'CamelCase', for qapi enum values. The InputButton and InputAxis > enums violated this convention. However, they are currently used > primarily for generating code that is used

Re: [Qemu-devel] [PATCH for-2.5 2/2] input: Promote 'input-send-event' to stable API

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > We've had 'x-input-send-event' since 2.3, with no further > changes to the interface other than tweaks in the previous patch > to the spelling of the enum constants ('X' and 'WheelUp' changed > to 'x' and 'wheel-up'). > > What's more, changing the spelling

[Qemu-devel] [PULL v2 02/12] e1000: Cosmetic and alignment fixes

2015-11-12 Thread Jason Wang
From: Leonid Bloch This fixes some alignment and cosmetic issues. The changes are made in order that the following patches in this series will look like integral parts of the code surrounding them, while conforming to the coding style. Although some changes in

[Qemu-devel] [PULL v2 04/12] e1000: Introduced an array to control the access to the MAC registers

2015-11-12 Thread Jason Wang
From: Leonid Bloch The array of uint8_t's which is introduced here, contains access metadata about the MAC registers: if a register is accessible, but partly implemented, or if a register requires a certain compatibility flag in order to be accessed. Currently, 6

[Qemu-devel] [PULL v2 01/12] slirp: Fix type casts and format strings in debug code

2015-11-12 Thread Jason Wang
From: Stefan Weil Casting pointers to long won't work on 64 bit Windows. It is not needed with the right format strings. Signed-off-by: Stefan Weil Signed-off-by: Jason Wang --- slirp/bootp.c | 12 +--- slirp/if.c

[Qemu-devel] [PULL v2 11/12] net: netmap: Fix compilation issue

2015-11-12 Thread Jason Wang
From: Vincenzo Maffione Reorganization of struct NetClientOptions (commit e4ba22b) caused a compilation failure of the netmap backend. This patch fixes the issue by properly accessing the union field. Reviewed-by: Eric Blake Reviewed-by: Markus

Re: [Qemu-devel] [PATCH 04/10] snapshot: create bdrv_all_goto_snapshot helper

2015-11-12 Thread Fam Zheng
On Tue, 11/10 17:25, Denis V. Lunev wrote: > to switch to snapshot on all loaded block drivers. > > The patch also ensures proper locking. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Greg Kurz > CC: Juan Quintela > CC:

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Paolo Bonzini
On 12/11/2015 03:49, Li, Liang Z wrote: > I am very surprised about the live migration performance result when > I use your ' memeqzero4_paolo' instead of these SSE2 Intrinsics to > check the zero pages. What code were you using? Remember I suggested using only unsigned long checks, like

Re: [Qemu-devel] [PATCH 0/3] Postcopy minor fixes

2015-11-12 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > Am 11.11.2015 um 15:02 schrieb Dr. David Alan Gilbert (git): > > From: "Dr. David Alan Gilbert" > > > > Hi, > > These are three small fixes for the postcopy code; > > the first two coming from Bharata's testing on

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-12 Thread Paolo Bonzini
On 11/11/2015 20:09, Eduardo Habkost wrote: > All DisplayType values are just UI options that don't affect any > hardware emulation code, except for DT_NOGRAPHIC. Replace > DT_NOGRAPHIC with DT_NONE plus a new MachineState.nographic > field, so hardware emulation code don't need to use the >

Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Prasanna Kumar Kalever
On Tuesday, November 10, 2015 9:37:20 PM, Eric Blake wrote: > > On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple volfile servers to the gluster > > block backend of QEMU with tcp|rdma transport types and their port numbers. > > > > [...] [...]

[Qemu-devel] [PULL v2 12/12] net: netmap: use error_setg() helpers in place of error_report()

2015-11-12 Thread Jason Wang
From: Vincenzo Maffione This update was required to align error reporting of netmap backend initialization to the modifications introduced by commit a30ecde. Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by:

Re: [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-12 Thread Gerd Hoffmann
Hi, > > If desired, I can prepare an alternate patch that adds the dash to the > > qapi enum definition, to see what we think. > > If Gerd is fine with the rename, let's do it. No need to do so I think ... > >> -[INPUT_BUTTON_WHEEL_UP] = SDL_BUTTON(SDL_BUTTON_WHEELUP), > >> -

[Qemu-devel] [PULL v2 10/12] e1000: Introducing backward compatibility command line parameter

2015-11-12 Thread Jason Wang
From: Leonid Bloch This follows the previous patches, where support for migrating the entire MAC registers' array, and some new MAC registers were introduced. This patch introduces the e1000-specific boolean parameter "extra_mac_registers", which is on by

[Qemu-devel] [PULL v2 09/12] e1000: Implementing various counters

2015-11-12 Thread Jason Wang
From: Leonid Bloch This implements the following Statistic registers (various counters) according to Intel's specs: TSCTC GOTCL GOTCH GORCL GORCH MPRC BPRC RUCROC BPTC MPTC PTC... PRC... PLEASE NOTE: these registers will not be active, nor will

Re: [Qemu-devel] [PATCH V3 4/6] ide: orphan all buffered requests on DMA cancel

2015-11-12 Thread Peter Lieven
Am 12.11.2015 um 09:27 schrieb Fam Zheng: On Fri, 11/06 09:42, Peter Lieven wrote: If the guests canceles a DMA request we can prematurely invoke all callbacks of buffered requests and flag all them as orphaned. Ideally this avoids the need for draining all requests. For CDROM devices this

Re: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Markus Armbruster
Bandan Das writes: > There's no indication of any sort that i440fx doesn't support > "iommu=on"" > > Signed-off-by: Bandan Das > --- > hw/pci-host/piix.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c >

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-11-12 Thread Zhu Guihua
Hi Bharata, On 09/09/2015 03:56 PM, Bharata B Rao wrote: On Wed, Sep 09, 2015 at 03:41:30PM +0800, Zhu Guihua wrote: On 09/09/2015 01:52 PM, Bharata B Rao wrote: On Fri, Sep 04, 2015 at 03:31:24PM +1000, David Gibson wrote: On Thu, Aug 06, 2015 at 10:57:07AM +0530, Bharata B Rao wrote:

Re: [Qemu-devel] [PATCH for 2.5 v7 0/10] dataplane snapshot fixes

2015-11-12 Thread Fam Zheng
On Tue, 11/10 17:25, Denis V. Lunev wrote: > Denis V. Lunev (10): > snapshot: create helper to test that block drivers supports snapshots > snapshot: return error code from bdrv_snapshot_delete_by_id_or_name > snapshot: create bdrv_all_delete_snapshot helper > snapshot: create

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-11-12 Thread Andreas Färber
Am 12.11.2015 um 10:30 schrieb Bharata B Rao: > On Thu, Nov 12, 2015 at 05:11:02PM +0800, Zhu Guihua wrote: >> Hi Bharata, >> >> On 09/09/2015 03:56 PM, Bharata B Rao wrote: >>> On Wed, Sep 09, 2015 at 03:41:30PM +0800, Zhu Guihua wrote: On 09/09/2015 01:52 PM, Bharata B Rao wrote: > On

Re: [Qemu-devel] [PULL v2 0/7] Block patches

2015-11-12 Thread Peter Maydell
On 11 November 2015 at 20:59, Marc-André Lureau wrote: > Hi Peter > > On Wed, Nov 11, 2015 at 9:33 PM, Peter Maydell > wrote: >> On 10 November 2015 at 18:41, Peter Maydell wrote: >>> On 9 November 2015 at 17:50,

Re: [Qemu-devel] [v2 1/2] cutils: add avx2 instruction optimization

2015-11-12 Thread Li, Liang Z
> > The main issue here is that you are not testing whether the compiler supports > gnu_indirect_function. > > I suggest that you start by moving the functions to util/buffer-zero.c > > Then the structure should be something like > > #ifdef CONFIG_HAVE_AVX2 > #include > #endif > > ... define

Re: [Qemu-devel] [PATCH v6 0/9] e1000: Various fixes and registers' implementation

2015-11-12 Thread Jason Wang
On 11/11/2015 09:52 PM, Leonid Bloch wrote: > This series fixes issues with packet/octet counting in e1000's Statistic > registers, fixes a bug in the packet address filtering procedure, and > implements many MAC registers that were absent before, some Statistic > counters among them. > >

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

2015-11-12 Thread Gerd Hoffmann
On Mo, 2015-11-09 at 18:12 -0500, Bandan Das wrote: > Gerd Hoffmann writes: > > > On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: > >> +/* Add a new watch asap so as to not lose events > >> */ > > > > This comment sounds like there is a race ("asap").

Re: [Qemu-devel] [PATCH 1/4] spapr: Extend rtas-blob

2015-11-12 Thread Thomas Huth
On 11/11/15 18:15, Aravinda Prasad wrote: > Extend rtas-blob to accommodate error log. Error log > structure is saved in rtas space upon a machine check > exception. > > Signed-off-by: Aravinda Prasad > --- > hw/ppc/spapr.c |4 > 1 file changed, 4

[Qemu-devel] [PULL v2 00/12] Net patches

2015-11-12 Thread Jason Wang
The following changes since commit 31e49ac192f782d594bbd04070fe79e800b7813f: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-2015' into staging (2015-11-11 18:23:08 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Thomas Huth
On 11/11/15 18:16, Aravinda Prasad wrote: > Memory error such as bit flips that cannot be corrected > by hardware are passed on to the kernel for handling. > If the memory address in error belongs to guest then > guest kernel is responsible for taking suitable action. > Patch [1] enhances KVM to

Re: [Qemu-devel] [PATCH V3 2/6] block: add blk_abort_aio_request

2015-11-12 Thread Fam Zheng
On Fri, 11/06 09:42, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/block-backend.c | 17 + > include/sysemu/block-backend.h | 3 +++ > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/block/block-backend.c

Re: [Qemu-devel] [PATCH for-2.5 2/2] input: Promote 'input-send-event' to stable API

2015-11-12 Thread Gerd Hoffmann
On Do, 2015-11-12 at 09:23 +0100, Markus Armbruster wrote: > Eric Blake writes: > > > We've had 'x-input-send-event' since 2.3, with no further > > changes to the interface other than tweaks in the previous patch > > to the spelling of the enum constants ('X' and 'WheelUp'

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-11-12 Thread Zhu Guihua
On 11/12/2015 05:30 PM, Bharata B Rao wrote: On Thu, Nov 12, 2015 at 05:11:02PM +0800, Zhu Guihua wrote: Hi Bharata, On 09/09/2015 03:56 PM, Bharata B Rao wrote: On Wed, Sep 09, 2015 at 03:41:30PM +0800, Zhu Guihua wrote: On 09/09/2015 01:52 PM, Bharata B Rao wrote: On Fri, Sep 04, 2015 at

Re: [Qemu-devel] [PATCH 04/10] snapshot: create bdrv_all_goto_snapshot helper

2015-11-12 Thread Denis V. Lunev
On 11/12/2015 11:38 AM, Fam Zheng wrote: On Tue, 11/10 17:25, Denis V. Lunev wrote: to switch to snapshot on all loaded block drivers. The patch also ensures proper locking. Signed-off-by: Denis V. Lunev Reviewed-by: Greg Kurz CC: Juan Quintela

Re: [Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2015-11-12 Thread Justin Shafer
Wine works! =) Didn't know if you knew... no more old qemu. You da man! On Tue, Aug 6, 2013 at 3:33 AM, Peter Maydell wrote: > Commits aa004f5f9 to 24cb36a61c (13 in total) are the patchset that fix > this. > > -- > You received this bug notification because you are

Re: [Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend

2015-11-12 Thread Jason Wang
On 11/10/2015 05:47 PM, Vincenzo Maffione wrote: > This patch series adds some fixes to the netmap net backend. It contains > two changes: > (1) Fix compilation issue of netmap.c introduced by the reorganization > of struct NetClientOptions > (2) Address the FIXME comment that

Re: [Qemu-devel] [PATCH] virtio-9p: add savem handlers

2015-11-12 Thread Greg Kurz
On Thu, 22 Oct 2015 19:38:42 +0200 Greg Kurz wrote: > We don't support migration of mounted 9p shares. This is handled by a > migration blocker. > > One would expect, however, to be able to migrate if the share is unmounted. > Unfortunately virtio-9p-device does not

Re: [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-12 Thread Gerd Hoffmann
Hi, > The InputButton type has existed since 2.0; which is then part of the > 'InputBtnEvent' struct, then the 'InputEvent' union, also since 2.0. I > can't easily tell if it was only used internally at that point, Internal only. > 'x-input-send-event' (since 2.2, but the x- prefix gives us

Re: [Qemu-devel] [RFC] ide: Don't use qemu_hw_version() for firmware revision

2015-11-12 Thread Markus Armbruster
Eduardo Habkost writes: > The IDEState.version field is used for firmware version > information returned to the guest. Updating firmware information > on QEMU upgrade is supposed to be acceptable, so IDE doesn't need > the version compatibility magic of qemu_hw_version() and

Re: [Qemu-devel] safety of migration_bitmap_extend

2015-11-12 Thread Wen Congyang
On 11/04/2015 05:19 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 11/04/2015 05:05 PM, Dr. David Alan Gilbert wrote: >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: On 11/03/2015 09:47 PM, Dr. David Alan Gilbert wrote: > * Juan Quintela

Re: [Qemu-devel] [PATCH v6 0/9] e1000: Various fixes and registers' implementation

2015-11-12 Thread Dmitry Fleytman
> On 12 Nov 2015, at 10:16 AM, Jason Wang wrote: > > > > On 11/11/2015 09:52 PM, Leonid Bloch wrote: >> This series fixes issues with packet/octet counting in e1000's Statistic >> registers, fixes a bug in the packet address filtering procedure, and >> implements many MAC

Re: [Qemu-devel] [PATCH 1/1] configure: use appropriate code fragment for -fstack-protector checks

2015-11-12 Thread Markus Armbruster
Rodrigo Rebello writes: > The check for stack-protector support consisted in compiling and linking > the test program below (output by function write_c_skeleton()) with the > compiler flag -fstack-protector-strong first and then with > -fstack-protector-all if the first one

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Li, Liang Z
> On 12/11/2015 03:49, Li, Liang Z wrote: > > I am very surprised about the live migration performance result when > > I use your ' memeqzero4_paolo' instead of these SSE2 Intrinsics to > > check the zero pages. > > What code were you using? Remember I suggested using only unsigned long >

Re: [Qemu-devel] [PATCH v11 00/12] Block replication for continuous checkpoints

2015-11-12 Thread Wen Congyang
ping... On 11/03/2015 06:58 PM, Wen Congyang wrote: > You can the detailed information about block replication from here: > http://wiki.qemu.org/Features/BlockReplication > > Usage: > Please refer to docs/block-replication.txt > > This patch series is based on the following patch series: > 1.

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Paolo Bonzini
On 12/11/2015 09:53, Li, Liang Z wrote: >> On 12/11/2015 03:49, Li, Liang Z wrote: >>> I am very surprised about the live migration performance result when >>> I use your ' memeqzero4_paolo' instead of these SSE2 Intrinsics to >>> check the zero pages. >> >> What code were you using? Remember

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-11-12 Thread Bharata B Rao
On Thu, Nov 12, 2015 at 05:11:02PM +0800, Zhu Guihua wrote: > Hi Bharata, > > On 09/09/2015 03:56 PM, Bharata B Rao wrote: > >On Wed, Sep 09, 2015 at 03:41:30PM +0800, Zhu Guihua wrote: > >>On 09/09/2015 01:52 PM, Bharata B Rao wrote: > >>>On Fri, Sep 04, 2015 at 03:31:24PM +1000, David Gibson

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Li, Liang Z
> >>> I am very surprised about the live migration performance result > >>> when I use your ' memeqzero4_paolo' instead of these SSE2 Intrinsics > >>> to check the zero pages. > >> > >> What code were you using? Remember I suggested using only unsigned > >> long checks, like > >> > >>

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Thomas Huth
On 12/11/15 09:09, Thomas Huth wrote: > On 11/11/15 18:16, Aravinda Prasad wrote: >> Memory error such as bit flips that cannot be corrected >> by hardware are passed on to the kernel for handling. >> If the memory address in error belongs to guest then >> guest kernel is responsible for taking

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Paolo Bonzini
On 12/11/2015 10:40, Li, Liang Z wrote: > I migrate a 8GB RAM Idle guest, I think most of it's pages are zero pages. > > I use your new code: > - > unsigned long *p = ... > if (p[0] || p[1] || p[2] || p[3] > || memcmp(p+4,

Re: [Qemu-devel] [PATCH v6 0/9] e1000: Various fixes and registers' implementation

2015-11-12 Thread Leonid Bloch
On Thu, Nov 12, 2015 at 10:16 AM, Jason Wang wrote: > > > On 11/11/2015 09:52 PM, Leonid Bloch wrote: >> This series fixes issues with packet/octet counting in e1000's Statistic >> registers, fixes a bug in the packet address filtering procedure, and >> implements many MAC

Re: [Qemu-devel] [PATCH 00/12] vl: graphics stubs + #ifdef cleanup, eliminate some global vars

2015-11-12 Thread Paolo Bonzini
On 11/11/2015 20:09, Eduardo Habkost wrote: > * Clean up the graphics initialization code to reduce the > number of #ifdefs; > * Remove the display_type == DT_NOGRAPHIC checks from hardware > emulation code; > * Make the display_type global variable a local variable on > main(); > * Make

Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Prasanna Kumar Kalever
On Tuesday, November 10, 2015 10:54:25 PM, Jeff Cody wrote: > > On Tue, Nov 10, 2015 at 02:39:16PM +0530, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple volfile servers to the gluster > > block backend of QEMU with tcp|rdma transport types and their port numbers. > >

Re: [Qemu-devel] [PATCH V3 3/6] ide: add support for IDEBufferedRequest

2015-11-12 Thread Fam Zheng
On Fri, 11/06 09:42, Peter Lieven wrote: > +BlockAIOCB *ide_buffered_readv(IDEState *s, int64_t sector_num, > + QEMUIOVector *iov, int nb_sectors, > + BlockCompletionFunc *cb, void *opaque) > +{ > +BlockAIOCB *aioreq; > +

Re: [Qemu-devel] [PULL 0/1] Block patches

2015-11-12 Thread Peter Maydell
On 11 November 2015 at 18:00, Jeff Cody wrote: > The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-2015' into > staging (2015-11-11 09:34:18 +) > > are available in the git

Re: [Qemu-devel] [PATCH V3 4/6] ide: orphan all buffered requests on DMA cancel

2015-11-12 Thread Fam Zheng
On Fri, 11/06 09:42, Peter Lieven wrote: > If the guests canceles a DMA request we can prematurely > invoke all callbacks of buffered requests and flag all them > as orphaned. Ideally this avoids the need for draining all > requests. For CDROM devices this works in 100% of all cases. > >

[Qemu-devel] [PULL v2 06/12] e1000: Fixing the received/transmitted packets' counters

2015-11-12 Thread Jason Wang
From: Leonid Bloch According to Intel's specs, these counters (as the other Statistic registers) stick at 0x when this maximal value is reached. Previously, they would reset after the max. value. Signed-off-by: Leonid Bloch

[Qemu-devel] [PULL v2 08/12] e1000: Fixing the packet address filtering procedure

2015-11-12 Thread Jason Wang
From: Leonid Bloch Previously, if promiscuous unicast was enabled, a packet was received straight away, even if it was a multicast or a broadcast packet. This patch fixes that behavior, while making the filtering procedure a bit more human-readable.

[Qemu-devel] [PULL v2 05/12] e1000: Trivial implementation of various MAC registers

2015-11-12 Thread Jason Wang
From: Leonid Bloch These registers appear in Intel's specs, but were not implemented. These registers are now implemented trivially, i.e. they are initiated with zero values, and if they are RW, they can be written or read by the driver, or read only if they are

[Qemu-devel] [PULL v2 03/12] e1000: Add support for migrating the entire MAC registers' array

2015-11-12 Thread Jason Wang
From: Leonid Bloch This patch makes the migration of the entire array of MAC registers possible during live migration. The entire array is just 128 KB long, so practically no penalty should be felt when transmitting it, additionally to the previously transmitted

[Qemu-devel] [PULL v2 07/12] e1000: Fixing the received/transmitted octets' counters

2015-11-12 Thread Jason Wang
From: Leonid Bloch Previously, these 64-bit registers did not stick at their maximal values when (and if) they reached them, as they should do, according to the specs. This patch introduces a function that takes care of such registers, avoiding code duplication,

Re: [Qemu-devel] [PATCH 3/4] spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2015-11-12 Thread Thomas Huth
On 11/11/15 18:15, Aravinda Prasad wrote: > This patch adds support in QEMU to handle "ibm,nmi-register" > and "ibm,nmi-interlock" RTAS calls. > > The machine check notification address is saved when the > OS issues "ibm,nmi-register" RTAS call. > > This patch also handles the case when multiple

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Li, Liang Z
> On 12/11/2015 10:40, Li, Liang Z wrote: > > I migrate a 8GB RAM Idle guest, I think most of it's pages are zero pages. > > > > I use your new code: > > - > > unsigned long *p = ... > > if (p[0] || p[1] || p[2] || p[3] > > ||

Re: [Qemu-devel] [v2 1/2] cutils: add avx2 instruction optimization

2015-11-12 Thread Paolo Bonzini
On 10/11/2015 03:51, Liang Li wrote: > buffer_find_nonzero_offset() is a hot function during live migration. > Now it use SSE2 intructions for optimization. For platform supports > AVX2 instructions, use the AVX2 instructions for optimization can help > to improve the performance about 30%

Re: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das >> --- >> hw/pci-host/piix.c | 4 >> 1 file changed, 4 insertions(+) >> >>

[Qemu-devel] [PATCH v2 1/2] q35: Check propery to determine if iommu is set

2015-11-12 Thread Bandan Das
The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das --- hw/core/machine.c | 5 - hw/pci-host/q35.c | 2 +- include/hw/boards.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
There's no indication of any sort that i440fx doesn't support "iommu=on"" Signed-off-by: Bandan Das --- hw/pci-host/piix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..ffcb846 100644 --- a/hw/pci-host/piix.c +++

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- > qapi/block-core.json |

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

2015-11-12 Thread Bandan Das
Gerd Hoffmann writes: > On Mo, 2015-11-09 at 18:12 -0500, Bandan Das wrote: >> Gerd Hoffmann writes: >> >> > On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: >> >> +/* Add a new watch asap so as to not lose events >> >> */ >> > >> >

[Qemu-devel] [PATCH v2 0/2] Minor cleanups when parsing the "iommu" option

2015-11-12 Thread Bandan Das
Small cleanup changes. The first removes the helper function by directly checking the property and the second adds a error message if user tries to use "-machine iommu=on" with i440fx. v2: 2/2: use error_report for the warning message Bandan Das (2): q35: Check propery to determine if iommu is

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > This patch gives a mechanism to provide all the server addresses, which are in >

Re: [Qemu-devel] [PATCH 0/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Eric Blake
[adding qemu-block] On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > This release is rebased on qemu master branch. > In this series of patches 1/4 and 2/4 are unchanged. According to scripts/get-maintainer.pl, this series should have cc'd qemu-bl...@nongnu.org. I don't know if anyone on

Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Eric Blake
On 11/12/2015 03:55 PM, Bandan Das wrote: > There's no indication of any sort that i440fx doesn't support > "iommu=on"" > > Signed-off-by: Bandan Das > --- > hw/pci-host/piix.c | 5 + > 1 file changed, 5 insertions(+) > > @@ -301,6 +302,10 @@ static void

Re: [Qemu-devel] [PATCH V3 5/6] ide: enable buffered requests for ATAPI devices

2015-11-12 Thread Fam Zheng
On Fri, 11/06 09:42, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > hw/ide/atapi.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c > index 29fd131..2f6d018 100644 > --- a/hw/ide/atapi.c > +++

Re: [Qemu-devel] [v2 1/2] cutils: add avx2 instruction optimization

2015-11-12 Thread Juan Quintela
Paolo Bonzini wrote: > > The main issue here is that you are not testing whether the compiler > supports gnu_indirect_function. > > I suggest that you start by moving the functions to util/buffer-zero.c > > Then the structure should be something like > > #ifdef

Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue

2015-11-12 Thread Peter Maydell
On 10 November 2015 at 14:25, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" > > When transmitting RAM pages, consume pages that have been queued by > MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanning. > > Note: > a) After

[Qemu-devel] [PATCH v2] tests/vhost-user-bridge: implement logging of dirty pages

2015-11-12 Thread Victor Kaplansky
During migration devices continue writing to the guest's memory. The writes has to be reported to QEMU. This change implements minimal support in vhost-user-bridge required for successful migration of a guest with virtio-net device. Signed-off-by: Victor Kaplansky --- v2:

Re: [Qemu-devel] [PULL v2 0/1] error: More error_setg() usage

2015-11-12 Thread Peter Maydell
On 12 November 2015 at 10:28, Peter Maydell wrote: > On 11 November 2015 at 17:59, Markus Armbruster wrote: >> v2: Indentation touched up >> >> The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: >> >> Merge remote-tracking

Re: [Qemu-devel] [PATCH for-2.5 0/4] Expose ErrorClass through introspection

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > I noticed that introspection was not documenting either > qmp_capabilities nor the ErrorClass enum. I think this is worth > fixing for 2.5 when introspection is brand new, so that if we later > extend the ErrorClass enum or add future capability

Re: [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > If desired, I can prepare an alternate patch that adds the dash to the >> > qapi enum definition, to see what we think. >> >> If Gerd is fine with the rename, let's do it. > > No need to do so I think ... > >> >> -

Re: [Qemu-devel] [PATCH V3 0/6] ide: avoid main-loop hang on CDROM/NFS failure

2015-11-12 Thread Fam Zheng
On Fri, 11/06 09:42, Peter Lieven wrote: > This series aims at avoiding a hanging main-loop if a vserver has a > CDROM image mounted from a NFS share and that NFS share goes down. > Typical situation is that users mount an CDROM ISO to install something > and then forget to eject that CDROM

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Juan Quintela
"Li, Liang Z" wrote: >> On 12/11/2015 10:40, Li, Liang Z wrote: >> > I migrate a 8GB RAM Idle guest, I think most of it's pages are zero pages. >> > >> > I use your new code: >> > - >> >unsigned long *p = ... >> >if

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-11-12 Thread Bharata B Rao
On Thu, Nov 12, 2015 at 10:56:50AM +0100, Andreas Färber wrote: > > > I am hoping that I should be able to get CPU hotplug/unplug included > > in QEMU-2.6 timeframe. > > If there are preparatory patches ready for inclusion today, please point > me to them urgently. Thanks. I do have some

  1   2   3   4   >