Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

2017-05-19 Thread gengdongjiu
Michael, very sorry for the late response due to recently busy. On 2017/5/13 7:59, Michael S. Tsirkin wrote: > On Sun, Apr 30, 2017 at 01:35:03PM +0800, Dongjiu Geng wrote: >> This implements APEI GHES Table by passing the error cper info >> to the guest via a fw_cfg_blob. After a CPER info

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

2017-05-19 Thread gengdongjiu
Laszlo, sorry for the late response. On 2017/5/13 5:00, Laszlo Ersek wrote: > On 04/30/17 07:35, Dongjiu Geng wrote: >> This implements APEI GHES Table by passing the error cper info >> to the guest via a fw_cfg_blob. After a CPER info is added, an >> SEA/SEI exception will be injected into

[Qemu-devel] [Bug 888150] Re: qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2017-05-19 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/888150 Title: qemu and

Re: [Qemu-devel] [PATCH] oslib: strip trailing '\n' from error_setg() string argument

2017-05-19 Thread Philippe Mathieu-Daudé
On 05/17/2017 09:48 AM, Stefan Hajnoczi wrote: On Mon, May 15, 2017 at 09:11:49PM -0300, Philippe Mathieu-Daudé wrote: spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci Signed-off-by: Philippe Mathieu-Daudé --- util/oslib-posix.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] coccinelle: fix typo in comment

2017-05-19 Thread Philippe Mathieu-Daudé
On 05/16/2017 11:35 AM, Eric Blake wrote: On 05/15/2017 07:11 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/return_directly.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Did you intend for this to be threaded

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/2] hw/adc: Add basic Aspeed ADC model

2017-05-19 Thread Philippe Mathieu-Daudé
Hi Andrew, On 05/19/2017 09:26 PM, Andrew Jeffery wrote: This model implements enough behaviour to do basic functionality tests such as device initialisation and read out of dummy sample values. The sample value generation strategy is similar to the STM ADC already in the tree. Signed-off-by:

[Qemu-devel] [RFC 3/3] qmp: Include parent types on 'qom-list-types' output

2017-05-19 Thread Eduardo Habkost
Include list of parent types of each type on 'qom-list-types' output. Without this, there's no way to figure out the parents of a given type without making additional 'qom-list-types' queries. In addition to the test case for the new feature, update the abstract-interface test case to use the

[Qemu-devel] [RFC 2/3] qmp: Include 'abstract' field on 'qom-list-types' output

2017-05-19 Thread Eduardo Habkost
A client may be interested in getting the list of both abstract and non-abstract types. Instead of requiring them to make multiple queries with different filter arguments, just return an 'abstract' field in 'qom-list-types'. In addition to the new test code for validating this field, update the

[Qemu-devel] [RFC 1/3] tests: Simplify abstract-interfaces check with a helper

2017-05-19 Thread Eduardo Habkost
Add a new type_list_find() helper to device-introspect-test.c, to simplify the code at test_abstract_interfaces(). Signed-off-by: Eduardo Habkost --- tests/device-introspect-test.c | 43 -- 1 file changed, 25 insertions(+), 18

[Qemu-devel] [RFC 0/3] qmp: Return extra information on qom-list-types

2017-05-19 Thread Eduardo Habkost
This series adds 'abstract' and 'parent-types' fields to the output of qom-list-types. For reference, below are the sizes of the output of "qom-list-types abstract=true" on qemu-system-x86_64, before and after applying the patches: * before: 11724 bytes * with 'abstract' field: 20119 bytes *

Re: [Qemu-devel] [PATCH 0/2] hw/adc: Implement a basic Aspeed ADC model

2017-05-19 Thread Andrew Jeffery
On Fri, 2017-05-19 at 17:51 -0700, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/hw/adc/aspeed_adc.c:15:0: > /tmp/qemu-test/src/hw/adc/aspeed_adc.c: In function 'aspeed_adc_read': > /tmp/qemu-test/src/hw/adc/aspeed_adc.c:106:34: error: format '%lx' expects > argument of

Re: [Qemu-devel] Migration downtime more than 5s when migrating guest with massive disks

2017-05-19 Thread Yang Hongyang
On 2017/5/20 0:46, Paolo Bonzini wrote: > > > On 19/05/2017 14:17, Gonglei (Arei) wrote: >>> It would. Right now memory_region_transaction_commit() is roughly >>> O(n^2) (n devices * n BARs), and there are n of them. >>> >>> Reducing memory_region_transaction_commit to O(n) would be a large

[Qemu-devel] [PATCH 1/2] hw/adc: Add basic Aspeed ADC model

2017-05-19 Thread Andrew Jeffery
This model implements enough behaviour to do basic functionality tests such as device initialisation and read out of dummy sample values. The sample value generation strategy is similar to the STM ADC already in the tree. Signed-off-by: Andrew Jeffery --- hw/adc/Makefile.objs

[Qemu-devel] [PATCH 2/2] hw/arm: Integrate ADC model into Aspeed SoC

2017-05-19 Thread Andrew Jeffery
Signed-off-by: Andrew Jeffery --- hw/arm/aspeed_soc.c | 15 +++ include/hw/arm/aspeed_soc.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index 5c667d2c35b6..11f9588720d2 100644 --- a/hw/arm/aspeed_soc.c

[Qemu-devel] [PATCH 0/2] hw/adc: Implement a basic Aspeed ADC model

2017-05-19 Thread Andrew Jeffery
Hello, This short series introduces a basic model for the Aspeed ADC and glues it into the generic Aspeed SoC definition. The register interface is enhanced slightly from the AST2400 to the AST2500, but in a backwards-compatible way by making use of reserved bits. As such I haven't made any

Re: [Qemu-devel] [PATCH v2 0/9] QOM'ify work for sparc

2017-05-19 Thread Philippe Mathieu-Daudé
Hi Xiaoqiang, On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: This patch set aims for QOM'ifying code relate with sparc. It is part of my QOM'ify work of qemu code base. changes since v1: * rebased on the latest master xiaoqiang zhao (9): hw/misc: QOM'ify eccmemctl.c hw/dma: QOM'ify

Re: [Qemu-devel] [PATCH v2 6/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2017-05-19 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: assign DeviceClass::vmsd instead of using vmstate_register function Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé --- hw/timer/m48t59.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [Qemu-devel] [PATCH v2 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 1)

2017-05-19 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: * split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-19 Thread Thomas Huth
When you currently try to run a test directly from the command line without setting the QTEST_QEMU_BINARY environment variable first, you are presented with an unhelpful assertion message like this: ERROR:tests/libqtest.c:163:qtest_init_without_qmp_handshake: assertion failed: (qemu_binary !=

Re: [Qemu-devel] [PATCH v2 4/5] io: preserve ipv4/ipv6 flags when resolving InetSocketAddress

2017-05-19 Thread Philippe Mathieu-Daudé
On 05/19/2017 03:03 PM, Daniel P. Berrange wrote: The original InetSocketAddress struct may have has_ipv4 and has_ipv6 fields set, which will control both the ai_family used during DNS resolution, and later use of the V6ONLY flag. Currently the standalone DNS resolver code drops the has_ipv4 &

Re: [Qemu-devel] [PATCH v2 2/5] sockets: don't block IPv4 clients when listening on "::"

2017-05-19 Thread Philippe Mathieu-Daudé
On 05/19/2017 03:03 PM, Daniel P. Berrange wrote: When inet_parse() parses the hostname, it is forcing the has_ipv6 && ipv6 flags if the address contains a ":". This means that if the user had set the ipv4=on flag, to try to restrict the listener to just ipv4, an error would not have been

[Qemu-devel] [Bug 721825] Re: VDI block driver bugs

2017-05-19 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/721825 Title: VDI block driver bugs Status in QEMU: Triaged Bug description: Chunqiang

Re: [Qemu-devel] [PATCH v2 1/5] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-19 Thread Philippe Mathieu-Daudé
On 05/19/2017 03:03 PM, Daniel P. Berrange wrote: When binding to an IPv6 socket we currently force the IPV6_V6ONLY flag to off. This means that the IPv6 socket will accept both IPv4 & IPv6 sockets when QEMU is launched with something like -vnc :::1 While this is good for that case, it is

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-19 Thread John Snow
On 05/03/2017 08:25 AM, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] fsdev: fix virtfs-proxy-helper cwd

2017-05-19 Thread Eric Blake
On 05/19/2017 09:30 AM, Greg Kurz wrote: > Since chroot() doesn't change the current directory, it is indeed a good > practice to chdir() to the target directory and then then chroot(), or > to chroot() to the target directory and then chdir("/"). > > The current code does neither of them

Re: [Qemu-devel] [PATCH v0 0/6] move the tcg files into tcg directory.

2017-05-19 Thread Eric Blake
On 05/19/2017 02:30 AM, Yang Zhong wrote: > Move the tcg relative files into tcg directory, which will make > the code more clean in qemu. Titling a patch series v0 is a bit unusual (typically, the first version is untitled, and the second version is titled v2; 'git send-email -v2' can help).

Re: [Qemu-devel] [PATCH] block: Tweak error message related to qemu-img convert

2017-05-19 Thread Eric Blake
On 05/19/2017 08:30 AM, Max Reitz wrote: > On 2017-05-08 19:13, Eric Blake wrote: >> When converting a 1.1 image down to 0.10, qemu-iotests 060 forces >> a contrived failure where allocating a cluster used to replace a >> zero cluster reads unaligned data. Since it is a zero cluster >> rather

[Qemu-devel] [PATCH] migration: keep bytes_xfer_prev init'd to zero

2017-05-19 Thread Felipe Franciosi
The first time migration_bitmap_sync() is called, bytes_xfer_prev is set to ram_state.bytes_transferred which is, at this point, zero. The next time migration_bitmap_sync() is called, an iteration has happened and bytes_xfer_prev is set to 'x' bytes. Most likely, more than one second has passed,

[Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-05-19 Thread Felipe Franciosi
Currently, the throttle_thread_scheduled flag is reset back to 0 before sleeping (as part of the throttling logic). Given that throttle_timer (well, any timer) may tick with a slight delay, it so happens that under heavy throttling (ie. close or on CPU_THROTTLE_PCT_MAX) the tick may schedule a

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-19 Thread Michael S. Tsirkin
On Fri, May 19, 2017 at 05:00:37PM +0800, Wei Wang wrote: > > > > > > That being said, we compared to vhost-user, instead of vhost_net, > > > because vhost-user is the one > > > that is used in NFV, which we think is a major use case for vhost-pci. > > > > If this is true, why not draft a pmd

Re: [Qemu-devel] [PATCH RFC] virtio-net: enable configurable tx queue size

2017-05-19 Thread Michael S. Tsirkin
On Fri, May 19, 2017 at 10:32:19AM +0800, Wei Wang wrote: > This patch enables the virtio-net tx queue size to be configurable > between 256 (the default queue size) and 1024 by the user. The queue > size specified by the user should be power of 2. > > Setting the tx queue size to be 1024

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

2017-05-19 Thread Michael S. Tsirkin
On Fri, May 19, 2017 at 11:48:52AM +0200, Maxime Coquelin wrote: > > > On 05/18/2017 05:24 PM, Michael S. Tsirkin wrote: > > On Thu, May 18, 2017 at 04:45:23PM +0200, Maxime Coquelin wrote: > > > Hi Michael, > > > > > > On 05/18/2017 09:35 AM, Maxime Coquelin wrote: > > > > > > > > > > > > On

Re: [Qemu-devel] [Bug 721825] Re: VDI block driver bugs

2017-05-19 Thread Stefan Hajnoczi
On Fri, May 19, 2017 at 8:36 PM, Thomas Huth <721...@bugs.launchpad.net> wrote: > Is this still an issue with the latest version of QEMU, or could we > close this bug nowadays? A quick check of block/vdi.c shows that error handling is still lacking. Updates to in-memory data structures are not

[Qemu-devel] [Bug 917824] Re: qemu loops/hangs on extending qcow2-diskspace

2017-05-19 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/917824 Title: qemu loops/hangs on extending qcow2-diskspace Status in QEMU: Invalid Status in

[Qemu-devel] [Bug 924943] Re: usb-host devices given by command line are routed incomplete to the guest

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 959992] Re: segfault in apic_report_irq_delivered when booting tinycore_3.3.iso

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 1234179] Re: QEMU segfaults during Windows 7 unattended install

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 950692] Re: High CPU usage in Host (revisited)

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 721825] Re: VDI block driver bugs

2017-05-19 Thread Thomas Huth
Is this still an issue with the latest version of QEMU, or could we close this bug nowadays? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 726619] Re: loadvm does not load (offline) snapshot anymore

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 796202] Re: Doing a 64 bit load from a 32 bit local APIC register is allowed

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 757702] Re: ARM: singlestepping insn which UNDEFs should stop at UNDEF vector insn, not after it

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 752476] Re: monitor command mouse_button 1 moves mouse

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you somehow still reproduce this problem with the latest version of QEMU (currently v2.9), or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

2017-05-19 Thread Richard W.M. Jones
On Fri, May 19, 2017 at 04:41:46PM -0300, Eduardo Habkost wrote: > On Tue, May 09, 2017 at 07:18:07AM -0700, Richard Henderson wrote: > > On 05/09/2017 07:13 AM, Richard W.M. Jones wrote: > > > On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote: > > > > > Daniel P. Berrange (2): > >

Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

2017-05-19 Thread Richard W.M. Jones
On Fri, May 19, 2017 at 04:41:46PM -0300, Eduardo Habkost wrote: > On Tue, May 09, 2017 at 07:18:07AM -0700, Richard Henderson wrote: > > On 05/09/2017 07:13 AM, Richard W.M. Jones wrote: > > > On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote: > > > > > Daniel P. Berrange (2): > >

Re: [Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validated

2017-05-19 Thread Eduardo Habkost
On Fri, May 19, 2017 at 04:58:23PM +0200, Kashyap Chamarthy wrote: > On Tue, May 09, 2017 at 02:27:35PM +0100, Daniel P. Berrange wrote: > > Change the nested if statements into a flat format, to make > > it clearer what validation / capping is being performed on > > different CPUID index values.

Re: [Qemu-devel] [PATCH] xhci: bump the link TRB cycle detection limit.

2017-05-19 Thread anonym
Gentle ping! :) I've lost the Message-IDs of my previous posts on this topic but its about this patch submission: * https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03433.html * https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03434.html Cheers! > Hi, list! > > I guess

Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

2017-05-19 Thread Eduardo Habkost
On Tue, May 09, 2017 at 07:18:07AM -0700, Richard Henderson wrote: > On 05/09/2017 07:13 AM, Richard W.M. Jones wrote: > > On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote: > > > > Daniel P. Berrange (2): > > > >i386: rewrite way CPUID index is validated > > > >i386:

Re: [Qemu-devel] [PATCH RFC 4/6] migration: shut src return path unconditionally

2017-05-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > We were do the shutting off only for postcopy. Now we do this as long as > the source return path is there. > > Moving the cleanup of from_src_file there too. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH V5 8/9] migration: add postcopy total blocktime into query-migrate

2017-05-19 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Postcopy total blocktime is available on destination side only. > But query-migrate was possible only for source. This patch > adds ability to call query-migrate on destination. To distinguish > src/dst, state of the MigrationState is using,

Re: [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types

2017-05-19 Thread Eduardo Habkost
On Thu, May 18, 2017 at 01:59:53PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Currently there's no way for QMP clients to get a list of device types > > that are really usable with -device. This information would be useful > > for management software

Re: [Qemu-devel] [PATCH V5 7/9] migration: calculate vCPU blocktime on dst side

2017-05-19 Thread Dr. David Alan Gilbert
* Alexey (a.pereva...@samsung.com) wrote: > On Tue, May 16, 2017 at 12:34:16PM +0100, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > This patch provides blocktime calculation per vCPU, > > > as a summary and as a overlapped value for all vCPUs. > > > >

Re: [Qemu-devel] [PATCH V5 4/9] migration: split ufd_version_check onto receive/request features part

2017-05-19 Thread Dr. David Alan Gilbert
* Alexey (a.pereva...@samsung.com) wrote: > On Tue, May 16, 2017 at 11:32:51AM +0100, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > This modification is necessary for userfault fd features which are > > > required to be requested from userspace. > > >

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, May 19, 2017 at 03:33:12PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > shutdown() is safe, in that it stops any other threads accessing the fd > > > > but doesn't allow it's

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/19/2017 07:28 PM, Dr. David Alan Gilbert wrote: > >> To sum it up although I'm currently leaning towards abandoning my idea > >> of two sections for two devices, I'm not comfortable with making the > >> call myself. I'm hoping for some

[Qemu-devel] [PATCH v2 5/5] tests: add functional test validating ipv4/ipv6 address flag handling

2017-05-19 Thread Daniel P. Berrange
The semantics around handling ipv4=on|off & ipv6=on|off are quite subtle to understand in combination with the various hostname addresses and backend types. Introduce a massive test matrix that launches QEMU and validates the ability to connect a client on each protocol as appropriate. The test

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 07:47 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: We could also consider making WITH_TMP act as a normal field. Working on the whole state looks like a bit like a

[Qemu-devel] [PATCH v2 4/5] io: preserve ipv4/ipv6 flags when resolving InetSocketAddress

2017-05-19 Thread Daniel P. Berrange
The original InetSocketAddress struct may have has_ipv4 and has_ipv6 fields set, which will control both the ai_family used during DNS resolution, and later use of the V6ONLY flag. Currently the standalone DNS resolver code drops the has_ipv4 & has_ipv6 flags after resolving, which means the

[Qemu-devel] [PATCH v2 3/5] sockets: ensure we don't accept IPv4 clients when IPv4 is disabled

2017-05-19 Thread Daniel P. Berrange
Currently if you disable listening on IPv4 addresses, via the CLI flag ipv4=off, we still mistakenly accept IPv4 clients via the IPv6 listener socket due to IPV6_V6ONLY flag being unset. We must ensure IPV6_V6ONLY is always set if ipv4=off This fixes the following scenarios -incoming

[Qemu-devel] [PATCH v2 2/5] sockets: don't block IPv4 clients when listening on "::"

2017-05-19 Thread Daniel P. Berrange
When inet_parse() parses the hostname, it is forcing the has_ipv6 && ipv6 flags if the address contains a ":". This means that if the user had set the ipv4=on flag, to try to restrict the listener to just ipv4, an error would not have been raised. eg -incoming tcp:[::]:9000,ipv4 should have

[Qemu-devel] [PATCH v2 0/5] Fix handling of IPv4/IPv6 dual stack

2017-05-19 Thread Daniel P. Berrange
This is a (much larger) followup to: v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg05659.html This series aims to fix a lot of bugs related to handling of IPv4 / IPv6 dual stack. - The VNC server mistakenly listened on two separate ports 5900+5901 when the to= parameter

[Qemu-devel] [PATCH v2 1/5] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-19 Thread Daniel P. Berrange
When binding to an IPv6 socket we currently force the IPV6_V6ONLY flag to off. This means that the IPv6 socket will accept both IPv4 & IPv6 sockets when QEMU is launched with something like -vnc :::1 While this is good for that case, it is bad for other cases. For example if an empty hostname

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

2017-05-19 Thread Halil Pasic
On 05/19/2017 07:28 PM, Dr. David Alan Gilbert wrote: >> To sum it up although I'm currently leaning towards abandoning my idea >> of two sections for two devices, I'm not comfortable with making the >> call myself. I'm hoping for some maintainer guidance (s390x, virtio >> and migration). >

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > >> We could also consider making WITH_TMP act as a normal field. > >> Working on the whole state looks like a bit like a corner case: > >> we have some stuff adjacent in the migration

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: > >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >

Re: [Qemu-devel] [PATCH v12 2/2] migration: spapr: migrate pending_events of spapr state

2017-05-19 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-05-19 09:27:50) > From: Jianjun Duan > > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started. In this case the

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/15/2017 09:07 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/08/2017 08:42 PM, Dr. David Alan Gilbert wrote: > >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >

Re: [Qemu-devel] [PATCH v4 10/10] vhost: iommu: cache static mapping if there is

2017-05-19 Thread Michael S. Tsirkin
On Fri, May 19, 2017 at 11:19:49AM +0800, Peter Xu wrote: > This patch pre-heat vhost iotlb cache when passthrough mode enabled. > > Sometimes, even if user specified iommu_platform for vhost devices, > IOMMU might still be disabled. One case is passthrough mode in VT-d > implementation. We can

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-19 Thread Michael S. Tsirkin
On Fri, May 19, 2017 at 11:10:33AM +0800, Jason Wang wrote: > > > On 2017年05月18日 11:03, Wei Wang wrote: > > On 05/17/2017 02:22 PM, Jason Wang wrote: > > > > > > > > > On 2017年05月17日 14:16, Jason Wang wrote: > > > > > > > > > > > > On 2017年05月16日 15:12, Wei Wang wrote: > > > > > > > > > > >

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-19 Thread Michael S. Tsirkin
On Fri, May 19, 2017 at 03:46:36PM +0800, Jason Wang wrote: > > > On 2017年05月18日 16:43, Maxime Coquelin wrote: > > > > > > > > +When the VHOST_USER_PROTOCOL_F_SLAVE_REQ is supported by the > > > > slave, and the > > > > +master initiated the slave to master communication channel using the > > >

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: >> We could also consider making WITH_TMP act as a normal field. >> Working on the whole state looks like a bit like a corner case: >> we have some stuff adjacent in the migration stream, and we have >> to map it on multiple fields (and

[Qemu-devel] [PULL] Update OpenBIOS images

2017-05-19 Thread Mark Cave-Ayland
Hi Stefan, This update contains the OpenBIOS VGA driver updates required to enable Ben's QemuMacDrivers for Mac guests. Please pull. ATB, Mark. The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into

Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19

2017-05-19 Thread Paolo Bonzini
On 19/05/2017 17:51, Stefan Hajnoczi wrote: >> This series seems to have some coding style problems. See output below for >> more information: > Yikes, on second thought I've dropped the pull request for now. > > Please look at these coding style violations. These are just a sample program, so

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > *

Re: [Qemu-devel] [PULL 0/3] audio patch queue.

2017-05-19 Thread Stefan Hajnoczi
tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-audio-20170519-1 > > for you to fetch changes up to 8a824e4d74213a2da39323304f949c5b4243e1fb

Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19

2017-05-19 Thread Stefan Hajnoczi
On Fri, May 19, 2017 at 05:41:28AM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: Yikes, on second thought I've dropped the pull request for now. Please look at these coding style violations. Thanks,

Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19

2017-05-19 Thread Stefan Hajnoczi
On Fri, May 19, 2017 at 01:20:52PM +0200, Paolo Bonzini wrote: > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git repository

Re: [Qemu-devel] [PULL 0/1] ui: egl-headless requires dmabuf support

2017-05-19 Thread Stefan Hajnoczi
ing branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-ui-20170519-1 > > for you to fetch changes up to 371ec54e9f8415cd74af45acdcf67b413f50cce5: > >

Re: [Qemu-devel] [PULL 00/18] Migration pull request

2017-05-19 Thread Stefan Hajnoczi
On Thu, May 18, 2017 at 07:24:44PM +0200, Juan Quintela wrote: > Hi > > This include the following series: > - Fix non-multiple of page size migraition (dave) > - Remove use of old MigrationParms (a.k.a. now block migration is a > capability) > - Cleanups of headers in migration > - Make

Re: [Qemu-devel] [PATCH v2 0/9] QOM'ify work for sparc

2017-05-19 Thread Mark Cave-Ayland
On 29/04/17 11:49, xiaoqiang zhao wrote: > This patch set aims for QOM'ifying code relate with sparc. > It is part of my QOM'ify work of qemu code base. > > changes since v1: > * rebased on the latest master > > xiaoqiang zhao (9): > hw/misc: QOM'ify eccmemctl.c > hw/dma: QOM'ify

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-19 Thread Stefan Hajnoczi
On Fri, May 19, 2017 at 11:10:33AM +0800, Jason Wang wrote: > On 2017年05月18日 11:03, Wei Wang wrote: > > On 05/17/2017 02:22 PM, Jason Wang wrote: > > > On 2017年05月17日 14:16, Jason Wang wrote: > > > > On 2017年05月16日 15:12, Wei Wang wrote: > > > > > > Hi: > > > > > > > > > > > > Care to post the

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > Dave > P.S. I'm out for about a week. Thanks for the info! Could you say something about our 'two devices two sections vs two devices one section' dilemma form PATCH 06/10 before leaving? I do not want to be pushy, but I'm also eager to

Re: [Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validated

2017-05-19 Thread Kashyap Chamarthy
On Tue, May 09, 2017 at 02:27:35PM +0100, Daniel P. Berrange wrote: > Change the nested if statements into a flat format, to make > it clearer what validation / capping is being performed on > different CPUID index values. > > NB this changes behaviour when "index > env->cpuid_xlevel2". > This

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > As a

[Qemu-devel] [PATCH 2/2] util: drop old utimensat() compat code

2017-05-19 Thread Greg Kurz
Now that 9pfs and virtfs-proxy-helper have been converted to utimensat(), we don't need to keep qemu_utimens() anymore. Signed-off-by: Greg Kurz --- configure | 22 - include/sysemu/os-posix.h | 11 --- util/oslib-posix.c|

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Daniel P. Berrange
On Fri, May 19, 2017 at 03:33:12PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > shutdown() is safe, in that it stops any other threads accessing the fd > > > but doesn't allow it's reallocation until the close; We perform the > > > close only when

[Qemu-devel] [PATCH 1/2] 9pfs: assume utimensat() and futimens() are present

2017-05-19 Thread Greg Kurz
The utimensat() and futimens() syscalls have been around for ages (ie, glibc 2.6 and linux 2.6.22), and the decision was already taken to switch to utimensat() anyway when fixing CVE-2016-9602 in 2.9. Signed-off-by: Greg Kurz --- fsdev/virtfs-proxy-helper.c |3 ++-

[Qemu-devel] [PATCH 0/2] get rid of qemu_utimens()

2017-05-19 Thread Greg Kurz
It is currently only used by 9pfs and virtfs-proxy-helper. This series convert them to utimensat() and futimens(). -- Greg --- Greg Kurz (2): 9pfs: assume utimensat() and futimens() are present util: drop old utimensat() compat code configure | 22

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, May 19, 2017 at 02:02:00PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Fri, May 19, 2017 at 01:51:43PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrange

[Qemu-devel] [PATCH] fsdev: fix virtfs-proxy-helper cwd

2017-05-19 Thread Greg Kurz
Since chroot() doesn't change the current directory, it is indeed a good practice to chdir() to the target directory and then then chroot(), or to chroot() to the target directory and then chdir("/"). The current code does neither of them actually. Let's go for the latter. This doesn't fix any

[Qemu-devel] [PATCH v12 0/2] pseries: migrate pending_events of spapr state

2017-05-19 Thread Daniel Henrique Barboza
NOTE: At the moment I am sending this v12, patch 1 isn't available in dgibson/ppc-for-2.10 branch yet. I am resending it here, unchanged, just to allow patch 2 to be applied cleanly. v12: - patch 2: added a switch statement to get the proper data_size based on the log_type v11: - patch 1 (new):

[Qemu-devel] [PATCH v12 2/2] migration: spapr: migrate pending_events of spapr state

2017-05-19 Thread Daniel Henrique Barboza
From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target

[Qemu-devel] [PATCH v12 1/2] hw/ppc/spapr_events.c: removing 'exception' from sPAPREventLogEntry

2017-05-19 Thread Daniel Henrique Barboza
Currenty we do not have any RTAS event that is reported by the event-scan interface. The existing events, RTAS_LOG_TYPE_EPOW and RTAS_LOG_TYPE_HOTPLUG, are being reported by the check-exception interface and, as such, marked as 'exception=true'. Commit 79853e18d9, 'spapr_events: event-scan RTAS

Re: [Qemu-devel] Migration downtime more than 5s when migrating guest with massive disks

2017-05-19 Thread Gonglei (Arei)
Oops, forgot to CC qemu-devel, add it. > -Original Message- > From: Gonglei (Arei) > Sent: Friday, May 19, 2017 8:17 PM > To: 'Paolo Bonzini'; yanghongyang; m...@redhat.com > Cc: quint...@redhat.com; Dr. David Alan Gilbert; Huangzhichao > Subject: RE: Migration downtime more than 5s when

[Qemu-devel] A problem of IRQchip in QEMU and KVM for ARM

2017-05-19 Thread Li Zhang
Hi, I am looking into QEMU code in ARM recently and trying to add add_hot_cpu in QEMU for ARM, but it doesn't work when enabling KVM. It reports error: "kvm_init_vcpu failed: Device or resourc busy." By debugging QEMU with gdb, it failed on ioctl. In kernel soruce code arch/arm/kvm/arm.c, vcpu

Re: [Qemu-devel] [PATCH] e1000e: Fix a bug where guest hangs upon migration

2017-05-19 Thread Sameeh Jubran
On Fri, May 19, 2017 at 9:25 AM, Jason Wang wrote: > > > On 2017年05月17日 19:46, Sameeh Jubran wrote: > >> The bug was caused by the "receive overrun" (bit #6 of the ICR register) >> interrupt >> which would be triggered post migration in a heavy traffic environment. >> Even

Re: [Qemu-devel] [PATCH] linux-user: remove all traces of qemu from /proc/self/cmdline

2017-05-19 Thread Riku Voipio
On Mon, Mar 20, 2017 at 12:31:55PM +0100, Andreas Schwab wrote: > Instead of post-processing the real contents use the remembered target > argv. That removes all traces of qemu, including command line options, > and handles QEMU_ARGV0. Applied to Linux-user, thanks Riku > Signed-off-by:

Re: [Qemu-devel] [PATCH] linux-user: Fix TARGET_MAP* and TARGET_F_??LCK for hppa arch

2017-05-19 Thread Riku Voipio
On Sun, Mar 12, 2017 at 08:17:46AM +1000, Richard Henderson wrote: > On 03/12/2017 03:50 AM, Helge Deller wrote: > >TARGET_MAP_TYPE needs to be 0x03 instead of 0x0f on the hppa > >architecture, otherwise it conflicts with MAP_FIXED which is 0x04. > > > >Add missing TARGET_MAP_STACK and

Re: [Qemu-devel] [PATCH 0/2] linux-user: fix eventfd()

2017-05-19 Thread Riku Voipio
On Tue, Apr 25, 2017 at 06:32:30PM +0200, Laurent Vivier wrote: > Ping? Applied, thanks. > Laurent > > Le 01/03/2017 à 10:37, Laurent Vivier a écrit : > > This patch series byte-swap the uint64_t data stream > > of a file-descriptor opened with eventfd(). > > > > It allows to pass more LTP

Re: [Qemu-devel] [PATCH] block: Tweak error message related to qemu-img convert

2017-05-19 Thread Max Reitz
On 2017-05-08 19:13, Eric Blake wrote: > When converting a 1.1 image down to 0.10, qemu-iotests 060 forces > a contrived failure where allocating a cluster used to replace a > zero cluster reads unaligned data. Since it is a zero cluster > rather than a data cluster being converted, changing the

  1   2   3   >