[Qemu-devel] [PATCH qemu v7 1/4] linux-headers: update to f1517df8701c

2018-02-08 Thread Alexey Kardashevskiy
Update headers against f1517df8701c. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f1517df8701c Signed-off-by: Alexey Kardashevskiy -- Pulled because of new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE --- include/standard-headers/linux/input-event-codes.h | 1 + includ

[Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-02-08 Thread Alexey Kardashevskiy
At the moment if vfio_memory_listener is registered in the system memory address space, it maps/unmaps every RAM memory region for DMA. It expects system page size aligned memory sections so vfio_dma_map would not fail and so far this has been the case. A mapping failure would be fatal. A side effe

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-08 Thread Viktor Mihajlovski
On 08.02.2018 21:33, Eduardo Habkost wrote: > On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: > [...] >> The "halted" field is somewhat controversial. On the one hand, >> it offers a convenient way to know if a guest CPU is idle or >> running. On the other hand, it's a field that c

[Qemu-devel] [PATCH qemu v7 3/4] vfio-pci: Allow mmap of MSIX BAR

2018-02-08 Thread Alexey Kardashevskiy
At the moment we unconditionally avoid mapping MSIX data of a BAR and emulate MSIX table in QEMU. However it is 1) not always necessary as a platform may prodive a paravirt interface for MSIX configuration; 2) can affect the speed of MMIO access by emulating them in QEMU when frequently accessed re

[Qemu-devel] [PATCH qemu v7 0/4] vfio-pci: Allow mmap of MSIX BAR

2018-02-08 Thread Alexey Kardashevskiy
Here is my latest patchset to allow mapping of MSIX BAR to the guest in order to accelerate MMIO on certains devices. This is based on sha1 008a51b Peter Maydell "Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging". Please comment. Thanks. Changes: v7: * split in

[Qemu-devel] [PATCH qemu v7 4/4] ppc/spapr, vfio: Turn off MSIX emulation for VFIO devices

2018-02-08 Thread Alexey Kardashevskiy
This adds a possibility for the platform to tell VFIO not to emulate MSIX so MMIO memory regions do not get split into chunks in flatview and the entire page can be registered as a KVM memory slot and make direct MMIO access possible for the guest. This enables the entire MSIX BAR mapping to the g

Re: [Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-08 Thread David Engraf
Hello David, Am 09.02.2018 um 06:33 schrieb David Gibson: On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote: This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image and

Re: [Qemu-devel] [PATCH v1] Implement support for IEEE 754-201x minimumNumber/maximumNumber

2018-02-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1518046997-22714-1-git-send-email-...@sifive.com Subject: [Qemu-devel] [PATCH v1] Implement support for IEEE 754-201x minimumNumber/maximumNumber === TEST SCRIPT BEGIN === #

Re: [Qemu-devel] [PATCH v5 12/23] RISC-V HTIF Console

2018-02-08 Thread Michael Clark
On Fri, Feb 9, 2018 at 5:35 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 02/07/2018 05:28 PM, Michael Clark wrote: > > +++ b/hw/riscv/riscv_elf.c > > @@ -0,0 +1,244 @@ > > +/* > > + * elf.c - A simple package for manipulating symbol tables in elf > binaries. > > + * > > + * Ta

Re: [Qemu-devel] [V9fs-developer] [RFC] we should solve create-unlink-getattr idiom

2018-02-08 Thread Veaceslav Falico
Hi Yiwen, all, On 2/9/2018 8:10 AM, jiangyiwen wrote: > Hi Eric and Greg, > > I encountered the similar problem with create-unlink-getattr idiom. > I use the testcase that create-unlink-setattr idiom, and I see the > bug is reported at https://bugs.launchpad.net/qemu/+bug/1336794. > Then I also s

Re: [Qemu-devel] [RFC PATCH 5/5] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-02-08 Thread Peter Xu
On Tue, Feb 06, 2018 at 05:26:46PM -0700, Alex Williamson wrote: > With vfio ioeventfd support, we can program vfio-pci to perform a > specified BAR write when an eventfd is triggered. This allows the > KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding > userspace handling for thes

[Qemu-devel] [V9fs-developer] [RFC] we should solve create-unlink-getattr idiom

2018-02-08 Thread jiangyiwen
Hi Eric and Greg, I encountered the similar problem with create-unlink-getattr idiom. I use the testcase that create-unlink-setattr idiom, and I see the bug is reported at https://bugs.launchpad.net/qemu/+bug/1336794. Then I also see you already fix the issue and push the patch to upstream. https:

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-02-08 Thread Fam Zheng
On Thu, Jan 18, 2018 at 5:07 PM, Amador Pahim wrote: > Expanding on that, the vmimage lib downloads and caches the so called > "cloud images" from distros own repositories. Here's[1] some > documentation with usage examples, including one example on how to add > your own image provider. Linux dis

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-02-08 Thread Peter Xu
On Tue, Feb 06, 2018 at 05:08:14PM -0700, Alex Williamson wrote: [...] > +long vfio_pci_ioeventfd(struct vfio_pci_device *vdev, loff_t offset, > + uint64_t data, int count, int fd) > +{ > + struct pci_dev *pdev = vdev->pdev; > + loff_t pos = offset & VFIO_PCI_OFFSET_MA

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Peter Xu
On Thu, Feb 08, 2018 at 06:31:04PM +0800, Peter Xu wrote: > Tree is pushed here for better reference and testing (online tree > includes monitor OOB series): > > https://github.com/xzpeter/qemu/tree/postcopy-recovery-support Hello, Patchew, Based-on: <20180124053957.29145-1-pet...@redhat.com>

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Fam Zheng
On Fri, Feb 9, 2018 at 2:07 PM, Peter Xu wrote: > On Thu, Feb 08, 2018 at 03:25:21AM -0800, no-re...@patchew.org wrote: >> Hi, >> >> This series failed docker-mingw@fedora build test. Please find the testing >> commands and >> their output below. If you have Docker installed, you can probably rep

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Peter Xu
On Thu, Feb 08, 2018 at 03:25:21AM -0800, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. For all the five patchew repor

Re: [Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-08 Thread David Gibson
On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote: > This patch fixes an incorrect behavior when the -kernel argument has been > specified without -bios. In this case the kernel was loaded twice. At address > 32M as a raw image and afterwards by load_elf/load_uimage at the > correspondin

[Qemu-devel] [PATCH v7 3/3] docs: Document share-rw property more thoroughly

2018-02-08 Thread Fam Zheng
Suggested-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- docs/qemu-block-drivers.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/qemu-block-drivers.texi b/docs/qemu-block-drivers.texi index cd74767ed3..f1793692bb 100644 --- a/docs/qemu-block-drivers.texi +++ b/docs/qe

[Qemu-devel] [PATCH v7 1/3] qemu-img.texi: Clean up parameter list

2018-02-08 Thread Fam Zheng
Split options out of the "@table @var" section and create a "@table @option", then use whitespaces and blank lines consistently. Suggested-by: Kevin Wolf Signed-off-by: Fam Zheng --- qemu-img.texi | 66 +++ 1 file changed, 39 insertions(+)

[Qemu-devel] [PATCH v7 0/3] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
v7: Tweak wording again "allowing concurrent writers" -> "allowing other QEMU processes to open it in write mode". [Eric, Stefan, Kevin] Add patch to document share-rw. [Stefan] v6: Tweak wording ("concurrent writers"). [Max] Fam Zheng (3): qemu-img.texi: Clean up parameter list qemu-

[Qemu-devel] [PATCH v7 2/3] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img.texi | 8 1 file changed, 8 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 60a0e080c6..8a26400adb 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -86,6 +86,14 @@ exclusive with the @var{-O} parameters. It

[Qemu-devel] [PULL v3 00/20] Miscellaneous patches for 2018-02-07

2018-02-08 Thread Markus Armbruster
The following changes since commit 008a51bbb343972dd8cf09126da8c3b87f4e1c96: Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging (2018-02-08 14:31:51 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2018-02-07-v3

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

Re: [Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit

2018-02-08 Thread Wanpeng Li
2018-02-09 2:12 GMT+08:00 Eduardo Habkost : > On Thu, Feb 08, 2018 at 05:44:20PM +0800, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Add PV_DEDICATED hint cpuid feature bit. >> > [...] >> diff --git a/target/i386/cpu.c b/target/i386/cpu.c >> index d70954b..cf48931 100644 >> --- a/target/i386/cpu.c

Re: [Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support

2018-02-08 Thread Wei Wang
On 02/09/2018 04:15 AM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the c

Re: [Qemu-devel] [PATCH 00/10] linux-user: Speed up guest space initialization on 32-bit ARM target

2018-02-08 Thread Luke Shumaker
Ping. On Thu, 28 Dec 2017 13:08:03 -0500, Luke Shumaker wrote: > > From: Luke Shumaker > > The goal of this patchset is to fix > https://bugs.launchpad.net/qemu/+bug/1740219 > > The gist is that the current linear search for an acceptable address > range is a bad strategy when the reason we di

Re: [Qemu-devel] [PATCH 3/3] build-sys: enable sanitizers by default with --enable-debug

2018-02-08 Thread Fam Zheng
On Thu, 02/08 20:03, Marc-André Lureau wrote: > Hi > > On Thu, Feb 8, 2018 at 6:46 PM, Paolo Bonzini wrote: > > On 08/02/2018 17:23, Marc-André Lureau wrote: > >> The original commit 247724cb302af5d70c8853154b640dfabf2bbb56 was meant > >> to enable sanitizers by default when --enable-debug, but f

Re: [Qemu-devel] [PATCH] block: unify blocksize types

2018-02-08 Thread Fam Zheng
On Thu, 02/08 14:28, Piotr Sarna wrote: > BlockSizes structure used in block size probing has uint32_t types > for logical and physical sizes. These fields are wrongfully assigned > to uint16_t in BlockConf, which results, among other errors, > in assigning 0 instead of 65536 (which will be the cas

[Qemu-devel] [Resend][PATCH] qga: unset frozen state if no mount points are frozen

2018-02-08 Thread Chen Hanxiao
From: Chen Hanxiao If we set mountpoints to qmp_guest_fsfreeze_freeze_list, we may got nothing to freeze as all mountpoints are not valid. Call ga_unset_frozen in this senario. Cc: Michael Roth Signed-off-by: Chen Hanxiao --- Rebase on master qga/commands-posix.c | 6 ++ 1 file changed,

[Qemu-devel] [PATCH 10/54] vfio: Fix vfio-kvm group registration

2018-02-08 Thread Michael Roth
From: Alex Williamson Commit 8c37faa475f3 ("vfio-pci, ppc64/spapr: Reorder group-to-container attaching") moved registration of groups with the vfio-kvm device from vfio_get_group() to vfio_connect_container(), but it missed the case where a group is attached to an existing container and takes an

Re: [Qemu-devel] [PATCH 1/2] hw/arm/aspeed: directly map the serial device to the system address space

2018-02-08 Thread Andrew Jeffery
On Thu, 2018-02-08 at 14:40 -0300, Philippe Mathieu-Daudé wrote: > On 02/08/2018 02:30 PM, Peter Maydell wrote: > > On 8 February 2018 at 17:22, Philippe Mathieu-Daudé wrote: > > > Signed-off-by: Philippe Mathieu-Daudé > > > --- > > > hw/arm/aspeed_soc.c | 2 +- > > > 1 file changed, 1 insertion

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:43:03PM -0800, Andrey Smirnov wrote: > On Thu, Feb 8, 2018 at 12:33 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: > >> On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin > >> wrote: > >> > On Thu, Feb 08, 2018 at 12:

Re: [Qemu-devel] [PATCH v3 06/18] sdcard: simplify using the ldst API

2018-02-08 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > the code is easier to review/refactor. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 38 +- > 1 file changed, 9 insertions(+), 29 delet

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-02-08 Thread Alistair Francis
On Thu, Feb 8, 2018 at 3:38 PM, Alistair Francis wrote: > On Mon, Feb 5, 2018 at 8:34 AM, Cleber Rosa wrote: >> >> >> On 02/01/2018 07:10 PM, Alistair Francis wrote: >>> On Wed, Jan 17, 2018 at 4:47 PM, Cleber Rosa wrote: On 01/17/2018 06:41 PM, Alistair Francis wrote: > On We

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-02-08 Thread Alistair Francis
On Mon, Feb 5, 2018 at 8:34 AM, Cleber Rosa wrote: > > > On 02/01/2018 07:10 PM, Alistair Francis wrote: >> On Wed, Jan 17, 2018 at 4:47 PM, Cleber Rosa wrote: >>> >>> >>> On 01/17/2018 06:41 PM, Alistair Francis wrote: On Wed, Jan 17, 2018 at 12:05 AM, Cleber Rosa wrote: > TL;DR >

Re: [Qemu-devel] [PATCH] hw/char/stm32f2xx_usart: improve TXE/TC bit handling

2018-02-08 Thread Alistair Francis
On Thu, Feb 8, 2018 at 6:58 AM, Peter Maydell wrote: > On 4 February 2018 at 20:41, Richard Braun wrote: >> Consider that data is always immediately sent. As a result, keep >> the SR_TXE and SR_TC bits always set. In addition, fix the reset value >> of the USART status register. > > Do you know w

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

2018-02-08 Thread David Gibson
On Thu, Feb 01, 2018 at 12:51:04PM +0100, BALATON Zoltan wrote: > On Wed, 31 Jan 2018, David Gibson wrote: > > On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote: > > > This matches what other files do for qemu includes > > > > > > Signed-off-by: BALATON Zoltan > > > > Applied, thank

Re: [Qemu-devel] [PATCH 04/27] qcow2: Pass BlockdevCreateOptions to qcow2_create2()

2018-02-08 Thread Eric Blake
On 02/08/2018 01:23 PM, Kevin Wolf wrote: All of the simple options are now passed to qcow2_create2() in a BlockdevCreateOptions object. Still missing: node-name and the encryption options. Signed-off-by: Kevin Wolf --- block/qcow2.c | 190 ++---

Re: [Qemu-devel] [PATCH] spapr: add missing break in h_get_cpu_characteristics()

2018-02-08 Thread David Gibson
On Thu, Feb 01, 2018 at 08:47:41PM +0100, Greg Kurz wrote: > Detected by Coverity (CID 1385702). This fixes the recently added hypercall > to let guests properly apply Spectre and Meltdown workarounds. > > Fixes: c59704b25473 "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS" > Signed-off-by

Re: [Qemu-devel] [PATCH v2] spapr: check smp_threads <= vsmt

2018-02-08 Thread David Gibson
On Thu, Feb 08, 2018 at 10:42:41AM +0100, Laurent Vivier wrote: > We ignore silently the value of smp_threads when we set > the default VSMT value, and if smp_threads is greater than VSMT > kernel is going into trouble later. > > Fixes: 8904e5a750 > ("spapr: Adjust default VSMT value for better mi

Re: [Qemu-devel] [PATCH 02/27] block/qapi: Add qcow2 create options to schema

2018-02-08 Thread Eric Blake
On 02/08/2018 01:23 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- qapi/block-core.json | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index b59b1430bb..aade602a04 100644 --- a/

Re: [Qemu-devel] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions

2018-02-08 Thread Eric Blake
On 02/08/2018 01:23 PM, Kevin Wolf wrote: This creates a BlockdevCreateOptions union type that will contain all of the options for image creation. We'll start out with an empty struct type BlockdevCreateDummy for all drivers. Name here... Signed-off-by: Kevin Wolf --- qapi/block-core.json

Re: [Qemu-devel] [PATCH 14/14] tests/boot-serial-test: Add support for the aarch64 virt machine

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: From: Wei Huang This patch adds a small binary kernel to test aarch64 virt machine's UART. Signed-off-by: Wei Huang [thuth: Fixed contextual conflict with the hppa patch] Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/boot-s

Re: [Qemu-devel] [PATCH 00/14] qtest patches

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: Here's a set of qtest patches that have been posted to the list before and are IMHO ready for inclusion. I've included the patches from Eric's "Preliminary libqtest cleanups" series that do not need major reworks (the rest needs some more love later), an

Re: [Qemu-devel] [PATCH v2 22/32] arm/translate-a64: add FP16 FNEG/FABS to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > +case 0x2f: /* FABS */ > +gen_helper_advsimd_absh(tcg_res, tcg_op); > +break; > +case 0x6f: /* FNEG */ > +tcg_gen_xori_i32(tcg_res, tcg_op, 0x8000); > +break; Why is

Re: [Qemu-devel] [PATCH v2 21/32] arm/translate-a64: add FP16 SCVTF/UCVFT to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > I've re-factored the handle_simd_intfp_conv helper to properly handle > half-precision as well as call plain conversion helpers when we are > not doing fixed point conversion. > > Signed-off-by: Alex Bennée > --- > target/arm/helper.c| 4 ++

Re: [Qemu-devel] [PATCH 13/14] tests/boot-serial: Add tests for PowerPC Mac machines

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: OpenBIOS prints out the CPU type on these machine types, so we can use this string to test whether the CPU detection is working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/boot-serial-test.c | 3 +++ 1 file changed, 3

Re: [Qemu-devel] [PATCH 12/14] tests/boot-serial: Enable the boot-serial test on SPARC machines, too

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: OpenBIOS prints out the name of the detected CPU here, so looking for this string is a nice test to verify that the CPU detection is still working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++

Re: [Qemu-devel] [PATCH v2 20/32] arm/translate-a64: add FP16 FCMxx (zero) to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > +maxpasses = hp ? (is_q ? 8 : 4) : (is_q ? 4 : 2); (8 << is_q) >> size ? > +read_vec_element_i32(s, tcg_op, rn, pass, hp ? MO_16 : MO_32); You already have size. > +return; > +break; Unreachable break. r

Re: [Qemu-devel] [PATCH v2 19/32] arm/translate-a64: add FCVTxx to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This covers all the floating point convert operations. > > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 32 + > target/arm/helper-a64.h| 2 ++ > target/arm/translate-a64.c | 85 > +++

Re: [Qemu-devel] [PATCH v2 18/32] arm/translate-a64: add FP16 FPRINTx to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > @@ -10727,40 +10727,152 @@ static void disas_simd_two_reg_misc(DisasContext > *s, uint32_t insn) > /* AdvSIMD [scalar] two register miscellaneous (FP16) > * > * 31 30 29 28 27 24 23 22 21 17 1612 11 10 95 40 > - * +---+-

Re: [Qemu-devel] [PATCH v2 17/32] arm/translate-a64: initial decode for simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > @@ -11472,6 +11512,8 @@ static void disas_data_proc_simd(DisasContext *s, > uint32_t insn) > if (fn) { > fn(s, insn); > } else { > +/* fprintf(stderr, "%s: failed to find %#4x @ %#" PRIx64 "\n", */ > +/* __func

Re: [Qemu-devel] [PATCH v2 16/32] arm/translate-a64: add FP16 x2 ops for simd_indexed

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > A bunch of the vectorised bitwise operations just operate on larger > chunks at a time. We can do the same for the new half-precision > operations by introducing some TWOHALFOP helpers which work on each > half of a pair of half-precision operations at o

[Qemu-devel] [Bug 1748296] Re: TCG throws Invalid Opcode when executing x86 BMI shlx instruction

2018-02-08 Thread Doug Gale
** Description changed: I am unable to use BMI in my project when running under TCG. I narrowed the problem down to incorrect instruction decoding for BMI instructions (which have a 2 byte VEX prefix). The gen_sse function in translate.c reaches the goto label do_0f_38_fx, but b does not e

Re: [Qemu-devel] "make check -j4" hangs (was: Re: chardev/char-socket: add POLLHUP handler)

2018-02-08 Thread Alistair Francis
On Thu, Feb 8, 2018 at 1:12 PM, Peter Maydell wrote: > On 8 February 2018 at 19:13, Thomas Huth wrote: >> I'm currently facing some issues with "make check -j4" (i.e. running the >> tests in parallel). Git bisect blames this commit - though I'm not sure >> whether this is really the right one ...

Re: [Qemu-devel] [PATCH 00/24] re-factor and add fp16 using glibc soft-fp

2018-02-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180204041136.17525-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH 00/24] re-factor and add fp16 using glibc soft-fp === TEST SCRIPT BEGIN === #!/bin/bash BASE

Re: [Qemu-devel] [PATCH v2 15/32] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > The helpers use the new re-factored muladd support in SoftFloat for the > float16 work. > > Signed-off-by: Alex Bennée --- > target/arm/translate-a64.c | 69 > -- 1 file changed, 54 > insertions(+), 15 del

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 02:59:17PM -0600, Eric Blake wrote: > On 02/08/2018 01:59 PM, Eduardo Habkost wrote: > > On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: > > > The query-cpus command has an extremely serious side effect: > > > it always interrupt all running vCPUs so that th

Re: [Qemu-devel] [PATCH v2 14/32] arm/translate-a64: add FP16 pairwise ops simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This includes FMAXNMP, FADDP, FMAXP, FMINNMP, FMINP. > > Signed-off-by: Alex Bennée > > --- > v2 > - checkpatch fixes > --- > target/arm/translate-a64.c | 208 > + > 1 file changed, 133 insertions(+), 75

Re: [Qemu-devel] [PATCH v5 06/23] Softfloat support for IEEE 754-201x minimumNumber/maximumNumber

2018-02-08 Thread Michael Clark
On Fri, Feb 9, 2018 at 3:35 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 02/07/2018 05:28 PM, Michael Clark wrote: > > QEMU currently implements IEEE 754-2008 minNum/maxNum. This patch adds > > support for IEEE 754-201x minimumNumber/maximumNumber which is required > > by the

Re: [Qemu-devel] "make check -j4" hangs (was: Re: chardev/char-socket: add POLLHUP handler)

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 19:13, Thomas Huth wrote: > I'm currently facing some issues with "make check -j4" (i.e. running the > tests in parallel). Git bisect blames this commit - though I'm not sure > whether this is really the right one ... Starting with this commit, I > saw hangs in test-filter-re

[Qemu-devel] [Bug 1748296] [NEW] TCG throws Invalid Opcode when executing x86 BMI shlx instruction

2018-02-08 Thread Doug Gale
Public bug reported: I am unable to use BMI in my project when running under TCG. I narrowed the problem down to incorrect instruction decoding for BMI instructions (which have a 2 byte VEX prefix). The gen_sse function in translate.c reaches the goto label do_0f_38_fx, but b does not equal 0x1f7,

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eric Blake
On 02/08/2018 01:59 PM, Eduardo Habkost wrote: On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: The query-cpus command has an extremely serious side effect: it always interrupt all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for s

Re: [Qemu-devel] [PATCH V9 1/4] mem: add share parameter to memory-backend-ram

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 01, 2018 at 10:55:08PM +0200, Marcel Apfelbaum wrote: > Currently only file backed memory backend can > be created with a "share" flag in order to allow > sharing guest RAM with other processes in the host. > > Add the "share" flag also to RAM Memory Backend > in order to allow remappi

Re: [Qemu-devel] [PATCH v2 11/32] arm/translate-a64: add FP16 F[A]C[EQ/GE/GT] to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 49 > ++ > target/arm/helper-a64.h| 5 + > target/arm/translate-a64.c | 15 ++ > 3 files changed, 69 insertions(+) > > di

Re: [Qemu-devel] [PATCH v2 13/32] arm/translate-a64: add FP16 FR[ECP/SQRT]S to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 34 ++ > target/arm/helper-a64.h| 2 ++ > target/arm/translate-a64.c | 6 ++ > 3 files changed, 42 insertions(+) > > diff --git a/target/arm/help

Re: [Qemu-devel] [PATCH v2 10/32] arm/translate-a64: add FP16 FADD/FABD/FSUB/FMUL/FDIV to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > The fprintf is only there for debugging as the skeleton is added to, > it will be removed once the skeleton is complete. > > Signed-off-by: Alex Bennée > > --- > v2 > - add absh helper > - fix checkpatch violation > --- > target/arm/helper-a64.c

Re: [Qemu-devel] [PATCH v2 09/32] arm/translate-a64: initial decode for simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This is the initial decode skeleton for the Advanced SIMD three same > instruction group. > > The fprintf is purely to aid debugging as the additional instructions > are added. It will be removed once the group is complete. > > Signed-off-by: Alex Benn

Re: [Qemu-devel] [PATCH v2] S390: Expose s390-specific CPU info

2018-02-08 Thread Eric Blake
On 02/08/2018 10:43 AM, Viktor Mihajlovski wrote: Presently s390x is the only architecture not exposing specific CPU information via QMP query-cpus. Upstream discussion has shown that it could make sense to report the architecture specific CPU state, e.g. to detect that a CPU has been stopped. W

Re: [Qemu-devel] [PATCH] g364fb: switch to using DirtyBitmapSnapshot

2018-02-08 Thread Hervé Poussineau
Le 08/02/2018 à 19:22, Paolo Bonzini a écrit : This removes the last user of memory_region_test_and_clear_dirty outside memory.c. Cc: Hervé Poussineau Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Paolo Bonzini Tested-by: Hervé Poussineau Tested with Windows NT 4.0 --- Unte

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Andrey Smirnov
On Thu, Feb 8, 2018 at 12:33 PM, Michael S. Tsirkin wrote: > On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: >> On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: >> > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: >> >> >> +#define PCIE_PORT_LINK_CONTROL

Re: [Qemu-devel] [PATCH v2 06/32] target/arm/helper: pass explicit fpst to set_rmode

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > As the rounding mode is now split between FP16 and the rest of > floating point we need to be explicit when tweaking it. Instead of > passing the CPU env we now pass the appropriate fpst pointer directly. > > Signed-off-by: Alex Bennée > --- > target/

Re: [Qemu-devel] [PATCH v2 12/32] arm/translate-a64: add FP16 FMULA/X/S to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 24 > target/arm/helper-a64.h| 2 ++ > target/arm/translate-a64.c | 15 +++ > 3 files changed, 41 insertions(+) > > diff --git a/target/arm/helpe

Re: [Qemu-devel] [PATCH v2 07/32] arm/translate-a64: implement half-precision F(MIN|MAX)(V|NMV)

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > +DEF_HELPER_3(advsimd_maxh, f16, f16, f16, ptr) > +DEF_HELPER_3(advsimd_minh, f16, f16, f16, ptr) > +DEF_HELPER_3(advsimd_maxnumh, f16, f16, f16, ptr) > +DEF_HELPER_3(advsimd_minnumh, f16, f16, f16, ptr) DEF_HELPER_FLAGS_3 with TCG_CALL_NO_RWG. r~

Re: [Qemu-devel] [PATCH v2 05/32] target/arm/cpu.h: add additional float_status flags

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > @@ -10750,15 +10751,22 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, > uint32_t val) > } > set_float_rounding_mode(i, &env->vfp.fp_status); > } > -if (changed & (1 << 24)) { > +if (changed & (1 << 19)) { /* FPCR:FZ16 */

Re: [Qemu-devel] [RFC PATCH 2/5] vfio/quirks: Add generic support for ioveventfds

2018-02-08 Thread Auger Eric
Hi Alex, On 08/02/18 19:33, Alex Williamson wrote: > On Thu, 8 Feb 2018 12:11:57 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 07/02/18 01:26, Alex Williamson wrote: >>> We might wish to handle some quirks via ioeventfds, add a list of >>> ioeventfds to the quirk. >> The commit title is a b

Re: [Qemu-devel] [RFC PATCH 3/5] vfio/quirks: Automatic ioeventfd enabling for NVIDIA BAR0 quirks

2018-02-08 Thread Auger Eric
Hi Alex, On 08/02/18 19:24, Alex Williamson wrote: > On Thu, 8 Feb 2018 12:10:02 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 07/02/18 01:26, Alex Williamson wrote: >>> Record data writes that come through the NVIDIA BAR0 quirk, if we get >>> enough in a row that we're only passing through,

Re: [Qemu-devel] [PATCH v2 08/32] arm/translate-a64: handle_3same_64 comment fix

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > We do implement all the opcodes. > > Signed-off-by: Alex Bennée > --- > target/arm/translate-a64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 03/32] target/arm/cpu64: allow fp16 to be disabled

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > While for CONFIG_USER_ONLY it is policy for the "cpu" to be the most > capable is can be this does cause problems. For example legacy RISU > runs would fail as there are a bunch of implemented instructions which > would have caused failures that now trig

Re: [Qemu-devel] [PATCH v2 07/32] arm/translate-a64: implement half-precision F(MIN|MAX)(V|NMV)

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This implements the half-precision variants of the across vector > reduction operations. This involves a re-factor of the reduction code > which more closely matches the ARM ARM order (and handles 8 element > reductions). > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: > On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: > >> >> +#define PCIE_PORT_LINK_CONTROL 0x710 > >> >> + > >> >> +#define PCIE_PHY_DEBUG_R1

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: > >> +#define PCIE_PORT_LINK_CONTROL 0x710 > >> + > >> +#define PCIE_PHY_DEBUG_R1 0x72C > >> +#define PCIE_PHY_DEBUG_R1_XMLH_LINK_UP BIT(4) > >> + > >> +#define PCIE_LINK_WIDTH_SPEED_CONTROL 0x80C > >> +#defin

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: [...] > The "halted" field is somewhat controversial. On the one hand, > it offers a convenient way to know if a guest CPU is idle or > running. On the other hand, it's a field that can change many > times a second. In fact, the halte

[Qemu-devel] [PATCH 14/14] tests/boot-serial-test: Add support for the aarch64 virt machine

2018-02-08 Thread Thomas Huth
From: Wei Huang This patch adds a small binary kernel to test aarch64 virt machine's UART. Signed-off-by: Wei Huang [thuth: Fixed contextual conflict with the hppa patch] Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/boot-serial-test.c | 9 + 2 files changed, 10

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Andrey Smirnov
On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: >> >> +#define PCIE_PORT_LINK_CONTROL 0x710 >> >> + >> >> +#define PCIE_PHY_DEBUG_R1 0x72C >> >> +#define PCIE_PHY_DEBUG_R1_XMLH_LINK_UP BIT(4) >> >>

[Qemu-devel] [PATCH 13/14] tests/boot-serial: Add tests for PowerPC Mac machines

2018-02-08 Thread Thomas Huth
OpenBIOS prints out the CPU type on these machine types, so we can use this string to test whether the CPU detection is working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/boot-serial-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/boot-serial-

[Qemu-devel] [PATCH 11/14] wdt_ib700-test: Drop dependence on global_qtest

2018-02-08 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Improve this test to be explicit about the state. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Thoma

Re: [Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support

2018-02-08 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > This is the deivce part implementation to add a new feature, > VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device > receives the guest free page hints from the driver and clears the > corresponding bits in the dirty bitmap, so that th

[Qemu-devel] [PATCH 09/14] qmp-test: Drop dependence on global_qtest

2018-02-08 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Although qmp-test does not maintain parallel qtest connections, it was the last test assigning to global_qtest. It's just a

[Qemu-devel] [PATCH 03/14] libqos: Track QTestState with QPCIBus

2018-02-08 Thread Thomas Huth
From: Eric Blake When initializing a QPCIBus, track which QTestState the bus is associated with (so that a later patch can then explicitly use that test state for all communication on the bus, rather than blindly relying on global_qtest). Update the initialization functions to take another param

[Qemu-devel] [PATCH 05/14] libqos: Use explicit QTestState for rtas operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all rtas test functionality to pass in an explicit QTestState, adjusting all callers. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth [thuth: Use nicer indentation in rtas.h] Signed-off-by: Thomas Huth --- tests/libqos/pci-

[Qemu-devel] [PATCH 08/14] libqos: Use explicit QTestState for remaining libqos operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all remaining libqos stragglers to pass in an explicit QTestState. Change the setting of global_qtest from being implicit in libqos' call to qtest_start() to instead be explicit in all clients that are still relying on global_qtes

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Andrey Smirnov
On Thu, Feb 8, 2018 at 9:45 AM, Michael S. Tsirkin wrote: > On Tue, Feb 06, 2018 at 08:24:34PM -0800, Andrey Smirnov wrote: >> Add code needed to get a functional PCI subsytem when using in >> conjunction with upstream Linux guest (4.13+). Tested to work against >> "e1000e" (network adapter, using

[Qemu-devel] [PATCH 01/14] tests: Clean up wait for event

2018-02-08 Thread Thomas Huth
From: Markus Armbruster We still use hacks like qmp("") to wait for an event, even though we have qmp_eventwait() since commit 8fe941f, and qmp_eventwait_ref() since commit 7ffe312. Both commits neglected to convert all the existing hacks. Make up what they missed. Bonus: gets rid of empty for

[Qemu-devel] [PATCH 06/14] libqos: Use explicit QTestState for i2c operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all i2c test functionality to pass in an explicit QTestState, adjusting all callers. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/ds1338-test.c | 6 ++--- tests/libqos/i2c-imx.c

[Qemu-devel] [PATCH 07/14] libqos: Use explicit QTestState for ahci operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all ahci test functionality to pass in an explicit QTestState. The state was already available, so no callers had to be adjusted. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Thomas Huth Signed-off-by: Thomas

[Qemu-devel] [Bug 1379688] Re: qemu's monitor and parallel create huge window

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH v2 00/32] Add ARMv8.2 half-precision functions

2018-02-08 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208173157.24705-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/32] Add

  1   2   3   4   5   >