Richard Henderson writes:
> This is now handled properly by the generic softfloat code.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> target/hppa/op_helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/hppa/op_helper
On Tue, 15 May 2018 14:00:30 +0200
Halil Pasic wrote:
> On 05/15/2018 10:32 AM, Cornelia Huck wrote:
> > On Mon, 14 May 2018 19:12:27 +0100
> > Peter Maydell wrote:
> >> (Other odd code in that function:
> >> vector = 0;
> >> [...]
> >> indicators |= 1ULL << vector;
> >> is that
Richard Henderson writes:
> This is now handled properly by the generic softfloat code.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> target/arm/helper-a64.c | 1 -
> target/arm/helper.c | 12 ++--
> 2 files changed, 2 inser
** Changed in: qemu (Ubuntu)
Importance: High => Undecided
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1771238
Title:
Not able to passthrough > 32 PCIe devices to a KVM Guest
Status in QEMU:
On 15 May 2018 at 14:13, Stefan Weil wrote:
> This is fixed in upstream vixl, in fact:
>
> https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337fda52845ed3d2e620cc02
>
> That fix will work for the moment, but is not sufficient for the future
> because it only supports gcc 7.x, but not
Richard Henderson writes:
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> target/arm/helper-a64.c | 6 +++---
> target/arm/helper.c | 12 ++--
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/target/arm/helper
On 05/15/2018 02:07 PM, Peter Maydell wrote:
On 15 May 2018 at 13:00, Halil Pasic wrote:
To sum it up, my take on the whole is the diff below. I can convert
it to a proper patch if we agree that's the way to go.
From: Halil Pasic
Date: Tue, 15 May 2018 13:57:44 +0200
Subject: [PATCH] WIP: c
Am 15.05.2018 um 14:13 schrieb Peter Maydell:
> On 13 May 2018 at 10:57, Stefan Weil wrote:
>> Even with the above patch, disas/libvixl raises a compiler warning for a
>> fall through case. The patch below fixes that warning, but I am not sure
>> whether a fall through is correct there.
>>
>> Stef
On Mon, May 14, 2018 at 07:37:49PM +0100, Peter Maydell wrote:
> On 14 May 2018 at 19:29, Michael S. Tsirkin wrote:
> > On Mon, May 14, 2018 at 04:10:42PM +0100, Peter Maydell wrote:
> >> On 14 May 2018 at 14:07, Michael S. Tsirkin wrote:
> >> > It turns out that we have unistd.h and kvm headers
Am 14.05.2018 um 22:53 hat Max Reitz geschrieben:
> On 2018-05-09 18:26, Kevin Wolf wrote:
> > This moves the top-level job completion and cancellation functions from
> > BlockJob to Job.
> >
> > Signed-off-by: Kevin Wolf
> > @@ -3362,7 +3362,7 @@ static void bdrv_close(BlockDriverState *bs)
> >
On 15/05/2018 14:33, Michael S. Tsirkin wrote:
>> Let's just pull it into standard-headers instead, and use
>> on all platforms unconditionally.
>>
>> It turns out we only need the x86 version, so that is
>> and extra a plus - drop the rest.
>
> Ping kvm maintainers - any comments?
> Should I merge
On Tue, May 15, 2018 at 02:02:55PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > I stole the printk_once() macro.
> >
> > I always wanted to be able to print some error directly if there is a
> > buffer to dump, however we can't use error_report() really quite often
> > when there can
On Tue, Apr 17, 2018 at 09:58:16PM +0300, Michael S. Tsirkin wrote:
> kvm_para.h is normally an interface for guest. It's natural to need the
> header in host to emulate that in qemu.
>
> ATM it does not actually work on non-kvm systems, which allowed us to
> get by sticking it in linux-headers a
On 15/05/2018 14:07, Markus Armbruster wrote:
> Alexey Kardashevskiy writes:
>
>> The recently introduced qom-list-properties QMP command raised
>> a question what properties it (and its cousin - device-list-properties)
>> can possibly print - only those defined by DeviceClass::props
>> or dynami
From: Marc-André Lureau
Cloned "SecurityPkg/Library/DxeTcg2PhysicalPresenceLib" and:
- removed all the functions that are unreachable from
Tcg2PhysicalPresenceLibProcessRequest()
- replaced everything that's related to the
TCG2_PHYSICAL_PRESENCE*_VARIABLE variables, with direct access to
From: Marc-André Lureau
This NULL library will let us call
Tcg2PhysicalPresenceLibProcessRequest() unconditionally from
BdsPlatform when building without TPM2_ENABLE.
Signed-off-by: Marc-André Lureau
---
.../DxeTcg2PhysicalPresenceLib.c | 26 ++
.../DxeTcg2PhysicalPres
From: Marc-André Lureau
Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI
requests from PlatformBootManagerAfterConsole().
Laszlo understanding of edk2 is that the PPI operation processing was
meant to occur *entirely* before End-Of-Dxe, so that 3rd party UEFI
drivers couldn't
From: Marc-André Lureau
Add some common macros and type definitions corresponding to the QEMU
TPM interface.
Signed-off-by: Marc-André Lureau
---
OvmfPkg/Include/IndustryStandard/QemuTpm.h | 67 ++
1 file changed, 67 insertions(+)
create mode 100644 OvmfPkg/Include/Industr
From: Marc-André Lureau
Hi,
The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU
with TPM2 (I haven't tested TPM1, for lack of interest).
PPI test runs successfully with Windows 10 WHLK, despite the limited
number of supported funcions (tpm2_ppi_funcs table, in particular, no
fu
Am 15.05.2018 um 00:33 hat John Snow geschrieben:
>
>
> On 05/09/2018 12:26 PM, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf
>
> Hmm, this one is a bit more than just code motion due to the way the
> aio_context acquisition has changed. I think at a minimum a good commit
> message is warrant
Am 14.05.2018 um 17:52 hat Max Reitz geschrieben:
> On 2018-05-09 18:26, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf
> > ---
> > include/block/blockjob.h | 5
> > include/block/blockjob_int.h | 19 ---
> > include/qemu/job.h | 20
> > block/bac
From: Stefan Berger
To avoid having to hard code the base address of the PPI virtual
memory device we introduce a fw_cfg file etc/tpm/config that holds the
base address of the PPI device, the version of the PPI interface and
the version of the attached TPM.
Signed-off-by: Stefan Berger
[ Marc-A
This allows to pass the last failing test from the Windows HLK TPM 2.0
TCG PPI 1.3 tests.
The interface is described in the "TCG Platform Reset Attack
Mitigation Specification", chapter 6 "ACPI _DSM Function". Whether or
not we should have a real implementation remains an open question to me.
Sig
From: Stefan Berger
Implement a virtual memory device for the TPM Physical Presence interface.
The memory is located at 0xfffef000 and used by ACPI to send messages to the
firmware (BIOS) and by the firmware to provide parameters for each one of
the supported codes.
This device should be used by
From: Stefan Berger
The TPM Physical Presence interface consists of an ACPI part, a shared
memory part, and code in the firmware. Users can send messages to the
firmware by writing a code into the shared memory through invoking the
ACPI code. When a reboot happens, the firmware looks for the code
Hi,
The following patches implement the TPM Physical Presence Interface
that allows a user to set a command via ACPI (sysfs entry in Linux)
that, upon the next reboot, the firmware looks for and acts upon by
sending sequences of commands to the TPM.
A dedicated memory region is added to the TPM C
On 13 May 2018 at 10:57, Stefan Weil wrote:
> Even with the above patch, disas/libvixl raises a compiler warning for a
> fall through case. The patch below fixes that warning, but I am not sure
> whether a fall through is correct there.
>
> Stefan
>
>
> diff --git a/disas/libvixl/vixl/a64/disasm-a
Alexey Kardashevskiy writes:
> The recently introduced qom-list-properties QMP command raised
> a question what properties it (and its cousin - device-list-properties)
> can possibly print - only those defined by DeviceClass::props
> or dynamically created in TypeInfo::instance_init() so properti
On 15 May 2018 at 13:00, Halil Pasic wrote:
> To sum it up, my take on the whole is the diff below. I can convert
> it to a proper patch if we agree that's the way to go.
>
> From: Halil Pasic
> Date: Tue, 15 May 2018 13:57:44 +0200
> Subject: [PATCH] WIP: cleanup virtio notify
>
> Signed-off-by:
On 15/05/2018 14:00, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> Replay data is not considered a possible attack vector; add a model that
>> does not use getc so that "tainted data" warnings are suppressed.
>>
>> Signed-off-by: Paolo Bonzini
>> ---
>> scripts/coverity-model.c | 13 +++
On 10 May 2018 at 14:12, Alex Bennée wrote:
>
> Abdallah Bouassida writes:
>
>> The previous version:
>> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714
>>
>> Abdallah Bouassida (3):
>> target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo
>> type
>> target
Peter Xu writes:
> I stole the printk_once() macro.
>
> I always wanted to be able to print some error directly if there is a
> buffer to dump, however we can't use error_report() really quite often
> when there can be any DDOS attack.
Got an example?
> To av
On 08/05/2018 14:25, Tony Krowiak wrote:
A new CPU model feature and two new CPU model facilities are
introduced to support AP devices for a KVM guest.
CPU model features:
1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that
AP facilities are installed. This feature will be enabl
On 05/15/2018 10:32 AM, Cornelia Huck wrote:
On Mon, 14 May 2018 19:12:27 +0100
Peter Maydell wrote:
Hi; Coverity has I think enabled a new warning recently, which
is triggering on virtio_ccw_notify() in hw/s390x/virtio-ccw.c
(CID 1390619).
This function does
indicators |= 1ULL << vect
Paolo Bonzini writes:
> Replay data is not considered a possible attack vector; add a model that
> does not use getc so that "tainted data" warnings are suppressed.
>
> Signed-off-by: Paolo Bonzini
> ---
> scripts/coverity-model.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff
Richard Henderson writes:
> With a canonical representation of NaNs, we can silence an SNaN
> immediately rather than delay until the final format is known.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> fpu/softfloat-specialize.h | 23 ++
git repository at:
>
> git://git.kraxel.org/qemu tags/ui-20180515-pull-request
>
> for you to fetch changes up to 677b490501823c1cb6946d8bb9e7907c12cd0c71:
>
> gtk: disable the F10 menubar key (2018-05-15 10:47:01 +0200)
>
> ---
Richard Henderson writes:
> With a canonical representation of NaNs, we can return the
> default nan directly rather than delay the expansion until
> the final format is known.
>
> Note one case where we uselessly assigned to a.sign, which was
> overwritten/ignored later when expanding float_cla
Richard Henderson writes:
> Shift the NaN fraction to a canonical position, much like we
> do for the fraction of normal numbers. This will facilitate
> manipulation of NaNs within the shared code paths.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> fpu/softfloat.c
Richard Henderson writes:
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> fpu/softfloat-specialize.h | 15 +++
> fpu/softfloat.c| 12 ++--
> 2 files changed, 17 insertions(+), 10 deletions(-)
>
> diff --git a/
Richard Henderson writes:
> This is my SNaN patch set, Alex's float-float refactor, and a couple
> of other random outstanding fpu patches. This has been reordered so
> as to be bisectable, since the float-float refactor requires the snan
> work to avoid breakage.
>
> This was built on top of p
Since struct AddressSpaceOps isn't used anywhere else,
so just delete it.
Signed-off-by: Jay Zhou
---
memory.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/memory.c b/memory.c
index fc7f9b7..94b91f9 100644
--- a/memory.c
+++ b/memory.c
@@ -220,8 +220,6 @@ struct FlatRange {
bool rea
From: Lucian Petrut
Adds the CPUID trap for CPUID 0x4000, sending the WHPX signature
to the guest upon request. This is consistent with other QEMU
accelerators (KVM).
Signed-off-by: Alessandro Pilotti
Signed-off-by: Justin Terry (VM)
Signed-off-by: Lucian Petrut
---
As opposed to the prev
1. Problem Description
==
If QEMU is built without seccomp support, 'elevateprivileges' remains compiled.
This option of sandbox is treated as an indication for seccomp blacklist support
in libvirt. This behavior is introduced by the libvirt commits 31ca6a5 and
3527f9d. It would
If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains
compiled. This would make libvirt set the corresponding capability and
then trigger the guest startup fails. So this patch excludes the code
regarding seccomp staff if CONFIG_SECCOMP is undefined.
Signed-off-by: Yi Min Zhao
--
Le 15/05/2018 à 13:17, Igor Mammedov a écrit :
> cpu_init() was replaced by cpu_create() since 2.12 but comments
> weren't updated. So update stale comments now.
>
> Signed-off-by: Igor Mammedov
> ---
> bsd-user/main.c | 2 +-
> linux-user/main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 d
cpu_init() was replaced by cpu_create() since 2.12 but comments
weren't updated. So update stale comments now.
Signed-off-by: Igor Mammedov
---
bsd-user/main.c | 2 +-
linux-user/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
ind
cpu_init() was removed since 2.12, so drop define that now isn't used
nad point to nowhere.
Signed-off-by: Igor Mammedov
---
target/riscv/cpu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 34abc38..0562a02 100644
--- a/target/riscv/cpu.h
+++ b/
On 14 May 2018 at 23:27, Richard Henderson wrote:
> Rebased on master to resolve conflicts with Emilio Cota's
> TranslatorOps patch set.
>
>
> r~
>
>
> The following changes since commit bbd87423ea0c436c55bbc3f9c23d4f811d1f3f29:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pul
On 14 May 2018 at 23:12, Richard Henderson wrote:
> We will need these helpers within softfloat-specialize.h, so move
> the definitions above the include. After specialization, they will
> not always be used so mark them to avoid the Werror.
>
> Signed-off-by: Richard Henderson
> ---
> fpu/soft
Alex Bennée writes:
> Richard Henderson writes:
>
>> On 05/13/2018 12:21 AM, Alex Bennée wrote:
>>>
>>> Richard Henderson writes:
>>>
Cc: qemu-sta...@nongnu.org
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
>>>
>>> Hmm oddly this fails to apply:
>>
>> Did try vs ma
On 14 May 2018 at 23:12, Richard Henderson wrote:
> Only MIPS requires snan_bit_is_one to be variable. While we are
> specializing softfloat behaviour, allow other targets to eliminate
> this runtime check.
>
> Cc: Aurelien Jarno
> Cc: Yongbok Kim
> Cc: David Gibson
> Cc: Alexander Graf
> Cc:
On 14 May 2018 at 23:12, Richard Henderson wrote:
> From: Alex Bennée
>
> This allows us to delete a lot of additional boilerplate
> code which is no longer needed.
>
> Signed-off-by: Alex Bennée
> Signed-off-by: Richard Henderson
>
Reviewed-by: Peter Maydell
thanks
-- PMM
Richard Henderson writes:
> From: Petr Tesarik
>
> The significand is passed to normalizeRoundAndPackFloat128() as high
> first, low second. The current code passes the integer first, so the
> result is incorrectly shifted left by 64 bits.
>
> This bug affects the emulation of s390x instruction
On 14 May 2018 at 23:12, Richard Henderson wrote:
> From: Alex Bennée
>
> For float16 ARM supports an alternative half-precision format which
> sacrifices the ability to represent NaN/Inf in return for a higher
> dynamic range. The new FloatFmt flag, arm_althp, is then used to
> modify the behav
On 14 May 2018 at 23:11, Richard Henderson wrote:
> Shift the NaN fraction to a canonical position, much like we
> do for the fraction of normal numbers. This will facilitate
> manipulation of NaNs within the shared code paths.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
t
When using following CLI:
-numa dist,src=128,dst=1,val=20
user getsi a rather confusing error message:
"Invalid node 128, max possible could be 128"
Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error
Richard Henderson writes:
> Cc: qemu-sta...@nongnu.org
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> target/arm/translate-a64.c | 30 ++
> 1 file changed, 14 insertions(+), 16 deletions(-)
>
> diff --git a/targe
On 14 May 2018 at 23:12, Richard Henderson wrote:
> Isolate the target-specific choice to 2 functions instead of 6.
>
> The code in float16_default_nan was only correct for ARM, MIPS, and X86.
> Though float16 support is rare among our targets.
>
> The code in float128_default_nan was arguably wro
Richard Henderson writes:
> No sense in emitting code after the exception.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> target/arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/transl
Richard Henderson writes:
> Adding the fp16 moves to/from general registers.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> target/arm/translate-a64.c | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git a/target/a
On 14 May 2018 at 19:19, Laurent Vivier wrote:
> The following changes since commit c74e62ee3e2dc2955e07d004c71badecb68a84eb:
>
> Merge remote-tracking branch 'remotes/rth/tags/cota-target-pull-request'
> into staging (2018-05-11 15:41:29 +0100)
>
> are available in the Git repository at:
>
>
On 14 May 2018 at 23:12, Richard Henderson wrote:
> From: Alex Bennée
>
> Instead of passing env and leaving it up to the helper to get the
> right fpstatus we pass it explicitly. There was already a get_fpstatus
> helper for neon for the 32 bit code. We also add an get_ahp_flag() for
> passing t
On Tue, May 15, 2018 at 09:45:56AM +0800, Su Hang wrote:
> These series of patchs implement Intel Hexadecimal File loader and
> add QTest testcase to verify the correctness of Loader.
Good job, this looks close now. I left a comment on the test case - it
needs to work with out-of-tree builds.
St
On Tue, May 15, 2018 at 09:45:58AM +0800, Su Hang wrote:
> 'test.hex' file is a bare metal ARM software stored in Hexadecimal
> Object Format. When it's loaded by QEMU, it will print "Hello world!\n"
> on console.
>
> `pre_store` array in 'hexloader-test.c' file, stores the binary format
> of 'tes
On Tue, May 15, 2018 at 09:45:57AM +0800, Su Hang wrote:
> This patch adds Intel Hexadecimal Object File format support to
> the loader. The file format specification is available here:
> http://www.piclist.com/techref/fileext/hex/intel.htm
>
> The file format is mainly intended for embedded syst
On Wed, May 09, 2018 at 05:26:08PM +0200, Laszlo Ersek wrote:
> Add a schema that describes the different uses and properties of virtual
> machine firmware.
>
> Each firmware executable installed on a host system should come with at
> least one JSON file that conforms to this schema. Each file inf
From: Geoffrey McRae
This fixes an issue by adding bounds checking to multi-byte packets
where the PS/2 mouse data stream may become corrupted due to data being
discarded when the PS/2 ringbuffer is full.
Interrupts for Multi-byte responses are postponed until the final byte
has been queued.
Th
From: Geoffrey McRae
This allows guest's to correctly reinitialize and identify the mouse
should the guest decide to re-scan or reset during mouse input events.
When the guest sends the "Identify" command, due to the PC's hardware
architecutre it is impossible to reliably determine the response
The following changes since commit fbd3a489df9953e2a5d017c922f3c103b2426952:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180514' into
staging (2018-05-14 18:53:42 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/input-20180515-pull-re
On Mon, May 07, 2018 at 11:13:12PM +1000, Geoffrey McRae wrote:
> This fixes an issue by adding bounds checking to multi-byte packets
> where the PS/2 mouse data stream may become corrupted due to data being
> discarded when the PS/2 ringbuffer is full.
>
> Interrupts for Multi-byte responses are
From: Peter Wu
The F10 key is used in various applications, disable it unconditionally
(do not limit it to grab mode). Note that this property is deprecated
and might be removed in the future (GTK+ commit b082fb598d).
Fixes: https://bugs.launchpad.net/qemu/+bug/1726910
Signed-off-by: Peter Wu
M
From: Peter Wu
Saves some space and disables the F10 button as side-effect.
Fixes: https://bugs.launchpad.net/qemu/+bug/1726910
Signed-off-by: Peter Wu
Message-Id: <20180510230739.28459-1-pe...@lekensteyn.nl>
Signed-off-by: Gerd Hoffmann
---
ui/gtk.c | 46 +
Drop the gtk option parser from parse_display(), so parse_display_qapi()
will handle it instead.
With this change the parser will accept gl=core and gl=es too, gtk
must catch the unsupported gles variant now.
Signed-off-by: Gerd Hoffmann
Message-id: 20180507095539.19584-4-kra...@redhat.com
---
Signed-off-by: Gerd Hoffmann
Message-id: 20180507095424.16220-1-kra...@redhat.com
---
ui/console.c | 105 +--
1 file changed, 58 insertions(+), 47 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index b02510cdca..945f05d728 100644
---
Add parse_display_qapi() function which parses the -display command line
using a qapi visitor for DisplayOptions. Wire up as default catch in
parse_display().
Improves the error message for unknown display types.
Also enables json as -display argument, i.e. -display "{ 'type': 'gtk' }"
Signed-o
The following changes since commit fbd3a489df9953e2a5d017c922f3c103b2426952:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180514' into
staging (2018-05-14 18:53:42 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/ui-20180515-pull-reques
From: Tomeu Vizoso
The commit referenced below changed the logic by causing the gtk-egl
backend to be initialized regardless of whether GtkGlArea initialization
succeeded. This causes eglInitialize to crash in Wayland systems without
XWayland.
This patch restores the previous logic.
Fixes: 4c70
Add comments to the cases not (yet) switched
over to parse_display_qapi().
Signed-off-by: Gerd Hoffmann
Message-id: 20180507095539.19584-5-kra...@redhat.com
---
vl.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/vl.c b/vl.c
index 5f1734d851..3b39bbd7a8 100644
--- a/vl.c
+++
Drop the option-less display types (egl-headless, curses, none) from
parse_display(), so they'll be handled by parse_display_qapi().
Signed-off-by: Gerd Hoffmann
Reviewed-by: Eric Blake
Message-id: 20180507095539.19584-3-kra...@redhat.com
---
vl.c | 6 --
1 file changed, 6 deletions(-)
dif
Set magic cookie on initialization. Clear on cleanup. Sprinkle a bunch
of assert()s checking the cookie, to verify the pointer is valid.
Signed-off-by: Gerd Hoffmann
Message-id: 20180507102254.12107-1-kra...@redhat.com
---
ui/vnc.h | 3 +++
ui/vnc-jobs.c | 4
ui/vnc.c | 10 +++
So the opts pointer is set for all sdl2_consoles.
Fixes: 844fd50dbbcfc9e401895274bf4fb8da8e8d3f64
Signed-off-by: Gerd Hoffmann
---
ui/sdl2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index da037248c2..a0f9b16bc1 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180515091356.24106-1-pet...@redhat.com
Subject: [Qemu-devel] [PATCH RFC] qemu-error: introduce error_report_once
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=
I stole the printk_once() macro.
I always wanted to be able to print some error directly if there is a
buffer to dump, however we can't use error_report() really quite often
when there can be any DDOS attack. To avoid that, we can introduce a
print-once function for it.
CC: Markus Armbruster
Si
Am 14.05.2018 um 23:34 hat John Snow geschrieben:
>
>
> On 05/09/2018 12:26 PM, Kevin Wolf wrote:
> > This moves reference counting from BlockJob to Job.
> >
> > In order to keep calling the BlockJob cleanup code when the job is
> > deleted via job_unref(), introduce a new JobDriver.free callbac
On 14 May 2018 at 19:05, Laurent Vivier wrote:
> The following changes since commit 7a9180b77eca258ab418ec00ab397392e70e55d9:
>
> Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into
> staging (2018-05-14 14:15:27 +0100)
>
> are available in the Git repository at:
>
> gi
On 15 May 2018 at 02:26, Eva Chen wrote:
> Hello,
>
> I want to know the flow of how devices read/write function be called by
> code_gen_buffer().
> Take pl110_write() for example, I set a breakpoint in pl110_write(), and
> the backtrace shows bellow.
Hi. This code flow is a bit complicated. You
On Tue, May 15, 2018 at 10:46:54AM +0200, Gerd Hoffmann wrote:
> On Tue, May 15, 2018 at 09:39:12AM +0100, Daniel P. Berrangé wrote:
> > On Tue, May 15, 2018 at 10:30:09AM +0200, Gerd Hoffmann wrote:
> > > On Fri, May 11, 2018 at 01:07:39AM +0200, Peter Wu wrote:
> > > > The F10 key is used in vari
I have done some further tests and the problem seems to be SATA, not
UEFI, I have updated the bug description to reflect this.
** Summary changed:
- Issue with qemu 2.12.0 + UEFI
+ Issue with qemu 2.12.0 + SATA
** Description changed:
- (first reported here: https://bugzilla.tianocore.org/show_
On Tue, May 15, 2018 at 09:39:12AM +0100, Daniel P. Berrangé wrote:
> On Tue, May 15, 2018 at 10:30:09AM +0200, Gerd Hoffmann wrote:
> > On Fri, May 11, 2018 at 01:07:39AM +0200, Peter Wu wrote:
> > > The F10 key is used in various applications, disable it unconditionally
> > > (do not limit it to
On 05/04/18 09:25, Cornelia Huck wrote:
> From: Collin Walling
>
> zIPL boot menu entries can be non-sequential. Let's account
> for this issue for the s390 zIPL boot menu. Since this boot
> menu is actually an imitation and is not completely capable
> of everything the real zIPL menu can do, let
I've come across this patch in downstream review (although I really have
zero background in s390x), and Cornelia suggested I might want to repeat
my comments on the upstream list too:
On 05/04/18 09:25, Cornelia Huck wrote:
> From: Collin Walling
>
> Rename the loadparm char array in main.c to l
On 05/15/2018 05:23 AM, Gerd Hoffmann wrote:
> So the opts pointer is set for all sdl2_consoles.
>
> Fixes: 844fd50dbbcfc9e401895274bf4fb8da8e8d3f64
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
> ---
> ui/sdl2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On 15/05/2018 09:42, Markus Armbruster wrote:
> Olaf Hering writes:
>
>> Currently the minimal supported version of glib is 2.22.
>> Since testing is done with a glib that claims to be 2.22, but in fact
>> has APIs from newer version of glib, this bug was not caught during
>> submit of the patch
On Tue, May 15, 2018 at 10:30:09AM +0200, Gerd Hoffmann wrote:
> On Fri, May 11, 2018 at 01:07:39AM +0200, Peter Wu wrote:
> > The F10 key is used in various applications, disable it unconditionally
> > (do not limit it to grab mode). Note that this property is deprecated
> > and might be removed i
On Mon, May 07, 2018 at 03:42:37PM +0200, Tomeu Vizoso wrote:
> The commit referenced below changed the logic by causing the gtk-egl
> backend to be initialized regardless of whether GtkGlArea initialization
> succeeded. This causes eglInitialize to crash in Wayland systems without
> XWayland.
>
>
On Fri, May 11, 2018 at 01:07:38AM +0200, Peter Wu wrote:
> Saves some space and disables the F10 button as side-effect.
Added to ui patch queue.
thanks,
Gerd
On Mon, 14 May 2018 19:12:27 +0100
Peter Maydell wrote:
> Hi; Coverity has I think enabled a new warning recently, which
> is triggering on virtio_ccw_notify() in hw/s390x/virtio-ccw.c
> (CID 1390619).
>
> This function does
> indicators |= 1ULL << vector;
> but the code is guarded only by
>
On Fri, May 11, 2018 at 01:07:39AM +0200, Peter Wu wrote:
> The F10 key is used in various applications, disable it unconditionally
> (do not limit it to grab mode). Note that this property is deprecated
> and might be removed in the future (GTK+ commit b082fb598d).
Any replacement provided by gtk
So the opts pointer is set for all sdl2_consoles.
Fixes: 844fd50dbbcfc9e401895274bf4fb8da8e8d3f64
Signed-off-by: Gerd Hoffmann
---
ui/sdl2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index da037248c2..a0f9b16bc1 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2
301 - 400 of 411 matches
Mail list logo
