[Qemu-devel] [PATCH v2 2/4] block: split flags in copy_range

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
Pass read flags and write flags separately. This is needed to handle coming BDRV_REQ_NO_SERIALISING clearly in following patches. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 3 ++- include/block/block_int.h | 14 ++ include/sysemu/block-back

[Qemu-devel] [PATCH v2 1/4] block: disallow BDRV_REQ_NO_SERIALISING for write

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
Before commit 9ded4a01149 "backup: Use copy offloading", BDRV_REQ_NO_SERIALISING was used for only one case: read in copy-on-write operation during backup. Also, the flag was handled only on read path (in bdrv_co_preadv and bdrv_aligned_preadv). After 9ded4a01149, flag is used for not waiting seri

Re: [Qemu-devel] [PATCH 1/2] block: add BDRV_REQ_SERIALISING flag

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 19:36, Vladimir Sementsov-Ogievskiy wrote: 04.07.2018 19:20, Kevin Wolf wrote: Am 04.07.2018 um 18:11 hat Vladimir Sementsov-Ogievskiy geschrieben: 04.07.2018 18:08, Kevin Wolf wrote: Am 04.07.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: 03.07.2018 21:07, Vladimir Se

Re: [Qemu-devel] [kvmtool test PATCH 22/24] kvmtool: arm64: Add support for guest physical address size

2018-07-04 Thread Julien Grall
Hi, On 04/07/18 15:09, Will Deacon wrote: On Fri, Jun 29, 2018 at 12:15:42PM +0100, Suzuki K Poulose wrote: Add an option to specify the physical address size used by this VM. Signed-off-by: Suzuki K Poulose --- arm/aarch64/include/kvm/kvm-config-arch.h | 5 - arm/include/arm-common/kv

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Alex Bennée
Programmingkid writes: >> On Jul 4, 2018, at 11:39 AM, Alex Bennée wrote: >> >> >> Programmingkid writes: >> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: Richard Henderson writes: > > Anyway, all of this has been broken long enough that it'll need to

Re: [Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error

2018-07-04 Thread BALATON Zoltan
On Wed, 4 Jul 2018, Philippe Mathieu-Daudé wrote: Missed in 3c409c1927e, hopefully reported by Coverity. Apparently Coverity did report it and Paolo already notified me about that. I was about to send a patch but you were faster. Thank you very much. Reviewed-by: BALATON Zoltan Fixes: Co

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Philippe Mathieu-Daudé
On 07/04/2018 01:26 PM, Daniel P. Berrangé wrote: > On Wed, Jul 04, 2018 at 05:21:49PM +0100, Alex Bennée wrote: >> >> Daniel P. Berrangé writes: >> >>> On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > This silent (since d75402b5ee2)

Re: [Qemu-devel] [PATCH 1/2] block: add BDRV_REQ_SERIALISING flag

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 19:20, Kevin Wolf wrote: Am 04.07.2018 um 18:11 hat Vladimir Sementsov-Ogievskiy geschrieben: 04.07.2018 18:08, Kevin Wolf wrote: Am 04.07.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: 03.07.2018 21:07, Vladimir Sementsov-Ogievskiy wrote: Serialized writes should be u

Re: [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts

2018-07-04 Thread Philippe Mathieu-Daudé
On 07/04/2018 12:51 PM, Daniel P. Berrangé wrote: > On Wed, Jul 04, 2018 at 12:39:14PM -0300, Philippe Mathieu-Daudé wrote: >> Patch created mechanically by rerunning: >> >> $ spatch --sp-file scripts/coccinelle/typecast.cocci \ >> --macro-file scripts/cocci-macro-file.h \ >>

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 05:21:49PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: > >> > >> Philippe Mathieu-Daudé writes: > >> > >> > This silent (since d75402b5ee2): > >> > > >> > ./configure > >> > [...] > >> >

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Programmingkid
> On Jul 4, 2018, at 11:39 AM, Alex Bennée wrote: > > > Programmingkid writes: > >>> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: >>> >>> >>> Richard Henderson writes: >>> Anyway, all of this has been broken long enough that it'll need to wait til next devel cycle bef

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Alex Bennée
Daniel P. Berrangé writes: > On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > This silent (since d75402b5ee2): >> > >> > ./configure >> > [...] >> > NOTE: cross-compilers enabled: 'cc' >> > >> > Reported-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH 1/2] block: add BDRV_REQ_SERIALISING flag

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 18:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.07.2018 18:08, Kevin Wolf wrote: > > Am 04.07.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 03.07.2018 21:07, Vladimir Sementsov-Ogievskiy wrote: > > > > Serialized writes should be used in copy-on-write o

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Peter Maydell
On 4 July 2018 at 14:34, Kevin Wolf wrote: > Essentially, what is important to me isn't getting these options dropped > exactly in 3.0, but not setting a bad precedence that deprecation isn't > actually worth anything. We may easily end up with this deprecation > process: > > depreate a feature >

[Qemu-devel] [PATCH] checkpatch: handle token pasting better

2018-07-04 Thread Paolo Bonzini
The mechanism to find possible type tokens can sometimes be confused and go into an infinite loop. This happens for example in QEMU for a line that looks like uint## BITS ##_t S = _S, T = _T;\ uint## BITS ##_t as, at, xs, xt, xd;

Re: [Qemu-devel] [PATCH 1/2] block: add BDRV_REQ_SERIALISING flag

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 18:08, Kevin Wolf wrote: Am 04.07.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: 03.07.2018 21:07, Vladimir Sementsov-Ogievskiy wrote: Serialized writes should be used in copy-on-write of backup(sync=none) for image fleecing scheme. Signed-off-by: Vladimir Sementsov-Ogi

Re: [Qemu-devel] [PATCH v6 4/4] acpi: build TPM Physical Presence interface

2018-07-04 Thread Marc-André Lureau
HI On Wed, Jul 4, 2018 at 5:39 PM, Igor Mammedov wrote: > On Thu, 28 Jun 2018 19:26:57 +0200 > Marc-André Lureau wrote: > >> From: Stefan Berger >> >> The TPM Physical Presence interface consists of an ACPI part, a shared >> memory part, and code in the firmware. Users can send messages to the

Re: [Qemu-devel] [PULL 0/3] Audio 20180703 patches

2018-07-04 Thread Peter Maydell
On 3 July 2018 at 13:10, Gerd Hoffmann wrote: > The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into > staging (2018-07-02 17:57:46 +0100) > > are available in the git repository at: > > git://g

Re: [Qemu-devel] [kvmtool test PATCH 24/24] kvmtool: arm: Add support for creating VM with PA size

2018-07-04 Thread Suzuki K Poulose
Hi Will, On 07/04/2018 03:22 PM, Will Deacon wrote: On Fri, Jun 29, 2018 at 12:15:44PM +0100, Suzuki K Poulose wrote: diff --git a/arm/kvm.c b/arm/kvm.c index 5701d41..b1969be 100644 --- a/arm/kvm.c +++ b/arm/kvm.c @@ -11,6 +11,8 @@ #include #include +unsigned long kvm_arm_type; + s

Re: [Qemu-devel] [kvmtool test PATCH 22/24] kvmtool: arm64: Add support for guest physical address size

2018-07-04 Thread Will Deacon
On Wed, Jul 04, 2018 at 04:00:11PM +0100, Julien Grall wrote: > On 04/07/18 15:09, Will Deacon wrote: > >On Fri, Jun 29, 2018 at 12:15:42PM +0100, Suzuki K Poulose wrote: > >>Add an option to specify the physical address size used by this > >>VM. > >> > >>Signed-off-by: Suzuki K Poulose > >>--- >

Re: [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 12:39:14PM -0300, Philippe Mathieu-Daudé wrote: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/typecast.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir . --in-place > > Signed-off-by: Philippe Mat

Re: [Qemu-devel] [PATCH v3 15/20] kvm: arm/arm64: Allow tuning the physical address size for VM

2018-07-04 Thread Will Deacon
Hi Suzuki, On Fri, Jun 29, 2018 at 12:15:35PM +0100, Suzuki K Poulose wrote: > Allow specifying the physical address size for a new VM via > the kvm_type argument for KVM_CREATE_VM ioctl. This allows > us to finalise the stage2 page table format as early as possible > and hence perform the right c

Re: [Qemu-devel] [kvmtool test PATCH 24/24] kvmtool: arm: Add support for creating VM with PA size

2018-07-04 Thread Will Deacon
On Wed, Jul 04, 2018 at 03:41:18PM +0100, Marc Zyngier wrote: > On Wed, 04 Jul 2018 15:22:42 +0100, > Will Deacon wrote: > > > > On Fri, Jun 29, 2018 at 12:15:44PM +0100, Suzuki K Poulose wrote: > > > diff --git a/arm/kvm.c b/arm/kvm.c > > > index 5701d41..b1969be 100644 > > > --- a/arm/kvm.c > >

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > This silent (since d75402b5ee2): > > > > ./configure > > [...] > > NOTE: cross-compilers enabled: 'cc' > > > > Reported-by: Dr. David Alan Gilbert > > Reported-by: Daniel P. Berrangé >

[Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro

2018-07-04 Thread Philippe Mathieu-Daudé
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé --- ui/vnc-enc-tight.c | 2 +- ui/vnc.c | 3 ++- 2 files changed,

[Qemu-devel] [PATCH 7/8] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro

2018-07-04 Thread Philippe Mathieu-Daudé
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c | 2 +- hw/pci-host/q35.c | 2 +- 2 files changed, 2

[Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless casts

2018-07-04 Thread Philippe Mathieu-Daudé
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/typecast.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[Qemu-devel] [PATCH 0/8] Coccinelle cleanups

2018-07-04 Thread Philippe Mathieu-Daudé
Nothing exciting here, patches created mechanically (common after soft freeze). Philippe Mathieu-Daudé (8): qobject: Catch another straggler for use of qdict_put_str() error: Remove NULL checks on error_propagate() calls crypto: Remove useless casts xen: Remove useless casts tests/bios-t

[Qemu-devel] [PATCH 8/8] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro

2018-07-04 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/intc/arm_gicv3_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/intc/arm_gicv3_common.h b/include/hw/intc/arm_gicv3_common.h index b798486ecf..31ec9a1ae4 100644 --- a/include/hw/intc/arm_gicv3_common.h ++

Re: [Qemu-devel] [PATCH v6 4/4] acpi: build TPM Physical Presence interface

2018-07-04 Thread Igor Mammedov
On Thu, 28 Jun 2018 19:26:57 +0200 Marc-André Lureau wrote: > From: Stefan Berger > > The TPM Physical Presence interface consists of an ACPI part, a shared > memory part, and code in the firmware. Users can send messages to the > firmware by writing a code into the shared memory through invoki

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > This silent (since d75402b5ee2): > > ./configure > [...] > NOTE: cross-compilers enabled: 'cc' > > Reported-by: Dr. David Alan Gilbert > Reported-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 2 +- > 1 file changed

[Qemu-devel] [PATCH 4/8] xen: Remove useless casts

2018-07-04 Thread Philippe Mathieu-Daudé
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/typecast.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé --- hw/xen/xen_pt_config_init.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH 2/8] error: Remove NULL checks on error_propagate() calls

2018-07-04 Thread Philippe Mathieu-Daudé
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/virtio-ccw.c | 4 +--- 1 file changed, 1 inserti

[Qemu-devel] [PATCH 1/8] qobject: Catch another straggler for use of qdict_put_str()

2018-07-04 Thread Philippe Mathieu-Daudé
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé --- qobject/block-qdict.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[Qemu-devel] [PATCH 3/8] crypto: Remove useless casts

2018-07-04 Thread Philippe Mathieu-Daudé
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/typecast.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé --- crypto/cipher-builtin.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Alex Bennée
Programmingkid writes: >> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: >> >> >> Richard Henderson writes: >> >>> >>> Anyway, all of this has been broken long enough that it'll need to >>> wait til next devel cycle before anything further gets done. >> >> When it gets done should we add som

[Qemu-devel] [BUG] checkpatch.pl hangs on target/mips/msa_helper.c

2018-07-04 Thread Aleksandar Markovic
If checkpatch.pl is applied (using switch "-f") on file target/mips/msa_helper.c, it will hang. There is a workaround for this particular file: These lines in msa_helper.c: uint## BITS ##_t S = _S, T = _T;\ uint## BITS ##_t as, at, xs, xt, xd;

Re: [Qemu-devel] [PATCH] block: Don't silently truncate node names

2018-07-04 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. N/A. Internal error while reading log file --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com

Re: [Qemu-devel] [PATCH 1/2] block: add BDRV_REQ_SERIALISING flag

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > 03.07.2018 21:07, Vladimir Sementsov-Ogievskiy wrote: > > Serialized writes should be used in copy-on-write of backup(sync=none) > > for image fleecing scheme. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > >

[Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_co_create_opts_luks to avoid a memory leak

2018-07-04 Thread Philippe Mathieu-Daudé
After 1ec4f4160a1 Coverity reported: Variable cryptoopts going out of scope leaks the storage it points to. Fixes: Coverity CID 1393782 (Resource leak) Signed-off-by: Philippe Mathieu-Daudé --- I think this check is superfluous but I respected the previous code: ret = block_crypto_co_cre

[Qemu-devel] [PATCH v2 2/3] block/blklogwrites: Add an option for appending to an old log

2018-07-04 Thread Ari Sundholm
Suggested by Kevin Wolf. May be useful when testing multiple batches of writes or doing long-term testing involving restarts of the VM. Signed-off-by: Ari Sundholm --- block/blklogwrites.c | 147 ++- qapi/block-core.json | 3 +- 2 files changed,

[Qemu-devel] [PATCH v2 1/3] block/blklogwrites: Change log_sector_size from int64_t to uint64_t

2018-07-04 Thread Ari Sundholm
This was a simple oversight when working on intermediate versions of the original patch which introduced blklogwrites. Signed-off-by: Ari Sundholm --- block/blklogwrites.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/blklogwrites.c b/block/blklogwrites.c inde

[Qemu-devel] [PATCH v2 0/3] blklogwrites improvements

2018-07-04 Thread Ari Sundholm
This patch set contains a trivial printf format fix, followed by two new features for the blklogwrites driver. The first feature is an option to append to an existing log, adopting its sector size and other metadata in its superblock. This can be useful, and was suggested by Kevin Wolf. The secon

[Qemu-devel] [PATCH v2 3/3] block/blklogwrites: Add an option for the update interval of the log superblock

2018-07-04 Thread Ari Sundholm
This is a way to ensure that the log superblock is periodically updated. Before, this was only done on flush requests, which may not be enough if the VM exits abnormally, omitting the final flush. The default interval is 4096 write requests. Signed-off-by: Ari Sundholm --- block/blklogwrites.c

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Programmingkid
> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: > > > Richard Henderson writes: > >> >> Anyway, all of this has been broken long enough that it'll need to >> wait til next devel cycle before anything further gets done. > > When it gets done should we add some explicit ppc tests to tests/

[Qemu-devel] [PATCH] throttle-groups: fix hang when group member leaves

2018-07-04 Thread Stefan Hajnoczi
Throttle groups consist of members sharing one throttling state (including bps/iops limits). Round-robin scheduling is used to ensure fairness. If a group member already has a timer pending then other groups members do not schedule their own timers. The next group member will have its turn when

[Qemu-devel] [PATCH 2/2] file-posix: Unlock FD after creation

2018-07-04 Thread Max Reitz
Closing the FD does not necessarily mean that it is unlocked. Fix this by relinquishing all permission locks before qemu_close(). Reported-by: Kevin Wolf Signed-off-by: Max Reitz --- block/file-posix.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/block

[Qemu-devel] [PATCH 0/2] file-posix: Fix creation locking

2018-07-04 Thread Max Reitz
This series fixes two bugs Kevin spotted in file-posix's creation locking. Max Reitz (2): file-posix: Fix creation locking file-posix: Unlock FD after creation block/file-posix.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) -- 2.17.1

[Qemu-devel] [PATCH 1/2] file-posix: Fix creation locking

2018-07-04 Thread Max Reitz
raw_apply_lock_bytes() takes a bit mask of "permissions that are NOT shared". Also, make the "perm" and "shared" variables uint64_t, because I do not particularly like using ~ on signed integers (and other permission masks are usually uint64_t, too). Reported-by: Kevin Wolf Signed-off-by: Max Re

[Qemu-devel] [PATCH 0/3] blklogwrites improvements

2018-07-04 Thread Ari Sundholm
This patch set contains a trivial printf format fix, followed by two new features for the blklogwrites driver. The first feature is an option to append to an existing log, adopting its sector size and other metadata in its superblock. This can be useful, and was suggested by Kevin Wolf. The secon

[Qemu-devel] [PATCH 1/3] block/blklogwrites: Change log_sector_size from int64_t to uint64_t

2018-07-04 Thread Ari Sundholm
This was a simple oversight when working on intermediate versions of the original patch which introduced blklogwrites. Signed-off-by: Ari Sundholm --- block/blklogwrites.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/blklogwrites.c b/block/blklogwrites.c inde

[Qemu-devel] [PATCH 3/3] block/blklogwrites: Add an option for the update interval of the log superblock

2018-07-04 Thread Ari Sundholm
This is a way to ensure that the log superblock is periodically updated. Before, this was only done on flush requests, which may not be enough if the VM exits abnormally, omitting the final flush. The default interval is 4096 write requests. Signed-off-by: Ari Sundholm --- block/blklogwrites.c

[Qemu-devel] [PATCH 2/3] block/blklogwrites: Add an option for appending to an old log

2018-07-04 Thread Ari Sundholm
Suggested by Kevin Wolf. May be useful when testing multiple batches of writes or doing long-term testing involving restarts of the VM. Signed-off-by: Ari Sundholm --- block/blklogwrites.c | 147 ++- qapi/block-core.json | 3 +- 2 files changed,

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Cornelia Huck
On Wed, 4 Jul 2018 11:30:14 -0300 Philippe Mathieu-Daudé wrote: > This silent (since d75402b5ee2): s/silent/silences/ > > ./configure > [...] > NOTE: cross-compilers enabled: 'cc' > > Reported-by: Dr. David Alan Gilbert > Reported-by: Daniel P. Berrangé > Signed-off-by: Philippe Mat

Re: [Qemu-devel] [PATCH 1/2] block: add BDRV_REQ_SERIALISING flag

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
03.07.2018 21:07, Vladimir Sementsov-Ogievskiy wrote: Serialized writes should be used in copy-on-write of backup(sync=none) for image fleecing scheme. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 5 - block/io.c| 4 2 files changed, 8 inserti

[Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error

2018-07-04 Thread Philippe Mathieu-Daudé
Missed in 3c409c1927e, hopefully reported by Coverity. Fixes: Coverity CID 1393788 (Copy-paste error) Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc440_uc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c index 0bbaa6844a..09ccda5

Re: [Qemu-devel] [kvmtool test PATCH 24/24] kvmtool: arm: Add support for creating VM with PA size

2018-07-04 Thread Marc Zyngier
On Wed, 04 Jul 2018 15:22:42 +0100, Will Deacon wrote: > > On Fri, Jun 29, 2018 at 12:15:44PM +0100, Suzuki K Poulose wrote: > > diff --git a/arm/kvm.c b/arm/kvm.c > > index 5701d41..b1969be 100644 > > --- a/arm/kvm.c > > +++ b/arm/kvm.c > > @@ -11,6 +11,8 @@ > > #include > > #include > > >

Re: [Qemu-devel] [PATCH V9 12/20] qapi: Add new command to query colo status

2018-07-04 Thread Markus Armbruster
Zhang Chen writes: > On Tue, Jul 3, 2018 at 7:09 PM, Markus Armbruster wrote: > >> Zhang Chen writes: >> >> > Libvirt or other high level software can use this command query colo >> status. >> > You can test this command like that: >> > {'execute':'query-colo-status'} >> > >> > Signed-off-by: Z

Re: [Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event

2018-07-04 Thread Philippe Mathieu-Daudé
On 07/04/2018 09:04 AM, Paolo Bonzini wrote: > Reported by Coverity. > Fixes: Coverity CID 1393785 (Resource leak) > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- > scsi/pr-manager-helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scsi/pr-manager-he

[Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Philippe Mathieu-Daudé
This silent (since d75402b5ee2): ./configure [...] NOTE: cross-compilers enabled: 'cc' Reported-by: Dr. David Alan Gilbert Reported-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 15:43 hat Daniel P. Berrangé geschrieben: > On Wed, Jul 04, 2018 at 03:34:40PM +0200, Kevin Wolf wrote: > > I understand where you're coming from, but let's be honest: It's not as > > if disk geometry or serial numbers were features that absolutely need > > to be there to give QEMU

Re: [Qemu-devel] [kvmtool test PATCH 24/24] kvmtool: arm: Add support for creating VM with PA size

2018-07-04 Thread Will Deacon
On Fri, Jun 29, 2018 at 12:15:44PM +0100, Suzuki K Poulose wrote: > diff --git a/arm/kvm.c b/arm/kvm.c > index 5701d41..b1969be 100644 > --- a/arm/kvm.c > +++ b/arm/kvm.c > @@ -11,6 +11,8 @@ > #include > #include > > +unsigned long kvm_arm_type; > + > struct kvm_ext kvm_req_ext[] = { >

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Alex Bennée
Richard Henderson writes: > > Anyway, all of this has been broken long enough that it'll need to > wait til next devel cycle before anything further gets done. When it gets done should we add some explicit ppc tests to tests/tcg/ppc like we did with arm64 fcvt or would it be worth spending mor

[Qemu-devel] [PATCH v7 4/5] acpi: build TPM Physical Presence interface

2018-07-04 Thread Marc-André Lureau
From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the code

[Qemu-devel] [PATCH v7 3/5] acpi: add fw_cfg file for TPM and PPI virtual memory device

2018-07-04 Thread Marc-André Lureau
From: Stefan Berger To avoid having to hard code the base address of the PPI virtual memory device we introduce a fw_cfg file etc/tpm/config that holds the base address of the PPI device, the version of the PPI interface and the version of the attached TPM. Signed-off-by: Stefan Berger [ Marc-A

[Qemu-devel] [PATCH v7 5/5] PoC: tpm: add ACPI memory clear interface

2018-07-04 Thread Marc-André Lureau
This allows to pass the last failing test from the Windows HLK TPM 2.0 TCG PPI 1.3 tests. The interface is described in the "TCG Platform Reset Attack Mitigation Specification", chapter 6 "ACPI _DSM Function". According to Laszlo, it's not so easy to implement in OVMF, he suggested to do it in qem

[Qemu-devel] [PATCH v7 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-04 Thread Marc-André Lureau
From: Stefan Berger Implement a virtual memory device for the TPM Physical Presence interface. The memory is located at 0xFED45000 and used by ACPI to send messages to the firmware (BIOS) and by the firmware to provide parameters for each one of the supported codes. This device should be used by

[Qemu-devel] [PATCH v7 1/5] tpm: add a "ppi" boolean property

2018-07-04 Thread Marc-André Lureau
The following patches implement the TPM Physical Presence Interface, make use of a new memory region and a fw_cfg entry. Enable PPI by default with >2.12 machine type, to avoid migration issues. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- include/hw/compat.h | 10 ++

[Qemu-devel] [PATCH v7 0/5] Add support for TPM Physical Presence interface

2018-07-04 Thread Marc-André Lureau
Hi, The following patches implement the TPM Physical Presence Interface that allows a user to set a command via ACPI (sysfs entry in Linux) that, upon the next reboot, the firmware looks for and acts upon by sending sequences of commands to the TPM. A dedicated memory region is added to the TPM C

Re: [Qemu-devel] [PATCH 0/4] block: Trivial fixes in offloading code

2018-07-04 Thread Max Reitz
On 2018-07-03 03:26, Fam Zheng wrote: > On Mon, 07/02 14:35, Max Reitz wrote: >> On 2018-07-02 04:58, Fam Zheng wrote: >>> These are the low priority ones spotted by Kevin and Max last week. >>> >>> Fam Zheng (4): >>> qcow2: Drop unused cluster_data >>> file-posix: Fix fd_open check in raw_co_c

Re: [Qemu-devel] [kvmtool test PATCH 22/24] kvmtool: arm64: Add support for guest physical address size

2018-07-04 Thread Will Deacon
On Fri, Jun 29, 2018 at 12:15:42PM +0100, Suzuki K Poulose wrote: > Add an option to specify the physical address size used by this > VM. > > Signed-off-by: Suzuki K Poulose > --- > arm/aarch64/include/kvm/kvm-config-arch.h | 5 - > arm/include/arm-common/kvm-config-arch.h | 1 + > 2 files

Re: [Qemu-devel] [PATCH v2 2/3] block/fleecing-filter: new filter driver for fleecing

2018-07-04 Thread Max Reitz
On 2018-07-03 13:15, Kevin Wolf wrote: > Am 02.07.2018 um 14:09 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.06.2018 20:40, Eric Blake wrote: >>> On 06/29/2018 12:30 PM, John Snow wrote: On 06/29/2018 11:15 AM, Vladimir Sementsov-Ogievskiy wrote: > We need to synchronize b

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. N/A. Internal error while reading log file --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Cornelia Huck
On Wed, 4 Jul 2018 15:34:40 +0200 Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > > On Tue, 3 Jul 2018 13:32:29 +0200 > > Kevin Wolf wrote: > > > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into > > > > > > the > > > > > > next release?

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Christian Borntraeger
On 07/04/2018 03:34 PM, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: >> On Tue, 3 Jul 2018 13:32:29 +0200 >> Kevin Wolf wrote: >> >> Has serial/gemoetry been fixed meanwhile and will it make it into the >> next release? > > I cannot find an archive

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 03:34:40PM +0200, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > > On Tue, 3 Jul 2018 13:32:29 +0200 > > Kevin Wolf wrote: > > > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into > > > > > > the > > > > > > next relea

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Programmingkid
> On Jul 3, 2018, at 11:31 PM, David Gibson wrote: > > On Tue, Jul 03, 2018 at 08:17:25AM -0700, Richard Henderson wrote: >> Beginning with John Arbuckle's fdiv test case, clean up some >> of the fp helpers. As with fdiv, fre and fresqrt are missing >> divide-by-zero exceptions. >> >> I've al

Re: [Qemu-devel] [PATCH] i386: Add support to get/set/migrate MSR (33H)

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 15:21, Jingqi Liu wrote: > The MSR (33H) controls support for #AC exception > for split locked accesses. When bit 29 of the MSR (33H) > is set, the processor causes an #AC exception to > be issued instead of suppressing LOCK on bus > (during split lock access). > > Signed-off-by: Jin

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 15:12, Jingqi Liu wrote: > Add the option split-lock-ac to control whether the #AC > exception is generated for split locked accesses, which > is introduced for the machine, there is an example to enable it: > -machine split-lock-ac=on > It is disabled on default. > > When bit 29 of

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > On Tue, 3 Jul 2018 13:32:29 +0200 > Kevin Wolf wrote: > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > > > > next release? > > > > > > > > I cannot find an archive that has it, but it is on the libvirt

[Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

2018-07-04 Thread Dou Liyang
Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0, but the numa_complete_configuration need add a new node if

[Qemu-devel] [PATCH] i386: Add support to get/set/migrate MSR (33H)

2018-07-04 Thread Jingqi Liu
The MSR (33H) controls support for #AC exception for split locked accesses. When bit 29 of the MSR (33H) is set, the processor causes an #AC exception to be issued instead of suppressing LOCK on bus (during split lock access). Signed-off-by: Jingqi Liu --- target/i386/cpu.h | 2 ++ target/i

Re: [Qemu-devel] [PATCH 2/2] block/backup: fix fleecing scheme: use serialized writes

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 13:39, Kevin Wolf wrote: Am 03.07.2018 um 20:07 hat Vladimir Sementsov-Ogievskiy geschrieben: Fleecing scheme works as follows: we want a kind of temporary snapshot of active drive A. We create temporary image B, with B->backing = A. Then we start backup(sync=none) from A to B. From t

[Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread Jingqi Liu
Add the option split-lock-ac to control whether the #AC exception is generated for split locked accesses, which is introduced for the machine, there is an example to enable it: -machine split-lock-ac=on It is disabled on default. When bit 29 of the MSR (33H) is set, the processor causes an #AC exc

Re: [Qemu-devel] [PATCH] block/crypto: Fix memory leak in create error path

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 02:58:02PM +0200, Kevin Wolf wrote: > Fixes: Coverity CID 1393782 > Signed-off-by: Kevin Wolf > --- > block/crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/crypto.c b/block/crypto.c > index 994172a3de..146d81c90a 100644 > --- a/bloc

Re: [Qemu-devel] 32-bit “qemu-system-i386 -enable-kvm” segfaults on x86_64

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 02:34:07PM +0200, Ludovic Courtès wrote: > Hello, > > (I’m reporting the issue here because for some reason the launchpad.net > login page redirects me to an “oops” page and fails to log me in.) > > On a Linux 4.17 x86_64 host, “qemu-system-i386 -enable-kvm”, where > qemu-

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Cornelia Huck
On Tue, 3 Jul 2018 13:32:29 +0200 Kevin Wolf wrote: > > > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > > > next release? > > > > > > I cannot find an archive that has it, but it is on the libvirt mailing > > > list as "[libvirt] [PATCH v3] qemu: format serial and

[Qemu-devel] [PATCH] block/crypto: Fix memory leak in create error path

2018-07-04 Thread Kevin Wolf
Fixes: Coverity CID 1393782 Signed-off-by: Kevin Wolf --- block/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/crypto.c b/block/crypto.c index 994172a3de..146d81c90a 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -551,7 +551,7 @@ static int coroutine_fn b

Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes

2018-07-04 Thread Dou Liyang
At 07/04/2018 07:52 PM, Dou Liyang wrote: Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0. Due to the

Re: [Qemu-devel] question: disk missing in the guest contingently when hotplug several virtio scsi disks consecutively.

2018-07-04 Thread Paolo Bonzini
On 03/07/2018 15:30, l00284672 wrote: > I got a solution, the patch is below: > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index 608fb18..4cdc2bb 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -2184,7 +2184,9 @@ static void scsi_disk_reset(DeviceState *dev) >  

[Qemu-devel] [RFC PATCH 4/6] hw/arm/virt-acpi-build: distinguish possible and present cpus

2018-07-04 Thread Andrew Jones
When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. We then ensure only the present CPUs are enabled. Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 20 +++- 1 file changed, 15 insertion

[Qemu-devel] [RFC PATCH 3/6] hw/arm/virt: DT: add cpu-map

2018-07-04 Thread Andrew Jones
Support devicetree CPU topology descriptions. Signed-off-by: Andrew Jones --- hw/arm/virt.c | 35 +++ include/hw/arm/virt.h | 1 + 2 files changed, 36 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 880441275031..6c5fecdd61df 100644 --- a/

Re: [Qemu-devel] [RFC v3 05/15] hw/arm/virt: handle max_vm_phys_shift conflicts on migration

2018-07-04 Thread Auger Eric
Hi David, On 07/04/2018 01:53 PM, David Hildenbrand wrote: > On 03.07.2018 21:32, Auger Eric wrote: >> Hi David, >> On 07/03/2018 08:41 PM, David Hildenbrand wrote: >>> On 03.07.2018 09:19, Eric Auger wrote: When migrating a VM, we must make sure the destination host supports as many IPA

[Qemu-devel] [RFC PATCH 6/6] hw/arm/virt: cpu topology: don't allow threads

2018-07-04 Thread Andrew Jones
None of the cpu models supported by mach-virt support threads. Furthermore when running with KVM and cpu=host, while the host processor may support threads, we don't yet support telling KVM that we want the guest to see that. So if the user tries to select more than one thread for the cpu topology,

[Qemu-devel] [RFC PATCH 5/6] virt-acpi-build: add PPTT table

2018-07-04 Thread Andrew Jones
The ACPI PPTT table supports topology descriptions for ACPI guests. Note, while a DT boot Linux guest with a non-flat CPU topology will see socket and core IDs being sequential integers starting from zero, e.g. with -smp 4,sockets=2,cores=2,threads=1 a DT boot produces cpu: 0 package_id: 0 cor

[Qemu-devel] [RFC PATCH 2/6] device_tree: add qemu_fdt_add_path

2018-07-04 Thread Andrew Jones
qemu_fdt_add_path works like qemu_fdt_add_subnode, except it also recursively adds any missing parent nodes. Cc: Peter Crosthwaite Cc: Alexander Graf Signed-off-by: Andrew Jones --- device_tree.c| 24 include/sysemu/device_tree.h | 1 + 2 files changed

[Qemu-devel] [RFC PATCH 0/6] hw/arm/virt: Introduce cpu topology support

2018-07-04 Thread Andrew Jones
This series provides support for booting mach-virt machines with non-flat cpu topology, i.e. enabling the extended options of the '-smp' command line parameter (sockets,cores,threads). Both DT and ACPI description generators are added. We only apply the new feature to 3.1 and later machine types, a

[Qemu-devel] [RFC PATCH 1/6] hw/arm/virt: Add virt-3.1 machine type

2018-07-04 Thread Andrew Jones
Signed-off-by: Andrew Jones --- hw/arm/virt.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 281ddcdf6e26..880441275031 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1757,10 +1757,7 @@ static void machvirt_machin

[Qemu-devel] 32-bit “qemu-system-i386 -enable-kvm” segfaults on x86_64

2018-07-04 Thread Ludovic Courtès
Hello, (I’m reporting the issue here because for some reason the launchpad.net login page redirects me to an “oops” page and fails to log me in.) On a Linux 4.17 x86_64 host, “qemu-system-i386 -enable-kvm”, where qemu-system-i386 is a 32-bit binary, crashes (it works fine without ‘-enable-kvm’):

Re: [Qemu-devel] [PATCH 2/2] block/backup: fix fleecing scheme: use serialized writes

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 13:39, Kevin Wolf wrote: Am 03.07.2018 um 20:07 hat Vladimir Sementsov-Ogievskiy geschrieben: Fleecing scheme works as follows: we want a kind of temporary snapshot of active drive A. We create temporary image B, with B->backing = A. Then we start backup(sync=none) from A to B. From t

<    1   2   3   >