Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-03-03 Thread Peter Xu
On Fri, Mar 01, 2019 at 10:11:42AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Feb 28, 2019 at 12:28:22PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Thu, Feb 28, 2019 at 11:40:19AM +, Dr. D

Re: [Qemu-devel] [PATCH v13 00/25] Fixing record/replay and adding reverse debugging

2019-03-03 Thread Pavel Dovgalyuk
Ping. Can anyone review block-related patches? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Thursday, February 21, 2019 2:04 PM > To: qemu-devel@nongnu.org > Cc: kw...@redhat.com; peter.mayd...@linaro.org; war2jor...@live.com; > cr

Re: [Qemu-devel] [PATCH] Fix for RSP vCont packet

2019-03-03 Thread Lucien Murray-Pitts via Qemu-devel
This fixes a regression in rsp packet vCont, this was due to the recently added multiprocess support. (Short commit hash: e40e520). The result is that vCont now does not recognise the case where no process/thread is provided after the action. This may not show up with GDB, but using Lauterbach Tr

Re: [Qemu-devel] [PATCH 06/10] r2d: Flash memory creation is confused about size, mark FIXME

2019-03-03 Thread Markus Armbruster
Magnus Damm writes: > Hi guys, > > On Wed, Feb 20, 2019 at 2:31 AM Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > On 2/19/19 4:45 PM, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> >> >>> On Mon, 18 Feb 2019 at 13:07, Markus Armbruster >> >>> wrote: >>

Re: [Qemu-devel] [PATCH] tests: Do not use "\n" in g_test_message() strings

2019-03-03 Thread Markus Armbruster
Thomas Huth writes: > g_test_message() takes care of the newline on its own, so we > should not use \n in the strings here. > > Signed-off-by: Thomas Huth Without "[PATCH] tests: Remove (mostly) useless architecture checks", the patch misses four instances of '\n', so: Based-on: <1551456970-46

[Qemu-devel] [PATCH v6 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-03-03 Thread Wei Yang
We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov --- v6: * add ) for last example o

[Qemu-devel] [PATCH v6 2/2] CODING_STYLE: indent example code as all others

2019-03-03 Thread Wei Yang
All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- CODING_STYLE | 8 1 file changed, 4 insertions(+), 4 deletions(

[Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update

2019-03-03 Thread Wei Yang
The first one is suggested by Igor Mammedov to provide rule for multiline code. The second is a trivial fix to make example code all indented with 4 spaces. v6: * add ) for last example of function v5: * mostly address function variants v4: * one exception case for function v3: * fix typo

Re: [Qemu-devel] [libvirt] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Mar 01, 2019 at 06:33:28PM +0100, Igor Mammedov wrote: >> On Fri, 1 Mar 2019 15:49:47 + >> Daniel P. Berrangé wrote: >> >> > On Fri, Mar 01, 2019 at 04:42:15PM +0100, Igor Mammedov wrote: >> > > The parameter allows to configure fake NUMA topology where

Re: [Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding

2019-03-03 Thread Samuel Thibault
Markus Armbruster, le lun. 04 mars 2019 07:44:34 +0100, a ecrit: > Samuel Thibault writes: > > --- a/qapi/ui.json > > +++ b/qapi/ui.json > > @@ -1131,6 +1131,7 @@ > > # @full-screen: Start user interface in fullscreen mode (default: off). > > # @window-close: Allow to quit qemu with window cl

Re: [Qemu-devel] [RFC PATCH v4 4/5] target/ppc: Refactor kvm_handle_debug

2019-03-03 Thread David Gibson
On Thu, Feb 28, 2019 at 07:57:58PM -0300, Fabiano Rosas wrote: > There are four scenarios being handled in this function: > > - single stepping > - hardware breakpoints > - software breakpoints > - fallback (no debug supported) > > A future patch will add code to handle specific single step and >

Re: [Qemu-devel] [RFC PATCH v4 3/5] target/ppc: Move handling of hardware breakpoints to a separate function

2019-03-03 Thread David Gibson
On Thu, Feb 28, 2019 at 07:57:57PM -0300, Fabiano Rosas wrote: > This is in preparation for a refactoring of the kvm_handle_debug > function in the next patch. > > Signed-off-by: Fabiano Rosas Nice cleanup regardless of anything else. Applied to ppc-for-4.0. > --- > target/ppc/kvm.c | 47

Re: [Qemu-devel] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

2019-03-03 Thread David Gibson
On Thu, Feb 28, 2019 at 07:57:56PM -0300, Fabiano Rosas wrote: > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > KVM_GUESTDBG_SINGLESTEP bit in the control field of the > kvm_guest_debug struct. > > This p

[Qemu-devel] [PATCH] exec.c: remove an unnecessary condition in flatview_add_to_dispatch()

2019-03-03 Thread Wei Yang
flatview_add_to_dispatch() registers page based on the condition of *section*, which may looks like this: |s|PPP|s| where s stands for subpage and P for page. The procedure of this function could be described as: - register first subpage - register page - register last subpa

Re: [Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding

2019-03-03 Thread Markus Armbruster
Samuel Thibault writes: > This uses iconv to convert glyphs from the specified VGA font encoding to > unicode, and makes use of cchar_t instead of chtype when using ncursesw, > which allows to store all wide char as well as the WACS values. > > Signed-off-by: Samuel Thibault > Cc: Eddie Kohler

Re: [Qemu-devel] [RFC PATCH v4 1/5] target/ppc: Move exception vector offset computation into a function

2019-03-03 Thread David Gibson
On Thu, Feb 28, 2019 at 07:57:55PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > Reviewed-by: Alexey Kardashevskiy This is a nice cleanup, regardless of the rest of the series. Applied to ppc-for-4.0. > --- > target/ppc/excp_helper.c | 30 +++--- > 1 fil

Re: [Qemu-devel] [PATCH 1/8] target/ppc: introduce single fpr_offset() function

2019-03-03 Thread David Gibson
On Sun, Mar 03, 2019 at 05:23:36PM +, Mark Cave-Ayland wrote: > Instead of having multiple copies of the offset calculation logic, move it to > a > single fpr_offset() function. > > Signed-off-by: Mark Cave-Ayland Applied to ppc-for-4.0, thanks. > --- > target/ppc/cpu.h | 7 ++-

Re: [Qemu-devel] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function

2019-03-03 Thread David Gibson
On Sun, Mar 03, 2019 at 05:23:37PM +, Mark Cave-Ayland wrote: > Instead of having multiple copies of the offset calculation logic, move it to > a > single vsrl_offset() function. > > This commit also renames the existing get_vsr()/set_vsr() functions to > get_vsrl()/set_vsrl() which better de

Re: [Qemu-devel] [PATCH 0/8] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order

2019-03-03 Thread David Gibson
On Sun, Mar 03, 2019 at 05:23:35PM +, Mark Cave-Ayland wrote: > After some investigation into Andrew's report of corruption in his ppc64le > tests at https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07234.html, > I > discovered the underlying cause was that the first 32 VSX registers a

Re: [Qemu-devel] [QEMU-PPC] [PATCH 0/2] Enable mitigations by default for pseries-4.0 machine type

2019-03-03 Thread David Gibson
On Fri, Mar 01, 2019 at 03:46:07PM +1100, Suraj Jitindar Singh wrote: > This series is based on the ppc-for-4.0 branch with my large-decrementer > and count-cache-flush series applied. > > Suraj Jitindar Singh (2): > target/ppc/tcg: make spapr_caps apply cap-[cfpc/sbbc/ibs] non-fatal > for t

Re: [Qemu-devel] [PATCH 06/10] r2d: Flash memory creation is confused about size, mark FIXME

2019-03-03 Thread Magnus Damm
Hi guys, On Wed, Feb 20, 2019 at 2:31 AM Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > On 2/19/19 4:45 PM, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On Mon, 18 Feb 2019 at 13:07, Markus Armbruster wrote: > > pflash_cfi02_register() takes a siz

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] Re-applying Freescale PPC E500 i2c/RTC patch

2019-03-03 Thread BALATON Zoltan
On Mon, 4 Mar 2019, Andrew Randrianasulu wrote: From: Amit Singh Tomar Original commit message: This patch adds an emulation model for i2c controller found on most of the FSL SoCs. It also integrates the RTC (ds1338) that sits on the i2c Bus with e500 machine model. Patch was originally writ

[Qemu-devel] [PATCH] x86: define a new MSR based feature word -- FEAT_CORE_CAPABILITY

2019-03-03 Thread Xiaoyao Li
MSR IA32_CORE_CAPABILITY is a feature-enumerating MSR, which enumerates the capabilitiy of enabling detection of split locks (bit 5 of MSR_TEST_CTL). MSR IA32_CORE_CAPABILITY can be enumerated by CPUID.0X7.0:EDX[30]. Related kernel patches can be found here: https://lkml.org/lkml/2019/3/1/749 Pat

Re: [Qemu-devel] [RFC v2 31/38] target/xtensa: fetch code with translator_ld

2019-03-03 Thread Max Filippov
On Mon, Feb 25, 2019 at 6:55 AM Alex Bennée wrote: > Emilio G. Cota writes: > > Signed-off-by: Emilio G. Cota > > --- > > target/xtensa/translate.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c > > index

Re: [Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn

2019-03-03 Thread Peter Xu
On Fri, Mar 01, 2019 at 04:25:17PM +, Stefan Hajnoczi wrote: > On Thu, Feb 28, 2019 at 01:58:56PM +0800, Peter Xu wrote: > > On Wed, Feb 27, 2019 at 01:38:38PM +, Stefan Hajnoczi wrote: > > > On Fri, Feb 22, 2019 at 02:57:24PM +0800, Peter Xu wrote: > > > > On Fri, Feb 22, 2019 at 07:37:02A

Re: [Qemu-devel] [PATCH v2] Re-applying Freescale PPC E500 i2c/RTC patch

2019-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190304015401.14280-1-randrianas...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190304015401.14280-1-randrianas...@gmail.com Subject: [Qemu-devel] [PATCH v2] Re-ap

[Qemu-devel] [PATCH v2] Re-applying Freescale PPC E500 i2c/RTC patch

2019-03-03 Thread Andrew Randrianasulu
From: Amit Singh Tomar Original commit message: This patch adds an emulation model for i2c controller found on most of the FSL SoCs. It also integrates the RTC (ds1338) that sits on the i2c Bus with e500 machine model. Patch was originally written by Amit Singh Tomar see http://patchwork.ozla

Re: [Qemu-devel] [QEMU-PPC] [PATCH v3 1/4] target/ppc/spapr: Add SPAPR_CAP_LARGE_DECREMENTER

2019-03-03 Thread David Gibson
On Fri, Mar 01, 2019 at 01:43:14PM +1100, Suraj Jitindar Singh wrote: > Add spapr_cap SPAPR_CAP_LARGE_DECREMENTER to be used to control the > availability of the large decrementer for a guest. > > Signed-off-by: Suraj Jitindar Singh Series applied to ppc-for-4.0, thanks. > --- > hw/ppc/spapr.c

Re: [Qemu-devel] [QEMU-PPC] [PATCH 2/2] target/ppc/spapr: Add SPAPR_CAP_CCF_ASSIST

2019-03-03 Thread David Gibson
On Fri, Mar 01, 2019 at 03:26:45PM +1100, Suraj Jitindar Singh wrote: > On Fri, 2019-03-01 at 14:19 +1100, Suraj Jitindar Singh wrote: > > Introduce a new spapr_cap SPAPR_CAP_CCF_ASSIST to be used to indicate > > the requirement for a hw-assisted version of the count cache flush > > workaround. > >

Re: [Qemu-devel] [PATCH 2/2] spapr: Simulate CAS for qtest

2019-03-03 Thread David Gibson
On Fri, Mar 01, 2019 at 04:33:38PM -0600, Michael Roth wrote: > Quoting Greg Kurz (2019-03-01 13:32:37) > > The RTAS event hotplug code for machine types 2.8 and newer depends on > > the CAS negotiated ov5 in order to work properly. However, there's no > > CAS when running under qtest. There has be

Re: [Qemu-devel] [PATCH] Re-applying Freescale PPC E500 i2c/RTC patch

2019-03-03 Thread Andrew Randrianasulu
В сообщении от Monday 04 March 2019 02:57:28 David Gibson написал(а): > On Sun, Mar 03, 2019 at 12:21:21AM +0300, Andrew Randrianasulu wrote: > > From ad2b4baf8b369c8ef354e56f75ae780413acd989 Mon Sep 17 00:00:00 2001 > > From: Amit Singh Tomar > > Date: Sun, 3 Mar 2019 00:05:04 +0300 > > Subject:

Re: [Qemu-devel] [PATCH] hw/arm/acpi: enable SHPC native hot plug

2019-03-03 Thread Heyi Guo
On 2019/3/4 7:38, Michael S. Tsirkin wrote: On Fri, Mar 01, 2019 at 10:28:30AM +0800, Heyi Guo wrote: After the introduction of generic PCIe root port and PCIe-PCI bridge, we will also have SHPC controller on ARM, so just enalbe SHPC native hot plug. Cc: Shannon Zhao Cc: Peter Maydell Cc:

Re: [Qemu-devel] [PATCH] Re-applying Freescale PPC E500 i2c/RTC patch

2019-03-03 Thread David Gibson
On Sun, Mar 03, 2019 at 12:21:21AM +0300, Andrew Randrianasulu wrote: > From ad2b4baf8b369c8ef354e56f75ae780413acd989 Mon Sep 17 00:00:00 2001 > From: Amit Singh Tomar > Date: Sun, 3 Mar 2019 00:05:04 +0300 > Subject: [PATCH] Re-applying Freescale PPC E500 i2c/RTC patch > > Patch was originally w

Re: [Qemu-devel] [PATCH] hw/arm/acpi: enable SHPC native hot plug

2019-03-03 Thread Michael S. Tsirkin
On Fri, Mar 01, 2019 at 10:28:30AM +0800, Heyi Guo wrote: > After the introduction of generic PCIe root port and PCIe-PCI bridge, > we will also have SHPC controller on ARM, so just enalbe SHPC native > hot plug. > > Cc: Shannon Zhao > Cc: Peter Maydell > Cc: "Michael S. Tsirkin" > Cc: Igor Mam

Re: [Qemu-devel] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > static inline void get_cpu_vsrh(TCGv_i64 dst, int n) > { > -if (n < 32) { > -get_fpr(dst, n); > -} else { > -get_avr64(dst, n - 32, true); > -} > +tcg_gen_ld_i64(dst, cpu_env, vsrh_offset(n)); > } > > static inline v

Re: [Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > -static inline int fpr_offset(int i) > +static inline int vsrh_offset(int i) I don't agree with this. The original is clearer for its uses. r~

Re: [Qemu-devel] [PATCH 6/8] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > When VSX support was initially added, the fpr registers were added at > offset 0 of the VSR register and the vsrl registers were added at offset > 1. This is in contrast to the VMX registers (the last 32 VSX registers) which > are stored in host-endian o

Re: [Qemu-devel] [PATCH 4/8] target/ppc: introduce avrh_offset() and avrl_offset() functions

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > These will become more useful later, but initially use this as an aid to > simplify the offset calculation by replacing the HOST_TARGET_BIGENDIAN > sections with the VsrD macro. > > Signed-off-by: Mark Cave-Ayland > --- > target/ppc/cpu.h | 10 +

Re: [Qemu-devel] [PATCH 5/8] target/ppc: introduce avr_offset() function

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > All TCG vector operations require pointers to the base address of the vector > rather than separate access to the top and bottom 64-bits. Convert > the VMX TCG instructions to use a new avr_offset() function instead of > avr64_offset(), which can itself

Re: [Qemu-devel] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > Instead of having multiple copies of the offset calculation logic, move it to > a > single vsrl_offset() function. > > This commit also renames the existing get_vsr()/set_vsr() functions to > get_vsrl()/set_vsrl() which better describes their purpose.

Re: [Qemu-devel] [PATCH 1/8] target/ppc: introduce single fpr_offset() function

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > Instead of having multiple copies of the offset calculation logic, move it to > a > single fpr_offset() function. > > Signed-off-by: Mark Cave-Ayland > --- > target/ppc/cpu.h | 7 ++- > target/ppc/translate.c | 4 ++-- > 2 files changed, 8

Re: [Qemu-devel] [PATCH v6 72/73] cpu: add async_run_on_cpu_no_bql

2019-03-03 Thread Emilio G. Cota
On Fri, Feb 08, 2019 at 14:58:40 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Some async jobs do not need the BQL. > > > > Reviewed-by: Richard Henderson > > Signed-off-by: Emilio G. Cota (snip) > So we now have a locking/scheduling hierarchy that goes: > > - run_on_cpu - sync

[Qemu-devel] [PATCH v4 9/9] hw/pvrdma: Unregister from shutdown notifier when device goes down

2019-03-03 Thread Yuval Shaia
This hook was installed to close the device when VM is going down. After the device is closed there is no need to be informed on VM shutdown. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/rdma/vmw/

[Qemu-devel] [PATCH v4 1/9] hw/rdma: Switch to generic error reporting way

2019-03-03 Thread Yuval Shaia
Utilize error_report for all pr_err calls and some pr_dbg that are considered as errors. For the remaining pr_dbg calls, the important ones were replaced by trace points while other deleted. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c| 336 +++

[Qemu-devel] [PATCH v4 4/9] {hmp, hw/pvrdma}: Expose device internals via monitor interface

2019-03-03 Thread Yuval Shaia
Allow interrogating device internals through HMP interface. The exposed indicators can be used for troubleshooting by developers or sysadmin. There is no need to expose these attributes to a management system (e.x. libvirt) because (1) most of them are not "device-management' related info and (2) t

[Qemu-devel] [PATCH v4 8/9] hw/pvrdma: Delete pvrdma_exit function

2019-03-03 Thread Yuval Shaia
This hook is not called and was implemented by mistake. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index b795f80666..4e4a43eac4 100644 --- a

[Qemu-devel] [PATCH v4 6/9] hw/rdma: Free all receive buffers when QP is destroyed

2019-03-03 Thread Yuval Shaia
When QP is destroyed the backend QP is destroyed as well. This ensures we clean all received buffer we posted to it. However, a contexts of these buffers are still remain in the device. Fix it by maintaining a list of buffer's context and free them when QP is destroyed. Signed-off-by: Yuval Shaia

[Qemu-devel] [PATCH v4 3/9] hw/rdma: Protect against concurrent execution of poll_cq

2019-03-03 Thread Yuval Shaia
The function rdma_poll_cq is called from two contexts - completion handler thread which sense new completion on backend channel and explicitly as result of guest issuing poll_cq command. Add lock to protect against concurrent executions. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum

[Qemu-devel] [PATCH v4 7/9] hw/pvrdma: Delete unneeded function argument

2019-03-03 Thread Yuval Shaia
The function's argument rdma_dev_res is not needed as it is stored in the backend_dev object at init. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 13 ++--- hw/rdma/rdma_backend.h | 1 - hw/rdma/vmw/pvrdma_qp_ops.c | 3 +-- 3 files ch

[Qemu-devel] [PATCH v4 2/9] hw/rdma: Introduce protected qlist

2019-03-03 Thread Yuval Shaia
To make code more readable move handling of protected list to a rdma_utils Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 20 +-- hw/rdma/rdma_backend_defs.h | 8 ++-- hw/rdma/rdma_utils.c| 39 +

[Qemu-devel] [PATCH v4 0/9] Misc fixes to pvrdma device

2019-03-03 Thread Yuval Shaia
Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for reviewing v0. David, please see version notes below, since i restructured the HMP part your second

[Qemu-devel] [PATCH v4 5/9] hw/rdma: Free all MAD receive buffers when device is closed

2019-03-03 Thread Yuval Shaia
When device is going down free all saved MAD buffers. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c| 34 +- hw/rdma/vmw/pvrdma_main.c | 2 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/hw/rdma/rdma_ba

Re: [Qemu-devel] [PATCH v6 62/73] cpu: introduce cpu_has_work_with_iothread_lock

2019-03-03 Thread Emilio G. Cota
On Fri, Feb 08, 2019 at 11:33:32 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > It will gain some users soon. > > > > Suggested-by: Paolo Bonzini > > Reviewed-by: Richard Henderson > > Signed-off-by: Emilio G. Cota > > --- > > include/qom/cpu.h | 36 ++

[Qemu-devel] [PULLv2] Reduce curses escdelay from 1s to 25ms

2019-03-03 Thread Samuel Thibault
By default, curses will only report single ESC key event after 1s delay, since ESC is also used for keypad escape sequences. This however makes users believe that ESC is not working. Reducing to 25ms provides good user experience, while still allowing 25ms for keypad sequences to get in, which shou

[Qemu-devel] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions

2019-03-03 Thread Mark Cave-Ayland
Now that the VSX registers are all in host endian order, there is no need to go via different accessors depending upon the register number. Instead the high and low parts can be accessed directly via vsrh_offset() and vsrl_offset() accordingly. Signed-off-by: Mark Cave-Ayland --- target/ppc/tran

[Qemu-devel] [PATCH 3/8] target/ppc: move Vsr* macros from internal.h to cpu.h

2019-03-03 Thread Mark Cave-Ayland
It isn't possible to include internal.h from cpu.h so move the Vsr* macros into cpu.h alongside the other VMX/VSX register access functions. Signed-off-by: Mark Cave-Ayland --- target/ppc/cpu.h | 20 target/ppc/internal.h | 19 --- 2 files changed, 20 in

[Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function

2019-03-03 Thread Mark Cave-Ayland
Now that both VSX and VMX registers are in host-endian order we can introduce a vsrh_offset() function as a replacement for fpr_offset(). In addition the avrh_offset() and avrl_offset() functions can be simplified in terms of vsrh_offset() and vsrl_offset(). Signed-off-by: Mark Cave-Ayland ---

[Qemu-devel] [PATCH 0/8] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order

2019-03-03 Thread Mark Cave-Ayland
After some investigation into Andrew's report of corruption in his ppc64le tests at https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07234.html, I discovered the underlying cause was that the first 32 VSX registers are not stored in host endian order. This is something that Richard and I h

[Qemu-devel] [PATCH 5/8] target/ppc: introduce avr_offset() function

2019-03-03 Thread Mark Cave-Ayland
All TCG vector operations require pointers to the base address of the vector rather than separate access to the top and bottom 64-bits. Convert the VMX TCG instructions to use a new avr_offset() function instead of avr64_offset(), which can itself be written as a simple wrapper onto vsr_full_offset

[Qemu-devel] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function

2019-03-03 Thread Mark Cave-Ayland
Instead of having multiple copies of the offset calculation logic, move it to a single vsrl_offset() function. This commit also renames the existing get_vsr()/set_vsr() functions to get_vsrl()/set_vsrl() which better describes their purpose. Signed-off-by: Mark Cave-Ayland --- target/ppc/cpu.h

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

2019-03-03 Thread Samuel Thibault
Warner Losh, le dim. 03 mars 2019 10:11:52 -0700, a ecrit: > On Sun, Mar 3, 2019, 12:45 AM Samuel Thibault > <[1]samuel.thiba...@ens-lyon.org> > wrote: > > By default, curses will only report single ESC key event after 1s delay, > since ESC is also used for keypad escape sequences. This h

[Qemu-devel] [PATCH 6/8] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order

2019-03-03 Thread Mark Cave-Ayland
When VSX support was initially added, the fpr registers were added at offset 0 of the VSR register and the vsrl registers were added at offset 1. This is in contrast to the VMX registers (the last 32 VSX registers) which are stored in host-endian order. Switch the fpr/vsrl registers so that the lo

[Qemu-devel] [PATCH 4/8] target/ppc: introduce avrh_offset() and avrl_offset() functions

2019-03-03 Thread Mark Cave-Ayland
These will become more useful later, but initially use this as an aid to simplify the offset calculation by replacing the HOST_TARGET_BIGENDIAN sections with the VsrD macro. Signed-off-by: Mark Cave-Ayland --- target/ppc/cpu.h | 10 ++ target/ppc/translate.c | 24 ++

[Qemu-devel] [PATCH 1/8] target/ppc: introduce single fpr_offset() function

2019-03-03 Thread Mark Cave-Ayland
Instead of having multiple copies of the offset calculation logic, move it to a single fpr_offset() function. Signed-off-by: Mark Cave-Ayland --- target/ppc/cpu.h | 7 ++- target/ppc/translate.c | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/target/ppc/cpu.h b

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

2019-03-03 Thread Warner Losh
On Sun, Mar 3, 2019, 12:45 AM Samuel Thibault wrote: > By default, curses will only report single ESC key event after 1s delay, > since ESC is also used for keypad escape sequences. This however makes > users > believe that ESC is not working. Reducing to 0.2s provides good enough user > experien

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-03 Thread Philippe Mathieu-Daudé
On 3/3/19 4:40 PM, Aleksandar Markovic wrote: > On Sunday, March 3, 2019, BALATON Zoltan wrote: > >> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI >> gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and >> guests running on these and the PMON2000 firmware of the

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-03 Thread Philippe Mathieu-Daudé
On 3/3/19 1:46 PM, BALATON Zoltan wrote: > On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, >> >> On 3/3/19 12:34 AM, BALATON Zoltan wrote: >>> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI >>> gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and >>>

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-03 Thread Aleksandar Markovic
On Sunday, March 3, 2019, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available. Fortunately t

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-03 Thread Philippe Mathieu-Daudé
On 3/3/19 3:04 PM, BALATON Zoltan wrote: > On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: >> On 3/3/19 1:46 PM, BALATON Zoltan wrote: >>> On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: > diff --git a/hw/display/trace-events b/hw/display/trace-events > index 37d3264bb2..6aed33eeaa 10

[Qemu-devel] [PATCH V3 0/7] Migration/colo: Fix upstream bugs when occur failover

2019-03-03 Thread Zhang Chen
From: Zhang Chen This series focus on COLO failover bug fix and optimization. V3: - Fix grammer issues in patch 4/7. - Add more information in commit log of patch 5/7. V2: - Add patch 4/7 to handle failover state. - Add new patches to optimize failover status. V1: - Init patch. Zhang Ch

[Qemu-devel] [PATCH V3 1/7] Migration/colo.c: Fix double close bug when occur COLO failover

2019-03-03 Thread Zhang Chen
From: Zhang Chen In migration_incoming_state_destroy(void) will check the mis->to_src_file to double close the mis->to_src_file when occur COLO failover. Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migr

[Qemu-devel] [PATCH V3 2/7] Migration/colo.c: Fix COLO failover status error

2019-03-03 Thread Zhang Chen
From: Zhang Chen When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. Signed-off-by: Zhang Chen --- migration/colo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/colo.c b/migrat

[Qemu-devel] [PATCH V3 7/7] Migration/colo.c: Make user obtain the COLO mode info after failover

2019-03-03 Thread Zhang Chen
From: Zhang Chen Add the last_colo_mode to save the status after failover. This patch can solve the issue that user got nothing to call query_colo_status after failover. Signed-off-by: Zhang Chen --- migration/colo.c | 28 +++- 1 file changed, 23 insertions(+), 5 deleti

[Qemu-devel] [PATCH V3 3/7] Migration/colo.c: Make COLO node running after failover

2019-03-03 Thread Zhang Chen
From: Zhang Chen Delay to close COLO for auto start VM after failover. Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 1 - migration/migration.c | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/colo.c b/migration/colo.

[Qemu-devel] [PATCH V3 4/7] Migration/colo.c: Add new COLOExitReason to handle all failover state

2019-03-03 Thread Zhang Chen
From: Zhang Chen In this patch we add the processing state for COLOExitReason, because we have to identify COLO in the failover processing state or failover error state. In the way, we can handle all the failover state. We have improved the description of the COLOExitReason by the way. Signed-of

[Qemu-devel] [PATCH V3 6/7] Migration/colo.c: Add the necessary checks for colo_do_failover

2019-03-03 Thread Zhang Chen
From: Zhang Chen Signed-off-by: Zhang Chen --- migration/colo.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index dbe2b88807..d1ae2e6d11 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -197,10 +197,16 @@ void colo_do

[Qemu-devel] [PATCH V3 5/7] qapi/migration.json: Remove a variable that doesn't exist in example

2019-03-03 Thread Zhang Chen
From: Zhang Chen Remove the "active" variable in example for query-colo-status. It is a doc bug from commit f56c0065 Signed-off-by: Zhang Chen Reviewed-by: Eric Blake --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migrati

Re: [Qemu-devel] [PATCH] tests: Remove (mostly) useless architecture checks

2019-03-03 Thread Thomas Huth
On 01/03/2019 18.57, John Snow wrote: > > > On 3/1/19 11:16 AM, Thomas Huth wrote: >> These checks at the beginning of some of the tests are mostly useless: >> We only run the tests on x86 anyway, and g_test_message() does not >> print anything unless you call g_test_init() first. >> >> Signed-of

Re: [Qemu-devel] [PATCH V2 5/7] qapi/migration.json: Remove a variable that doesn't exist in example

2019-03-03 Thread Zhang, Chen
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Friday, March 1, 2019 1:07 AM To: Zhang, Chen ; Li Zhijian ; Zhang Chen ; Dr. David Alan Gilbert ; Juan Quintela ; zhanghailiang ; Markus Armbruster ; qemu-dev Subject: Re: [PATCH V2 5/7] qapi/migration.json: Remov

Re: [Qemu-devel] [PATCH V2 4/7] Migration/colo.c: Add new COLOExitReason to handle all failover state

2019-03-03 Thread Zhang, Chen
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Friday, March 1, 2019 1:05 AM To: Zhang, Chen ; Li Zhijian ; Zhang Chen ; Dr. David Alan Gilbert ; Juan Quintela ; zhanghailiang ; Markus Armbruster ; qemu-dev Subject: Re: [PATCH V2 4/7] Migration/colo.c: Add new C

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-03 Thread BALATON Zoltan
On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: On 3/3/19 1:46 PM, BALATON Zoltan wrote: On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: +??? case RBBM_STATUS: ? /* fall through */ +??? case GUI_STAT: +??? val = 64; /* free CMDFIFO entries */ +??? break; Obviously fall

Re: [Qemu-devel] [PATCH RFC v3 08/11] RX62N internal serial communication interface

2019-03-03 Thread Yoshinori Sato
On Sun, 03 Mar 2019 04:21:10 +0900, Philippe Mathieu-Daudé wrote: > > Hi Yoshinori, > > On 3/2/19 7:21 AM, Yoshinori Sato wrote: > > This module supported only non FIFO type. > > Hardware manual. > > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf?key=086

Re: [Qemu-devel] [PATCH RFC v3 11/11] MAINTAINERS: Add RX entry.

2019-03-03 Thread Yoshinori Sato
On Sun, 03 Mar 2019 04:03:19 +0900, Philippe Mathieu-Daudé wrote: > > On 3/2/19 7:21 AM, Yoshinori Sato wrote: > > Signed-off-by: Yoshinori Sato > > --- > > MAINTAINERS | 20 > > 1 file changed, 20 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5040d

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-03 Thread Philippe Mathieu-Daudé
On 3/3/19 1:46 PM, BALATON Zoltan wrote: > On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, >> >> On 3/3/19 12:34 AM, BALATON Zoltan wrote: >>> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI >>> gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and >>>

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-03 Thread BALATON Zoltan
On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 3/3/19 12:34 AM, BALATON Zoltan wrote: At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the fu

[Qemu-devel] [Bug 1818398] [NEW] No evdev mouse passthrough with virtio-vga or kvm

2019-03-03 Thread Yohann Agrebbe
Public bug reported: Hi, Using qemu version 3.1.0-1 on a host with the latest Archlinux 64-bit distribution, and running the same OS as guest, the mouse doesn't work when using both evdev passthrough and virtio-vga, or when using both evdev passthrough and kvm. The following command line runs a

Re: [Qemu-devel] [RFC] multi phase reset

2019-03-03 Thread Peter Maydell
On Sat, 2 Mar 2019 at 19:41, Philippe Mathieu-Daudé wrote: > > Hi Damien, > > On 3/1/19 5:52 PM, Peter Maydell wrote: > > On Fri, 1 Mar 2019 at 15:34, Damien Hedde > > wrote: > >> On 3/1/19 12:43 PM, Peter Maydell wrote: > >>> In my design the only thing that I thought would happen in phase 3 >

[Qemu-devel] [PATCH 0/2] curses: Add support for wide output

2019-03-03 Thread Samuel Thibault
Hello, This adds support for wide output in the curses frontend Samuel Thibault (2): iconv: detect and make curses depend on it curses: add option to specify VGA font encoding configure | 45 ++- qapi/ui.json| 4 +- qemu-options.hx | 5 +- ui/curses.c | 315 ++

[Qemu-devel] [PATCH 1/2] iconv: detect and make curses depend on it

2019-03-03 Thread Samuel Thibault
curses will use it for proper wide output support. Signed-off-by: Samuel Thibault --- configure | 40 vl.c | 2 +- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 540bee19ba..9979ca708d 100755 --- a/configu

[Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding

2019-03-03 Thread Samuel Thibault
This uses iconv to convert glyphs from the specified VGA font encoding to unicode, and makes use of cchar_t instead of chtype when using ncursesw, which allows to store all wide char as well as the WACS values. Signed-off-by: Samuel Thibault Cc: Eddie Kohler --- configure | 5 +- qapi/u

Re: [Qemu-devel] [PATCH v2 5/5] contrib: gitdm: add a mapping for Janus Technologies

2019-03-03 Thread Marcel Apfelbaum
On 3/1/19 12:03 PM, Alex Bennée wrote: Currently this just includes Marcel who is a fairly prolific contributor. Cc: Marcel Apfelbaum Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-janustech | 5 + gitdm.config | 1 + 2 files changed, 6 insertions(+) c

Re: [Qemu-devel] [PATCH v3 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-03-03 Thread Marcel Apfelbaum
On 3/1/19 2:28 PM, Yuval Shaia wrote: On Fri, Mar 01, 2019 at 08:17:02AM +0100, Markus Armbruster wrote: Marcel Apfelbaum writes: Hi Yuval, On 2/27/19 4:06 PM, Yuval Shaia wrote: Allow interrogating device internals through HMP interface. The exposed indicators can be used for troublesho

Re: [Qemu-devel] [PATCH RFC v3 00/11] Add RX archtecture support

2019-03-03 Thread Yoshinori Sato
On Sun, 03 Mar 2019 03:51:14 +0900, Philippe Mathieu-Daudé wrote: > > Hi Yoshinori, > > On 3/2/19 7:21 AM, Yoshinori Sato wrote: > > Hello. > > This patch series is added Renesas RX target emulation. > > > > My git repository is bellow. > > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git > >