Re: [Qemu-devel] [PATCH v7 2/2] Add Nios II semihosting support.

2019-04-03 Thread Sandra Loosemore
On 4/3/19 11:59 PM, Peter Maydell wrote: On Thu, 4 Apr 2019 at 02:53, Sandra Loosemore wrote: This patch adds support for libgloss semihosting to Nios II bare-metal emulation. The specification for the protocol can be found in the libgloss sources. Signed-off-by: Sandra Loosemore Signed-off

Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver

2019-04-03 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 08:40:13AM -0400, Pankaj Gupta wrote: > > > Subject: Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver > > > > On Wed, Apr 03, 2019 at 04:10:15PM +0530, Pankaj Gupta wrote: > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > Guest reads t

Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-04-03 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, April 4, 2019 9:43 AM > To: Zhang, Chen > Cc: Dr. David Alan Gilbert ; qemu-dev de...@nongnu.org>; John Snow ; Fam Zheng > > Subject: Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops f

Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-03 Thread Pankaj Gupta
Hi Dave, > > Virtio pmem provides asynchronous host page cache flush > > mechanism. we don't support 'MAP_SYNC' with virtio pmem > > and xfs. > > > > Signed-off-by: Pankaj Gupta > > --- > > fs/xfs/xfs_file.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/fs/xfs/xfs_fi

Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-03 Thread Pankaj Gupta
> > On Thu, Apr 04, 2019 at 09:09:12AM +1100, Dave Chinner wrote: > > On Wed, Apr 03, 2019 at 04:10:18PM +0530, Pankaj Gupta wrote: > > > Virtio pmem provides asynchronous host page cache flush > > > mechanism. we don't support 'MAP_SYNC' with virtio pmem > > > and xfs. > > > > > > Signed-off-b

Re: [Qemu-devel] [PATCH v7 2/2] Add Nios II semihosting support.

2019-04-03 Thread Peter Maydell
On Thu, 4 Apr 2019 at 02:53, Sandra Loosemore wrote: > > This patch adds support for libgloss semihosting to Nios II bare-metal > emulation. The specification for the protocol can be found in the > libgloss sources. > > Signed-off-by: Sandra Loosemore > Signed-off-by: Julian Brown I gave a rev

Re: [Qemu-devel] [PATCH v2] migration: avoid filling ignore-shared ramblock when in incoming migration

2019-04-03 Thread Peter Xu
On Wed, Apr 03, 2019 at 11:21:47PM +0800, Catherine Ho wrote: > Hi Peter Xu > > On Wed, 3 Apr 2019 at 10:25, Peter Xu wrote: > > > On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine Ho wrote: > > > Commit 18269069c310 ("migration: Introduce ignore-shared capability") > > > addes ignore-shared c

Re: [Qemu-devel] [PATCH 0/3] numa: move numa global variables into MachineState

2019-04-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190404033429.17232-1-tao3...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time m

[Qemu-devel] Proof of concept for GPU forwarding for Linux guest on Linux host

2019-04-03 Thread Tao Wu via Qemu-devel
Hi, This is a proof of concept of GPU forwarding for Linux guest on Linux host. I'd like to get comments and suggestions from community before I put more time on it. To summarize what it is: 1. It's a solution to bring GPU acceleration for Linux vm guest on Linux host. It could works with differe

[Qemu-devel] [PATCH 1/1] proof of concept for GPU forwarding

2019-04-03 Thread Tao Wu via Qemu-devel
--- arch/x86/configs/x86_64_defconfig |5 + drivers/char/Makefile |1 + drivers/char/forwarder/Makefile|8 + drivers/char/forwarder/forwarder.h | 103 ++ drivers/char/forwarder/forwarder_drv.c | 2104 fs/open.c

[Qemu-devel] [PATCH 2/3] numa: move numa global variable have_numa_distance into MachineState

2019-04-03 Thread Tao Xu
The aim of this patch is to move existing numa global have_numa_distance into NumaState. Suggested-by: Igor Mammedov Suggested-by: Eduardo Habkost Signed-off-by: Tao Xu --- hw/arm/virt-acpi-build.c | 1 + hw/arm/virt.c| 1 + hw/i386/acpi-build.c | 2 +- include/hw/boards.h

[Qemu-devel] [PATCH 3/3] numa: move numa global variable numa_info into MachineState

2019-04-03 Thread Tao Xu
The aim of this patch is to move existing numa global numa_info into NumaState. Suggested-by: Igor Mammedov Suggested-by: Eduardo Habkost Signed-off-by: Tao Xu --- exec.c | 1 + hw/acpi/aml-build.c | 1 + hw/arm/boot.c| 1 + hw/arm/virt-acpi-build.c | 1 +

[Qemu-devel] [PATCH 0/3] numa: move numa global variables into MachineState

2019-04-03 Thread Tao Xu
The aim of this patch is to add struct NumaState in MachineState and move existing numa global nb_numa_nodes into NumaState. And add variable numa_support into MachineClass to decide which submachines support NUMA. Tao Xu (3): numa: move numa global variable nb_numa_nodes into MachineState num

[Qemu-devel] [PATCH 1/3] numa: move numa global variable nb_numa_nodes into MachineState

2019-04-03 Thread Tao Xu
The aim of this patch is to add struct NumaState in MachineState and move existing numa global nb_numa_nodes into NumaState. And add variable numa_support into MachineClass to decide which submachines support NUMA. Suggested-by: Igor Mammedov Suggested-by: Eduardo Habkost Signed-off-by: Tao Xu

Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties

2019-04-03 Thread Like Xu
On 2019/3/29 18:21, Igor Mammedov wrote: On Fri, 29 Mar 2019 16:48:36 +0800 Like Xu wrote: This patch series make existing cores/threads/sockets into machine properties and get rid of global variables they use currently. Thanks for looking into it! Its long overdue and rather desired conversi

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Peter Maydell
On Wed, 3 Apr 2019 at 23:27, Daniel P. Berrangé wrote: > > On Wed, Apr 03, 2019 at 02:49:48PM +0200, Helge Deller wrote: > > diff --git a/configure b/configure > > index 1c563a7027..8632267049 100755 > > --- a/configure > > +++ b/configure > > @@ -2389,7 +2389,6 @@ if test "$seccomp" != "no" ; the

Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-04-03 Thread Peter Maydell
On Sat, 30 Mar 2019 at 03:09, Zhang Chen wrote: > > From: Zhang Chen > > In current codes we use change_bit() to finish the job. > > Signed-off-by: Zhang Chen > --- > include/qemu/bitmap.h | 1 - > include/qemu/bitops.h | 15 --- > 2 files changed, 16 deletions(-) Do we gain anyth

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Peter Maydell
On Thu, 4 Apr 2019 at 04:05, Eduardo Habkost wrote: > > > CCing the right Eduardo. :) Oops, sorry! Can I blame my email client's autocompletion? :-) -- PMM

[Qemu-devel] [PULL] RISC-V Patches for 4.0-rc3

2019-04-03 Thread Palmer Dabbelt
The following changes since commit 49fc899f8d673dd9e73f3db0d9e9ea60b77c331b: Update version for v4.0.0-rc1 release (2019-03-26 17:02:29 +) are available in the Git repository at: git://github.com/palmer-dabbelt/qemu.git tags/riscv-for-master-4.0-rc3 for you to fetch changes up to b84ffc

[Qemu-devel] [Bug 1818483] Re: qemu user mode does not support binfmt_misc config with flags include "P"

2019-04-03 Thread YunQiang Su
This patch is for qemu itself. It test AT_FLAGS and determine whether it is start by binfmt_misc and whether P flag is used. ** Patch added: "preserve-argv0.patch" https://bugs.launchpad.net/qemu/+bug/1818483/+attachment/5252630/+files/preserve-argv0.patch -- You received this bug notificat

Re: [Qemu-devel] [PATCH for 4.0 v2 0/2] Update the QEMU PLIC addresses

2019-04-03 Thread Palmer Dabbelt
On Wed, 03 Apr 2019 16:32:11 PDT (-0700), alistai...@gmail.com wrote: On Wed, Mar 27, 2019 at 8:23 PM Palmer Dabbelt wrote: On Wed, 27 Mar 2019 11:51:15 PDT (-0700), Alistair Francis wrote: > This series updates the PLIC address to match the documentation. > > This fixes: https://github.com/ri

[Qemu-devel] [PULL 1/2] riscv: plic: Fix incorrect irq calculation

2019-04-03 Thread Palmer Dabbelt
From: Alistair Francis This patch fixes four different things, to maintain bisectability they have been merged into a single patch. The following fixes are below: sifive_plic: Fix incorrect irq calculation The irq is incorrectly calculated to be off by one. It has worked in the past as the prior

[Qemu-devel] [PULL 2/2] riscv: plic: Log guest errors

2019-04-03 Thread Palmer Dabbelt
From: Alistair Francis Instead of using error_report() to print guest errors let's use qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Palmer Dabbelt --- hw/riscv/sifive_plic.

Re: [Qemu-devel] [PATCH for 4.0 v2 0/2] Update the QEMU PLIC addresses

2019-04-03 Thread Alistair Francis
On Wed, Mar 27, 2019 at 8:23 PM Palmer Dabbelt wrote: > > On Wed, 27 Mar 2019 11:51:15 PDT (-0700), Alistair Francis wrote: > > This series updates the PLIC address to match the documentation. > > > > This fixes: https://github.com/riscv/opensbi/issues/97 > > > > V2: > > - Squash patches to ensur

Re: [Qemu-devel] [PATCH for-4.1 2/8] target/riscv: Use --static-decode for decodetree

2019-04-03 Thread Alistair Francis
On Sun, Mar 31, 2019 at 8:15 PM Richard Henderson wrote: > > The generated functions are only used within translate.c > and do not need to be global, or declared. > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/translate.c | 2 -- > target/r

Re: [Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the argument sets for all of insn32 formats

2019-04-03 Thread Alistair Francis
On Sun, Mar 31, 2019 at 8:12 PM Richard Henderson wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn32.decode | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/target/riscv/insn32.decode b/target/risc

Re: [Qemu-devel] [PATCH] target/riscv: Do not allow sfence.vma from user mode

2019-04-03 Thread Alistair Francis
On Mon, Apr 1, 2019 at 1:39 PM Jonathan Behrens wrote: > > The 'sfence.vma' instruction is privileged, and should only ever be allowed > when executing in supervisor mode or higher. > > Jonathan > > Signed-off-by: Jonathan Behrens Reviewed-by: Alistair Francis Alistair > --- > target/riscv/o

Re: [Qemu-devel] [PATCH 16/26] target/riscv: Convert to CPUClass::tlb_fill

2019-04-03 Thread Alistair Francis
On Tue, Apr 2, 2019 at 8:57 PM Richard Henderson wrote: > > Note that env->pc is removed from the qemu_log as that value is garbage. > The PC isn't recovered until cpu_restore_state, called from > cpu_loop_exit_restore, called from riscv_raise_exception. > > Cc: qemu-ri...@nongnu.org > Cc: Palmer

Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-03 Thread Darrick J. Wong
On Thu, Apr 04, 2019 at 09:09:12AM +1100, Dave Chinner wrote: > On Wed, Apr 03, 2019 at 04:10:18PM +0530, Pankaj Gupta wrote: > > Virtio pmem provides asynchronous host page cache flush > > mechanism. we don't support 'MAP_SYNC' with virtio pmem > > and xfs. > > > > Signed-off-by: Pankaj Gupta >

Re: [Qemu-devel] [PATCH 4/4] vl: Simplify machine_parse()

2019-04-03 Thread Wei Yang
On Tue, Apr 02, 2019 at 03:26:50PM +0200, Markus Armbruster wrote: >Exploit that argument @name is nerver null. Check is_help_option() >first, because that's what we do elsewhere. > >Signed-off-by: Markus Armbruster >--- > vl.c | 24 +++- > 1 file changed, 11 insertions(+), 13

Re: [Qemu-devel] [PATCH 3/4] vl: Clean up after previous commit

2019-04-03 Thread Wei Yang
On Tue, Apr 02, 2019 at 03:26:49PM +0200, Markus Armbruster wrote: >Since the previous commit, find_machine() and find_default_machine() >don't have to deallocate on return. This permits further >simplifications. > >Signed-off-by: Markus Armbruster >--- > vl.c | 25 +++-- > 1 f

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-04-03 Thread Elijah Shakkour
> -Original Message- > From: Elijah Shakkour > Sent: Thursday, April 4, 2019 12:57 AM > To: 'Peter Xu' > Cc: Knut Omang ; Michael S. Tsirkin > ; Alex Williamson ; > Marcel Apfelbaum ; Stefan Hajnoczi > ; qemu-devel@nongnu.org > Subject: RE: QEMU and vIOMMU support for emulated VF passthr

Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-03 Thread Dave Chinner
On Wed, Apr 03, 2019 at 04:10:18PM +0530, Pankaj Gupta wrote: > Virtio pmem provides asynchronous host page cache flush > mechanism. we don't support 'MAP_SYNC' with virtio pmem > and xfs. > > Signed-off-by: Pankaj Gupta > --- > fs/xfs/xfs_file.c | 8 > 1 file changed, 8 insertions(+)

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-04-03 Thread Elijah Shakkour
> -Original Message- > From: Peter Xu > Sent: Wednesday, April 3, 2019 5:40 AM > To: Elijah Shakkour > Cc: Knut Omang ; Michael S. Tsirkin > ; Alex Williamson ; > Marcel Apfelbaum ; Stefan Hajnoczi > ; qemu-devel@nongnu.org > Subject: Re: QEMU and vIOMMU support for emulated VF passthro

[Qemu-devel] [Bug 1821839] Re: qemu 4.0 doesnt support glsl 3.0 but yes older versions, that have no sense IMO

2019-04-03 Thread salvador liébana
I didnt understand properly the output, it only can use opengl es 3.0. you should put that info because when i compile qemu it pass and it should if doesnt support my opengl setup. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Qemu-devel] [Bug 1821839] Re: qemu 4.0 doesnt support glsl 3.0 but yes older versions, that have no sense IMO

2019-04-03 Thread salvador liébana
it shouldn't+ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821839 Title: qemu 4.0 doesnt support glsl 3.0 but yes older versions, that have no sense IMO Status in QEMU: New Bug description:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-04-03 Thread Daniel Henrique Barboza
On 4/2/19 7:28 AM, Greg Kurz wrote: On Mon, 1 Apr 2019 12:01:48 -0300 "Maxiwell S. Garcia" wrote: Hi Greg, Thanks for your review. I added some comments below... On Fri, Mar 29, 2019 at 01:29:51PM +0100, Greg Kurz wrote: On Thu, 28 Mar 2019 15:39:45 -0300 "Maxiwell S. Garcia" wrote:

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Eduardo Habkost
CCing the right Eduardo. :) On Wed, Apr 03, 2019 at 10:16:15PM +0700, Peter Maydell wrote: > On Wed, 3 Apr 2019 at 19:51, Helge Deller wrote: > > [cc'ing Eduardo as the seccomp submaintainer] > > > On a non-release architecture, the configure program aborts if the > > --enable-seccomp flag w

Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-04-03 Thread John Snow
On 3/29/19 4:04 PM, Zhang Chen wrote: > From: Zhang Chen > > In current codes we use change_bit() to finish the job. > > Signed-off-by: Zhang Chen > --- > include/qemu/bitmap.h | 1 - > include/qemu/bitops.h | 15 --- > 2 files changed, 16 deletions(-) > > diff --git a/include

[Qemu-devel] [PATCH v7 2/2] Add Nios II semihosting support.

2019-04-03 Thread Sandra Loosemore
This patch adds support for libgloss semihosting to Nios II bare-metal emulation. The specification for the protocol can be found in the libgloss sources. Signed-off-by: Sandra Loosemore Signed-off-by: Julian Brown --- qemu-options.hx| 8 +- target/nios2/Makefile.objs | 2 +- t

[Qemu-devel] [PATCH v7 0/2] Nios II generic board config and semihosting

2019-04-03 Thread Sandra Loosemore
This is the seventh version of the patch series last posted here: http://lists.nongnu.org/archive/html/qemu-devel/2019-03/msg06255.html Changes since v6: - Fixed block comment formatting for QEMU style. - Fixed fixme for interrupt handler (now added to libgloss BSP). - Added link to libgloss semih

[Qemu-devel] [PATCH v7 1/2] Add generic Nios II board.

2019-04-03 Thread Sandra Loosemore
This patch adds support for a generic MMU-less Nios II board that can be used e.g. for bare-metal compiler testing with the linker script and startup code provided by libgloss. Nios II booting is also tweaked so that bare-metal binaries start executing in RAM starting at 0x, rather than an

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-04-03 Thread Paolo Bonzini
On 03/04/19 10:53, Markus Armbruster wrote: > Why (1) our interfaces can't have state: > > Since interfaces are abstract, there's no such thing as an interface > instance. Well, there is. Since all class instances are Objects, and interfaces are applied to classes, interface instances must be Ob

Re: [Qemu-devel] [PATCH] migration: fix migration shutdown

2019-04-03 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > It fixes heap-use-after-free which was found by clang's ASAN. > > Control flow of this use-after-free: > main_thread: > * Got SIGTERM and completes main loop > * Calls migration_shutdown > - migrate_fd_cancel (so, migration_thread beg

Re: [Qemu-devel] Question: can we hot plug a PCIe switch on machine "virt"

2019-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2019 at 03:32:09PM +0800, Heyi Guo wrote: > Hi folks, > > In physical world, a PCIe switch including one upstream port and several > downstream ports is a single physical device, however we treat each port as a > device in qemu world. In qemu docs/pcie.txt, we have below statemen

Re: [Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc2 is now available

2019-04-03 Thread Dr. David Alan Gilbert
* Lukas Straub (lukasstra...@web.de) wrote: > Hello, > The following Patch which fixes COLO is missing: > https://lists.nongnu.org/archive/html/qemu-devel/2019-03/msg07909.html Yep, we need to do a migration pull for it, I've added it to the planning/4.0 list of 'Not yet fixed in any rc' Dave >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field

2019-04-03 Thread John Snow
On 4/2/19 9:25 PM, Zhang, Chen wrote: > >> -Original Message- >> From: John Snow [mailto:js...@redhat.com] >> Sent: Wednesday, April 3, 2019 5:07 AM >> To: Zhang, Chen ; Laurent Vivier ; >> qemu-dev ; Fam Zheng >> Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap >

Re: [Qemu-devel] [PATCH v3 0/4] pvrdma: Add support for SRQ

2019-04-03 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 02:33:39PM +0300, Kamal Heib wrote: > This series implements the SRQ (Shared Receive Queue) for the pvrdma > device, It also includes all the needed functions and definitions for > support SRQ in the backend and resource management layers. > > Changes from v2->3: > - Patch

Re: [Qemu-devel] [PATCH v3 4/4] hw/pvrdma: Add support for SRQ

2019-04-03 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 02:33:43PM +0300, Kamal Heib wrote: > Implement the pvrdma device commands for supporting SRQ > > Signed-off-by: Kamal Heib > --- > hw/rdma/vmw/pvrdma_cmd.c| 147 > hw/rdma/vmw/pvrdma_main.c | 16 > hw/rdma/vmw/pvrdma_qp_op

Re: [Qemu-devel] [PATCH v3 3/4] hw/rdma: Modify create/destroy QP to support SRQ

2019-04-03 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 02:33:42PM +0300, Kamal Heib wrote: > Modify create/destroy QP to support shared receive queue and rearrange > the destroy_qp() code to avoid touching the QP after calling > rdma_rm_dealloc_qp(). > > Signed-off-by: Kamal Heib > --- > hw/rdma/rdma_backend.c | 9 -- >

Re: [Qemu-devel] [PATCH 2/4] hw/rdma: Add support for managing SRQ resource

2019-04-03 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 02:33:41PM +0300, Kamal Heib wrote: > Adding the required functions and definitions for support managing the > shared receive queues (SRQs). > > Signed-off-by: Kamal Heib > --- > hw/rdma/rdma_rm.c | 93 ++ > hw/rdma/rdma_rm.h

Re: [Qemu-devel] [PATCH v3 1/4] hw/rdma: Add SRQ support to backend layer

2019-04-03 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 02:33:40PM +0300, Kamal Heib wrote: > Add the required functions and definitions to support shared receive > queues (SRQs) in the backend layer. > > Signed-off-by: Kamal Heib > --- > hw/rdma/rdma_backend.c | 116 +++- > hw/rdma/rdma_ba

[Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc2 is now available

2019-04-03 Thread Lukas Straub
Hello, The following Patch which fixes COLO is missing: https://lists.nongnu.org/archive/html/qemu-devel/2019-03/msg07909.html Regards, Lukas Straub

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-04-03 Thread Max Reitz
On 03.04.19 18:41, Max Reitz wrote: > On 01.04.19 09:21, Vladimir Sementsov-Ogievskiy wrote: >> 29.03.2019 22:32, Kevin Wolf wrote: >>> Am 29.03.2019 um 19:00 hat Vladimir Sementsov-Ogievskiy geschrieben: 29.03.2019 20:58, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 20:44, Max Reitz w

Re: [Qemu-devel] [PATCH v2 3/8] migration-test: rename parameter to parameter_int

2019-04-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We would need _str ones on the next patch. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 49 +- > 1 file changed, 25 insertions(+), 24 deletions(-) >

Re: [Qemu-devel] [PATCH v2 2/8] migration: fix multifd_recv event typo

2019-04-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It uses num in multifd_send(). Make it coherent. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/trace-events | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/trace-events

Re: [Qemu-devel] [PATCH v3] block/file-posix: do not fail on unlock bytes

2019-04-03 Thread Max Reitz
On 01.04.19 09:21, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 22:32, Kevin Wolf wrote: >> Am 29.03.2019 um 19:00 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 29.03.2019 20:58, Vladimir Sementsov-Ogievskiy wrote: 29.03.2019 20:44, Max Reitz wrote: > On 29.03.19 18:40, Kevin Wolf

Re: [Qemu-devel] [PATCH v2 1/8] migration: Fix migrate_set_parameter

2019-04-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Otherwise we are setting err twice, what is wrong and causes an abort. > > Signed-off-by: Juan Quintela This patch should be broken out as a separate fix. Reviewed-by: Dr. David Alan Gilbert > --- > hmp.c | 6 -- > 1 file changed, 4 insertio

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-03 Thread Shameerali Kolothum Thodi
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 03 April 2019 14:29 > To: Shameerali Kolothum Thodi ; > Igor Mammedov > Cc: Auger Eric ; Ard Biesheuvel > ; peter.mayd...@linaro.org; > sa...@linux.intel.com; qemu-devel@nongnu.org; Linuxarm > ; shanno

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Daniel P . Berrangé
On Wed, Apr 03, 2019 at 02:49:48PM +0200, Helge Deller wrote: > On a non-release architecture, the configure program aborts if the > --enable-seccomp flag was given (with no way to work around it on the > command line): > > ERROR: User requested feature libseccomp > configure was not able to

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Helge Deller
On 03.04.19 17:16, Peter Maydell wrote: > On Wed, 3 Apr 2019 at 19:51, Helge Deller wrote: > > [cc'ing Eduardo as the seccomp submaintainer] > >> On a non-release architecture, the configure program aborts if the >> --enable-seccomp flag was given (with no way to work around it on the >> command l

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-04-03 Thread Laszlo Ersek
On 04/03/19 16:12, Xiang Zheng wrote: > Hi Laszlo and Markus, > > Thanks for your useful suggestions and comments! :) > > On 2019/3/27 2:36, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 03/26/19 17:39, Markus Armbruster wrote: Laszlo Ersek writes: >>> > With the dynamic s

Re: [Qemu-devel] [PATCH v2] migration: avoid filling ignore-shared ramblock when in incoming migration

2019-04-03 Thread Catherine Ho
Hi Peter Xu On Wed, 3 Apr 2019 at 10:25, Peter Xu wrote: > On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine Ho wrote: > > Commit 18269069c310 ("migration: Introduce ignore-shared capability") > > addes ignore-shared capability to bypass the shared ramblock (e,g, > > membackend + numa node). I

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Peter Maydell
On Wed, 3 Apr 2019 at 22:16, Peter Maydell wrote: > > On Wed, 3 Apr 2019 at 19:51, Helge Deller wrote: > > [cc'ing Eduardo as the seccomp submaintainer] > > > On a non-release architecture, the configure program aborts if the > > --enable-seccomp flag was given (with no way to work around it on t

Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Peter Maydell
On Wed, 3 Apr 2019 at 19:51, Helge Deller wrote: [cc'ing Eduardo as the seccomp submaintainer] > On a non-release architecture, the configure program aborts if the > --enable-seccomp flag was given (with no way to work around it on the > command line): > > ERROR: User requested feature libseccom

Re: [Qemu-devel] VSOCK benchmark and optimizations

2019-04-03 Thread Stefano Garzarella
On Wed, Apr 03, 2019 at 01:34:38PM +0100, Stefan Hajnoczi wrote: > On Mon, Apr 01, 2019 at 06:32:40PM +0200, Stefano Garzarella wrote: > > Hi Alex, > > I'm sending you some benchmarks and information about VSOCK CCing qemu-devel > > and linux-netdev (maybe this info could be useful for others :)) >

Re: [Qemu-devel] [PULL for-4.0 0/4] s390x gcc 9 warning fixes

2019-04-03 Thread Peter Maydell
m/cohuck/qemu tags/s390x-20190403 > > for you to fetch changes up to 7357b2215978debf2fd17b525ba745d3c69272a3: > > hw/s390x/3270-ccw: avoid taking address of fields in packed struct > (2019-04-03 11:19:57 +0200) > >

[Qemu-devel] [Bug 1818483] Re: qemu user mode does not support binfmt_misc config with flags include "P"

2019-04-03 Thread YunQiang Su
This patch is for linux kernel. It will set the 3rd bit of AT_FLAGS, if P is set for binfmt_misc. The major concern is that AT_FLAGS is never used, then, should we use it here? ** Patch added: "binfmt_preserve_argv0.patch" https://bugs.launchpad.net/qemu/+bug/1818483/+attachment/5252516/+fil

[Qemu-devel] [PATCH for-4.1] commit: Use bdrv_append() in commit_start()

2019-04-03 Thread Alberto Garcia
This function combines bdrv_set_backing_hd() and bdrv_replace_node() so we can use it to simplify the code a bit in commit_start(). Signed-off-by: Alberto Garcia --- block/commit.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/block/commit.c b/block/commit.c ind

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

2019-04-03 Thread Collin Walling
On 4/3/19 10:16 AM, Collin Walling wrote: On 4/3/19 8:30 AM, Cornelia Huck wrote: On Wed, 3 Apr 2019 13:46:07 +0200 David Hildenbrand wrote: On 01.04.19 23:48, Collin Walling wrote: DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM

Re: [Qemu-devel] [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup

2019-04-03 Thread Aleksandar Markovic
> From: Jules Irenge > Subject: [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup > > This v1 series cleans up all warnings and errors of coding style within cpu.h > file > Hi, Jules! There are a couple of minor problems that I described in my comments to other patches. Other

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

2019-04-03 Thread Collin Walling
On 4/3/19 8:30 AM, Cornelia Huck wrote: On Wed, 3 Apr 2019 13:46:07 +0200 David Hildenbrand wrote: On 01.04.19 23:48, Collin Walling wrote: DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM. Let's introduce some functions to communi

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-04-03 Thread Xiang Zheng
Hi Laszlo and Markus, Thanks for your useful suggestions and comments! :) On 2019/3/27 2:36, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 03/26/19 17:39, Markus Armbruster wrote: >>> Laszlo Ersek writes: >> With the dynamic sizing in QEMU (which, IIRC, I had originally int

Re: [Qemu-devel] [PATCH 3/5] target/mips: replace indentation with space to fix checkpatch errors

2019-04-03 Thread Aleksandar Markovic
> From: Jules Irenge > Subject: [PATCH 3/5] target/mips: replace indentation with space to fix > checkpatch errors > > Replace indentation with space to fix errors issued by checkpatch.pl tool > "ERROR: code indent should never use tabs" > within "target/mips/cpu.h" file. > > Signed-off-by: Jule

Re: [Qemu-devel] [PATCH 2/5] target/mips: realign comments to fix checkpatch warnings

2019-04-03 Thread Aleksandar Markovic
> From: Jules Irenge > Subject: [PATCH 2/5] target/mips: realign comments to fix checkpatch warnings > > Realign comments to fix warnings issued by checkpatch.pl tool > "WARNING: Block comments use a leading /* on a separate line" > within "target/mips/cpu.h" file. > > Signed-off-by: Jules Iren

Re: [Qemu-devel] [PATCH 1/5] target/mips: add space to fix checkpatch errors

2019-04-03 Thread Aleksandar Markovic
> From: Jules Irenge > Subject: [PATCH 1/5] target/mips: add space to fix checkpatch errors > > Add space to fix errors reported by checkpatch.pl tool > "ERROR: spaces required around that ..." > "ERROR: space required before the open parenthesis" > "ERROR: space required after that ..." > > Sig

Re: [Qemu-devel] [PATCH 5/7] block: Fix BDRV_BLOCK_RAW status to honor alignment

2019-04-03 Thread Eric Blake
On 4/3/19 8:03 AM, Kevin Wolf wrote: > Am 03.04.2019 um 05:05 hat Eric Blake geschrieben: >> Previous patches mentioned how the blkdebug filter driver demonstrates >> a bug present in our NBD server; the bug is also present with the raw >> format driver when probing occurs. Basically, if we specify

Re: [Qemu-devel] [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup

2019-04-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190403125055.26564-1-jbi.oct...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190403125055.26564-1-jbi.oct...@gmail.com Subject: [Qemu-devel] [PATCH 0/5] target/mips/cpu: errors

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-03 Thread Laszlo Ersek
On 04/03/19 14:10, Shameerali Kolothum Thodi wrote: > So, the condition for hiding the hotpluggable memory nodes in question > from the DT is: > > (aarch64 && firmware_loaded && acpi_enabled) >>> While UEFI has bindings for both 32-bit and 64-bit ARM, ACPI has a >>> 64-bit-

Re: [Qemu-devel] [PATCH] sockets: Fix stringop-truncation warning

2019-04-03 Thread Philippe Mathieu-Daudé
On Wed, Apr 3, 2019 at 2:23 PM Daniel P. Berrangé wrote: > On Wed, Apr 03, 2019 at 02:16:20PM +0200, Philippe Mathieu-Daudé wrote: > > Compiling with clang-8 fails with: > > > > CC util/qemu-sockets.o > > util/qemu-sockets.c: In function 'unix_connect_saddr': > > util/qemu-sockets.c:9

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-03 Thread Laszlo Ersek
On 04/03/19 11:49, Igor Mammedov wrote: > On Tue, 2 Apr 2019 17:38:26 +0200 > Laszlo Ersek wrote: > >> On 04/02/19 17:29, Auger Eric wrote: >>> Hi Laszlo, >>> >>> On 4/1/19 3:07 PM, Laszlo Ersek wrote: On 03/29/19 14:56, Auger Eric wrote: > Hi Ard, > > On 3/29/19 2:14 PM, Ard

Re: [Qemu-devel] [PATCH 5/7] block: Fix BDRV_BLOCK_RAW status to honor alignment

2019-04-03 Thread Kevin Wolf
Am 03.04.2019 um 05:05 hat Eric Blake geschrieben: > Previous patches mentioned how the blkdebug filter driver demonstrates > a bug present in our NBD server; the bug is also present with the raw > format driver when probing occurs. Basically, if we specify a > particular alignment > 1, but defer t

[Qemu-devel] [PATCH 5/5] target/mips: wrap line into multiple lines to to fix checkpatch errors

2019-04-03 Thread Jules Irenge
Wrap line into multiple lines to fix errors issued by checkpatch.pl tool ERROR: line over 90 characters" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/target/mips

[Qemu-devel] [PATCH 2/5] target/mips: realign comments to fix checkpatch warnings

2019-04-03 Thread Jules Irenge
Realign comments to fix warnings issued by checkpatch.pl tool "WARNING: Block comments use a leading /* on a separate line" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(

[Qemu-devel] [PATCH 1/5] target/mips: add space to fix checkpatch errors

2019-04-03 Thread Jules Irenge
Add space to fix errors reported by checkpatch.pl tool "ERROR: spaces required around that ..." "ERROR: space required before the open parenthesis" "ERROR: space required after that ..." Signed-off-by: Jules Irenge --- target/mips/cpu.h | 20 ++-- 1 file changed, 10 insertions(+)

[Qemu-devel] [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup

2019-04-03 Thread Jules Irenge
This v1 series cleans up all warnings and errors of coding style within cpu.h file Jules Irenge (5): target/mips: add space to fix checkpatch errors target/mips: realign comments to fix checkpatch warnings target/mips: replace indentation with space to fix checkpatch errors target/mips: re

[Qemu-devel] [PATCH 3/5] target/mips: replace indentation with space to fix checkpatch errors

2019-04-03 Thread Jules Irenge
Replace indentation with space to fix errors issued by checkpatch.pl tool "ERROR: code indent should never use tabs" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 136 +++--- 1 file changed, 68 insertions(+), 68 dele

[Qemu-devel] [PATCH 4/5] target/mips: remove space to fix checkpatch errors

2019-04-03 Thread Jules Irenge
Remove space to fix errors issued by checkpatch.pl tool "ERROR: space prohibited between function name and open parenthesis" "ERROR: trailing white space" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 10 +- 1 file changed, 5 insertions(+), 5 delet

Re: [Qemu-devel] [PATCH] sun4m: obey -vga none

2019-04-03 Thread Philippe Mathieu-Daudé
Hi Paolo, On 3/19/19 3:40 PM, Paolo Bonzini wrote: > Do not create a TCX if "-vga none" was passed on the command line. > Remove some dead code along the way to avoid big reindentation. Can you add: This fixes when configuring with --without-default-devices: $ sparc-softmmu/qemu-system-sparc

[Qemu-devel] [PATCH] configure: Relax check for libseccomp

2019-04-03 Thread Helge Deller
On a non-release architecture, the configure program aborts if the --enable-seccomp flag was given (with no way to work around it on the command line): ERROR: User requested feature libseccomp configure was not able to find it. libseccomp is not supported for host cpu parisc64 Ins

Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver

2019-04-03 Thread Pankaj Gupta
> Subject: Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver > > On Wed, Apr 03, 2019 at 04:10:15PM +0530, Pankaj Gupta wrote: > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and regist

Re: [Qemu-devel] VSOCK benchmark and optimizations

2019-04-03 Thread Stefan Hajnoczi
On Tue, Apr 02, 2019 at 09:37:06AM +0200, Stefano Garzarella wrote: > On Tue, Apr 02, 2019 at 04:19:25AM +, Alex Bennée wrote: > > > > Stefano Garzarella writes: > > > > > Hi Alex, > > > I'm sending you some benchmarks and information about VSOCK CCing > > > qemu-devel > > > and linux-netde

Re: [Qemu-devel] VSOCK benchmark and optimizations

2019-04-03 Thread Stefan Hajnoczi
On Mon, Apr 01, 2019 at 06:32:40PM +0200, Stefano Garzarella wrote: > Hi Alex, > I'm sending you some benchmarks and information about VSOCK CCing qemu-devel > and linux-netdev (maybe this info could be useful for others :)) > > One of the VSOCK advantages is the simple configuration: you don't ne

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

2019-04-03 Thread Cornelia Huck
On Wed, 3 Apr 2019 13:46:07 +0200 David Hildenbrand wrote: > On 01.04.19 23:48, Collin Walling wrote: > > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > > be intercepted by SIE and handled via KVM. Let's introduce some > > functions to communicate between QEMU and KVM via

Re: [Qemu-devel] [PATCH v2] Replace calls to object_child_foreach() with object_child_foreach_recursive()

2019-04-03 Thread Stefan Hajnoczi
On Mon, Apr 01, 2019 at 04:40:28PM +0100, Ernest Esene wrote: > Replace calls to object_child_foreach() with object_child_foreach_recursive() > when applicable: nvdimm_device_list, nmi_monitor_handle, > find_sysbus_device, > pc_dimm_slot2bitmap, build_dimm_list. > > Signed-off-by: Ernest Esene >

Re: [Qemu-devel] [PATCH] sockets: Fix stringop-truncation warning

2019-04-03 Thread Daniel P . Berrangé
On Wed, Apr 03, 2019 at 02:16:20PM +0200, Philippe Mathieu-Daudé wrote: > Compiling with clang-8 fails with: > > CC util/qemu-sockets.o > util/qemu-sockets.c: In function 'unix_connect_saddr': > util/qemu-sockets.c:925:5: error: 'strncpy' specified bound 108 equals > destination size

[Qemu-devel] [Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

2019-04-03 Thread Christian Ehrhardt 
Thank you Daniel, we will most likely keep Disco as-is for now and merge this in 19.10 where then mesa can drop the revert. I tagged it for 19.10 to be revisited. ** Tags added: qemu-19.10 ** Also affects: mesa (Ubuntu Ee-series) Importance: Undecided Status: New ** Also affects: qemu

[Qemu-devel] [PATCH] sockets: Fix stringop-truncation warning

2019-04-03 Thread Philippe Mathieu-Daudé
Compiling with clang-8 fails with: CC util/qemu-sockets.o util/qemu-sockets.c: In function 'unix_connect_saddr': util/qemu-sockets.c:925:5: error: 'strncpy' specified bound 108 equals destination size [-Werror=stringop-truncation] strncpy(un.sun_path, saddr->path, sizeof(un.su

Re: [Qemu-devel] [PATCH v2 0/8] WIP: Multifd compression support

2019-04-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190403114958.3705-1-quint...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190403114958.3705-1-quint...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/8] WIP: Multifd compression

Re: [Qemu-devel] [PATCH v4 5/5] target/mips: Refactor and fix INSERT. instructions

2019-04-03 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: Re: [PATCH v4 5/5] target/mips: Refactor and fix INSERT. > instructions > > On 2.4.19. 22:50, Aleksandar Markovic wrote: > >> From: Mateja Marjanovic > >> Subject: [PATCH v4 5/5] target/mips: Refactor and fix INSERT. > >> instructions > >> > >> From: Mateja

  1   2   >