Re: [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve

Hi, On 6/21/19 6:34 PM, Andrew Jones wrote: > These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the > swabbing is different than it is for fpsmid because the vector format > is a little-endian stream of words. some cosmetic changes besides Richard's comments > > Signed-off-by: Andr

[Qemu-devel] [PATCH v23 4/7] target/avr: Add instruction translation

This includes: - TCG translations for each instruction Signed-off-by: Michael Rolnik --- target/avr/translate.c | 2888 1 file changed, 2888 insertions(+) create mode 100644 target/avr/translate.c diff --git a/target/avr/translate.c b/target/avr/transla

[Qemu-devel] [PATCH v23 6/7] target/avr: Add example board configuration

From: Sarah Harris A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. Signed-off-by: Michael Rolnik --- hw/Kconfig | 1 + hw/avr/Kconf

[Qemu-devel] [PATCH] console: fix cell overflow

Linux terminal behavior (coming from vt100 I think) is somewhat strange when it comes to line wraps: When a character is printed to the last char cell of a line the cursor does NOT jump to the next line but stays where it is. The line feed happens when the next character is printed. So the valid

[Qemu-devel] [PATCH v23 1/7] target/avr: Add outward facing interfaces and core CPU logic

From: Sarah Harris This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Signed-off-by: Michael Rolnik --- gdb-xml/avr-cpu.xml| 49 target/avr/cpu-param.h | 37 +++ target/avr/cpu.c | 599 +++

[Qemu-devel] [PATCH v23 2/7] target/avr: Add instruction helpers

From: Sarah Harris Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate wake

[Qemu-devel] [PATCH v23 5/7] target/avr: Add limited support for USART and 16 bit timer peripherals

From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). Signed-o

[Qemu-devel] [PATCH v23 7/7] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

From: Sarah Harris Signed-off-by: Michael Rolnik --- MAINTAINERS | 6 ++ arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h | 6 ++ include/sysemu/arch_i

[Qemu-devel] [PATCH v23 0/7] QEMU AVR 8 bit cores

This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet

[Qemu-devel] [PATCH v23 3/7] target/avr: Add instruction decoding

This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git a/target/a

[Qemu-devel] [Bug 1834399] [NEW] AArch64: branch out of range

Public bug reported: I build lib32-qemu which is a multilib variant for mips o32 on project Yocto with qemumips64. It finally runs command and fails: mips-wrsmllib32-linux-gcc -meb -mabi=32 -mhard-float -fstack-protector-strong -Wformat -Wformat-security -Werror=format-security --sysroot=/m

Re: [Qemu-devel] [PATCH v4 1/5] virtio: add "use-started" property

On Wed, 26 Jun 2019 at 18:18, Greg Kurz wrote: > > On Wed, 26 Jun 2019 10:31:26 +0800 > elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > In order to avoid migration issues, we introduce a "use-started" > > property to the base virtio device to indicate whether use > > "started" flag or no

Re: [Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag

On Wed, 26 Jun 2019 at 18:43, Laurent Vivier wrote: > > On 26/06/2019 04:31, elohi...@gmail.com wrote: > > From: Xie Yongji > > Could you use the same address to send the series? > Or may be you need to add a Signed-off-by with your name and this address? > > I don't know what is the rule when so

Re: [Qemu-devel] [PATCH v3 0/4] Clean ups in net/net.c

On 2019/5/17 下午9:47, Stefano Garzarella wrote: This series contains some clean ups in net/net.c The patch 1 solves an assertion failure when ipv6-prefixlen is not a number, Following the Markus' advice, I modified the parsing of IPv6 prefix (patch 2) and IPv4 host:port (patch 3). Then I remov

[Qemu-devel] [PATCH 1/3] migration/postcopy: the valid condition is one less then end

If one equals end, it means we have gone through the whole bitmap. Use a more restrict check to skip a unnecessary condition. Signed-off-by: Wei Yang --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 908517fc2b..b7816

[Qemu-devel] [PATCH 2/3] migration/postcopy: break the loop when there is no more page to discard

When one is equal or bigger then end, it means there is no page to discard. Just break the loop in this case instead of processing it. No functional change, just refactor it a little. Signed-off-by: Wei Yang --- migration/ram.c | 26 +- 1 file changed, 13 insertions(+),

[Qemu-devel] [PATCH 3/3] migration/postcopy: discard_length must not be 0

Since we break the loop when there is no more page to discard, we are sure the following process would find some page to discard. It is not necessary to check it again. Signed-off-by: Wei Yang --- migration/ram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/migration/r

[Qemu-devel] [PATCH 0/3] migration/postcopy: cleanup function postcopy_send_discard_bm_ram

Some cleanup of function postcopy_send_discard_bm_ram: * use a more restrict check for discard page * break the loop when no more page to discard * it is for sure discard_length is not 0 No functional change. Wei Yang (3): migration/postcopy: the valid condition is one less then end migratio

Re: [Qemu-devel] [PATCH v5 0/5] network announce; interface selection & IDs

On 2019/6/21 上午2:47, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Up until now, the 'announce' feature has mainly been used for migration where we announce on all interfaces. Another use for 'announce' is in cases of network topology changes. Since network topology cha

Re: [Qemu-devel] [PATCH V2 4/5] COLO-compare: Add colo-compare remote notify support

On 2019/6/10 上午12:44, Zhang Chen wrote: From: Zhang Chen This patch make colo-compare can send message to remote COLO frame(Xen) when occur checkpoint. Signed-off-by: Zhang Chen --- net/colo-compare.c | 54 +- 1 file changed, 44 insertions(+),

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

On Wed, Jun 26, 2019, 19:08 Laurent Vivier wrote: > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits > > wrote: > > > > On Wed, 26 Jun 2019 18:47:42 +0200 > > Laurent Vivier mailto:laur...@vivier.eu>> wrot

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits > wrote: > > On Wed, 26 Jun 2019 18:47:42 +0200 > Laurent Vivier mailto:laur...@vivier.eu>> wrote: > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : >

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

On Wed, Jun 26, 2019, 13:04 Justin Hibbits wrote: > On Wed, 26 Jun 2019 18:47:42 +0200 > Laurent Vivier wrote: > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > Laurent Vivier wrote: > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit :

Re: [Qemu-devel] [GSoC] Help needed in implementing live migration

On Tue, 25 Jun 2019 at 00:11, Dr. David Alan Gilbert wrote: > > * Sukrit Bhatnagar (skrtbht...@gmail.com) wrote: > > Hi David, > > > > I am Sukrit, GSoC participant working on PVRDMA live migration. > > We had a short chat about vmxnet3 migration about a week ago > > on the IRC channel. > > > > I

Re: [Qemu-devel] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow

On 6/26/19 4:53 PM, John Snow wrote: > Reported-by: radmehrsae...@gmail.com > Fixes: https://bugs.launchpad.net/bugs/1832914 > Signed-off-by: John Snow > --- > block/qcow.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Yes, this is useful. Reviewed-by: Eric Blake Reminds me of

[Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to guests through scsi-block

From: Shin'ichiro Kawasaki When host block devices are bridged to a guest system through virtio-scsi-pci and scsi-block driver, scsi_handle_rw_error() in hw/scsi/scsi-disk.c checks the error number to judge which error to report to the guests. EIO and EINVAL are not reported and ignored. Once EIO

[Qemu-devel] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow

Reported-by: radmehrsae...@gmail.com Fixes: https://bugs.launchpad.net/bugs/1832914 Signed-off-by: John Snow --- block/qcow.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/qcow.c b/block/qcow.c index 6dee5bb792..a9cb6ae0bd 100644 --- a/block/qcow.c +++ b/block/qc

Re: [Qemu-devel] [Qemu-block] [PATCH V2 RESEND] block/replication.c: Fix crash issue after failover

On 6/21/19 2:28 AM, Zhang Chen wrote: > From: Zhang Chen > > If we try to close replication after failover, it will crash here. > So we need check the block job on active disk before cancel the job. > > Signed-off-by: Zhang Chen > --- > block/replication.c | 4 +++- > 1 file changed, 3 inse

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

On 6/26/19 4:23 PM, Eric Blake wrote: > On 6/26/19 4:18 PM, John Snow wrote: >> >> >> On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a suggestion to enable keepalive option to track server availablity. >>> We suggest to enable it by default. If we need, we'll be

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

On 6/26/19 5:23 PM, Eric Blake wrote: > On 6/26/19 4:18 PM, John Snow wrote: >> >> >> On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a suggestion to enable keepalive option to track server availablity. >>> We suggest to enable it by default. If we need, we'll

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

On 6/26/19 4:18 PM, John Snow wrote: > > > On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a suggestion to enable keepalive option to track server availablity. >> We suggest to enable it by default. If we need, we'll be able to add option >> to specify timeout by

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a suggestion to enable keepalive option to track server availablity. > We suggest to enable it by default. If we need, we'll be able to add option > to specify timeout by hand later. > > v2: 01 - Fix io channel retur

Re: [Qemu-devel] [Qemu-block] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes

On 6/26/19 5:06 PM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 6/26/19 10:33 PM, John Snow wrote: >> I don't think this series ever made it upstream, and it's now well past >> 30 days, so I might encourage a resend when you can if this is still >> important to pursue. > > I should have se

Re: [Qemu-devel] [Qemu-block] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes

Hi John, On 6/26/19 10:33 PM, John Snow wrote: > I don't think this series ever made it upstream, and it's now well past > 30 days, so I might encourage a resend when you can if this is still > important to pursue. I should have sent a 'ping' indeed. I keep rebasing because I have it in my pflash

Re: [Qemu-devel] [Qemu-block] [PATCH v2] block/rbd: implement .bdrv_get_allocated_file_size callback

It looks like this has hit a 30 day expiration without any reviews or being merged; do we still want this? If so, can you please resend? On 5/10/19 11:33 AM, Stefano Garzarella wrote: > This patch allows 'qemu-img info' to show the 'disk size' for > the RBD images that have the fast-diff feature e

[Qemu-devel] [PATCH v4 0/5] 9p: Fix file ID collisions

This is v4 of a proposed patch set for fixing file ID collisions with 9pfs. v3->v4: * Rebased to latest git master head. * Splitted Antonios' patch set to its original 4 individual patches. (was merged previously as only 1 patch). * Addressed discussed issues directly on Antonios' pat

[Qemu-devel] [PATCH v4 4/5] 9p: stat_to_qid: implement slow path

stat_to_qid attempts via qid_path_prefixmap to map unique files (which are identified by 64 bit inode nr and 32 bit device id) to a 64 QID path value. However this implementation makes some assumptions about inode number generation on the host. If qid_path_prefixmap fails, we still have 48 bits av

[Qemu-devel] [PATCH v4 3/5] 9p: Added virtfs option "remap_inodes"

To support multiple devices on the 9p share, and avoid qid path collisions we take the device id as input to generate a unique QID path. The lowest 48 bits of the path will be set equal to the file inode, and the top bits will be uniquely assigned based on the top 16 bits of the inode and the devic

[Qemu-devel] [PATCH v4 5/5] 9p: Use variable length suffixes for inode remapping

Use variable length suffixes for inode remapping instead of the fixed 16 bit size prefixes before. With this change the inode numbers on guest will typically be much smaller (e.g. around >2^1 .. >2^7 instead of >2^48 with the previous fixed size inode remapping. Additionally this solution should b

[Qemu-devel] [PATCH v4 2/5] 9p: Treat multiple devices on one export as an error

The QID path should uniquely identify a file. However, the inode of a file is currently used as the QID path, which on its own only uniquely identifies wiles within a device. Here we track the device hosting the 9pfs share, in order to prevent security issues with QID path collisions from other dev

[Qemu-devel] [PATCH v4 1/5] 9p: unsigned type for type, version, path

There is no need for signedness on these QID fields for 9p. Signed-off-by: Antonios Motakis Signed-off-by: Christian Schoenebeck --- fsdev/9p-marshal.h | 6 +++--- hw/9pfs/9p.c | 6 +++--- hw/9pfs/trace-events | 14 +++--- 3 files changed, 13 insertions(+), 13 deletions(-)

Re: [Qemu-devel] [Qemu-block] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes

I don't think this series ever made it upstream, and it's now well past 30 days, so I might encourage a resend when you can if this is still important to pursue. --js On 5/5/19 6:15 PM, Philippe Mathieu-Daudé wrote: > Hi, > > While reviewing Stephen Checkoway's v4 "Implement missing AMD > pflash

Re: [Qemu-devel] [PATCH v7 1/4] VirtIO-RNG: Update default entropy source to `/dev/urandom`

On 29/05/2019 16:31, Laurent Vivier wrote: > From: Kashyap Chamarthy > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > source of entropy, and that source needs to be "non-blocking", like > `/dev/urandom`. However, currently QEMU defaults to the problematic > `/dev/ran

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

On Wed, 26 Jun 2019, Mark Cave-Ayland wrote: On 26/06/2019 19:42, Richard Henderson wrote: On 6/26/19 7:00 PM, Mark Cave-Ayland wrote: Interestingly if I set a trap and then switch the opcode to "lis r4,0" (0x3c80) then we carry on as normal until the next "lis r2,0" instruction. Looking

[Qemu-devel] [PULL 0/4] Trivial patches patches

The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-patches-pu

[Qemu-devel] [PULL 2/4] configure: disallow spaces and colons in source path and build path

From: Antonio Ospite The configure script breaks when the qemu source directory is in a path containing white spaces, in particular the list of targets is not correctly generated when calling "./configure --help" because of how the default_target_list variable is built. In addition to that, *bui

[Qemu-devel] [PULL 4/4] MAINTAINERS: Change maintership of Xen code under hw/9pfs

From: Greg Kurz Xen folks are the actual maintainers for this. Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Acked-by: Anthony PERARD Acked-by: Paul Durrant Acked-by: Stefano Stabellini Message-Id: <155912548463.2019004.3515830305299809902.st...@bahia.lan> Signed-off-by: Laur

[Qemu-devel] [PULL 3/4] configure: use valid args testing sem_timedwait

From: Daniel P. Berrangé The sem_timedwait function has been annotated as requiring non-null args in latest header files from GCC snapshot representing the future 2.30 release. This causes configure to fail when -Werror is used: config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf

[Qemu-devel] [PULL 1/4] configure: set source_path only once and make its definition more robust

From: Antonio Ospite Since commit 79d77bcd36 (configure: Remove --source-path option, 2019-04-29) source_path cannot be overridden anymore, move it out of the "default parameters" block since the word "default" may suggest that the value can change, while in fact it does not. While at it, only s

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

On 26/06/2019 19:42, Richard Henderson wrote: > On 6/26/19 7:00 PM, Mark Cave-Ayland wrote: >> Interestingly if I set a trap and then switch the opcode to "lis r4,0" >> (0x3c80) >> then we carry on as normal until the next "lis r2,0" instruction. Looking >> through the >> whole output of -d

Re: [Qemu-devel] [PULL 02/11] vhost-user: check unix_listen() return value

Hi On Wed, Jun 26, 2019 at 7:56 PM Eric Blake wrote: > > On 6/16/19 4:36 PM, Michael S. Tsirkin wrote: > > From: Marc-André Lureau > > > > This check shouldn't be necessary, since &error_fatal is given as > > argument and will exit() on failure. However, this change should > > silence coverity C

Re: [Qemu-devel] [PATCH for-4.1 v3 12/17] tcg/ppc: Initial backend support for Altivec

On 26/06/2019 19:36, BALATON Zoltan wrote: > On Tue, 19 Mar 2019, Richard Henderson wrote: >> diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c >> index ec8e336be8..70a64dd214 100644 >> --- a/tcg/ppc/tcg-target.inc.c >> +++ b/tcg/ppc/tcg-target.inc.c >> @@ -42,6 +42,9 @@ >> # define

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

On 6/26/19 7:00 PM, Mark Cave-Ayland wrote: > Interestingly if I set a trap and then switch the opcode to "lis r4,0" > (0x3c80) > then we carry on as normal until the next "lis r2,0" instruction. Looking > through the > whole output of -d out_asm this is the first mention of r2 which makes me

Re: [Qemu-devel] [PATCH for-4.1 v3 12/17] tcg/ppc: Initial backend support for Altivec

On Tue, 19 Mar 2019, Richard Henderson wrote: diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index ec8e336be8..70a64dd214 100644 --- a/tcg/ppc/tcg-target.inc.c +++ b/tcg/ppc/tcg-target.inc.c @@ -42,6 +42,9 @@ # define TCG_REG_TMP1 TCG_REG_R12 #endif +#define TCG_VEC_TMP1T

Re: [Qemu-devel] [PATCH v8 10/10] hw/m68k: define Macintosh Quadra 800

Am Wed, 26 Jun 2019 19:51:12 +0200 schrieb Philippe Mathieu-Daudé : > On 6/25/19 6:30 PM, Thomas Huth wrote: > > Am Thu, 20 Jun 2019 00:19:33 +0200 > > schrieb Laurent Vivier : > > > >> If you want to test the machine, it doesn't yet boot a MacROM, but > >> you can boot a linux kernel from the

Re: [Qemu-devel] [PATCH v2 1/4] target/mips: Fix emulation of ILVEV. on big endian host

On 6/20/19 3:45 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Fix emulation of ILVEV. on big endian host by applying > mapping of data element indexes from one endian to another. > > Signed-off-by: Aleksandar Markovic > Reviewed-by: Aleksandar Rikalo > --- > target/mips/msa_h

Re: [Qemu-devel] [PATCH 1/8] target/ppc: Optimize emulation of lvsl and lvsr instructions

On 6/19/19 1:03 PM, Stefan Brankovic wrote: > +/* Get sh(from description) by anding EA with 0xf. */ > +gen_addr_reg_index(ctx, EA); > +tcg_gen_ext_i32_i64(sh, EA); >From patchew, this fails to build one of the ppc*-linux-user configurations. You need to use tcg_gen_extu_tl_i64(). r

[Qemu-devel] [PATCH] hw/sd/aspeed_sdhci: New device

The Aspeed SOCs have two SD/MMC controllers. Add a device that encapsulates both of these controllers and models the Aspeed-specific registers and behavior. Both controllers use a single HW interrupt. In order to trigger that interrupt, a function pointer was added to the generic SDHCI structure.

Re: [Qemu-devel] [PATCH 6/8] target/ppc: Optimize emulation of vclzw instruction

On 6/19/19 1:03 PM, Stefan Brankovic wrote: > Optimize Altivec instruction vclzw (Vector Count Leading Zeros Word). > This instruction counts the number of leading zeros of each word element > in source register and places result in the appropriate word element of > destination register. > > Count

Re: [Qemu-devel] [PATCH 2/8] target/ppc: Optimize emulation of vsl and vsr instructions

On 6/19/19 1:03 PM, Stefan Brankovic wrote: > Optimization of altivec instructions vsl and vsr(Vector Shift Left/Rigt). > Perform shift operation (left and right respectively) on 128 bit value of > register vA by value specified in bits 125-127 of register vB. Lowest 3 > bits in each byte element o

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

On 6/26/19 10:33 AM, David Gibson wrote: >>> out of curiosity: is your Power9 system BE or LE? >> >> The Power9 is LE. > > It's the kernel determines endianness, not the system. Yes. Lazy verbiage on my part -- I did mean "The Power9 that I have access to is configured as LE". r~

Re: [Qemu-devel] [PATCH v2 12/14] target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features

On 6/21/19 6:34 PM, Andrew Jones wrote: > kvm_arm_create_scratch_host_vcpu() takes a struct kvm_vcpu_init > parameter. Rather than just using it as an output parameter to > pass back the preferred target, use it also as an input parameter, > allowing a caller to pass a selected target if they wish

Re: [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve

On 6/21/19 6:34 PM, Andrew Jones wrote: > +/* > + * If ARM_MAX_VQ is increased to be greater than 16, then we can no > + * longer hard code slices to 1 in kvm_arch_put/get_sve(). > + */ > +QEMU_BUILD_BUG_ON(ARM_MAX_VQ > 16); This seems easy to fix, or simply drop the slices entirely for now, as ot

Re: [Qemu-devel] [PATCH v3 1/8] target/ppc: Optimize emulation of lvsl and lvsr instructions

On 6/21/19 1:07 PM, Stefan Brankovic wrote: > +#if defined(TARGET_PPC64) > +tcg_gen_andi_i64(sh, EA, 0xfULL); > +#else > +tcg_gen_ext_i32_i64(sh, EA); > +tcg_gen_andi_i64(sh, sh, 0xfULL); > +#endif Didn't see v3 before reviewing v2, however as noted there, tcg_gen_extu_tl_i64. r~

Re: [Qemu-devel] [PATCH 1/8] target/ppc: Optimize emulation of lvsl and lvsr instructions

On 6/19/19 1:03 PM, Stefan Brankovic wrote: > Adding simple macro that is calling tcg implementation of appropriate > instruction if altivec support is active. > > Optimization of altivec instruction lvsl (Load Vector for Shift Left). > Place bytes sh:sh+15 of value 0x00 || 0x01 || 0x02 || ... ||

Re: [Qemu-devel] [PATCH v2 08/14] target/arm/kvm64: Fix error returns

On 6/21/19 6:34 PM, Andrew Jones wrote: > A couple return -EINVAL's forgot their '-'s. > > Signed-off-by: Andrew Jones > Reviewed-by: Eric Auger > --- > target/arm/kvm64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 4/8] target/ppc: Optimize emulation of vgbbd instruction

On 6/19/19 1:03 PM, Stefan Brankovic wrote: > Optimize altivec instruction vgbbd (Vector Gather Bits by Bytes by Doubleword) > All ith bits (i in range 1 to 8) of each byte of doubleword element in > source register are concatenated and placed into ith byte of appropriate > doubleword element in de

Re: [Qemu-devel] [PATCH v2 08/14] target/arm/kvm64: Fix error returns

On 6/21/19 6:34 PM, Andrew Jones wrote: > A couple return -EINVAL's forgot their '-'s. > > Signed-off-by: Andrew Jones > Reviewed-by: Eric Auger > --- > target/arm/kvm64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 11/14] target/arm/kvm64: max cpu: Enable SVE when available

On 6/21/19 6:34 PM, Andrew Jones wrote: > @@ -675,6 +689,11 @@ static void aarch64_max_initfn(Object *obj) > > if (kvm_enabled()) { > kvm_arm_set_cpu_features_from_host(cpu); > +/* > + * KVM doesn't yet support the sve-max-vq property, but > + * setting cpu->

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

On Wed, 26 Jun 2019, Mark Cave-Ayland wrote: On 26/06/2019 08:45, Richard Henderson wrote: On 6/25/19 7:55 PM, Mark Cave-Ayland wrote: And here's where we are blowing up according to -d in_asm,op_out_asm: IN: 0x00f22ca0: 101ffc84 vor v0, v31, v31 OP: ld_i32 tmp0,env,$0xfff8 movi_

Re: [Qemu-devel] [PATCH RFC 0/3] qemu-img: remove command documentation duplication

On 6/26/19 2:03 PM, Max Reitz wrote: > On 10.04.19 03:24, John Snow wrote: >> This might hopefully cut down on the doc duplication/mismatching >> until I can devise something more comprehensive. >> >> Ideally, I'd like to redo all of the documentation for qemu-img >> nearly from scratch; with a

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

On Wed, 26 Jun 2019 18:47:42 +0200 Laurent Vivier wrote: > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > On Wed, 26 Jun 2019 18:16:36 +0200 > > Laurent Vivier wrote: > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > >>

Re: [Qemu-devel] [PATCH RFC 0/3] qemu-img: remove command documentation duplication

On 10.04.19 03:24, John Snow wrote: > This might hopefully cut down on the doc duplication/mismatching > until I can devise something more comprehensive. > > Ideally, I'd like to redo all of the documentation for qemu-img > nearly from scratch; with a parser generator that helps generate > the doc

Re: [Qemu-devel] [PULL 02/11] vhost-user: check unix_listen() return value

On 6/16/19 4:36 PM, Michael S. Tsirkin wrote: > From: Marc-André Lureau > > This check shouldn't be necessary, since &error_fatal is given as > argument and will exit() on failure. However, this change should > silence coverity CID 1401761 & 1401705. > > Signed-off-by: Marc-André Lureau > Messa

Re: [Qemu-devel] [PATCH v8 10/10] hw/m68k: define Macintosh Quadra 800

On 6/25/19 6:30 PM, Thomas Huth wrote: > Am Thu, 20 Jun 2019 00:19:33 +0200 > schrieb Laurent Vivier : > >> If you want to test the machine, it doesn't yet boot a MacROM, but >> you can boot a linux kernel from the command line. > > I gave the patch series a quick try, and was indeed able to boot

Re: [Qemu-devel] [PATCH] xen-block: support feature-large-sector-size

On 26.06.19 19:19, Anthony PERARD wrote: > On Wed, Jun 26, 2019 at 06:48:50PM +0200, Max Reitz wrote: >> On 09.04.19 18:40, Paul Durrant wrote: >>> A recent Xen commit [1] clarified the semantics of sector based quantities >>> used in the blkif protocol such that it is now safe to create a xen-bloc

Re: [Qemu-devel] [PATCH v8 03/10] dp8393x: manage big endian bus

On 6/26/19 12:11 PM, Laurent Vivier wrote: > Le 26/06/2019 à 10:57, Philippe Mathieu-Daudé a écrit : >> On 6/25/19 7:09 PM, Laurent Vivier wrote: >>> Le 25/06/2019 à 17:57, Philippe Mathieu-Daudé a écrit : On 6/24/19 10:07 PM, Laurent Vivier wrote: > Hi, > > Jason, Can I have an Ac

Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

On 6/26/19 6:49 PM, Stefano Garzarella wrote: > On Tue, Jun 25, 2019 at 02:39:05PM +0200, Christophe de Dinechin wrote: >> In hmp_change(), the variable hmp_mon is only used >> by code under #ifdef CONFIG_VNC. This results in a build >> error when VNC is configured out with the default of >> treati

Re: [Qemu-devel] [PATCH 3/7] configure: integrate Meson in the build system

Paolo Bonzini writes: > The Meson build system is integrated in the existing configure/make steps > by invoking Meson from the configure script and converting Meson's build.ninja > rules to an included Makefile. > > Signed-off-by: Paolo Bonzini > --- > Makefile | 9 + > configure

Re: [Qemu-devel] [PATCH] xen-block: support feature-large-sector-size

On Wed, Jun 26, 2019 at 06:48:50PM +0200, Max Reitz wrote: > On 09.04.19 18:40, Paul Durrant wrote: > > A recent Xen commit [1] clarified the semantics of sector based quantities > > used in the blkif protocol such that it is now safe to create a xen-block > > device with a logical_block_size != 51

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

On 26/06/2019 08:45, Richard Henderson wrote: > On 6/25/19 7:55 PM, Mark Cave-Ayland wrote: >> And here's where we are blowing up according to -d in_asm,op_out_asm: >> >> IN: >> 0x00f22ca0: 101ffc84 vor v0, v31, v31 >> >> OP: >> ld_i32 tmp0,env,$0xfff8 >> movi_i32 tmp1,$0x0 >> brcond

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

On Wed, Jun 26, 2019 at 12:14:15PM +0200, Paolo Bonzini wrote: > On 26/06/19 06:46, Markus Armbruster wrote: > >> I'm not sure how to wire it together without the bus abstraction? So > >> I'll stick with the bus for now. It *is* extremely convenient! > > > > As far as I can tell offhand, a common

Re: [Qemu-devel] [PATCH v2 07/14] target/arm/cpu64: max cpu: Introduce sve properties

Hi, On 6/21/19 6:34 PM, Andrew Jones wrote: > Introduce cpu properties to give fine control over SVE vector lengths. > We introduce a property for each valid length up to the current > maximum supported, which is 2048-bits. The properties are named, e.g. > sve128, sve256, sve512, ..., where the num

Re: [Qemu-devel] [PULL 0/3] M68k next patches

Patchew URL: https://patchew.org/QEMU/20190626162100.24774-1-laur...@vivier.eu/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that ha

Re: [Qemu-devel] [PATCH] xen-block: support feature-large-sector-size

On 09.04.19 18:40, Paul Durrant wrote: > A recent Xen commit [1] clarified the semantics of sector based quantities > used in the blkif protocol such that it is now safe to create a xen-block > device with a logical_block_size != 512, as long as the device only > connects to a frontend advertizing

Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

On Tue, Jun 25, 2019 at 02:39:05PM +0200, Christophe de Dinechin wrote: > In hmp_change(), the variable hmp_mon is only used > by code under #ifdef CONFIG_VNC. This results in a build > error when VNC is configured out with the default of > treating warnings as errors: > > monitor/hmp-cmds.c: In f

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > On Wed, 26 Jun 2019 18:16:36 +0200 > Laurent Vivier wrote: > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : The attached very trivial patch fixes a startup bug that prevents at le

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

On Wed, 26 Jun 2019 18:16:36 +0200 Laurent Vivier wrote: > Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > >> The attached very trivial patch fixes a startup bug that prevents > >> at least Qemu 3.1 and later from working on FreeBSD/powerpc6

[Qemu-devel] [PULL 0/3] M68k next patches

The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-next-pul

Re: [Qemu-devel] [Qemu-trivial] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

On Wed, 26 Jun 2019 18:30:47 +0200 Laurent Vivier wrote: > Le 15/06/2019 à 07:43, Philippe Mathieu-Daudé a écrit : > > Cc'ing qemu-trivial@ > > > > On 6/14/19 6:50 PM, Greg Kurz wrote: > > [...] > >> Markus, Xen maintainers, > >> > >> All needed Acked-by have been provided. I don't plan to sen

[Qemu-devel] Add SPLIT_LOCK DETECT capability to SnowRidge (SNR) cpu model

SPLIT_LOCK DETECT is enabled in qemu patch: x86: define a new MSR based feature word -- FEAT_CORE_CAPABILITY and kernel patch series that includes: x86/split_lock: Align x86_capability to unsigned long to avoid split locked access WAITPKG (UMONITOR/UMWAIT/TPAUSE) supplied in: x86/cpu: Ad

Re: [Qemu-devel] [Qemu-trivial] [PATCH] docs/vhost-user.json: some firmware.json copy leftovers

Le 26/06/2019 à 18:24, Laurent Vivier a écrit : > Le 05/06/2019 à 15:12, Marc-André Lureau a écrit : >> Signed-off-by: Marc-André Lureau >> --- >> docs/interop/vhost-user.json | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/docs/interop/vhost-user.json b/docs/int

Re: [Qemu-devel] [Qemu-trivial] [PATCH] docs/vhost-user.json: some firmware.json copy leftovers

Le 05/06/2019 à 15:12, Marc-André Lureau a écrit : > Signed-off-by: Marc-André Lureau > --- > docs/interop/vhost-user.json | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/interop/vhost-user.json b/docs/interop/vhost-user.json > index ae88c03117..da6aaf51c8 100

Re: [Qemu-devel] [Qemu-trivial] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

Le 15/06/2019 à 07:43, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial@ > > On 6/14/19 6:50 PM, Greg Kurz wrote: > [...] >> Markus, Xen maintainers, >> >> All needed Acked-by have been provided. I don't plan to send a 9pfs PR >> anytime soon. Can this go through someone else's tree please ?

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: use valid args testing sem_timedwait

Le 17/06/2019 à 13:41, Daniel P. Berrangé a écrit : > The sem_timedwait function has been annotated as requiring > non-null args in latest header files from GCC snapshot > representing the future 2.30 release. > > This causes configure to fail when -Werror is used: > > config-temp/qemu-conf.c: In

[Qemu-devel] [PULL 3/3] linux-user/m68k: remove simulator syscall interface

This interface has been introduced in 2005 with the coldfire implementation (e6e5906b6e ColdFire target.) and looks like to do what the linux-user interface already does with the TRAP exception rather than the ILLEGAL exception. This interface has not been maintained since that. The semi-hosting i

[Qemu-devel] [Qemu-devel v4] Introduce SnowRidge CPU model

SnowRidge CPU supports Accelerator Infrastrcture Architecture (MOVDIRI, MOVDIR64B), CLDEMOTE and SPLIT_LOCK_DISABLE. MOVDIRI, MOVDIR64B, and CLDEMOTE are found via CPUID. The availability of SPLIT_LOCK_DISABLE is check via msr access References can be found in either: https://software.intel.com/

[Qemu-devel] [PULL 2/3] m68k comments break patch submission due to being incorrectly formatted

From: Lucien Murray-Pitts Altering all comments in target/m68k to match Qemu coding styles so that future patches wont fail due to style breaches. Signed-off-by: Lucien Murray-Pitts Reviewed-by: Laurent Vivier Message-Id: <20190606234125.GA4830@localhost.localdomain> Signed-off-by: Laurent Viv

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > Le 07/06/2019 à 20:56, Justin Hibbits a écrit : >> The attached very trivial patch fixes a startup bug that prevents at >> least Qemu 3.1 and later from working on FreeBSD/powerpc64. >> >> - Justin >> > > Please don't send a patch in attachment but

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > The attached very trivial patch fixes a startup bug that prevents at > least Qemu 3.1 and later from working on FreeBSD/powerpc64. > > - Justin > Please don't send a patch in attachment but inlined in the message (you may use "git send-email" for

  1   2   3   >