Re: [PATCH 0/15] KVM: MIPS: Add Loongson-3 support (Host Side)

On Tue, 14 Apr 2020 09:40:26 +0800 maobibo wrote: > On 04/13/2020 04:18 PM, Jiaxun Yang wrote: > > On Mon, 13 Apr 2020 15:30:09 +0800 > > Huacai Chen wrote: > > > >> We are preparing to add KVM support for Loongson-3. VZ extension is > >> fully supported in Loongson-3A R4+, and we will not

Re: Boot flakiness with QEMU 3.1.0 and Clang built kernels

On Tue, Apr 14, 2020 at 12:05:53PM +1000, David Gibson wrote: > On Sat, Apr 11, 2020 at 11:57:23PM +1000, Nicholas Piggin wrote: > > Nicholas Piggin's on April 11, 2020 7:32 pm: > > > Nathan Chancellor's on April 11, 2020 10:53 am: > > >> The tt.config values are needed to reproduce but I did not

Re: [PATCH] spapr_nvdimm.c: make 'label-size' mandatory

CCing Xiao, Michael and Igor for generic NVDIMM perspective. On Mon, Apr 13, 2020 at 05:36:28PM -0300, Daniel Henrique Barboza wrote: > The pseries machine does not support NVDIMM modules without label. > Attempting to do so, even if the overall block size is aligned with > 256MB, will seg fault

Re: [PATCH RESEND v3 0/2] Makefile: libfdt: build only the strict necessary

On Sat, Apr 11, 2020 at 11:31:48AM +0200, Claudio Fontana wrote: > v2 -> v3: > > * changed into a 2 patch series; in the second patch we remove the old > compatibility gunks that were meant for removal some time after 4.1. > > * renamed the libfdt PHONY rule to dtc/all, with the intent to make

Re: [PATCH-for-5.1 v3 11/23] hw/pci-host/pnv_phb3: Add missing error-propagation code

On Mon, Apr 13, 2020 at 12:41:32AM +0200, Philippe Mathieu-Daudé wrote: > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ > --keep-comments

Re: [PATCH-for-5.1 1/3] target: Remove unnecessary CPU() cast

On Sun, Apr 12, 2020 at 11:09:52PM +0200, Philippe Mathieu-Daudé wrote: > The CPU() macro is defined as: > > #define CPU(obj) ((CPUState *)(obj)) > > Remove an unnecessary CPU() cast. > > Patch created mechanically using spatch with this script: > > @@ > typedef CPUState; > CPUState

Re: Boot flakiness with QEMU 3.1.0 and Clang built kernels

On Sat, Apr 11, 2020 at 11:57:23PM +1000, Nicholas Piggin wrote: > Nicholas Piggin's on April 11, 2020 7:32 pm: > > Nathan Chancellor's on April 11, 2020 10:53 am: > >> The tt.config values are needed to reproduce but I did not verify that > >> ONLY tt.config was needed. Other than that, no, we

Re: [PATCH-for-5.1 v3 18/24] hw/pci-host/pnv_phb3: Move some code from realize() to init()

On Mon, Apr 13, 2020 at 12:36:13AM +0200, Philippe Mathieu-Daudé wrote: > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/pci-host/pnv_phb3.c > >>> possible moves from

Re: [PATCH-for-5.1 3/3] hw: Remove unnecessary DEVICE() cast

On Sun, Apr 12, 2020 at 11:09:54PM +0200, Philippe Mathieu-Daudé wrote: > The DEVICE() macro is defined as: > > #define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE) > > Remove unnecessary DEVICE() casts. > > Patch created mechanically using spatch with this script: > > @@ >

Re: [PATCH-for-5.1 v3 01/24] various: Remove suspicious '\' character outside of #define in C code

On Mon, Apr 13, 2020 at 12:35:56AM +0200, Philippe Mathieu-Daudé wrote: > Fixes the following coccinelle warnings: > > $ spatch --sp-file --verbose-parsing ... \ > scripts/coccinelle/remove_local_err.cocci > ... > SUSPICIOUS: a \ character appears outside of a #define at >

[PATCH RFC] target/arm: Implement SVE2 MATCH, NMATCH

Signed-off-by: Stephen Long --- Submitting this for early review. I'm working with Richard on SVE2 support for qemu. I'll be attempting to tackle the insns in the 'SVE2 integer add/subtract narrow high part' category next [1]. [1] ISA manual:

Re: [PATCH 0/15] KVM: MIPS: Add Loongson-3 support (Host Side)

On 04/13/2020 04:18 PM, Jiaxun Yang wrote: > On Mon, 13 Apr 2020 15:30:09 +0800 > Huacai Chen wrote: > >> We are preparing to add KVM support for Loongson-3. VZ extension is >> fully supported in Loongson-3A R4+, and we will not care about old >> CPUs (at least now). We already have a full

Re: [PATCH 21/31] target/arm: Implement SVE2 integer absolute difference and accumulate long

On 4/13/20 9:15 AM, Laurent Desnogues wrote: > On Fri, Mar 27, 2020 at 12:18 AM Richard Henderson > wrote: > [...] >> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c >> index a3653007ac..a0995d95c7 100644 >> --- a/target/arm/sve_helper.c >> +++ b/target/arm/sve_helper.c >> @@

Re: [PATCH v19 QEMU 4/4] memory: Do not allow direct write access to rom_device regions

On Fri, Apr 10, 2020 at 3:50 AM Paolo Bonzini wrote: > > On 10/04/20 05:41, Alexander Duyck wrote: > > From: Alexander Duyck > > > > According to the documentation in memory.h a ROM memory region will be > > backed by RAM for reads, but is supposed to go through a callback for > > writes.

Re: [PATCH-for-5.1 v3 19/24] hw/riscv/sifive_e: Move some code from realize() to init()

On Sun, Apr 12, 2020 at 3:45 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/riscv/sifive_e.c > >>> possible moves from riscv_sifive_e_soc_init() to >

Re: [PATCH-for-5.1 v3 17/24] hw/microblaze/xlnx-zynqmp-pmu: Move some code from realize() to init()

On Sun, Apr 12, 2020 at 3:44 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/microblaze/xlnx-zynqmp-pmu.c > >>> possible moves from

Re: [PATCH-for-5.1 v3 21/24] hw/riscv/sifive_u: Move some code from realize() to init()

On Sun, Apr 12, 2020 at 3:49 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/riscv/sifive_u.c > >>> possible moves from riscv_sifive_u_soc_init() to >

Re: [PATCH-for-5.1 v3 23/24] hw/riscv/sifive_u: Move some code from realize() to init()

On Sun, Apr 12, 2020 at 3:48 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/riscv/sifive_u.c > >>> possible moves from riscv_sifive_u_soc_init() to >

Re: [PATCH-for-5.1 v3 22/24] hw/riscv/sifive_u: Store MemoryRegion in SiFiveUSoCState

On Sun, Apr 12, 2020 at 3:52 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/riscv/sifive_u.c > >>> possible moves from riscv_sifive_u_soc_init() to >

Re: [PATCH-for-5.1 v3 10/23] hw/microblaze/xlnx-zynqmp-pmu: Add missing error-propagation code

On Sun, Apr 12, 2020 at 3:58 PM Philippe Mathieu-Daudé wrote: > > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ > --keep-comments

Re: [PATCH-for-5.1 v3 24/24] hw/riscv/sifive_u: Rename MachineClass::init()

On Sun, Apr 12, 2020 at 3:54 PM Philippe Mathieu-Daudé wrote: > > As there already is the riscv_sifive_u_soc_init() method, > rename riscv_sifive_u_init() as riscv_sifive_u_machine_init(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH-for-5.1 1/3] hw/ide/ahci: Use qdev gpio rather than qemu_allocate_irqs()

On Sun, Apr 12, 2020 at 2:29 PM Philippe Mathieu-Daudé wrote: > > Switch to using the qdev gpio API which is preferred over > qemu_allocate_irqs(). One step to eventually deprecate and > remove qemu_allocate_irqs() one day. > > Patch created mechanically using spatch with this script > inspired

Re: [PATCH-for-5.1 v3 07/23] hw/riscv/sifive: Add missing error-propagation code

On Sun, Apr 12, 2020 at 4:00 PM Philippe Mathieu-Daudé wrote: > > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ > --keep-comments

Re: [PATCH-for-5.1 v3 08/23] hw/arm/armv7m: Add missing error-propagation code

On Sun, Apr 12, 2020 at 3:54 PM Philippe Mathieu-Daudé wrote: > > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ > --keep-comments

Re: [PATCH-for-5.1 v3 20/24] hw/riscv/sifive_u: Use single type_init()

On Sun, Apr 12, 2020 at 3:48 PM Philippe Mathieu-Daudé wrote: > > We can use a single type_init() to call multiple type_register*(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/sifive_u.c | 12 +++- > 1 file changed, 3

Re: [PATCH-for-5.1 v3 16/24] hw/arm/xlnx-zynqmp: Move some code from realize() to init()

On Sun, Apr 12, 2020 at 3:41 PM Philippe Mathieu-Daudé wrote: > > Coccinelle failed at processing this file: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/arm/xlnx-zynqmp.c > EXN:

Re: [PATCH-for-5.1 v3 14/24] hw/arm/xlnx-zynqmp: Use single propagate_error() call

On Sun, Apr 12, 2020 at 3:45 PM Philippe Mathieu-Daudé wrote: > > Coccinelle failed at processing this file: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/arm/xlnx-zynqmp.c > EXN:

Re: [PATCH-for-5.1 v3 13/24] hw/arm/stm32f205_soc: Move some code from realize() to init()

On Sun, Apr 12, 2020 at 3:42 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/arm/stm32f205_soc.c > >>> possible moves from stm32f205_soc_initfn() to

Re: [PATCH] MAINTAINERS: Add myself as vhost-user-blk maintainer

On 4/10/20 2:28 AM, Raphael Norwitz wrote: > Ping FYI this patch has been recently merged as commit b372d79b236a4e07eaa3ce65ee0543569b712326. > > On Thu, Mar 26, 2020 at 04:47:35AM -0400, Raphael Norwitz wrote: >> As suggested by Michael, let's add me as a maintainer of >> vhost-user-blk and

Re: [PATCH-for-5.1 v3 12/24] hw/arm/stm32f205_soc: Store MemoryRegion in STM32F205State

On Sun, Apr 12, 2020 at 3:41 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/arm/stm32f205_soc.c > >>> possible moves from stm32f205_soc_initfn() to

Re: [PATCH-for-5.1 v3 11/24] hw/arm/msf2-soc: Store MemoryRegion in MSF2State

On Sun, Apr 12, 2020 at 3:40 PM Philippe Mathieu-Daudé wrote: > > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/arm/msf2-soc.c > >>> possible moves from m2sxxx_soc_initfn() to

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

On 4/10/20 4:37 PM, Aleksandar Markovic wrote: > 04:39 Čet, 09.04.2020. Jiaxun Yang > је написао/ла: >> >> On Thu, 9 Apr 2020 10:17:46 +0800 >> Huacai Chen mailto:che...@lemote.com>> wrote: >> >> > Hi, Aleksandar, >> > >> > On Wed, Apr 8, 2020 at 11:30 PM

[PATCH-for-5.0 v2] hw/display/sm501: Avoid heap overflow in sm501_2d_operation()

Zhang Zi Ming reported a heap overflow in the Drawing Engine of the SM501 companion chip model, in particular in the COPY_AREA() macro in sm501_2d_operation(). Add a simple check to avoid the heap overflow. This fixes: =

Re: [PATCH] .gitignore: include common build sub-directories

On 4/13/20 11:42 PM, Eric Blake wrote: > On 4/13/20 4:32 PM, Alex Bennée wrote: >> >> Eric Blake writes: >> >>> On 4/13/20 11:29 AM, Alex Bennée wrote: As out-of-tree builds become more common (or rather building in a subdir) we can add a lot of load to "git ls-files" as it hunts down

Re: [PATCH] .gitignore: include common build sub-directories

On 4/13/20 4:32 PM, Alex Bennée wrote: Eric Blake writes: On 4/13/20 11:29 AM, Alex Bennée wrote: As out-of-tree builds become more common (or rather building in a subdir) we can add a lot of load to "git ls-files" as it hunts down sub-directories that are irrelevant to the source tree.

[PATCH-for-5.1 v3 2/7] various: Use _abort in instance_init()

Patch created mechanically by running: $ spatch \ --macro-file scripts/cocci-macro-file.h \ --include-headers --keep-comments --in-place \ --sp-file \ scripts/coccinelle/use-error_abort-in-instance_init.cocci Reviewed-by: Cédric Le Goater Acked-by: Cornelia Huck

Re: [PATCH] .gitignore: include common build sub-directories

Eric Blake writes: > On 4/13/20 11:29 AM, Alex Bennée wrote: >> As out-of-tree builds become more common (or rather building in a >> subdir) we can add a lot of load to "git ls-files" as it hunts down >> sub-directories that are irrelevant to the source tree. This is >> especially annoying if

Re: [PATCH-for-5.0? 3/3] hw/openrisc/pic_cpu: Use qdev gpio rather than qemu_allocate_irqs()

Hi Stafford, On 4/13/20 1:33 AM, Stafford Horne wrote: > On Sun, Apr 12, 2020 at 11:29:43PM +0200, Philippe Mathieu-Daudé wrote: >> Switch to using the qdev gpio API which is preferred over >> qemu_allocate_irqs(). Doing so we also stop leaking the >> allocated memory. One step to eventually

Re: [PATCH-for-5.1 1/3] hw/ide/ahci: Use qdev gpio rather than qemu_allocate_irqs()

[sending again as my previous mail was rejected, sorry if you get this twice] On 4/12/20 11:29 PM, Philippe Mathieu-Daudé wrote: > Switch to using the qdev gpio API which is preferred over > qemu_allocate_irqs(). One step to eventually deprecate and > remove qemu_allocate_irqs() one day. > >

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Cc'ing Peter] On 4/13/20 12:12 PM, KONRAD Frederic wrote: > Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit : >> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote: >>> Philippe Mathieu-Daudé (7): >>>    hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP >>> registers >>>   

Re: [PATCH-for-5.1 v3 03/24] hw/arm/allwinner-a10: Move some code from realize() to init()

On 4/13/20 12:35 AM, Philippe Mathieu-Daudé wrote: > Coccinelle reported: > > $ spatch ... --timeout 60 --sp-file \ > scripts/coccinelle/simplify-init-realize-error_propagate.cocci > HANDLING: ./hw/arm/allwinner-a10.c > >>> possible moves from aw_a10_init() to aw_a10_realize() in >

[PATCH-for-5.1 v3 4/7] migration/colo: Add missing error-propagation code

Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ --keep-comments --smpl-spacing --dir . HANDLING: ./migration/colo.c [[manual check required:

[PATCH-for-5.1 v3 5/7] hw/mips/boston: Add missing error-propagation code

Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ --keep-comments --smpl-spacing --dir . HANDLING: ./hw/mips/boston.c [[manual check required:

[PATCH-for-5.1 v3 3/7] scripts/coccinelle: Find eventually missing error_propagate() calls

In some places in we put an error into a local Error*, but forget to use it. Add a Coccinelle patch to find such cases and report them. Inspired-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- .../find-missing-error_propagate.cocci| 53 +++ MAINTAINERS

[PATCH-for-5.1 v3 1/7] scripts/coccinelle: Use _abort in TypeInfo::instance_init()

The instance_init() calls are not suppose to fail. Add a Coccinelle script to use _abort instead of ignoring errors by using a NULL Error*. Signed-off-by: Philippe Mathieu-Daudé --- v3: Improved script (Vladimir Sementsov-Ogievskiy suggestions) .../use-error_abort-in-instance_init.cocci|

[PATCH-for-5.1 v3 7/7] qga/commands-win32: Add missing error-propagation code

Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ --keep-comments --smpl-spacing --dir . HANDLING: ./qga/commands-win32.c [[manual check required:

[PATCH] spapr_nvdimm.c: make 'label-size' mandatory

The pseries machine does not support NVDIMM modules without label. Attempting to do so, even if the overall block size is aligned with 256MB, will seg fault the guest kernel during NVDIMM probe. This can be avoided by forcing 'label-size' to always be present for sPAPR NVDIMMs. The verification

[PATCH-for-5.1 v3 6/7] hw/mips/mips_malta: Use _abort in MachineClass::init -> create_cps

Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ --keep-comments --smpl-spacing --dir . HANDLING: ./hw/mips/mips_malta.c [[manual check required:

Re: [PULL 0/4] pc: bugfixes, maintainers

On Mon, 13 Apr 2020 at 12:09, Michael S. Tsirkin wrote: > > The following changes since commit f3bac27cc1e303e1860cc55b9b6889ba39dee587: > > Update version for v5.0.0-rc2 release (2020-04-07 23:13:37 +0100) > > are available in the Git repository at: > >

Re: Supported Sphinx Versions (was: Re: [PATCH for-5.0? 0/3] Make docs build work with Sphinx 3)

On 4/13/20 2:22 PM, Peter Maydell wrote: > On Mon, 13 Apr 2020 at 19:08, John Snow wrote: >> I was curious about our actual version compatibility, so I did some testing. > > Thanks for doing the testing. > >> 1.6.1 through 2.2.2 all appear to work just fine, but produce a lot of >> warnings

Re: [PATCH] .gitignore: include common build sub-directories

On 4/13/20 11:29 AM, Alex Bennée wrote: As out-of-tree builds become more common (or rather building in a subdir) we can add a lot of load to "git ls-files" as it hunts down sub-directories that are irrelevant to the source tree. This is especially annoying if you have a prompt that attempts to

Re: Supported Sphinx Versions (was: Re: [PATCH for-5.0? 0/3] Make docs build work with Sphinx 3)

On Mon, 13 Apr 2020 at 19:08, John Snow wrote: > I was curious about our actual version compatibility, so I did some testing. Thanks for doing the testing. > 1.6.1 through 2.2.2 all appear to work just fine, but produce a lot of > warnings about a coming incompatibility with Docutils > 0.16.

[Bug 1872237] Re: SysTick reload behavior emulated incorrectly

Other than the systick issue, I think the core M-profile emulation should be pretty solid (bugs are always possible, of course). We have support for v6M (cortex-m0), v7M (cortex-m3, m4) and v8M (cortex-m33, including the security extension) and at least some board models for all of those. No v8.1M

Re: [PATCH] hax: Windows doesn't like posix device names

> On 22/03/20 22:02, Volker Rümelin wrote: >> Patch acb9f95a7c "i386: Fix GCC warning with snprintf when HAX >> is enabled" replaced Windows device names with posix device >> names. Revert this. >> >> Fixes: acb9f95a7c "i386: Fix GCC warning with snprintf when HAX is enabled" >> Queued, thanks.

Re: [PATCH for-5.0] qcow2: Add incompatibility note between backing files and raw external data files

On 4/10/20 7:18 AM, Alberto Garcia wrote: Backing files and raw external data files are mutually exclusive. The documentation of the raw external data bit (in autoclear_features) already indicates that, but we should also mention it on the other side. Suggested-by: Eric Blake Signed-off-by:

Re: [Qemu-devel] [PATCH v3] net: cadence_gem: fix compilation error when debug is on

False alarm, exact same patch was merged by someone else. On Mon, Apr 13, 2020 at 8:55 PM Ramon Fried wrote: > > Hi. > Just noticed that this patch didn't hit master. > Got lost ? > > Thanks, > Ramon. > > On Sat, Jun 15, 2019 at 9:16 AM Ramon Fried wrote: > > > > > > > > On June 15, 2019

Supported Sphinx Versions (was: Re: [PATCH for-5.0? 0/3] Make docs build work with Sphinx 3)

On 4/11/20 2:29 PM, Peter Maydell wrote: > Our current docs don't build with Sphinx 3, as noted in > https://bugs.launchpad.net/bugs/1872113 -- this is a combination of: > (1) we are using the sphinx-build -W option so warnings are treated > as errors > (3) a kernel-doc script bug meant

Re: Domain backup file explodes on s3fs

Hi Eric and all, When invoking "virsh backup-begin" to do a full backup using qcow2 driver to a new backup target file that does not have a backing chain, is it safe to not zero the unallocated parts of the virtual disk? Do we still depend on SEEK_DATA support in this case to avoid forcing

Re: [PATCH v2] net: cadence_gem: clear RX control descriptor

Hi. Just noticed that this patch didn't hit master. Got lost ? Thanks, Ramon. On Tue, Jul 16, 2019 at 2:58 PM Jason Wang wrote: > > > On 2019/7/16 下午6:59, Ramon Fried wrote: > > The RX ring descriptors control field is used for setting > > SOF and EOF (start of frame and end of frame). > > The

Re: [Qemu-devel] [PATCH v3] net: cadence_gem: fix compilation error when debug is on

Hi. Just noticed that this patch didn't hit master. Got lost ? Thanks, Ramon. On Sat, Jun 15, 2019 at 9:16 AM Ramon Fried wrote: > > > > On June 15, 2019 8:38:35 AM GMT+03:00, "Philippe Mathieu-Daudé" > wrote: > >Hi Ramon, > > > >On 6/15/19 7:15 AM, Ramon Fried wrote: > >> defining

[Bug 1872237] Re: SysTick reload behavior emulated incorrectly

@pmaydell: Thanks for the quick response! For whatever it's worth, I think that there's definitely a bunch of interest in the M-profile work: in the embedded Rust space (for example) Cortex-M is very much the reference platform. Viz. the Embedded Rust Book:

Re: [PATCH v4 30/30] iotests: Add tests for qcow2 images with extended L2 entries

On Thu 09 Apr 2020 02:22:37 PM CEST, Max Reitz wrote: >> +### Write subcluster #31-#34 (cluster overlap) ### > > #31-#34, I think. That's what I wrote :-? >> +### Partially zeroize an unallocated cluster (#3) >> +if [ "$use_backing_file" = "yes" ]; then >> +alloc="`seq 0

[PATCH] .gitignore: include common build sub-directories

As out-of-tree builds become more common (or rather building in a subdir) we can add a lot of load to "git ls-files" as it hunts down sub-directories that are irrelevant to the source tree. This is especially annoying if you have a prompt that attempts to summarise the current git status on

Re: [PATCH 20/31] target/arm: Implement SVE2 complex integer add

On Fri, Mar 27, 2020 at 12:20 AM Richard Henderson wrote: [...] > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index b5afa34efe..a3653007ac 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1289,6 +1289,48 @@ DO_BITPERM(sve2_bgrp_d, uint64_t,

Re: [PATCH 22/31] target/arm: Implement SVE2 integer add/subtract long with carry

On Fri, Mar 27, 2020 at 12:17 AM Richard Henderson wrote: [...] > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index a0995d95c7..aa330f75c3 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c [...] > +void HELPER(sve2_adcl_d)(void *vd, void *va, void *vn,

Re: [PATCH 21/31] target/arm: Implement SVE2 integer absolute difference and accumulate long

On Fri, Mar 27, 2020 at 12:18 AM Richard Henderson wrote: [...] > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index a3653007ac..a0995d95c7 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1216,6 +1216,30 @@ DO_ZZZ_NTB(sve2_eoril_d, uint64_t, ,

Re: [PATCH 13/31] target/arm: Implement SVE2 integer add/subtract wide

On Fri, Mar 27, 2020 at 12:17 AM Richard Henderson wrote: [...] > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 7d7a59f620..44503626e4 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1131,6 +1131,36 @@ DO_ZZZ_TB(sve2_uabdl_d, uint64_t,

Re: [PATCH 11/31] target/arm: Implement SVE2 integer add/subtract long

On Fri, Mar 27, 2020 at 12:09 AM Richard Henderson wrote: [...] > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index bee00eaa44..7d7a59f620 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1088,6 +1088,49 @@ DO_ZZW(sve_lsl_zzw_s, uint32_t, uint64_t,

Re: [PATCH-for-5.1 v3 06/23] hw/arm/msf2-soc: Add missing error-propagation code

On Sun, Apr 12, 2020 at 3:53 PM Philippe Mathieu-Daudé wrote: > > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ > --keep-comments

Re: [PATCH-for-5.1 v3 01/24] various: Remove suspicious '\' character outside of #define in C code

On Sun, Apr 12, 2020 at 3:38 PM Philippe Mathieu-Daudé wrote: > > Fixes the following coccinelle warnings: > > $ spatch --sp-file --verbose-parsing ... \ > scripts/coccinelle/remove_local_err.cocci > ... > SUSPICIOUS: a \ character appears outside of a #define at >

Re: [PATCH 09/31] target/arm: Implement SVE2 integer pairwise arithmetic

On Fri, Mar 27, 2020 at 12:16 AM Richard Henderson wrote: [...] > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 5d75aed7b7..d7c181ddb8 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -681,6 +681,73 @@ DO_ZPZZ_D(sve2_uhsub_zpzz_d, uint64_t,

Re: [PATCH v2] gdbstub: Fix segment fault for i386 target

Changbin Du writes: > With GByteArray, we should pass the object itself but not to plus an offset. > > gdb log: > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > __memmove_avx_unaligned_erms () at > ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:384 > 384

Re: [PULL v2 0/8] Misc patches for QEMU 5.0-rc3

On Mon, 13 Apr 2020 at 08:05, Paolo Bonzini wrote: > > The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200406' into staging (2020-04-06 > 12:36:45 +0100) > > are available in the Git

Re: [RFC patch v1 0/3] qemu-file writing performance improving

Patchew URL: https://patchew.org/QEMU/1586776334-641239-1-git-send-email-dplotni...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: colo: qemu 4.2.0 vs. qemu 5.0.0-rc2 performance regression

On Sat, 11 Apr 2020 19:16:54 +0200 Lukas Straub wrote: > Hello Everyone, > I did some Benchmarking with iperf3 and memtester (to dirty some guest memory) > of colo performance in qemu 4.2.0 and in qemu 5.0.0-rc2 > with my bugfixes on top.( >

Re: [PATCH v2 0/6] Automation of Coverity Scan uploads (via Docker)

Yes, go ahead. I would like to add a docker-coverity Makefile target but I can do that later. Il lun 13 apr 2020, 14:13 Peter Maydell ha scritto: > What's your view on this series, Paolo? Personally I'd like > to put it into master, because at least then we have something > that we can do

Re: [PATCH v18 0/4] qcow2: Implement zstd cluster compression method

Ping! Is there something to be fixed in the series? Thanks, Denis On 02.04.2020 09:36, Denis Plotnikov wrote: v18: * 04: add quotes to all file name variables [Vladimir] * 04: add Vladimir's comment according to "qemu-io write -s" option issue. v17: * 03: remove

Re: [PATCH v2 0/6] Automation of Coverity Scan uploads (via Docker)

What's your view on this series, Paolo? Personally I'd like to put it into master, because at least then we have something that we can do Coverity runs on, whereas AIUI at the moment we don't. But I'd rather not put it in after rc3, which is tomorrow... thanks -- PMM On Thu, 19 Mar 2020 at

Re: [PULL for-5.0 0/1] tcg patch queue

On Sun, 12 Apr 2020 at 22:11, Richard Henderson wrote: > > The following changes since commit 17e1e49814096a3daaa8e5a73acd56a0f30bdc18: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-04-09 19:00:41 +0100) > > are available in the Git repository

Re: [RFC patch v1 0/3] qemu-file writing performance improving

On 4/13/20 2:12 PM, Denis Plotnikov wrote: > Problem description: qcow2 internal snapshot saving time is too big on HDD ~ > 25 sec > > When a qcow2 image is placed on a regular HDD and the image is openned with > O_DIRECT the snapshot saving time is around 26 sec. > The snapshot saving time can

Re: [PATCH 13/15] KVM: MIPS: Add CONFIG6 and DIAG registers emulation

On Mon, 13 Apr 2020 15:30:22 +0800 Huacai Chen wrote: > Loongson-3 has CONFIG6 and DIAG registers which need to be emulate. > CONFIG6 is mostly used to enable/disable FTLB and SFB, while DIAG is > mostly used to flush BTB, ITLB, DTLB, VTLB and FTLB. > > Signed-off-by: Huacai Chen >

[RFC patch v1 2/3] qemu-file: add buffered mode

The patch adds ability to qemu-file to write the data asynchronously to improve the performance on writing. Before, only synchronous writing was supported. Enabling of the asyncronous mode is managed by new "enabled_buffered" callback. Signed-off-by: Denis Plotnikov --- include/qemu/typedefs.h

[RFC patch v1 1/3] qemu-file: introduce current buffer

To approach async wrtiting in the further commits, the buffer allocated in QEMUFile struct is replaced with the link to the current buffer. We're going to use many buffers to write the qemu file stream to the unerlying storage asynchronously. The current buffer points out to the buffer is

[RFC patch v1 3/3] migration/savevm: use qemu-file buffered mode for non-cached bdrv

This makes internal snapshots of HDD placed qcow2 images opened with O_DIRECT flag 4 times faster. The test: creates 500M internal snapshot for a cow2 image placed on HDD Result times: with the patch: ~6 sec without patch: ~24 sec This happens because the internal snapshot saving

[RFC patch v1 0/3] qemu-file writing performance improving

Problem description: qcow2 internal snapshot saving time is too big on HDD ~ 25 sec When a qcow2 image is placed on a regular HDD and the image is openned with O_DIRECT the snapshot saving time is around 26 sec. The snapshot saving time can be 4 times sorter. The patch series propose the way to

[PULL 4/4] exec: Fix for qemu_ram_resize() callback

From: David Hildenbrand Summarizing the issue: 1. Memory regions contain ram blocks with a different size, if the size is not properly aligned. While memory regions can have an unaligned size, ram blocks can't. This is true when creating resizable memory region with an unaligned

[PULL 3/4] fw_cfg: Migrate ACPI table mr sizes separately

From: Shameer Kolothum Any sub-page size update to ACPI MRs will be lost during migration, as we use aligned size in ram_load_precopy() -> qemu_ram_resize() path. This will result in inconsistency in FWCfgEntry sizes between source and destination. In order to avoid this, save and restore them

[PULL 2/4] acpi: Use macro for table-loader file name

From: Shameer Kolothum Use macro for "etc/table-loader" and move it to the header file similar to ACPI_BUILD_TABLE_FILE/ACPI_BUILD_RSDP_FILE etc. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov Message-Id: <20200403101827.30664-2-shameerali.kolothum.th...@huawei.com> Reviewed-by:

[PULL 1/4] MAINTAINERS: Add myself as vhost-user-blk maintainer

From: Raphael Norwitz As suggested by Michael, let's add me as a maintainer of vhost-user-blk and vhost-user-scsi. CC: Michael S. Tsirkin CC Peter Maydell Signed-off-by: Raphael Norwitz Message-Id: <1585213047-20089-1-git-send-email-raphael.norw...@nutanix.com> Reviewed-by: Michael S.

[PULL 0/4] pc: bugfixes, maintainers

The following changes since commit f3bac27cc1e303e1860cc55b9b6889ba39dee587: Update version for v5.0.0-rc2 release (2020-04-07 23:13:37 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

Re: [PATCH v2] gdbstub: Fix segment fault for i386 target

Le 13/04/2020 à 01:32, Changbin Du a écrit : > With GByteArray, we should pass the object itself but not to plus an offset. > > gdb log: > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > __memmove_avx_unaligned_erms () at >

Re: [PATCH v4 10/30] qcow2: Add offset_to_sc_index()

17.03.2020 21:16, Alberto Garcia wrote: For a given offset, return the subcluster number within its cluster (i.e. with 32 subclusters per cluster it returns a number between 0 and 31). Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best

Re: [PATCH-for-5.0 0/3] virtio, vhost-gpu: Release memory returned by malloc() with free()

On Mon, Mar 23, 2020 at 09:41:20AM -0400, Michael S. Tsirkin wrote: > On Mon, Mar 23, 2020 at 12:29:40PM +0100, Philippe Mathieu-Daudé wrote: > > Coverity reported a ALLOC_FREE_MISMATCH in vg_handle_cursor(), > > because the memory returned by vu_queue_pop() is allocated with > > malloc(). Fix it.

Re: [PATCH] hw/pci/pcie: Forbid hot-plug via QMP if it's disabled on the slot

On Wed, Apr 08, 2020 at 12:51:20PM +0200, Igor Mammedov wrote: > On Tue, 7 Apr 2020 16:50:17 +0200 > Julia Suvorova wrote: > > > Raise an error when trying to hot-plug/unplug a device through QMP to a > > device > > with disabled hot-plug capability. This makes the device behaviour more > >

[PATCH v3] migration/throttle: Add cpu-throttle-tailslow migration parameter

At the tail stage of throttling, the Guest is very sensitive to CPU percentage while the @cpu-throttle-increment is excessive usually at tail stage. If this parameter is true, we will compute the ideal CPU percentage used by the Guest, which may exactly make the dirty rate match the dirty rate

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit : On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (7): hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses Ping ^^^ for 5.0?

Re: [PATCH v2] lockable: Replace locks with lock guard macros

On Thu, 2 Apr 2020 at 09:50, Simran Singhal wrote: > Replace manual lock()/unlock() calls with lock guard macros > (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). > > Signed-off-by: Simran Singhal > --- > Changes in v2: > -Drop changes in file hw/rdma/rdma_utils.c > So i guess we are expected

[PATCH 1/3] bugfix: Use gicr_typer in arm_gicv3_icc_reset

The KVM_VGIC_ATTR macro expect the second parameter as gicr_typer, of which high 32bit is constructed by mp_affinity. For most case, the high 32bit of mp_affinity is zero, so it will always access the ICC_CTLR_EL1 of CPU0. Signed-off-by: Keqian Zhu --- hw/intc/arm_gicv3_kvm.c | 4 +--- 1 file

[PATCH 2/3] intc/gicv3_kvm: use kvm_gicc_access to get ICC_CTLR_EL1

Replace kvm_device_access with kvm_gicc_access to simplify code. Signed-off-by: Keqian Zhu --- hw/intc/arm_gicv3_kvm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index ca43bf87ca..85f6420498 100644 ---

[PATCH 0/3] Some trivial fixes

Hi all, This patch-set contains trivial bugfix and typo fix. Thanks, Keqian Keqian Zhu (3): bugfix: Use gicr_typer in arm_gicv3_icc_reset intc/gicv3_kvm: use kvm_gicc_access to get ICC_CTLR_EL1 Typo: Correct the name of CPU hotplug memory region hw/acpi/cpu.c | 2 +-

  1   2   >