On Fri, 2020-09-18 at 16:42 +, Eduardo Habkost wrote:
> ...
> > > > ---
> > > > Changelog
> > > > v3:
> > > > Make the deprecation implementation CPUClass generic.
> > > >
> > > > v2:
> > > > Move deprecation check from parse_cpu_option() to
> > > > machine_run_board_init(), so
> > > > that
A comment blob is added in bios-tables-test.c that explains the reasoning
behind the process of updating the ACPI table blobs when new tests are added
or old tests are modified or code is committed that affect tests. The
explanation would help future contributors follow the correct process when
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
On 2020/9/18 22:06, Fam Zheng wrote:
>
> I can see how blocking in a slow io_submit can cause trouble for main
> thread. I think one way to fix it (until it's made truly async in new
> kernels) is moving the io_submit call to thread pool, and wrapped in a
> coroutine, perhaps.
>
I'm not sure if
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Hi, Philippe,
On Thu, Sep 17, 2020 at 3:53 PM Philippe Mathieu-Daudé wrote:
>
> On 9/16/20 12:47 PM, Philippe Mathieu-Daudé wrote:
> > On 9/16/20 11:49 AM, Huacai Chen wrote:
> >> On Wed, Sep 16, 2020 at 3:56 PM Philippe Mathieu-Daudé
> >> wrote:
> >>> On 9/16/20 4:12 AM, Huacai Chen wrote:
>
Hi, Richard,
On Wed, Sep 16, 2020 at 11:15 PM Richard Henderson
wrote:
>
> On 9/15/20 7:12 PM, Huacai Chen wrote:
> > +case OPC_GSLQ:
> > +gen_base_offset_addr(ctx, t0, rs, lsq_offset);
> > +tcg_gen_qemu_ld_tl(t0, t0, ctx->mem_idx, MO_TEQ |
> > +
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Note, this also occurs with freeDOS 1.2, at least.
Note 2, 4.2 stable does not exhibit the bug.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896298
Title:
memory leak
Status in QEMU:
New
This patch shold fix the regression:
diff --git a/configure b/configure
index 0004c46525..0786144043 100755
--- a/configure
+++ b/configure
@@ -7414,6 +7414,7 @@ NINJA=${ninja:-$PWD/ninjatool} $meson setup \
-Dwerror=$(if test "$werror" = yes; then echo true; else echo false;
fi) \
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Patchew URL:
https://patchew.org/QEMU/20200918204759.225810-1-marcandre.lur...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST
On Fri, Sep 04, 2020 at 04:54:31PM +0200, Vitaly Kuznetsov wrote:
> To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we
> need to expand and set the corresponding CPUID leaves early. Modify
> x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V
> specific
Public bug reported:
qemu trunk as of today leaks memory FAST when freedos' edit is running.
To reproduce, download:
https://www.ibiblio.org/pub/micro/pc-
stuff/freedos/files/repositories/1.3/cdrom.iso
Then run:
$ qemu-system-i386 -cdrom cdrom.iso
select your language then select "return to
On Fri, Sep 04, 2020 at 04:54:31PM +0200, Vitaly Kuznetsov wrote:
> To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we
> need to expand and set the corresponding CPUID leaves early. Modify
> x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V
> specific
Patchew URL:
https://patchew.org/QEMU/20200918204714.27276-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200918204714.27276-1-ehabk...@redhat.com
Subject: [PULL 00/17] QOM queue, 2020-09-18
Huh. I thought we ignored the environment LDFLAGS/CFLAGS from much
earlier than 5.0 and was about to ask if honouring it was a change
introduced with the Meson switch! My (not necessarily very considered)
opinion is that generally it's better not to honour the environment
CFLAGS and LDFLAGS
On Fri, Sep 04, 2020 at 04:54:21PM +0200, Vitaly Kuznetsov wrote:
> We have all the required data in X86CPU already and as we are about to
> split hyperv_handle_properties() into hyperv_expand_features()/
> hyperv_fill_cpuids() we can remove the blind copy. The functional change
> is that QEMU
On Fri, Sep 04, 2020 at 04:54:18PM +0200, Vitaly Kuznetsov wrote:
> As a preparation to expanding Hyper-V CPU features early, add
> reserved FEAT_HYPERV_ECX CPUID leaf.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> target/i386/cpu.c | 5 +
> target/i386/cpu.h | 1 +
> target/i386/kvm.c | 2 ++
On Fri, Sep 04, 2020 at 04:54:16PM +0200, Vitaly Kuznetsov wrote:
> There was a typo which went unnoticed.
>
> Fixes: e48ddcc6ce13 ("i386/kvm: implement 'hv-passthrough' mode")
> Signed-off-by: Vitaly Kuznetsov
Similar fix had been submitted at:
On Fri, Sep 04, 2020 at 04:54:13PM +0200, Vitaly Kuznetsov wrote:
> As a preparation to expanding Hyper-V CPU features early, move
> hyperv_interface_id initialization to x86_cpu_realizefn().
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> target/i386/cpu.c | 6 ++
> target/i386/cpu.h | 1 +
>
> -Original Message-
> From: Klaus Jensen
> Sent: Friday, September 18, 2020 5:30 PM
> To: Dmitry Fomichev
> Cc: Keith Busch ; Klaus Jensen
> ; Kevin Wolf ; Philippe
> Mathieu-Daudé ; Maxim Levitsky
> ; Fam Zheng ; Niklas Cassel
> ; Damien Le Moal ;
> qemu-bl...@nongnu.org;
On Tue, Aug 20, 2019 at 06:30:30PM +0800, Zhenyu Wang wrote:
> Fix typo to use correct edx value for FEATURE_HYPERV_EDX when
> hyperv_passthrough is enabled.
>
> Signed-off-by: Zhenyu Wang
CCing other maintainers (please use ./scripts/get_maintainer.pl
to make sure maintainers don't miss
On Fri, Sep 04, 2020 at 04:54:15PM +0200, Vitaly Kuznetsov wrote:
> As a preparation to expanding Hyper-V CPU features early, move
> hyperv_limits initialization to x86_cpu_realizefn().
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> target/i386/cpu.c | 5 +
> target/i386/cpu.h | 1 +
>
On Fri, Sep 04, 2020 at 04:54:14PM +0200, Vitaly Kuznetsov wrote:
> As a preparation to expanding Hyper-V CPU features early, move
> hyperv_version_id initialization to x86_cpu_realizefn().
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> target/i386/cpu.c | 4
> target/i386/cpu.h | 1 +
>
On Fri, Sep 04, 2020 at 04:54:12PM +0200, Vitaly Kuznetsov wrote:
> As a preparation to expanding Hyper-V CPU features early, move
> hyperv_vendor_id initialization to x86_cpu_realizefn().
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> target/i386/cpu.c | 15 ++-
> target/i386/cpu.h |
Chiming in here as the user who initially suggested Arch use this:
--extra-ldflags="$LDFLAGS"
qemu-5.0.0 introduced a breaking change whereby LDFLAGS from the
environment were ignored. For Arch, this resulted in exclusion of `--as-
needed' from the link, which naturally caused dependency chaos.
> -Original Message-
> From: Klaus Jensen
> Sent: Friday, September 18, 2020 5:20 PM
> To: Dmitry Fomichev
> Cc: Keith Busch ; Klaus Jensen
> ; Kevin Wolf ; Philippe
> Mathieu-Daudé ; Maxim Levitsky
> ; Fam Zheng ; Niklas Cassel
> ; Damien Le Moal ;
> qemu-bl...@nongnu.org;
On Sep 14 07:14, Dmitry Fomichev wrote:
> The emulation code has been changed to advertise NVM Command Set when
> "zoned" device property is not set (default) and Zoned Namespace
> Command Set otherwise.
>
> Handlers for three new NVMe commands introduced in Zoned Namespace
> Command Set
On Mon, Sep 14, 2020 at 09:37:20AM +0200, Igor Mammedov wrote:
> On Fri, 11 Sep 2020 11:04:47 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Fri, Sep 11, 2020 at 09:32:02AM -0400, Igor Mammedov wrote:
> > > it's was deprecated since 3.1
> > >
> > > Support for invalid topologies is removed, the
From: Marc-André Lureau
Add an alias target "update-dtb" to recompile the device-tree "sources"
to the "blob" format.
Signed-off-by: Marc-André Lureau
---
pc-bios/Makefile| 19 ---
pc-bios/meson.build | 12
2 files changed, 12 insertions(+), 19 deletions(-)
Hi Luwei Kang,
I was looking for info on intel-pt and just saw this series, and
it was never reviewed or merged (sorry for missing it!). Is this
still the approach we want to follow for intel-pt?
I'm CCing Jiri Denemark because this might be relevant for a
libvirt issue related to intel-pt we
From: Marc-André Lureau
Hi,
Here is a series of patches to convert the remaining Makefile in pc-bios/ to
meson. I have done various tests to check that the resulting binaries are
working as expected, but I didn't cover it all, and I am not sure the test su=
ite
covers them all either.
Please
On 9/18/20 4:38 PM, Eduardo Habkost wrote:
> On Mon, Aug 31, 2020 at 01:43:07PM -0500, Babu Moger wrote:
>> apic_id contains all the information required to build
>> CPUID_8000_001E. core_id and node_id is already part of
>> apic_id generated by x86_topo_ids_from_apicid.
>>
>> Also remove the
One of the goals of having less boilerplate on QOM declarations
is to avoid human error. Requiring an extra argument that is
never used is an opportunity for mistakes.
Remove the unused argument from OBJECT_DECLARE_TYPE and
OBJECT_DECLARE_SIMPLE_TYPE.
Coccinelle patch used to convert all users
From: Richard Henderson
Fix alignment of CPURISCVState.vreg.
Signed-off-by: Richard Henderson
Reviewed-by: Alistair Francis
Message-Id: <20200916004638.2444147-6-richard.hender...@linaro.org>
Signed-off-by: Eduardo Habkost
---
target/riscv/cpu.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Richard Henderson
It turns out that some hosts have a default malloc alignment less
than that required for vectors.
We assume that, with compiler annotation on CPUArchState, that we
can properly align the vector portion of the guest state. Fix the
alignment of the allocation by using
The following changes since commit 053a4177817db307ec854356e95b5b350800a216:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918'
into staging (2020-09-18 16:34:26 +0100)
are available in the Git repository at:
git://github.com/ehabkost/qemu.git tags/machine-next-pull
Some of the enum constant names conflict with a QOM type check
macro (SIFIVE_E_PRCI). This needs to be addressed to allow us to
transform the QOM type check macros into functions generated by
OBJECT_DECLARE_TYPE().
Rename all the constants to SIFIVE_E_DEV_*, to avoid conflicts.
Signed-off-by:
From: Klaus Jensen
The emulated nvme device (hw/block/nvme.c) is currently using an
internal Intel device id.
Prepare to change that by allocating a device id under the 1b36 (Red
Hat, Inc.) vendor id.
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
Acked-by: Gerd Hoffmann
Reviewed-by:
On Mon, Aug 31, 2020 at 01:43:07PM -0500, Babu Moger wrote:
> apic_id contains all the information required to build
> CPUID_8000_001E. core_id and node_id is already part of
> apic_id generated by x86_topo_ids_from_apicid.
>
> Also remove the restriction on number bits on core_id and
> node_id.
Hi All,
virtiofsd default thread pool size is 64. To me it feels that in most of
the cases thread pool size 1 performs better than thread pool size 64.
I ran virtiofs-tests.
https://github.com/rhvgoyal/virtiofs-tests
And here are the comparision results. To me it seems that by default
we
From: Klaus Jensen
This adds support for multiple namespaces by introducing a new 'nvme-ns'
device model. The nvme device creates a bus named from the device name
('id'). The nvme-ns devices then connect to this and registers
themselves with the nvme device.
This changes how an nvme device is
On Sep 14 07:14, Dmitry Fomichev wrote:
> From: Niklas Cassel
>
> Namespace Types introduce a new command set, "I/O Command Sets",
> that allows the host to retrieve the command sets associated with
> a namespace. Introduce support for the command set and enable
> detection for the NVM Command
On Tue, Sep 15, 2020 at 10:48:49PM +0200, Klaus Jensen wrote:
> On Sep 15 20:44, Dmitry Fomichev wrote:
> >
> > It is not necessary to change it in NST patch since result64 field is not
> > used
> > in that patch. But if you insist, I can move it to NST patch :)
>
> You are right of course, but
From: Klaus Jensen
Prepare to support inactive namespaces.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index d2e211c7cbc2..f533eec55c5c 100644
---
On Mon, Sep 14, 2020 at 02:56:17PM +0100, Daniel P. Berrangé wrote:
> When debugging QEMU it is often useful to put a breakpoint on the
> error_setg_internal method impl.
>
> Unfortunately the object_property_add / object_class_property_add
> methods call object_property_find /
From: Marc-André Lureau
Use a fake subproject: this is a simple workaround to avoid the
incompatible flags (such as gprof) that are set globally for the rest of
QEMU.
Signed-off-by: Marc-André Lureau
---
configure| 2 -
pc-bios/meson.build | 4 +
From: Marc-André Lureau
Checking for linker emulation is a bit tricky with meson, since it
actually tries to compile a file with a main().
I didn't bother to port the Darwin or SunOS check, as they are
quite old, and not very specific to the compiler version/issue, so they
might be outdated.
From: Marc-André Lureau
Clang doesn't support specifying segment prefixes before the
instruction, and requires specifying them on the address.
Signed-off-by: Marc-André Lureau
---
pc-bios/optionrom/kvmvapic.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Klaus Jensen
For now, support the Data Block, Segment and Last Segment descriptor
types.
See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)").
Signed-off-by: Klaus Jensen
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
---
include/block/nvme.h | 6 +-
hw/block/nvme.c
I'm not documenting every single change in the codeconverter
script because most of that code will be deleted once we finish
the QOM code conversion. This patch updates the script to the
latest version that was used to perform changes in the QOM code.
Signed-off-by: Eduardo Habkost
Message-Id:
From: Markus Armbruster
object_property_get_enum() is the only object_property_FOO() that is
documented to return an undefined value on error. It does no such
thing, actually: it returns 0 on some errors, and -1 on others.
Needlessly complicated. Always return -1 on error, and adjust the
This converts existing DECLARE_OBJ_CHECKERS usage to
OBJECT_DECLARE_TYPE when possible.
$ ./scripts/codeconverter/converter.py -i \
--pattern=AddObjectDeclareType $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
Reviewed-by: Cédric Le Goater
Acked-by: Paul Durrant
Message-Id:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
Makefile | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index cb23123606..4728fcf1bd 100644
--- a/Makefile
+++ b/Makefile
@@ -135,13 +135,12 @@ Makefile: ;
configure: ;
.PHONY: all
Some of the enum constant names conflict with the QOM type check
macros (SIFIVE_U_OTP, SIFIVE_U_PRCI). This needs to be addressed
to allow us to transform the QOM type check macros into functions
generated by OBJECT_DECLARE_TYPE().
Rename all the constants to SIFIVE_U_DEV_*, to avoid conflicts.
The requirement to specify the parent class type makes the macro
harder to use and easy to misuse (silent bugs can be introduced
if the wrong struct type is specified).
Simplify the macro by just not declaring any class struct,
allowing us to remove the class_size field from the TypeInfo
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
Makefile | 9 -
configure | 3 ---
2 files changed, 12 deletions(-)
diff --git a/Makefile b/Makefile
index 7c60b9dcb8..cb23123606 100644
--- a/Makefile
+++ b/Makefile
@@ -180,16 +180,7 @@ slirp/all: .git-submodule-status
From: Klaus Jensen
Add the symbolic command name to the pci_nvme_{io,admin}_cmd and
pci_nvme_rw trace events.
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.h | 28
hw/block/nvme.c | 8 +---
From: Richard Henderson
Fix alignment of CPUARMState.vfp.zregs.
Signed-off-by: Richard Henderson
Message-Id: <20200916004638.2444147-4-richard.hender...@linaro.org>
Signed-off-by: Eduardo Habkost
---
target/arm/cpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/arm/cpu.c
From: Richard Henderson
Fix alignment of CPUPPCState.vsr.
Signed-off-by: Richard Henderson
Acked-by: David Gibson
Message-Id: <20200916004638.2444147-5-richard.hender...@linaro.org>
Signed-off-by: Eduardo Habkost
---
target/ppc/translate_init.c.inc | 1 +
1 file changed, 1 insertion(+)
From: Klaus Jensen
There are two reasons for changing this:
1. The nvme device currently uses an internal Intel device id.
2. Since commits "nvme: fix write zeroes offset and count" and "nvme:
support multiple namespaces" the controller device no longer has
the quirks that the
object_class_dynamic_cast_assert() is not used by
INTERFACE_CHECK, remove misleading mention of that function in
the documentation.
Message-Id: <20200916193101.511600-2-ehabk...@redhat.com>
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 2 +-
1 file changed, 1 insertion(+), 1
From: Richard Henderson
Fix alignment of CPUS390XState.vregs.
Signed-off-by: Richard Henderson
Message-Id: <20200916004638.2444147-7-richard.hender...@linaro.org>
Signed-off-by: Eduardo Habkost
---
target/s390x/cpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/s390x/cpu.c
Some typedefs and macros are defined after the type check macros.
This makes it difficult to automatically replace their
definitions with OBJECT_DECLARE_TYPE.
Patch generated using:
$ ./scripts/codeconverter/converter.py -i \
--pattern=QOMStructTypedefSplit $(git grep -l '' -- '*.[ch]')
From: Klaus Jensen
Handling DMA errors gracefully is required for the device to pass the
block/011 test ("disable PCI device while doing I/O") in the blktests
suite.
With this patch the device passes the test by retrying "critical"
transfers (posting of completion entries and processing of
From: Markus Armbruster
object_property_get_bool()'s contract claims it returns NULL on error.
Pasto; it returns false.
object_property_get_int()'s contract claims it returns "negative". It
actually returns -1. All the other object_property_get_FOO()
contracts specify the exact error value,
$ ./scripts/codeconverter/converter.py -i \
--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
Reviewed-by: Daniel P. Berrangé
Message-Id: <20200831210740.126168-12-ehabk...@redhat.com>
Signed-off-by: Eduardo Habkost
---
hw/intc/sifive_plic.h |
From: Klaus Jensen
This pulls block layer aio submission/completion to common functions.
For completions, additionally map an AIO error to the Unrecovered Read
and Write Fault status codes.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 25
hw/block/nvme.c | 136
From: Klaus Jensen
Some devices might want to know the return value of dma_memory_rw, so
pass it along instead of ignoring it.
There are no existing users of the return value, so this patch should be
safe.
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael
From: Gollu Appalanaidu
This adds support for SGL descriptor type 0x1 (bit bucket descriptor).
See the NVM Express v1.3d specification, Section 4.4 ("Scatter Gather
List (SGL)").
Signed-off-by: Gollu Appalanaidu
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 33
From: Klaus Jensen
The raw NLB field is a 16 bit value, so use le16_to_cpu instead of
le32_to_cpu and cast to uint32_t before incrementing the value to not
wrap around.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Klaus Jensen
Add the nvme_l2b helper and use it for converting NLB and SLBA to byte
counts and offsets.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 6 ++
hw/block/nvme.c | 12
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/block/nvme.h
From: Klaus Jensen
Since the controller has only supported PRPs so far it has not been
required to check the ending address (addr + len - 1) of the CMB access
for validity since it has been guaranteed to be in range of the CMB.
This changes when the controller adds support for SGLs (next
From: Klaus Jensen
This is the next round of my patches for the nvme device.
This includes a bit of cleanup and two new features:
* support for scatter/gather lists
* multiple namespaces support through a new nvme-ns device
Finally, the series wraps up with changing the PCI vendor and
From: Klaus Jensen
Make the default request status NVME_SUCCESS so only error status codes
have to be set.
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/block/nvme.c
From: Klaus Jensen
Fix a typo in the sq doorbell trace event.
Signed-off-by: Klaus Jensen
---
hw/block/trace-events | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/trace-events b/hw/block/trace-events
index ec94c56a4165..8ff4cbc4932c 100644
---
From: Klaus Jensen
Style fixes.
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 78c3ac80fd4c..10568cbf8761 100644
---
From: Klaus Jensen
Move common error handling to a label.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 8ffe407ef658..78c3ac80fd4c 100644
--- a/hw/block/nvme.c
+++
On Friday, August 28, 2020, Ahmed Karaman
wrote:
> - Apply pylint and flake8 formatting rules to the script.
> - Use 'tempfile' instead of '/tmp' for creating temporary files.
>
> Signed-off-by: Ahmed Karaman
> ---
Hello, folks.
This series seems forgotten. Can some of you perhaps take a
From: Philippe Mathieu-Daudé
Drop superfluous parenthesis around VMPortReadFunc typedef
(added in d67f679d99, missed to remove when moved in e595112985).
Suggested-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200505142836.16903-1-phi...@redhat.com>
Signed-off-by:
From: Babu Moger
Remove all the hardcoded values and replace with generalized
fields.
Signed-off-by: Babu Moger
Reviewed-by: Igor Mammedov
Reviewed-by: Pankaj Gupta
Acked-by: Michael S. Tsirkin
Message-Id: <159897584649.30750.3939159632943292252.st...@naples-babu.amd.com>
Signed-off-by:
From: Vitaly Kuznetsov
Hyper-V TLFS prior to version 6.0 had a mistake in it: special value
'0x' for CPUID 0x4004.EBX was called 'never to retry', this
looked weird (like why it's not '0' which supposedly have the same effect?)
but nobody raised the question. In TLFS version 6.0 the
The following changes since commit 053a4177817db307ec854356e95b5b350800a216:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918'
into staging (2020-09-18 16:34:26 +0100)
are available in the Git repository at:
git://github.com/ehabkost/qemu.git tags/x86-next-pull
From: Babu Moger
apic_id contains all the information required to build
CPUID_8000_001E. core_id and node_id is already part of
apic_id generated by x86_topo_ids_from_apicid.
Also remove the restriction on number bits on core_id and
node_id.
Remove all the hardcoded values and replace with
Armbian servers are not very reliable and confused the GitLab CI
users a few times this month (path updated, archives moved, and
now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
error). Time to disable these tests.
Users can still use the artifacts from the cache (or manually add
17.07.2020 16:45, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
Refactor common path to use BlockCopyCallState pointer as parameter, to
prepare it for use in asynchronous block-copy (at least, we'll need to
run block-copy in a coroutine, passing the whole parameters as
The following changes since commit 053a4177817db307ec854356e95b5b350800a216:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' i=
nto staging (2020-09-18 16:34:26 +0100)
are available in the Git repository at:
https://gitlab.com/philmd/qemu.git tags/acceptance-next
On 9/18/20 7:55 AM, Markus Armbruster wrote:
Ignorant question: why does this come after PATCH 13 "qapi/common.py:
add notational type hints", but before all the other patches adding type
hints?
John Snow writes:
Fix two very minor issues, and then establish a mypy type-checking
baseline.
On 9/18/20 5:00 AM, Dr. David Alan Gilbert wrote:
* Tom Lendacky (thomas.lenda...@amd.com) wrote:
On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote:
* Tom Lendacky (thomas.lenda...@amd.com) wrote:
From: Tom Lendacky
This patch series provides support for launching an SEV-ES guest.
Secure
On 9/16/20 7:19 AM, Claudio Fontana wrote:
> Motivation and higher level steps:
>
> https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html
>
> Current state is mostly all reviewed, but I include here a few resolutions
> of rebasing conflicts and a new patch to use current_machine
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 10
target/arm/sve.decode | 9
target/arm/sve_helper.c| 99 ++
target/arm/translate-sve.c | 17 +++
4 files changed, 135 insertions(+)
diff --git
You have to unset LDFLAGS, or remove -pie. Specifying --extra-ldflags is
useless because Meson already obeys the LDFLAGS environment variable.
Il ven 18 set 2020, 19:11 Frederic Bezies <1896...@bugs.launchpad.net> ha
scritto:
> And qemu log build using make -V=1.
>
> Hope it helps.
>
> **
From: Stephen Long
Implements both vectored and indexed FMLALB, FMLALT, FMLSLB, FMLSLT
Signed-off-by: Stephen Long
Message-Id: <20200504171240.11220-1-stepl...@quicinc.com>
[rth: Rearrange to use float16_to_float32_by_bits.]
Signed-off-by: Richard Henderson
---
target/arm/helper.h|
From: Stephen Long
Implements SQSHL/UQSHL, SRSHR/URSHR, and SQSHLU
Signed-off-by: Stephen Long
Message-Id: <20200430194159.24064-1-stepl...@quicinc.com>
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 33 +
target/arm/sve.decode | 5
From: Stephen Long
Signed-off-by: Stephen Long
Message-Id: <20200428174332.17162-4-stepl...@quicinc.com>
[rth: Use do_frint_mode, which avoids a specific runtime helper.]
Signed-off-by: Richard Henderson
---
target/arm/sve.decode | 2 ++
target/arm/translate-sve.c | 49
1 - 100 of 525 matches
Mail list logo
