Re: [PATCH] migration/rdma: Fix cm_event used before being initialized

2021-05-13 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > A segmentation fault was triggered when i try to abort a postcopy + rdma > migration. > > since rdma_ack_cm_event releases a uninitialized cm_event in thise case. > > like below: > 2496 ret = rdma_get_cm_event(rdma->channel, _event); > 2497

Re: [PATCH v6 72/82] target/arm: Implement SVE2 bitwise shift immediate

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:17, Richard Henderson wrote: > > From: Stephen Long > > Implements SQSHL/UQSHL, SRSHR/URSHR, and SQSHLU > > Signed-off-by: Stephen Long > Message-Id: <20200430194159.24064-1-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h|

Re: [PATCH] hw/avr/atmega.c: use the avr51 cpu for atmega1280

2021-05-13 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial@ On 5/5/21 4:00 PM, Joaquin de Andres wrote: > On 5/5/21 3:33 PM, Fred Konrad wrote: >> >> >> Le 4/30/21 à 12:27 PM, Joaquin de Andres a écrit : >>> On 4/28/21 9:17 PM, Philippe Mathieu-Daudé wrote: Cc'ing Joaquín. On 4/28/21 9:15 PM, Frederic Konrad wrote:

Re: [PATCH] hw/avr/atmega.c: use the avr51 cpu for atmega1280

2021-05-13 Thread Laurent Vivier
Le 13/05/2021 à 19:04, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial@ Applied to my trivial-patches branch. Thanks, Laurent > On 5/5/21 4:00 PM, Joaquin de Andres wrote: >> On 5/5/21 3:33 PM, Fred Konrad wrote: >>> >>> >>> Le 4/30/21 à 12:27 PM, Joaquin de Andres a écrit : On

Re: GICv3 for MTTCG

2021-05-13 Thread Shashi Mallela
Hi Andrey, To clarify, the patch series > https://lists.gnu.org/archive/html/qemu-arm/2021-04/msg00944.html > "GICv3 LPI and ITS feature implementation" > is applicable for virt machine 6.1 onwards,i.e ITS TCG functionality is not available for version 6.0 that is being tried here. Thanks

Re: [PATCH v6 73/82] target/arm: Implement SVE2 fp multiply-add long

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:19, Richard Henderson wrote: > > From: Stephen Long > > Implements both vectored and indexed FMLALB, FMLALT, FMLSLB, FMLSLT > > Signed-off-by: Stephen Long > Message-Id: <20200504171240.11220-1-stepl...@quicinc.com> > [rth: Rearrange to use float16_to_float32_by_bits.]

Re: [PATCH v4 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-05-13 Thread Ziqiao Kong
Ping. On 5/7/21, Ziqiao Kong wrote: > Changes since v3: > - Split the long patches to series to make review easier. > - Fix the coding style problems in v3. > > Changes since v2: > - Change the sequence of fpcs, fpds, fpip and fpdp in CPUX86State. > - Use stl instead of stw in do_fstenv. >

Re: [PATCH v6 74/82] target/arm: Implement aarch64 SUDOT, USDOT

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:12, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 5 + > target/arm/translate-a64.c | 25 + > 2 files changed, 30 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] target/sh4: Return error if CPUClass::get_phys_page_debug() fails

2021-05-13 Thread Laurent Vivier
Le 05/05/2021 à 18:10, Philippe Mathieu-Daudé a écrit : > If the get_physical_address() call fails, the SH4 get_phys_page_debug() > handler returns an uninitialized address. Instead return -1, which > correspond to "no page found" (see cpu_get_phys_page_debug() doc > string). > > This fixes a

Re: [PATCH] target/sh4: Return error if CPUClass::get_phys_page_debug() fails

2021-05-13 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial@ On 5/5/21 6:10 PM, Philippe Mathieu-Daudé wrote: > If the get_physical_address() call fails, the SH4 get_phys_page_debug() > handler returns an uninitialized address. Instead return -1, which > correspond to "no page found" (see cpu_get_phys_page_debug() doc > string). > >

Re: [PATCH 10/10] default-configs/devices: Clarify ARM_COMPATIBLE_SEMIHOSTING is required

2021-05-13 Thread Philippe Mathieu-Daudé
Cc Alex & Thomas On 5/13/21 6:38 PM, Philippe Mathieu-Daudé wrote: > ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets. > Move the variable assignment out of the block documented with > "Uncomment the following lines to disable these optional devices". > > Signed-off-by: Philippe

Re: [PATCH v6 70/82] target/arm: Implement SVE2 LD1RO

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:31, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/sve.decode | 4 ++ > target/arm/translate-sve.c | 97 ++ > 2 files changed, 101 insertions(+) > > diff --git a/target/arm/sve.decode

Re: [PATCH v6 71/82] target/arm: Implement 128-bit ZIP, UZP, TRN

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:23, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 3 ++ > target/arm/sve.decode | 8 ++ > target/arm/sve_helper.c| 29 +-- > target/arm/translate-sve.c | 58

Re: [PATCH] migration/rdma: Fix cm_event used before being initialized

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 6:13 PM, Philippe Mathieu-Daudé wrote: > On 5/13/21 1:37 PM, Li Zhijian wrote: >> A segmentation fault was triggered when i try to abort a postcopy + rdma >> migration. >> >> since rdma_ack_cm_event releases a uninitialized cm_event in thise case. >> >> like below: >> 2496 ret =

[PATCH 08/10] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC

2021-05-13 Thread Philippe Mathieu-Daudé
Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338

[PATCH 10/10] default-configs/devices: Clarify ARM_COMPATIBLE_SEMIHOSTING is required

2021-05-13 Thread Philippe Mathieu-Daudé
ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets. Move the variable assignment out of the block documented with "Uncomment the following lines to disable these optional devices". Signed-off-by: Philippe Mathieu-Daudé --- default-configs/devices/arm-softmmu.mak | 4 +++-

Re: [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS

2021-05-13 Thread Hao Wu
Reviewed-by: Hao Wu On Thu, May 13, 2021 at 9:39 AM Philippe Mathieu-Daudé wrote: > The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but > this isn't advertised with proper Kconfig symbol, leading > to an early build failure when building NPCM7XX machines > standalone: > > The following

[PATCH 07/10] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines

2021-05-13 Thread Philippe Mathieu-Daudé
Only the Virt and Spike machines use NUMA. Add a RISCV_NUMA Kconfig symbol and only have these machines select it. Adapt the Meson file to only built it if required. Signed-off-by: Philippe Mathieu-Daudé --- hw/riscv/Kconfig | 5 + hw/riscv/meson.build | 2 +- 2 files changed, 6

[PATCH 09/10] default-configs/devices: Remove implicy SEMIHOSTING config

2021-05-13 Thread Philippe Mathieu-Daudé
Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol which selects SEMIHOSTING. Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING, they don't need to select SEMIHOSTING manually. Simplify. Signed-off-by:

[PATCH 06/10] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL

2021-05-13 Thread Philippe Mathieu-Daudé
Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") added a dependency on the SERIAL model, but forgot to add the Kconfig selector. Fix that to solve when built the MICROCHIP_PFSOC machine stand-alone: /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in

Re: [PATCH 00/14] vl: compound properties for machines and accelerators

2021-05-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210513162901.1310239-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210513162901.1310239-1-pbonz...@redhat.com Subject: [PATCH 00/14] vl: compound

[PATCH 04/10] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board

2021-05-13 Thread Philippe Mathieu-Daudé
In commit c4f00daa5b3 ("imx25-pdk: create ds1338 for qtest inside the test") we removed the DS1338 device from the i.MX25 machine but forgot to remove it in the machine Kconfig definitions, do it now. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 1 - 1 file changed, 1 deletion(-)

[PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV

2021-05-13 Thread Philippe Mathieu-Daudé
The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491:ide_create_drive(d->bus + bus[i], unit[i], hd_table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive)

[PATCH 05/10] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25

2021-05-13 Thread Philippe Mathieu-Daudé
Commit bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") added a dependency on the TYPE_IMX_USDHC model, but forgot to add the Kconfig selector. Fix that to solve when built stand-alone: $ qemu-system-arm -M imx25-pdk qemu-system-arm: missing object type 'imx-usdhc' Aborted (core

[PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS

2021-05-13 Thread Philippe Mathieu-Daudé
The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but this isn't advertised with proper Kconfig symbol, leading to an early build failure when building NPCM7XX machines standalone: The following clauses were found for AT24C config AT24C depends on I2C select AT24C if NPCM7XX

[PATCH 01/10] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-13 Thread Philippe Mathieu-Daudé
Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may not be started without it. This is the case with the NVDIMM device (it is certainly possible to start a machine without NVDIMM) , so use the 'imply' weak reverse

[PATCH 00/10] hw: Various Kconfig fixes

2021-05-13 Thread Philippe Mathieu-Daudé
Various Kconfig fixes when building stand-alone machine binaries. FYI I'm looking at a way to test this automatically, by generating all the configurations using: https://docs.gitlab.com/ee/ci/parent_child_pipelines.html#dynamic-child-pipel= ines This way we could run this on release candidate

Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 6:03 PM, Laurent Vivier wrote: > Le 11/05/2021 à 05:29, Philippe Mathieu-Daudé a écrit : >> Hi Laurent, >> >> I addressed your comments from v1, and this series is >> now reviewed. Can it get merged via your qemu-trivial tree? > > Yes, but next time cc: trivial to be sure ;) OK, thank

[PATCH 12/14] machine: pass QAPI struct to mc->smp_parse

2021-05-13 Thread Paolo Bonzini
As part of converting -smp to a property with a QAPI type, define the struct and use it to do the actual parsing. machine_smp_parse takes care of doing the QemuOpts->QAPI conversion by hand, for now. Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 33 +++--

[PATCH 06/14] vl: switch -M parsing to keyval

2021-05-13 Thread Paolo Bonzini
Switch from QemuOpts to keyval. This enables the introduction of non-scalar machine properties, and JSON syntax in the future. For JSON syntax to be supported right now, we would have to consider what would happen if string-based dictionaries (produced by -M key=val) were to be merged with

Re: GICv3 for MTTCG

2021-05-13 Thread Andrey Shinkevich
Dear colleagues, Thank you all very much for your responses. Let me reply with one message. I configured QEMU for AARCH64 guest: $ ./configure --target-list=aarch64-softmmu When I start QEMU with GICv3 on an x86 host: qemu-system-aarch64 -machine virt-6.0,accel=tcg,gic-version=3 QEMU reports

[PATCH 14/14] machine: add smp compound property

2021-05-13 Thread Paolo Bonzini
Make -smp syntactic sugar for a compound property "-machine smp.{cores,threads,cpu,...}". machine_smp_parse is replaced by the setter for the property. numa-test will now cover the new syntax, while other tests still use -smp. Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 108

Re: [PATCH 07/11] target/ppc: added KVM fallback to fpscr manipulation

2021-05-13 Thread Bruno Piazera Larsen
On 12/05/2021 15:20, Richard Henderson wrote: On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 104a308abb..a8a720eb48 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2947,3 +2947,17 @@ bool

[PATCH 11/14] machine: add error propagation to mc->smp_parse

2021-05-13 Thread Paolo Bonzini
Clean up the smp_parse functions to use Error** instead of exiting. Signed-off-by: Paolo Bonzini --- hw/core/machine.c| 34 +++--- hw/i386/pc.c | 28 ++-- include/hw/boards.h | 2 +- include/hw/i386/pc.h | 2 -- 4 files changed,

[PATCH 10/14] machine: move common smp_parse code to caller

2021-05-13 Thread Paolo Bonzini
Most of smp_parse and pc_smp_parse is guarded by an "if (opts)" conditional, and the rest is common to both function. Move the conditional and the common code to the caller, machine_smp_parse. Move the replay_add_blocker call after all errors are checked for. Signed-off-by: Paolo Bonzini ---

[PATCH 02/14] qemu-config: parse configuration files to a QDict

2021-05-13 Thread Paolo Bonzini
Change the parser to put the values into a QDict and pass them to a callback. qemu_config_parse's QemuOpts creation is itself turned into a callback function. This is useful for -readconfig to support keyval-based options; getting a QDict from the parser removes a roundtrip from QDict to

[PATCH 04/14] qom: export more functions for use with non-UserCreatable objects

2021-05-13 Thread Paolo Bonzini
Machines and accelerators are not user-creatable but they are going to share similar command-line parsing machinery. Export functions that will be used with -machine and -accel in softmmu/vl.c. Signed-off-by: Paolo Bonzini --- include/qom/object.h| 23

[PATCH 09/14] machine: move dies from X86MachineState to CpuTopology

2021-05-13 Thread Paolo Bonzini
In order to make SMP configuration a Machine property, we need a getter as well as a setter. To simplify the implementation put everything that the getter needs in the CpuTopology struct. Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 1 + hw/i386/pc.c | 4 +---

[PATCH 08/14] vl: switch -accel parsing to keyval

2021-05-13 Thread Paolo Bonzini
Switch from QemuOpts to keyval. This enables compound options for accelerators as well as passing the options as JSON, using for example -accel '{"accel":"kvm"}'. Signed-off-by: Paolo Bonzini --- accel/accel-softmmu.c | 6 ++ include/qemu/accel.h | 1 + softmmu/vl.c | 156

[PATCH 13/14] machine: reject -smp dies!=1 for non-PC machines

2021-05-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 7daca0b86a..55e878fc3e 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -745,6 +745,10 @@ static void smp_parse(MachineState *ms,

[PATCH 05/14] keyval: introduce keyval_parse_into

2021-05-13 Thread Paolo Bonzini
Allow parsing multiple keyval sequences into the same dictionary. This will be used to simplify the parsing of the -M command line option, which is currently a .merge_lists = true QemuOpts group. Signed-off-by: Paolo Bonzini --- include/qemu/option.h | 2 ++ util/keyval.c | 43

[PATCH 01/14] remove -writeconfig

2021-05-13 Thread Paolo Bonzini
Like -set and -readconfig, it would not really be too hard to extend -writeconfig to parsing mechanisms other than QemuOpts. However, the uses of -writeconfig are substantially more limited, as it is generally easier to write the configuration by hand in the first place. In addition, -writeconfig

[PATCH 07/14] qemu-option: remove now-dead code

2021-05-13 Thread Paolo Bonzini
-M was the sole user of qemu_opts_set and qemu_opts_set_defaults, remove them and the arguments that they used. Signed-off-by: Paolo Bonzini --- include/qemu/option.h | 3 --- tests/unit/test-qemu-opts.c | 35 - util/qemu-option.c | 51

[PATCH 03/14] vl: plumb keyval-based options into -set and -readconfig

2021-05-13 Thread Paolo Bonzini
Let -set and -readconfig support parsing command line options with keyval either QemuOpts. The underlying data structure is QDict for command line options that opt into keyval-based parsing. This patch introduces a keyval_merge function that merges two keyval-produced (or keyval-like) QDicts.

[PATCH 00/14] vl: compound properties for machines and accelerators

2021-05-13 Thread Paolo Bonzini
This series converts -M and -accel to keyval parsing, so that they can use compound properties. The series also converts -smp to a compound property. This is also a preparatory work for SGX support, which would like to use an array-type machine property. Patch 1 removes -writeconfig, which

[PATCH] tests/qtest/fuzz: Fix build failure

2021-05-13 Thread Philippe Mathieu-Daudé
On Fedora 32, using clang (version 10.0.1-3.fc32) we get: tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function 'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration] qemu_init(result.we_wordc, result.we_wordv, NULL); ^ qemu_init() is declared in

Re: [PULL 0/2] pflash patches for 2021-05-11

2021-05-13 Thread Peter Maydell
On Tue, 11 May 2021 at 17:20, Philippe Mathieu-Daudé wrote: > > The following changes since commit f9a576a818044133f8564e0d243ebd97df0b3280: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210506' into staging > (2021-05-11 13:03:44 +0100) > > are available in

Re: [PATCH] multi-process: Avoid logical AND of mutually exclusive tests

2021-05-13 Thread Laurent Vivier
Le 08/05/2021 à 06:34, Thomas Huth a écrit : > On 07/05/2021 17.53, Jagannathan Raman wrote: >> Fixes an if statement that performs a logical AND of mutually exclusive >> tests >> >> Reported-by: Thomas Huth > > I just spotted the bug ticket on Launchpad :-) So whoever picks this patch > up,

Re: [PATCH] hw/pci-host: Do not build gpex-acpi.c if GPEX is not selected

2021-05-13 Thread Laurent Vivier
Le 11/05/2021 à 05:36, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial (patch reviewed). Applied to my trivial-patches branch. Thanks, Laurent > On 4/25/21 8:21 PM, Philippe Mathieu-Daudé wrote: >> Since its introduction in commit 5b85eabe68f ("acpi: add >> acpi_dsdt_add_gpex") we build

Re: [PATCH] migration/rdma: Fix cm_event used before being initialized

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 1:37 PM, Li Zhijian wrote: > A segmentation fault was triggered when i try to abort a postcopy + rdma > migration. > > since rdma_ack_cm_event releases a uninitialized cm_event in thise case. > > like below: > 2496 ret = rdma_get_cm_event(rdma->channel, _event); > 2497 if

Re: [PATCH-for-6.0] hw/mem/meson: Fix linking sparse-mem device with fuzzer

2021-05-13 Thread Laurent Vivier
Le 11/05/2021 à 05:48, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial (patch reviewed). Applied to my trivial-patches branch. Thanks, Laurent > > On 4/12/21 1:07 PM, Philippe Mathieu-Daudé wrote: >> ping? >> >> On 4/6/21 4:39 PM, Alexander Bulekov wrote: >>> On 210406 1539, Philippe

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-13 Thread Marc-André Lureau
Hi On Thu, May 13, 2021 at 5:45 PM Peter Maydell wrote: > On Wed, 12 May 2021 at 20:31, Peter Maydell > wrote: > > I should be able to deal with this by installing the rtd theme on > > the host. I'll retry merging the pullreq. > > On try 2 I find that some of my machines warn: > > Program

Re: [PATCH] cutils: fix memory leak in get_relocated_path()

2021-05-13 Thread Laurent Vivier
Le 11/05/2021 à 07:38, Markus Armbruster a écrit : > Stefano Garzarella writes: > >> Ping :-) >> >> Should I resend for 6.1? > > I'm cc'ing qemu-trivial. > > For good measure: > Reviewed-by: Markus Armbruster > > Applied to my trivial-patches branch. Thanks, Laurent

Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

2021-05-13 Thread Laurent Vivier
Le 11/05/2021 à 05:29, Philippe Mathieu-Daudé a écrit : > Hi Laurent, > > I addressed your comments from v1, and this series is > now reviewed. Can it get merged via your qemu-trivial tree? Yes, but next time cc: trivial to be sure ;) Applied to my trivial-patches branch. Thanks, Laurent > On

Re: [PATCH] multi-process: Avoid logical AND of mutually exclusive tests

2021-05-13 Thread Stefan Hajnoczi
On Fri, May 07, 2021 at 11:53:23AM -0400, Jagannathan Raman wrote: > Fixes an if statement that performs a logical AND of mutually exclusive > tests > > Reported-by: Thomas Huth > Signed-off-by: Jagannathan Raman > --- > hw/remote/mpqemu-link.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH trivial] hw/gpio/aspeed: spelling fix (addtional)

2021-05-13 Thread Laurent Vivier
Le 08/05/2021 à 11:36, Michael Tokarev a écrit : > Fixes: 36d737ee82b2972167e97901c5271ba3f904ba71 > Signed-off-by: Michael Tokarev > --- > hw/gpio/aspeed_gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c > index

Re: [PATCH trivial] qapi: spelling fix (addtional)

2021-05-13 Thread Laurent Vivier
Le 10/05/2021 à 12:02, Kevin Wolf a écrit : > Am 08.05.2021 um 11:33 hat Michael Tokarev geschrieben: >> Fixes: 3d0d3c30ae3a259bff176f85a3efa2d0816695af >> Signed-off-by: Michael Tokarev > > Reviewed-by: Kevin Wolf > > I'm also applying this to my block branch because this is how the patch >

Re: [PATCH] virtiofsd: Fix check of chown()'s return value

2021-05-13 Thread Laurent Vivier
Le 10/05/2021 à 16:23, Greg Kurz a écrit : > On Mon, 10 May 2021 15:16:23 +0100 > "Dr. David Alan Gilbert" wrote: > >> * Greg Kurz (gr...@kaod.org) wrote: >>> Otherwise you always get this warning when using --socket-group=users >>> >>> vhost socket failed to set group to users (100) >>> >>>

Re: [PATCH 0/3] hw/virtio: Constify VirtIOFeature

2021-05-13 Thread Laurent Vivier
Le 11/05/2021 à 12:41, Philippe Mathieu-Daudé a écrit : > Trivial patches to keep VirtIOFeature arrays read-only > (better safe than sorry). > > Philippe Mathieu-Daudé (3): > hw/virtio: Pass virtio_feature_get_config_size() a const argument > virtio-blk: Constify VirtIOFeature feature_sizes[]

Re: [PATCH] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-05-13 Thread Laurent Vivier
Le 12/05/2021 à 09:07, Philippe Mathieu-Daudé a écrit : > Simplify the tpm_emulator_ctrlcmd() handler by replacing a pair of > qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD > macro. > > Reviewed-by: Stefan Berger > Reviewed-by: Christophe de Dinechin > Signed-off-by:

Re: [RFC PATCH 4/5] hw/ppc/fdt: Drop dependency on libfdt

2021-05-13 Thread Paolo Bonzini
On 13/05/21 05:46, David Gibson wrote: The patch makes sense in general. The file is only needed for pseries and powernv, not for e.g. e500 which does need fdt. Yes, agreed. I would get rid of FDT_PPC completely. First, before patch 3, you can move fdt.c to PSERIES and POWERNV (it's too

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

2021-05-13 Thread Catalin Marinas
On Thu, May 13, 2021 at 11:57:39AM +0100, Steven Price wrote: > On 12/05/2021 18:45, Catalin Marinas wrote: > > On Wed, May 12, 2021 at 04:46:48PM +0100, Steven Price wrote: > >> On 10/05/2021 19:35, Catalin Marinas wrote: > On Thu, May 06, 2021 at 05:15:25PM +0100, Steven Price wrote: >

Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-13 Thread Paolo Bonzini
On 12/05/21 09:02, David Gibson wrote: But with "imply" you could end up with a PSERIES that does not have NVDIMM when also using --without-default-devices, couldn't you? Why don't you use "select" instead of "imply" ? Oh.. clearly I misunderstand the semantics of "imply". If we don't need

Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection

2021-05-13 Thread Stefan Hajnoczi
On Mon, May 10, 2021 at 10:38:05PM +0800, Jiachen Zhang wrote: > Hi all, > > > We are going to develop the v2 patch for virtio-fs crash reconnection. As > suggested by Marc-André and Stefan, except for the inflight I/O tracking > log area, all the other internal statuses of virtiofsd will be

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

2021-05-13 Thread Catalin Marinas
On Thu, May 13, 2021 at 11:57:39AM +0100, Steven Price wrote: > On 12/05/2021 18:45, Catalin Marinas wrote: > > On Wed, May 12, 2021 at 04:46:48PM +0100, Steven Price wrote: > >> On Thu, Apr 29, 2021 at 05:06:41PM +0100, Steven Price wrote: > >>> Given the changes to set_pte_at() which

Re: [PATCH] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-05-13 Thread Philippe Mathieu-Daudé
Hi Stefan, On 5/13/21 4:08 PM, Stefan Berger wrote: > On 5/12/21 3:07 AM, Philippe Mathieu-Daudé wrote: >> Simplify the tpm_emulator_ctrlcmd() handler by replacing a pair of >> qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD >> macro. >> >> Reviewed-by: Stefan Berger >>

QEMU SMMUv3 stage 2 translation

2021-05-13 Thread Shashi Mallela
Hi, Since the current SMMUv3 qemu implementation only supports stage 1 translation,wanted to understand if the implementation could be extended to stage 2 translation support and if yes what is the overall scope involved.This is required for sbsa-ref platforms. Thanks Shashi

Re: [RFC PATCH] block/io.c: Flush parent for quorum in generic code

2021-05-13 Thread Stefan Hajnoczi
On Wed, May 12, 2021 at 03:49:57PM +0800, Zhang Chen wrote: > Fix the issue from this patch: > [PATCH] block: Flush all children in generic code > From 883833e29cb800b4d92b5d4736252f4004885191 > > Quorum driver do not have the primary child. > It will caused guest block flush issue when use

Re: [PATCH v6 69/82] target/arm: Share table of sve load functions

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:36, Richard Henderson wrote: > > The table used by do_ldrq is a subset of the table used by do_ld_zpa; > we can share them by passing dtype instead of msz to do_ldrq. > > Signed-off-by: Richard Henderson > --- > @@ -5512,14 +5514,8 @@ static bool

Re: [PATCH v6 68/82] target/arm: Implement SVE2 FLOGB

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:24, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200430191405.21641-1-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > v2: Fixed esz index and c++ comments > v3: Fixed denormal arithmetic and raise

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Reorg everything using QEMU_GENERIC and multiple inclusion to > reduce the amount of code duplication between the formats. > > The use of QEMU_GENERIC means that we need to use pointers instead > of structures, which means that even the smaller float formats > need

Re: [PATCH 58/72] tests/fp/fp-test: Reverse order of floatx80 precision tests

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Many qemu softfloat will check floatx80_rounding_precision > even when berkeley testfloat will not. So begin with > floatx80_precision_x, so that's the one we use > when !FUNC_EFF_ROUNDINGPRECISION. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [PATCH 46/72] softfloat: Move rount_to_int_and_pack to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Rename to parts$N_float_to_sint. Reimplement > float128_to_int{32,64}{_round_to_zero} with FloatParts128. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 45/72] softfloat: Move round_to_int to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > At the same time, convert to pointers, split out > parts$N_round_to_int_normal, define a macro for > parts_round_to_int using QEMU_GENERIC. > > This necessarily meant some rearrangement to the > rount_to_{,u}int_and_pack routines, so go ahead and > convert to

Re: making a qdev bus available from a (non-qtree?) device

2021-05-13 Thread Stefan Hajnoczi
On Wed, May 12, 2021 at 02:02:50PM +0200, Markus Armbruster wrote: > Klaus Jensen writes: > > I can then call `qdev_set_parent_bus()` and set the parent bus to the > > bus creates in the nvme-subsys device. This solves the problem since > > the namespaces are not "garbage collected" when the nvme

Re: [PATCH v6 67/82] target/arm: Implement SVE2 FCVTXNT, FCVTX

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:23, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200428174332.17162-4-stepl...@quicinc.com> > [rth: Use do_frint_mode, which avoids a specific runtime helper.] > Signed-off-by: Richard Henderson > --- >

Re: [PATCH] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-05-13 Thread Stefan Berger
On 5/12/21 3:07 AM, Philippe Mathieu-Daudé wrote: Simplify the tpm_emulator_ctrlcmd() handler by replacing a pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD macro. Reviewed-by: Stefan Berger Reviewed-by: Christophe de Dinechin Signed-off-by: Philippe

Re: [PATCH 09/11] include/exec: added functions to the stubs in exec-all.h

2021-05-13 Thread Lucas Mateus Martins Araujo e Castro
On 12/05/2021 15:34, Richard Henderson wrote: On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: From: "Lucas Mateus Castro (alqotel)" Added tlb_set_page and tlb_set_page_with_attrs to the stubbed functions in exec-all.h  as it is needed in some functions when compiling without TCG

[Bug 1915531] Re: qemu-user child process hangs when forking due to glib allocation

2021-05-13 Thread Daniel Berrange
As a quick win, we ought to call setenv("G_SLICE", "always-malloc", 1) during startup to avoid the specific scenario you hit. A more general solution is likely to be non-trivial. glib is such a fundamental part of QEMU that is is hard to avoid its usage. The async-signal safety issues only

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > On 5/12/21 2:23 PM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> Reorg everything using QEMU_GENERIC and multiple inclusion to >>> reduce the amount of code duplication between the formats. >>> >>> The use of QEMU_GENERIC means that we need to use

Re: [PATCH v6 66/82] target/arm: Implement SVE2 FCVTLT

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:33, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200428174332.17162-3-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 5 + > target/arm/sve.decode | 2 ++ >

Re: [PATCH v6 65/82] target/arm: Implement SVE2 FCVTNT

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:20, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200428174332.17162-2-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 5 + > target/arm/sve.decode | 4 >

Re: [PATCH v6 64/82] target/arm: Implement SVE2 TBL, TBX

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:26, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200428144352.9275-1-stepl...@quicinc.com> > [rth: rearrange the macros a little and rebase] > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 10

Re: [PATCH v6 63/82] target/arm: Implement SVE2 crypto constructive binary operations

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:11, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 5 + > target/arm/sve.decode | 4 > target/arm/translate-sve.c | 16 > 3 files changed, 25 insertions(+) Reviewed-by: Peter Maydell

[Bug 1915531] Re: qemu-user child process hangs when forking due to glib allocation

2021-05-13 Thread Valentin David
Re-opened as https://gitlab.com/qemu-project/qemu/-/issues/285 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #285 https://gitlab.com/qemu-project/qemu/-/issues/285 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-13 Thread Peter Maydell
On Wed, 12 May 2021 at 20:31, Peter Maydell wrote: > I should be able to deal with this by installing the rtd theme on > the host. I'll retry merging the pullreq. On try 2 I find that some of my machines warn: Program qemu-keymap found: NO Program sphinx-build found: YES

Re: [vhost-user] Expectations around reconnection

2021-05-13 Thread Stefan Hajnoczi
On Thu, May 13, 2021 at 11:43:25AM +0200, Philippe Mathieu-Daudé wrote: > Cc'ing few developers > > On 5/11/21 3:33 PM, Boeuf, Sebastien wrote: > > Hi All, > > > > In the context of vhost-user, I was wondering how a reconnection should > > be handled from the VMM perspective? > > > > In

Re: RFC: Memory region accesses where .valid.min_access_size < .impl.min_access_size

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 3:00 PM, Jonathan Cameron wrote: > On Thu, 13 May 2021 14:36:27 +0200 > Philippe Mathieu-Daudé wrote: > >> On 5/13/21 2:23 PM, Peter Maydell wrote: >>> On Thu, 13 May 2021 at 12:49, Jonathan Cameron >>> wrote: My initial suggestion was to fix this by adding the relatively

Re: [PULL 00/17] migration queue

2021-05-13 Thread Peter Maydell
On Thu, 13 May 2021 at 14:17, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Fails to build on the gitlab cross build job: > > https://gitlab.com/qemu-project/qemu/-/jobs/1258047823 > > > > ../migration/ram.c: In function 'host_page_from_ram_block_offset':

[Bug 1912107] Re: Option to constrain linux-user exec() to emulated CPU only

2021-05-13 Thread Mingye Wang
** Changed in: qemu Status: Incomplete => Confirmed ** Changed in: qemu Status: Confirmed => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1912107 Title: Option to constrain

Re: [PULL 00/17] migration queue

2021-05-13 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 11 May 2021 at 16:08, Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > The following changes since commit e4f3ede95ce813d5705c65e1c0e1c80c70739ebb: > > > > Merge remote-tracking branch > >

Re: RFC: Memory region accesses where .valid.min_access_size < .impl.min_access_size

2021-05-13 Thread Jonathan Cameron
On Thu, 13 May 2021 14:36:27 +0200 Philippe Mathieu-Daudé wrote: > On 5/13/21 2:23 PM, Peter Maydell wrote: > > On Thu, 13 May 2021 at 12:49, Jonathan Cameron > > wrote: > >> My initial suggestion was to fix this by adding the relatively > >> simple code needed in the driver to implement byte

Re: [PATCH v6 60/82] target/arm: Implement SVE mixed sign dot product

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:00, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h| 2 ++ > target/arm/sve.decode | 4 > target/arm/translate-sve.c | 16 > target/arm/vec_helper.c| 18 ++ > 4 files

Re: [PATCH v6 62/82] target/arm: Implement SVE2 crypto destructive binary operations

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:27, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 5 + > target/arm/sve.decode | 7 +++ > target/arm/translate-sve.c | 38 ++ > 3 files changed, 50 insertions(+)

Re: [PATCH v6 61/82] target/arm: Implement SVE2 crypto unary operations

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:17, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/sve.decode | 6 ++ > target/arm/translate-sve.c | 11 +++ > 2 files changed, 17 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [RFC PATCH 10/11] target/ppc: created tcg-stub.c file

2021-05-13 Thread Bruno Piazera Larsen
On 13/05/2021 00:59, David Gibson wrote: On Wed, May 12, 2021 at 11:08:12AM -0300, Bruno Larsen (billionai) wrote: Created a file with stubs needed to compile disabling TCG. We're not sure about keeping the softmmu stubs in this file. if there is a better place to put them, please let us

Re: [PATCH v6 59/82] target/arm: Implement SVE mixed sign dot product (indexed)

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:04, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 5 +++ > target/arm/helper.h| 4 +++ > target/arm/sve.decode | 4 +++ > target/arm/translate-sve.c | 16 + > target/arm/vec_helper.c| 68

Re: [PATCH v6 58/82] target/arm: Implement SVE2 saturating multiply high (indexed)

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:11, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h| 14 ++ > target/arm/sve.decode | 8 > target/arm/translate-sve.c | 8 > target/arm/vec_helper.c| 88 ++ >

Re: [PATCH v6 56/82] target/arm: Implement SVE2 saturating multiply (indexed)

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:24, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 5 + > target/arm/sve.decode | 12 > target/arm/sve_helper.c| 20 > target/arm/translate-sve.c | 19

[Bug 1898011] Re: mmap MAP_NORESERVE of 2^42 bytes consumes 16Gb of actual RAM

2021-05-13 Thread Richard Henderson
Still an issue, yes. ** Changed in: qemu Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1898011 Title: mmap MAP_NORESERVE of 2^42 bytes consumes 16Gb of

<    1   2   3   4   >