Re: [PATCH v4 02/14] doc: update AMD SEV to include Live migration flow

2021-08-04 Thread Dov Murik
On 04/08/2021 14:53, Ashish Kalra wrote: > From: Brijesh Singh > > Signed-off-by: Brijesh Singh > Signed-off-by: Ashish Kalra > --- > docs/amd-memory-encryption.txt | 46 +- > 1 file changed, 45 insertions(+), 1 deletion(-) > > diff --git a/docs/amd-memory-e

Re: [RFC PATCH] vhost-vdpa: Do not send empty IOTLB update batches

2021-08-04 Thread Jason Wang
On Wed, Aug 4, 2021 at 10:44 PM Eugenio Pérez wrote: > > With the introduction of the batch hinting, meaningless batches can be > created with no IOTLB updates if the memory region was skipped by > vhost_vdpa_listener_skipped_section. This is the case of host notifiers > memory regions, but others

Re: [PATCH v2 4/4] hw/riscv: virt: Add optional ACLINT support to virt machine

2021-08-04 Thread Alistair Francis
On Thu, Aug 5, 2021 at 4:09 PM Alistair Francis wrote: > > On Sat, Jul 24, 2021 at 10:27 PM Anup Patel wrote: > > > > We extend virt machine to emulate ACLINT devices only when "aclint=on" > > parameter is passed along with machine name in QEMU command-line. > > > > Signed-off-by: Anup Patel > >

Re: [PATCH v2 4/4] hw/riscv: virt: Add optional ACLINT support to virt machine

2021-08-04 Thread Alistair Francis
On Sat, Jul 24, 2021 at 10:27 PM Anup Patel wrote: > > We extend virt machine to emulate ACLINT devices only when "aclint=on" > parameter is passed along with machine name in QEMU command-line. > > Signed-off-by: Anup Patel > --- > hw/riscv/virt.c | 113 ++

Re: [PATCH v2 3/4] hw/riscv: virt: Re-factor FDT generation

2021-08-04 Thread Alistair Francis
On Sat, Jul 24, 2021 at 10:25 PM Anup Patel wrote: > > We re-factor and break the FDT generation into smaller functions > so that it is easier to modify FDT generation for different > configurations of virt machine. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alistair > --- >

Re: [RFC PATCH 00/13] Support UXL field in mstatus

2021-08-04 Thread Alistair Francis
On Thu, Aug 5, 2021 at 12:55 PM LIU Zhiwei wrote: > > This patch set implements UXL field in mstatus register. Programmer can change > UXLEN by writting to this field. So that you can run a 32 bit program > on a 64 bit CPU. Awesome! Do you have any steps for building a rootFS to test this? Alist

Re: [RFC PATCH 01/13] target/riscv: Add UXL to tb flags

2021-08-04 Thread Alistair Francis
On Thu, Aug 5, 2021 at 12:55 PM LIU Zhiwei wrote: > > For 32-bit applications run on 64-bit cpu, it may share some code > with other 64-bit applictions. Thus we should distinguish the translated > cache of the share code with a tb flag. > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis

Re: [PATCH 0/3] Disable vhost device IOTLB is IOMMU is not enabled

2021-08-04 Thread Peter Xu
On Thu, Aug 05, 2021 at 09:46:10AM +0800, Jason Wang wrote: > > For the long term we may need to think about making device creation to be > > not > > ordered by user cmdline input but still has a priority specified in the code > > itself. > > I fully agree. I'll see whether I can work on that in

[RFC PATCH 12/13] target/riscv: Support UXL32 for RVB

2021-08-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvb.c.inc | 47 +++-- target/riscv/translate.c| 8 + 2 files changed, 45 insertions(+), 10 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c

[RFC PATCH 11/13] target/riscv: Fix srow

2021-08-04 Thread LIU Zhiwei
Always fill MSB 32 bits with 1s in source register before calling gen_sro. Otherwise it may not only shift in 1s. Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvb.c.inc | 4 ++-- target/riscv/translate.c| 7 +++ 2 files changed, 9 insertions(+), 2 deletions(-)

[RFC PATCH 10/13] target/riscv: Support UXL32 for float instructions

2021-08-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvd.c.inc | 4 ++-- target/riscv/insn_trans/trans_rvf.c.inc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvd.c.inc b/target/riscv/insn_trans/trans_rvd.c.inc index 9bb15fdc12..fb0

[RFC PATCH 13/13] target/riscv: Changing the width of U-mode CSR

2021-08-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 42 +- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 9a4ed18ac5..dc9807c0ff 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -297,7

[RFC PATCH 09/13] target/riscv: Support UXL32 for atomic instructions

2021-08-04 Thread LIU Zhiwei
Only load or store 32 bits data for atomic instructions when UXL32. Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rva.c.inc | 36 - 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/target/riscv/insn_trans/trans_rva.c.inc b/target/riscv/insn_tr

[RFC PATCH 08/13] target/riscv: Support UXL32 for vector instructions

2021-08-04 Thread LIU Zhiwei
For integer operations, the scalar can be taken from the scalar x register specified by rs1. If XLEN --- target/riscv/cpu.h | 3 ++ target/riscv/insn_trans/trans_rvv.c.inc | 44 target/riscv/vector_helper.c| 54 + 3 fil

[RFC PATCH 07/13] target/riscv: Support UXL32 for RVM

2021-08-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvm.c.inc | 24 --- target/riscv/translate.c| 56 +++-- 2 files changed, 62 insertions(+), 18 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvm.c.inc b/target/riscv/insn_trans/trans

[RFC PATCH 05/13] target/riscv: Support UXL32 for shift instruction

2021-08-04 Thread LIU Zhiwei
Reuse 32-bit right shift instructions. Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvi.c.inc | 12 1 file changed, 12 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvi.c.inc b/target/riscv/insn_trans/trans_rvi.c.inc index 6201c07795..698a28731e 100644 --

[RFC PATCH 06/13] target/riscv: Fix div instructions

2021-08-04 Thread LIU Zhiwei
Don't overwrite global source register after https://lists.gnu.org/archive/html/qemu-riscv/2021-07/msg00058.html. Signed-off-by: LIU Zhiwei --- target/riscv/translate.c | 46 +++- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/target/riscv/tra

[RFC PATCH 03/13] target/riscv: Support UXL32 on 64-bit cpu for load/store

2021-08-04 Thread LIU Zhiwei
Get the LSB 32 bits and zero-extend as the base address. Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvi.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvi.c.inc b/target/riscv/insn_trans/trans_rvi.c.inc index ea41d1de

[RFC PATCH 04/13] target/riscv: Support UXL32 for slit/sltiu

2021-08-04 Thread LIU Zhiwei
For slitu, the imm is sign-extend before unsigned compare. Thus we should only use the LSB 32 bits of the imm for UXL32. Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvi.c.inc | 8 ++--- target/riscv/translate.c| 44 + 2 files changed, 48 i

[RFC PATCH 02/13] target/riscv: Support UXL32 for branch instructions

2021-08-04 Thread LIU Zhiwei
When UXLEN is 32 on 64-bit CPU, only use the LSB 32 bits of source registers and sign-extend or zero-extend it according to different operations. Signed-off-by: LIU Zhiwei --- target/riscv/insn_trans/trans_rvi.c.inc | 38 - target/riscv/translate.c| 22 +++

[RFC PATCH 01/13] target/riscv: Add UXL to tb flags

2021-08-04 Thread LIU Zhiwei
For 32-bit applications run on 64-bit cpu, it may share some code with other 64-bit applictions. Thus we should distinguish the translated cache of the share code with a tb flag. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h | 15 +++ target/riscv/translate.c | 3 +++ 2 fil

[RFC PATCH 00/13] Support UXL field in mstatus

2021-08-04 Thread LIU Zhiwei
This patch set implements UXL field in mstatus register. Programmer can change UXLEN by writting to this field. So that you can run a 32 bit program on a 64 bit CPU. This patch set depends on one patch set by Richard Henderson https://lists.gnu.org/archive/html/qemu-riscv/2021-07/msg00059.html. L

Re: [PATCH 0/3] Disable vhost device IOTLB is IOMMU is not enabled

2021-08-04 Thread Jason Wang
在 2021/8/5 上午12:08, Peter Xu 写道: On Wed, Aug 04, 2021 at 11:48:00AM +0800, Jason Wang wrote: Hi: We currently try to enable device IOTLB when iommu_platform is set. This may lead unnecessary trasnsactions between qemu and vhost when vIOMMU is not used (which is the typical case for the encryp

Re: [PATCH v2 0/2] s390x: improve subchannel error handling (vfio)

2021-08-04 Thread Matthew Rosato
On 8/4/21 8:30 PM, Jared Rossi wrote: I've exercised the error paths and it appears to all work correctly. On 7/19/21 11:09 AM, Jared Rossi wrote: I will take a look and see if I can exercise the error paths. Regards, Jared Rossi Thanks Jared! So, with that I'd suggest a Tested-by: Jared

[PATCH 2/2] docs/sphinx: change default role to "any"

2021-08-04 Thread John Snow
This interprets single-backtick syntax in all of our Sphinx docs as a cross-reference to *something*, including Python symbols. If it doesn't resolve, or resolves to too more than one thing, Sphinx will emit a warning and the build will fail. Signed-off-by: John Snow --- docs/conf.py | 3 +++ 1

[PATCH 1/2] docs: remove non-reference uses of single backticks

2021-08-04 Thread John Snow
The single backtick markup in ReST is the "default role". Currently, Sphinx's default role is called "content". Sphinx suggests you can use the "Any" role instead to turn any single-backtick enclosed item into a cross-reference. This is useful for things like autodoc for Python docstrings, where i

[PATCH 0/2] docs/sphinx: change default `role` to "any"

2021-08-04 Thread John Snow
The first patch that I've been carrying for quite a while got real small recently ... Apologies to Peter Maydell who re-did all that work. John Snow (2): docs: remove non-reference uses of single backticks docs/sphinx: change default role to "any" docs/conf.py | 3

Re: [PATCH RFC 1/1] accel/tcg: Clear PAGE_WRITE before translation

2021-08-04 Thread Richard Henderson
On 8/4/21 12:46 PM, Ilya Leoshkevich wrote: translate_insn() implementations fetch instruction bytes piecemeal, which can cause qemu-user to generate inconsistent translations if another thread modifies them concurrently [1]. Fix by marking translation block pages non-writable earlier. [1] http

Re: [PATCH v2 0/2] s390x: improve subchannel error handling (vfio)

2021-08-04 Thread Jared Rossi
I've exercised the error paths and it appears to all work correctly. On 7/19/21 11:09 AM, Jared Rossi wrote: I will take a look and see if I can exercise the error paths. Regards, Jared Rossi On 7/19/21 10:16 AM, Matthew Rosato wrote: On 7/5/21 12:39 PM, Cornelia Huck wrote: This is a follo

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-04 Thread John Snow
On Wed, Aug 4, 2021 at 5:00 PM Eduardo Habkost wrote: > On Wed, Aug 04, 2021 at 09:42:24PM +0100, Peter Maydell wrote: > > On Wed, 4 Aug 2021 at 21:31, Eduardo Habkost > wrote: > > > > > > On Mon, Aug 02, 2021 at 01:14:57PM +0100, Peter Maydell wrote: > > > > On Thu, 29 Jul 2021 at 19:00, Eduard

Re: [PATCH v2 0/6] qapi: static typing conversion, pt5b

2021-08-04 Thread John Snow
On 5/20/21 6:57 PM, John Snow wrote: This is part five (b), and focuses on QAPIDoc in parser.py. gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b Requirements: - Python 3.6+ - mypy >= 0.770 - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) Every commit should pass with:

Re: [PATCH v3 4/7] migration/ram: Handle RAMBlocks with a RamDiscardManager on the migration source

2021-08-04 Thread Peter Xu
On Fri, Jul 30, 2021 at 10:52:46AM +0200, David Hildenbrand wrote: > We don't want to migrate memory that corresponds to discarded ranges as > managed by a RamDiscardManager responsible for the mapped memory region of > the RAMBlock. The content of these pages is essentially stale and > without any

Re: [PATCH v3 3/7] migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*()

2021-08-04 Thread Peter Xu
On Fri, Jul 30, 2021 at 10:52:45AM +0200, David Hildenbrand wrote: > The parameter is unused, let's drop it. > > Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v3 6/7] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-08-04 Thread Peter Xu
On Fri, Jul 30, 2021 at 10:52:48AM +0200, David Hildenbrand wrote: > Currently, when someone (i.e., the VM) accesses discarded parts inside a > RAMBlock with a RamDiscardManager managing the corresponding mapped memory > region, postcopy will request migration of the corresponding page from the > s

Re: [PATCH 2/2] target/hppa: Clean up DisasCond

2021-08-04 Thread Richard Henderson
On 8/4/21 11:01 AM, Philippe Mathieu-Daudé wrote: On 7/8/21 10:58 PM, Richard Henderson wrote: The a0_is_n flag is redundant with comparing a0 to cpu_psw_n. Preferably split as 2 patches: Reviewed-by: Philippe Mathieu-Daudé Already in mainline for 3 weeks. r~

[PATCH v8] tests/tcg/s390x: Test SIGILL and SIGSEGV handling

2021-08-04 Thread Ilya Leoshkevich
Verify that s390x-specific uc_mcontext.psw.addr is reported correctly and that signal handling interacts properly with debugging. Signed-off-by: Ilya Leoshkevich --- v7: https://lists.nongnu.org/archive/html/qemu-devel/2021-08/msg00463.html v7 -> v8: Another rebase needed due to the conflict wit

[PATCH RFC 1/1] accel/tcg: Clear PAGE_WRITE before translation

2021-08-04 Thread Ilya Leoshkevich
translate_insn() implementations fetch instruction bytes piecemeal, which can cause qemu-user to generate inconsistent translations if another thread modifies them concurrently [1]. Fix by marking translation block pages non-writable earlier. [1] https://lists.nongnu.org/archive/html/qemu-devel/2

[PATCH RFC 0/1] accel/tcg: Clear PAGE_WRITE before translation

2021-08-04 Thread Ilya Leoshkevich
Hello, As discussed on IRC, here is the tentative fix for concurrent code patching. It helps with the x86_64 .NET app on s390x and survives check-tcg. Bug report: https://lists.nongnu.org/archive/html/qemu-devel/2021-08/msg00644.html IRC log: iii: my initial thoughts are there is a ra

Re: [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature

2021-08-04 Thread Eric DeVolder
On 7/27/21 7:52 AM, Igor Mammedov wrote: On Mon, 26 Jul 2021 15:01:05 -0500 Eric DeVolder wrote: On 7/26/21 5:42 AM, Igor Mammedov wrote: On Wed, 21 Jul 2021 11:07:40 -0500 Eric DeVolder wrote: On 7/20/21 7:17 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:16 -0400 Eric DeVolder

Re: [PATCH for 6.1] tests: filter out TLS distinguished name in certificate checks

2021-08-04 Thread Eric Blake
On Wed, Aug 04, 2021 at 07:03:30PM +0100, Daniel P. Berrangé wrote: > The version of GNUTLS in Fedora 34 has changed the order in which encodes > fields when generating new TLS certificates. This in turn changes the > order seen when querying the distinguished name. This ultimately breaks > the exp

Re: [PATCH-for-6.2 v4] memory: Directly dispatch alias accesses on origin memory region

2021-08-04 Thread Philippe Mathieu-Daudé
Let's be honest, this won't make 6.1, so update the subject to 6.2, as some scan the list for "6.2" in the subject when 6.1 release is out. On 7/7/21 3:58 PM, Philippe Mathieu-Daudé wrote: > Peter Xu already reviewed, but Cc'ing Peter Maydell too due to > his last comment on v3: > https://www.mail

Re: [PATCH] include/qemu: Use builtins for bswap

2021-08-04 Thread Philippe Mathieu-Daudé
On 7/8/21 8:17 PM, Richard Henderson wrote: > All supported compilers have builtins for this. > Drop all of the complicated system detection stuff. > > Signed-off-by: Richard Henderson > --- > meson.build | 6 - > include/qemu/bswap.h | 53 +++---

Re: [PATCH 2/4] target/alpha: Use dest_sink for HW_RET temporary

2021-08-04 Thread Philippe Mathieu-Daudé
On 7/8/21 8:25 PM, Richard Henderson wrote: > This temp is automatically freed, just like ctx->lit. > But we're about to remove ctx->lit, so use sink instead. > > Signed-off-by: Richard Henderson > --- > target/alpha/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-b

Re: [PATCH 2/2] target/hppa: Clean up DisasCond

2021-08-04 Thread Philippe Mathieu-Daudé
On 7/8/21 10:58 PM, Richard Henderson wrote: > The a0_is_n flag is redundant with comparing a0 to cpu_psw_n. Preferably split as 2 patches: Reviewed-by: Philippe Mathieu-Daudé > The a1_is_0 flag can be removed by initializing a1 to $0, > which also means that cond_prep can be removed entirely. >

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-04 Thread Eduardo Habkost
On Wed, Aug 04, 2021 at 09:42:24PM +0100, Peter Maydell wrote: > On Wed, 4 Aug 2021 at 21:31, Eduardo Habkost wrote: > > > > On Mon, Aug 02, 2021 at 01:14:57PM +0100, Peter Maydell wrote: > > > On Thu, 29 Jul 2021 at 19:00, Eduardo Habkost wrote: > > > > diff --git a/docs/devel/qom.rst b/docs/dev

Re: [PATCH 5/9] tests/acceptance: Use image_expand() in test_arm_orangepi_uboot_netbsd9

2021-08-04 Thread Philippe Mathieu-Daudé
Hi Niek, On 6/23/21 8:00 PM, Philippe Mathieu-Daudé wrote: > The NetBSD OrangePi image must be at least 2GiB, not less. > Expand the SD card image to this size before using it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 9 +++-- > 1 file chang

Re: [PATCH V5 00/25] Live Update [restart] : fork mode?

2021-08-04 Thread Steven Sistare
On 7/30/2021 9:10 AM, Zheng Chuan wrote: > Hi, Steve > I have saw the discussion about the fork+exec mode below: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg815956.html > > And I am still very curious and I want to discuss about the possibility to > support both fork+exec and exec in

Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-08-04 Thread Peter Maydell
On Wed, 4 Aug 2021 at 21:40, Eduardo Habkost wrote: > > On Mon, Aug 02, 2021 at 01:19:14PM +0100, Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 19:01, Eduardo Habkost wrote: > > > > > > When there's no specific class struct used for a QOM type, we > > > normally don't define a typedef for it.

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-04 Thread Peter Maydell
On Wed, 4 Aug 2021 at 21:31, Eduardo Habkost wrote: > > On Mon, Aug 02, 2021 at 01:14:57PM +0100, Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 19:00, Eduardo Habkost wrote: > > > diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst > > > index e5fe3597cd8..9c1be5d7fc2 100644 > > > --- a/docs/d

Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-08-04 Thread Eduardo Habkost
On Mon, Aug 02, 2021 at 01:19:14PM +0100, Peter Maydell wrote: > On Thu, 29 Jul 2021 at 19:01, Eduardo Habkost wrote: > > > > When there's no specific class struct used for a QOM type, we > > normally don't define a typedef for it. Remove the typedef from > > the minimal example, as it is unneces

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-04 Thread Eduardo Habkost
On Mon, Aug 02, 2021 at 01:14:57PM +0100, Peter Maydell wrote: > On Thu, 29 Jul 2021 at 19:00, Eduardo Habkost wrote: > > > > Replace leftover of GTK-Doc #name syntax with `name`, and use > > default-role:: any, so we can add references to other functions, > > types, and macros. > > > > There are

Re: [PATCH V5 03/25] cpr: QMP interfaces for reboot

2021-08-04 Thread Steven Sistare
On 8/4/2021 11:48 AM, Eric Blake wrote: > On Wed, Jul 07, 2021 at 10:20:12AM -0700, Steve Sistare wrote: >> cprsave calls cprsave(). Syntax: >> { 'enum': 'CprMode', 'data': [ 'reboot' ] } >> { 'command': 'cprsave', 'data': { 'file': 'str', 'mode': 'CprMode' } } >> >> cprload calls cprload().

Re: [PATCH V5 12/25] cpr: QMP interfaces for restart

2021-08-04 Thread Steven Sistare
On 8/4/2021 12:00 PM, Eric Blake wrote: > On Wed, Jul 07, 2021 at 10:20:21AM -0700, Steve Sistare wrote: >> cprexec calls cprexec(). Syntax: >> { 'command': 'cprexec', 'data': { 'argv': [ 'str' ] } } >> >> Add the restart mode: >> { 'enum': 'CprMode', 'data': [ 'reboot', 'restart' ] } >> >> Si

Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-08-04 Thread Lukas Straub
On Wed, 4 Aug 2021 15:39:55 -0400 Peter Xu wrote: > On Wed, Aug 04, 2021 at 09:26:32PM +0200, Lukas Straub wrote: > > Unconditionally unregister yank function in multifd_load_cleanup(). > > If it is not unregistered here, it will leak and cause a crash > > in yank_unregister_instance(). > > Cu

Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-08-04 Thread Peter Xu
On Wed, Aug 04, 2021 at 09:26:32PM +0200, Lukas Straub wrote: > Unconditionally unregister yank function in multifd_load_cleanup(). > If it is not unregistered here, it will leak and cause a crash > in yank_unregister_instance(). Curious whether there was a crash somewhere that you hit? > Now if

[PATCH] multifd: Implement yank for multifd send side

2021-08-04 Thread Lukas Straub
When introducing yank functionality in the migration code I forgot to cover the multifd send side. Signed-off-by: Lukas Straub --- @Leonardo Could you check if this fixes your issue? migration/multifd.c | 6 +- migration/multifd.h | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) di

[PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-08-04 Thread Lukas Straub
Unconditionally unregister yank function in multifd_load_cleanup(). If it is not unregistered here, it will leak and cause a crash in yank_unregister_instance(). Now if the ioc is still in use afterwards, it will only lead to qemu not being able to recover from a hang related to that ioc. After ch

Re: [ANNOUNCE] QEMU 6.1.0-rc2 is now available

2021-08-04 Thread Michael Roth
Quoting Mark Cave-Ayland (2021-08-04 13:37:43) > On 04/08/2021 19:05, Michael Roth wrote: > > > Hello, > > > > On behalf of the QEMU Team, I'd like to announce the availability of the > > third release candidate for the QEMU 6.1 release. This release is meant > > for testing purposes and should

Re: [PATCH v3 25/25] python/aqmp: add AsyncProtocol unit tests

2021-08-04 Thread John Snow
On Tue, Aug 3, 2021 at 2:31 PM John Snow wrote: > This tests most of protocol.py -- From a hacked up Coverage.py run, it's > at about 86%. There's a few error cases that aren't very well tested > yet, they're hard to induce artificially so far. I'm working on it. > > Signed-off-by: John Snow > -

Re: [ANNOUNCE] QEMU 6.1.0-rc2 is now available

2021-08-04 Thread Mark Cave-Ayland
On 04/08/2021 19:05, Michael Roth wrote: Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 6.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-pro

[ANNOUNCE] QEMU 6.1.0-rc2 is now available

2021-08-04 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 6.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-6.1.0-rc2.tar.xz http://downl

[PATCH for 6.1] tests: filter out TLS distinguished name in certificate checks

2021-08-04 Thread Daniel P . Berrangé
The version of GNUTLS in Fedora 34 has changed the order in which encodes fields when generating new TLS certificates. This in turn changes the order seen when querying the distinguished name. This ultimately breaks the expected output in the NBD TLS iotests. We don't need to be comparing the exact

Re: [PATCH v7 25/33] iotests.py: VM: add own __enter__ method

2021-08-04 Thread John Snow
On Wed, Aug 4, 2021 at 5:39 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > In superclass __enter__ method is defined with return value type hint > 'QEMUMachine'. So, mypy thinks that return value of VM.__enter__ is > QEMUMachine. Let's redefine __enter__ in VM class, to give

Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN

2021-08-04 Thread Kevin Wolf
Am 04.08.2021 um 16:50 hat Stefano Garzarella geschrieben: > On Mon, Aug 02, 2021 at 02:40:36PM +0200, Kevin Wolf wrote: > > Am 29.07.2021 um 11:10 hat Fabian Ebner geschrieben: > > > Linux SCSI can throw spurious -EAGAIN in some corner cases in its > > > completion path, which will end up being th

Re: [PATCH V5 12/25] cpr: QMP interfaces for restart

2021-08-04 Thread Eric Blake
On Wed, Jul 07, 2021 at 10:20:21AM -0700, Steve Sistare wrote: > cprexec calls cprexec(). Syntax: > { 'command': 'cprexec', 'data': { 'argv': [ 'str' ] } } > > Add the restart mode: > { 'enum': 'CprMode', 'data': [ 'reboot', 'restart' ] } > > Signed-off-by: Steve Sistare > --- > monitor/qm

Re: [PATCH 1/1] hw/arm/smmu: Add access flag handling

2021-08-04 Thread Eric Auger
Hi Joe, On 7/31/21 1:17 AM, Joe Komlodi wrote: > The SMMU should access fault if AF == 0 in a TTD, and if AFFD == 0 in the CD. > > Per the spec, an access fault has a higher priority over a permission fault. > For instance, a write to a writable clean (temporarily non-writable) page with > AF == 0

Re: [PATCH 0/3] Disable vhost device IOTLB is IOMMU is not enabled

2021-08-04 Thread Peter Xu
On Wed, Aug 04, 2021 at 11:48:00AM +0800, Jason Wang wrote: > Hi: > > We currently try to enable device IOTLB when iommu_platform is > set. This may lead unnecessary trasnsactions between qemu and vhost > when vIOMMU is not used (which is the typical case for the encrypted > VM). > > So patch tri

Re: [PULL 0/5] pc,pci: bugfixes

2021-08-04 Thread Peter Maydell
On Tue, 3 Aug 2021 at 21:52, Michael S. Tsirkin wrote: > > The following changes since commit f2da205cb4142259d9bc6b9d4596ebbe2426fe49: > > Update version for v6.1.0-rc1 release (2021-07-27 18:07:52 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/ms

Re: [RESEND RFC] hw/arm/smmuv3: add device properties to disable cached iotlb

2021-08-04 Thread Eric Auger
Hi Chenxiang, On 8/4/21 10:49 AM, chenxiang wrote: > From: Xiang Chen > > It splits invalidations into ^2 range invalidations in the patch > 6d9cd115b(" hw/arm/smmuv3: Enforce invalidation on a power of two range"). > So for some scenarios such as the size of invalidation is not ^2 range > invali

[PATCH v2 07/11] chardev: fix qemu_chr_open_fd() being called with fd=-1

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau The "file" chardev may call qemu_chr_open_fd() with fd_in=-1. This may cause invalid system calls, as the QIOChannel is assumed to be properly initialized later on. Signed-off-by: Marc-André Lureau --- chardev/char-fd.c | 26 +- 1 file changed, 1

[PATCH v2 11/11] chardev: reuse qmp_chardev_new()

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau qemu_chardev_new() and qmp_chardev_add() are similar, let's factorize the code a bit. Signed-off-by: Marc-André Lureau --- chardev/char.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/chardev/char.c b/chardev/char.c in

Re: [PATCH v7 29/33] iotests.py: hmp_qemu_io: support qdev

2021-08-04 Thread John Snow
On Wed, Aug 4, 2021 at 5:39 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/qemu-io

Re: [PATCH V5 02/25] cpr: reboot mode

2021-08-04 Thread Eric Blake
On Wed, Jul 07, 2021 at 10:20:11AM -0700, Steve Sistare wrote: > Provide the cprsave and cprload functions for live update. These save and > restore VM state, with minimal guest pause time, so that qemu may be updated > to a new version in between. > > +++ b/migration/cpr.c > @@ -0,0 +1,149 @@

[PATCH v2 06/11] chardev: fix fd_chr_add_watch() when in != out

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Create child sources for the different streams, and dispatch on the parent source with the synthesized conditions. Signed-off-by: Marc-André Lureau --- chardev/char-fd.c | 78 ++- 1 file changed, 77 insertions(+), 1 deletion(-

[PATCH v2 05/11] chardev: mark explicitly first argument as poisoned

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Since commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 "char: convert from GIOChannel to QIOChannel", the first argument to the watch callback can actually be a QIOChannel, which is not a GIOChannel (but a QEMU Object). Even though we never used that pointer, change the ca

Re: [PATCH V5 03/25] cpr: QMP interfaces for reboot

2021-08-04 Thread Eric Blake
On Wed, Jul 07, 2021 at 10:20:12AM -0700, Steve Sistare wrote: > cprsave calls cprsave(). Syntax: > { 'enum': 'CprMode', 'data': [ 'reboot' ] } > { 'command': 'cprsave', 'data': { 'file': 'str', 'mode': 'CprMode' } } > > cprload calls cprload(). Syntax: > { 'command': 'cprload', 'data': {

[PATCH v2 10/11] chardev: report a simpler error about duplicated id

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Report: "Chardev with id 'char2' already exists" Rather than: "Failed to add chardev 'char2': duplicate yank instance" Signed-off-by: Marc-André Lureau --- chardev/char.c | 5 + 1 file changed, 5 insertions(+) diff --git a/chardev/char.c b/chardev/char.c index

[PATCH v2 08/11] chardev: fix qemu_chr_open_fd() with fd_in==fd_out

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau The "serial" chardev calls qemu_chr_open_fd() with the same fd. This may lead to double-close as each QIOChannel owns the fd. Instead, share the reference to the same QIOChannel. Signed-off-by: Marc-André Lureau --- chardev/char-fd.c | 19 +++ 1 file ch

[PATCH v2 03/11] chardev: remove needless class method

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau "chr_option_parsed" is only implemented by the "mux" chardev, we can specialize the code there to avoid the needless generic class method. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- include/chardev/char.h |

[PATCH v2 02/11] chardev/socket: print a more correct command-line address

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Better reflect the command line version of the socket address arguments, following the now recommended long-form opt=on syntax. Complement/fixes commit 9d902d51 "chardev: do not use short form boolean options in non-QemuOpts character device descriptions". Signed-off-by:

[PATCH v2 04/11] chardev: add some comments about the class methods

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/chardev/char.h | 33 + 1 file changed, 33 insertions(+) diff --git a/include/chardev/char.h b/include/chardev/char.h index 589e7fe46d..a319b5fdff 100644 --- a/i

[PATCH v2 09/11] chardev: give some context on chardev-add error

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Description from Daniel P. Berrangé: > The original code reported: > > "attempt to add duplicate property 'char2' to object (type 'container')" > > Since adding yank support, the current code reports > > "duplicate yank instance" > > With this patch applied it now report

Re: [PATCH] chardev: give some context on chardev-add error

2021-08-04 Thread Marc-André Lureau
Hi On Tue, Aug 3, 2021 at 6:39 PM Daniel P. Berrangé wrote: > On Tue, Aug 03, 2021 at 04:02:29PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > Related to: > > https://bugzilla.redhat.com/show_bug.cgi?id=1984721 > > It is preferrable to describe the problem & ap

[PATCH v2 00/11] chardev related fixes

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Hi, Those patches have been sent earlier. I compiled them here, as I intend to send a pull request for 6.1. We may want to drop the last 2/3 patches since we are in freeze though. Marc-André Lureau (11): util: fix abstract socket path copy chardev/socket: print a mor

Re: [PATCH v4 00/13] new plugin argument passing scheme

2021-08-04 Thread Alex Bennée
Mahmoud Mandour writes: > Hello, > > This series removes passing arguments to plugins through "arg=" since > it's redundant and reduces readability especially when the argument > itself is composed of a name and a value. Queued to plugins/next, thanks. -- Alex Bennée

[PATCH v2 01/11] util: fix abstract socket path copy

2021-08-04 Thread marcandre . lureau
From: Marc-André Lureau Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket support" neglected to update socket_sockaddr_to_address_unix() and copied the whole sun_path without taking "salen" into account. Later, commit 3b14b4ec49 "sockets: Fix socket_sockaddr_to_address_unix() for

Re: [PATCH] hw/char/virtio-serial-bus: fix: Unpop throttled VirtQueueElement to queue before discard vq data

2021-08-04 Thread Stefan Hajnoczi
On Mon, Aug 02, 2021 at 05:01:14PM +0200, Laurent Vivier wrote: > On 30/07/2021 03:58, AIERPATIJIANG1 [艾尔帕提江·阿布都赛买提] wrote: > > Ports enter a "throttled" state when writing to the chardev would block. > > The current output VirtQueueElement is kept around until the chardev > > becomes writable agai

Re: [PATCH 1/2] fuzz: use ITIMER_REAL for timeouts

2021-08-04 Thread Darren Kenny
On Wednesday, 2021-08-04 at 09:56:20 -04, Alexander Bulekov wrote: > Using ITIMER_VIRTUAL is a bad idea, if the fuzzer hits a blocking > syscall - e.g. ppoll with a NULL timespec. This causes timeout issues > while fuzzing some block-device code. Fix that by using wall-clock time. > This might caus

Re: [PATCH v5 0/2] plugins/cache: multicore cache modelling

2021-08-04 Thread Alex Bennée
Mahmoud Mandour writes: > On Tue, Aug 3, 2021 at 11:10 PM Alex Bennée wrote: > > Mahmoud Mandour writes: > > > Hello, > > > > This series introduce multicore cache modelling in contrib/plugins/cache.c > > > > Multi-core cache modelling is handled such that for full-system > > emulation

Re: [PATCH 2/2] fuzz: unblock SIGALRM so the timeout works

2021-08-04 Thread Darren Kenny
On Wednesday, 2021-08-04 at 09:56:21 -04, Alexander Bulekov wrote: > The timeout mechanism wont work if SIGALRM is blocked. This changes NIT: s/wont/won't/ s/changes/change/ > unmasks SIGALRM when the timer is installed. This doesn't completely > solve the problem, as the fuzzer could trigge

Re: [PATCH 0/7] floppy: build as modules.

2021-08-04 Thread Philippe Mathieu-Daudé
+Mark On 8/4/21 4:27 PM, Gerd Hoffmann wrote: > Some code shuffling needed beforehand due to floppy being part of > several platforms. While being at it also make floppy optional > in pc machine type. > floppy: move fdctrl_init_sysbus > floppy: move sun4m_fdctrl_init https://www.mail-archiv

Re: [PATCH] linux-user/elfload: byteswap i386 registers when dumping core

2021-08-04 Thread Philippe Mathieu-Daudé
On 8/4/21 4:12 PM, Laurent Vivier wrote: > Le 03/08/2021 à 20:34, Peter Maydell a écrit : >> On Tue, 3 Aug 2021 at 18:21, Ilya Leoshkevich wrote: >>> >>> Core dumps from emulating x86_64 on big-endian hosts contain incorrect >>> register values. >>> >>> Signed-off-by: Ilya Leoshkevich >> >> >> Lo

Re: [PATCH 0/3] docs: convert qapi-code-gen.txt to qapi-code-gen.rst

2021-08-04 Thread Peter Maydell
On Wed, 4 Aug 2021 at 15:49, John Snow wrote: > > > > On Wed, Aug 4, 2021 at 4:48 AM Markus Armbruster wrote: >> >> For 6.1, or "don't rock the boat now"? > > > No preference. In response to the same question on the other doc conversion > patch, "No preference." I have no strong preference eith

improving logging of hanging tests in CI

2021-08-04 Thread Peter Maydell
Some of our tests in 'make check' hang intermittently. At the moment we have a path to diagnosing these when they happen via my ad-hoc CI scripts: I can log into the relevant machine and manually look at what has hung, attach gdb, etc. However, for the gitlab CI this doesn't work. Is it possible t

Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN

2021-08-04 Thread Stefano Garzarella
On Mon, Aug 02, 2021 at 02:40:36PM +0200, Kevin Wolf wrote: Am 29.07.2021 um 11:10 hat Fabian Ebner geschrieben: Linux SCSI can throw spurious -EAGAIN in some corner cases in its completion path, which will end up being the result in the completed io_uring request. Resubmitting such requests sh

Re: [PATCH 0/3] docs: convert qapi-code-gen.txt to qapi-code-gen.rst

2021-08-04 Thread John Snow
On Wed, Aug 4, 2021 at 4:48 AM Markus Armbruster wrote: > Peter Maydell writes: > > > On Wed, 21 Jul 2021 at 00:58, John Snow wrote: > >> > >> Patch 1 does (roughly) the bare minimum, patch 2 adds some formatting, > >> and patch 3 adds cross-references. > >> > >> John Snow (3): > >> docs: con

[RFC PATCH] vhost-vdpa: Do not send empty IOTLB update batches

2021-08-04 Thread Eugenio Pérez
With the introduction of the batch hinting, meaningless batches can be created with no IOTLB updates if the memory region was skipped by vhost_vdpa_listener_skipped_section. This is the case of host notifiers memory regions, but others could fall on this category. This caused the vdpa device to rec

[PATCH 6/7] tcg/module: Add tlb_flush_page to TCGModuleOps

2021-08-04 Thread Gerd Hoffmann
Move stub from exec-all.h to tcg-module.c. Signed-off-by: Gerd Hoffmann --- include/exec/exec-all.h | 3 --- include/tcg/tcg-module.h | 3 +++ accel/tcg/cputlb.c | 1 + accel/tcg/tcg-module.c | 5 + softmmu/physmem.c| 4 ++-- target/arm/helper.c | 4 ++-- 6 files change

[PATCH 2/7] tcg/module: move hmp.c to tcg module

2021-08-04 Thread Gerd Hoffmann
One little step in moving more code to the tcg modules. Signed-off-by: Gerd Hoffmann --- accel/tcg/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build index 137a1a44cc0a..d4df7681a811 100644 --- a/accel/tcg/meson.build +++

[PATCH 4/7] tcg/module: add some infrastructure for modular tcg.

2021-08-04 Thread Gerd Hoffmann
Create tcg-module.[ch] files, with struct TCGModuleOps, empty for now. Followup patches will add function pointers to the struct and stub functions to tcg-module.c. That will effectively will switch stubs from compile-time to runtime, which is needed to build tcg as module. Signed-off-by: Gerd H

  1   2   3   >