[PULL 10/12] block/nvme: Automatically free qemu_memalign() with QEMU_AUTO_VFREE

2021-11-02 Thread Kevin Wolf
From: Philippe Mathieu-Daudé Since commit 4d324c0bf65 ("introduce QEMU_AUTO_VFREE") buffers allocated by qemu_memalign() can automatically freed when using the QEMU_AUTO_VFREE macro. Use it to simplify a bit. Signed-off-by: Philippe Mathieu-Daudé Message-Id:

Re: [PATCH] colo: Don't dump colo cache if dump-guest-core=off

2021-11-02 Thread Juan Quintela
Lukas Straub wrote: > One might set dump-guest-core=off to make coredumps smaller and > still allow to debug many qemu bugs. Extend this option to the colo > cache. > > Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela

Re: [PATCH] MAINTAINERS: Change status to Odd Fixes

2021-11-02 Thread Peter Maydell
On Mon, 1 Nov 2021 at 18:31, Cédric Le Goater wrote: > > I haven't done any Aspeed development for a couple of years now and > maintaining the Aspeed QEMU machines has been a side project since. > I don't have time anymore. Thanks for the work you've done on this over the years. I guess this

Re: [PATCH v2 6/7] Changed the last-mode to none of first start COLO

2021-11-02 Thread Juan Quintela
"Rao, Lei" wrote: > From: "Rao, Lei" > > When we first stated the COLO, the last-mode is as follows: > { "execute": "query-colo-status" } > {"return": {"last-mode": "primary", "mode": "primary", "reason": "none"}} > > The last-mode is unreasonable. After the patch, will be changed to the >

[PULL 09/12] block-backend: Silence clang -m32 compiler warning

2021-11-02 Thread Kevin Wolf
From: Hanna Reitz Similarly to e7e588d432d31ecebc26358e47201dd108db964c, there is a warning in block/block-backend.c that qiov->size <= INT64_MAX is always true on machines where size_t is narrower than a uint64_t. In said commit, we silenced this warning by casting to uint64_t. The commit

Re: [PATCH v2 7/7] Optimized the function of fill_connection_key.

2021-11-02 Thread Juan Quintela
"Rao, Lei" wrote: > From: "Rao, Lei" > > Remove some unnecessary code to improve the performance of > the filter-rewriter module. > > Signed-off-by: Lei Rao > Reviewed-by: Zhang Chen As Chen has already reviewed it: Reviewed-by: Juan Quintela But I think that you should change in a

[PULL 08/12] linux-aio: add `dev_max_batch` parameter to laio_io_unplug()

2021-11-02 Thread Kevin Wolf
From: Stefano Garzarella Between the submission of a request and the unplug, other devices with larger limits may have been queued new requests without flushing the batch. Using the new `dev_max_batch` parameter, laio_io_unplug() can check if the batch exceeds the device limit to flush the

[PULL 05/12] block/export/fuse.c: fix musl build

2021-11-02 Thread Kevin Wolf
From: Fabrice Fontaine Include linux/falloc.h if CONFIG_FALLOCATE_ZERO_RANGE is defined to fix https://gitlab.com/qemu-project/qemu/-/commit/50482fda98bd62e072c30b7ea73c985c4e9d9bbb and avoid the following build failure on musl: ../block/export/fuse.c: In function 'fuse_fallocate':

Re: [PATCH] net/vhost-vdpa: fix memory leak in vhost_vdpa_get_max_queue_pairs()

2021-11-02 Thread Stefano Garzarella
On Tue, Nov 02, 2021 at 05:05:21PM +0100, Philippe Mathieu-Daudé wrote: On 11/2/21 16:51, Stefano Garzarella wrote: Use g_autofree to ensure that `config` is freed when vhost_vdpa_get_max_queue_pairs() returns. Reported-by: Coverity (CID 1465228: RESOURCE_LEAK) Fixes: 402378407d ("vhost-vdpa:

[PULL 06/12] file-posix: add `aio-max-batch` option

2021-11-02 Thread Kevin Wolf
From: Stefano Garzarella Commit d7ddd0a161 ("linux-aio: limit the batch size using `aio-max-batch` parameter") added a way to limit the batch size of Linux AIO backend for the entire AIO context. The same AIO context can be shared by multiple devices, so latency-sensitive devices may want to

Re: [PATCH v4 16/22] qapi: introduce x-query-skeys QMP command

2021-11-02 Thread Daniel P . Berrangé
On Tue, Nov 02, 2021 at 04:02:42PM +0100, Philippe Mathieu-Daudé wrote: > On 10/28/21 17:54, Daniel P. Berrangé wrote: > > This is a counterpart to the HMP "info skeys" command. It is being > > added with an "x-" prefix because this QMP command is intended as an > > adhoc debugging tool and will

[PULL 04/12] ide: Cap LBA28 capacity announcement to 2^28-1

2021-11-02 Thread Kevin Wolf
From: Samuel Thibault The LBA28 capacity (at offsets 60/61 of identification) is supposed to express the maximum size supported by LBA28 commands. If the device is larger than this, we have to cap it to 2^28-1. At least NetBSD happens to be using this value to determine whether to use LBA28 or

Re: [PATCH] net/vhost-vdpa: fix memory leak in vhost_vdpa_get_max_queue_pairs()

2021-11-02 Thread Philippe Mathieu-Daudé
On 11/2/21 16:51, Stefano Garzarella wrote: > Use g_autofree to ensure that `config` is freed when > vhost_vdpa_get_max_queue_pairs() returns. > > Reported-by: Coverity (CID 1465228: RESOURCE_LEAK) > Fixes: 402378407d ("vhost-vdpa: multiqueue support") > Signed-off-by: Stefano Garzarella > --- >

[PULL 12/12] block/nvme: Extract nvme_free_queue() from nvme_free_queue_pair()

2021-11-02 Thread Kevin Wolf
From: Philippe Mathieu-Daudé Instead of duplicating code, extract the common helper to free a single queue. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211006164931.172349-4-phi...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/nvme.c | 9 +++-- 1

[PULL 02/12] block: Fail gracefully when blockdev-snapshot creates loops

2021-11-02 Thread Kevin Wolf
Using blockdev-snapshot to append a node as an overlay to itself, or to any of its parents, causes crashes. Catch the condition and return an error for these cases instead. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1824363 Signed-off-by: Kevin Wolf Message-Id:

[PULL 00/12] Block layer patches

2021-11-02 Thread Kevin Wolf
The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50: Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into staging (2021-11-02 05:53:45 -0400) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

[PULL 11/12] block/nvme: Display CQ/SQ pointer in nvme_free_queue_pair()

2021-11-02 Thread Kevin Wolf
From: Philippe Mathieu-Daudé For debugging purpose it is helpful to know the CQ/SQ pointers. We already have a trace event in nvme_free_queue_pair(), extend it to report these pointer addresses. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211006164931.172349-3-phi...@redhat.com>

[PULL 01/12] block/file-posix: Fix return value translation for AIO discards

2021-11-02 Thread Kevin Wolf
From: Ari Sundholm AIO discards regressed as a result of the following commit: 0dfc7af2 block/file-posix: Optimize for macOS When trying to run blkdiscard within a Linux guest, the request would fail, with some errors in dmesg: [ snip ] [4.010070] sd 2:0:0:0: [sda] tag#0

Re: [PATCH v4 20/22] qapi: introduce x-query-irq QMP command

2021-11-02 Thread Daniel P . Berrangé
On Tue, Nov 02, 2021 at 03:57:08PM +0100, Philippe Mathieu-Daudé wrote: > On 10/28/21 17:54, Daniel P. Berrangé wrote: > > This is a counterpart to the HMP "info irq" command. It is being > > added with an "x-" prefix because this QMP command is intended as an > > adhoc debugging tool and will

Re: [PATCH v2 4/7] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff

2021-11-02 Thread Juan Quintela
"Rao, Lei" wrote: > From: "Rao, Lei" > > The GDB statck is as follows: > Program terminated with signal SIGSEGV, Segmentation fault. > 0 object_class_dynamic_cast (class=0x55c8f5d2bf50, typename=0x55c8f2f7379e > "qio-channel") at qom/object.c:832 > if (type->class->interfaces && >

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-02 Thread François Ozog
Hi Simon, On Tue, 2 Nov 2021 at 15:59, Simon Glass wrote: > Hi François, > > On Mon, 1 Nov 2021 at 02:53, François Ozog > wrote: > > > > Hi Simon, > > > > this seems a great endeavor. I'd like to better understand the scope of > it. > > > > Is it to be used as part of what could become a

[PULL 03/12] block/rbd: implement bdrv_co_block_status

2021-11-02 Thread Kevin Wolf
From: Peter Lieven the qemu rbd driver currently lacks support for bdrv_co_block_status. This results mainly in incorrect progress during block operations (e.g. qemu-img convert with an rbd image as source). This patch utilizes the rbd_diff_iterate2 call from librbd to detect allocated and

Re: [PATCH v2 3/7] Fixed SVM hang when do failover before PVM crash

2021-11-02 Thread Juan Quintela
"Rao, Lei" wrote: > From: "Rao, Lei" > > This patch fixed as follows: > Thread 1 (Thread 0x7f34ee738d80 (LWP 11212)): > #0 __pthread_clockjoin_ex (threadid=139847152957184, > thread_return=0x7f30b1febf30, clockid=, abstime= out>, block=) at pthread_join_common.c:145 > #1

Re: [PATCH v2 2/7] Fixed qemu crash when guest power off in COLO mode

2021-11-02 Thread Juan Quintela
"Rao, Lei" wrote: > From: "Rao, Lei" > > This patch fixes the following: > qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'running' > Aborted (core dumped) > The gdb bt as following: > 0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 > 1

Re: [PATCH v2 1/7] Some minor optimizations for COLO

2021-11-02 Thread Juan Quintela
"Rao, Lei" wrote: > From: "Rao, Lei" > > Signed-off-by: Lei Rao > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela queued.

[PATCH] net/vhost-vdpa: fix memory leak in vhost_vdpa_get_max_queue_pairs()

2021-11-02 Thread Stefano Garzarella
Use g_autofree to ensure that `config` is freed when vhost_vdpa_get_max_queue_pairs() returns. Reported-by: Coverity (CID 1465228: RESOURCE_LEAK) Fixes: 402378407d ("vhost-vdpa: multiqueue support") Signed-off-by: Stefano Garzarella --- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 0/6] rSTify contribution-related wiki pages

2021-11-02 Thread Kashyap Chamarthy
On Mon, Nov 01, 2021 at 02:56:43PM +, Peter Maydell wrote: > On Tue, 19 Oct 2021 at 10:04, Kashyap Chamarthy wrote: > > > > My main motivation was to convert SubmitAPatch[1] based on a chat with > > Peter Maydell and Dan Berrangé on #qemu channel (on OFTC). But the page > > also links to a

Re: [PULL 00/20] Migration 20211031 patches

2021-11-02 Thread Richard Henderson
On 11/1/21 6:08 PM, Juan Quintela wrote: The following changes since commit af531756d25541a1b3b3d9a14e72e7fedd941a2e: Merge remote-tracking branch 'remotes/philmd/tags/renesas-20211030' into staging (2021-10-30 11:31:41 -0700) are available in the Git repository at:

Re: [RFC 2/6] target/riscv: rvk: add implementation of instructions for Zbk* - reuse partial instructions of Zbb/Zbc extensions - add brev8 packh, unzip, zip, etc.

2021-11-02 Thread Richard Henderson
On 11/1/21 11:11 PM, liweiwei wrote: Signed-off-by: liweiwei Signed-off-by: wangjunqiang You managed to get the whole patch description into the subject line. Please break it up. +target_ulong HELPER(grev)(target_ulong rs1, target_ulong rs2) +{ +return do_grev(rs1, rs2,

Re: [PATCH 2/2] failover: don't allow to migrate a paused VM that needs PCI unplug

2021-11-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Sep 29, 2021 at 04:43:11PM +0200, Laurent Vivier wrote: >> As the guest OS is paused, we will never receive the unplug event >> from the kernel and the migration cannot continue. >> >> Signed-off-by: Laurent Vivier > > Well ... what if user previously did >

Re: [PATCH] migration: initialise compression_counters for a new migration

2021-11-02 Thread Juan Quintela
yuxiating wrote: > If the compression migration fails or is canceled, the query for the value of > compression_counters during the next compression migration is wrong. > > Signed-off-by: yuxiating > --- > migration/migration.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 5/5] block/nvme: Fix memory leak from nvme_init_queue()

2021-11-02 Thread Philippe Mathieu-Daudé
On 11/2/21 15:50, Kevin Wolf wrote: > Am 02.11.2021 um 13:36 hat Philippe Mathieu-Daudé geschrieben: >> On 11/2/21 13:33, Kevin Wolf wrote: >>> Should we still merge (parts of) this series for 6.2? Or does this mean >>> that we don't want it at all? >> >> Patches #1-4 are cleanups welcome for 6.2

Re: does drive_get_next(IF_NONE) make sense?

2021-11-02 Thread Philippe Mathieu-Daudé
On 11/2/21 16:14, Peter Maydell wrote: > Does it make sense for a device/board to do drive_get_next(IF_NONE) ? > > At the moment we have exactly one user of this, which is > hw/misc/sifive_u_otp.c. This is a model of a one-time-programmable > fuse, and the drive is providing the backing store for

Re: [PATCH v4 06/22] monitor: introduce HumanReadableText and HMP support

2021-11-02 Thread Philippe Mathieu-Daudé
On 10/28/21 17:54, Daniel P. Berrangé wrote: > This provides a foundation on which to convert simple HMP commands to > use QMP. The QMP implementation will generate formatted text targeted > for human consumption, returning it in the HumanReadableText data type. > > The HMP command handler will

Re: [PATCH 2/2] failover: don't allow to migrate a paused VM that needs PCI unplug

2021-11-02 Thread Michael S. Tsirkin
On Wed, Sep 29, 2021 at 04:43:11PM +0200, Laurent Vivier wrote: > As the guest OS is paused, we will never receive the unplug event > from the kernel and the migration cannot continue. > > Signed-off-by: Laurent Vivier Well ... what if user previously did pause start migration unpause we are

Re: [RFC PATCH 00/15] job: replace AioContext lock with job_mutex

2021-11-02 Thread Vladimir Sementsov-Ogievskiy
02.11.2021 17:13, Emanuele Giuseppe Esposito wrote: On 02/11/2021 14:08, Vladimir Sementsov-Ogievskiy wrote: 29.10.2021 19:38, Emanuele Giuseppe Esposito wrote: In this series, we want to remove the AioContext lock and instead use the already existent job_mutex to protect the job structures

Re: [PATCH v4 16/22] qapi: introduce x-query-skeys QMP command

2021-11-02 Thread Philippe Mathieu-Daudé
On 10/28/21 17:54, Daniel P. Berrangé wrote: > This is a counterpart to the HMP "info skeys" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long

Re: [PATCH v5 06/26] arm: qemu: Add a devicetree file for qemu_arm64

2021-11-02 Thread Simon Glass
Hi Tom, On Mon, 1 Nov 2021 at 12:07, Tom Rini wrote: > > On Mon, Nov 01, 2021 at 06:33:35PM +0100, François Ozog wrote: > > Hi Simon > > > > Le lun. 1 nov. 2021 à 17:58, Simon Glass a écrit : > > > > > Hi Peter, > > > > > > On Mon, 1 Nov 2021 at 04:48, Peter Maydell > > > wrote: > > > > > > >

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-11-02 Thread Simon Glass
Hi François, On Thu, 28 Oct 2021 at 10:26, François Ozog wrote: > > Hi Simon > > Le jeu. 28 oct. 2021 à 17:44, Simon Glass a écrit : >> >> Hi François, >> >> On Thu, 28 Oct 2021 at 08:50, François Ozog wrote: >> > >> > Hi Simon >> > >> > Le jeu. 28 oct. 2021 à 16:30, Simon Glass a écrit : >>

does drive_get_next(IF_NONE) make sense?

2021-11-02 Thread Peter Maydell
Does it make sense for a device/board to do drive_get_next(IF_NONE) ? At the moment we have exactly one user of this, which is hw/misc/sifive_u_otp.c. This is a model of a one-time-programmable fuse, and the drive is providing the backing store for the fuse contents. Borrowing an IF_NONE for this

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-02 Thread Simon Glass
Hi François, On Mon, 1 Nov 2021 at 02:53, François Ozog wrote: > > Hi Simon, > > this seems a great endeavor. I'd like to better understand the scope of it. > > Is it to be used as part of what could become a U-Boot entry ABI scheme? By > that I mean giving some fixed aspects > to U-Boot entry

Re: [PATCH 0/3] SEV: fixes for -kernel launch with incompatible OVMF

2021-11-02 Thread Brijesh Singh
On 11/2/21 8:22 AM, Dov Murik wrote: On 02/11/2021 12:52, Brijesh Singh wrote: Hi Dov, Overall the patch looks good, only question I have is that now we are enforce qemu to hash the kernel, initrd and cmdline unconditionally for any of the SEV guest launches. This requires anyone wanting

Re: [RFC 1/6] target/riscv: rvk: add flag support for Zbk[bcx]

2021-11-02 Thread liweiwei
在 2021/11/2 下午10:18, Richard Henderson 写道: On 11/1/21 11:11 PM, liweiwei wrote: +++ b/target/riscv/cpu.c @@ -472,15 +472,15 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)   error_setg(errp, "I and E extensions are incompatible");    

Re: [PATCH v5 06/26] arm: qemu: Add a devicetree file for qemu_arm64

2021-11-02 Thread Simon Glass
Hi François, On Mon, 1 Nov 2021 at 11:33, François Ozog wrote: > > Hi Simon > > Le lun. 1 nov. 2021 à 17:58, Simon Glass a écrit : >> >> Hi Peter, >> >> On Mon, 1 Nov 2021 at 04:48, Peter Maydell wrote: >> > >> > On Tue, 26 Oct 2021 at 01:33, Simon Glass wrote: >> > > >> > > Add this file,

Re: [PATCH 5/5] block/nvme: Fix memory leak from nvme_init_queue()

2021-11-02 Thread Kevin Wolf
Am 02.11.2021 um 13:36 hat Philippe Mathieu-Daudé geschrieben: > On 11/2/21 13:33, Kevin Wolf wrote: > > Am 07.10.2021 um 15:34 hat Philippe Mathieu-Daudé geschrieben: > >> On 10/7/21 15:29, Stefan Hajnoczi wrote: > >>> On Wed, Oct 06, 2021 at 06:49:31PM +0200, Philippe Mathieu-Daudé wrote: >

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-11-02 Thread Simon Glass
Hi Ilias, On Mon, 1 Nov 2021 at 05:05, Ilias Apalodimas wrote: > > Hi Simon, > > On Thu, 28 Oct 2021 at 05:51, Simon Glass wrote: > > > > Hi Ilias, > > > > On Tue, 26 Oct 2021 at 00:46, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > A bit late to the party, sorry! > > > > (Did

Re: [PATCH] escc: update transmit status bits when switching to async mode

2021-11-02 Thread Peter Maydell
On Mon, 1 Nov 2021 at 20:31, Mark Cave-Ayland wrote: > > The recent ESCC reset changes cause a regression when attemping to use a real > SS-5 Sun PROM instead of OpenBIOS. The Sun PROM doesn't send an explicit reset > command to the ESCC but gets stuck in a loop probing the keyboard waiting for >

Re: [PATCH v4 20/22] qapi: introduce x-query-irq QMP command

2021-11-02 Thread Philippe Mathieu-Daudé
On 10/28/21 17:54, Daniel P. Berrangé wrote: > This is a counterpart to the HMP "info irq" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long term

Re: [PATCH 07/15] hw/nvme: Add support for Secondary Controller List

2021-11-02 Thread Klaus Jensen
On Oct 7 18:23, Lukasz Maniak wrote: > Introduce handling for Secondary Controller List (Identify command with > CNS value of 15h). > > Secondary controller ids are unique in the subsystem, hence they are > reserved by it upon initialization of the primary controller to the > number of

Re: [PATCH v2] generic-loader: check that binary file target location exists

2021-11-02 Thread Damien Hedde
On 11/2/21 15:15, Peter Maydell wrote: On Tue, 2 Nov 2021 at 14:04, Damien Hedde wrote: On 11/1/21 11:53, Peter Maydell wrote: Won't this break the case of loading a file that spans two consecutive-but-different memory regions ? yes. I did not thought about that.

Re: [PATCH 05/15] hw/nvme: Add support for SR-IOV

2021-11-02 Thread Klaus Jensen
On Oct 7 18:23, Lukasz Maniak wrote: > This patch implements initial support for Single Root I/O Virtualization > on an NVMe device. > > Essentially, it allows to define the maximum number of virtual functions > supported by the NVMe controller via sriov_max_vfs parameter. > > Passing a

Re: [PATCH v4 17/22] qapi: introduce x-query-cmma QMP command

2021-11-02 Thread Philippe Mathieu-Daudé
On 10/28/21 17:54, Daniel P. Berrangé wrote: > This is a counterpart to the HMP "info cmma" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long

Re: [PATCH 06/15] hw/nvme: Add support for Primary Controller Capabilities

2021-11-02 Thread Klaus Jensen
On Oct 7 18:23, Lukasz Maniak wrote: > Implementation of Primary Controller Capabilities data > structure (Identify command with CNS value of 14h). > > Currently, the command returns only ID of a primary controller. > Handling of remaining fields are added in subsequent patches > implementing

Re: [PATCH 2/7] tests/docker: Simplify debian-all-test-cross

2021-11-02 Thread Philippe Mathieu-Daudé
On 11/2/21 13:24, Alex Bennée wrote: > Alex Bennée writes: >> Philippe Mathieu-Daudé writes: >>> On 10/18/21 12:54, Alex Bennée wrote: Richard Henderson writes: > The base debian10 image contains enough to build qemu; > we do not need to repeat that within the new image. >

Re: -only-migrate and the two different uses of migration blockers

2021-11-02 Thread Juan Quintela
David Gibson wrote: > On Tue, Jul 20, 2021 at 07:30:16AM +0200, Markus Armbruster wrote: > > Right, it may well have been the first usage this way, this fwnmi > stuff isn't super old. > >> >> While this isn't exactly terrible, it may be a weakness in our thinking >> >> and our infrastructure.

Re: -only-migrate and the two different uses of migration blockers

2021-11-02 Thread Juan Quintela
Markus Armbruster wrote: > We appear to use migration blockers in two ways: > > (1) Prevent migration for an indefinite time, typically due to use of > some feature that isn't compatible with migration. > > (2) Delay migration for a short time. > > Option -only-migrate is designed for (1). It

[PULL 3/4] vmdk: allow specification of tools version

2021-11-02 Thread Hanna Reitz
From: Thomas Weißschuh VMDK files support an attribute that represents the version of the guest tools that are installed on the disk. This attribute is used by vSphere before a machine has been started to determine if the VM has the guest tools installed. This is important when configuring

[PULL 4/4] block/vpc: Add a sanity check that fixed-size images have the right type

2021-11-02 Thread Hanna Reitz
From: Thomas Huth The code in vpc.c uses BDRVVPCState->footer.type in various places to decide whether the image is a fixed-size (VHD_FIXED) or a dynamic (VHD_DYNAMIC) image. However, we never check that this field really contains VHD_FIXED if we detected a fixed size image in vpc_open(), so a

Re: [PATCH v2] generic-loader: check that binary file target location exists

2021-11-02 Thread Peter Maydell
On Tue, 2 Nov 2021 at 14:04, Damien Hedde wrote: > > > > On 11/1/21 11:53, Peter Maydell wrote: > > Won't this break the case of loading a file that spans two > > consecutive-but-different memory regions ? > > yes. I did not thought about that. > > >I

[PULL 1/4] qemu-img: Consistent docs for convert -F

2021-11-02 Thread Hanna Reitz
From: Eric Blake Use consistent capitalization, and fix a missed line (we duplicate the qemu-img synopses in too many places). Fixes: 1899bf4737 (qemu-img: Add -F shorthand to convert) Signed-off-by: Eric Blake Message-Id: <20210921142812.2631605-1-ebl...@redhat.com> Reviewed-by: Vladimir

[PULL 2/4] pylint: fix errors and warnings generated by tests/qemu-iotests/297

2021-11-02 Thread Hanna Reitz
From: Emanuele Giuseppe Esposito Test 297 in tests/qemu-iotests currently fails: pylint has learned new things to check, or we simply missed them. All fixes in this patch are related to additional spaces used or wrong indentation. No functional change intended. Signed-off-by: Emanuele Giuseppe

Re: [PATCH 09/15] hw/nvme: Implement the Function Level Reset

2021-11-02 Thread Klaus Jensen
On Oct 7 18:24, Lukasz Maniak wrote: > From: Łukasz Gieryk > > This patch implements the FLR, a feature currently not implemented for > the Nvme device, while listed as a mandatory ("shall") in the 1.4 spec. > > The implementation reuses FLR-related building blocks defined for the > pci-bridge

Re: [PATCH v5 0/8] target/riscv: support Zfh, Zfhmin extension v0.1

2021-11-02 Thread Frank Chang
On Fri, Oct 22, 2021 at 12:30 AM wrote: > From: Frank Chang > > Zfh - Half width floating point > Zfhmin - Subset of half width floating point > > Zfh, Zfhmin v0.1 is now in public review period and is required by > RVV extension: > >

[PULL 0/4] Block patches

2021-11-02 Thread Hanna Reitz
The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50: Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into staging (2021-11-02 05:53:45 -0400) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2021-11-02

Re: [RFC 1/6] target/riscv: rvk: add flag support for Zbk[bcx]

2021-11-02 Thread Richard Henderson
On 11/1/21 11:11 PM, liweiwei wrote: +++ b/target/riscv/cpu.c @@ -472,15 +472,15 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp) error_setg(errp, "I and E extensions are incompatible"); return; - } +}

Re: [PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: Y> The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid > device by the standard, so just stick to the right number of device > models. > > This is not a problem to vhost-net, but it

Re: [PATCH] configure: fix --audio-drv-list help message

2021-11-02 Thread Peter Maydell
On Tue, 2 Nov 2021 at 13:56, Paolo Bonzini wrote: > > --audio-drv-list is now establishing which audio drivers to try if -audiodev > is not used; drivers for -audiodev are configured with --enable/--disable > options or possibly --without-default-features. Adjust the help message > for

Re: [RFC PATCH 00/15] job: replace AioContext lock with job_mutex

2021-11-02 Thread Emanuele Giuseppe Esposito
On 02/11/2021 14:08, Vladimir Sementsov-Ogievskiy wrote: 29.10.2021 19:38, Emanuele Giuseppe Esposito wrote: In this series, we want to remove the AioContext lock and instead use the already existent job_mutex to protect the job structures and list. This is part of the work to get rid of

Re: [PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-02 Thread Denis Plotnikov
On 02.11.2021 16:39, Denis Plotnikov wrote: The device destruction may superimpose over qemu shutdown. In this case some management layer, requested a device unplug and waiting for DEVICE_DELETED event, may never get this event. This happens because device_finalize() may never be called on

Re: [PULL 8/9] pci: Export pci_for_each_device_under_bus*()

2021-11-02 Thread Matthew Rosato
On 11/1/21 7:44 PM, Michael S. Tsirkin wrote: From: Peter Xu They're actually more commonly used than the helper without _under_bus, because most callers do have the pci bus on hand. After exporting we can switch a lot of the call sites to use these two helpers. Reviewed-by: David

Re: [PULL 0/1] qemu-openbios queue 20211101

2021-11-02 Thread Richard Henderson
On 11/1/21 5:56 PM, Mark Cave-Ayland wrote: The following changes since commit af531756d25541a1b3b3d9a14e72e7fedd941a2e: Merge remote-tracking branch 'remotes/philmd/tags/renesas-20211030' into staging (2021-10-30 11:31:41 -0700) are available in the Git repository at:

[PULL 36/41] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU

2021-11-02 Thread Philippe Mathieu-Daudé
FCR0_HAS2008 flag has been enabled in commit ba5c79f2622 ("target-mips: indicate presence of IEEE 754-2008 FPU in R6/R5+MSA CPUs"), so remove the obsolete FIXME comment. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Message-Id:

[PULL 40/41] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-11-02 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan This device is part of a superio/ISA bridge chip and IRQs from it are routed to an ISA interrupt set by the Interrupt Line PCI config register. Implement this in a vt82c686-uhci-pci specific irq handler Using via_isa_set_irq(). Signed-off-by: BALATON Zoltan Reviewed-by:

[PULL 37/41] usb/uhci: Misc clean up

2021-11-02 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan Fix a comment for coding style so subsequent patch will not get checkpatch error and simplify and shorten uhci_update_irq(). Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Message-Id: Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-uhci.c | 7

[PULL 35/41] target/mips: Fix Loongson-3A4000 MSAIR config register

2021-11-02 Thread Philippe Mathieu-Daudé
When using the Loongson-3A4000 CPU, the MSAIR is returned with a zero value (because unimplemented). Checking on real hardware, this value appears incorrect: $ cat /proc/cpuinfo system type : generic-loongson-machine machine : loongson,generic cpu model : Loongson-3 V0.4

Re: [PATCH v2] generic-loader: check that binary file target location exists

2021-11-02 Thread Damien Hedde
On 11/1/21 11:53, Peter Maydell wrote: On Tue, 26 Oct 2021 at 15:11, Damien Hedde wrote: When loading a binary file, we only check if it is smaller than the ram_size. It does not really check if the file will be loaded at an existing location (if there is nothing at the target address, it

[PULL 32/41] target/mips: Convert CTCMSA opcode to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert the CTCMSA (Copy To Control MSA register) opcode to decodetree. Since it overlaps with the SLDI opcode, use a decodetree overlap group. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-30-f4...@amsat.org>

[PULL 33/41] target/mips: Remove generic MSA opcode

2021-11-02 Thread Philippe Mathieu-Daudé
All opcodes have been converted to decodetree. The generic MSA handler is now pointless, remove it. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-31-f4...@amsat.org> --- target/mips/tcg/msa.decode | 2 --

[PATCH] configure: fix --audio-drv-list help message

2021-11-02 Thread Paolo Bonzini
--audio-drv-list is now establishing which audio drivers to try if -audiodev is not used; drivers for -audiodev are configured with --enable/--disable options or possibly --without-default-features. Adjust the help message for --audio-drv-list. Reported-by: Peter Maydell Signed-off-by: Paolo

[PULL 31/41] target/mips: Convert CFCMSA opcode to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert the CFCMSA (Copy From Control MSA register) opcode to decodetree. Since it overlaps with the SPLATI opcode, use a decodetree overlap group. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 24/41] target/mips: Convert MSA 3R instruction format to decodetree (part 2/4)

2021-11-02 Thread Philippe Mathieu-Daudé
Convert 3-register operations to decodetree. Per the Encoding of Operation Field for 3R Instruction Format' (Table 3.25), these instructions are not defined for the BYTE format. Therefore the TRANS_DF_iii_b() macro returns 'false' in that case, because no such instruction is decoded.

Re: [PATCH v8 26/29] target/loongarch: 'make check-tcg' support

2021-11-02 Thread Alex Bennée
Song Gao writes: > Reviewed-by: Richard Henderson > Signed-off-by: Song Gao > Signed-off-by: Xiaojuan Yang Acked-by: Alex Bennée -- Alex Bennée

[PULL 28/41] target/mips: Convert MSA COPY_U opcode to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert the COPY_U opcode (Element Copy to GPR Unsigned) to decodetree. Since the 'n' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 39/41] usb/uhci: Replace pci_set_irq with qemu_set_irq

2021-11-02 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan Instead of using pci_set_irq, store the irq in the device state and use it explicitly so variants having different interrupt handling can use their own. Signed-off-by: BALATON Zoltan Reviewed-by: Gerd Hoffmann Message-Id: Signed-off-by: Philippe Mathieu-Daudé ---

[PULL 17/41] target/mips: Convert MSA 2RF instruction format to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert 2-register floating-point operations to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-15-f4...@amsat.org> --- target/mips/tcg/msa.decode | 20 ++ target/mips/tcg/msa_translate.c |

[PULL 27/41] target/mips: Convert MSA ELM instruction format to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert instructions with an immediate element index and data format df/n to decodetree. Since the 'data format' and 'n' fields are constant values, use tcg_constant_i32() instead of a TCG temporaries. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe

Re: [PATCH v2 1/2] virtio-gpu: splitting one extended mode guest fb into n-scanouts

2021-11-02 Thread Gerd Hoffmann
On Mon, Jul 26, 2021 at 02:59:49PM -0700, Dongwon Kim wrote: > When guest is running Linux/X11 with extended multiple displays mode enabled, > the guest shares one scanout resource each time containing whole surface > rather than sharing individual display output separately. This extended frame >

[PULL 14/41] target/mips: Convert MSA SHF opcode to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert the SHF opcode (Immediate Set Shuffle Elements) to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 38/41] usb/uhci: Disallow user creating a vt82c686-uhci-pci device

2021-11-02 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan Because this device only works as part of VIA superio chips set user creatable to false. Since the class init method is common for UHCI variants introduce a flag in UHCIInfo for this. Signed-off-by: BALATON Zoltan Reviewed-by: Gerd Hoffmann Message-Id: Signed-off-by:

Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-11-02 Thread Philippe Mathieu-Daudé
On 11/2/21 13:42, BALATON Zoltan wrote: > On Tue, 2 Nov 2021, Gerd Hoffmann wrote: >> On Tue, Nov 02, 2021 at 11:53:18AM +0100, BALATON Zoltan wrote: >>> Hello, >>> >>> On Mon, 25 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/25/21 13:33, BALATON Zoltan wrote: > This is the same as posted

[PULL 22/41] target/mips: Convert MSA 3RF instruction format to decodetree (DF_WORD)

2021-11-02 Thread Philippe Mathieu-Daudé
Convert 3-register floating-point or fixed-point operations to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-20-f4...@amsat.org> --- target/mips/tcg/msa.decode | 39 ++

[PULL 13/41] target/mips: Convert MSA BIT instruction format to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert instructions with an immediate bit index and data format df/m to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 34/41] target/mips: Remove one MSA unnecessary decodetree overlap group

2021-11-02 Thread Philippe Mathieu-Daudé
Only the MSA generic opcode was overlapping with the other instructions. Since the previous commit removed it, we can now remove the overlap group. The decodetree script forces us to re-indent the opcodes. Diff trivial to review using `git-diff --ignore-all-space`. Reviewed-by: Jiaxun Yang

[PULL 20/41] target/mips: Convert MSA VEC instruction format to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert 3-register instructions with implicit data formats to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-18-f4...@amsat.org> --- target/mips/tcg/msa.decode | 8 +++

[PULL 41/41] Revert "elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too"

2021-11-02 Thread Philippe Mathieu-Daudé
Per the "P32 Porting Guide" (rev 1.2) [1], chapter 2: p32 ABI Overview The Application Binary Interface, or ABI, is the set of rules that all binaries must follow in order to run on a nanoMIPS system. This includes, for example, object file format, instruction set,

[PULL 10/41] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v

2021-11-02 Thread Philippe Mathieu-Daudé
This 'shift amount' format is not always 16-bit, so name it generically as 'sa'. This will help to unify the various arg_msa decodetree generated structures. Rename the @bz format -> @bz_v (specific @bz with df=3) and @bz_df -> @bz (generic @bz). Since we modify _bz, re-align its arguments, so

[PULL 30/41] target/mips: Convert MSA MOVE.V opcode to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert the MOVE.V opcode (Vector Move) to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-28-f4...@amsat.org> --- target/mips/tcg/msa.decode | 7 ++- target/mips/tcg/msa_translate.c | 19

[PULL 18/41] target/mips: Convert MSA FILL opcode to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert the FILL opcode (Vector Fill from GPR) to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-16-f4...@amsat.org> --- target/mips/tcg/msa.decode | 2 ++ target/mips/tcg/msa_translate.c | 31

[PULL 29/41] target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree

2021-11-02 Thread Philippe Mathieu-Daudé
Convert the COPY_S (Element Copy to GPR Signed) opcode and INSERT (GPR Insert Element) opcode to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211028210843.2120802-27-f4...@amsat.org> --- target/mips/tcg/msa.decode

[PULL 23/41] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4)

2021-11-02 Thread Philippe Mathieu-Daudé
Convert 3-register operations to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Note, the format definition could be named @3rf_b (for 3R with a df field BYTE-based) but since the instruction class is named '3R', we simply call

<    1   2   3   4   5   6   >