Re: [PATCH] virtio-net: set the max of queue size to 4096

On Wed, Sep 21, 2022 at 02:15:41PM +0800, Jason Wang wrote: > On Wed, Sep 21, 2022 at 11:57 AM Michael S. Tsirkin wrote: > > > > On Wed, Sep 21, 2022 at 10:59:50AM +0800, Jason Wang wrote: > > > On Tue, Sep 20, 2022 at 8:59 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Sep 20, 2022

Re: [PATCH] ratelimit: restrict the delay time to a non-negative value

On Wed, 2022-09-21 at 06:53 +0200, Markus Armbruster wrote: > Wang Liang writes: > > > On Tue, 2022-09-20 at 13:18 +, Alberto Garcia wrote: > > > On Tue 20 Sep 2022 08:33:50 PM +08, wanglian...@126.com wrote: > > > > From: Wang Liang > > > > > > > > The delay time should never be a negative

Re: [PATCH] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

在 2022/9/21 13:28, Raphael Norwitz 写道: I have some concerns from the vhost-user-blk side. >On Tue, Sep 13, 2022 at 5:13 PM Hao Chen wrote: >> >> When use dpdk-vdpa tests vdpa device. You need to specify the mac address to >> start the virtual machine through libvirt or qemu, but now, the l

Re: [PATCH] virtio-net: set the max of queue size to 4096

On Wed, Sep 21, 2022 at 11:57 AM Michael S. Tsirkin wrote: > > On Wed, Sep 21, 2022 at 10:59:50AM +0800, Jason Wang wrote: > > On Tue, Sep 20, 2022 at 8:59 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 20, 2022 at 10:03:23AM +0800, Jason Wang wrote: > > > > On Tue, Sep 20, 2022 at 9:38 AM

Re: [PATCH 0/1] hw/display: expose linear framebuffer address in Bochs VBE registers

Hi, > 1. Although it is reasonable to assume no more than one isa-vga device > will exist in one machine, this could be changed easily later on. Nope. Even if you fix the framebuffer address conflict you still have the io address conflict. > As it stands now, on an ISA-PC machine with no

Re: [PATCH v1 0/3] ui/gtk: Add a new parameter to assign connectors/monitors to Guests' windows

"Kasireddy, Vivek" writes: > Hi Markus, > >> Any overlap with Dongwon Kim's "[PATCH v5 0/2] handling guest multiple >> displays"? > > [Kasireddy, Vivek] Yes, there is some overlap but as I mentioned in the cover > letter, > this series is intended to replace Dongwon's series dealing with multipl

[PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

From: Hao Chen When use dpdk-vdpa tests vdpa device. You need to specify the mac address to start the virtual machine through libvirt or qemu, but now, the libvirt or qemu can call dpdk vdpa vendor driver's ops .get_config through vhost_net_get_config to get the mac address of the vdpa hardware

Re: [PATCH] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

I have some concerns from the vhost-user-blk side. >On Tue, Sep 13, 2022 at 5:13 PM Hao Chen wrote: >> >> When use dpdk-vdpa tests vdpa device. You need to specify the mac address to >> start the virtual machine through libvirt or qemu, but now, the libvirt or >> qemu can call dpdk vdpa ven

Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState

Bernhard Beschow writes: > Am 20. September 2022 11:36:47 UTC schrieb Markus Armbruster > : >>Alistair Francis writes: >> >>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to inherit from TYPE_MACHIN

Re: [PATCH] ratelimit: restrict the delay time to a non-negative value

Wang Liang writes: > On Tue, 2022-09-20 at 13:18 +, Alberto Garcia wrote: >> On Tue 20 Sep 2022 08:33:50 PM +08, wanglian...@126.com wrote: >> > From: Wang Liang >> > >> > The delay time should never be a negative value. >> > >> > -return limit->slice_end_time - now; >> > +return M

Re: [PATCH v9 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

On 9/20/22 17:51, Klaus Jensen wrote: On Sep 10 13:27, Sam Li wrote: Add a new zoned_host_device BlockDriver. The zoned_host_device option accepts only zoned host block devices. By adding zone management operations in this new BlockDriver, users can use the new block layer APIs including Report

Re: [PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

Kevin Wolf writes: > Am 08.09.2022 um 19:36 hat Claudio Fontana geschrieben: >> On 9/8/22 19:10, Claudio Fontana wrote: >> > On 9/8/22 18:03, Richard Henderson wrote: >> >> On 9/8/22 15:53, Claudio Fontana wrote: >> >>> @@ -446,8 +447,13 @@ static int dmg_open(BlockDriverState *bs, QDict >> >>>

Re: [PATCH] virtio-net: set the max of queue size to 4096

On Wed, Sep 21, 2022 at 10:59:50AM +0800, Jason Wang wrote: > On Tue, Sep 20, 2022 at 8:59 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 20, 2022 at 10:03:23AM +0800, Jason Wang wrote: > > > On Tue, Sep 20, 2022 at 9:38 AM Jason Wang wrote: > > > > > > > > On Tue, Sep 20, 2022 at 9:10 AM liuha

Re: [PATCH 2/3] acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses

On Tue, 20 Sep 2022, Miguel Luis wrote: > Per the ACPI 6.5 specification, on the GTDT Table Structure, the Counter > Control > Block Address and Counter Read Block Address fields of the GTDT table should > be > set to 0x if not provided, rather than 0x0. > > Fixes: 41041e57085

Re: [PATCH 3/3] tests/acpi: virt: update ACPI GTDT binaries

On Tue, 20 Sep 2022, Miguel Luis wrote: > Step 6 & 7 of the bios-tables-test.c documented procedure. > > Differences between disassembled ASL files for GTDT: > > @@ -13,14 +13,14 @@ > [000h 4]Signature : "GTDT"[Generic Timer > Description Table] > [

Re: [PATCH 1/3] tests/acpi: virt: allow acpi GTDT changes

On Tue, 20 Sep 2022, Miguel Luis wrote: > Step 3 from bios-tables-test.c documented procedure. > > Signed-off-by: Miguel Luis Acked-by: Ani Sinha > --- > tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/qtest/bios-tables-test-all

Re: [PULL v2 0/9] loongarch-to-apply queue

在 2022/9/21 上午2:33, Stefan Hajnoczi 写道: Please remember to push your GPG key to the keyservers using gpg send-keys YOUR_KEY_ID. Thanks for your reminding. I send the keys to  hkps://keys.openpgp.org  yesterday ,  but fogot to update the  identity information. Thanks. Song Gao

Re: [PATCH v6 2/2] i386: Add notify VM exit support

On 9/20/2022 9:59 PM, Peter Xu wrote: On Tue, Sep 20, 2022 at 01:55:20PM +0800, Chenyi Qiang wrote: @@ -5213,6 +5213,7 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run) break; case KVM_EXIT_NOTIFY: ret = 0; +warn_report_once("KVM: notify windo

Re: [PATCH] virtio-net: set the max of queue size to 4096

On Tue, Sep 20, 2022 at 8:59 PM Michael S. Tsirkin wrote: > > On Tue, Sep 20, 2022 at 10:03:23AM +0800, Jason Wang wrote: > > On Tue, Sep 20, 2022 at 9:38 AM Jason Wang wrote: > > > > > > On Tue, Sep 20, 2022 at 9:10 AM liuhaiwei wrote: > > > > > > > > From: liuhaiwei > > > > > > > > the limit

Re: [PATCH] vhost-user-blk: fix the resize crash

>If the os is not installed and doesn't have the virtio guest driver, >the vhost dev isn't started, so the dev->vdev is NULL. > >Reproduce: mount a Win 2019 iso, go into the install ui, then resize >the virtio-blk device, qemu crash. > >Signed-off-by: Li Feng fen...@smartx.com

Re: [PATCH] ratelimit: restrict the delay time to a non-negative value

On Tue, 2022-09-20 at 13:18 +, Alberto Garcia wrote: > On Tue 20 Sep 2022 08:33:50 PM +08, wanglian...@126.com wrote: > > From: Wang Liang > > > > The delay time should never be a negative value. > > > > -return limit->slice_end_time - now; > > +return MAX(limit->slice_end_time - now

RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

[AMD Official Use Only - General] Hi Paul and AFAIK: Thanks for your help. When could we see this patch on the master branch? 😊 Our project urgently needs this solution. Thanks! Ruili -Original Message- From: Paul Durrant Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for pass

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

On Wed, Sep 14, 2022 at 4:08 PM Bin Meng wrote: > > On Wed, Sep 7, 2022 at 1:07 PM Bin Meng wrote: > > > > Hi Clément, > > > > On Tue, Sep 6, 2022 at 8:06 PM Clément Chigot wrote: > > > > > > > > > I checked your patch, what you did seems to be something one would > > > > > > naturally write, bu

[PATCH 10/14] migration: Make PageSearchStatus part of RAMState

We used to allocate PSS structure on the stack for precopy when sending pages. Make it static, so as to describe per-channel ram migration status. Here we declared RAM_CHANNEL_MAX instances, preparing for postcopy to use it, even though this patch has not yet to start using the 2nd instance. Thi

[PATCH 05/14] migration: Yield bitmap_mutex properly when sending/sleeping

Don't take the bitmap mutex when sending pages, or when being throttled by migration_rate_limit() (which is a bit tricky to call it here in ram code, but seems still helpful). It prepares for the possibility of concurrently sending pages in >1 threads using the function ram_save_host_page() becaus

[PATCH 06/14] migration: Use atomic ops properly for page accountings

To prepare for thread-safety on page accountings, at least below counters need to be accessed only atomically, they are: ram_counters.transferred ram_counters.duplicate ram_counters.normal ram_counters.postcopy_bytes There are a lot of other counters but they won't

[PATCH 04/14] migration: Remove RAMState.f references in compression code

Removing referencing to RAMState.f in compress_page_with_multi_thread() and flush_compressed_data(). Compression code by default isn't compatible with having >1 channels (or it won't currently know which channel to flush the compressed data), so to make it simple we always flush on the default to_

[PATCH] qboot: rebuild based on latest commit

df22fbb751 ("qboot: update to latest submodule") updated the qboot submodule from a5300c49 to 8ca302e8. However, qboot isn't built during the QEMU's build process but rather is included in binary form. So rebuild it here. Cc: Paolo Bonzini Signed-off-by: Jason A. Donenfeld --- Paolo - I have no

Re: [PATCH 13/14] migration: Remove old preempt code around state maintainance

On Tue, Sep 20, 2022 at 06:52:27PM -0400, Peter Xu wrote: > With the new code to send pages in rp-return thread, there's little help to > keep lots of the old code on maintaining the preempt state in migration > thread, because the new way should always be faster.. > > Then if we'll always send pa

Re: [PATCH] qboot: update to latest submodule

On Wed, Sep 21, 2022 at 12:22 AM Paolo Bonzini wrote: > Yeah the mirroring from GitHub to (my personal fork on) Gitlab was failing > because git:// is not supported anymore. Changed to https:// and everybody is > happy. Ahh, bingo. > Btw I saw your other patches, will get to it tomorrow. Supe

Re: [PATCH] qboot: update to latest submodule

Il mer 21 set 2022, 00:11 Jason A. Donenfeld ha scritto: > On Tue, Sep 20, 2022 at 11:57:09PM +0200, Paolo Bonzini wrote: > > It should have been automatic, there's mirroring set up. > > Hm, something is weird. Gitlab says "This project is mirrored from > https://gitlab.com/bonzini/qboot.git. Pul

Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups

"Michael S. Tsirkin" writes: > On Tue, Sep 20, 2022 at 02:25:48PM -0400, Stefan Hajnoczi wrote: >> On Tue, 20 Sept 2022 at 10:18, Alex Bennée wrote: >> > >> > >> > Stefan Hajnoczi writes: >> > >> > > [[PGP Signed Part:Undecided]] >> > > On Fri, Sep 16, 2022 at 07:51:40AM +0100, Alex Bennée wr

Re: [PATCH 8/9] softmmu/physmem: Let SysBusState absorb memory region and address space singletons

Am 20. September 2022 08:50:01 UTC schrieb BALATON Zoltan : > > >On Tue, 20 Sep 2022, Philippe Mathieu-Daudé via wrote: > >> On 20/9/22 01:17, Bernhard Beschow wrote: >>> These singletons are actually properties of the system bus but so far it >>> hasn't been modelled that way. Fix this to make thi

Re: [PATCH] qboot: update to latest submodule

On Mon, Sep 19, 2022 at 04:35:54PM +0200, Jason A. Donenfeld wrote: > FYI, that commit made it to: > > https://github.com/bonzini/qboot > > But wasn't pushed to: > > https://github.com/qemu/qboot > https://gitlab.com/qemu-project/qboot > https://git.qemu.org/?p=qboot.git;a=summary > > I have no

Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al

Am 20. September 2022 15:36:26 UTC schrieb Mark Cave-Ayland : >On 20/09/2022 10:55, Peter Maydell wrote: > >> On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: >>> >>> In address-spaces.h it can be read that get_system_memory() and >>> get_system_io() are temporary interfaces which "should

Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState

Am 20. September 2022 11:36:47 UTC schrieb Markus Armbruster : >Alistair Francis writes: > >> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: >>> >>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to >>> inherit from TYPE_MACHINE. This is an inconsistency which can

Re: [PATCH v2 28/39] hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure

On Tue, Sep 20, 2022 at 11:40 PM Daniel Henrique Barboza wrote: > > Bin, > > Since I'll send a ppc pull request shortly, I'll queue up both this and patch > 27 via > the ppc tree. These are good fixes that are independent of what happens with > the > 'tests/qtest: Enable running qtest on Windows

[PATCH 12/14] migration: Send requested page directly in rp-return thread

With all the facilities ready, send the requested page directly in the rp-return thread rather than queuing it in the request queue, if and only if postcopy preempt is enabled. It can achieve so because it uses separate channel for sending urgent pages. The only shared data is bitmap and it's pro

Re: [PULL v2 0/9] loongarch-to-apply queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

[PULL 16/17] hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure

From: Xuzhou Cheng pnv_phb3_root_bus_info and pnv_phb4_root_bus_info are missing the instance_size initialization. This results in accessing out-of-bound memory when setting 'chip-id' and 'phb-id', and eventually crashes glib's malloc functionality with the following message: "qemu-system-ppc6

[PATCH 13/14] migration: Remove old preempt code around state maintainance

With the new code to send pages in rp-return thread, there's little help to keep lots of the old code on maintaining the preempt state in migration thread, because the new way should always be faster.. Then if we'll always send pages in the rp-return thread anyway, we don't need those logic to mai

[PATCH 11/14] migration: Move last_sent_block into PageSearchStatus

Since we use PageSearchStatus to represent a channel, it makes perfect sense to keep last_sent_block (aka, leverage RAM_SAVE_FLAG_CONTINUE) to be per-channel rather than global because each channel can be sending different pages on ramblocks. Hence move it from RAMState into PageSearchStatus. Sig

[PATCH 07/14] migration: Teach PSS about host page

Migration code has a lot to do with host pages. Teaching PSS core about the idea of host page helps a lot and makes the code clean. Meanwhile, this prepares for the future changes that can leverage the new PSS helpers that this patch introduces to send host page in another thread. Three more fie

Re: [PATCH 9/9] exec/address-spaces: Inline legacy functions

Am 20. September 2022 09:02:41 UTC schrieb BALATON Zoltan : > > >On Tue, 20 Sep 2022, Philippe Mathieu-Daudé via wrote: > >> On 20/9/22 01:17, Bernhard Beschow wrote: >>> The functions just access a global pointer and perform some pointer >>> arithmetic on top. Allow the compiler to see through thi

[PATCH 00/14] migration: Postcopy Preempt-Full

Based-on: <20220920223800.47467-1-pet...@redhat.com> [PATCH 0/5] migration: Bug fixes (prepare for preempt-full) Tree is here: https://github.com/xzpeter/qemu/tree/preempt-full RFC: https://lore.kernel.org/qemu-devel/20220829165659.96046-1-pet...@redhat.com This patchset is the v1 formal v

[PULL 15/17] hw/ppc: spapr: Use qemu_vfree() to free spapr->htab

From: Xuzhou Cheng spapr->htab is allocated by qemu_memalign(), hence we should use qemu_vfree() to free it. Fixes: c5f54f3e31bf ("pseries: Move hash page table allocation to reset time") Fixes: b4db54132ffe ("target/ppc: Implement H_REGISTER_PROCESS_TABLE H_CALL"") Signed-off-by: Xuzhou Cheng

[PATCH 01/14] migration: Add postcopy_preempt_active()

Add the helper to show that postcopy preempt enabled, meanwhile active. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/ram.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1d42414ecc..d8cf7cc901 100

Re: [PATCH 2/9] exec/hwaddr.h: Add missing include

Am 20. September 2022 04:50:51 UTC schrieb "Philippe Mathieu-Daudé" : >On 20/9/22 01:17, Bernhard Beschow wrote: >> The next commit would not compile w/o the include directive. >> >> Signed-off-by: Bernhard Beschow >> --- >> include/exec/hwaddr.h | 1 + >> 1 file changed, 1 insertion(+) >> >

[PULL 08/17] target/ppc: Remove unused xer_* macros

From: Víctor Colombo The macros xer_ov, xer_ca, xer_ov32, and xer_ca32 are both unused and hiding the usage of env. Remove them. Signed-off-by: Víctor Colombo Reviewed-by: Daniel Henrique Barboza Message-Id: <20220906125523.38765-3-victor.colo...@eldorado.org.br> Signed-off-by: Daniel Henrique

Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al

Am 20. September 2022 09:55:37 UTC schrieb Peter Maydell : >On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: >> >> In address-spaces.h it can be read that get_system_memory() and >> get_system_io() are temporary interfaces which "should only be used >> temporarily >> until a proper bus int

[PATCH 3/5] migration: Disallow xbzrle with postcopy

It's not supported since the 1st day, as ram_load_postcopy does not handle RAM_SAVE_FLAG_XBZRLE. Mark it disabled explicitly. Signed-off-by: Peter Xu --- migration/migration.c | 5 + 1 file changed, 5 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index bb8bbddfe4

[PATCH 09/14] migration: Add pss_init()

Helper to init PSS structures. Signed-off-by: Peter Xu --- migration/ram.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 40ff5dc49f..b4b36ca59e 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -535,6 +535,14 @@ stati

[PATCH 1/5] migration: Fix possible deadloop of ram save process

When starting ram saving procedure (especially at the completion phase), always set last_seen_block to non-NULL to make sure we can always correctly detect the case where "we've migrated all the dirty pages". Then we'll guarantee both last_seen_block and pss.block will be valid always before the l

[PULL 11/17] target/ppc: Zero second doubleword for VSX madd instructions

From: Víctor Colombo In 205eb5a89e we updated most VSX instructions to zero the second doubleword, as is requested by PowerISA since v3.1. However, VSX_MADD helper was left behind unchanged, while it is also affected and should be fixed as well. This patch applies the fix for MADD instructions.

[PATCH 2/5] migration: Fix race on qemu_file_shutdown()

In qemu_file_shutdown(), there's a possible race if with current order of operation. There're two major things to do: (1) Do real shutdown() (e.g. shutdown() syscall on socket) (2) Update qemufile's last_error We must do (2) before (1) otherwise there can be a race condition like: pag

[PULL 03/17] target/ppc: Implement hashstp and hashchkp

From: Víctor Colombo Implementation for instructions hashstp and hashchkp, the privileged versions of hashst and hashchk, which were added in Power ISA 3.1B. Signed-off-by: Víctor Colombo Reviewed-by: Lucas Mateus Castro Message-Id: <20220715205439.161110-4-victor.colo...@eldorado.org.br> Sign

[PATCH 14/14] migration: Drop rs->f

Now with rs->pss we can already cache channels in pss->pss_channels. That pss_channel contains more infromation than rs->f because it's per-channel. So rs->f could be replaced by rss->pss[RAM_CHANNEL_PRECOPY].pss_channel, while rs->f itself is a bit vague now. Note that vanilla postcopy still sen

Re: [PATCH] qboot: update to latest submodule

It should have been automatic, there's mirroring set up. Paolo Il mar 20 set 2022, 23:00 Jason A. Donenfeld ha scritto: > On Mon, Sep 19, 2022 at 04:35:54PM +0200, Jason A. Donenfeld wrote: > > FYI, that commit made it to: > > > > https://github.com/bonzini/qboot > > > > But wasn't pushed to: >

[PULL 02/17] target/ppc: Implement hashst and hashchk

From: Víctor Colombo Implementation for instructions hashst and hashchk, which were added in Power ISA 3.1B. It was decided to implement the hash algorithm from ground up in this patch exactly as described in Power ISA. Signed-off-by: Víctor Colombo Reviewed-by: Lucas Mateus Castro Message-Id

[PATCH 08/14] migration: Introduce pss_channel

Introduce pss_channel for PageSearchStatus, define it as "the migration channel to be used to transfer this host page". We used to have rs->f, which is a mirror to MigrationState.to_dst_file. After postcopy preempt initial version, rs->f can be dynamically changed depending on which channel we wa

RE: [PATCH v1 0/3] ui/gtk: Add a new parameter to assign connectors/monitors to Guests' windows

Hi Markus, > Any overlap with Dongwon Kim's "[PATCH v5 0/2] handling guest multiple > displays"? [Kasireddy, Vivek] Yes, there is some overlap but as I mentioned in the cover letter, this series is intended to replace Dongwon's series dealing with multiple displays. > > Message-Id: <2022071823

[PATCH 03/14] migration: Trivial cleanup save_page_header() on same block check

The 2nd check on RAM_SAVE_FLAG_CONTINUE is a bit redundant. Use a boolean to be clearer. Signed-off-by: Peter Xu --- migration/ram.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index fc59c052cf..62ff2c1469 100644 --- a/migration/ram

Re: [Phishing Risk] [External] Re: [PATCH 0/3] Add a host power device

On 20/9/22 17:17, Zhang Jian wrote: Hi Philippe, Thanks for your reply. On Tue, Sep 20, 2022 at 7:09 AM Philippe Mathieu-Daudé wrote: Hi Jian, On 19/9/22 19:21, Jian Zhang wrote: This patchset adds a host power device and added it into the g220a mahcine. The BMC have a important is to cont

[PATCH 02/14] migration: Cleanup xbzrle zero page cache update logic

The major change is to replace "!save_page_use_compression()" with "xbzrle_enabled" to make it clear. Reasonings: (1) When compression enabled, "!save_page_use_compression()" is exactly the same as checking "xbzrle_enabled". (2) When compression disabled, "!save_page_use_compression()" alway

[PULL 17/17] hw/ppc/spapr: Fix code style problems reported by checkpatch

From: Bernhard Beschow Reviewed-by: Daniel Henrique Barboza Signed-off-by: Bernhard Beschow Message-Id: <20220919231720.163121-5-shen...@gmail.com> Signed-off-by: Daniel Henrique Barboza --- include/hw/ppc/spapr.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includ

[PATCH 0/5] migration: Bug fixes (prepare for preempt-full)

This patchset does bug fixes that I found when testing preempt-full. Patch 1 should fix a possible deadloop when I hit when testing the preempt-full code. I didn't verify it because it's so hard to trigger, but the logic should be explained in the patch. Patch 2 fixes a race condition I can easi

Re: [PULL v2 0/9] loongarch-to-apply queue

Please remember to push your GPG key to the keyservers using gpg send-keys YOUR_KEY_ID. Thanks, Stefan

[PATCH 4/5] migration: Disallow postcopy preempt to be used with compress

The preempt mode requires the capability to assign channel for each of the page, while the compression logic will currently assign pages to different compress thread/local-channel so potentially they're incompatible. Signed-off-by: Peter Xu --- migration/migration.c | 11 +++ 1 file chan

[PULL 10/17] target/ppc: Set result to QNaN for DENBCD when VXCVI occurs

From: Víctor Colombo According to the ISA, for instruction DENBCD: "If an invalid BCD digit or sign code is detected in the source operand, an invalid-operation exception (VXCVI) occurs." In the Invalid Operation Exception section, there is the situation: "When Invalid Operation Exception is dis

[PULL 13/17] target/ppc: Zero second doubleword of VSR registers for FPR insns

From: Víctor Colombo FPR register are mapped to the first doubleword of the VSR registers. Since PowerISA v3.1, the second doubleword of the target register must be zeroed for FP instructions. This patch does it by writting 0 to the second dw everytime the first dw is being written using set_fpr

[PULL 12/17] target/ppc: Set OV32 when OV is set

From: Víctor Colombo According to PowerISA: "OV32 is set whenever OV is implicitly set, and is set to the same value that OV is defined to be set to in 32-bit mode". This patch changes helper_update_ov_legacy to set/clear ov32 when applicable. Signed-off-by: Víctor Colombo Reviewed-by: Daniel

[PULL 09/17] target/ppc: Zero second doubleword in DFP instructions

From: Víctor Colombo Starting at PowerISA v3.1, the second doubleword of the registers used to store results in DFP instructions are supposed to be zeroed. >From the ISA, chapter 7.2.1.1 Floating-Point Registers: """ Chapter 4. Floating-Point Facility provides 32 64-bit FPRs. Chapter 5. Decimal

[PATCH 5/5] migration: Use non-atomic ops for clear log bitmap

Since we already have bitmap_mutex to protect either the dirty bitmap or the clear log bitmap, we don't need atomic operations to set/clear/test on the clear log bitmap. Switching all ops from atomic to non-atomic versions, meanwhile touch up the comments to show which lock is in charge. Introduc

Re: [PATCH] checkpatch: ignore target/hexagon/imported/* files

On 20/9/22 15:42, Matheus Tavares Bernardino wrote: These files come from an external project (the hexagon archlib), so they deliberately do not follow QEMU's coding style. To avoid false positives from checkpatch.pl, let's disable the checking for those. Signed-off-by: Matheus Tavares Bernardin

[PULL 05/17] target/ppc: Move fsqrts to decodetree

From: Víctor Colombo Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson Message-Id: <20220905123746.54659-3-victor.colo...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/insn32.decode | 1 + target/ppc/translate/fp-impl.c.inc | 23 +

Re: [PATCH] qboot: update to latest submodule

On Tue, Sep 20, 2022 at 11:57:09PM +0200, Paolo Bonzini wrote: > It should have been automatic, there's mirroring set up. Hm, something is weird. Gitlab says "This project is mirrored from https://gitlab.com/bonzini/qboot.git. Pull mirroring updated 28 minutes ago." yet the commit is much older th

[PULL 07/17] target/ppc: Remove extra space from s128 field in ppc_vsr_t

From: Víctor Colombo Very trivial rogue space removal. There are two spaces between Int128 and s128 in ppc_vsr_t struct, where it should be only one. Signed-off-by: Víctor Colombo Reviewed-by: Daniel Henrique Barboza Message-Id: <20220906125523.38765-2-victor.colo...@eldorado.org.br> Signed-of

[PULL 01/17] target/ppc: Add HASHKEYR and HASHPKEYR SPRs

From: Víctor Colombo Add the Special Purpose Registers HASHKEYR and HASHPKEYR, which were introduced by the Power ISA 3.1B. They are used by the new instructions hashchk(p) and hashst(p). The ISA states that the Operating System should generate the value for these registers when creating a proce

[PULL 04/17] target/ppc: Move fsqrt to decodetree

From: Víctor Colombo Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson Message-Id: <20220905123746.54659-2-victor.colo...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/insn32.decode | 7 +++ target/ppc/translate/fp-impl.c.inc | 29 +++

[PULL 01/12] linux-user: Add missing signals in strace output

Some of the guest signal numbers are currently not converted to their representative names in the strace output, e.g. SIGVTALRM. This patch introduces a smart way to generate and keep in sync the host-to-guest and guest-to-host signal conversion tables for usage in the qemu signal and strace code.

[PULL 08/12] linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch

On the parisc architecture the stack grows upwards. Move the TASK_UNMAPPED_BASE to high memory area as it's done by the kernel on physical machines. Signed-off-by: Helge Deller --- linux-user/mmap.c | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/mmap.c b/linux-user/mmap.c ind

Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups

On Tue, Sep 20, 2022 at 02:25:48PM -0400, Stefan Hajnoczi wrote: > On Tue, 20 Sept 2022 at 10:18, Alex Bennée wrote: > > > > > > Stefan Hajnoczi writes: > > > > > [[PGP Signed Part:Undecided]] > > > On Fri, Sep 16, 2022 at 07:51:40AM +0100, Alex Bennée wrote: > > >> > > >> Alex Bennée writes: >

[PULL 10/12] linux-user: Show timespec on strace for futex()

Signed-off-by: Helge Deller --- linux-user/strace.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 6f818212d5..b6b9abaea4 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -3714,11 +3714,20 @@ print_futex

Re: [PATCH 2/4] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t

On Tue, 20 Sep 2022, Mark Cave-Ayland wrote: On 17/09/2022 23:27, Philippe Mathieu-Daudé via wrote: On 17/9/22 14:09, BALATON Zoltan wrote: On Sat, 17 Sep 2022, Mark Cave-Ayland wrote: There are already 32 feature bits in use, so change the size of the m68k CPU features to uint64_t (allong wi

Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups

On Tue, 20 Sept 2022 at 10:18, Alex Bennée wrote: > > > Stefan Hajnoczi writes: > > > [[PGP Signed Part:Undecided]] > > On Fri, Sep 16, 2022 at 07:51:40AM +0100, Alex Bennée wrote: > >> > >> Alex Bennée writes: > >> > >> > Hi, > >> > > >> > This is an update to the previous series which fixes th

Re: QEMU's FreeBSD 13 CI job is failing

On Tue, Sep 20, 2022 at 2:57 AM Daniel P. Berrangé wrote: > On Tue, Sep 20, 2022 at 10:23:56AM +0200, Thomas Huth wrote: > > On 20/09/2022 10.21, Daniel P. Berrangé wrote: > > > On Tue, Sep 20, 2022 at 08:44:27AM +0200, Thomas Huth wrote: > > > > > > > > Seen here for example: > > > > > > > > htt

[PULL 03/12] linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd() syscalls

I noticed those were missing when running the glib2.0 testsuite. Add the syscalls including the strace output. Signed-off-by: Helge Deller --- linux-user/strace.c| 28 linux-user/strace.list | 9 + linux-user/syscall.c | 34

[PULL 07/12] linux-user: Fix strace of chmod() if mode == 0

If the mode parameter of chmod() is zero, this value isn't shown when stracing a program: chmod("filename",) This patch fixes it up to show the zero-value as well: chmod("filename",000) Signed-off-by: Helge Deller --- linux-user/strace.c | 5 + 1 file changed, 5 insertions(+) diff -

Re: [Virtio-fs] [PATCH] virtiofsd: use g_date_time_get_microsecond to get subsecond

On Wed, Aug 24, 2022 at 01:41:29PM -0400, Stefan Hajnoczi wrote: > On Thu, Aug 18, 2022 at 02:46:19PM -0400, Yusuke Okada wrote: > > From: Yusuke Okada > > > > The "%f" specifier in g_date_time_format() is only available in glib > > 2.65.2 or later. If combined with older glib, the function retur

[PULL 14/17] target/ppc: Clear fpstatus flags on helpers missing it

From: Víctor Colombo In ppc emulation, exception flags are not cleared at the end of an instruction. Instead, the next instruction is responsible to clear it before its emulation. However, some helpers are not doing it, causing an issue where the previously set exception flags are being used and

[PATCH v2 37/37] target/i386: remove old SSE decoder

With all SSE (and AVX!) instructions now implemented in disas_insn_new, it's possible to remove gen_sse, as well as the helpers for instructions that now use gvec. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h| 124 --- target/i386/ops_sse_he

[PULL 06/17] target/ppc: Merge fsqrt and fsqrts helpers

From: Víctor Colombo These two helpers are almost identical, differing only by the softfloat operation it calls. Merge them into one using a macro. Also, take this opportunity to capitalize the helper name as we moved the instruction to decodetree in a previous patch. Signed-off-by: Víctor Colom

[PULL 00/17] ppc queue

The following changes since commit d29201ff34a135cdfc197f4413c1c5047e4f58bb: Merge tag 'pull-hmp-20220915a' of https://gitlab.com/dagrh/qemu into staging (2022-09-17 10:31:11 -0400) are available in the Git repository at: https://gitlab.com/danielhb/qemu.git tags/pull-ppc-2022092

[PULL 00/12] Publish1 patches

The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51: Update version for v7.1.0 release (2022-08-30 09:40:11 -0700) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git tags/publish1-pull-request for you to fetch changes up to 7f8674a61a908

[PATCH v2 35/37] tests/tcg: extend SSE tests to AVX

Extracted from a patch by Paul Brook . Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- tests/tcg/i386/Makefile.target | 2 +- tests/tcg/i386/test-avx.c | 201 ++--- tests/tcg/i386/test-avx.py | 5 +- 3 files changed, 113 insertions(+), 95

[PULL 14/30] tests/docker: flatten debian-powerpc-test-cross

Flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220914155950.804707-15-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/container-cross.yml b/.g

[PATCH v2 29/37] target/i386: reimplement 0x0f 0xc2, 0xc4-0xc6, add AVX

Nothing special going on here, for once. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.c.inc | 5 +++ target/i386/tcg/emit.c.inc | 75 target/i386/tcg/translate.c | 1 + 3 files changed, 81 insertions(+)

[PATCH v2 31/37] target/i386: reimplement 0x0f 0x28-0x2f, add AVX

Here the code is a bit uglier due to the truncation and extension of registers to and from 32-bit. There is also a mistake in the manual with respect to the size of the memory operand of CVTPS2PI and CVTTPS2PI, reported by Ricky Zhou. Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.

[PULL 05/12] linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info

Enhance the hppa linux-user cpu_loop() to show more debugging info on hard errors. Signed-off-by: Helge Deller --- linux-user/hppa/cpu_loop.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/hppa/cpu_loop.c b/linux-user/hppa/cpu_loop.c index 64263c3dc4..1ef3b46

Re: [PATCH] i386: Fix KVM_CAP_ADJUST_CLOCK capability check

On Tue, Sep 20, 2022 at 04:40:24PM +0200, Vitaly Kuznetsov wrote: > KVM commit c68dc1b577ea ("KVM: x86: Report host tsc and realtime values in > KVM_GET_CLOCK") broke migration of certain workloads, e.g. Win11 + WSL2 > guest reboots immediately after migration. KVM, however, is not to > blame this

  1   2   3   4   >