;
> +
> ret = virgl_renderer_init(g, flags, _gpu_3d_cbs);
> if (ret != 0) {
> error_report("virgl could not be initialized: %d", ret);
> diff --git a/subprojects/virglrenderer.wrap
> b/subprojects/virglrenderer.wrap
> new file mode 100644
> index 00..3656a478c4
> --- /dev/null
> +++ b/subprojects/virglrenderer.wrap
> @@ -0,0 +1,6 @@
> +[wrap-git]
> +url = https://gitlab.freedesktop.org/virgl/virglrenderer.git
> +revision = virglrenderer-1.0.1
> +
> +[provide]
> +virglrenderer = libvirglrenderer_dep
> --
> 2.39.2
>
>
>
--
Marc-André Lureau
d, 26 insertions(+), 18 deletions(-)
>
for the series:
Reviewed-by: Marc-André Lureau
Hi
On Wed, Jun 5, 2024 at 11:36 AM Gerd Hoffmann wrote:
>
> On Tue, Jun 04, 2024 at 10:27:18AM GMT, Marc-André Lureau wrote:
> > Hi
> >
> > > +if (is_buffer_shared(surface)) {
> >
> > Perhaps the suggestion to rename the function (in
Hi
On Wed, Jun 5, 2024 at 2:37 PM Marc-André Lureau
wrote:
> Hi
>
> On Tue, Jun 4, 2024 at 5:51 PM Daniel P. Berrangé
> wrote:
>
>> It is confusing having many different pieces of code enabling and
>> disabling commands, and it is not clear that they all have the sa
-qmp_for_each_command(_commands, ga_disable_not_allowed,
> config->allowedrpcs);
> -s->allowedrpcs = config->allowedrpcs;
> -}
> +ga_apply_command_filters(s);
>
> -/*
> - * Some commands can be blocked due to system limitation.
> - * Initialize blockedrpcs list even if allowedrpcs specified.
> - */
> -config->blockedrpcs =
> ga_command_init_blockedrpcs(config->blockedrpcs);
> -if (config->blockedrpcs) {
> -GList *l = config->blockedrpcs;
> -s->blockedrpcs = config->blockedrpcs;
> -do {
> -g_debug("disabling command: %s", (char *)l->data);
> -qmp_disable_command(_commands, l->data, NULL);
> -l = g_list_next(l);
> -} while (l);
> -}
> s->command_state = ga_command_state_new();
> ga_command_state_init(s, s->command_state);
> ga_command_state_init_all(s->command_state);
> --
> 2.45.1
>
>
>
--
Marc-André Lureau
> -const char *service;
> -#endif
> -gchar *bliststr; /* blockedrpcs may point to this string */
> -gchar *aliststr; /* allowedrpcs may point to this string */
> -GList *blockedrpcs;
> -GList *allowedrpcs;
> -int daemonize;
> -GLogLevelFlags log_level;
> -int dumpconf;
> -bool retry_path;
> -};
> -
> static void config_load(GAConfig *config)
> {
> GError *gerr = NULL;
> --
> 2.45.1
>
>
>
--
Marc-André Lureau
f FITRIM
> -#define CONFIG_FSTRIM
> -#endif
> #endif /* __linux__ */
>
> #ifdef __FreeBSD__
> #include
> -#ifdef UFSSUSPEND
> -#define CONFIG_FSFREEZE
> -#endif
> #endif /* __FreeBSD__ */
>
> #if defined(CONFIG_FSFREEZE) || defined(CONFIG_FSTRIM)
> --
> 2.45.1
>
>
>
--
Marc-André Lureau
Hi
On Tue, Jun 4, 2024 at 9:49 PM Kim, Dongwon wrote:
> On 6/4/2024 4:12 AM, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, May 30, 2024 at 2:44 AM > <mailto:dongwon@intel.com>> wrote:
> >
> > From: Dongwon mailto:dongwon@intel.com>
Hi
On Tue, Jun 4, 2024 at 9:59 PM Kim, Dongwon wrote:
> Hi Marc-André,
>
> On 6/4/2024 3:37 AM, Marc-André Lureau wrote:
> > Hi
> >
> > On Fri, May 31, 2024 at 11:00 PM > <mailto:dongwon@intel.com>> wrote:
> >
> > From: Dongwon Kim do
this
would be a nice cleanup too
> +break;
> +}
> +
> QTAILQ_REMOVE(>cmdq, cmd, next);
> if (virtio_gpu_stats_enabled(g->parent_obj.conf)) {
> g->stats.requests++;
> --
> 2.44.0
>
>
--
Marc-André Lureau
struct virtio_gpu_framebuffer *fb,
> + struct virtio_gpu_rect *r);
> +void virtio_gpu_disable_scanout(VirtIOGPU *g, int scanout_id);
> +
> /* virtio-gpu-3d.c */
> void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
>struct virtio_gpu_ctrl_command *cmd);
> diff --git a/meson.build b/meson.build
> index 65fddfbbc3a7..e753da4c76c3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2311,6 +2311,7 @@ config_host_data.set('CONFIG_VNC_SASL', sasl.found())
> if virgl.version().version_compare('>=1.0.0')
>config_host_data.set('HAVE_VIRGL_D3D_INFO_EXT', 1)
>config_host_data.set('HAVE_VIRGL_CONTEXT_CREATE_WITH_FLAGS', 1)
> + config_host_data.set('HAVE_VIRGL_RESOURCE_BLOB', 1)
>
Instead of accumulating various #define values, we could simply have
HAVE_VIRGL1 or something..
Alternatively, virgl.version().version_compare('>=1.0.1') and use #if
VIRGL_MAJOR_VERSION >= 1 in the code.
(the VIRGL_CHECK_VERSION macro is borked, it needs a 1.0.2 release)
--
Marc-André Lureau
OGPU *g);
> void virtio_gpu_virgl_reset_scanout(VirtIOGPU *g);
> void virtio_gpu_virgl_reset(VirtIOGPU *g);
> int virtio_gpu_virgl_init(VirtIOGPU *g);
> +void virtio_gpu_virgl_deinit(VirtIOGPU *g);
> int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g);
>
> #endif
> --
> 2.44.0
>
>
--
Marc-André Lureau
Error **errp);
> };
>
> +/* VirtIOGPUGL renderer states */
> +typedef enum {
> +RS_START, /* starting state */
> +RS_INIT_FAILED, /* failed initialisation */
> +RS_INITED, /* initialised and working */
> +RS_RESET, /* inited and reset pending, moves to start after
> reset */
> +} RenderState;
> +
> struct VirtIOGPUGL {
> struct VirtIOGPU parent_obj;
>
> -bool renderer_inited;
> -bool renderer_reset;
> +RenderState renderer_state;
>
> QEMUTimer *fence_poll;
> QEMUTimer *print_stats;
> --
> 2.44.0
>
>
--
Marc-André Lureau
Hi
On Thu, May 30, 2024 at 2:44 AM wrote:
> From: Dongwon
>
> Make sure rendering of the current frame is finished before switching
> the run state to RUN_STATE_SAVE_VM by waiting for egl-sync object to be
> signaled.
>
Can you expand on what this solves?
>
> Cc:
tors/outputs/connectors are
actually named, whether they are stable etc (not mentioning the
portability).
Window placement & geometry is a job for the compositor. Can you discuss
this issue with GTK devs & the compositor you are targeting?
--
Marc-André Lureau
Hi
On Mon, Jun 3, 2024 at 7:18 PM Gerd Hoffmann wrote:
>
> In case the display surface uses a shared buffer (i.e. uses vga vram
> directly instead of a shadow) go unshare the buffer before clearing it.
>
> This avoids vga memory corruption, which in turn fixes unblanking not
> working properly
On Tue, Jun 4, 2024 at 1:22 AM Octavian Purdila wrote:
>
> Add path option to the pty char backend which will create a symbolic
> link to the given path that points to the allocated PTY.
>
> This avoids having to make QMP or HMP monitor queries to find out what
> the new PTY device path is.
>
>
Neves
> Signed-off-by: Paulo Neves
> [OP: rebase and address original patch review comments]
> Signed-off-by: Octavian Purdila
Reviewed-by: Marc-André Lureau
> ---
> Changes since v1:
>
> * Keep the original Signed-off-by from Paulo and add one line
>
Hi
On Mon, Jun 3, 2024 at 3:51 PM Gerd Hoffmann wrote:
> On Mon, Jun 03, 2024 at 02:24:52PM GMT, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, May 30, 2024 at 3:05 PM Gerd Hoffmann wrote:
> >
> > > In case the display surface uses a shared buffer (i.e.
Hi
On Mon, Jun 3, 2024 at 4:23 PM Peter Maydell wrote:
>
> On Fri, 31 May 2024 at 22:21, Octavian Purdila wrote:
> >
> > Add path option to the pty char backend which will create a symbolic
> > link to the given path that points to the allocated PTY.
> >
> > Based on patch from Paulo Neves:
> >
+``-chardev pty,id=id[,path=path]``
> Create a new pseudo-terminal on the host and connect to it. ``pty``
> does not take any options.
>
> ``pty`` is not available on Windows hosts.
>
> +``path`` specifies the symbolic link path to be created that
> +points to the pty device.
> +
> +
> ``-chardev stdio,id=id[,signal=on|off]``
> Connect to standard input and standard output of the QEMU process.
>
> @@ -4171,8 +4175,10 @@ SRST
>
> vc:80Cx24C
>
> -``pty``
> -[Linux only] Pseudo TTY (a new PTY is automatically allocated)
> +``pty[:path]``
> +[Linux only] Pseudo TTY (a new PTY is automatically allocated).
> +Optionally a path can be given to create a symbolic link to
> +the allocated PTY.
>
> ``none``
> No device is allocated. Note that for machine types which
> --
> 2.45.1.288.g0e0cd299f1-goog
>
>
>
thanks
--
Marc-André Lureau
(surface);
> d = surface_data(surface);
> for(i = 0; i < s->last_scr_height; i++) {
> --
> 2.45.1
>
>
>
thanks
--
Marc-André Lureau
Hi
On Wed, May 15, 2024 at 2:29 PM Michael Tokarev wrote:
>
> 14.05.2024 16:17, marcandre.lur...@redhat.com wrote:
> >
> > UI: small fixes and improvements
> >
> >
>
Hi
On Tue, May 14, 2024 at 8:35 AM Peter Xu wrote:
>
> Hey, Marc-Andre,
>
> On Mon, May 13, 2024 at 11:19:04AM +0400, marcandre.lur...@redhat.com wrote:
> > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> > index ae831b6b3e..7f9fb5eacc 100644
> > --- a/hw/display/virtio-gpu.c
>
Hi Fiona
On Mon, May 13, 2024 at 4:56 PM Fiona Ebner wrote:
>
> Hi,
>
> Am 13.05.24 um 09:19 schrieb marcandre.lur...@redhat.com:
> > From: Marc-André Lureau
> >
> > Hi,
> >
> > The aforementioned patch breaks virtio-gpu device migrations f
ll charger. Fix that
> by
> enabling the screen saver.
>
> Signed-off-by: Bernhard Beschow
Acked-by: Marc-André Lureau
> ---
> ui/sdl2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index 4971963f00..0a0eb5a42d 100644
> ---
y - my) / vc->gfx.scale_y * ws;
> +/*
> + * `motion` is reported in `widget` coordinates
> + * so translating it to the coordinates in `vc`.
> + */
> +x = (motion->x - mx) / vc->gfx.scale_x;
> +y = (motion->y - my) / vc->gfx.scale_y;
>
> trace_gd_motion_event(ww, wh, gtk_widget_get_scale_factor(widget), x, y);
>
> --
> 2.39.2
>
>
--
Marc-André Lureau
On Sun, May 12, 2024 at 3:16 PM hikalium wrote:
>
> Add gd_motion_event trace event for making it easy to debug
> gd_motion_event related issues.
>
> Signed-off-by: hikalium
Acked-by: Marc-André Lureau
> ---
> ui/gtk.c| 2 ++
> ui/trace-events | 1 +
> 2
Hi Peter
On Fri, May 10, 2024 at 9:33 PM Peter Xu wrote:
>
> Hi, Marc-André,
>
> On Fri, May 10, 2024 at 12:39:34PM +0400, Marc-André Lureau wrote:
> > Since we don't have per VMSD version information on the wire, nested
> > struct versioning is quite limited and c
g, and
> accessing individual fields within the struct and replacing all direct
> references to individual fields in the struct with methods using helpers
> throughout the codebase.
>
> This change was made based on a suggestion from Marc-André Lureau
>
>
> (Resumitting same patc
Hi Michael
On Fri, May 10, 2024 at 2:26 PM Michael S. Tsirkin wrote:
>
> On Tue, May 07, 2024 at 03:19:19PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Depending on the version, use v1 or v2 of the scanout VM state.
> >
> &
Hi
On Wed, May 8, 2024 at 12:01 AM Peter Xu wrote:
>
> On Tue, May 07, 2024 at 03:19:19PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Depending on the version, use v1 or v2 of the scanout VM state.
> >
> > Signed-off-by
PI.
(you can also share other things like D3D textures etc. those
mechanisms are used to enable -display dbus on Windows efficiently)
--
Marc-André Lureau
t
> do it.
>
> --- 'dmabuf' is now allocated space so it should be freed at the end of
> dbus_scanout_texture
>
> v13: --- Immediately free dmabuf after it is released to prevent possible
> leaking of the ptr
> (Marc-André Lureau )
>
> --
RM capsets. Register capsets dynamically to avoid that
> problem.
>
> Signed-off-by: Pierre-Eric Pelloux-Prayer
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Marc-André Lureau
> ---
> hw/display/virtio-gpu-gl.c | 6 --
> hw/display/virtio-gpu-virgl.c | 33 +
by: Antonio Caggiano
> Signed-off-by: Dmitry Osipenko
Acked-by: Marc-André Lureau
> ---
> hw/display/virtio-gpu-virgl.c | 109 +
> hw/display/virtio-gpu.c| 12 ++--
> include/hw/virtio/virtio-gpu.h | 7 +++
> meson.build
at will be contain
> fields specific to virgl.
>
> Signed-off-by: Huang Rui
> Reviewed-by: Antonio Caggiano
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Marc-André Lureau
> ---
> hw/display/virtio-gpu-virgl.c | 74 +++
> 1 file cha
son.build
> +++ b/meson.build
> @@ -2288,6 +2288,7 @@ config_host_data.set('CONFIG_VNC_JPEG', jpeg.found())
> config_host_data.set('CONFIG_VNC_SASL', sasl.found())
> if virgl.version().version_compare('>=1.0.0')
>config_host_data.set('HAVE_VIRGL_D3D_INFO_EXT', 1)
> + config_host_data.set('HAVE_VIRGL_CONTEXT_CREATE_WITH_FLAGS', 1)
> endif
> config_host_data.set('CONFIG_VIRTFS', have_virtfs)
> config_host_data.set('CONFIG_VTE', vte.found())
> --
> 2.44.0
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Hi
On Tue, May 7, 2024 at 7:18 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Sun, May 5, 2024 at 12:29 AM Dmitry Osipenko
> wrote:
> >
> > New virglrerenderer features were stabilized with release of v1.0.0.
> > Presence of symbols in virglrenderer.h doesn't guarant
t('CONFIG_VIRTFS', have_virtfs)
> config_host_data.set('CONFIG_VTE', vte.found())
> --
> 2.44.0
>
--
Marc-André Lureau
/virtio-gpu.h
> +++ b/include/hw/virtio/virtio-gpu.h
> @@ -336,6 +336,7 @@ void virtio_gpu_virgl_fence_poll(VirtIOGPU *g);
> void virtio_gpu_virgl_reset_scanout(VirtIOGPU *g);
> void virtio_gpu_virgl_reset(VirtIOGPU *g);
> int virtio_gpu_virgl_init(VirtIOGPU *g);
> +void virtio_gpu_virgl_deinit(VirtIOGPU *g);
> int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g);
>
> #endif
> --
> 2.44.0
>
otherwise:
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
should cause a window size reconfiguration
- the window size != display size
thanks
> Cc: Gerd Hoffmann
> Cc: Marc-André Lureau
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
> ui/gtk.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
e window is currently in inactive state
> (minimized or tabified). If draw is not done for a long time,
> gl_block timeout and/or fence timeout (on the guest) will happen
> eventually.
>
> v2: Use gd_gl_area_draw(vc) in gtk-gl-area.c
>
> Suggested-by: Vivek Kasireddy
> Cc:
Hi
On Wed, Apr 3, 2024 at 9:51 AM Justinien Bouron
wrote:
>
> Depending on your use-case, it might be inconvenient to have qemu grab
> the input device from the host immediately upon starting the guest.
>
> Added a new bool option to input-linux: grab-on-startup. If true, the
> device is grabbed
On Thu, Apr 25, 2024 at 5:58 AM wrote:
>
> From: Dongwon Kim
>
> To complete privatizing process of QemuDmaBuf, QemuDmaBuf struct def
> is moved to dmabuf.c
>
> Suggested-by: Marc-André Lureau
> Cc: Philippe Mathieu-Daudé
> Cc: Daniel P. Berrangé
> Cc:
t
> do it.
>
> --- 'dmabuf' is now allocated space so it should be freed at the end of
> dbus_scanout_texture
>
> Suggested-by: Marc-André Lureau
> Cc: Philippe Mathieu-Daudé
> Cc: Daniel P. Berrangé
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> -
ction of helpers was removed as those were already added
> by the previous commit
>
> Suggested-by: Marc-André Lureau
Reviewed-by: Marc-André Lureau
> Cc: Philippe Mathieu-Daudé
> Cc: Daniel P. Berrangé
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
>
et qemu_dmabuf_fee to call qemu_dmabuf_close before freeing
> the struct to make sure fd is closed.
> (Daniel P. Berrangé )
>
> v12: Not closing fd in qemu_dmabuf_free because there are cases fd
> should still be available even after the struct is destroyed
> (
Hi
On Tue, Apr 30, 2024 at 4:31 PM Fiona Ebner wrote:
>
> Am 12.03.24 um 15:02 schrieb marcandre.lur...@redhat.com:
> > From: Marc-André Lureau
> >
> > The current post-loading code for scanout has a FIXME: it doesn't take
> > the resource region/rect into ac
mabuf_get_... helpers to extract
> > > specific fields from the QemuDmaBuf struct. It also updates all
> > > instances where fields within the QemuDmaBuf struct are directly
> > > accessed, replacing them with calls to these new helper functions.
> > >
> >
> Suggested-by: Marc-André Lureau
> Cc: Philippe Mathieu-Daudé
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
> include/hw/vfio/vfio-common.h | 2 +-
> include/hw/virtio/virtio-gpu.h | 4 ++--
> include/ui/console.h| 8 +++
ccessed, replacing
> them with calls to these new helper functions.
>
> v6: fix typos in helper names in ui/spice-display.c
>
> Suggested-by: Marc-André Lureau
> Cc: Philippe Mathieu-Daudé
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
> include/ui/console.h
ccessed, replacing
> them with calls to these new helper functions.
>
> Suggested-by: Marc-André Lureau
> Cc: Philippe Mathieu-Daudé
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
> include/ui/console.h| 17 +
> hw/display/vhost-user-gpu.c
Hi Irina
On Mon, Mar 25, 2024 at 10:44 AM Marc-André Lureau
wrote:
>
> Hi
>
> On Sun, Mar 24, 2024 at 7:23 PM Irina Ryapolova
> wrote:
> >
> > After exit Qemu need to return the terminal to the default state.
> >
> > Signed-off-by: Irina Ryapolova
&g
Hi
On Tue, Apr 16, 2024 at 1:00 AM Kim, Dongwon wrote:
>
> Hi Marc-André,
>
> > -Original Message-
> > From: marcandre.lur...@redhat.com
> > Sent: Monday, April 15, 2024 4:16 AM
> > To: qemu-devel@nongnu.org
> > Cc: Kim, Dongwon ; dbas...@redhat.
fic fields from the QemuDmaBuf struct. It also updates all instances
> where fields within the QemuDmaBuf struct are directly accessed, replacing
> them with calls to these new helper functions.
>
> Suggested-by: Marc-André Lureau
> Cc: Philippe Mathieu-Daudé
> Cc: Vivek Kasire
> [-Wdeprecated-declarations]
> sprintf(response, "\033[%d;%dR",
> ^
> 1 warning generated.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> ui/console-vc.c | 2 +-
> 1 file change
f(3) instead.
> [-Wdeprecated-declarations]
> sprintf(response, "\033[%d;%dR",
> ^
> 1 warning generated.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> ui/console-vc.c | 4 ++--
> 1 fil
Hi
On Wed, Apr 10, 2024 at 2:06 PM ゞlym <707242...@qq.com> wrote:
>
>
Please send the patch as inline:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#do-not-send-as-an-attachment
The patch is doing too much changes to the ssd.lock usage without
explaining in detail which race
Hi
On Wed, Apr 3, 2024 at 12:31 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> On 03.04.24 11:11, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Apr 2, 2024 at 11:24 PM Vladimir Sementsov-Ogievskiy
> > wrote:
> >>
> >> On 02.04.24 18:34, Eric Blake
#define WITH_GRAPH_RDLOCK_GUARD() \
-WITH_GRAPH_RDLOCK_GUARD_(glue(graph_lockable_auto, __COUNTER__))
+WITH_GRAPH_RDLOCK_GUARD_(glue(graph_lockable_auto, __COUNTER__),
glue(graph_lockable_auto, __COUNTER__))
Unfortunately, it doesn't work in all cases. It seems to have issues
with some guards:
../block/stream.c: In function ‘stream_run’:
../block/stream.c:216:12: error: ‘ret’ may be used uninitialized
[-Werror=maybe-uninitialized]
216 | if (ret < 0) {
What should we do? change the macros + cherry-pick the missing
false-positives, or keep this series as is?
--
Marc-André Lureau
Hi
On Thu, Mar 28, 2024 at 3:31 PM Philippe Mathieu-Daudé
wrote:
>
> On 28/3/24 11:20, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > ../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized
> > [-Werror=maybe-uninitialized]
&
Hi
On Fri, Mar 29, 2024 at 12:35 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> On 28.03.24 13:20, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > ../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized
> > [-Werror=may
errors
They are about 20, probably false-positives, although it's
understandable the compiler is confused as I am too sometime!
Is it a known issue? Are we willing to help the compiler in all those
optimization levels? I can send a patch series for review in this
case.
thanks
--
Marc-André Lureau
= INVALID_HANDLE_VALUE) {
> TerminateThread(stdio->hInputThread, 0);
> }
> +
> +GetConsoleMode(stdio->hStdIn, );
> +dwMode &= ~ENABLE_VIRTUAL_TERMINAL_INPUT;
> +SetConsoleMode(stdio->hStdIn, dwMode);
I'd suggest saving the mode when opening instead, to make sure we
restore the same value.
thanks
--
Marc-André Lureau
accessed directly.
If we want to make the whole structure private, we will probably need setters.
I don't see why the function should silently return 0 when given NULL.
Imho an assert(dmabuf != NULL) is appropriate (or
g_return_val_if_fail).
> Cc: Philippe Mathieu-Daudé
> Cc: Marc-A
e Mathieu-Daudé
> Cc: Marc-André Lureau
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
> include/ui/console.h | 1 +
> hw/vfio/display.c| 8 +++-
> ui/console.c | 9 +
> 3 files changed, 17 insertions(+), 1 deletion(-)
>
> diff
heir
> own.
>
> Cc: Philippe Mathieu-Daudé
> Cc: Marc-André Lureau
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
> include/hw/vfio/vfio-common.h | 2 +-
> include/hw/virtio/virtio-gpu.h | 4 ++--
> include/ui/console.h|
ng, Error **errp)
> +{
There is g_utf8_to_utf16() which can be cast to wchar_t, iirc, that's
how glib converts string for w32 api
--
Marc-André Lureau
Hi
On Wed, Mar 20, 2024 at 7:20 AM Akihiko Odaki wrote:
>
> On 2024/03/19 17:29, Marc-André Lureau wrote:
> > Hi Akihiko
> >
> > On Tue, Mar 19, 2024 at 7:09 AM Akihiko Odaki
> > wrote:
> >>
> >> ui/console has a concept of "active"
quot;active" console state from ui/console.
> curses, cocoa, and vnc will hold the reference to the console currently
> shown with DisplayListener::con. This also eliminates the need to
> replace NULL with the active console and save code.
>
> Signed-off-by: Akihiko Odaki
lgtm
R
01,10 +133,23 @@ GSource *io_add_watch_poll(Chardev *chr,
> return (GSource *)iwp;
> }
>
> +static void io_remove_watch_poll(GSource *source)
> +{
> +IOWatchPoll *iwp;
> +
> +iwp = io_watch_poll_from_source(source);
> +if (iwp->src) {
> +g_source_destroy(iwp->src);
> +g_source_unref(iwp->src);
> +iwp->src = NULL;
> +}
> +g_source_destroy(>parent);
> +}
> +
> void remove_fd_in_watch(Chardev *chr)
> {
> if (chr->gsource) {
> -g_source_destroy(chr->gsource);
> +io_remove_watch_poll(chr->gsource);
> chr->gsource = NULL;
> }
> }
> --
> 2.43.0
>
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
2 GSource objects. This can be achieved by lowering the
> priority of the HUP GSource, so that it is never dispatched if the
> main GSource is also ready to dispatch. Counter-intuitively, lowering
> the priority of a GSource is done by raising its priority number.
>
> Signed-off-by: Da
Hi
On Mon, Mar 18, 2024 at 10:23 PM Daniel P. Berrangé wrote:
>
> This commit results in unexpected termination of the TLS connection.
> When 'fd_can_read' returns 0, the code goes on to pass a zero length
> buffer to qio_channel_read. The TLS impl calls into gnutls_recv()
> with this zero
Hi
On Mon, Mar 18, 2024 at 1:05 PM Akihiko Odaki wrote:
>
> On 2024/03/18 17:21, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Mar 18, 2024 at 11:58 AM Akihiko Odaki
> > wrote:
> >>
> >> console_select() is shared by other displays and a cons
> +vs->vd->dcl.con = con;
> +register_displaychangelistener(>vd->dcl);
> +}
> return;
> }
> default:
> @@ -4206,7 +4210,7 @@ void vnc_display_open(const char *id, Error **errp)
> goto fail;
> }
> } else {
> -con = NULL;
> +con = qemu_console_lookup_first_graphic_console();
why this change here?
otherwise, lgtm
> }
>
> if (con != vd->dcl.con) {
>
> --
> 2.44.0
>
>
--
Marc-André Lureau
has no content at the time, so it will have the size of graphic
> console placeholder, which contains no useful information. It's better
> to have the standard size of text console instead.
>
> Signed-off-by: Akihiko Odaki
Reviewed-by: Marc-André Lureau
> ---
> ui/console-v
dbus_display1[0])
+ dbus_display1_dep = declare_dependency(sources: dbus_display1,
dependencies: gio)
This makes commit 186acfbaf7 ("tests/qtest: Depend on
dbus_display1_dep") no longer relevant, as dbus-display1.c will be
recompiled.
Alternatively, we could always build with pic: true (or pic:
enable_modules), but that's not ideal either.
--
Marc-André Lureau
Hi Justinien
On Fri, Mar 15, 2024 at 6:37 AM Justinien Bouron
wrote:
>
> Just a ping to make sure this patch hasn't been lost in the noise.
> Any chance to get this merged? Should I send a v2 with a revised commit
> message?
>
It's too late for 9.0. Please send a v2 with updated commit
U_CHAR_FEATURE_REPLAY);
> -}
> -if (qemu_chr_replay(chr) && CHARDEV_GET_CLASS(chr)->chr_ioctl) {
> -error_report("Replay: ioctl is not supported "
> - "for serial devices yet");
> -}
> -replay_register_char_driver(chr);
> -}
> -return chr;
> +return __qemu_chr_new(label, filename, permit_mux_mon, context, true);
> }
>
> Chardev *qemu_chr_new(const char *label, const char *filename,
> --
> 2.42.0
>
>
It's probably too late for 9.0, splitting the patch and preliminary
cleanup should really help reviewing the change and pointing out the
behaviour differences.
thanks
--
Marc-André Lureau
't fix it, can you apply your solution
on top of it?
thanks
> Cc: Marc-André Lureau
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
> ---
> hw/display/virtio-gpu.c | 21 ++---
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/h
d before flushing
> the pipeline
>
> v3: Prevent redundant call of gd_hw_gl_flushed by checking dmabuf
> and fence_fd >= 0 in it (e.g. during and after eglClientWaitSync
> in gd_change_runstate).
>
> Destroy sync object later in gd_hw_fl_flushed
>
> Cc:
Hi
On Fri, Mar 8, 2024 at 4:59 AM Kim, Dongwon wrote:
>
> Hi Marc-André,
>
> > -Original Message-
> > From: Marc-André Lureau
> > Sent: Tuesday, March 5, 2024 4:18 AM
> > To: Kim, Dongwon ; P. Berrange, Daniel
> >
> > Cc: qemu-devel@n
Hi Dongwon Kim
On Wed, Mar 6, 2024 at 2:24 AM wrote:
>
> From: Dongwon Kim
>
> The guest surface needs to be updated with a blob scanout after resumed
> from saved vm state if blob is enabled.
>
> Cc: Marc-André Lureau
> Cc: Vivek Kasireddy
> Signed-off-by: Dongw
>
> qemu-system-x86_64: -mon chardev=chr0: chardev 'chr0' is already in use
>
> Signed-off-by: Markus Armbruster
lgtm
Reviewed-by: Marc-André Lureau
> ---
> chardev/char-fe.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/char
Hi Dongwon Kim
On Thu, Dec 14, 2023 at 8:26 AM Dongwon Kim wrote:
>
> The guest surface needs to be updated with a blob scanout after resumed
> from saved vm state if blob is enabled.
>
> Cc: Marc-André Lureau
> Cc: Vivek Kasireddy
> Signed-off-by: Dongwon Kim
Can you re
esponsible)
Daniel, could you have a look too?
thanks
On Fri, Mar 1, 2024 at 4:05 AM Kim, Dongwon wrote:
>
> Hi Marc-André Lureau,
>
> Just a reminder.. I need your help reviewing this patch series. Please take a
> look at my messages at
> https://lists.gnu.org/archive/html/qemu
/channel-tls: fix handling of bigger read buffers")
> Buglink: https://issues.redhat.com/browse/RHEL-24614
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Thomas Huth
Reviewed-by: Marc-André Lureau
> ---
> Sorry if you've got this mail twice - I forgot to CC: qemu-devel
ly set a
"transparent" cursor, which we don't detect. Maybe we should also have
some check for this case to implement that "show-cursor" behaviour in
that case too.
> parameter, thereby hiding the cursor. Once Windows VM switches back to
> the HW cursor, then IDD would again prov
Hi
On Tue, Feb 27, 2024 at 4:38 PM Andrey Drobyshev
wrote:
>
>
>
> On 2/26/24 20:50, Konstantin Kostiuk wrote:
> >
> > Best Regards,
> > Konstantin Kostiuk.
> >
> >
> > On Mon, Feb 26, 2024 at 7:02 PM Andrey Drobyshev
> > mailto:andrey.drobys...@virtuozzo.com>>
> > wrote:
> >
> > Since the
On Mon, Feb 26, 2024 at 12:28 PM Thomas Huth wrote:
>
> test-util-sockets leaves the temporary socket files around in the
> temporary files folder. Let's better remove them at the end of the
> testing.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Marc-André Lureau
> ---
&g
Hi
On Mon, Feb 19, 2024 at 4:39 PM Thomas Huth wrote:
>
> When compiling with "configure --without-default-devices", the
> dbus-display-test fails since it implicitly assumes that the
> machine comes with the standard VGA card. Thus add a check to
> meson.build to disable the test if the VGA
| 2 +-
> ui/meson.build| 18 --
> 9 files changed, 28 insertions(+), 23 deletions(-)
> ---
> base-commit: 4705fc0c8511d073bee4751c3c974aab2b10a970
> change-id: 20231215-dbus-86876ecb7b09
>
> Best regards,
> --
> Akihiko Odaki
>
>
--
Marc-André Lureau
Hi
On Tue, Feb 6, 2024 at 6:06 PM wrote:
>
> From: Marc-André Lureau
>
> Fixes:
>rm -rf b; cd b
> ../configure --enable-modules --target-list=x86_64-softmmu
> ninja qemu-system-x86_64
>
>In file included from ../ui/dbus-chardev.c:34:
> ../ui/dbus
ly nice for things that are really common, but in this
case I don't think it's a win.
>
> Signed-off-by: Akihiko Odaki
> ---
> I found it was failing to build dbus modules when --enable-dbus so here
> are fixes.
> ---
> Changes in v6:
> - Dropped patch "aud
Hi
On Tue, Feb 13, 2024 at 5:58 PM Markus Armbruster wrote:
>
> Markus Armbruster writes:
>
> > The __linux__ version of qemu_chr_open_pp_fd() tries to claim the
> > parport device with a PPCLAIM ioctl(). On success, it stores the file
> > descriptor in the chardev object, and returns success.
p; !is_buffer_shared(surface) &&
> !is_placeholder(surface))) &&
> qemu_console_get_width(s, -1) == width &&
> qemu_console_get_height(s, -1) == height) {
> return;
> --
> 2.38.1.windows.1
>
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Hi Michael
On Sat, Feb 3, 2024 at 5:41 PM Michael Tokarev wrote:
>
> Doing a build of just a single target with --enable modules results in build
> error:
>
>
> rm -rf b; cd b
> ../configure --enable-modules --target-list=x86_64-softmmu
> ninja qemu-system-x86_64
>
>In file included
l
> qapi/char: Deprecate backend type "memory"
Reviewed-by: Marc-André Lureau
>
> docs/about/deprecated.rst | 8
> qapi/char.json| 28 +---
> include/qemu/osdep.h | 9 -
> chardev/char-parallel.c |
age(nb, page);
> > > gtk_widget_grab_focus(vc->focus);
> > > +vc->gfx.visible = true;
> > > }
> > > }
> > >
> > > @@ -1350,6 +1355,7 @@ static gboolean gd_tab_window_close(GtkWidget
> > *widget, GdkEvent *event,
> > > VirtualConsole *vc = opaque;
> > > GtkDisplayState *s = vc->s;
> > >
> > > +vc->gfx.visible = false;
> > > gtk_widget_set_sensitive(vc->menu_item, true);
> > > gd_widget_reparent(vc->window, s->notebook, vc->tab_item);
> > > gtk_notebook_set_tab_label_text(GTK_NOTEBOOK(s->notebook),
> > > @@ -1423,6 +1429,7 @@ static void gd_menu_untabify(GtkMenuItem *item,
> > void *opaque)
> > > gd_update_geometry_hints(vc);
> > > gd_update_caption(s);
> > > }
> > > +vc->gfx.visible = true;
> > > }
> > >
> > > static void gd_menu_show_menubar(GtkMenuItem *item, void *opaque)
> > @@
> > > -2471,6 +2478,7 @@ static void gtk_display_init(DisplayState *ds,
> > > DisplayOptions *opts) #ifdef CONFIG_GTK_CLIPBOARD
> > > gd_clipboard_init(s);
> > > #endif /* CONFIG_GTK_CLIPBOARD */
> > > +vc->gfx.visible = true;
> > > }
> > >
> > > static void early_gtk_display_init(DisplayOptions *opts)
> > > --
> > > 2.34.1
> > >
> > >
> >
> >
> > --
> > Marc-André Lureau
--
Marc-André Lureau
1 - 100 of 9087 matches
Mail list logo
