Re: [PATCH 0/2] i386/sev: Two trivial improvements to sev_get_capabilities()

On 6/24/24 10:52, Michal Privoznik wrote: > I've noticed that recent QEMU + libvirt (current HEADs, roughly) behave > a bit different than expected. The problem is in recent change to > 'query-sev-capabilities' command (well, sev_get_capabilities() in fact) > which libvirt uses (see patch 2/2).

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

On 6/3/24 10:50, Akihiko Odaki wrote: > On 2024/06/03 16:56, Michal Prívozník wrote: >> On 6/2/24 08:26, Akihiko Odaki wrote: >>> On 2024/06/01 0:46, Philippe Mathieu-Daudé wrote: >>>> On 31/5/24 17:10, Michal Privoznik wrote: >>>>> The unspoken p

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

On 6/2/24 08:26, Akihiko Odaki wrote: > On 2024/06/01 0:46, Philippe Mathieu-Daudé wrote: >> On 31/5/24 17:10, Michal Privoznik wrote: >>> The unspoken premise of qemu_madvise() is that errno is set on >>> error. And it is mostly the case except for posix_madvise() which >>> is documented to

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

On 5/31/24 17:46, Philippe Mathieu-Daudé wrote: > On 31/5/24 17:10, Michal Privoznik wrote: >> The unspoken premise of qemu_madvise() is that errno is set on >> error. And it is mostly the case except for posix_madvise() which >> is documented to return either zero (on success) or a positive >>

Re: [PATCH v2 1/4] osdep: Make qemu_madvise() to set errno in all cases

On 5/31/24 11:08, David Hildenbrand wrote: > On 31.05.24 10:12, Philippe Mathieu-Daudé wrote: >> On 31/5/24 10:01, David Hildenbrand wrote: >>> On 31.05.24 09:57, Philippe Mathieu-Daudé wrote: Hi Michal, On 31/5/24 09:28, Michal Privoznik wrote: > The unspoken premise of

Re: [PATCH 3/3] backends/hostmem: Round up memory size for qemu_madvise() and mbind()

On 5/28/24 18:47, David Hildenbrand wrote: > Am 28.05.24 um 18:15 schrieb Michal Privoznik: >> ./build/qemu-system-x86_64 \ -m >> size=8389632k,slots=16,maxmem=2560k \ -object >>

Re: [PATCH] qga: Add an interactive mode to guest-exec via VSOCK for Linux

On 5/22/24 17:06, Alexander Ivanov wrote: > Add an interactive mode to the guest-exec command in the QEMU Guest Agent > using the VSOCK communication mechanism. It enables interactive sessions > with the executed command in the guest, allowing real-time input/output. > > Introduce "interactive"

Re: [PATCH] hostmem: Round up memory size for qemu_madvise() in host_memory_backend_memory_complete()

On 12/4/23 10:21, David Hildenbrand wrote: > On 01.12.23 10:07, Michal Prívozník wrote: >> On 11/27/23 14:55, David Hildenbrand wrote: >>> On 27.11.23 14:37, David Hildenbrand wrote: >>>> On 27.11.23 13:32, Michal Privoznik wrote: >>>>> Simple rep

Re: [PATCH] hostmem: Round up memory size for qemu_madvise() in host_memory_backend_memory_complete()

On 11/27/23 14:55, David Hildenbrand wrote: > On 27.11.23 14:37, David Hildenbrand wrote: >> On 27.11.23 13:32, Michal Privoznik wrote: >>> Simple reproducer: >>> qemu.git $ ./build/qemu-system-x86_64 \ >>> -m size=8389632k,slots=16,maxmem=2560k \ >>> -object >>>

Re: [PATCH v2 00/10] meson: replace submodules with wrap files

On 6/7/23 09:47, Daniel P. Berrangé wrote: > On Wed, Jun 07, 2023 at 09:41:40AM +0200, Michal Prívozník wrote: >> On 6/5/23 11:52, Paolo Bonzini wrote: >>> This series replaces git submodules for bundled libraries with .wrap >>> files that can be used direct

Re: [PATCH v2 00/10] meson: replace submodules with wrap files

On 6/5/23 11:52, Paolo Bonzini wrote: > This series replaces git submodules for bundled libraries with .wrap > files that can be used directly by meson for subprojects. Pardon my lack of knowledge, but even after I clone new repo and run: ./configure --enable-donwload && make && make test I

Re: [RFC 0/3] virtio-blk: add iothread-vq-mapping parameter

On 1/18/23 20:47, Stefan Hajnoczi wrote: > This is a preview of the iothread-vq-mapping parameter that assigns virtqueues > to IOThreads. The syntax is implemented but multiple IOThreads are not > actually > supported yet. The purpose of this RFC is to reach agreement on the syntax and > to

Re: [PATCH 0/3] util/userfaultfd: Support /dev/userfaultfd

On 1/31/23 22:01, Peter Xu wrote: > I'll wait 1-2 more days to see whether Michal has anything to comment. Yeah, we can go with your patches and leave FD passing for future work. It's orthogonal after all. In the end we can have (in the order of precedence): 1) new cmd line argument, say:

Re: [PATCH 0/3] util/userfaultfd: Support /dev/userfaultfd

On 1/26/23 16:25, Peter Xu wrote: > On Thu, Jan 26, 2023 at 02:15:11PM +, Dr. David Alan Gilbert wrote: >> * Michal Prívozník (mpriv...@redhat.com) wrote: >>> On 1/25/23 23:40, Peter Xu wrote: >>>> The new /dev/userfaultfd handle is superior to the system call

Re: [PATCH 0/3] util/userfaultfd: Support /dev/userfaultfd

On 1/25/23 23:40, Peter Xu wrote: > The new /dev/userfaultfd handle is superior to the system call with a > better permission control and also works for a restricted seccomp > environment. > > The new device was only introduced in v6.1 so we need a header update. > > Please have a look, thanks.

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

On 12/19/22 10:58, David Hildenbrand wrote: > > I'll fixup. I just queued the fixed-up patch to > > https://github.com/davidhildenbrand/qemu.git mem-next > > Please double-check. Thanks! > Looks good. Sorry for not doing it properly the first time. Michal

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

On 12/19/22 10:55, David Hildenbrand wrote: > On 16.12.22 14:47, Michal Prívozník wrote: >> On 12/16/22 14:41, David Hildenbrand wrote: >>> On 15.12.22 10:55, Michal Privoznik wrote: >>>> If a memory-backend is configured with mode

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

On 12/16/22 14:41, David Hildenbrand wrote: > On 15.12.22 10:55, Michal Privoznik wrote: >> If a memory-backend is configured with mode >> HOST_MEM_POLICY_PREFERRED then >> host_memory_backend_memory_complete() calls mbind() as: >> >>    mbind(..., MPOL_PREFERRED, nodemask, ...); >> >> Here,

Re: [PATCH v2] seccomp: Get actual errno value from failed seccomp functions

On 10/26/22 14:33, Daniel P. Berrangé wrote: > On Wed, Oct 26, 2022 at 09:30:24AM +0200, Michal Privoznik wrote: >> Upon failure, a libseccomp API returns actual errno value very >> rarely. Fortunately, after its commit 34bf78ab (contained in >> 2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC

Re: [PATCH] configure: Avoid using strings binary

On 10/13/22 12:39, Peter Maydell wrote: > On Thu, 13 Oct 2022 at 09:47, Michal Privoznik wrote: >> >> When determining the endiandness of the target architecture we're >> building for a small program is compiled, which in an obfuscated >> way declares two strings. Then, we look which string is in

Re: [PATCH] configure: Avoid using strings binary

On 10/13/22 10:37, Michal Privoznik wrote: > When determining the endiandness of the target architecture we're > building for a small program is compiled, which in an obfuscated > way declares two strings. Then, we look which string is in > correct order (using strings binary) and deduct the

Re: [PATCH RFC 0/7] hostmem: NUMA-aware memory preallocation using ThreadContext

On 9/21/22 16:54, David Hildenbrand wrote: > On 21.09.22 16:44, Michal Prívozník wrote: >> On 7/21/22 14:07, David Hildenbrand wrote: >>> >> >> Ping? Is there any plan how to move forward? I have libvirt patches >> ready to consume this and I'd like to prune m

Re: [PATCH RFC 0/7] hostmem: NUMA-aware memory preallocation using ThreadContext

On 7/21/22 14:07, David Hildenbrand wrote: > Ping? Is there any plan how to move forward? I have libvirt patches ready to consume this and I'd like to prune my old local branches :-) Michal

Re: [PATCH v5 1/3] Update linux headers to 6.0-rc1

On 8/17/22 04:08, Chenyi Qiang wrote: > commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > > Signed-off-by: Chenyi Qiang > --- > include/standard-headers/asm-x86/bootparam.h | 7 +- > include/standard-headers/drm/drm_fourcc.h | 73 +++- > include/standard-headers/linux/ethtool.h

Re: [PATCH RFC 0/7] hostmem: NUMA-aware memory preallocation using ThreadContext

On 8/9/22 20:06, David Hildenbrand wrote: > On 09.08.22 12:56, Joao Martins wrote: >> On 7/21/22 13:07, David Hildenbrand wrote: >>> This is a follow-up on "util: NUMA aware memory preallocation" [1] by >>> Michal. >>> >>> Setting the CPU affinity of threads from inside QEMU usually isn't >>>

Re: [PATCH RFC 3/7] util: Introduce ThreadContext user-creatable object

On 7/21/22 14:07, David Hildenbrand wrote: > Setting the CPU affinity of QEMU threads is a bit problematic, because > QEMU doesn't always have permissions to set the CPU affinity itself, > for example, with seccomp after initialized by QEMU: > -sandbox enable=on,resourcecontrol=deny > > While

Re: [PATCH RFC 0/7] hostmem: NUMA-aware memory preallocation using ThreadContext

On 7/21/22 14:07, David Hildenbrand wrote: > This is a follow-up on "util: NUMA aware memory preallocation" [1] by > Michal. > > Setting the CPU affinity of threads from inside QEMU usually isn't > easily possible, because we don't want QEMU -- once started and running > guest code -- to be able

Re: [PATCH RFC 7/7] vl: Allow ThreadContext objects to be created before the sandbox option

On 7/21/22 14:07, David Hildenbrand wrote: > Currently, there is no way to configure a CPU affinity inside QEMU when > the sandbox option disables it for QEMU as a whole, for example, via: > -sandbox enable=on,resourcecontrol=deny > > While ThreadContext objects can be created on the QEMU

Re: [PATCH RFC 0/7] hostmem: NUMA-aware memory preallocation using ThreadContext

On 7/21/22 14:07, David Hildenbrand wrote: > This is a follow-up on "util: NUMA aware memory preallocation" [1] by > Michal. I've skimmed through patches and haven't spotted anything obviously wrong. I'll test these more once I write libvirt support for them (which I plan to do soon). Michal

Re: [PATCH 1/2] usb: document guest-reset and guest-reset-all

On 7/11/22 11:44, Gerd Hoffmann wrote: > Suggested-by: Michal Prívozník > Signed-off-by: Gerd Hoffmann > --- > docs/system/devices/usb.rst | 29 + > 1 file changed, 29 insertions(+) Thank you! Reviewed-by: Michal Privoznik Michal

Re: [libvirt PATCH v2] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

On 6/20/22 19:19, Daniel P. Berrangé wrote: > Libvirt provides QMP passthrough APIs for the QEMU driver and these are > exposed in virsh. It is not especially pleasant, however, using the raw > QMP JSON syntax. QEMU has a tool 'qmp-shell' which can speak QMP and > exposes a human friendly

Re: [PATCH v3] qga: add guest-get-diskstats command for Linux guests

On 5/15/22 11:54, luzhipeng wrote: > Add a new 'guest-get-diskstats' command for report disk io statistics > for Linux guests. This can be usefull for getting io flow or handling > IO fault, no need to enter guests. > > Signed-off-by: luzhipeng > --- > Changes v2->v3: > bugfix for memory leak >

Re: [PATCH] util: NUMA aware memory preallocation

On 5/10/22 11:12, Daniel P. Berrangé wrote: > On Tue, May 10, 2022 at 08:55:33AM +0200, Michal Privoznik wrote: >> When allocating large amounts of memory the task is offloaded >> onto threads. These threads then use various techniques to >> allocate the memory fully (madvise(), writing into the

Re: [PATCH 3/3] qga/commands-posix: Fix listing ifaces for Solaris

On 3/20/22 22:38, Andrew Deason wrote: > The code for guest-network-get-interfaces needs a couple of small > adjustments for Solaris: > > - The results from SIOCGIFHWADDR are documented as being in ifr_addr, > not ifr_hwaddr (ifr_hwaddr doesn't exist on Solaris). > > - The implementation of

Re: [PATCH 0/3] qga: Implement guest-network-get-interfaces for Solaris

On 3/20/22 22:38, Andrew Deason wrote: > This implements the guest agent guest-network-get-interfaces command on > Solaris. Solaris provides a getifaddrs() that's very similar to the Linux one, > so the implementation is mostly the same. > > Andrew Deason (3): > qga/commands-posix: Use

Re: [PATCH] x86/amx: compatible with older kernel release

On 3/18/22 12:55, Yang Zhong wrote: > The AMX KVM introduced one new ARCH_GET_XCOMP_SUPP system attribute > API to get host side supported_xcr0 and latest Qemu can decide if it > can request dynamically enabled XSAVE features permission. But this > implementation(19db68ca68) did not consider older

Re: [PULL 15/22] x86: Grant AMX permission for guest

On 3/16/22 16:57, Peter Krempa wrote: > On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote: >> From: Yang Zhong >> >> Kernel allocates 4K xstate buffer by default. For XSAVE features >> which require large state component (e.g. AMX), Linux kernel >> dynamically expands the xstate buffer

Re: Call for GSoC and Outreachy project ideas for summer 2022

On 2/21/22 12:27, Paolo Bonzini wrote: > On 2/21/22 10:36, Michal Prívozník wrote: >> Indeed. Libvirt's participating on its own since 2016, IIRC. Since we're >> still in org acceptance phase we have some time to decide this, >> actually. We can do the final decision aft

Re: Call for GSoC and Outreachy project ideas for summer 2022

On 2/19/22 14:46, Stefan Hajnoczi wrote: > On Fri, 18 Feb 2022 at 16:03, Paolo Bonzini wrote: >> >> On 2/18/22 12:39, Michal Prívozník wrote: >>> On 2/17/22 18:52, Paolo Bonzini wrote: >>>> I would like to co-mentor one or more projects about adding more >&g

Re: Call for GSoC and Outreachy project ideas for summer 2022

On 2/17/22 18:52, Paolo Bonzini wrote: > On 1/28/22 16:47, Stefan Hajnoczi wrote: >> Dear QEMU, KVM, and rust-vmm communities, >> QEMU will apply for Google Summer of Code 2022 >> (https://summerofcode.withgoogle.com/) and has been accepted into >> Outreachy May-August 2022

Re: [PATCH v1 0/2] virtio-mem: Handle preallocation with migration

On 1/18/22 16:07, David Hildenbrand wrote: > While playing with migration of virtio-mem with an ordinary file backing, > I realized that migration and prealloc doesn't currently work as expected > for virtio-mem, especially when migrating zeropages or skipping migration > of some pages. > > In

Re: [PATCH] qemu-options: Remove the deprecated -no-quit option

On 12/15/21 09:24, Thomas Huth wrote: > This option was just a wrapper around the -display ...,window-close=off > parameter, and the name "no-quit" is rather confusing compared to > "window-close" (since there are still other means to quit the emulator), > so let's remove this now. > >

Re: [PATCH v1 00/12] Add riscv kvm accel support

On 11/20/21 08:46, Yifei Jiang wrote: > This series adds both riscv32 and riscv64 kvm support, and implements > migration based on riscv. What libvirt does when detecting KVM support is issuing query-kvm monitor command and checking if both 'present' and 'enabled' bools are true. If this is what

Re: [PATCH v1 0/8] virtio-mem: Support "prealloc=on"

ini > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Eduardo Habkost > Cc: Dr. David Alan Gilbert > Cc: Daniel P. Berrangé > Cc: Gavin Shan > Cc: Hui Zhu > Cc: Sebastien Boeuf > Cc: Pankaj Gupta > Cc: Michal Prívozník > > D

Re: [PATCH v1 2/3] virtio-mem: Support VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE

On 11/30/21 10:28, David Hildenbrand wrote: > With VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE, we signal the VM that reading > unplugged memory is not supported. We have to fail feature negotiation > in case the guest does not support VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE. > > First,

Re: [PATCH v1 1/3] linux-headers: sync VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE

On 11/30/21 10:28, David Hildenbrand wrote: > TODO: replace by a proper header sync. > > Signed-off-by: David Hildenbrand > --- > include/standard-headers/linux/virtio_mem.h | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v1 3/3] virtio-mem: Set "unplugged-inaccessible=auto" for the 6.2 machine on x86

On 11/30/21 10:28, David Hildenbrand wrote: > Set the new default to "auto", keeping it set to "on" for compat I believe you wanted to say: keeping it set to "off", because that's what the patch does. > machines. This property is only available for x86 targets. > > TODO: once 6.2 was released

Re: Odd square bracket encoding in QOM names

On 11/30/21 09:35, Mark Cave-Ayland wrote: > Hi all, > > Has there been a recent change as to how square brackets are encoded > within QOM names? I noticed that the output has changed here in the > "info qom-tree" output in qemu-system-m68k for the q800 machine. > > The q800 machine has a set of

Re: RFC: extending QGA guest-network-get-interfaces

On 11/24/21 15:00, Marc-André Lureau wrote: > Hi > > Or Shoval filed two RFE for guest-network-get-interfaces: > - "Guest agent should report the interface Permanent address" > https://bugzilla.redhat.com/show_bug.cgi?id=2025303 > As I've

Re: [PATCH] qmp: Stabilize preconfig

On 11/3/21 9:02 AM, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: >>> On 10/25/21 2:19 PM, Markus Armbruster wrote: >>>> Michal Privoznik writes: >>>> >>>>>

Re: [PATCH] device_tree: Fix compiler error

On 11/9/21 9:38 AM, Richard Henderson wrote: > On 11/8/21 9:07 PM, Stefan Weil wrote: >> A build with gcc (Debian 10.2.1-6) 10.2.1 20210110 fails: >> >> ../../../softmmu/device_tree.c: In function ‘qemu_fdt_add_path’: >> ../../../softmmu/device_tree.c:560:18: error: ‘retval’ may be used >>

Re: [PATCH] qmp: Stabilize preconfig

On 10/25/21 2:19 PM, Markus Armbruster wrote: > Michal Privoznik writes: > >> The -preconfig option and exit-preconfig command are around for >> quite some time now. However, they are still marked as unstable. >> This is suboptimal because it may block some upper layer in >> consuming it. In

Re: [PATCH 1/2] chardev: Propagate error from logfile opening

On 8/17/21 11:54 AM, Marc-André Lureau wrote: > On Tue, Aug 17, 2021 at 12:56 PM Michal Privoznik > wrote: > >> If a chardev has a logfile the file is opened using >> qemu_open_old() which does the job, but since @errp is not >> propagated into qemu_open_internal() we lose much more accurate >>

Re: [PATCH 2/2] monitor: Report EBADFD if fdset contains invalid FD

On 8/17/21 11:59 AM, Marc-André Lureau wrote: > Hi > > On Tue, Aug 17, 2021 at 12:56 PM Michal Privoznik > wrote: > >> When opening a path that starts with "/dev/fdset/" the control >> jumps into qemu_parse_fdset() and then into >> monitor_fdset_dup_fd_add(). In here, corresponding fdset is

Re: [PATCH 2/2] numa: Parse initiator= attribute before cpus= attribute

On 7/9/21 11:26 AM, Igor Mammedov wrote: > On Wed, 7 Jul 2021 15:40:30 +0200 > Michal Privoznik wrote: > >> When parsing cpus= attribute of -numa object couple of checks >> is performed, such as correct initiator setting (see the if() >> statement at the end of for() loop in >>

Re: [PATCH] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

On 6/14/21 6:03 PM, Philippe Mathieu-Daudé wrote: > On 6/11/21 1:46 PM, Philippe Mathieu-Daudé wrote: >> When the NVMe block driver was introduced (see commit bdd6a90a9e5, >> January 2018), Linux VFIO_IOMMU_MAP_DMA ioctl was only returning >> -ENOMEM in case of error. The driver was correctly

Re: [PATCH] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

t (65535 by default) when loading the VFIO IOMMU module: > > # modprobe vfio_iommu_type1 dma_entry_limit=666 > > Cc: qemu-sta...@nongnu.org > Reported-by: Michal Prívozník > Fixes: bdd6a90a9e5 ("block: Add VFIO based NVMe driver") > Buglink: https://bugs.launchpad.

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

On 5/10/21 3:20 PM, Gerd Hoffmann wrote: > Move device init (realize) and properties. > > Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no > matter what. Just use virtio-gpu-device instead if you don't want > enable virgl and opengl. This simplifies the logic and reduces

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

On 4/29/21 5:52 PM, Stefan Hajnoczi wrote: > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > completely at this point. > > Drop the scsi=on|off option. It was only available on Legacy virtio-blk > devices. Linux v5.6 already dropped support for it. > > Remove the

Re: [PULL v8 00/86] Misc QEMU patches for 2020-09-24

On 10/2/20 6:22 PM, Eduardo Habkost wrote: On Fri, Oct 02, 2020 at 05:58:55PM +0200, Michal Prívozník wrote: On 9/30/20 9:58 PM, Paolo Bonzini wrote: Eduardo Habkost (10): docs: Create docs/devel/qom.rst cd442a45db60a1a72fcf980c24bd1227f13f8a87 is the first bad commit Sorry

Re: [PULL v8 00/86] Misc QEMU patches for 2020-09-24

On 9/30/20 9:58 PM, Paolo Bonzini wrote: > Eduardo Habkost (10): docs: Create docs/devel/qom.rst cd442a45db60a1a72fcf980c24bd1227f13f8a87 is the first bad commit Sorry for noticing this earlier, but is this known? The build starts failing for me after this commit:

Re: [PATCH] configure: Improve zstd test

On 5. 3. 2020 16:27, Juan Quintela wrote: > Alex Bennée wrote: >> Juan Quintela writes: >> >>> There were one error on the test (missing an s for --exists). >>> But we really need a recent zstd (0.8.1). >>> That version was released in 2016, so it is newer that some of our travis >>> images.

[Bug 1863333] [NEW] Assigning NVMe disk to a domain causes VFIO_MAP_DMA errors

Public bug reported: I'm seeing some errors when assigning my NVMe disk to qemu. This is the full command line: /home/zippy/work/qemu/qemu.git/x86_64-softmmu/qemu-system-x86_64 \ -name guest=fedora,debug-threads=on \ -S \ -object

Re: [PATCH] x86: Check for machine state object class before typecasting it

On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 10:35 AM, Michal Prívozník wrote: >> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: >>> On 12/30/19 9:00 AM, Michal Privoznik wrote: >>>> In v4.2.0-246-ged9e923c3c the SMM property was moved f

Re: [PATCH v2] accel/kvm: Make "kernel_irqchip" default on

; accelerator property") > Reported-by: Vitaly Kuznetsov > Signed-off-by: Xiaoyao Li > --- > Changes in v2: > - Add Reported-by tag; > - Initialize kernel_irqchip_split in init_machine(); > --- > accel/kvm/kvm-all.c | 3 +++ > include/hw/boards.h | 3 --

Re: [PATCH] x86: Check for machine state object class before typecasting it

On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 9:00 AM, Michal Privoznik wrote: >> In v4.2.0-246-ged9e923c3c the SMM property was moved from PC > > Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. This depends on how you format the hash :-) I've used 'git describe ed9e923c3c' because

Re: Making QEMU easier for management tools and applications

On 12/21/19 10:02 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> 4. Go and Rust bindings would also be useful. There is >> https://github.com/intel/govmm but I think it makes sense to keep it >> in qemu.git and provide an interface similar to our Python modules. > > Mapping

Re: [PULL 48/87] x86: move SMM property to X86MachineState

On 12/23/19 2:38 PM, Paolo Bonzini wrote: > On 23/12/19 12:40, Michal Prívozník wrote: >> >> diff --git i/target/i386/kvm.c w/target/i386/kvm.c >> index 0b511906e3..7ee3202634 100644 >> --- i/target/i386/kvm.c >> +++ w/target/i386/kvm.c >> @@ -2173,6 +2173,

Re: [PULL 48/87] x86: move SMM property to X86MachineState

On 12/23/19 12:33 PM, Daniel P. Berrangé wrote: > On Mon, Dec 23, 2019 at 12:28:43PM +0100, Michal Prívozník wrote: >> On 12/18/19 1:02 PM, Paolo Bonzini wrote: >>> Add it to microvm as well, it is a generic property of the x86 >>> architecture. >>> >>&g

Re: [PULL 48/87] x86: move SMM property to X86MachineState

On 12/18/19 1:02 PM, Paolo Bonzini wrote: > Add it to microvm as well, it is a generic property of the x86 > architecture. > > Suggested-by: Sergio Lopez > Signed-off-by: Paolo Bonzini > --- > hw/i386/pc.c | 49 - > hw/i386/pc_piix.c

Re: [PATCH v4 21/24] nvme: support multiple namespaces

On 12/19/19 2:09 PM, Klaus Jensen wrote: > This adds support for multiple namespaces by introducing a new 'nvme-ns' > device model. The nvme device creates a bus named from the device name > ('id'). The nvme-ns devices then connect to this and registers > themselves with the nvme device. > > This

Re: [Qemu-devel] [PATCH] Makefile: Drop $(DESTDIR) from generated FW paths

On 8/5/19 3:00 PM, Peter Maydell wrote: > > Hi -- this looks like a duplicate of > https://patchew.org/QEMU/20190530192812.17637-1-o...@aepfle.de/ > > (which Philippe has put in a pullreq which I guess is > destined for 4.1, though I'm still waiting for confirmation > of that, ie that it really

Re: [Qemu-devel] [PULL 0/1] EDK2 firmware patches

On 8/3/19 12:22 PM, Peter Maydell wrote: > On Sat, 3 Aug 2019 at 09:26, Philippe Mathieu-Daudé wrote: >> >> The following changes since commit 9bcf2dfa163f67b0fec6ee0fe88ad5dc5d69dc59: >> >> Merge remote-tracking branch >> 'remotes/elmarco/tags/slirp-CVE-2019-14378-pull-request' into staging

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Repo: https://github.com/lersek/qemu.git > Branch: edk2_build > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > release, and builds and captures platform firmware binaries from that > release. At this point they are meant to

Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command

On 06/27/2018 05:44 PM, Paolo Bonzini wrote: > On 26/06/2018 18:31, Michal Privoznik wrote: >>> >>> +static bool pr_manager_helper_is_connected(PRManager *p) >>> +{ >>> +PRManagerHelper *pr_mgr = PR_MANAGER_HELPER(p); >>> +bool result; >>> + >>> +qemu_mutex_lock(_mgr->lock); >>> +

Re: [Qemu-devel] [PATCH v2 0/2] Avoid using RUN_STATE_PRECONFIG unless explicitly requested with --preconfig

On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > The change to use RUN_STATE_PRECONFIG as the default initial state, even > when not requested with --preconfig has caused a number of problems. This > series introduces a new RUN_STATE_NONE to act as the initial state, so > that we never use