[PATCH v5 4/4] docs: add test for firmware.json QAPI

2024-07-18 Thread Thomas Weißschuh
To make sure that the QAPI description stays valid add a testcase. Suggested-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/qemu-devel/d9ce0234-4beb-4b90-b14c-76810d3b8...@linaro.org/ Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Weißschuh --- docs/meson.build | 5 + 1

[PATCH v5 1/4] docs/interop/firmware.json: add new enum FirmwareFormat

2024-07-18 Thread Thomas Weißschuh
Only a small subset of all blockdev drivers make sense for firmware images. Introduce and use a new enum to represent this. This also reduces the dependency on firmware.json from the global qapi definitions. Suggested-by: Daniel P. Berrangé Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas

Re: [PATCH 1/2] ci: add gtk-vnc to the deps

2024-07-18 Thread Thomas Huth
+ - gtk-vnc - hostname - json-c - libaio Reviewed-by: Thomas Huth IIRC Alex has a patch in his queue already to refresh the docker images, maybe he could include this change there, too...?

[PATCH v4 3/3] docs: add test for firmware.json QAPI

2024-07-18 Thread Thomas Weißschuh
To make sure that the QAPI description stays valid add a testcase. Suggested-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/qemu-devel/d9ce0234-4beb-4b90-b14c-76810d3b8...@linaro.org/ Signed-off-by: Thomas Weißschuh --- docs/meson.build | 5 + 1 file changed, 5 insertions

[PATCH v4 0/3] docs/interop/firmware.json: scripts/qapi-gen.py compatibility

2024-07-18 Thread Thomas Weißschuh
seems clear the we have to keep it. Signed-off-by: Thomas Weißschuh --- Changes in v4: - Update "since" to 9.1 - Add comment to 'member-name-exceptions' - Document enum members and drop 'documentation-exceptions' - Link to v3: https://lore.kernel.org/r/20240311-qap

[PATCH v4 1/3] docs/interop/firmware.json: add new enum FirmwareFormat

2024-07-18 Thread Thomas Weißschuh
Only a small subset of all blockdev drivers make sense for firmware images. Introduce and use a new enum to represent this. This also reduces the dependency on firmware.json from the global qapi definitions. Suggested-by: Daniel P. Berrangé Signed-off-by: Thomas Weißschuh --- docs/interop

[PATCH v4 2/3] docs/interop/firmware.json: add new enum FirmwareArchitecture

2024-07-18 Thread Thomas Weißschuh
Only a small subset of all architectures supported by qemu make use of firmware files. Introduce and use a new enum to represent this. This also removes the dependency to machine.json from the global qapi definitions. Suggested-by: Daniel P. Berrangé Signed-off-by: Thomas Weißschuh --- docs

Re: [PATCH 04/11] tests/functional: Add python-based tests to the meson build system

2024-07-17 Thread Thomas Huth
On 16/07/2024 17.15, Fabiano Rosas wrote: Thomas Huth writes: Integrate the new python-based test framework with the meson build system. Since these tests now require the pycotap module, make sure that it gets installed in the venv. The changes to the meson.build files are partly based on an

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-17 Thread Thomas Huth
On 17/07/2024 10.37, Daniel P. Berrangé wrote: On Wed, Jul 17, 2024 at 10:04:19AM +0200, Thomas Huth wrote: On 16/07/2024 19.03, Thomas Huth wrote: On 16/07/2024 18.51, Daniel P. Berrangé wrote: On Tue, Jul 16, 2024 at 01:26:03PM +0200, Thomas Huth wrote: ... So instead of trying to update

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-17 Thread Thomas Huth
On 16/07/2024 19.03, Thomas Huth wrote: On 16/07/2024 18.51, Daniel P. Berrangé wrote: On Tue, Jul 16, 2024 at 01:26:03PM +0200, Thomas Huth wrote: ... So instead of trying to update the python-based test suite in QEMU to a newer version of Avocado, we should maybe try to better integrate it

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-17 Thread Thomas Huth
ssume we could continue using avocado.utils for the cloud-init stuff there, and just run them via the meson test runner, too. I'll give it a try when I get some spare time. Thomas

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-16 Thread Thomas Huth
On 16/07/2024 18.45, John Snow wrote: On Thu, Jul 11, 2024, 7:55 AM Thomas Huth <mailto:th...@redhat.com>> wrote: ... - I haven't looked into logging yet ... this still needs some work   so that you could e.g. inspect the console output of the guests   somewhere

Re: [PATCH] tests: increase timeout per instance of bios-tables-test

2024-07-16 Thread Thomas Huth
t easily to use CPU time instead of wall time? Anyway, if the bios-tables-test is getting more and more complex, it's maybe not such a good idea to run it in a job that is using TCI ... Maybe it's best to remove aarch64-softmmu from the cross-i686-tci job? Thomas

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-16 Thread Thomas Huth
On 16/07/2024 18.51, Daniel P. Berrangé wrote: On Tue, Jul 16, 2024 at 01:26:03PM +0200, Thomas Huth wrote: ... So instead of trying to update the python-based test suite in QEMU to a newer version of Avocado, we should maybe try to better integrate it with the meson test runner instead

[PATCH 08/11] tests/functional: Convert some avocado tests that needed avocado.utils.archive

2024-07-16 Thread Thomas Huth
Instead of using the "archive" module from avocado.utils, switch these tests to use the new wrapper function that is based on the "tarfile" module instead. Signed-off-by: Thomas Huth --- MAINTAINERS | 6 ++--- tests/functional/meson.build

[PATCH 05/11] tests/functional: Implement fetch_asset() method for downloading assets

2024-07-16 Thread Thomas Huth
In the new python test framework, we cannot use the fetch_asset() function from Avocado anymore, so we have to provide our own implementation now instead. Thus add such a function based on the urllib python module for this purpose. Signed-off-by: Thomas Huth --- tests/functional/qemu_test

[PATCH 01/11] tests/functional: Add base classes for the upcoming pytest-based tests

2024-07-16 Thread Thomas Huth
be set via meson.build later. Signed-off-by: Thomas Huth --- tests/functional/qemu_test/__init__.py | 326 + 1 file changed, 326 insertions(+) create mode 100644 tests/functional/qemu_test/__init__.py diff --git a/tests/functional/qemu_test/__init__.py b/tests

[PATCH 07/11] tests/functional: Add a function for extracting files from an archive

2024-07-16 Thread Thomas Huth
with this functionality, so let's just add a nice wrapper function around that. Signed-off-by: Thomas Huth --- tests/functional/qemu_test/utils.py | 21 + 1 file changed, 21 insertions(+) create mode 100644 tests/functional/qemu_test/utils.py diff --git a/tests/functional/qemu_t

[PATCH 03/11] tests/functional: Convert avocado tests that just need a small adjustment

2024-07-16 Thread Thomas Huth
These simple tests can be converted to stand-alone tests quite easily, e.g. by just setting the machine to 'none' now manually or by adding "-cpu" command line parameters, since we don't support the corresponding avocado tags in the new python test framework. S

[PATCH 11/11] gitlab-ci: Add "check-functional" to the build tests

2024-07-16 Thread Thomas Huth
Now that we converted many tests from the "check-avocado" test suite to the "check-functional" test suite, we should make sure that these also get tested in the CI. Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest-template.yml | 3 +- .gitlab-ci.d/buildte

[PATCH 04/11] tests/functional: Add python-based tests to the meson build system

2024-07-16 Thread Thomas Huth
Integrate the new python-based test framework with the meson build system. Since these tests now require the pycotap module, make sure that it gets installed in the venv. The changes to the meson.build files are partly based on an earlier patch by Ani Sinha (but heavily modified by Thomas Huth

[PATCH 10/11] tests/functional: Convert the s390x avocado tests into standalone tests

2024-07-16 Thread Thomas Huth
ymore nowadays. Signed-off-by: Thomas Huth --- MAINTAINERS | 4 +- tests/functional/meson.build | 6 ++ tests/functional/qemu_test/utils.py | 7 ++ .../test_s390x_ccw_virtio.py} | 32 - .../test_s390x_topolo

[PATCH 09/11] tests/functional: Set up logging

2024-07-16 Thread Thomas Huth
Create log files for each test separately, one file that contains the basic logging and one that contains the console output. Signed-off-by: Thomas Huth --- tests/functional/qemu_test/__init__.py | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/tests

[PATCH 02/11] tests/functional: Convert simple avocado tests into standalone python tests

2024-07-16 Thread Thomas Huth
directly. Signed-off-by: Thomas Huth --- .../test_cpu_queries.py} | 7 ++- .../test_empty_cpu_model.py} | 7 ++- .../test_mem_addr_space.py} | 53 +++ .../test_pc_cpu_hotplug_props.py} | 11 ++-- .

[PATCH 06/11] tests/functional: Convert some tests that download files via fetch_asset()

2024-07-16 Thread Thomas Huth
Now that we've got a working fetch_asset() function, we can convert some Avocado tests that use this function for downloading their required files. Signed-off-by: Thomas Huth --- MAINTAINERS | 12 +++ tests/functional/meson.build

[PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-16 Thread Thomas Huth
nal in the gitlab-CI - ... lots of other changes I forgot about ... in fact, I changed so many things that I also did not dare to pick up the Reviewed-bys from the RFC Thomas Huth (11): tests/functional: Add base classes for the upcoming pytest-based tests tests/functional: Convert simple avoc

Re: FreeBSD update required for CI?

2024-07-15 Thread Thomas Huth
ersion to get the fix for it. Alex is planning to provide a patch. Thomas

Re: [RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-12 Thread Thomas Huth
On 12/07/2024 13.47, Daniel P. Berrangé wrote: On Fri, Jul 12, 2024 at 12:14:45PM +0200, Thomas Huth wrote: On 12/07/2024 11.01, Daniel P. Berrangé wrote: On Thu, Jul 11, 2024 at 01:55:42PM +0200, Thomas Huth wrote: From: Ani Sinha Integrate the pytest framework with the meson build system

Re: [RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-12 Thread Thomas Huth
On 12/07/2024 12.26, Daniel P. Berrangé wrote: On Fri, Jul 12, 2024 at 12:14:45PM +0200, Thomas Huth wrote: On 12/07/2024 11.01, Daniel P. Berrangé wrote: On Thu, Jul 11, 2024 at 01:55:42PM +0200, Thomas Huth wrote: From: Ani Sinha Integrate the pytest framework with the meson build system

Re: [RFC PATCH 7/8] tests/pytest: Add a function for extracting files from an archive

2024-07-12 Thread Thomas Huth
On 12/07/2024 11.14, Daniel P. Berrangé wrote: On Thu, Jul 11, 2024 at 01:55:45PM +0200, Thomas Huth wrote: Some Avocado-based tests use the "archive" module from avocado.utils to extract files from an archive. To be able to use these tests without Avocado, we have to provide our ow

Re: [RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-12 Thread Thomas Huth
On 12/07/2024 11.01, Daniel P. Berrangé wrote: On Thu, Jul 11, 2024 at 01:55:42PM +0200, Thomas Huth wrote: From: Ani Sinha Integrate the pytest framework with the meson build system. This will make meson run all the pytests under the pytest directory. Lets add a note about the compelling

Re: [RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-12 Thread Thomas Huth
On 12/07/2024 11.09, Daniel P. Berrangé wrote: On Thu, Jul 11, 2024 at 01:55:43PM +0200, Thomas Huth wrote: In the pytests, we cannot use the fetch_asset() function from Avocado anymore, so we have to provide our own implementation now instead. Thus add such a function based on the

Re: [RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-11 Thread Thomas Huth
On 11/07/2024 23.35, Richard Henderson wrote: On 7/11/24 12:23, Alex Bennée wrote: Richard Henderson writes: On 7/11/24 09:45, Richard Henderson wrote: On 7/11/24 04:55, Thomas Huth wrote: +    def fetch_asset(self, url, asset_hash): +    cache_dir = os.path.expanduser("~/.cache

Re: [RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-11 Thread Thomas Huth
On 11/07/2024 20.49, Richard Henderson wrote: On 7/11/24 09:45, Richard Henderson wrote: On 7/11/24 04:55, Thomas Huth wrote: +    def fetch_asset(self, url, asset_hash): +    cache_dir = os.path.expanduser("~/.cache/qemu/download") +    if not os.path.exists

Re: [RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-11 Thread Thomas Huth
On 11/07/2024 18.45, Richard Henderson wrote: On 7/11/24 04:55, Thomas Huth wrote: +    def fetch_asset(self, url, asset_hash): +    cache_dir = os.path.expanduser("~/.cache/qemu/download") +    if not os.path.exists(cache_dir): +    os.makedirs(cache_dir) +   

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-11 Thread Thomas Huth
On 11/07/2024 16.39, Fabiano Rosas wrote: Thomas Huth writes: ... Things that need further attention though: - All tests that use the LinuxTest / LinuxDistro classes (e.g. based on cloud-init images) really depend on the Avocado framework, thus we'd need a solution for those if we

Re: Avocado 88.1 vs Python 3.12

2024-07-11 Thread Thomas Huth
rate the python-based tests directly with the meson test runner. A prototype can be found here: https://lore.kernel.org/qemu-devel/2024075546.40859-1-th...@redhat.com/ Thomas

[RFC PATCH 3/8] tests/pytest: Convert info_usernet and version test with small adjustments

2024-07-11 Thread Thomas Huth
These two simple tests can be converted to a pytest quite easily, we just have to set the machine to 'none' now manually since we don't support the avocado tags here yet. Signed-off-by: Thomas Huth --- .../info_usernet.py => pytest/test_info_usernet.py} | 6 ++--

[RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-11 Thread Thomas Huth
In the pytests, we cannot use the fetch_asset() function from Avocado anymore, so we have to provide our own implementation now instead. Thus add such a function based on the _download_with_cache() function from tests/vm/basevm.py for this purpose. Signed-off-by: Thomas Huth --- tests/pytest

[RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-11 Thread Thomas Huth
From: Ani Sinha Integrate the pytest framework with the meson build system. This will make meson run all the pytests under the pytest directory. Signed-off-by: Ani Sinha [thuth: Removed the acpi-bits and adjusted for converted avocado tests instead] Signed-off-by: Thomas Huth --- tests

[RFC PATCH 7/8] tests/pytest: Add a function for extracting files from an archive

2024-07-11 Thread Thomas Huth
with this functionality, so let's just add a nice wrapper function around that. Signed-off-by: Thomas Huth --- tests/pytest/qemu_pytest/utils.py | 21 + 1 file changed, 21 insertions(+) create mode 100644 tests/pytest/qemu_pytest/utils.py diff --git a/tests/pytest/qemu_pytest/ut

[RFC PATCH 8/8] tests/pytest: Convert avocado test that needed avocado.utils.archive

2024-07-11 Thread Thomas Huth
Instead of using the "archive" module from avocado.utils, switch these tests to use the new wrapper function that is based on the "tarfile" module instead. Signed-off-by: Thomas Huth --- tests/pytest/meson.build | 5 + .../te

[RFC PATCH 6/8] tests/pytest: Convert some tests that download files via fetch_asset()

2024-07-11 Thread Thomas Huth
Now that we've got a working fetch_asset() function, we can convert some Avocado tests that use this function for downloading their required files. Signed-off-by: Thomas Huth --- tests/pytest/meson.build | 16 +++ .../test_machine_arm_n8

[RFC PATCH 2/8] tests/pytest: Convert some simple avocado tests into pytests

2024-07-11 Thread Thomas Huth
ia the PYTEST_QEMU_BINARY environment variable, and the source and build directories via the PYTEST_SOURCE_ROOTand PYTEST_BUILD_ROOT environment variables. Signed-off-by: Thomas Huth --- tests/{avocado/cpu_queries.py => pytest/test_cpu_queries.py} | 2 +- .../empty_cpu_model.py =>

[RFC PATCH 1/8] tests/pytest: Add base classes for the upcoming pytest-based tests

2024-07-11 Thread Thomas Huth
will be set via meson.build later. Signed-off-by: Thomas Huth --- tests/pytest/qemu_pytest/__init__.py | 344 +++ 1 file changed, 344 insertions(+) create mode 100644 tests/pytest/qemu_pytest/__init__.py diff --git a/tests/pytest/qemu_pytest/__init__.py b/tests/pytest

[RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-11 Thread Thomas Huth
here - I did not work on documentation updates yet (will do that if we agree to continue with this patch series) What's your thoughts? Is it worth to continue with this approach? Or shall I rather forget about it and wait for the Avocado version update? Thomas Ani Sinha (1): t

[PATCH] tests/avocado: Remove the non-working virtio_check_params test

2024-07-10 Thread Thomas Huth
The test has been marked as broken more than 4 years ago, and so far nobody ever cared to fix it. Thus let's simply remove it now ... if somebody ever needs it again, they can restore the file from an older version of QEMU. Signed-off-by: Thomas Huth --- tests/avocado/virtio_check_para

[PATCH] tests/avocado: Remove non-working sparc leon3 test

2024-07-10 Thread Thomas Huth
The test has been marked as broken more than 4 years ago, and so far nobody ever cared to fix it. Thus let's simply remove it now ... if somebody ever needs it again, they can restore the file from an older version of QEMU. Signed-off-by: Thomas Huth --- tests/avocado/machine_sparc_leo

Re: [PATCH v3 9/9] tests/qtest: Delete previous boot file

2024-07-08 Thread Thomas Huth
insertions(+), 7 deletions(-) Acked-by: Thomas Huth

Re: [PATCH v2 20/40] gitlab: don't bother with KVM for TCI builds

2024-07-07 Thread Thomas Huth
On 05/07/2024 23.44, Philippe Mathieu-Daudé wrote: On 5/7/24 18:49, Thomas Huth wrote: On 05/07/2024 18.34, Philippe Mathieu-Daudé wrote: On 5/7/24 10:40, Alex Bennée wrote: In fact any other accelerator would be pointless as the point is to exercise the TCI accelerator anyway. Signed-off-by

Re: [PATCH v2 20/40] gitlab: don't bother with KVM for TCI builds

2024-07-05 Thread Thomas Huth
sable the other accelerators for completeness? No, this is a Linux machine, and there's only TCG and KVM available for Linux. No need to bother with the other accelerators here. Thomas

[PATCH] system: Enable the device aliases for or1k, too

2024-07-05 Thread Thomas Huth
ically into the list. Signed-off-by: Thomas Huth --- system/qdev-monitor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 6af6ef7d66..60c3b6ad96 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -57,10 +57,

Re: [PATCH v2 20/40] gitlab: don't bother with KVM for TCI builds

2024-07-05 Thread Thomas Huth
deletions(-) Reviewed-by: Thomas Huth

Re: [PULL 02/12] tests/qtest/migration-test: enable on s390x with TCG

2024-07-04 Thread Thomas Huth
On 04/07/2024 13.20, Nicholas Piggin wrote: On Tue Jul 2, 2024 at 8:33 PM AEST, Thomas Huth wrote: From: Nicholas Piggin s390x with TCG is more stable now. Enable it. Ah, you did a more complete version of my flic fix that migrates all the state. I didn't see that go by but yeah I su

Re: [PULL v2 00/88] virtio: features,fixes

2024-07-03 Thread Thomas Huth
On 03/07/2024 21.45, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 08:46:38PM +0200, Thomas Huth wrote: On 03/07/2024 19.01, Richard Henderson wrote: On 7/3/24 09:51, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 09:31:45AM -0700, Richard Henderson wrote: On 7/2/24 13:15, Michael S

Re: [PULL v2 00/88] virtio: features,fixes

2024-07-03 Thread Thomas Huth
On 03/07/2024 22.26, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 08:46:38PM +0200, Thomas Huth wrote: On 03/07/2024 19.01, Richard Henderson wrote: On 7/3/24 09:51, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 09:31:45AM -0700, Richard Henderson wrote: On 7/2/24 13:15, Michael S

Re: [PULL v2 00/88] virtio: features,fixes

2024-07-03 Thread Thomas Huth
tive debugging, so that's likely the best way to tackle such issues. HTH, Thomas

Re: [PATCH v2 2/2] docs: remove Sphinx 1.x compatibility code

2024-07-03 Thread Thomas Huth
-- docs/sphinx/kernellog.py | 28 docs/sphinx/qapidoc.py | 29 +++-- 4 files changed, 19 insertions(+), 97 deletions(-) delete mode 100644 docs/sphinx/kernellog.py Reviewed-by: Thomas Huth

Re: [PATCH v2 1/2] Python: bump minimum sphinx version to 3.4.3

2024-07-03 Thread Thomas Huth
PyPI. Signed-off-by: John Snow Acked-by: Paolo Bonzini Acked-by: Markus Armbruster --- docs/conf.py| 7 +++ pythondeps.toml | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Thomas Huth

[PATCH] hw: Fix crash that happens when introspecting scsi-block on older machine types

2024-07-03 Thread Thomas Huth
's fix the problem by only changing the property on the devices that really have this property. Fixes: b4912afa5f ("scsi-disk: Fix crash for VM configured with USB CDROM after live migration") Signed-off-by: Thomas Huth --- hw/core/machine.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PULL 03/12] tests/qtest: Use qtest_add_data_func_full()

2024-07-02 Thread Thomas Huth
627-san-v2-10-750bb0946...@daynix.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/device-introspect-test.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/qtest/device-introspect-test.c b/tests/qtest/device-introspect-test.c index 5b0f

[PULL 05/12] tests/qtest: Free old machine variable name

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki This fixes LeakSanitizer warnings. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-12-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/libqtest.c | 1 + 1 file changed, 1 ins

[PULL 04/12] tests/qtest: Free unused QMP response

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki This fixes LeakSanitizer warnings. Signed-off-by: Akihiko Odaki Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-11-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/libqtest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PULL 10/12] tests/avocado: add hotplug_blk test

2024-07-02 Thread Thomas Huth
From: Vladimir Sementsov-Ogievskiy Introduce a test, that checks that plug/unplug of virtio-blk device works. (the test is developed by copying hotplug_cpu.py, so keep original copyright) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Thomas Huth Message-ID: <20240409065854.366

[PULL 09/12] hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge

2024-07-02 Thread Thomas Huth
Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index f87ca36264..c1edbd9131 100644 --- a/hw/s390x/s390-virtio-

[PULL 11/12] .travis.yml: Install python3-tomli in all build jobs

2024-07-02 Thread Thomas Huth
Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too. Message-ID: <20240624094807.182313-1-th...@redhat.com> Acked-by: Alex Bennée Signed-off-by: Thomas

[PULL 02/12] tests/qtest/migration-test: enable on s390x with TCG

2024-07-02 Thread Thomas Huth
From: Nicholas Piggin s390x with TCG is more stable now. Enable it. Signed-off-by: Nicholas Piggin Message-Id: <20240525131241.378473-3-npig...@gmail.com> Reviewed-by: Prasad Pandit [thuth: Added "with TCG" to the commit message] Signed-off-by: Thomas Huth --- tests/qtest/

[PULL 12/12] pc-bios/s390-ccw: Remove duplicated LDFLAGS

2024-07-02 Thread Thomas Huth
The -Wl,-pie and -nostdlib flags are added to LDFLAGS twice. Merge the two lines to get rid of the duplicates. Message-ID: <20240621082422.136217-2-th...@redhat.com> Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -

[PULL 07/12] tests/qtest: Free GThread

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki These GThreads are never referenced. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-15-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/vhost-user-test.c | 6 +++--- 1 file c

[PULL 08/12] docs: add precision about capstone for execlog plugin

2024-07-02 Thread Thomas Huth
ge-ID: <20240620135731.977377-1-erdn...@crans.org> Signed-off-by: Thomas Huth --- docs/devel/tcg-plugins.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 9cc09d8c3d..f7d7b9e3a4 100644 --- a/docs/devel/tcg-plugins.rst +++ b

[PULL 06/12] tests/qtest: Free paths

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki This fixes LeakSanitizer warnings. Signed-off-by: Akihiko Odaki Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-14-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/qos-test.c | 16 1 file changed, 12 insertions

[PULL 01/12] hw/intc/s390_flic: Fix interrupt controller migration on s390x with TCG

2024-07-02 Thread Thomas Huth
e, so s390_cpu_exec_interrupt falls through to halting again." Thus let's finally migrate the pending state, and to be on the safe side, also the other state variables of the QEMUS390FLICState structure. Message-ID: <20240619144421.261342-1-th...@redhat.com> Signed-off-by: Thomas Huth

[PULL 00/12] qtest, s390x, avocado and doc patches

2024-07-02 Thread Thomas Huth
Piggin (1): tests/qtest/migration-test: enable on s390x with TCG Thomas Huth (4): hw/intc/s390_flic: Fix interrupt controller migration on s390x with TCG hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge .travis.yml: Install python3-tomli in all build job

Re: [PATCH v2 13/15] tests/qtest: Delete previous boot file

2024-07-02 Thread Thomas Huth
x27;A' followed by an endless string of 'B's I think the better fix would be to call bootfile_create() only once from main() since we don't have to create the bootfile multiple times, do we? Thomas

Re: [PATCH v2 00/15] Fix check-qtest-ppc64 sanitizer errors

2024-07-01 Thread Thomas Huth
ally or other misc areas. I can take the qtest patches through my tree. Thomas

Re: [PATCH v2 10/15] tests/qtest: Use qtest_add_data_func_full()

2024-07-01 Thread Thomas Huth
-introspect-test.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

[PATCH] hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge

2024-07-01 Thread Thomas Huth
The initial virtio-net-ccw devices currently do not have a proper parent in the QOM tree, so they show up under /machine/unattached - which is somewhat ugly. Let's attach them to /machine/virtual-css-bridge/virtual-css instead. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.

Re: [PATCH] hw/virtio: Fix the de-initialization of vhost-user devices

2024-07-01 Thread Thomas Huth
On 01/07/2024 17.06, Michael S. Tsirkin wrote: On Mon, Jul 01, 2024 at 04:07:56PM +0200, Thomas Huth wrote: On 18/06/2024 14.19, Thomas Huth wrote: The unrealize functions of the various vhost-user devices are calling the corresponding vhost_*_set_status() functions with a status of 0 to shut

Re: [PATCH] hw/virtio: Fix the de-initialization of vhost-user devices

2024-07-01 Thread Thomas Huth
On 18/06/2024 14.19, Thomas Huth wrote: The unrealize functions of the various vhost-user devices are calling the corresponding vhost_*_set_status() functions with a status of 0 to shut down the device correctly. Now these vhost_*_set_status() functions all follow this scheme: bool

[PATCH] Remove inclusion of hw/hw.h from files that don't need it

2024-07-01 Thread Thomas Huth
hw/hw.h only contains the prototype of hw_error() nowadays, so files that don't use this function don't need to include this header. Signed-off-by: Thomas Huth --- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/container.c | 1 - 3 files

Re: [PATCH v2 07/14] hw/i386: convert 'q35' machine definitions to use new macros

2024-07-01 Thread Thomas Huth
- hw/i386/pc_q35.c | 215 --- 1 file changed, 90 insertions(+), 125 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 06/14] hw/i386: convert 'i440fx' machine definitions to use new macros

2024-07-01 Thread Thomas Huth
thrice in three different formats in the calls to DEFINE_I440FX_MACHINE. Signed-off-by: Daniel P. Berrangé --- hw/i386/pc_piix.c| 219 +++ include/hw/i386/pc.h | 26 + 2 files changed, 122 insertions(+), 123 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img

2024-07-01 Thread Thomas Huth
On 28/06/2024 20.01, Jared Rossi wrote: On 6/24/24 1:55 AM, Thomas Huth wrote: [...] I think it should be fine, both functions are basically just a wrapper around the write() function in sclp.c, with sclp_print() being rather dumb while printf() is doing the usual string formatting before

Re: [PATCH v3 15/17] tests/qtest: Disable npcm7xx_sdhci tests using hardcoded RCA

2024-06-27 Thread Thomas Huth
This g_test_skip here does not make too much sense (since you're doing it in the caller site, too) ... could you please replace it with a proper comment why this code needs to be reworked? Thanks! Thomas sdhci_cmd_regs(qts, NPCM7XX_MMC_BA

[PATCH] docs/system/devices/usb: Replace the non-existing "qemu" binary

2024-06-26 Thread Thomas Huth
We don't ship a binary that is simply called "qemu", so we should avoid this in the documentation. Use the configurable binary name via "|qemu_system|" instead. Signed-off-by: Thomas Huth --- docs/system/devices/usb.rst | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [RFC PATCH v3 2/2] tests/qtest: QTest example for RISC-V CSR register

2024-06-26 Thread Thomas Huth
int csrno, uint64_t *val) +{ +uint64_t res = 0; + +res = qtest_csr_call(qts, name, cpu, csrno, val); + +return res; +} This wrapper function looks completely unnecessary, just call qtest_csr_call() everywhere directly instead? Thomas +static int qcsr_get_csr(QTestState

Re: [RFC PATCH v3 1/2] target/riscv: Add RISC-V CSR qtest support

2024-06-26 Thread Thomas Huth
t64_t qtest_csr_call(QTestState *s, const char *name, + uint64_t cpu, int csr, + unsigned long *val); + /** * qtest_bufread: * @s: #QTestState instance to operate on. For the tests/qtest part: Acked-by: Thomas Huth

Re: [PATCH] tests/avocado: add hotplug_blk test

2024-06-26 Thread Thomas Huth
cado: tags=arch:x86_64 +:avocado: tags=machine:q35 +:avocado: tags=accel:kvm +""" + self.require_accelerator('kvm') +self.vm.add_args('-accel', 'kvm') +self.vm.add_args('-device', 'pcie-pci-bridge,id=pci.1,bus=pcie.0') + +self.launch_and_wait() +self.blockdev_add() + +self.plug() +self.unplug() Reviewed-by: Thomas Huth

Re: [RFC PATCH] testing: restore some testing for i686

2024-06-25 Thread Thomas Huth
ould be ok to re-introduce this job. Partially revert but using the debian-i686 cross build images this time as fedora has deprecated the 32 bit stuff. Reported-by: Richard Henderson Suggested-by: Thomas Huth Signed-off-by: Alex Bennée --- .gitlab-ci.d/crossbuilds.yml | 10 ++ 1 fi

Re: Help improve 32-bit testing

2024-06-25 Thread Thomas Huth
nt to go a step backwards, then basically just revert commit 4f9a8315e65561bafa03651518aa5d22af09bdee and use the i686-debian-cross-container image instead of the removed i386-fedora-cross-container image. HTH, Thomas

Re: [PATCH 1/1] include/qemu: Provide a C++ compatible version of typeof_strip_qual

2024-06-24 Thread Thomas Huth
ur C++-enabled downstream repository. Thomas

Re: [PATCH] .travis.yml: Install python3-tomli in all build jobs

2024-06-24 Thread Thomas Huth
On 24/06/2024 12.09, Alex Bennée wrote: Thomas Huth writes: Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too. AFAICT the only repo currently running these

Re: [PATCH v2] scsi-disk: Fix crash for VM configured with USB CDROM after live migration

2024-06-24 Thread Thomas Huth
ty maybe rather be added to the "scsi-disk-base" class instead? Or should hw_compat_9_0 rather list the devices that have the property instead of using the parent class? Could you please have a look? Thanks, Thomas

[PATCH] .travis.yml: Install python3-tomli in all build jobs

2024-06-24 Thread Thomas Huth
Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too. Signed-off-by: Thomas Huth --- .travis.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.travis.yml

[PULL 05/11] vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()

2024-06-24 Thread Thomas Huth
Goater Reviewed-by: Zhenzhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-6-...@redhat.com> Signed-off-by: Thomas Huth --- hw/vfio/ccw.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --gi

[PULL 04/11] s390x/css: Make S390CCWDeviceClass::realize return bool

2024-06-24 Thread Thomas Huth
zhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-5-...@redhat.com> Signed-off-by: Thomas Huth --- include/hw/s390x/s390-ccw.h | 2 +- hw/s390x/s390-ccw.c | 7 --- hw/vfio/ccw.c | 3 +-- 3

[PULL 08/11] tests/qtest/fuzz: fix memleak in qos_fuzz.c

2024-06-24 Thread Thomas Huth
From: Dmitry Frolov Found with fuzzing for qemu-8.2, but also relevant for master Signed-off-by: Dmitry Frolov Reviewed-by: Thomas Huth Reviewed-by: Alexander Bulekov Message-ID: <20240521103106.119021-3-fro...@swemel.ru> Signed-off-by: Thomas Huth --- tests/qtest/fuzz/qos_fuzz.c |

[PULL 07/11] vfio/{ap, ccw}: Use warn_report_err() for IRQ notifier registration errors

2024-06-24 Thread Thomas Huth
: Zhenzhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-8-...@redhat.com> Signed-off-by: Thomas Huth --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfi

[PULL 09/11] target/s390x/arch_dump: use correct byte order for pid

2024-06-24 Thread Thomas Huth
From: Omar Sandoval The pid field of prstatus needs to be big endian like all of the other fields. Fixes: f738f296eaae ("s390x/arch_dump: pass cpuid into notes sections") Signed-off-by: Omar Sandoval Reviewed-by: Thomas Huth Message-ID: <5929f76d536d355afd04af51bf293695a10651

[PULL 11/11] target/s390x: Add a CONFIG switch to disable legacy CPUs

2024-06-24 Thread Thomas Huth
used to disable them (and old machine types that use them by default). Message-Id: <20240614125019.588928-1-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/cpu_models.c | 9 + target/s390x/Kconfig | 5 + 3 files chang

<    2   3   4   5   6   7   8   9   10   11   >