Daniel P. Berrangé wrote:
> On Wed, Oct 04, 2023 at 08:00:34PM +0200, Juan Quintela wrote:
>> Daniel P. Berrangé wrote:
>> > On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote:
>> >> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
>> >> > Oh dear, where to start. There's
On Wed, Oct 04, 2023 at 08:00:34PM +0200, Juan Quintela wrote:
> Daniel P. Berrangé wrote:
> > On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote:
> >> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
> >> > Oh dear, where to start. There's so much wrong, and in pretty obv
Daniel P. Berrangé wrote:
> On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote:
>> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
>> > Oh dear, where to start. There's so much wrong, and in pretty obvious
>> > ways. This code should never have passed review. I'm refrai
Thank you for reviewing! Especially Li Zhijian, who went through pretty
much all the patches. Big chunk of work, much appreciated.
Will send v2 shortly.
On 22/09/2023 23:21, Peter Xu wrote:
> On Thu, Sep 21, 2023 at 08:27:24AM +, Zhijian Li (Fujitsu) wrote:
>> I'm worried that I may not have enough time, ability, or environment to
>> review/test
>> the RDMA patches. but for this patch set, i will take a look later.
>
> That'll be helpful, t
On Thu, Sep 21, 2023 at 08:27:24AM +, Zhijian Li (Fujitsu) wrote:
> I'm worried that I may not have enough time, ability, or environment to
> review/test
> the RDMA patches. but for this patch set, i will take a look later.
That'll be helpful, thanks!
So it seems maybe at least we should hav
Perter,
On 20/09/2023 00:49, Peter Xu wrote:
> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
>> Oh dear, where to start. There's so much wrong, and in pretty obvious
>> ways. This code should never have passed review. I'm refraining from
>> saying more; see the commit mess
Daniel P. Berrangé writes:
> On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote:
>> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
>> > Oh dear, where to start. There's so much wrong, and in pretty obvious
>> > ways. This code should never have passed review. I'm refr
Daniel P. Berrangé writes:
> On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote:
>> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
>> > Oh dear, where to start. There's so much wrong, and in pretty obvious
>> > ways. This code should never have passed review. I'm refr
On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote:
> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
> > Oh dear, where to start. There's so much wrong, and in pretty obvious
> > ways. This code should never have passed review. I'm refraining from
> > saying more; see t
On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote:
> Oh dear, where to start. There's so much wrong, and in pretty obvious
> ways. This code should never have passed review. I'm refraining from
> saying more; see the commit messages instead.
>
> Issues remaining after this serie
Oh dear, where to start. There's so much wrong, and in pretty obvious
ways. This code should never have passed review. I'm refraining from
saying more; see the commit messages instead.
Issues remaining after this series include:
* Terrible error messages
* Some error message cascades remain
12 matches
Mail list logo
