Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-19 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:55 PM, Peter Maydell wrote: > On 14 October 2012 21:49, Blue Swirl wrote: >> On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell >> wrote: >>> On 14 October 2012 21:33, Blue Swirl wrote: On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell wrote: > In general any

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Andreas Färber
Am 14.10.2012 22:33, schrieb Blue Swirl: > On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell > wrote: >> Please don't delete this function, it is the public facing interface >> for allowing board models to attach NAND devices to the GPMC. This >> might not be used by anything currently in mainline,

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Peter Maydell
On 14 October 2012 21:49, Blue Swirl wrote: > On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell > wrote: >> On 14 October 2012 21:33, Blue Swirl wrote: >>> On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell >>> wrote: In general anything in linux-user/arm/nwfpe is legacy code which it's sc

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell wrote: > On 14 October 2012 21:33, Blue Swirl wrote: >> On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell >> wrote: >>> Please don't delete this function, it is the public facing interface >>> for allowing board models to attach NAND devices to the GP

[Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
Add missing 'static' qualifiers and remove unused functions. Signed-off-by: Blue Swirl --- hw/devices.h |3 -- hw/i2c.h |3 -- hw/omap.h |1 - hw/omap_gpmc.c| 21 --- hw/pxa.h

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Peter Maydell
On 14 October 2012 21:33, Blue Swirl wrote: > On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell > wrote: >> Please don't delete this function, it is the public facing interface >> for allowing board models to attach NAND devices to the GPMC. This >> might not be used by anything currently in mainli

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell wrote: > On 14 October 2012 20:58, Blue Swirl wrote: >> index 2fc4137..2c02a83 100644 >> --- a/hw/omap_gpmc.c >> +++ b/hw/omap_gpmc.c >> @@ -871,24 +871,3 @@ void omap_gpmc_attach(struct omap_gpmc_s *s, int cs, >> MemoryRegion *iomem) >> f->iom

Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions

2012-10-14 Thread Peter Maydell
On 14 October 2012 20:58, Blue Swirl wrote: > index 2fc4137..2c02a83 100644 > --- a/hw/omap_gpmc.c > +++ b/hw/omap_gpmc.c > @@ -871,24 +871,3 @@ void omap_gpmc_attach(struct omap_gpmc_s *s, int cs, > MemoryRegion *iomem) > f->iomem = iomem; > omap_gpmc_cs_map(s, cs); > } > - > -void om