On 03/05/2018 08:22, Alexey Kardashevskiy wrote:
> On 2/5/18 7:50 pm, Paolo Bonzini wrote:
>> On 02/05/2018 11:33, Alexey Kardashevskiy wrote:
+# Note: the handler creates an object, enumerates properties and
destroys
+# the object so it only lists properties created in
On 2/5/18 7:50 pm, Paolo Bonzini wrote:
> On 02/05/2018 11:33, Alexey Kardashevskiy wrote:
>>> +# Note: the handler creates an object, enumerates properties and
>>> destroys
>>> +# the object so it only lists properties created in
>>> TypeInfo::instance_init().
>>> +# Since th
On 02/05/2018 15:31, Markus Armbruster wrote:
>> We do have infrastructure for class properties, we just don't use it much.
> ... the sane thing to do would be to limit this command to class
> properties, and use class properties for anything that doesn't *have* to
> be dynamic. The second half of
Paolo Bonzini writes:
> On 02/05/2018 14:36, Markus Armbruster wrote:
>>> The purpose of this command is to tell people/tools what they can pass
>>> to -device/-object/device_add/object_add, so the real question is
>>> whether there are cases where it falls short of that purpose.
>>>
>>> If not,
On 02/05/2018 14:36, Markus Armbruster wrote:
>> The purpose of this command is to tell people/tools what they can pass
>> to -device/-object/device_add/object_add, so the real question is
>> whether there are cases where it falls short of that purpose.
>>
>> If not,
>
> Do we have to be certain?
Paolo Bonzini writes:
> On 02/05/2018 11:38, Markus Armbruster wrote:
> It probably is not unless someone adds properties in realize() callback,
Now work that into the doc comment, please :)
>>> Are there any examples?
>> There must be examples where instances of the same type have diffe
On 02/05/2018 11:33, Alexey Kardashevskiy wrote:
>> +# Note: the handler creates an object, enumerates properties and
>> destroys
>> +# the object so it only lists properties created in
>> TypeInfo::instance_init().
>> +# Since the instance_init() callback of the device object
On 02/05/2018 11:38, Markus Armbruster wrote:
It probably is not unless someone adds properties in realize() callback,
>>> Now work that into the doc comment, please :)
>> Are there any examples?
> There must be examples where instances of the same type have different
> properties, or else our
Paolo Bonzini writes:
> On 02/05/2018 08:34, Markus Armbruster wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 30/4/18 7:39 pm, Paolo Bonzini wrote:
On 30/04/2018 08:52, Alexey Kardashevskiy wrote:
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 5636f4a..399ec74 100644
On 2/5/18 7:11 pm, Paolo Bonzini wrote:
> On 02/05/2018 08:34, Markus Armbruster wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 30/4/18 7:39 pm, Paolo Bonzini wrote:
On 30/04/2018 08:52, Alexey Kardashevskiy wrote:
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 5636f4a..399e
On 02/05/2018 08:34, Markus Armbruster wrote:
> Alexey Kardashevskiy writes:
>
>> On 30/4/18 7:39 pm, Paolo Bonzini wrote:
>>> On 30/04/2018 08:52, Alexey Kardashevskiy wrote:
diff --git a/qapi/misc.json b/qapi/misc.json
index 5636f4a..399ec74 100644
--- a/qapi/misc.json
+++ b
Alexey Kardashevskiy writes:
> On 30/4/18 7:39 pm, Paolo Bonzini wrote:
>> On 30/04/2018 08:52, Alexey Kardashevskiy wrote:
>>> diff --git a/qapi/misc.json b/qapi/misc.json
>>> index 5636f4a..399ec74 100644
>>> --- a/qapi/misc.json
>>> +++ b/qapi/misc.json
>>> @@ -1491,6 +1491,10 @@
>>> #
>>> #
On 1/5/18 11:01 pm, Eric Blake wrote:
> On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote:
>> Signed-off-by: Alexey Kardashevskiy
>> ---
>
> There is no rationale in the commit body (a good commit message has a
> one-line summary of "what", then a paragraph stating "why", making it
> easier for
On 30/4/18 7:39 pm, Paolo Bonzini wrote:
> On 30/04/2018 08:52, Alexey Kardashevskiy wrote:
>> diff --git a/qapi/misc.json b/qapi/misc.json
>> index 5636f4a..399ec74 100644
>> --- a/qapi/misc.json
>> +++ b/qapi/misc.json
>> @@ -1491,6 +1491,10 @@
>> #
>> # List properties associated with a device
On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote:
Signed-off-by: Alexey Kardashevskiy
---
There is no rationale in the commit body (a good commit message has a
one-line summary of "what", then a paragraph stating "why", making it
easier for the reviewer to check that the patch itself is th
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180430065235.577-1-...@ozlabs.ru
Subject: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties
implementation specific
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script
On 30/04/2018 08:52, Alexey Kardashevskiy wrote:
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 5636f4a..399ec74 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -1491,6 +1491,10 @@
> #
> # List properties associated with a device.
> #
> +# Note: the handler creates a device obj
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180430065235.577-1-...@ozlabs.ru
Subject: [Qemu-devel] [PATCH qemu] qom: Document qom
On 30/4/18 4:56 pm, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
wow, did not know that the format is that strict :) I'll repost if there is
no other comments about actual notes.
--
Alexey
Hi,
This series failed docker-build@min-glib build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180430065235.577-1-...@ozlabs.ru
Subject: [Qemu-devel] [PATCH qemu] qom: Document qom
Signed-off-by: Alexey Kardashevskiy
---
qapi/misc.json | 9 +
1 file changed, 9 insertions(+)
diff --git a/qapi/misc.json b/qapi/misc.json
index 5636f4a..399ec74 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -1491,6 +1491,10 @@
#
# List properties associated with a device.
#
+#
21 matches
Mail list logo
