Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Samuel Thibault
Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:40:19 +, wrote: > * Samuel Thibault (samuel.thiba...@gnu.org) wrote: > > Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:09:26 +, wrote: > > > but only for Linux. > > > > That's what I was referring to. > > Yes I think that's OK because: >

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Dr. David Alan Gilbert
* Samuel Thibault (samuel.thiba...@gnu.org) wrote: > Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:09:26 +, wrote: > > but only for Linux. > > That's what I was referring to. Yes I think that's OK because: a) The alternative breaks all backwards migration b) This doesn't casuse any p

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Samuel Thibault
Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:09:26 +, wrote: > but only for Linux. That's what I was referring to. Samuel

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Dr. David Alan Gilbert
* Samuel Thibault (samuel.thiba...@gnu.org) wrote: > Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:00:17 +, wrote: > > * Samuel Thibault (samuel.thiba...@gnu.org) wrote: > > > Dr. David Alan Gilbert, on mar. 28 févr. 2017 16:54:46 +, wrote: > > > > I'm thinking one way to do it without c

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Samuel Thibault
Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:00:17 +, wrote: > * Samuel Thibault (samuel.thiba...@gnu.org) wrote: > > Dr. David Alan Gilbert, on mar. 28 févr. 2017 16:54:46 +, wrote: > > > I'm thinking one way to do it without changing the version would > > > be to use the existing valu

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Dr. David Alan Gilbert
* Samuel Thibault (samuel.thiba...@gnu.org) wrote: > Dr. David Alan Gilbert, on mar. 28 févr. 2017 16:54:46 +, wrote: > > I'm thinking one way to do it without changing the version would > > be to use the existing value for IPv4, and on reading allow any other > > value for IPv6 (or just the on

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Samuel Thibault
Dr. David Alan Gilbert, on mar. 28 févr. 2017 16:54:46 +, wrote: > I'm thinking one way to do it without changing the version would > be to use the existing value for IPv4, and on reading allow any other > value for IPv6 (or just the ones we know about); that would make > it inwards migration c

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-28 Thread Dr. David Alan Gilbert
* Samuel Thibault (samuel.thiba...@gnu.org) wrote: > Hello, > > Dr. David Alan Gilbert, on jeu. 23 févr. 2017 11:40:45 +, wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > IOW if we transmit this data on the wire, we've effectively said that > > > our migration data format is

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-26 Thread Samuel Thibault
Samuel Thibault, on dim. 26 févr. 2017 21:34:27 +0100, wrote: > since we'll want to change the size of the field Ah, no, sorry, it was forced to be 16bit, so at least the size is fine. But I guess we don't want to change the values to have cross-OS compatibility without changing the version. Sam

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-26 Thread Samuel Thibault
Hello, Dr. David Alan Gilbert, on jeu. 23 févr. 2017 11:40:45 +, wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > IOW if we transmit this data on the wire, we've effectively said that > > our migration data format is *not* portable across different host OS > > platforms. At that

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-23 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Feb 23, 2017 at 10:51:56AM +, Dr. David Alan Gilbert wrote: > > Samual, Jan: Can you just take 1-3 of this series; 4 has a problem; > > > > * Juan Quintela (quint...@redhat.com) wrote: > > > "Dr. David Alan Gilbert (git)" wrote: > >

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-23 Thread Daniel P. Berrange
On Thu, Feb 23, 2017 at 10:51:56AM +, Dr. David Alan Gilbert wrote: > Samual, Jan: Can you just take 1-3 of this series; 4 has a problem; > > * Juan Quintela (quint...@redhat.com) wrote: > > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Working up th

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-23 Thread Dr. David Alan Gilbert
Samual, Jan: Can you just take 1-3 of this series; 4 has a problem; * Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Working up the stack, this replaces the slirp_socket_load/save > > with VMState definitions. > > >

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Working up the stack, this replaces the slirp_socket_load/save > > with VMState definitions. > > > > A place holder for IPv6 support is added as a comment; it needs > >

Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Working up the stack, this replaces the slirp_socket_load/save > with VMState definitions. > > A place holder for IPv6 support is added as a comment; it needs > testing once the rest of the IPv6 code is there. > > Signed-o

[Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level

2017-02-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Working up the stack, this replaces the slirp_socket_load/save with VMState definitions. A place holder for IPv6 support is added as a comment; it needs testing once the rest of the IPv6 code is there. Signed-off-by: Dr. David Alan Gilbert --- slirp/slirp.c | 1