Re: [PATCH 9.0 00/13] Consolidate common vdpa members in VhostVDPAShared

2023-11-29 Thread Eugenio Perez Martin
On Thu, Nov 30, 2023 at 4:22 AM Lei Yang wrote: > > Hi Eugenio > > QE performed regression testing after applying this patch. This series > patch introduced a qemu core dump bug, for the core dump information > please review the attached file. > Hi Lei, thank you very much for the testing! Can

Re: [PATCH v3 04/70] HostMem: Add mechanism to opt in kvm guest memfd via MachineState

2023-11-29 Thread Xiaoyao Li
On 11/20/2023 5:30 PM, David Hildenbrand wrote: On 16.11.23 03:53, Xiaoyao Li wrote: On 11/16/2023 2:14 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Add a new member "require_guest_memfd" to memory backends. When it's set to true, it enables RAM_GUEST_MEMFD in ram_flags,

Re: [PATCH v3 02/70] RAMBlock: Add support of KVM private guest memfd

2023-11-29 Thread Xiaoyao Li
On 11/20/2023 5:24 PM, David Hildenbrand wrote:   uint8_t memory_region_get_dirty_log_mask(MemoryRegion *mr)   {   uint8_t mask = mr->dirty_log_mask; diff --git a/system/physmem.c b/system/physmem.c index fc2b0fee0188..0af2213cbd9c 100644 --- a/system/physmem.c +++ b/system/physmem.c @@

Re: [PATCH v3 02/70] RAMBlock: Add support of KVM private guest memfd

2023-11-29 Thread Xiaoyao Li
On 11/20/2023 5:19 PM, David Hildenbrand wrote: On 16.11.23 03:45, Xiaoyao Li wrote: On 11/16/2023 1:54 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Add KVM guest_memfd support to RAMBlock so both normal hva based memory and kvm guest memfd based private memory can be

Re: [PATCH v3 03/70] RAMBlock/guest_memfd: Enable KVM_GUEST_MEMFD_ALLOW_HUGEPAGE

2023-11-29 Thread Xiaoyao Li
On 11/20/2023 5:26 PM, David Hildenbrand wrote: ... did you shamelessly copy that from hw/virtio/virtio-mem.c ? ;) Get caught. This should be factored out into a common helper. Sure, will do it in next version. Factor it out in a separate patch. Then, this patch is get small that you

Re: [PATCH v4] migration: Plug memory leak with migration URIs

2023-11-29 Thread Markus Armbruster
Het Gala writes: > migrate_uri_parse() allocates memory to 'channel' if the user > opts for old syntax - uri, which is leaked because there is no > code for freeing 'channel'. > So, free channel to avoid memory leak in case where 'channels' > is empty and uri parsing is required. > > Fixes:

Re: [PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs

2023-11-29 Thread Markus Armbruster
Stefan Hajnoczi writes: > The term "QEMU global mutex" is identical to the more widely used Big > QEMU Lock ("BQL"). Update the code comments and documentation to use > "BQL" instead of "QEMU global mutex". > > Signed-off-by: Stefan Hajnoczi For QAPI Acked-by: Markus Armbruster

Re: [PATCH v3] migration: free 'channel' after its use in migration.c

2023-11-29 Thread Markus Armbruster
Het Gala writes: > On 29/11/23 6:21 pm, Markus Armbruster wrote: >> I'ld like to suggest a clearer subject: >> >>migration: Plug memory leak with migration URIs > Ack. Will update the commit message >> Het Gala writes: >> >>> 'channel' in qmp_migrate() and qmp_migrate_incoming() is not >>>

Re: [PATCH v2 04/14] spapr: nested: Introduce cap-nested-papr for Nested PAPR API

2023-11-29 Thread Harsh Prateek Bora
On 11/29/23 09:31, Nicholas Piggin wrote: On Thu Oct 12, 2023 at 8:49 PM AEST, Harsh Prateek Bora wrote: Introduce a SPAPR capability cap-nested-papr which provides a nested HV facility to the guest. This is similar to cap-nested-hv, but uses a different (incompatible) API and so they are

Re: [PATCH v1 2/2] hw/mem/cxl_type3: allocate more vectors for MSI-X

2023-11-29 Thread Hyeonggon Yoo
On Tue, Nov 28, 2023 at 9:46 PM Jonathan Cameron wrote: > > On Tue, 28 Nov 2023 09:27:28 +0900 > Hyeonggon Yoo <42.hye...@gmail.com> wrote: > > > On Tue, Nov 28, 2023 at 2:53 AM Davidlohr Bueso wrote: > > > > > > On Mon, 27 Nov 2023, Hyeonggon Yoo wrote: > > > > > > >commit 43efb0bfad2b

Re: [PATCH 9.0 00/13] Consolidate common vdpa members in VhostVDPAShared

2023-11-29 Thread Lei Yang
Hi Eugenio QE performed regression testing after applying this patch. This series patch introduced a qemu core dump bug, for the core dump information please review the attached file. Tested-by: Lei Yang On Sat, Nov 25, 2023 at 1:14 AM Eugenio Pérez wrote: > > Current memory operations

[PATCH v4] crypto: Introduce SM4 symmetric cipher algorithm

2023-11-29 Thread Hyman Huang
Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). SM4 (GBT.32907-2016) is a cryptographic standard issued by the Organization of State Commercial Administration of China (OSCCA) as an authorized cryptographic algorithms for the use within China. Use the crypto-sm4 meson build option

Re: [PATCH v3] ppc/amigaone: Allow running AmigaOS without firmware image

2023-11-29 Thread BALATON Zoltan
On Tue, 28 Nov 2023, Cédric Le Goater wrote: On 11/28/23 02:32, BALATON Zoltan wrote: The machine uses a modified U-Boot under GPL license but the sources of it are lost with only a binary available so it cannot be included in QEMU. Allow running without the firmware image which can be used

[PATCH v4] ppc/amigaone: Allow running AmigaOS without firmware image

2023-11-29 Thread BALATON Zoltan
The machine uses a modified U-Boot under GPL license but the sources of it are lost with only a binary available so it cannot be included in QEMU. Allow running without the firmware image which can be used when calling a boot loader directly and thus simplifying booting guests. We need a small

Re: [PATCH v7 00/10] Introduce model for IBM's FSI

2023-11-29 Thread Cédric Le Goater
On 11/29/23 22:29, Cédric Le Goater wrote: On 11/29/23 15:56, Ninad Palsule wrote: Hello Cedric, On 11/27/23 10:31, Cédric Le Goater wrote: Hello Ninad, On 10/26/23 18:47, Ninad Palsule wrote: Hello, Please review the patch-set version 7. I have incorporated review comments from Cedric,

Re: [PATCH v7 00/10] Introduce model for IBM's FSI

2023-11-29 Thread Cédric Le Goater
On 11/29/23 15:56, Ninad Palsule wrote: Hello Cedric, On 11/27/23 10:31, Cédric Le Goater wrote: Hello Ninad, On 10/26/23 18:47, Ninad Palsule wrote: Hello, Please review the patch-set version 7. I have incorporated review comments from Cedric, Philippe and Thomas. I reworked v7 with the

[PATCH 0/6] Make Big QEMU Lock naming consistent

2023-11-29 Thread Stefan Hajnoczi
The Big QEMU Lock ("BQL") has two other names: "iothread lock" and "QEMU global mutex". The term "iothread lock" is easily confused with the unrelated --object iothread (iothread.c). This series updates the code and documentation to consistently use "BQL". This makes the code easier to

[PATCH 2/6] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to QEMU_BQL_LOCK_GUARD

2023-11-29 Thread Stefan Hajnoczi
The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi --- include/qemu/main-loop.h | 20 ++-- hw/i386/kvm/xen_evtchn.c | 14 +++--- hw/i386/kvm/xen_gnttab.c | 2 +-

[PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs

2023-11-29 Thread Stefan Hajnoczi
The term "QEMU global mutex" is identical to the more widely used Big QEMU Lock ("BQL"). Update the code comments and documentation to use "BQL" instead of "QEMU global mutex". Signed-off-by: Stefan Hajnoczi --- docs/devel/multi-thread-tcg.rst | 7 +++ docs/devel/qapi-code-gen.rst |

[PATCH 5/6] Replace "iothread lock" with "BQL" in comments

2023-11-29 Thread Stefan Hajnoczi
The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL) in their names. Update the code comments to use "BQL" instead of "iothread lock". Signed-off-by: Stefan Hajnoczi --- docs/devel/reset.rst | 2 +- hw/display/qxl.h | 2 +-

[PATCH 3/6] qemu/main-loop: rename qemu_cond_wait_iothread() to qemu_cond_wait_bql()

2023-11-29 Thread Stefan Hajnoczi
The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi --- include/qemu/main-loop.h | 8 accel/tcg/tcg-accel-ops-rr.c | 4 ++-- hw/display/virtio-gpu.c | 2 +-

[PATCH 1/6] system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()

2023-11-29 Thread Stefan Hajnoczi
The Big QEMU Lock (BQL) has many names and they are confusing. The actual QemuMutex variable is called qemu_global_mutex but it's commonly referred to as the BQL in discussions and some code comments. The locking APIs, however, are called qemu_mutex_lock_iothread() and

[PATCH 4/6] system/cpus: rename qemu_global_mutex to qemu_bql

2023-11-29 Thread Stefan Hajnoczi
The APIs using qemu_global_mutex now follow the Big QEMU Lock (BQL) nomenclature. It's a little strange that the actual QemuMutex variable that embodies the BQL is called qemu_global_mutex instead of qemu_bql. Rename it for consistency. Signed-off-by: Stefan Hajnoczi --- system/cpus.c | 20

Re: [RFC PATCH v2 17/19] heki: x86: Update permissions counters during text patching

2023-11-29 Thread Madhavan T. Venkataraman
On 11/27/23 14:08, Peter Zijlstra wrote: > On Mon, Nov 27, 2023 at 10:48:29AM -0600, Madhavan T. Venkataraman wrote: >> Apologies for the late reply. I was on vacation. Please see my response >> below: >> >> On 11/13/23 02:19, Peter Zijlstra wrote: >>> On Sun, Nov 12, 2023 at 09:23:24PM -0500,

[PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-29 Thread Philippe Mathieu-Daudé
'can_do_io' is specific to TCG. Having it set in non-TCG code is confusing, so remove it from QTest / HVF / KVM. Signed-off-by: Philippe Mathieu-Daudé --- accel/dummy-cpus.c| 1 - accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-ops.c | 1 - 3 files changed, 3 deletions(-) diff

[PATCH v4] migration: Plug memory leak with migration URIs

2023-11-29 Thread Het Gala
migrate_uri_parse() allocates memory to 'channel' if the user opts for old syntax - uri, which is leaked because there is no code for freeing 'channel'. So, free channel to avoid memory leak in case where 'channels' is empty and uri parsing is required. Fixes: 5994024f ("migration: Implement

Re: [PATCH v3] migration: free 'channel' after its use in migration.c

2023-11-29 Thread Het Gala
On 29/11/23 6:21 pm, Markus Armbruster wrote: I'ld like to suggest a clearer subject: migration: Plug memory leak with migration URIs Ack. Will update the commit message Het Gala writes: 'channel' in qmp_migrate() and qmp_migrate_incoming() is not auto-freed. migrate_uri_parse()

Re: [PATCH v2 09/10] block: Convert qmp_query_block() to coroutine_fn

2023-11-29 Thread Fabiano Rosas
Hanna Czenczek writes: > On 09.06.23 22:19, Fabiano Rosas wrote: >> This is another caller of bdrv_get_allocated_file_size() that needs to >> be converted to a coroutine because that function will be made >> asynchronous when called (indirectly) from the QMP dispatcher. >> >> This QMP command is

[PATCH 10/12] scsi: remove outdated AioContext lock comment

2023-11-29 Thread Stefan Hajnoczi
The SCSI subsystem no longer uses the AioContext lock. Request processing runs exclusively in the BlockBackend's AioContext since "scsi: only access SCSIDevice->requests from one thread" and hence the lock is unnecessary. Signed-off-by: Stefan Hajnoczi --- hw/scsi/scsi-disk.c | 1 - 1 file

[PATCH 07/12] aio-wait: draw equivalence between AIO_WAIT_WHILE() and AIO_WAIT_WHILE_UNLOCKED()

2023-11-29 Thread Stefan Hajnoczi
Now that the AioContext lock no longer exists, AIO_WAIT_WHILE() and AIO_WAIT_WHILE_UNLOCKED() are equivalent. A future patch will get rid of AIO_WAIT_WHILE_UNLOCKED(). Signed-off-by: Stefan Hajnoczi --- include/block/aio-wait.h | 16 1 file changed, 4 insertions(+), 12

[PATCH 09/12] docs: remove AioContext lock from IOThread docs

2023-11-29 Thread Stefan Hajnoczi
Encourage the use of locking primitives and stop mentioning the AioContext lock since it is being removed. Signed-off-by: Stefan Hajnoczi --- docs/devel/multiple-iothreads.txt | 45 +++ 1 file changed, 15 insertions(+), 30 deletions(-) diff --git

[PATCH 12/12] block: remove outdated AioContext locking comments

2023-11-29 Thread Stefan Hajnoczi
The AioContext lock no longer exists. There is one noteworthy change: - * More specifically, these functions use BDRV_POLL_WHILE(bs), which - * requires the caller to be either in the main thread and hold - * the BlockdriverState (bs) AioContext lock, or directly in the - * home thread

[PATCH 02/12] tests: remove aio_context_acquire() tests

2023-11-29 Thread Stefan Hajnoczi
The aio_context_acquire() API is being removed. Drop the test case that calls the API. Signed-off-by: Stefan Hajnoczi --- tests/unit/test-aio.c | 67 +-- 1 file changed, 1 insertion(+), 66 deletions(-) diff --git a/tests/unit/test-aio.c

[PATCH 11/12] job: remove outdated AioContext locking comments

2023-11-29 Thread Stefan Hajnoczi
The AioContext lock no longer exists. Signed-off-by: Stefan Hajnoczi --- include/qemu/job.h | 20 1 file changed, 20 deletions(-) diff --git a/include/qemu/job.h b/include/qemu/job.h index e502787dd8..9ea98b5927 100644 --- a/include/qemu/job.h +++ b/include/qemu/job.h @@

[PATCH 06/12] scsi: remove AioContext locking

2023-11-29 Thread Stefan Hajnoczi
The AioContext lock no longer has any effect. Remove it. Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/virtio-scsi.h | 14 -- hw/scsi/scsi-bus.c | 2 -- hw/scsi/scsi-disk.c | 28 hw/scsi/virtio-scsi.c | 18

[PATCH 04/12] graph-lock: remove AioContext locking

2023-11-29 Thread Stefan Hajnoczi
Stop acquiring/releasing the AioContext lock in bdrv_graph_wrlock()/bdrv_graph_unlock() since the lock no longer has any effect. The distinction between bdrv_graph_wrunlock() and bdrv_graph_wrunlock_ctx() becomes meaningless and they can be collapsed into one function. Signed-off-by: Stefan

[PATCH 00/12] aio: remove AioContext lock

2023-11-29 Thread Stefan Hajnoczi
This series removes the AioContext locking APIs from QEMU. aio_context_acquire() and aio_context_release() are currently only needed to support the locking discipline required by AIO_POLL_WHILE() (except for a stray user that I converted in Patch 1). AIO_POLL_WHILE() doesn't really need the

[PATCH 08/12] aio: remove aio_context_acquire()/aio_context_release() API

2023-11-29 Thread Stefan Hajnoczi
Delete these functions because nothing calls these functions anymore. I introduced these APIs in commit 98563fc3ec44 ("aio: add aio_context_acquire() and aio_context_release()") in 2014. It's with a sigh of relief that I delete these APIs almost 10 years later. Thanks to Paolo Bonzini's vision

[PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-11-29 Thread Stefan Hajnoczi
Protect the Task Management Function BH state with a lock. The TMF BH runs in the main loop thread. An IOThread might process a TMF at the same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh must be protected by a lock. Run TMF request completion in the IOThread using

[PATCH 03/12] aio: make aio_context_acquire()/aio_context_release() a no-op

2023-11-29 Thread Stefan Hajnoczi
aio_context_acquire()/aio_context_release() has been replaced by fine-grained locking to protect state shared by multiple threads. The AioContext lock still plays the role of balancing locking in AIO_WAIT_WHILE() and many functions in QEMU either require that the AioContext lock is held or not

Re: [RFC PATCH v2 18/19] heki: x86: Protect guest kernel memory using the KVM hypervisor

2023-11-29 Thread Madhavan T. Venkataraman
On 11/27/23 14:03, Peter Zijlstra wrote: > On Mon, Nov 27, 2023 at 11:05:23AM -0600, Madhavan T. Venkataraman wrote: >> Apologies for the late reply. I was on vacation. Please see my response >> below: >> >> On 11/13/23 02:54, Peter Zijlstra wrote: >>> On Sun, Nov 12, 2023 at 09:23:25PM -0500,

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Peter Maydell
On Wed, 29 Nov 2023 at 16:49, Daniel P. Berrangé wrote: > > On Wed, Nov 29, 2023 at 08:50:06AM -0700, Warner Losh wrote: > > I'd honestly optimize for 'frequent merges of smaller things' rather than > > 'infrequent merges of larger things'. The latter has caused most of the > > issues for me.

Re: [PATCH] hw/core/cpu: Update description of CPUState::node

2023-11-29 Thread Richard Henderson
On 11/29/23 12:32, Philippe Mathieu-Daudé wrote: 'next_cpu' was converted to 'node' in commit bdc44640cb ("cpu: Use QTAILQ for CPU list"). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] hw/core/cpu: Remove final vestiges of dynamic state tracing

2023-11-29 Thread Richard Henderson
On 11/29/23 12:27, Philippe Mathieu-Daudé wrote: The dynamic state tracing was removed in commit d0aaf08bb9. Fixes: d0aaf08bb9 ("tcg: remove the final vestiges of dstate") Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH] hw/core/cpu: Update description of CPUState::node

2023-11-29 Thread Philippe Mathieu-Daudé
'next_cpu' was converted to 'node' in commit bdc44640cb ("cpu: Use QTAILQ for CPU list"). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index

[PATCH] hw/core/cpu: Remove final vestiges of dynamic state tracing

2023-11-29 Thread Philippe Mathieu-Daudé
The dynamic state tracing was removed in commit d0aaf08bb9. Fixes: d0aaf08bb9 ("tcg: remove the final vestiges of dstate") Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Stefan Hajnoczi
On Wed, 29 Nov 2023 at 11:57, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > To give a picture of the state of the CI, I'd say it fails 80% of the > > time. Usually 2 or 3 of the tests fail randomly from a group of <10 > > tests that commonly fail randomly. > > Do you have a list anywhere?

Re: [PATCH 4/4] hw/misc/ivshmem: Rename ivshmem to ivshmem-pci

2023-11-29 Thread Philippe Mathieu-Daudé
On 27/11/23 06:20, Gustavo Romero wrote: Because now there is also an MMIO ivshmem device (ivshmem-flat.c), and ivshmem.c is a PCI specific implementation, rename it to ivshmem-pci.c. Signed-off-by: Gustavo Romero --- hw/misc/{ivshmem.c => ivshmem-pci.c} | 0 hw/misc/meson.build

Re: [PATCH 1/4] Add ivshmem-flat device

2023-11-29 Thread Philippe Mathieu-Daudé
On 27/11/23 06:20, Gustavo Romero wrote: Add a new device, ivshmem-flat, which is similar to the ivshmem PCI but does not require a PCI bus. It's meant to be used on machines like those with Cortex-M MCUs, which usually lack a PCI/PCIe bus, e.g. lm3s6965evb and mps2-an385. The device currently

Re: [PATCH v3] crypto: Introduce SM4 symmetric cipher algorithm

2023-11-29 Thread Philippe Mathieu-Daudé
On 29/11/23 16:17, Hyman Huang wrote: Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). SM4 (GBT.32907-2016) is a cryptographic standard issued by the Organization of State Commercial Administration of China (OSCCA) as an authorized cryptographic algorithms for the use within China.

[PATCH v3 4/4] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Thomas Weißschuh
Shutdown requests are normally hardware dependent. By extending pvpanic to also handle shutdown requests, guests can submit such requests with an easily implementable and cross-platform mechanism. Signed-off-by: Thomas Weißschuh --- docs/specs/pvpanic.rst| 2 ++ hw/misc/pvpanic.c |

[PATCH v3 3/4] tests/qtest/pvpanic: use centralized definition of supported events

2023-11-29 Thread Thomas Weißschuh
Avoid the necessity to update all tests when new events are added to the device. Acked-by: Thomas Huth Signed-off-by: Thomas Weißschuh --- tests/qtest/pvpanic-pci-test.c | 5 +++-- tests/qtest/pvpanic-test.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH v3 2/4] hw/misc/pvpanic: centralize definition of supported events

2023-11-29 Thread Thomas Weißschuh
The different components of pvpanic duplicate the list of supported events. Move it to the shared header file to minimize changes when new events are added. Signed-off-by: Thomas Weißschuh --- hw/misc/pvpanic-isa.c | 2 +- hw/misc/pvpanic-pci.c | 2 +- hw/misc/pvpanic.c | 2 +-

[PATCH v3 1/4] linux-headers: drop pvpanic.h

2023-11-29 Thread Thomas Weißschuh
misc/pvpanic.h from the Linux UAPI does not define a Linux UAPI but a qemu device API. This leads to a weird process when updates to the interface are needed: 1) Change to the specification in the qemu tree 2) Change to the header in the Linux tree 3) Re-import of the header into Qemu. The

[PATCH v3 0/4] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Thomas Weißschuh
Shutdown requests are normally hardware dependent. By extending pvpanic to also handle shutdown requests, guests can submit such requests with an easily implementable and cross-platform mechanism. The background is the usage of minimal Linux kernels with different architectures for testing

Re: [BUG] accel/tcg: cpu_exec_longjmp_cleanup: assertion failed: (cpu == current_cpu)

2023-11-29 Thread Petr Cvek
Dne 29. 11. 23 v 15:25 Richard Henderson napsal(a): > On 11/25/23 07:08, Petr Cvek wrote: >> ERROR:../accel/tcg/cpu-exec.c:546:cpu_exec_longjmp_cleanup: assertion >> failed: (cpu == current_cpu) >> Bail out! ERROR:../accel/tcg/cpu-exec.c:546:cpu_exec_longjmp_cleanup: >> assertion failed: (cpu ==

Re: [PATCH v2 2/2] vhost-scsi: Add support for a worker thread per virtqueue

2023-11-29 Thread Mike Christie
On 11/29/23 3:30 AM, Stefano Garzarella wrote: > On Sun, Nov 26, 2023 at 06:28:34PM -0600, Mike Christie wrote: >> This adds support for vhost-scsi to be able to create a worker thread >> per virtqueue. Right now for vhost-net we get a worker thread per >> tx/rx virtqueue pair which scales nicely

Re: [PATCH 2/2] target/riscv: The whole vector register move instructions depend on vsew

2023-11-29 Thread Richard Henderson
On 11/29/23 11:03, Max Chou wrote: The RISC-V v spec 16.6 section says that the whole vector register move instructions operate as if EEW=SEW. So it should depends on the vsew field of vtype register. Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 3 +-- 1 file

[PATCH v2] accel/kvm: Turn DPRINTF macro use into tracepoints

2023-11-29 Thread Jai Arora
Patch removes DRPINTF macro and adds multiple tracepoints to capture different kvm events. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1827 Signed-off-by: Jai Arora --- accel/kvm/kvm-all.c| 33 +++-- accel/kvm/trace-events | 8 +++- 2 files

[PATCH 0/2] Make vector whole-register move (vmv) depend on vtype register

2023-11-29 Thread Max Chou
The ratified v1.0 version of RISC-V V spec section 16.6 says that `The instructions operate as if EEW=SEW.`. So the whole vector register move instructions depend on the vtype register that means the implementation needs to be fixed to raise an illegal-instruction exception when vtype.vill=1, as

[PATCH 2/2] target/riscv: The whole vector register move instructions depend on vsew

2023-11-29 Thread Max Chou
The RISC-V v spec 16.6 section says that the whole vector register move instructions operate as if EEW=SEW. So it should depends on the vsew field of vtype register. Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 1/2] target/riscv: Add vill check for whole vector register move instructions

2023-11-29 Thread Max Chou
The ratified version of RISC-V V spec section 16.6 says that `The instructions operate as if EEW=SEW`. So the whole vector register move instructions depend on the vtype register that means the whole vector register move instructions should raise an illegal-instruction exception when

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Alex Bennée
Stefan Hajnoczi writes: > To give a picture of the state of the CI, I'd say it fails 80% of the > time. Usually 2 or 3 of the tests fail randomly from a group of <10 > tests that commonly fail randomly. Do you have a list anywhere? > > In order for the CI to be usable to submaintainers I think

Re: [RFC/PATCH v0 03/12] gunyah: Basic support

2023-11-29 Thread Alex Bennée
Srivatsa Vaddagiri writes: > Add a new accelerator, gunyah, with basic functionality of creating a > VM. Subsequent patches will add support for other functions required to > run a VM. > > Signed-off-by: Srivatsa Vaddagiri Hmm this failed to build: FAILED:

Re: [PATCH v2] crypto: Introduce SM4 symmetric cipher algorithm

2023-11-29 Thread Daniel P . Berrangé
On Wed, Nov 29, 2023 at 09:40:29AM +0800, Yong Huang wrote: > I'll try to understand the comment, if i misunderstood, please point out. > > On Wed, Nov 29, 2023 at 12:20 AM Daniel P. Berrangé > wrote: > > > On Tue, Nov 28, 2023 at 04:57:20PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi Hyman,

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Daniel P . Berrangé
On Wed, Nov 29, 2023 at 08:50:06AM -0700, Warner Losh wrote: > On Wed, Nov 29, 2023 at 8:44 AM Daniel P. Berrangé > wrote: > > > On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote: > > > On 11/21/23 18:11, Alex Bennée wrote: > > > > Peter Maydell writes: > > > > > > > > > QEMU

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Stefan Hajnoczi
On Wed, 29 Nov 2023 at 11:46, Daniel P. Berrangé wrote: > > On Wed, Nov 29, 2023 at 10:53:00AM -0500, Stefan Hajnoczi wrote: > > To give a picture of the state of the CI, I'd say it fails 80% of the > > time. Usually 2 or 3 of the tests fail randomly from a group of <10 > > tests that commonly

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Daniel P . Berrangé
On Wed, Nov 29, 2023 at 10:53:00AM -0500, Stefan Hajnoczi wrote: > To give a picture of the state of the CI, I'd say it fails 80% of the > time. Usually 2 or 3 of the tests fail randomly from a group of <10 > tests that commonly fail randomly. > > In order for the CI to be usable to

Re: [RFC/PATCH v0 02/12] update-linux-headers: Include gunyah.h

2023-11-29 Thread Alex Bennée
Srivatsa Vaddagiri writes: > gunyah.h containts UAPI definitions exported by Gunyah Linux kernel > driver. This file will be referenced by Gunyah accelerator driver in > Qemu. > > Note: Gunyah Linux kernel driver is not yet merged in Linux kernel. > v14 of the patch series has been posted on

Re: [PATCH v3 20/20] mcdstub: updated MAINTAINERS file and fully activated the mcdstub in the meson build system

2023-11-29 Thread Alex Bennée
Nicolas Eder writes: > --- > MAINTAINERS| 11 +++ > mcdstub/meson.build| 15 +++ > meson.build| 1 + > target/arm/meson.build | 1 + > 4 files changed, 28 insertions(+) > create mode 100644 mcdstub/meson.build > > diff --git a/MAINTAINERS

Re: [PATCH v3 05/20] mcdstub: tcp packet processing added

2023-11-29 Thread Alex Bennée
Nicolas Eder writes: > --- > include/mcdstub/mcdstub.h | 144 > mcdstub/mcdstub.c | 277 ++ > 2 files changed, 421 insertions(+) > > diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h > index 36058157ae..1461d0e1cb

Re: [PATCH v3 04/20] mcdstub: added header with defines specific to the mcd tcp packet communication

2023-11-29 Thread Alex Bennée
Nicolas Eder writes: > --- > include/mcdstub/mcd_shared_defines.h | 108 +++ > 1 file changed, 108 insertions(+) > create mode 100644 include/mcdstub/mcd_shared_defines.h > > diff --git a/include/mcdstub/mcd_shared_defines.h > b/include/mcdstub/mcd_shared_defines.h >

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Stefan Hajnoczi
To give a picture of the state of the CI, I'd say it fails 80% of the time. Usually 2 or 3 of the tests fail randomly from a group of <10 tests that commonly fail randomly. In order for the CI to be usable to submaintainers I think it should _pass_ at least 90% of the time. There is still some

Re: [PATCH v3 03/20] gdbstub: moving code so that it can be easier accessed from outside the gdbstub: fromhex and tohex functions moved to a cutils header. GDBRegisterState moved to gdbstub.h

2023-11-29 Thread Alex Bennée
Nicolas Eder writes: > --- > gdbstub/gdbstub.c | 9 + > gdbstub/internals.h| 26 -- > include/cutils.h | 30 ++ > include/exec/gdbstub.h | 9 - Please split into the utils and the reg state patches as they are

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Warner Losh
On Wed, Nov 29, 2023 at 8:44 AM Daniel P. Berrangé wrote: > On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote: > > On 11/21/23 18:11, Alex Bennée wrote: > > > Peter Maydell writes: > > > > > > > QEMU Summit Minutes 2023 > > > > > > > > > > > > As usual,

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Stefan Hajnoczi
On Wed, 29 Nov 2023 at 09:22, Philippe Mathieu-Daudé wrote: > > On 28/11/23 19:06, Daniel P. Berrangé wrote: > > On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote: > > > Anyway, when a maintainer wants to merge a tree, I would expect to > > have a MR opened against 'master' in

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Warner Losh
On Wed, Nov 29, 2023 at 8:33 AM Philippe Mathieu-Daudé wrote: > On 28/11/23 19:06, Daniel P. Berrangé wrote: > > On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote: > > > Anyway, when a maintainer wants to merge a tree, I would expect to > > have a MR opened against 'master' in

Re: [PATCH for-6.1 v6 14/17] accel/tcg: Move breakpoint recognition outside translation

2023-11-29 Thread Max Filippov
On Tue, Nov 28, 2023 at 10:06 AM Richard Henderson wrote: > On 11/28/23 05:08, Philippe Mathieu-Daudé wrote: > > (In sysemu there is a single use in Xtensa tb_invalidate_virtual_addr). > > I suspect that should be migrated to use the common HW breakpoint support. I'm taking a look. -- Thanks.

Re: [PATCH v3 01/20] mcdstub: initial file structure for new mcdstub created. -mcd QEMU startup option added. Functions for initializing the mcdstub added. Basic helper functions for processes/cpus in

2023-11-29 Thread Alex Bennée
Nicolas Eder writes: I think you need to ensure an extra line in you git commit messages because currently the whole commit runs into your subject. foo/bar: summary of change made longer description of the problem and how the patch solves it. This can continue to be multiple lines of

[PATCH v3] crypto: Introduce SM4 symmetric cipher algorithm

2023-11-29 Thread Hyman Huang
Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). SM4 (GBT.32907-2016) is a cryptographic standard issued by the Organization of State Commercial Administration of China (OSCCA) as an authorized cryptographic algorithms for the use within China. Use the crypto-sm4 meson build option

Re: [PATCH v1] riscv: support new isa extension detection devicetree properties

2023-11-29 Thread Conor Dooley
On Wed, Nov 29, 2023 at 11:37:00AM -0300, Daniel Henrique Barboza wrote: > On 11/29/23 07:39, Conor Dooley wrote: > > From: Conor Dooley > > > > A few months ago I submitted a patch to various lists, deprecating > > "riscv,isa" with a lengthy commit message [0] that is now commit > >

Re: [PATCH v3 00/20] first version of mcdstub

2023-11-29 Thread nicolas.e...@lauterbach.com
On 29/11/2023 15:44, Alex Bennée wrote: Nicolas Eder writes: SUMMARY === This patch-set introduces the first version of the mcdstub. The mcdstub is a debug interface, which enables debugging QEMU using the MCD (Multi-Core Debug) API. The mcdstub uses TCP to communicate with the host

Re: [PATCH v7 00/10] Introduce model for IBM's FSI

2023-11-29 Thread Ninad Palsule
Hello Cedric, On 11/27/23 10:31, Cédric Le Goater wrote: Hello Ninad, On 10/26/23 18:47, Ninad Palsule wrote: Hello, Please review the patch-set version 7. I have incorporated review comments from Cedric, Philippe and Thomas. I reworked v7 with the suggestions I made in patches 1-6.

Re: [PATCH 0/4] ICH9 root PCI hotplug

2023-11-29 Thread Michael S. Tsirkin
On Wed, Nov 29, 2023 at 09:47:13AM +, Thierry Escande wrote: > On 24/11/2023 15:54, Michael S. Tsirkin wrote: > > On Fri, Nov 24, 2023 at 03:01:35PM +0100, Igor Mammedov wrote: > > > On Wed, 15 Nov 2023 17:18:53 + > > > Thierry Escande wrote: > > > > > > > Hi, > > > > > > > > This

Re: [PATCH v3] migration: free 'saddr' since be no longer used

2023-11-29 Thread Peter Xu
On Wed, Nov 29, 2023 at 10:09:12AM +0800, Zongmin Zhou wrote: > Ping? Has this been forgotten? Juan, Would you send a pull to include this? Thanks! -- Peter Xu

Re: [PATCH v3 00/20] first version of mcdstub

2023-11-29 Thread Alex Bennée
Nicolas Eder writes: > SUMMARY > === > > This patch-set introduces the first version of the mcdstub. > The mcdstub is a debug interface, which enables debugging QEMU > using the MCD (Multi-Core Debug) API. > The mcdstub uses TCP to communicate with the host debug software. However, > because

Re: [PATCH v1] riscv: support new isa extension detection devicetree properties

2023-11-29 Thread Daniel Henrique Barboza
On 11/29/23 07:39, Conor Dooley wrote: From: Conor Dooley A few months ago I submitted a patch to various lists, deprecating "riscv,isa" with a lengthy commit message [0] that is now commit aeb71e42caae ("dt-bindings: riscv: deprecate riscv,isa") in the Linux kernel tree. Primarily, the

Re: [PATCH] qemu/timer: Don't use RDTSC on i486

2023-11-29 Thread Richard Henderson
On 11/29/23 07:50, Petr Cvek wrote: I can agree that binary compiled for i486 doesn't contain cmpxchg8b and works OK with exception of setjmp bug I described in another thread [1]. glxgears which doesn't use signals works without problem. 64bit atomic operations seems to be emulated in

Re: [BUG] accel/tcg: cpu_exec_longjmp_cleanup: assertion failed: (cpu == current_cpu)

2023-11-29 Thread Richard Henderson
On 11/25/23 07:08, Petr Cvek wrote: ERROR:../accel/tcg/cpu-exec.c:546:cpu_exec_longjmp_cleanup: assertion failed: (cpu == current_cpu) Bail out! ERROR:../accel/tcg/cpu-exec.c:546:cpu_exec_longjmp_cleanup: assertion failed: (cpu == current_cpu) # The code fails either with or without

Re: QEMU Summit Minutes 2023

2023-11-29 Thread Philippe Mathieu-Daudé
On 28/11/23 19:06, Daniel P. Berrangé wrote: On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote: Anyway, when a maintainer wants to merge a tree, I would expect to have a MR opened against 'master' in qemu-project/qemu. The CI ought to then run and if it is all green, then

Re: [BUG] accel/tcg: cpu_exec_longjmp_cleanup: assertion failed: (cpu == current_cpu)

2023-11-29 Thread Petr Cvek
Dne 27. 11. 23 v 10:37 Peter Maydell napsal(a): > On Sat, 25 Nov 2023 at 13:09, Petr Cvek wrote: >> >> It seems there is a bug in SIGALRM handling when 486 system emulates x86_64 >> code. > > 486 host is pretty well out of support currently. Can you reproduce > this on a less ancient host CPU

Re: [PATCH] qemu/timer: Don't use RDTSC on i486

2023-11-29 Thread Petr Cvek
I can agree that binary compiled for i486 doesn't contain cmpxchg8b and works OK with exception of setjmp bug I described in another thread [1]. glxgears which doesn't use signals works without problem. 64bit atomic operations seems to be emulated in util/atomic64.c. However I've found out the

Re: [PATCH v1] riscv: support new isa extension detection devicetree properties

2023-11-29 Thread Richard Henderson
On 11/29/23 04:39, Conor Dooley wrote: From: Conor Dooley A few months ago I submitted a patch to various lists, deprecating "riscv,isa" with a lengthy commit message [0] that is now commit aeb71e42caae ("dt-bindings: riscv: deprecate riscv,isa") in the Linux kernel tree. Primarily, the goal

Re: [PATCH v2 0/2] vhost-scsi: Support worker ioctls

2023-11-29 Thread Stefan Hajnoczi
On Sun, Nov 26, 2023 at 06:28:32PM -0600, Mike Christie wrote: > The following patches allow users to configure the vhost worker threads > for vhost-scsi. With vhost-net we get a worker thread per rx/tx virtqueue > pair, but for vhost-scsi we get one worker for all workqueues. This > becomes a

Re: [PATCH v3] migration: free 'channel' after its use in migration.c

2023-11-29 Thread Fabiano Rosas
Markus Armbruster writes: > I'ld like to suggest a clearer subject: > > migration: Plug memory leak with migration URIs > > Het Gala writes: > >> 'channel' in qmp_migrate() and qmp_migrate_incoming() is not >> auto-freed. migrate_uri_parse() allocates memory to 'channel' if > > Not sure we

Re: [PATCH v2 3/3] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Thomas Weißschuh
On 2023-11-29 14:15:14+0100, Cornelia Huck wrote: > On Wed, Nov 29 2023, Thomas Weißschuh wrote: > > On 2023-11-29 09:23:46+0100, Cornelia Huck wrote: > >> On Tue, Nov 28 2023, Thomas Weißschuh wrote: > >> > diff --git a/include/standard-headers/linux/pvpanic.h > >> >

Re: [RFC PATCH] gdbstub: use a better signal when we halt for IO reasons

2023-11-29 Thread Alex Bennée
Alex Bennée writes: > The gdb description GDB_SIGNAL_IO is "I/O possible" and by default gdb > will try and restart the guest, getting us nowhere. Report > GDB_SIGNAL_STOP instead which should at least halt the session at the > failure point. > > Signed-off-by: Alex Bennée > Cc: Luis Machado

Re: [PATCH v2 3/3] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Cornelia Huck
On Wed, Nov 29 2023, Thomas Weißschuh wrote: > On 2023-11-29 09:23:46+0100, Cornelia Huck wrote: >> On Tue, Nov 28 2023, Thomas Weißschuh wrote: >> > diff --git a/include/standard-headers/linux/pvpanic.h >> > b/include/standard-headers/linux/pvpanic.h >> > index 54b7485390d3..38e53ad45929

Re: [PATCH-for-8.2? 2/6] hw/virtio: Free VirtIOIOMMUPCI::vdev.reserved_regions[] on finalize()

2023-11-29 Thread Michael Tokarev
21.11.2023 20:40, Philippe Mathieu-Daudé пишет: Commit 0be6bfac62 ("qdev: Implement variable length array properties") added the DEFINE_PROP_ARRAY() macro with the following comment: * It is the responsibility of the device deinit code to free the * @_arrayfield memory. Commit 8077b8e549

Re: [PATCH-for-8.2? 1/6] hw/virtio: Add VirtioPCIDeviceTypeInfo::instance_finalize field

2023-11-29 Thread Michael Tokarev
21.11.2023 20:40, Philippe Mathieu-Daudé: The VirtioPCIDeviceTypeInfo structure, added in commit a4ee4c8baa ("virtio: Helper for registering virtio device types") got extended in commit 8ea90ee690 ("virtio: add class_size") with the @class_size field. Do similarly with the @instance_finalize

  1   2   >