On Tue, 18 Dec 2012 14:53:30 -0800
Anton Vorontsov wrote:
> Hello Luiz,
>
> On Tue, Dec 18, 2012 at 06:16:55PM -0200, Luiz Capitulino wrote:
> > The auto-ballooning feature automatically performs balloon inflate
> > or deflate based on host and guest memory pressure. This
On Wed, 19 Dec 2012 18:17:09 +0800
Wenchao Xia wrote:
> This patch enable sub info command handler getting meaningful
> parameter.
>
> Signed-off-by: Wenchao Xia
> ---
> hmp-commands.hx |2 +-
> monitor.c | 79
> +++
> 2 files
On Thu, 20 Dec 2012 11:02:16 +0800
Wenchao Xia wrote:
> > On Wed, 19 Dec 2012 18:17:09 +0800
> > Wenchao Xia wrote:
> >
> >>This patch enable sub info command handler getting meaningful
> >> parameter.
> >>
> >> Signed-off-by: Wenchao Xia
> >> ---
> >> hmp-commands.hx |2 +-
> >> mo
On Thu, 20 Dec 2012 05:24:12 +
Dietmar Maurer wrote:
> > > Wow, you're fast! And I'm glad that it works for you, so we have two
> > > full-featured mempressure cgroup users already.
> >
> > Thanks, although I think we need more testing to be sure this does what we
> > want. I mean, the basic
On Thu, 24 Jan 2013 04:44:42 +0100
q...@buildbot.b1-systems.de wrote:
> The Buildbot has detected a new failure on builder monitor_x86_64_debian_6_0
> while building qemu.
I actually dropped that queue, as I'm not using it.
Can you guys remove it from buildslaves?
On Wed, 23 Jan 2013 16:45:50 -0500
pe...@gridcentric.ca wrote:
> From: Peter Feiner
>
> Adds control registers that govern virtual address translation to query-cpus.
>
> Given these registers and the guest's physical memory, which can be obtained
> with dump-guest-memory, a client can perform v
On Thu, 24 Jan 2013 15:18:04 +0800
Lei Li wrote:
> On 01/23/2013 11:47 PM, Luiz Capitulino wrote:
> > On Wed, 23 Jan 2013 17:06:09 +0800
> > Lei Li wrote:
> >
> >> Hi Anthony,
> >>
> >> Resubmit this series with your comments squashed in an
On Thu, 24 Jan 2013 13:12:08 -0500
Peter Feiner wrote:
> > What about converting 'info registers' to QMP (ie. having
> > query-cpu-registers)?
>
> We had thought about it, but we decided to go with this lower hanging fruit
> because it provides immediately useful functionality at a low implemen
On Fri, 25 Jan 2013 13:38:18 +0100
Paolo Bonzini wrote:
> Il 25/01/2013 13:34, Eduardo Habkost ha scritto:
> > On Fri, Jan 25, 2013 at 10:14:43AM -0200, Luiz Capitulino wrote:
> >> On Thu, 24 Jan 2013 13:12:08 -0500
> >> Peter Feiner wrote:
> >>
> >>
On Fri, 25 Jan 2013 00:03:21 +0800
Lei Li wrote:
> +MemCharRead *qmp_memchar_read(const char *device, int64_t size,
> + bool has_format, enum DataFormat format,
> + Error **errp)
> +{
> +CharDriverState *chr;
> +guchar *read_data;
On Fri, 25 Jan 2013 00:03:18 +0800
Lei Li wrote:
> Hi Anthony,
>
> Resubmit this series with your comments squashed in and Luiz's new
> comments fixed up. I will push console command part in another thread.
Applied to the qmp branch, thanks.
From: Lei Li
Signed-off-by: Lei Li
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx | 21 +
hmp.c| 21 +
hmp.h| 1 +
qapi-schema.json | 36
qemu-char.c | 47
From: Lei Li
Signed-off-by: Lei Li
Signed-off-by: Luiz Capitulino
---
qemu-char.c | 114
qemu-options.hx | 10 +
2 files changed, 124 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 9ba0573..8045869 100644
--- a
From: Lei Li
Signed-off-by: Lei Li
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx | 18 ++
hmp.c| 13 +
hmp.h| 1 +
qapi-schema.json | 38 ++
qemu-char.c | 42
On Fri, 25 Jan 2013 13:51:14 +0100
Andreas Färber wrote:
> Am 25.01.2013 13:14, schrieb Luiz Capitulino:
> > On Thu, 24 Jan 2013 13:12:08 -0500
> > Peter Feiner wrote:
> >
> >>> What about converting 'info registers' to QMP (ie. having
> >
CirMemCharDriver
QAPI: Introduce memchar-write QMP command
QAPI: Introduce memchar-read QMP command
Luiz Capitulino (3):
balloon: drop old stats code & API
balloon: re-enable balloon stats
docs: document virtio-balloon stats
blockdev.c| 14 ++-
docs/virtio-balloon-stats.txt |
tional
2. This feature has always been disabled
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
---
hmp.c | 24 +---
hw/virtio-balloon.c | 24
qapi-schema.json| 20 +---
qmp-commands.hx | 13 -
n use'.
Report error using monitor_printf() and strerror(), and convert existing
qerror_report() calls in do_commit() to monitor_printf().
Signed-off-by: Jeff Cody
Reviewed-by: Markus Armbruster
Signed-off-by: Luiz Capitulino
---
blockdev.c | 14 +-
1 file changed, 5 insert
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
---
docs/virtio-balloon-stats.txt | 104 ++
1 file changed, 104 insertions(+)
create mode 100644 docs/virtio-balloon-stats.txt
diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon
{
"stats": {
"stat-swap-out": 0,
"stat-free-memory": 844943360,
"stat-minor-faults": 219028,
"stat-major-faults": 235,
"stat-total-memory": 1044406272,
On Sat, 26 Jan 2013 23:25:11 +0100
q...@buildbot.b1-systems.de wrote:
> The Buildbot has detected a new failure on builder default_x86_64_rhel61
> while building qemu.
> Full details are available at:
> http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/509
>
> Buildbot UR
On Fri, 25 Jan 2013 14:27:11 +0100
Michal Privoznik wrote:
> Currently, we are using 'tray_open' in QMP and 'tray-open' in
> HMP. However, the QMP documentation was mistakenly using the
> HMP version.
It's missing the s-o-b line.
> ---
> qmp-commands.hx | 2 +-
> 1 file changed, 1 insertion(+)
Otherwise we can get funny stuff printed and if the buffer contains
a '\0' char it won't be fully printed.
Signed-off-by: Luiz Capitulino
---
hmp.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/hmp.c b/hmp.c
index 249b89b..5bfc8bd 100644
--
On Tue, 29 Jan 2013 14:20:30 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > Otherwise we can get funny stuff printed and if the buffer contains
> > a '\0' char it won't be fully printed.
> >
> > Signed-off-by: Luiz Capitulino
>
On Tue, 29 Jan 2013 17:58:41 +0100
Michal Privoznik wrote:
> Currently, we are using 'tray_open' in QMP and 'tray-open' in
> HMP. However, the QMP documentation was mistakenly using the
> HMP version.
>
> Signed-off-by: Michal Privoznik
Reviewed-by: Luiz
On Thu, 31 Jan 2013 10:51:10 +0100
Markus Armbruster wrote:
> "Erlon Cruz" writes:
>
> > QEMU monitor command 'info registers' only displays information for the
> > first
> > CPU. This fix that by show registers information for each CPU in the system
>
> This is incorrect. It displays inform
On Thu, 31 Jan 2013 05:12:25 -0800
"Erlon Cruz" wrote:
> Legal Disclaimer:
> The information contained in this message may be privileged and confidential.
> It is intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message i
On Fri, 01 Feb 2013 10:33:01 -0500
Corey Bryant wrote:
> > +##
> > +# @TPMInfo:
> > +#
> > +# Information about the TPM
> > +#
> > +# @model: The TPM frontend model, i.e., tpm-tis
> > +#
> > +# @id: The ID of the TPM
> > +#
> > +# @type: The type of TPM backend, i.e., passthrough
> > +#
> > +# @p
On Mon, 04 Feb 2013 08:48:57 +0100
Markus Armbruster wrote:
> [Note cc: Luiz]
>
> Peter Maydell writes:
>
> > On 2 February 2013 21:37, Andreas Färber wrote:
> >> Am 02.02.2013 22:19, schrieb Peter Maydell:
> >>> It's OK and expected for visitors to return errors when presented with
> >>> the
On Fri, 1 Feb 2013 18:38:14 +0100
Laszlo Ersek wrote:
>
> Signed-off-by: Laszlo Ersek
> ---
> hw/qdev-monitor.c |7 +--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
> index 3ec9e49..32be5a2 100644
> --- a/hw/qdev-monitor.c
On Fri, 1 Feb 2013 18:38:15 +0100
Laszlo Ersek wrote:
>
> Signed-off-by: Laszlo Ersek
I usually split this kind of patch the following way:
1. add an Error ** argument to the function reporting the error. Callers
are changed to pass NULL for the new argument
2. Handling of the new err
On Fri, 1 Feb 2013 18:38:17 +0100
Laszlo Ersek wrote:
> Use an Error to communicate the "stop the search" message.
>
> Signed-off-by: Laszlo Ersek
> ---
> hw/qdev-monitor.c | 24
> 1 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/hw/qdev-monitor.c
On Fri, 1 Feb 2013 18:38:18 +0100
Laszlo Ersek wrote:
>
> Signed-off-by: Laszlo Ersek
Splitting this as I suggested in the other patch would make review
easier. I honestly got a bit lost while reviewing this one.
> ---
> hw/qdev-monitor.c | 29 +++--
> 1 files chan
On Fri, 1 Feb 2013 18:38:19 +0100
Laszlo Ersek wrote:
>
> Signed-off-by: Laszlo Ersek
> ---
> hw/qdev-monitor.h |3 ++-
> hw/qdev-monitor.c | 29 +++--
> vl.c |9 +++--
> 3 files changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/hw
On Fri, 1 Feb 2013 18:38:12 +0100
Laszlo Ersek wrote:
> This series is the first in converting do_device_add() to qapi.
I've reviewed this, although it doesn't apply on master anymore and
then I was unable to try it.
Also, it's a good idea to CC qdev expert guys.
On Mon, 04 Feb 2013 19:23:15 +0100
Laszlo Ersek wrote:
> On 02/04/13 18:51, Luiz Capitulino wrote:
> > On Fri, 1 Feb 2013 18:38:18 +0100
> > Laszlo Ersek wrote:
> >
> >>
> >> Signed-off-by: Laszlo Ersek
> >
> > Splitting this as I suggested
On Tue, 05 Feb 2013 01:31:14 +0100
Laszlo Ersek wrote:
> On 02/04/13 18:27, Luiz Capitulino wrote:
> > On Fri, 1 Feb 2013 18:38:15 +0100
> > Laszlo Ersek wrote:
> >
> >>
> >> Signed-off-by: Laszlo Ersek
> >
> > I usually split this kind of
On Tue, 5 Feb 2013 20:44:23 +
Peter Maydell wrote:
> It's OK and expected for visitors to return errors when presented with
> the fuzz test's random data. Since the fuzzer doesn't care about
> errors, we pass in NULL rather than an Error**. This fixes a bug in
> the fuzzer where it was passi
On Tue, 5 Feb 2013 09:30:55 +0100
Markus Armbruster wrote:
> Test cases are scraped from Markus Kuhn's UTF-8 decoder capability and
> stress test at
> http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt
>
> Unfortunately, both JSON parser and formatter misbehave right now.
> This test ex
On Tue, 5 Feb 2013 17:22:04 +0100
Markus Armbruster wrote:
> Command memchar-write takes data and size parameter. Begs the
> question what happens when data doesn't match size.
>
> With format base64, qmp_memchar_write() copies the full data argument,
> regardless of size argument.
>
> With f
On Wed, 06 Feb 2013 14:11:10 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Wed, 06 Feb 2013 10:06:03 +0100
> > Markus Armbruster wrote:
> >
> >> Markus Armbruster writes:
> >>
> >> > Eric Blake writes:
> >
On Tue, 5 Feb 2013 17:22:05 +0100
Markus Armbruster wrote:
> The data returned has a well-defined size, which makes the size
> returned along with it redundant at best. Drop it.
It was me who asked Lei to add it and the reasons were: 1. qemu-ga
does it too, so it's good to be consistent and 2.
[Forgot to add Michael, re-sending]
On Tue, 5 Feb 2013 17:22:05 +0100
Markus Armbruster wrote:
> The data returned has a well-defined size, which makes the size
> returned along with it redundant at best. Drop it.
It was me who asked Lei to add it and the reasons were: 1. qemu-ga
does it too,
On Wed, 06 Feb 2013 10:06:03 +0100
Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Eric Blake writes:
> >
> >> On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> >>> Command memchar-write takes data and size parameter. Begs the
> >>> question what happens when data doesn't match si
On Tue, 5 Feb 2013 17:22:07 +0100
Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-char.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 892d5bb..9bf53e0 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2782,6 +27
On Wed, 06 Feb 2013 14:51:44 +0100
Markus Armbruster wrote:
> Back to your question, namely how to document enumeration DataFormat.
> Perhaps:
>
> ##
> # @DataFormat:
> #
> # An enumeration of data format.
> #
> # @utf8: Data is a UTF-8 string (RFC 3629)
> #
> # @base64: Data is a Base64 encoded
On Wed, 06 Feb 2013 16:28:08 +0100
Paolo Bonzini wrote:
> Il 06/02/2013 15:35, Markus Armbruster ha scritto:
> > HMP commands must be built on top of the QMP API.
> > Luiz and others have worked long & hard to make HMP conform to this
> > rule.
> >
> > However, a new command has crept in that vi
On Tue, 5 Feb 2013 17:22:03 +0100
Markus Armbruster wrote:
> We have a serious design bug in memchar-write [PATCH 01], and a less
> serious one in memchar-read [PATCH 02]. I really, really want them
> fixed before the API gets calcified by the release.
Nice series, just minor comments from me.
loop exit
bdrv_close_all()
bdrv_close()
bdrv_dev_change_media_cb()
So, revert the commit as the real fix is to separate eject
from bdrv_close() and also because it's not clear how important
it is to have a 100% correct semantic for eject from HMP.
Signed-off-by: Luiz Capit
On Thu, 07 Feb 2013 14:12:10 +0100
Kevin Wolf wrote:
> Am 06.02.2013 21:02, schrieb Luiz Capitulino:
> > This reverts commit 9ca111544c64b5abed2e79cf52e19a8f227b347b.
> >
> > That commit has added a weird side effect to QMP: on shutdown,
> > QMP emits the DEVICE_TRA
On Thu, 07 Feb 2013 14:28:33 +0100
Kevin Wolf wrote:
> Am 07.02.2013 14:15, schrieb Luiz Capitulino:
> > On Thu, 07 Feb 2013 14:12:10 +0100
> > Kevin Wolf wrote:
> >> I think the right solution is to move the bdrv_dev_change_media_cb()
> >> call to those call
on an uninitialized pointer variable when
visit_type_str() failed.].
Signed-off-by: Peter Maydell
Reviewed-by: Andreas Färber
Signed-off-by: Luiz Capitulino
---
tests/test-string-input-visitor.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/test-string-inpu
The changes (since ecd8d4715ea33aa2c146a5047bacb031e86af599) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Peter Maydell (1):
tests/test-string-input-visitor: Handle errors provoked by fuzz test
tests/test-string-input-visitor.c | 12 ++---
On Thu, 07 Feb 2013 18:07:01 +0100
Laszlo Ersek wrote:
> On 02/07/13 18:01, Eduardo Habkost wrote:
> > On Tue, Feb 05, 2013 at 09:39:15PM +0100, Laszlo Ersek wrote:
> >> Conversion status (call chains covered or substituted by error propagation
> >> marked with square brackets):
> >>
> >> do_devi
On Thu, 7 Feb 2013 15:04:54 -0200
Eduardo Habkost wrote:
> On Tue, Feb 05, 2013 at 09:39:16PM +0100, Laszlo Ersek wrote:
> > Error handling is not changed yet.
> >
> > Signed-off-by: Laszlo Ersek
>
> The extra parameter seems useless and even misleading (because Error
> info won't be set even
On Thu, 7 Feb 2013 15:12:22 -0200
Eduardo Habkost wrote:
> On Tue, Feb 05, 2013 at 09:39:18PM +0100, Laszlo Ersek wrote:
> > Problems are now reported via Error only.
> >
> > Signed-off-by: Laszlo Ersek
> > ---
> > hw/qdev-properties.h |4 ++--
> > hw/qdev-monitor.c|3 ++-
> > hw/q
On Thu, 7 Feb 2013 15:18:41 -0200
Eduardo Habkost wrote:
> On Tue, Feb 05, 2013 at 09:39:19PM +0100, Laszlo Ersek wrote:
> >
> > Signed-off-by: Laszlo Ersek
> > ---
> > hw/qdev-monitor.c | 21 -
> > 1 files changed, 16 insertions(+), 5 deletions(-)
> >
> > diff --git a/h
On Tue, 5 Feb 2013 21:39:20 +0100
Laszlo Ersek wrote:
> The return type can't be changed to void, because "set_property" must have
> type "qemu_opt_loopfunc".
>
> Conversion status (call chains covered or substituted by error propagation
> marked with square brackets):
This is fine to be squas
On Tue, 5 Feb 2013 21:39:13 +0100
Laszlo Ersek wrote:
> In v2, I'm mostly attempting to address Luiz's comments for v1:
Apart from minor comments, looks good to me.
Not sure if I did a good job on trying to suggest you a better
splitting though.
Also, I think it's a good idea for someone more
On Fri, 8 Feb 2013 17:17:07 +0100
Markus Armbruster wrote:
> The arguments of error_report() should yield a short error string
> without newlines.
>
> A few places try to print additional help after the error message by
> embedding newlines in the error string. That's nice, but let's do it
> t
@script:python@
> fmt << r.fmt;
> p << r.p;
> @@
> if "\\n" in str(fmt):
> print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Luiz Capitulino
> ---
>
vm_shadow_mem=dunno
> You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and
> terabytes.
> qemu-system-x86_64: -machine kvm_shadow_mem=dunno: Parameter
> 'kvm_shadow_mem' expects a size
>
> Pity. Disable them for now.
Oops, sorry. I think I
On Fri, 8 Feb 2013 17:17:11 +0100
Markus Armbruster wrote:
> qemu_opts_parse() reports the error already, and in a much more useful
> way.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Luiz Capitulino
> ---
> vl.c | 4
> 1 file changed, 4 deletions(-)
>
o exit unsuccessfully, like the other options.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Luiz Capitulino
What about qemu_opts_parse() call in QEMU_OPTION_boot?
> ---
> vl.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl
On Fri, 08 Feb 2013 19:56:17 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 8 Feb 2013 17:17:07 +0100
> > Markus Armbruster wrote:
> >
> >> The arguments of error_report() should yield a short error string
> >> without newl
On Fri, 08 Feb 2013 19:58:42 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 8 Feb 2013 17:17:10 +0100
> > Markus Armbruster wrote:
> >
> >> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
> >> message and
On Fri, 08 Feb 2013 19:59:55 +0100
Markus Armbruster wrote:
> Luiz, would you like to take v3 through your tree? In that case I'd
> drop qemu-trivial.
Yes, I can do it.
On Fri, 08 Feb 2013 20:34:20 +0100
Markus Armbruster wrote:
> > The real problem here is that the k, M, G suffixes, for example, are not
> > good to be reported by QMP. So maybe we should refactor the code in a way
> > that we separate what's done in QMP from what is done in HMP/command-line.
>
On Fri, 08 Feb 2013 20:48:18 +0100
Markus Armbruster wrote:
> It's a cleanup. It's only user-visible effect is getting rid of an
> extra newline on stderr. I'm fixing those globally. Tiny improvement
> in user experience, but next to no risk, thus proposed for 1.4. Since I
> need to touch thi
On Thu, 14 Feb 2013 10:45:22 +0100
Markus Armbruster wrote:
> [Note cc: +Laszlo, +Anthony, -qemu-trivial]
>
> Luiz Capitulino writes:
>
> > On Fri, 08 Feb 2013 20:34:20 +0100
> > Markus Armbruster wrote:
> >
> >> > The real problem here is that
On Thu, 14 Feb 2013 15:10:36 +0900
Tomoki Sekiyama wrote:
> Rename 'class' member in class_info of PciDeviceInfo to 'dev_class', and
> add some casts to avoid errors from c++ compiler.
[...]
> #
> # @class_info.desc: #optional a string description of the device's class
> #
> -# @class_info.c
On Thu, 14 Feb 2013 14:31:50 +0100
Markus Armbruster wrote:
> [Some quoted material restored]
>
> Luiz Capitulino writes:
>
> > On Thu, 14 Feb 2013 10:45:22 +0100
> > Markus Armbruster wrote:
> >
> >> [Note cc: +Laszlo, +Anthony, -qemu-triv
On Fri, 15 Feb 2013 15:47:41 +0100
Andreas Färber wrote:
> No functional change, just less usages of first_cpu and next_cpu fields.
>
> Signed-off-by: Andreas Färber
Reviewed-by: Luiz Capitulino
One comment below.
> ---
> cpus.c | 11 +++
> 1 Datei geändert, 3
>
> Signed-off-by: Andreas Färber
Reviewed-by: Luiz Capitulino
> ---
> monitor.c | 13 +
> 1 Datei geändert, 5 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-)
>
> diff --git a/monitor.c b/monitor.c
> index 20bd19b..cae33c4 100644
> --- a/monito
On Thu, 7 Feb 2013 11:31:08 -0200
Luiz Capitulino wrote:
> On Thu, 07 Feb 2013 14:28:33 +0100
> Kevin Wolf wrote:
>
> > Am 07.02.2013 14:15, schrieb Luiz Capitulino:
> > > On Thu, 07 Feb 2013 14:12:10 +0100
> > > Kevin Wolf wrote:
> > >&
On Thu, 21 Feb 2013 14:47:08 +0100
Stefan Hajnoczi wrote:
> On Thu, Feb 21, 2013 at 06:21:32AM +, Dietmar Maurer wrote:
> > > > +##
> > > > +# @backup:
> > > > +#
> > > > +# Starts a VM backup.
> > > > +#
> > > > +# @backup-file: the backup file name
> > > > +#
> > > > +# @format: format of t
The changes (since 70aa41b56ce3f34fceac44e828ba2d8cc19523ee) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Markus Armbruster (1):
check-qjson: More thorough testing of UTF-8 in strings
tests/check-qjson.c | 664
x27;re all clearly
marked, and are to be replaced by correct ones as the bugs get fixed.
See comments in new utf8_string() for details.
Signed-off-by: Markus Armbruster
Signed-off-by: Luiz Capitulino
---
tests/check-qjson.c | 664
1 file ch
On Fri, 14 Sep 2012 21:44:19 +0900
Ryota Ozaki wrote:
> This patch series adds qemu-ga-client that is a command line
> script to use guest agent functions easily.
Applied to qmp branch, thanks.
>
> Ryota Ozaki (3):
> Make negotiation optional in QEMUMonitorProtocol
> Support settimeout in
On Wed, 19 Sep 2012 16:31:04 +0200
Paolo Bonzini wrote:
> monitor_handle_fd_param and monitor_get_fd are mostly the same, except
> that monitor_handle_fd_param does error reporting wrong. Use it in all
> other places that do it wrong, instead of reinventing it.
Hmm, why do we want to do this?
On Wed, 19 Sep 2012 16:31:05 +0200
Paolo Bonzini wrote:
> Differentiate monitor_get_fd and monitor_handle_fd_param by doing
> correct error propagation in the former and its callers.
>
> Signed-off-by: Paolo Bonzini
> ---
> dump.c| 5 +++--
> monitor.c | 9 ++---
> monitor.h | 2 +-
>
On Thu, 20 Sep 2012 11:10:02 +0800
Dong Xu Wang wrote:
> Luiz, I think I need to use your 1-3 patchs in your series.
> http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html
Sure, that's what I expected you'd do. Note that Markus made some
comments there that have to be addressed.
On Thu, 20 Sep 2012 10:09:54 +0200
Paolo Bonzini wrote:
> Il 19/09/2012 22:42, Luiz Capitulino ha scritto:
> > On Wed, 19 Sep 2012 16:31:04 +0200
> > Paolo Bonzini wrote:
> >
> >> monitor_handle_fd_param and monitor_get_fd are mostly the same, except
> >
On Wed, 19 Sep 2012 16:31:06 +0200
Paolo Bonzini wrote:
> Enum values are always preceded by the uppercase name of the enum, so
> they do not conflict with reserved words.
>
> Signed-off-by: Paolo Bonzini
Cherry-picked into qmp branch, thanks.
> ---
> scripts/qapi-types.py | 4 ++--
> script
On Wed, 19 Sep 2012 16:31:07 +0200
Paolo Bonzini wrote:
> It is #defined to 1.
>
> Signed-off-by: Paolo Bonzini
Cherry-picked into qmp branch, thanks.
> ---
> scripts/qapi.py | 4 +++-
> 1 file modificato, 3 inserzioni(+). 1 rimozione(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
>
This actually fixes a regression introduced by the qapi conversion,
please refer to patch 2/3 for details.
It's also important to note that this series changes the QMP
interface for the send-key command, but this shouldn't be a problem
as we're still in development phase.
hmp.c| 43 +
interface changes
Item 2 is an incompatible change, but as we're development phase
(and this command has been merged a few weeks ago) this shouldn't be
a problem.
Lastly, it's not possible to split this commit without breaking the
build.
Reported-by: Avi Kivity
Signed-off-by: Lu
dynamically allocated and stores
the already converted key value.
This simplies the current code and the next commit.
Signed-off-by: Luiz Capitulino
---
input.c | 36 ++--
1 file changed, 14 insertions(+), 22 deletions(-)
diff --git a/input.c b/input.c
index
The hex key conversion is unused since last commit.
Signed-off-by: Luiz Capitulino
---
input.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/input.c b/input.c
index 187a131..da3ed27 100644
--- a/input.c
+++ b/input.c
@@ -186,8 +186,7 @@ static const int
The first two patches work on adding an Error * argument to monitor_get_fd().
The second patch is the actual conversion of add_client.
v2
o add Error * argument to monitor_get_fd()
o fix schema doc mistakes
dump.c | 3 +--
hw/kvm/pci-assign.c | 12 +++-
migration-fd.c
From: Paolo Bonzini
There is no need to open-code the choice between a file descriptor
number or a named one. Just use monitor_handle_fd_param, which
also takes care of printing the error message.
Signed-off-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
hw/kvm/pci-assign.c | 12
explode
3. A few error conditions aren't reported
Signed-off-by: Luiz Capitulino
---
monitor.c| 39 ---
qapi-schema.json | 23 +++
qmp-commands.hx | 5 +
qmp.c| 43 +++
4
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
dump.c | 3 +--
migration-fd.c | 2 +-
monitor.c | 15 +--
monitor.h | 2 +-
4 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/dump.c b/dump.c
index 2bf8d8d
On Thu, 20 Sep 2012 15:42:30 +0800
Lei Li wrote:
> On 09/20/2012 02:05 AM, Luiz Capitulino wrote:
> > On Wed, 12 Sep 2012 19:57:24 +0800
> > Lei Li wrote:
> >
> >> Signed-off-by: Lei Li
> >> ---
> >> hmp-commands.hx | 23 +
orted-by: Avi Kivity
Signed-off-by: Luiz Capitulino
---
hmp.c| 43 +--
input.c | 33 +++--
qapi-schema.json | 19 ---
3 files changed, 72 insertions(+), 23 deletions(-)
diff --git a/hmp.c b
The hex key conversion is unused since last commit.
Signed-off-by: Luiz Capitulino
---
input.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/input.c b/input.c
index 6be0231..92e1126 100644
--- a/input.c
+++ b/input.c
@@ -186,8 +186,7 @@ static const int
dynamically allocated and stores
the already converted key value.
This simplifies the current code and the next commit.
Signed-off-by: Luiz Capitulino
---
input.c | 36 ++--
1 file changed, 14 insertions(+), 22 deletions(-)
diff --git a/input.c b/input.c
index
o v2
- re-write some commit logs
- fix a possible issue with error handling in patch 2/3
This actually fixes a regression introduced by the qapi conversion,
please refer to patch 2/3 for details.
It's also important to note that this series changes the QMP
interface for the send-key command, b
On Fri, 21 Sep 2012 10:31:23 -0600
Eric Blake wrote:
> On 09/21/2012 08:55 AM, Luiz Capitulino wrote:
> > This commit fixes the problem by adding hex value support down
> > the QMP interface, qmp_send_key().
> >
>
> > +++ b/qapi-schema.json
> > @@ -2588,
kes little sense for humans
Because of these reasons, hardcode the 'protocol' argument to
'file:' in HMP.
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx | 8 +++-
hmp.c | 11 ---
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/hmp
501 - 600 of 5376 matches
Mail list logo
