Re: qpsmtpd won't start, can't access Net/IP.pm

2018-12-17 Thread Matt Simerson via qpsmtpd
Considering that 0.84 is quite a lot older than current, I'd do a search for Net::IP within the qpsmtpd repo and see what turns up: https://github.com/smtpd/qpsmtpd/search?q=net%3A%3Aip=Commits <https://github.com/smtpd/qpsmtpd/search?q=net::ip=Commits> Matt > On Dec 16, 2018, a

Re: Auth on outgoing and dkim signing

2017-02-05 Thread Matt Simerson via qpsmtpd
; Secondly, I would like to just accept all email unauthenticated from my > LAN, can I configure qpsmtpd to let anything from 172.22.0.0/16 go through? Yes, you can. Matt

Re: helo plugin fails to match badhelo

2015-12-17 Thread Matt Simerson via qpsmtpd
Hey Chris, See https://github.com/smtpd/qpsmtpd/pull/246 Matt > On Dec 17, 2015, at 9:17 AM, Chris Dallimore <pa...@pigstrough.co.uk> wrote: > > The helo plugin fails to match any entries in badhelo, as the is_regex_match > sub returns after the first (usually

Re: qpsmtpd-async weird ParaDNS lookup problem + code fix

2014-08-07 Thread Matt Sergeant
% Matt. On Fri, 1 Aug 2014, David Favor wrote: Matt Sergeant wrote: Do you have ParaDNS::XS installed? If not, try installing it. It's generally likely to be better than plain ParaDNS (and will be used automatically if it's installed). There is no ParaDNS::XS on cpan... At least nothing

Re: qpsmtpd-async weird ParaDNS lookup problem

2014-07-22 Thread Matt Sergeant
Do you have ParaDNS::XS installed? If not, try installing it. It's generally likely to be better than plain ParaDNS (and will be used automatically if it's installed). On Thu, 17 Jul 2014, David Favor wrote: I've been running qpsmtpd-async for years on all sorts of servers. Likely I have

Re: Fatal errors with Net-DNS-0.73

2013-12-01 Thread Matt Simerson
. That seems to take care of it for me. Matt On Nov 30, 2013, at 6:31 PM, Walt Mankowski walt...@pobox.com wrote: Are you referring to commit 6a0fa13? If so, I'm the one who first posted that bug, and it was for a different problem with Net-DNS 0.69. But Markus's patch was slightly different from mine

Re: Fatal errors with Net-DNS-0.73

2013-11-30 Thread Matt Simerson
https://github.com/smtpd/qpsmtpd/ Have a look at the Changes file, and/or the closed issues. Matt On Nov 30, 2013, at 7:43 AM, Walt Mankowski walt...@pobox.com wrote: I installed the new version of Net::DNS last night (version 0.73) and that caused qpsmtpd to fail with a fatal error

Re: Moved website to github

2013-08-05 Thread Matt Simerson
I intend to merge my fork directly onto the main repo. See the changes here: https://github.com/msimerson/qpsmtpd-dev/blob/master/Changes Concerns and objections? Matt On Aug 5, 2013, at 11:29 AM, Ask Bjørn Hansen a...@develooper.com wrote: Hi everyone, First of all apologies for my

Re: Moved website to github

2013-08-05 Thread Matt Simerson
will still work fine. Most of the 'incompatible' changes are to newer versions of old plugins, and most of those plugins have been renamed (dropping the check_ prefix). Matt If not, consider bumping up the version number to 1.5 or 1.9 or something. Thanks for taking this on Matt! -R

Re: Issue 32 in smtpd: qpsmtpd doesn't work with sslserver

2013-06-24 Thread Matt Simerson
and that worked for me as well. Matt ` Matt Simerson http://matt.simerson.net/ Systems Engineerhttp://www.tnpi.net/ Mail::Toaster - http://mail-toaster.org/ NicTool - http

clamdscan plugin defaults

2013-04-29 Thread Matt Simerson
into the Content-Type field value (which would get ignored later), to bypass multipart detection, and thus virus scanning? Matt

I found the future by dredging in the past

2013-04-29 Thread Matt Simerson
like: if ( 'from: ' eq lc substr($envelope_header, 0, 6) ) { $self-adjust_karma(-1); }; After reading the proposed solutions, the one I adopted was storing the unparsed line in a connection note, making it available to plugins that wish to inspect and act upon it. Matt PS: I find

qpsmtpd-dev release 0.92

2013-04-26 Thread Matt Simerson
I just tagged the 0.92 release of qpsmtpd-dev. It can be downloaded by clicking the Tags button on the github project page at https://github.com/qpsmtpd-dev/qpsmtpd-dev. The changes are listed below. Matt 0.92 Apr 20, 2013 new plugins: dmarc, fcrdns new feature: DKIM message signing

Devin's Received auth header patch

2013-04-26 Thread Matt Simerson
mailing list to www gateways redacting email addresses in headers, many do not. It just seems imprudent to be publishing that data into the headers, as well as having logged it. Matt --- a/lib/Qpsmtpd/SMTP.pm +++ b/lib/Qpsmtpd/SMTP.pm @@ -824,7 +824,7 @@ sub received_line { . (HELO

plugin announcement: FCrDNS

2013-04-26 Thread Matt Simerson
(only about 90%) to use for message rejection. However, when combined with any sort of heuristics system such as the karma plugin, the fcrdns plugin provides another extremely reliable indication of spam likelihood. Matt

plugin announcement: DMARC

2013-04-26 Thread Matt Simerson
are sending, this plugin will do the trick. It'll also stop all the forged [a-z]{6}@yahoo.com spams those senders haven't made it onto a DNSBL yet. The largest *legitimate* email senders have deployed DMARC records. And now I have too. :-) Matt

new feature: DKIM message signing

2013-04-26 Thread Matt Simerson
I added a signing feature to my DKIM plugin. https://github.com/qpsmtpd-dev/qpsmtpd-dev/blob/master/plugins/dkim Matt PS: for added pleasure, I also added a script that makes deploying DKIM really, really easy. How easy? # cd ~smtpd/config/dkim # ./dkim_key_gen.sh

Re: Alternative Postfix-Queue Plugin 'postfix-maildrop'

2012-11-28 Thread Matt Simerson
that use this plugin may. Having a backwards compatible option, and a paragraph of POD explaining the difference (pros cons) would go a long ways towards smoothing over any potential objections. Matt On Nov 28, 2012, at 7:16 PM, Michael Holzt k...@fqdn.org wrote: Hello everyone, considering

Re: Endless loop in plugin sender_permitted_from on IPv6 clients

2012-11-15 Thread Matt Simerson
Masks are already being handled properly by the other method. Wouldn't it be better to just skip CIDR processing entirely when we detect a mask? Matt On Nov 15, 2012, at 4:43 AM, Michael Holzt k...@fqdn.org wrote: It will return for the given example '2001:db8:123/44' which as I understands

Re: Endless loop in plugin sender_permitted_from on IPv6 clients

2012-11-14 Thread Matt Simerson
/commit/d1bb2d949ba4f570e087941820eb0baddc18ed23 Matt --- a/plugins/sender_permitted_from +++ b/plugins/sender_permitted_from @@ -59,6 +59,8 @@ use warnings; #use Mail::SPF 2.000; # eval'ed in -register use Qpsmtpd::Constants; +use Net::IP; + sub register { my ($self, $qp, %args

Re: IPv6 code warnings (pack_sockaddr_in6 redefined etc)

2012-11-14 Thread Matt Simerson
Applied in qpsmtpd-dev: https://github.com/qpsmtpd-dev/qpsmtpd-dev/commit/61f7ea00e0f96665e25c3d195d99609aa06f2527 I have my IPv6 allocation, but I'm waiting for my providers switch to get replaced before I can use them. I look forward to testing this patch. Matt On Nov 13, 2012, at 11:38

Re: [PATCH] Accept messages with no body and no trailing \n after headers

2012-07-20 Thread Matt Simerson
Imported to qpsmtpd-dev. https://github.com/msimerson/qpsmtpd-dev/commit/b174bb0c4dd865312c264504935549e962004336 Matt On Jul 20, 2012, at 10:37 AM, Charlie Brady wrote: On Sat, 25 Feb 2012, Robin H. Johnson wrote: I'm reopening this thread as I independently ran into it today, and I

Re: qpsmtpd-dev

2012-06-29 Thread Matt Simerson
corral, and when they get unwieldy, we can work out a solution for managing them. Matt

Re: qpsmtpd-dev

2012-06-26 Thread Matt Simerson
plan to tag a dev release. Then, a long overdue perltidy. :-) Matt

qpsmtpd-dev

2012-06-22 Thread Matt Simerson
to the main branch. Matt

release

2012-06-21 Thread Matt Simerson
What is the process for releasing a new version of qpsmtpd? Matt ` Matt Simerson http://matt.simerson.net/ Systems Engineerhttp://www.tnpi.net/ Mail::Toaster - http://mail-toaster.org

Re: new plugin: helo

2012-06-15 Thread Matt Simerson
On Jun 15, 2012, at 6:44 AM, Charlie Brady wrote: On Wed, 13 Jun 2012, Matt Simerson wrote: https://github.com/smtpd/qpsmtpd/pull/29 I consider this statement to be troublesome also: Per RFC 2821, the HELO hostname must be the FQDN of the sending server or address literal. -Per RFC

Re: new plugin: helo

2012-06-15 Thread Matt Simerson
On Jun 15, 2012, at 12:32 PM, Charlie Brady wrote: On Fri, 15 Jun 2012, Matt Simerson wrote: In my experience, reverse DNS is frequently managed (or, frequently, not managed) by an ISP, not by the admin of the mail server. In my experience, every ISP that provides clients with dedicated

new plugin: helo

2012-06-13 Thread Matt Simerson
from that test. While I'm still not using that as a condition for rejection, it may now be good enough to enforce. Matt NAME helo - validate the HELO message presented by a connecting host. DESCRIPTION Validate the HELO hostname. This plugin includes a suite of optional tests

Re: New plugin: reaper

2012-06-05 Thread Matt Simerson
On Jun 4, 2012, at 2:56 PM, Stevan Bajić wrote: On 04.06.2012 21:09, Matt Simerson wrote: On Jun 4, 2012, at 6:40 AM, Stevan Bajić wrote: Care to explain little more to me what this is all about? 49237 (data_post) dspam: training naughty as spam Overnight, dpsam's spam detection

Re: [PATCH] unrecognized_commands: better log messages

2012-06-04 Thread Matt Simerson
On Jun 3, 2012, at 11:41 PM, Ask Bjørn Hansen wrote: On Jun 3, 2012, at 19:00, Matt Simerson wrote: removed hook_connect, unnecessary. I think it's there so if you log or otherwise use the note, it'll be reasonably initialized. It's not used anywhere else in qpsmtpd or plugins

clamav

2012-06-04 Thread Matt Simerson
` Matt Simerson http://matt.simerson.net/ Systems Engineerhttp://www.tnpi.net/ Mail::Toaster - http://mail-toaster.org/ NicTool - http://www.nictool.com/ `

dspam plugin update

2012-06-04 Thread Matt Simerson
abstracted new subs: log_and_return, attach_headers ` Matt Simerson http://matt.simerson.net/ Systems Engineerhttp://www.tnpi.net/ Mail::Toaster - http://mail-toaster.org/ NicTool

Re: [PATCH] connection_time: make compatible with tcpserver deployment

2012-06-04 Thread Matt Simerson
On Jun 4, 2012, at 9:32 AM, Charlie Brady wrote: On Sun, 3 Jun 2012, Matt Simerson wrote: --- plugins/connection_time | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/plugins/connection_time b/plugins/connection_time index bfac4d2..9cff7f9 100644

Re: [PATCH] connection_time: make compatible with tcpserver deployment

2012-06-04 Thread Matt Simerson
, or is there some hidden functional significance? I think Matt has been trying to make loading other Qpsmtpd modules go first and then external dependencies second. Almost all the time that's fine (no functional change) and it is neater. Precisely. (It's however also what makes reviewing

Re: New plugin: reaper

2012-06-04 Thread Matt Simerson
On Jun 4, 2012, at 6:40 AM, Stevan Bajić wrote: On 02.06.2012 23:23, Matt Simerson wrote: On Jun 2, 2012, at 11:15 AM, Jared Johnson wrote: Yup. Part of the motivation for this plugin was to short circuit all the intermediate plugins and handlers so I can feed the message to sa-learn

Re: New plugin: reaper

2012-06-04 Thread Matt Simerson
the cost of the computing resources required to add them. But I suspect that question will have more than one correct answer. :-) Matt

Re: [PATCH] unrecognized_commands: better log messages

2012-06-04 Thread Matt Simerson
to read and maintain? Both seem equal to the task. Matt On Jun 3, 2012, at 11:46 PM, Matt Simerson wrote: On Jun 3, 2012, at 11:41 PM, Ask Bjørn Hansen wrote: On Jun 3, 2012, at 19:00, Matt Simerson wrote: removed hook_connect, unnecessary. I think it's there so if you log or otherwise

Re: validating from

2012-06-04 Thread Matt Simerson
On Jun 4, 2012, at 9:26 AM, Charlie Brady wrote: On Sat, 2 Jun 2012, Matt Simerson wrote: Is it a good idea to validate that the MAIL FROM address is the same as the From: header in the message? What exceptions need to be made, if any? What problems might I encounter if I were to do

Re: [PATCH] unrecognized_commands: better log messages

2012-06-04 Thread Matt Simerson
On Jun 4, 2012, at 7:35 PM, Charlie Brady wrote: On Mon, 4 Jun 2012, Matt Simerson wrote: +my $count = $self-connection-notes('unrec_cmd_count') || 0; + $self-connection-notes('unrec_cmd_count', ++$count ); Which does increment correctly. This also

Re: New plugin: reaper

2012-06-03 Thread Matt Simerson
in order to use them together. I think what qpsmtpd needs is a development branch where developers can actually work on qpsmtpd. Matt

[PATCH] basicheaders: adding missing semicolon, fixed POD error

2012-06-03 Thread Matt Simerson
--- plugins/check_basicheaders |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/check_basicheaders b/plugins/check_basicheaders index 684b9a4..c72f229 100644 --- a/plugins/check_basicheaders +++ b/plugins/check_basicheaders @@ -35,7 +35,7 @@ I would be surprised

[PATCH] connection consistency

2012-06-03 Thread Matt Simerson
- $self-qp-connection-notes + $self-connection-notes and all tests pass. --- docs/advanced.pod |4 ++-- plugins/async/check_earlytalker|3 +-- plugins/async/dnsbl|8 plugins/async/require_resolvable_fromhost |

[PATCH] make SPF level 2 a little more lenient

2012-06-03 Thread Matt Simerson
--- plugins/sender_permitted_from |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sender_permitted_from b/plugins/sender_permitted_from index 2353493..17805f1 100644 --- a/plugins/sender_permitted_from +++ b/plugins/sender_permitted_from @@ -167,7 +167,7 @@ sub

Re: New plugin: reaper

2012-06-03 Thread Matt Simerson
} ||= 'naughty'; }; sub connect_handler { my ($self, $transaction) = @_; ... do a bunch of stuff ... return DECLINED if is_okay(); return $self-get_reject( $message ); }; AUTHOR 2012 - Matt Simerson - msimer...@cpan.org

[PATCH] plugins.pod: much simpler way to get debug logging

2012-06-03 Thread Matt Simerson
for individual plugins --- docs/plugins.pod | 47 +++ 1 file changed, 3 insertions(+), 44 deletions(-) diff --git a/docs/plugins.pod b/docs/plugins.pod index 46b174b..43a4c4e 100644 --- a/docs/plugins.pod +++ b/docs/plugins.pod @@ -217,7 +217,7 @@

[PATCH] badrcptto: remove spurious semicolon

2012-06-03 Thread Matt Simerson
--- plugins/check_badrcptto |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_badrcptto b/plugins/check_badrcptto index fdea8e8..7b5f7d9 100644 --- a/plugins/check_badrcptto +++ b/plugins/check_badrcptto @@ -63,7 +63,7 @@ sub hook_rcpt { $line =~

[PATCH] connection_time: make compatible with tcpserver deployment

2012-06-03 Thread Matt Simerson
--- plugins/connection_time | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/plugins/connection_time b/plugins/connection_time index bfac4d2..9cff7f9 100644 --- a/plugins/connection_time +++ b/plugins/connection_time @@ -26,9 +26,10 @@ Adjust the quantity

[PATCH] loop: use default if invalid config set

2012-06-03 Thread Matt Simerson
--- plugins/check_loop |1 + 1 file changed, 1 insertion(+) diff --git a/plugins/check_loop b/plugins/check_loop index 5ffa608..634c126 100644 --- a/plugins/check_loop +++ b/plugins/check_loop @@ -35,6 +35,7 @@ sub init { if ( $self-{_max_hops} !~ /^\d+$/ ) { $self-log(LOGWARN,

[PATCH] unrecognized_commands: better log messages

2012-06-03 Thread Matt Simerson
removed hook_connect, unnecessary. --- plugins/count_unrecognized_commands | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/plugins/count_unrecognized_commands b/plugins/count_unrecognized_commands index 445dca7..1c3cbf2 100644 ---

Karma, RE: new plugin: naughty nice

2012-06-02 Thread Matt Simerson
, 158 connects 26945 550 You were naughty. You are penalized for 0.79 more days. 26945 click, disconnecting 26945 (post-connection) connection_time: 0.038 s. 24709 cleaning up after 26945 Of course, it supports the reaper plugin, so disconnecting can happen at later hooks as well. Matt On May 24

validating from

2012-06-02 Thread Matt Simerson
implementations, similar ideas, and further reading are welcome. Another way to solve part of this problem is that if MAIL FROM contains a local domain, reject it unless relay_client is set and the local user exists. If the To header exists, shouldn't that also be validated against RCPT TO? Matt

Re: New plugin: reaper

2012-06-02 Thread Matt Simerson
someone who is. The dspam author (Stevan Bajić) noticed my plugin, contacted me, and will be submitting some improvements, like talking directly to the dspam server. I'm BCC'ing him on this message, and hopefully we'll get a more informed opinion. Matt

auth cleanups

2012-06-02 Thread Matt Simerson
Added dependency tests within the plugins, so the plugins and tests will check for, and gracefully fail if their dependencies don't exist. Pull request: https://github.com/smtpd/qpsmtpd/pull/19 Changes: https://github.com/smtpd/qpsmtpd/pull/19/files Matt

Re: relay plugins

2012-06-02 Thread Matt Simerson
Is there anything else I can do to move this forward? Matt On May 21, 2012, at 12:06 PM, Matt Simerson wrote: https://github.com/smtpd/qpsmtpd/pull/13 replaces 3 relay plugins (check_relay, check_norelay, relay_only) with a single plugin (relay). Same functionality. Bonus

plugin immunity

2012-06-02 Thread Matt Simerson
not want immunization against a certain test. But I didn't run into a case where that was desirable or necessary. Matt PS: Here's the addition to Plugins.pm. sub is_immune { my $self = shift; if ( $self-qp-connection-relay_client() ) { # set by plugins/relay, or Qpsmtpd::Auth

New plugin: reaper

2012-06-01 Thread Matt Simerson
) = @_; ... do a bunch of stuff ... return DECLINED if is_okay(); return $self-get_reject( $message ); }; AUTHOR 2012 - Matt Simerson - msimer...@cpan.org ` Matt Simerson http

Re: New plugin: reaper

2012-06-01 Thread Matt Simerson
On Jun 1, 2012, at 3:30 PM, Steve Kemp wrote: On Fri Jun 01, 2012 at 15:17:51 -0700, Matt Simerson wrote: Introducing zombies and a reaper. Cute names.. Thanks. Notice the bolded lines. Instead of rejecting the message early, plugins like dnsbl and karma can zombify it. To increase

connection notes

2012-06-01 Thread Matt Simerson
Which is preferred within a plugin? $self-qp-connection-notes or $self-connection-notes The code in lib uses only the latter. Code in plugins uses a mixture, but mostly the former. Because I'm mildly obsessed with consistency, I'd like to make them all the same. Matt

Re: connection notes

2012-06-01 Thread Matt Simerson
https://github.com/smtpd/qpsmtpd/pull/18 Matt On Jun 1, 2012, at 8:34 PM, Ask Bjørn Hansen wrote: On Jun 1, 2012, at 20:25, Matt Simerson m...@tnpi.net wrote: Which is preferred within a plugin? $self-qp-connection-notes or $self-connection-notes Assuming the second method

SPF error?

2012-05-30 Thread Matt Simerson
that make hook_from plugins unnecessarily sensitive to ordering in config/plugins? Matt ` Matt Simerson http://matt.simerson.net/ Systems Engineerhttp://www.tnpi.net/ Mail::Toaster - http

Re: spool file not present on disk

2012-05-30 Thread Matt Simerson
and scanned as they should. But why is respooling necessary? Matt On May 29, 2012, at 10:03 PM, Matt Simerson wrote: For quite a long time (as long as I've used qpsmtpd), I've been getting chmod errors in my logs from the clamdscan plugin. The errors look like this: (data_post) virus::clamdscan

[PATCH] p0f: POD improvements

2012-05-30 Thread Matt Simerson
with local_ip override: @@ -107,15 +115,11 @@ Version 2 code heavily based upon the p0fq.pl included with the p0f distribution =head1 AUTHORS -Robert Spier ( original author ) - -Matt Simerson - -=head1 CHANGES +2004 - Robert Spier ( original author ) -Added local_ip option - Matt Simerson (5

[PATCH] fix typo

2012-05-30 Thread Matt Simerson
--- lib/Qpsmtpd/Transaction.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Qpsmtpd/Transaction.pm b/lib/Qpsmtpd/Transaction.pm index 0dabffa..8c55d90 100644 --- a/lib/Qpsmtpd/Transaction.pm +++ b/lib/Qpsmtpd/Transaction.pm @@ -358,7 +358,7 @@ the CDATA command. If

Re: new plugin: naughty nice

2012-05-27 Thread Matt Simerson
trying a new spam. Matt

Re: new plugin: naughty nice

2012-05-26 Thread Matt Simerson
On May 25, 2012, at 6:08 AM, Charlie Brady wrote: On Thu, 24 May 2012, Matt Simerson wrote: I have written a plugin that is currently named naughty. The POD has a good description of what it does and how it works. You can read the POD here: https://www.tnpi.net/internet/mail

new plugin: naughty nice

2012-05-24 Thread Matt Simerson
that, and these are the results) you can share. Thanks, Matt ` Matt Simerson http://matt.simerson.net/ Systems Engineerhttp://www.tnpi.net/ Mail::Toaster - http://mail-toaster.org/ NicTool

[PATCH] spamhelo: don't lc an undefined value

2012-05-23 Thread Matt Simerson
simplified logic --- plugins/check_spamhelo | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/plugins/check_spamhelo b/plugins/check_spamhelo index 3b60a0a..22f7c62 100644 --- a/plugins/check_spamhelo +++ b/plugins/check_spamhelo @@ -1,4 +1,5 @@ #!perl -w +

Re: [PATCH] basicheaders: Charlie's corrections

2012-05-21 Thread Matt Simerson
that didn't get applied most likely wouldn't, and I didn't have time to figure out why. Likely an ordering issue. I don't want to discourage you from sending patches -- this is the most interest anyone has had in qpsmtpd in a while, and we definitely appreciate it. I'll rebase and resubmit. Matt

[PATCH] SPF plugin: refactored, tests, new config option

2012-05-21 Thread Matt Simerson
/Changes @@ -1,6 +1,8 @@ Next Version + sender_permitted_from. see UPGRADING (Matt Simerson) + dspam plugin added (Matt Simerson) p0f version 3 supported and new default. see UPGRADING (Matt Simerson) diff --git a/UPGRADING b/UPGRADING index e76584b..58330ac 100644 --- a/UPGRADING +++ b

[PATCH] make SPF level 2 a little more lenient

2012-05-21 Thread Matt Simerson
--- plugins/sender_permitted_from |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sender_permitted_from b/plugins/sender_permitted_from index 2353493..17805f1 100644 --- a/plugins/sender_permitted_from +++ b/plugins/sender_permitted_from @@ -167,7 +167,7 @@ sub

[PATCH] earlytalker: many changes

2012-05-21 Thread Matt Simerson
consolidated chunks of code duplicated 4x into log_and_deny and log_and_pass in apr_*_handler subs, return DECLINED when connection is not available to read (like during tests) added 23 tests deprecate action argument 'action log' did nothing, better logging controls available with

[PATCH] consolidate auth logic into Qpsmtpd::Auth

2012-05-21 Thread Matt Simerson
These 3 auth plugins all have a data store they fetch the reference password or hash from. They then match the attempted password or hash against the reference. This consolidates the latter portion (validating the password/hash) into Auth.pm. * less duplicated code in the plugins. * Pass

[PATCH] greylisting: added upgrade note

2012-05-21 Thread Matt Simerson
--- UPGRADING | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/UPGRADING b/UPGRADING index 58330ac..5b15721 100644 --- a/UPGRADING +++ b/UPGRADING @@ -3,10 +3,20 @@ When upgrading from: v 0.84 or below -SPF plugin: spf_deny setting deprecated. Use

[PATCH] added loglevel option for plugins

2012-05-21 Thread Matt Simerson
Plugins can now use a 'loglevel' argument in config/plugins entry Includes user instructions prepended to docs/logging.pod Already works for all plugins that use named arguments --- docs/logging.pod | 121 - lib/Qpsmtpd/Plugin.pm | 29

[PATCH 1/2] domainkeys: only register hooks if Mail::DomainKeys is loadable

2012-05-21 Thread Matt Simerson
--- plugins/domainkeys | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/plugins/domainkeys b/plugins/domainkeys index dfd4e8f..5f4b353 100644 --- a/plugins/domainkeys +++ b/plugins/domainkeys @@ -68,7 +68,22 @@ sub init { }; } -sub hook_data_post {

[PATCH 2/2] enable domainkeys plugin by default

2012-05-21 Thread Matt Simerson
The previous commit allows it to be enabled and not blow up if Mail::DomainKeys isn't installed --- config.sample/plugins |1 + 1 file changed, 1 insertion(+) diff --git a/config.sample/plugins b/config.sample/plugins index 0f96bfe..b3d35e2 100644 --- a/config.sample/plugins +++

[PATCH] domainkeys: fix failing tests

2012-05-21 Thread Matt Simerson
the previous DK commit moved the 'use Mail::DomainKeys::*' stuff into an eval. The right idea, but tests still fail because I forgot to remove the bare 'use' lines. --- plugins/domainkeys |3 --- 1 file changed, 3 deletions(-) diff --git a/plugins/domainkeys b/plugins/domainkeys index

[PATCH] make SPF level 2 a little more lenient

2012-05-21 Thread Matt Simerson
--- plugins/sender_permitted_from |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sender_permitted_from b/plugins/sender_permitted_from index 2353493..17805f1 100644 --- a/plugins/sender_permitted_from +++ b/plugins/sender_permitted_from @@ -167,7 +167,7 @@ sub

[PATCH] SMTP: log denial message once (vs twice) at LOGINFO

2012-05-21 Thread Matt Simerson
--- lib/Qpsmtpd/SMTP.pm |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Qpsmtpd/SMTP.pm b/lib/Qpsmtpd/SMTP.pm index 5394646..b426114 100644 --- a/lib/Qpsmtpd/SMTP.pm +++ b/lib/Qpsmtpd/SMTP.pm @@ -451,13 +451,13 @@ sub rcpt_respond { } elsif ($rc ==

[PATCH] removed duplicated test name from test output

2012-05-21 Thread Matt Simerson
, ['b...@example.com'] ), null sender); $address = Qpsmtpd::Address-new( 'matt@' ); $transaction-sender($address); -ok( $self-is_immune( $transaction-sender, ['b...@example.com'] ), is_immune, missing host); +ok( $self-is_immune( $transaction-sender, ['b...@example.com

PATCH: dnsbl, POD tweaks, DENY type tests

2012-05-21 Thread Matt Simerson
` Matt Simerson http://matt.simerson.net/ Systems Engineerhttp://www.theartfarm.com/ The respect of those you respect is worth more than the applause of the multitude. -- Arthur Glasow `

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-21 Thread Matt Simerson
for the questions though. It made me think this through better when you first asked. :-) Matt

[PATCH 2/4] auth_vpopmail_sql test, eval 'use DBI' before testing

2012-05-21 Thread Matt Simerson
--- t/plugin_tests/auth/auth_vpopmail |2 +- t/plugin_tests/auth/auth_vpopmail_sql | 13 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/t/plugin_tests/auth/auth_vpopmail b/t/plugin_tests/auth/auth_vpopmail index 11cbdfa..1c56609 100644 ---

[PATCH 3/4] checkpassword: remove newlines that appeared

2012-05-21 Thread Matt Simerson
--- plugins/auth/auth_checkpassword |1 + 1 file changed, 1 insertion(+) diff --git a/plugins/auth/auth_checkpassword b/plugins/auth/auth_checkpassword index 4f4f9a2..28d7894 100644 --- a/plugins/auth/auth_checkpassword +++ b/plugins/auth/auth_checkpassword @@ -124,6 +124,7 @@ sub

[PATCH 4/4] auth: adding tests (should have attached with a previous commit)

2012-05-21 Thread Matt Simerson
--- t/Test/Qpsmtpd/Plugin.pm | 55 +++--- 1 file changed, 3 insertions(+), 52 deletions(-) diff --git a/t/Test/Qpsmtpd/Plugin.pm b/t/Test/Qpsmtpd/Plugin.pm index 6e7773d..cafa0d0 100644 --- a/t/Test/Qpsmtpd/Plugin.pm +++ b/t/Test/Qpsmtpd/Plugin.pm @@

[PATCH] updated MANIFEST with lots of test files

2012-05-21 Thread Matt Simerson
--- MANIFEST | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/MANIFEST b/MANIFEST index 1a6384b..fbcd358 100644 --- a/MANIFEST +++ b/MANIFEST @@ -1,7 +1,9 @@ .gitignore +.travis.yml Changes config.sample/badhelo config.sample/badmailfrom

[PATCH 01/13] ignore greylisting DB files

2012-05-20 Thread Matt Simerson
(generated during testing) --- .gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 4ddc58c..38803e1 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,8 @@ packaging/rpm/build/ *~ *.bak +denysoft_greylist.dbm +denysoft_greylist.dbm.lock

[PATCH 04/13] earlytalker: many changes

2012-05-20 Thread Matt Simerson
consolidated chunks of code duplicated 4x into log_and_deny and log_and_pass in apr_*_handler subs, return DECLINED when connection is not available to read (like during tests) added 23 tests deprecate action argument 'action log' did nothing, better logging controls available with

[PATCH 06/13] count_unrecognized_commands

2012-05-20 Thread Matt Simerson
simplified logic in a couple places consolidated duplicated message added 4 tests --- plugins/count_unrecognized_commands| 24 - t/plugin_tests/count_unrecognized_commands | 31 2 files changed, 45 insertions(+), 10 deletions(-) create

[PATCH 05/13] connection_time:

2012-05-20 Thread Matt Simerson
had single positional argument for loglevel, switched to named args which inherits the more flexible loglevel shortened logging line before: connection_time: Connection time from 66.118.151.187: 3.046 sec. after:connection_time: 3.046 s. --- plugins/connection_time | 64

[PATCH 08/13] dspam, added 'reject_type disconnect' option

2012-05-20 Thread Matt Simerson
--- plugins/dspam| 28 ++-- t/plugin_tests/dspam | 13 + 2 files changed, 35 insertions(+), 6 deletions(-) diff --git a/plugins/dspam b/plugins/dspam index 84d1d7d..edb7fce 100644 --- a/plugins/dspam +++ b/plugins/dspam @@ -131,12 +131,21 @@ and

[PATCH 07/13] dnsbl, POD tweaks, DENY type tests

2012-05-20 Thread Matt Simerson
consolidated POD at top of file added example options to reject_type POD head added an example loglevel entry consolidated DENY[SOFT|DISCONNECT] logic into get_reject_type added tests for get_reject_type --- plugins/dnsbl| 231 +-

[PATCH 10/13] greylisting: reset transaction for immunity tests

2012-05-20 Thread Matt Simerson
--- t/plugin_tests/greylisting | 13 + 1 file changed, 13 insertions(+) diff --git a/t/plugin_tests/greylisting b/t/plugin_tests/greylisting index 34effe0..f780393 100644 --- a/t/plugin_tests/greylisting +++ b/t/plugin_tests/greylisting @@ -54,8 +54,11 @@ sub test_hook_data { sub

[PATCH 09/13] greylisting, refactored and many changes

2012-05-20 Thread Matt Simerson
for this plugin. See docs/logging.pod -=head1 BUGS =head1 AUTHOR Written by Gavin Carr ga...@openfusion.com.au. -Added p0f section msimer...@cpan.org (2010-05-03) +nfslock feature by JT Moree jtmo...@kahalacorp.com - 2007-01-22 + +p0f feature by Matt Simerson msimer...@cpan.org - 2010-05-03

[PATCH 11/13] make SPF level 2 a little more lenient

2012-05-20 Thread Matt Simerson
--- plugins/sender_permitted_from |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sender_permitted_from b/plugins/sender_permitted_from index 2353493..17805f1 100644 --- a/plugins/sender_permitted_from +++ b/plugins/sender_permitted_from @@ -167,7 +167,7 @@ sub

[PATCH 12/13] greylisting: added note to UPGRADING

2012-05-20 Thread Matt Simerson
--- UPGRADING | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/UPGRADING b/UPGRADING index 58330ac..a81c18f 100644 --- a/UPGRADING +++ b/UPGRADING @@ -3,9 +3,17 @@ When upgrading from: v 0.84 or below +GREYLISTING plugin: 'mode' config argument is deprecated.

[PATCH 13/13] ignore files created during testing

2012-05-20 Thread Matt Simerson
--- .gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 38803e1..7edf28c 100644 --- a/.gitignore +++ b/.gitignore @@ -15,6 +15,8 @@ packaging/rpm/build/ *.bak denysoft_greylist.dbm denysoft_greylist.dbm.lock +greylist.dbm +greylist.dbm.lock

[PATCH 6/7] relay: added POD for loglevel option

2012-05-18 Thread Matt Simerson
for this plugin. See docs/logging.pod + =head1 AUTHOR 2012 - Matt Simerson - Merged check_relay, check_norelay, and relayonly -- 1.7.9.6

[PATCH 4/7] dnsbl: fixed path to docs/logging.pod

2012-05-18 Thread Matt Simerson
--- plugins/dnsbl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/dnsbl b/plugins/dnsbl index 7c2ff71..9832a9c 100644 --- a/plugins/dnsbl +++ b/plugins/dnsbl @@ -250,7 +250,7 @@ the same answer for a short period of time (the minimum DNS cache period). =head2

  1   2   3   4   5   6   7   8   9   >