[quagga-dev 15917] Re: Patchwork updated

DNS changed (Thanks Paul!), Certificate rolled out, TLS now available: https://patchwork.quagga.net/ I'll add a redirect from HTTP to HTTPS after checking if that breaks Martin's CI scripts again ;) Enjoy! -David On Tue, Jul 19, 2016 at 02:34:46PM +0200, David Lamparter wrote: > On Tue, Jul

[quagga-dev 15916] Re: Patchwork updated

On Tue, Jul 19, 2016 at 11:49:06AM +0100, Paul Jakma wrote: > On Tue, 19 Jul 2016, David Lamparter wrote: > > Thanks; the problem there is a different one though - my hosting setup > > has a separate reverse proxy doing all TLS handling; i.e. the > > patchwork setup

[quagga-dev 15914] Re: Patchwork updated

On Tue, Jul 19, 2016 at 11:19:48AM +0100, Paul Jakma wrote: > On Wed, 13 Jul 2016, David Lamparter wrote: > > > I've just installed the most recent version of patchwork; the upgrade > > was a bit bumpy - please report any malfunctions. It looks quite a > > bit differ

[quagga-dev 15901] Patchwork updated

Hi all, I've just installed the most recent version of patchwork; the upgrade was a bit bumpy - please report any malfunctions. It looks quite a bit different since upstream moved to bootstrap for styling, but functionally there isn't much different. There is now also a https URL available at:

[quagga-dev 15877] Re: Time for an experiment? (Was: focus: patchwork drain vs project updates)

On Tue, Jul 05, 2016 at 06:11:19AM -0400, Lou Berger wrote: > On July 5, 2016 3:10:34 AM Vincent JARDIN wrote: > > Le 5 juil. 2016 05:50, "Lou Berger" a écrit : > >> > >> So in thinking about this a bit, perhaps there's something useful that > >> we

[quagga-dev 15815] Re: [PATCH] lib: update Solaris multicast API (BZ#725)

Note my comment doesn't indicate a regression or new breakage, it only notes a caveat: the Solaris OS API doesn't work with unnumbered IPv4. (Maybe the API changed in the meantime - this patch is pretty old...) But considering it didn't work at all before, the patch is still an improvement. I

[quagga-dev 15812] Re: quagga / quagga-capnproto / push to upstream

On Thu, Jun 30, 2016 at 03:53:21PM +0200, Philippe Guibert wrote: > On Thu, Jun 30, 2016 at 9:57 AM, David Lamparter > <da...@opensourcerouting.org> wrote: > > Hello David, > > > I have a rebased/somewhat-cleaned version around, might be more useful > > to look

[quagga-dev 15793] Re: quagga / quagga-capnproto / push to upstream

Hi Philippe, I have a rebased/somewhat-cleaned version around, might be more useful to look at that. It's not fully cleaned up yet, but better than what's currently up there. I'll push it out some time today, will send another email. (Actually started writing docs for capnp...) However - the

[quagga-dev 15619] Re: RFC: plugin (DSO) + hook support

wnwards, but not sideways". Hope this makes sense, -David [*] Except SNMP, that should probably use one of the other interfaces and be out-of-process. > On Tue, Jun 14, 2016 at 1:59 PM, David Lamparter > <equi...@opensourcerouting.org> wrote: > > Hi all, >

[quagga-dev 15549] [PATCH 4/6] bgpd: snmp: use hooks for sending traps

--- bgpd/bgp_fsm.c | 14 +- bgpd/bgp_fsm.h | 4 bgpd/bgp_snmp.c | 11 +++ bgpd/bgp_snmp.h | 3 +++ 4 files changed, 19 insertions(+), 13 deletions(-) diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c index c4cfd58..8b3bb8c 100644 --- a/bgpd/bgp_fsm.c +++ b/bgpd/bgp_fsm.c

[quagga-dev 15551] [PATCH 6/6] build: split off libquaggasnmp

--- bgpd/Makefile.am | 1 + configure.ac | 6 -- lib/Makefile.am| 13 +++-- ospf6d/Makefile.am | 2 +- ospfd/Makefile.am | 2 +- ripd/Makefile.am | 2 +- zebra/Makefile.am | 2 +- 7 files changed, 20 insertions(+), 8 deletions(-) diff --git a/bgpd/Makefile.am

[quagga-dev 15548] [PATCH 3/6] lib: add hook infrastructure

) 2016 David Lamparter, for NetDEF, Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rig

[quagga-dev 15550] [PATCH 5/6] bgpd: snmp: convert into plugin

--- bgpd/Makefile.am | 9 +++-- bgpd/bgp_snmp.c | 24 ++-- bgpd/bgp_snmp.h | 31 --- bgpd/bgpd.c | 9 +++-- bgpd/bgpd.h | 3 +++ 5 files changed, 31 insertions(+), 45 deletions(-) delete mode 100644 bgpd/bgp_snmp.h diff

[quagga-dev 15546] [PATCH 1/6] lib: plugin loading

= rtinfo; + qplug_last = >next; + return rtinfo; + +out_fail: + if (rtinfo->load_args) + XFREE(MTYPE_PLUGIN_LOADARGS, rtinfo->load_args); + XFREE(MTYPE_PLUGIN_LOADNAME, rtinfo->load_name); + return NULL; +} + +void qplug_unload(struct qplu

[quagga-dev 15545] RFC: plugin (DSO) + hook support

Hi all, this series contains support for loading dynamic modules (DSOs) that contain additional functionality. bgpd's SNMP support is the test target. THIS IS AN UNFINISHED VERSION TO INVITE FEEDBACK. In the "big picture", there are some very broad topics that are non-trivial, first and

[quagga-dev 15547] [PATCH 2/6] zebra/bgpd: cmdline-load modules

--- bgpd/bgp_main.c | 17 - zebra/main.c| 17 +++-- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/bgpd/bgp_main.c b/bgpd/bgp_main.c index 25669a0..0ca2b99 100644 --- a/bgpd/bgp_main.c +++ b/bgpd/bgp_main.c @@ -39,6 +39,7 @@ Software Foundation,

[quagga-dev 15521] [PATCH 5/4] lib: linklist: clean up insert-before/after dups

- list_add_node_next was in fact unused - list_add_node_prev performs a subset of listnode_add_before and its only use in isisd replaced with that. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- ;) --- isisd/isis_spf.c | 4 ++-- lib/linklist.c

[quagga-dev 15519] [PATCH 3/4] lib: AgentX: use threads instead of eventloop hack

and is therefore untested. The most useful documentation on this is actually the blog post Vincent Bernat wrote when he originally integrated this into lldpd and Quagga: https://vincent.bernat.im/en/blog/2012-snmp-event-loop.html Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/ag

[quagga-dev 15518] [PATCH 2/4] lib: add thread_add_timer_tv (struct timeval)

Another zoo extension, this adds a timer scheduling function that takes a struct timeval argument (which is actually what the wrappers boil down to, yet it's not exposed...) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/thread.c | 11 +++ lib/thread.

[quagga-dev 15516] SNMP cleanups

Hi all, this is a bunch of cleanups to the SNMP code, in particular removing the somewhat ugly event-loop integration. Unfortunately, it somewhat increases messyness in the linked-list code. It's like sweeping leaves from one corner of the yard into another... then again, I think the uglyness in

[quagga-dev 15517] [PATCH 1/4] lib: linklist: add listnode_add_before()

(), but - supports before == NULL - returns allocated node In general, the entire linked-list implementation is in bad shape, and while it needs a cleanup / rewrite / replacement, this would both cause significant conflicts and block other cleanups... Signed-off-by: David Lamparter <e

[quagga-dev 15382] Re: [PATCH] lib: add skiplists; use for thread sorting by default

management, has been superseded by the following one: commit 4becea724ccd87e88f8454622ae227308b5fa3ce Author: Christian Franke <ch...@opensourcerouting.org> AuthorDate: Tue Nov 19 14:11:42 2013 + Commit: David Lamparter <equi...@opensourcerouting.org> CommitDate: Tue Apr 22

[quagga-dev 15369] bgpd API/CLI cleanups

Hi again, unlike isisd, bgpd has its logic very nicely split from its CLI functions. Still, a few places had (very small) room for improvement :) [Had to fix some rebasing, hope I didn't break stuff...] -David ___ Quagga-dev mailing list

[quagga-dev 15370] [PATCH 3/3] bgpd: ditch unused bgp_node_*() functions

Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_table.h | 38 -- 1 file changed, 38 deletions(-) diff --git a/bgpd/bgp_table.h b/bgpd/bgp_table.h index bee1296..3b4e6cf 100644 --- a/bgpd/bgp_table.h +++ b/bgpd/bgp_table.h @@ -

[quagga-dev 15371] [PATCH 1/3] bgpd: minor header/API clean up

consumers, matches peer->afc) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgpd.c | 13 +++-- bgpd/bgpd.h | 9 + 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c index 249d20f..cadca11 100644 --- a/bgpd/bgpd.

[quagga-dev 15366] [PATCH 6/8] isisd: API: timers (LSP, SPF)

From: Christian Franke <nob...@nowhere.ws> See previous commits... Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- isisd/isis_circuit.c | 24 -- isisd/isis_vty.c | 565 isisd/isisd.c

[quagga-dev 15364] [PATCH 7/8] isisd: API: area (L1), domain (L2) passwords

From: Christian Franke <nob...@nowhere.ws> Last isisd CLI cleanup for now. This also folds L1 & L2 configs into common functions, reducing CLI function bloat by a bit. (This patch contains changes authored by both Christian Franke and David Lamparter.) Signed-off-by: David Lampa

[quagga-dev 15362] [PATCH 3/8] isisd: API: circuit password

From: Christian Franke <nob...@nowhere.ws> This cleans up circuit password configuration a little bit. (Restructured several times by both Christian Franke and David Lamparter.) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- isisd/isis_ci

[quagga-dev 15361] [PATCH 2/8] isisd: API: basic area config

From: Christian Franke <nob...@nowhere.ws> Move out basic area configuration (metric type, overload and attachment bits, dynamic hostname extension enable) into isis_vty.c. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- isisd/i

[quagga-dev 15347] Re: OSPF SPF config knob

, Paul Jakma wrote: > On Fri, 20 May 2016, David Lamparter wrote: > > The event most likely to change my opinion on this is being presented > > with an actual real-world setup that sees breakage from this. From > > the way this bug works, I guess it'd need to be a Quagga-only

[quagga-dev 15344] Re: OSPF SPF config knob

Btw: Donald -- this patch is very early in the Cumulus tree; I assume it's been part of previous stable releases that are in active use at customer installations? Have you received any reports of breakage? -David On Fri, May 20, 2016 at 04:37:37PM +0200, David Lamparter wrote: > On Fri,

[quagga-dev 15343] Re: OSPF SPF config knob

On Fri, May 20, 2016 at 02:12:51PM +0100, Paul Jakma wrote: > Could we agree that at a minimum there needs to be a config knob, so > admins can at least manage rolling out updates without introducing > mixed-environments? I haven't seen any technical argument that led me to change my opinion on

[quagga-dev 15197] Re: plan for 8?

Hiya, so, having taked to Donald, I believe I'm supposed to do /8. I've suggested taking the cumulus patchset whole and pack the entire thing on 8/proposed, have people test and fix issues on top, and then merge it. Is that reasonable? -David On Thu, Apr 28, 2016 at 08:33:42AM -0400, Lou

[quagga-dev 15115] Re: [PATCH] ospfd: stub-router "allow transit" option and add "Host" option support

On Thu, Apr 21, 2016 at 12:33:50PM +0100, Paul Jakma wrote: > The previous patch clearly is incomplete, based on the concerns of those > proposing it and further analysis. Your review of the next patch seems > to be missing some of the issues, while restating the issue driving this > that makes

[quagga-dev 15067] Re: [PATCH] ospfd: stub-router "allow transit" option and add "Host" option support

On Tue, Apr 19, 2016 at 04:10:04PM +0200, David Lamparter wrote: > The default state of this seems to be "infinite", which is not > RFC-compilant behaviour. There was unanimous consent in the monthly > meeting that RFC-compliant behaviour should be the default. s/consent/conse

[quagga-dev 15066] Re: [PATCH] ospfd: stub-router "allow transit" option and add "Host" option support

On Tue, Apr 12, 2016 at 12:58:44PM +0100, Paul Jakma wrote: > - Makes the SPF behaviour configurable with a > > "compatible max-metric (infinite|follow)" The default state of this seems to be "infinite", which is not RFC-compilant behaviour. There was unanimous consent in the monthly

[quagga-dev 14964] Re: [PATCH 00/89] Cumulus Take-3 Electric Bugaloooooooooooooooo

Hi y'all, with Easter having passed - what's the status / next steps on this? Thanks, -David On Fri, Dec 11, 2015 at 06:50:44PM -0500, Donald Sharp wrote: [cut] ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net

[quagga-dev 14961] Re: Python Client (was: Quaxolotl (Cap'n Proto interface) slides)

On Tue, Mar 15, 2016 at 04:19:19PM +0100, David Lamparter wrote: > you can find the slides for the presentation I just gave at the monthly > meeting up at this URL: > https://aurora.nox.tf/tmp/quaxolotl_20160315.pdf > (will probably repost them somewhere else with a more permanent UR

[quagga-dev 14948] Re: [PATCH 00/89] Cumulus Take-3 Electric Bugaloooooooooooooooo

On Thu, Mar 17, 2016 at 08:29:34AM +, Paul Jakma wrote: > On Wed, 16 Mar 2016, Donald Sharp wrote: > > Without this patch when I set 'max-metric router-lsa administrative' on a > > switch, it is no longer considered as part of the spf calculation for > > routes. > > > > Suppose I have > > > >

[quagga-dev 14936] handling of "security" issues

Hi all, in the monthly meeting that just ended, there was a bit about security patches and their handling; I promised to send a mail elaborating on it further. In short, I believe there are 2 things that can be improved here: - raising the bar on what constitutes a security-critical fix - not

[quagga-dev 14935] Re: Proposal for how to improve patch pipeline

Sounds good to me. -David On Thu, Mar 10, 2016 at 10:33:09AM -0500, Donald Sharp wrote: > Problem statement: > > Patches can be in an unaccepted stated for a long time while the current > proposed branch is in a frozen state in order to get it ready for release. > This causes problems for the

[quagga-dev 14934] Quaxolotl (Cap'n Proto interface) slides

Hi all, you can find the slides for the presentation I just gave at the monthly meeting up at this URL: https://aurora.nox.tf/tmp/quaxolotl_20160315.pdf (will probably repost them somewhere else with a more permanent URL) I'll check into pushing the code out to github or so, expect another mail

[quagga-dev 14932] Re: Monthly Quagga Meeting

On Thu, Mar 10, 2016 at 10:46:45AM -0500, Donald Sharp wrote: > 1) Proposed branching scheme, sent under cover of another email > 2) Call for more gatekeepers. Please self nominate! I guess I'm available to try and share some of Donald's workload. Let's check the details in Hangout. -David

[quagga-dev 14930] Re: [PATCH 1/6] Add support for protobuf.

My API presentation tomorrow includes a section on why we choose Cap'n Proto and why it is better than Protobuf ;) The biggest argument is: > > - Library routines for working with protobuf, including functions > > that help translate between common quagga types and their protobuf > >

[quagga-dev 14928] Re: [PATCH 5/6] vtysh: support for invoking functions by name

On Mon, Mar 14, 2016 at 09:32:34AM -0700, Avneesh Sachdev wrote: > It looks like we agree that: > > - test functions should be easier to write. > > - test code should not be part of a production build (whether via > conditional compilation or separate binaries). > > Given the above, why not

[quagga-dev 14929] Re: [PATCH 5/6] vtysh: support for invoking functions by name

On Sun, Mar 13, 2016 at 06:29:22PM -0700, Avneesh Sachdev wrote: > On Sun, Mar 13, 2016 at 1:04 PM, Donald Sharp > wrote: > > Can you expand a bit on why adding the ability to call random functions > > from the cli is better than just adding a 'test XXX' function as

[quagga-dev 14910] [PATCH] lib: fix MIN/MAX macros to not double-eval

cf. https://gcc.gnu.org/onlinedocs/gcc/Typeof.html (Works on all compilers on Quagga's compiler support list in doc/overview.texi) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- Would suggest this additional fix to make the macro less surprising. -David --- lib/zebra.

[quagga-dev 14907] [PATCH] lib: fix MIN/MAX macros to not double-eval

cf. https://gcc.gnu.org/onlinedocs/gcc/Typeof.html (Works on all compilers on Quagga's compiler support list in doc/overview.texi) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- Would suggest this additional fix to make the macro less surprising. -David --- lib/zebra.

[quagga-dev 14844] Re: XR-Like Commit Feature

akma wrote: > On Thu, 3 Mar 2016, Paul Jakma wrote: > > On Thu, 3 Mar 2016, David Lamparter wrote: > > > >> As for this discussion, the approach that seemed most fruitful in my view > >> was to push transaction functionality outside of Quagga. There's no > >

[quagga-dev 14816] Re: XR-Like Commit Feature

On Wed, Mar 02, 2016 at 06:09:45PM +, Paul Jakma wrote: > On Wed, 2 Mar 2016, Paul Jakma wrote: > > > Someone mentioned Vyatta had done some work in this area. I think Cumulus > > might have done some work on other interfaces into things too, but I'm not > >

[quagga-dev 14814] Re: [PATCH 10/10] build: goodbye, gawk

You could just change Makefile.am to call extract.pl as argument to perl, as in: - ./$(EXTRA_DIST) $(vtysh_cmd_FILES) > vtysh_cmd.c + $(PERL) ./$(EXTRA_DIST) $(vtysh_cmd_FILES) > vtysh_cmd.c (On a random sidenote, it's really ugly to use $(EXTRA_DIST) like that...) On Thu, Mar 03,

[quagga-dev 14815] Re: [PATCH 10/10] build: goodbye, gawk

On Wed, Mar 02, 2016 at 08:38:05PM -0500, Donald Sharp wrote: > On a side note, extract.pl.in as far as I can tell only is used to auto > generate the perl binary location. Hadn't looked at this before sending my previous e-mail, but - it actually uses more than the perl binary location: line

[quagga-dev 14799] Re: CI Testresult: FAILED (Re: [quagga-dev, 14785, 10/10] build: goodbye, gawk)

On Fri, Feb 26, 2016 at 03:02:56AM -0800, Martin Winter wrote: > > Building Stage: Failed > > > > CentOS6 amd64 build: Successful > > Ubuntu1204 amd64 build: Successful > > NetBSD7 amd64 build: Successful > > FreeBSD10 amd64 build: Successful > > OmniOS amd64 build: Successful > >

[quagga-dev 14787] [PATCH 04/10] lib: migrate to new memory-type handling

Move over to the new allocation counting added in the previous commit. (This commit is mostly mechanical.) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Acked-by: Vincent JARDIN <vincent.jar...@6wind.com> --- bgpd/bgp_main.c | 1 + bg

[quagga-dev 14788] [PATCH 05/10] *: split & distribute memtypes

t. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Acked-by: Vincent JARDIN <vincent.jar...@6wind.com> Acked-by: Donald Sharp <sha...@cumulusnetworks.com> --- bgpd/Makefile.am | 2 + bgpd/bgp_community.c | 1 + bgpd/bgp_memory.c| 99 ++

[quagga-dev 14786] [PATCH 02/10] lib: move memory.[ch] out of the way

The following commit will recreate memory.[ch]. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Acked-by: Vincent JARDIN <vincent.jar...@6wind.com> Acked-by: Donald Sharp <sha...@cumulusnetworks.com> --- lib/Makefile.am | 8 +- lib/

[quagga-dev 14781] [PATCH 09/10] build: goodbye, memtypes.c

Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Acked-by: Vincent JARDIN <vincent.jar...@6wind.com> Acked-by: Donald Sharp <sha...@cumulusnetworks.com> --- lib/.gitignore | 1 - lib/Makefile.am | 10 +++--- lib/memtypes.c | 16 lib/memtypes

[quagga-dev 14785] [PATCH 10/10] build: goodbye, gawk

Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Acked-by: Vincent JARDIN <vincent.jar...@6wind.com> Acked-by: Donald Sharp <sha...@cumulusnetworks.com> --- INSTALL.quagga.txt | 1 - configure.ac | 6 -- 2 files changed, 7 deletions(-) diff --git a/IN

[quagga-dev 14780] [v2] scrap & rewrite memtypes handling

Hi all, this is the rebased version of this series, now applying on ca52365 "FreeBSD Bug: Zebra not deleting routes" I've also removed the "#if 0" macro branch and fixed remaining coding style issues I could find. As these changes are whitespace to the C compiler, I've taken the liberty of

[quagga-dev 14783] [PATCH 03/10] lib: add new extensible memory-type handling

This rewrites Quagga's memory per-type allocation counting, without using a fixed global list of types. Instead, source files can declare memory types which get handled through constructor functions called by the dynamic linker during startup. Signed-off-by: David Lamparter <e

[quagga-dev 14782] [PATCH 06/10] *: stop (re|ab)using lib/ MTYPEs

bgpd, ospf6d, isisd and some tests were reusing MTYPEs defined in the library for its own use. This is bad practice and will break with the later commit making the library's MTYPEs static. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Acked-by: Vincent JARDIN <vi

[quagga-dev 14779] [PATCH 08/10] lib: clean/restore memory debugging functions

This adapts the dump-at-exit handler and removes the old leftover code. (Note the text in log_memtype_stderr was actually incorrect as the only caller in bgpd cleans up configuration before calling it, i.e. any remaining allocations are missing-cleanup bugs.) Signed-off-by: David Lamparter <e

[quagga-dev 14770] Re: [PATCH 04/10] lib: migrate to new memory-type handling

On Wed, Feb 24, 2016 at 06:25:06PM -0500, Donald Sharp wrote: > I'm not a big fan of #if 0 or #if 1's introduced with this patch. Is there > someway we can mitigate them? This is what the comments from Paul & myself in the other mail referred to: > Paul: > > - The

[quagga-dev 14761] Mailing list snafu?

Apologies if you received (or will receive) duplicates of my messages. Something seems to be wrong with the mailing list; it lost 3 of my messages today... can somebody investigate? Message-ID: <20160224090742.GA873456@eidolon> Message-ID: <20160224120905.GB873456@eidolon> Message-ID:

[quagga-dev 14759] Re: [PATCH 03/10] lib: add new extensible memory-type handling

On Wed, Feb 24, 2016 at 11:58:42AM +, Paul Jakma wrote: > - This seems to require various extensions to work, some seem to be GCC >specific? It's specific to the "GCC-like group". I have tested on: Linux clang 3.6.1 Linux icc 14.0.3 Linux gcc 4.9.3 Linux gcc 4.7.4 Linux gcc 4.2.4 Linux

[quagga-dev 14758] Re: CI Testresult: FAILED (Re: [quagga-dev, 14741, 10/10] build: goodbye, gawk)

On Wed, Feb 24, 2016 at 01:00:03AM -0800, cisys...@netdef.org wrote: > Continous Integration Result: FAILED [...] > Tested on top of Git : eae18d1 (as of 20151209.135437 UTC) As mentioned in the original mail, this patchset applies on top of "lib: fix vrf_bitmap leak in zclient_free()", not

[quagga-dev 14742] [PATCH 07/10] lib: distribute mtypes into files

This places MTYPE definitions into the files where they're actually used, making most of them static in the process. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/buffer.c | 3 ++- lib/command.c | 4 lib/command.h | 6 + lib/distribute.c

[quagga-dev 14743] [PATCH 05/10] *: split & distribute memtypes

t. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/Makefile.am | 2 + bgpd/bgp_community.c | 1 + bgpd/bgp_memory.c| 99 bgpd/bgp_memory.h| 95 bgpd/bgpd.h | 1 + i

[quagga-dev 14739] [PATCH 04/10] lib: migrate to new memory-type handling

Move over to the new allocation counting added in the previous commit. (This commit is mostly mechanical.) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_main.c | 1 + bgpd/bgp_vty.c | 1 + isisd/isis_main.c | 1 +

[quagga-dev 14740] [PATCH 09/10] build: goodbye, memtypes.c

Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/.gitignore | 1 - lib/Makefile.am | 10 +++--- lib/memtypes.c | 16 lib/memtypes.pl | 6 -- 4 files changed, 3 insertions(+), 30 deletions(-) delete mode 100644 lib/memtypes.c delete mode

[quagga-dev 14741] [PATCH 10/10] build: goodbye, gawk

Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- INSTALL.quagga.txt | 1 - configure.ac | 6 -- 2 files changed, 7 deletions(-) diff --git a/INSTALL.quagga.txt b/INSTALL.quagga.txt index 11c85b1..b414d94 100644 --- a/INSTALL.quagga.txt +++ b/INSTALL.quag

[quagga-dev 14738] [PATCH 06/10] *: stop (re|ab)using lib/ MTYPEs

bgpd, ospf6d, isisd and some tests were reusing MTYPEs defined in the library for its own use. This is bad practice and will break with the later commit making the library's MTYPEs static. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_nexthop.c

[quagga-dev 14736] [PATCH 03/10] lib: add new extensible memory-type handling

This rewrites Quagga's memory per-type allocation counting, without using a fixed global list of types. Instead, source files can declare memory types which get handled through constructor functions called by the dynamic linker during startup. Signed-off-by: David Lamparter <e

[quagga-dev 14737] [PATCH 08/10] lib: clean/restore memory debugging functions

This adapts the dump-at-exit handler and removes the old leftover code. (Note the text in log_memtype_stderr was actually incorrect as the only caller in bgpd cleans up configuration before calling it, i.e. any remaining allocations are missing-cleanup bugs.) Signed-off-by: David Lamparter <e

[quagga-dev 14733] scrap & rewrite memtypes handling

Hi quagga-dev, this patchset replaces the 1990s-era memory allocation tracking with a 2010s-era memory allocation tracking. Particularly, it removes the neccessity to maintain a centralised list of MTYPEs in the library. Daemons can now just define their own MTYPEs on the fly, with per-file

[quagga-dev 14735] [PATCH 02/10] lib: move memory.[ch] out of the way

The following commit will recreate memory.[ch]. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/Makefile.am | 8 +- lib/memory.c | 486 --- lib/memory.h | 98 +-- lib/memory_vty.c

[quagga-dev 14685] assorted fixes

Hi quagga-dev, this is a set of 3 random-cleanup patches fixing things I stumbled upon while doing other work. -David ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 14687] [PATCH 2/3] isisd: fix assert warning

fix (for all places where the code needs to abort due to internal errors). Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- isisd/isis_redist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/isisd/isis_redist.c b/isisd/isis_redist.c index abb9ecd..552613a 100644 --- a

[quagga-dev 14686] [PATCH 1/3] lib: fix vrf_bitmap leak in zclient_free()

zclient_stop(), which is used as antagonist to zclient_init(), needs to undo the vrf_bitmap allocation. Otherwise zclient_init() will leak the allocated memory, for example when zclient_reset() is used. Reported-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter

[quagga-dev 14688] [PATCH 3/3] build/pimd: remove special shell scripts

Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- pimd/git-clone-github.sh | 27 --- pimd/git-clone-savannah.sh| 27 --- pimd/quagga-bootstrap.sh | 23 --- pimd/quagga-build-no-vt

[quagga-dev 13991] Re: cleaning up commands (was Re: BGP 'view' to 'vrf')

On Tue, Nov 24, 2015 at 11:45:27AM -0500, Lou Berger wrote: > On 11/24/2015 9:06 AM, Vincent JARDIN wrote: > > On 24/11/2015 14:38, Paul Jakma wrote: > >> So the things we need to consider: > >> > >> - Existing CLI > >> - SNMP > >> - YANG > >> - OVSDB > >> - > > - bson/json > > - XML/binary XML

[quagga-dev 13995] Re: cleaning up commands (was Re: BGP 'view' to 'vrf')

On Wed, Nov 25, 2015 at 05:15:27PM +0100, Vincent JARDIN wrote: > On 25/11/2015 16:32, David Lamparter wrote: > > That > > component could either be in-process (using something like Swig or > > Cython to access C memory structures) or external (using some wrapping > >

[quagga-dev 12692] Re: v1 - Patchwork ack't patches

On Wed, Jun 10, 2015 at 10:16:59AM +0200, Vincent JARDIN wrote: Honestly though I don't know how to read the patchwork.quagga.net http://patchwork.quagga.net. It has hundreds of patches that are years old, what applies anymore and what doesn't apply? I agree that we should start dropping

[quagga-dev 12694] Re: v1 - Patchwork ack't patches

On Wed, Jun 10, 2015 at 12:36:39PM +0200, Vincent JARDIN wrote: On 10/06/2015 12:35, David Lamparter wrote: If you just send an Ack to a year-old patch, they won't know what the Ack is for... +1, you are right. I've changed the styling on patchwork to make any patch older than 100 days

[quagga-dev 12605] [PATCH] zebra: fix VRF code for *BSD

There seems to be no rtm_table in struct rt_msghdr, at least on the systems I have access to... Signed-off-by: David Lamparter equi...@opensourcerouting.org --- first of a few BSD issues, but this one I got around to fixing before I ran out of time... --- zebra/kernel_socket.c | 2 +- 1 file

[quagga-dev 12588] Re: [PATCH v3 00/22] VRF support in quagga

On Mon, Jun 01, 2015 at 03:37:33PM +0100, Paul Jakma wrote: On Sun, 31 May 2015, David Lamparter wrote: As such, I'd mark the entire field as experimental (i.e. we won't care about API or CLI breakage for VRFs), and let the bright people on this list apply their engineering chops

[quagga-dev 12573] Re: [PATCH v3 00/22] VRF support in quagga

On Sat, May 30, 2015 at 09:34:04AM +0100, Paul Jakma wrote: On Fri, 29 May 2015, Lennart Sorensen wrote: multiple VRFs but can also be run as multiple processes would make everyone happy, although it does mean there are two ways of running things that would have to be supported in the

[quagga-dev 12575] Re: [PATCH v3 00/22] VRF support in quagga

On Sat, May 30, 2015 at 02:32:36PM +0100, Paul Jakma wrote: On Sat, 30 May 2015, David Lamparter wrote: Upfront was half a year ago... and we have users that would like to start meshing with this. [http://patchwork.quagga.net/patch/952/] I don't see the VRF design discussion or multi v

[quagga-dev 12570] Re: [PATCH 2/4] lib: make prefix2str simpler to use, and use it in zclient

On Sat, May 23, 2015 at 11:08:39AM +0300, Timo Teräs wrote: Add also PREFIX_STRLEN to be the generic buffer length required for any prefix string representation. [...] +/* Maximum prefix string length (IPv6) */ +#define PREFIX_STRLEN 51 How do you get 51? 8*4 + 7 + 1 + 3 + 1 = 44? hex :

[quagga-dev 12514] Re: [PATCH v3 00/22] VRF support in quagga

On Wed, May 27, 2015 at 12:11:52PM +0200, Vincent JARDIN wrote: Until now, I did prefer to stay quite to avoid confusions. 1- I understand that there is a consensus on this contribution (both approaches Single Daemon and Multi Daemon make sense and can coexist), 2- my review of the code

[quagga-dev 12517] Re: [PATCH 2/2] lib/privs: Don't use CAP_NET_BROADCAST

On Wed, May 13, 2015 at 01:59:18PM +0200, Christian Franke wrote: From what I can tell, CAP_NET_BROADCAST has never been required for any functionality in the Linux kernel, so we do not really need it. Both patches applied, thanks! -David ___

[quagga-dev 12519] Re: [PATCH] lib/sockunion.c wrong #define used

On Wed, May 13, 2015 at 08:34:46PM -0400, Donald Sharp wrote: The #define IPV6_MINHOPCNT define is never defined on any unix platform. From what I can tell the original implementation on the linux platform was IPV6_MINHOPCNT, when it got accepted into the mainstream kernel it was transformed

[quagga-dev 12520] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

On Wed, May 27, 2015 at 05:21:52PM +0100, Paul Jakma wrote: So something like the below to go before your patch (probably a good few of the types could be removed - I removed the ones that seemed obviously defunct to me (EcoNet, Chaos, the Linux Prism driver type), probably a good few more,

[quagga-dev 12500] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

On Tue, May 26, 2015 at 10:27:54PM +0100, Paul Jakma wrote: On Tue, 26 May 2015, David Lamparter wrote: The simple choice is using it as-is :) It's not that hard, I'll send something tomorrow. What'd really help is a if_gethwaddr() function in lib/if.c, because in isisd/isis_circuit.c:602

[quagga-dev 12502] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

On Wed, May 27, 2015 at 09:56:03AM +0300, Timo Teras wrote: On Wed, 27 May 2015 08:49:02 +0200 David Lamparter da...@opensourcerouting.org wrote: On Tue, May 26, 2015 at 10:27:54PM +0100, Paul Jakma wrote: On Tue, 26 May 2015, David Lamparter wrote: The simple choice is using

[quagga-dev 12495] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

On Tue, May 26, 2015 at 02:58:54PM +0300, Timo Teras wrote: On Tue, 26 May 2015 12:44:06 +0100 (BST) Paul Jakma p...@jakma.org wrote: On Tue, 26 May 2015, Paul Jakma wrote: Anything sensible would probably do. This is for the link-layer header type? libpcap might have useful

[quagga-dev 12494] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

On Tue, May 26, 2015 at 12:44:06PM +0100, Paul Jakma wrote: On Tue, 26 May 2015, Paul Jakma wrote: Anything sensible would probably do. This is for the link-layer header type? libpcap might have useful headers on this, maybe. Adding a dependency on libpcap just to get an enum seems

[quagga-dev 12457] Re: [PATCH] babeld: cleanup the whole code

On Fri, May 22, 2015 at 10:22:40AM +0200, Nicolas Dichtel wrote: babeld is gone in commit 336724d628be, let's remove all related code. Note that this patch fixes vtysh, which cannot start after this commit: $ vtysh Command node 17 doesn't exist, please check it Actually, I broke that in

[quagga-dev 12448] Re: Quagga legal fund

On Fri, May 22, 2015 at 04:58:20PM +0100, Paul Jakma wrote: On Fri, 22 May 2015, David Lamparter wrote: If anyone feels like helping me to cover the costs of this legal advice ^^ to the Quagga project, I'd welcome it. Neither the advice nor the cost

[quagga-dev 12446] Re: Quagga legal fund

On Fri, May 22, 2015 at 04:48:37PM +0100, Paul Jakma wrote: On Fri, 22 May 2015, Paul Jakma wrote: I have that advice in written up form now. Oh, and the solicitor concerned did the work for about half-cost (maybe even a bit more towards quarter cost - I'm not quite sure what their

  1   2   >